newsletter 3.0.2 → 3.2.0

data/spec/test_app/config/routes.rb

@@ -1,4 +1,3 @@
 Rails.application.routes.draw do
-
-  mount Newsletter::Engine => "/newsletter"
+  mount Newsletter::Engine => "/newsletter", as: :news
 end

data/spec/test_app/db/migrate/20131222171230_create_users.rb

@@ -0,0 +1,13 @@
+class CreateUsers < ActiveRecord::Migration
+  def change
+    create_table :users do |t|
+      t.string :first_name
+      t.string :last_name
+      t.string :email
+      t.string :phone
+
+      t.timestamps
+    end
+    add_index :users, :email, :unique => true
+  end
+end

data/spec/test_app/db/schema.rb

@@ -11,7 +11,7 @@
 #
 # It's strongly recommended to check this file into your version control system.
 
-ActiveRecord::Schema.define(:version => 20131222171229) do
+ActiveRecord::Schema.define(:version => 20150414102034) do
 
   create_table "news_areas", :force => true do |t|
     t.string   "name",        :null => false
@@ -31,7 +31,7 @@ ActiveRecord::Schema.define(:version => 20131222171229) do
   create_table "news_assets", :force => true do |t|
     t.integer  "field_id"
     t.integer  "piece_id"
-    t.string   "filename"
+    t.string   "image"
     t.string   "content_type"
     t.integer  "size"
     t.integer  "width"
@@ -113,4 +113,15 @@ ActiveRecord::Schema.define(:version => 20131222171229) do
     t.datetime "updated_at",    :null => false
   end
 
+  create_table "users", :force => true do |t|
+    t.string   "first_name"
+    t.string   "last_name"
+    t.string   "email"
+    t.string   "phone"
+    t.datetime "created_at", :null => false
+    t.datetime "updated_at", :null => false
+  end
+
+  add_index "users", ["email"], :name => "index_users_on_email", :unique => true
+
 end

data/spec/test_app/features/newsletter_management.feature

@@ -0,0 +1,39 @@
+Feature: Newsletter Management
+  In order to create newsletters
+  As a valid user
+  I want to create, modify, and publish newsletters
+
+  Background:
+    Given I am logged in and authorized for everything 
+      And a design named "Bobo's Design" exists
+  
+  Scenario: Create a new newsletter
+    When I go to the newsletters page
+     And I follow "New Newsletter"
+     And I fill in "Name" with "Bobo's first Newsletter"
+     And I press "Save"
+    Then a newsletter named "Bobo's first Newsletter" should exist
+     And that newsletter should have the design named "Bobo's Design"
+    
+  Scenario: Edit a newsletter
+   Given a newsletter named "Bobo's first Newsletter" exists
+    When I go to the newsletters page
+     And I follow "Edit"
+     And I fill in "Name" with "Bobo's Great Newsletter"
+     And I press "Save"
+    Then a newsletter named "Bobo's Great Newsletter" should exist
+
+  Scenario: View a newsletter on the archive page
+   Given a newsletter named "Bobo's first Newsletter" exists
+    When I go to the newsletters page
+     And I follow "Publish"
+     And I go to the newsletter archive page
+     And I follow "Bobo's first Newsletter"
+    Then I should see "Bobo's first Newsletter"
+
+  Scenario: Newsletters have pagination
+   Given 50 newsletters exist
+    When I go to the newsletters page
+    Then I should see "Previous"
+     And I should see "Next"
+    When I follow "Next"

data/spec/test_app/features/piece_management.feature

@@ -0,0 +1,20 @@
+Feature: Piece Management
+  In order to add content to newsletters
+  As a valid user
+  I want to create, modify, delete pieces
+
+  Background:
+    Given I am logged in and authorized for everything 
+      And a design named "Bobo's Design" exists
+      And a newsletter named "Bobo's Newsletter" exists with design named "Bobo's Design"
+
+  Scenario: Add an inline asset piece with a url
+    When I go to the newsletters page
+     And I follow "Edit"
+     And I select to add a "Left Column Image" from the "Left column" area
+     And I press the "Left column" area's "Add Element" button
+    Then I should be on newsletter named "Bobo's Newsletter"'s new piece page
+     And I fill in "Url:" with "http://www.google.com/favicon.ico"
+     And I press "Submit"
+    Then a "Left Column Image" should exist in "Bobo's Newsletter"'s "Left Column" are with an "image" url of "http://www.google.com/favicon.ico"
+

data/spec/test_app/features/step_definitions/debugging_steps.rb

@@ -0,0 +1,3 @@
+When /I debug/ do
+  binding.pry
+end

data/spec/test_app/features/step_definitions/design_steps.rb

@@ -0,0 +1,3 @@
+Given(/^a design named "(.*?)" exists$/) do |name|
+  import_design(nil,name)
+end

data/spec/test_app/features/step_definitions/login_steps.rb

@@ -0,0 +1,4 @@
+Given(/^I am logged in and authorized for everything$/) do
+  @user = FactoryGirl.create(:user, last_name: "the_admin")
+end
+

data/spec/test_app/features/step_definitions/newsletter_steps.rb

@@ -0,0 +1,24 @@
+Then(/^a newsletter named "(.*?)" should exist$/) do |name|
+  @newsletter = Newsletter::Newsletter.where(name: name).first
+  expect(@newsletter).not_to be nil
+end
+
+Then(/^that newsletter should have the design named "(.*?)"$/) do |name|
+  expect(@newsletter.design.name).to eq name
+end
+
+Given(/^a newsletter named "(.*?)" exists$/) do |name|
+  design = import_design
+  FactoryGirl.create(:newsletter, name: name, design: design) 
+end
+
+Given(/^a newsletter named "(.*?)" exists with design named "(.*?)"$/) do |news_name, design_name|
+  design = Newsletter::Design.where(name: design_name).first
+  FactoryGirl.create(:newsletter, name: news_name, design: design)
+end
+
+Given(/^(\d+) newsletters exist$/) do |count|
+  design = import_design(nil,Faker::Company.bs)
+  count.to_i.times{FactoryGirl.create(:newsletter, design: design)}
+end
+

data/spec/test_app/features/step_definitions/piece_steps.rb

@@ -0,0 +1,26 @@
+When(/^I select to add a "(.*?)" from the "(.*?)" area$/) do |element_name, area_name|
+  area = Newsletter::Area.where(name: area_name.downcase.gsub(/ /,'_')).first 
+  within(:css,"#add_element_for_area_#{area.id}") do
+    step %Q|I select "#{element_name}" from "Area: #{area.name.humanize}"|
+  end
+end
+
+When(/^I press the "(.*?)" area's "(.*?)" button$/) do |area_name, add_element|
+  area = Newsletter::Area.where(name: area_name.downcase.gsub(/ /,'_')).first 
+  within(:css,"#add_element_for_area_#{area.id}") do
+    step %Q|I press "Add Element"|
+  end
+end
+
+Then(/^a "(.*?)" should exist in "(.*?)"'s "(.*?)" are with an? "(.*)" ([^"]+) of "(.*?)"$/) do |element_name, newsletter_name, area_name, field_name, method, value|
+  newsletter = Newsletter::Newsletter.where(name: newsletter_name).last
+  area = newsletter.areas.detect{|a| a.name.eql?(underscore(area_name))}
+  element = area.elements.detect{|e| e.name.eql?(element_name)}
+  expect(newsletter.pieces.detect{|piece|
+    piece.area == area && piece.element == element &&
+    piece.locals[field_name.to_sym].send(method) == value
+  }).not_to be nil
+end
+
+
+

data/{features → spec/test_app/features}/step_definitions/webrat_steps.rb

@@ -4,11 +4,11 @@ require File.expand_path(File.join(File.dirname(__FILE__), "..", "support", "pat
 # http://github.com/brynary/webrat
 
 Given /^I am on (.+)$/ do |page_name|
-  visit path_to(page_name)
+  visit path_to(page_name,news)
 end
 
 When /^I go to (.+)$/ do |page_name|
-  visit path_to(page_name)
+  visit path_to(page_name,news)
 end
 
 When /^I press "([^\"]*)"$/ do |button|
@@ -16,13 +16,17 @@ When /^I press "([^\"]*)"$/ do |button|
 end
 
 When /^I follow "([^\"]*)"$/ do |link|
-  click_link(link)
+  click_link(link, match: :first)
 end
 
 When /^I fill in "([^\"]*)" with "([^\"]*)"$/ do |field, value|
   fill_in(field, :with => value) 
 end
 
+Then(/^I fill in "(.*?)" with the file "(.*?)"$/) do |field_name, filename|
+  fill_in field_name, with: "file://spec/support/files/#{filename}" 
+end
+
 When /^I select "([^\"]*)" from "([^\"]*)"$/ do |value, field|
   select(value, :from => field) 
 end
@@ -91,11 +95,11 @@ When /^I attach the file at "([^\"]*)" to "([^\"]*)"$/ do |path, field|
 end
 
 Then /^I should see "([^\"]*)"$/ do |text|
-  response.should contain(text)
+  expect(page.body).to have_content(text)
 end
 
 Then /^I should not see "([^\"]*)"$/ do |text|
-  response.should_not contain(text)
+  expect(page.body).not_to have_content(text)
 end
 
 Then /^the "([^\"]*)" field should contain "([^\"]*)"$/ do |field, value|
@@ -111,5 +115,5 @@ Then /^the "([^\"]*)" checkbox should be checked$/ do |label|
 end
 
 Then /^I should be on (.+)$/ do |page_name|
-  URI.parse(current_url).path.should == path_to(page_name)
+  URI.parse(current_url).path.should == path_to(page_name,news)
 end

data/spec/test_app/features/support/env.rb

@@ -4,7 +4,41 @@
 # instead of editing this one. Cucumber will automatically load all features/**/*.rb
 # files.
 
+require 'simplecov'
+pwd = File.expand_path( File.dirname(__FILE__) )
+SimpleCov.root(File.join(pwd,'..','..','..','..'))
+SimpleCov.command_name 'cucumber-' + ENV['DBADAPTER'].to_s
+SimpleCov.start('rails') do
+  adapters.delete(:root_filter)
+  add_filter do |src|
+    !(src.filename =~ /^#{SimpleCov.root}/)
+  end
+  add_filter do |src|
+    src.filename =~ /test_app/
+  end
+end
 require 'cucumber/rails'
+require 'factory_girl_rails'
+
+require 'capybara/poltergeist'
+require 'capybara/rspec'
+require 'capybara/rails'
+require File.join(pwd,'..','..',"lib","debugging")
+#require 'rack_session_access/capybara'
+Capybara.server_port = Newsletter.site_url.split(/:/).last
+Capybara.app_host = Newsletter.site_url
+
+Capybara.default_driver = :rack_test
+Capybara.register_driver :poltergeist do |app|
+  options = {
+    inspector: 'open',
+    debug: false,
+    phantomjs_options: ['--load-images=no', '--ignore-ssl-errors=yes'],
+    js_errors: false
+  }
+  Capybara::Poltergeist::Driver.new(app, options)
+end
+Capybara.javascript_driver = :poltergeist
 
 # Capybara defaults to CSS3 selectors rather than XPath.
 # If you'd prefer to use XPath, just uncomment this line and adjust any
@@ -27,6 +61,8 @@ require 'cucumber/rails'
 # recommended as it will mask a lot of errors for you!
 #
 ActionController::Base.allow_rescue = false
+DatabaseCleaner.strategy = :truncation
+DatabaseCleaner.clean
 
 # Remove/comment out the lines below if your app doesn't have a database.
 # For some databases (like MongoDB and CouchDB) you may need to use :truncation instead.

data/spec/test_app/features/support/functions.rb

@@ -0,0 +1,3 @@
+def underscore(name)
+  name.downcase.gsub(/ /,'_') 
+end

data/{features → spec/test_app/features}/support/paths.rb

@@ -5,7 +5,7 @@ module NavigationHelpers
   #
   # step definition in webrat_steps.rb
   #
-  def path_to(page_name)
+  def path_to(page_name, routing=nil)
     case page_name
     
     when /the homepage/
@@ -16,7 +16,16 @@ module NavigationHelpers
     #
     #   when /^(.*)'s profile page$/i
     #     user_profile_path(User.find_by_login($1))
+    # added by script/generate pickle path
+    when /the newsletter archive page/
+      "/newsletters/archive"
+    when /newsletter named "([^"]+)"'s new piece page$/
+      newsletter_name = $1
+      newsletter = Newsletter::Newsletter.where(name: newsletter_name).first
+      "/newsletter/newsletters/#{newsletter.id}/pieces/new"
 
+    when /^the (.+?) page$/                                         # translate to named route
+      routing.send("#{$1.downcase.gsub(' ','_')}_path")
     else
       raise "Can't find mapping from \"#{page_name}\" to a path.\n" +
         "Now, go and add a mapping in #{__FILE__}"

data/spec/test_app/lib/debugging.rb

@@ -0,0 +1,61 @@
+module ::Debugging
+  def self.with_pry_remote(timeout=5.minutes)
+    return unless block_given?
+    begin
+      yield
+    rescue StandardError, MiniTest::Assertion, Exception, RuntimeError => e
+      begin
+        Debugging::send_developer_im('chauboldt@bender.lnstar.com', "Error running test - #{e.message}: #{e.backtrace.join("\n")[0..80]} on #{`hostname`.strip} from #{`pwd`}")
+        Timeout::timeout(timeout) do
+          binding.pry_remote
+        end
+      rescue Exception, StandardError, RuntimeError => te
+        Rails.logger.warn "Uncaught/Unpried exception: #{te.message} #{te.backtrace.join("\n")}"
+        raise e
+      end
+    end
+  end
+
+  def self.send_developer_im(recipient='chauboldt@bender.lnstar.com', message)
+    # include Jabber # Makes using it a bit easier as we don't need to prepend Jabber:: to everything
+    # def send_xmpp_message(recipient, message)
+    # (recipient,message) = ARGV
+
+    #Account info
+    account = 'nagios@bender.lnstar.com'
+    password = '10dole01'
+
+
+    # Jabber::debug = true # Uncomment this if you want to see what's being sent and received!
+    jid = Jabber::JID::new(account)
+    client = Jabber::Client::new(jid)
+    client.connect
+    client.auth(password)
+    client.send(Jabber::Message::new(recipient,message))
+    # end
+  end
+
+  def self.wait_until(timeout=nil, log=false)
+    timeout ||= ((Capybara.default_wait_time + 3) rescue 10.seconds)
+    require "timeout"
+    Timeout.timeout(timeout) do
+      Rails.logger.warn "Waiting for something.. timeout: #{timeout}" if log
+      sleep(0.1) until value = yield
+      value
+    end
+  end
+
+  def self.wait_until_success(timeout=nil, log=false)
+    timeout ||= ((Capybara.default_wait_time + 3) rescue 10.seconds)
+    wait_until(timeout) do
+      begin
+        Rails.logger.warn "Waiting for something.. trying: #{Kernel.caller[0..5].join("\n")}" if log
+        yield
+        true
+      rescue => e
+        Rails.logger.warn "Waiting for something.. failure: #{e.message} #{e.backtrace.join}"
+        false
+      end
+    end
+  end
+end

data/spec/test_app/script/full_suite

@@ -0,0 +1,44 @@
+export RAILS_ENV=test
+# RUN FOR SQLITE
+cp config/database.sqlite.yml config/database.yml
+
+bundle exec rake db:schema:load
+
+export SQLITE_SUCCESS=0
+export CUC_SQLITE_SUCCESS=0
+
+DBADAPTER=sqlite bundle exec rspec spec && export SQLITE_SUCCESS=1
+DBADAPTER=sqlite bundle exec cucumber features && export CUC_SQLITE_SUCCESS=1
+
+if [ $POSTGRES -eq 1 ]; then
+  #RUN FOR Postgresql
+  cp config/database.postgres.local.yml config/database.yml
+
+  bundle exec rake db:schema:load
+  
+  export PGSQL_SUCCESS=0
+  export CUCPGSQL_SUCCESS=0
+
+  DBADAPTER=pg bundle exec rspec spec && export PGSQL_SUCCESS=1
+  DBADAPTER=pg bundle exec cucumber features && export CUC_PGSQL_SUCCESS=1
+fi
+  
+#RUN FOR MYSQL
+cp config/database.mysql.local.yml config/database.yml
+
+bundle exec rake db:schema:load
+
+export MYSQL_SUCCESS=0
+export CUCMYSQL_SUCCESS=0
+
+DBADAPTER=mysql bundle exec rspec spec && export MYSQL_SUCCESS=1
+DBADAPTER=mysql bundle exec cucumber features && export CUC_MYSQL_SUCCESS=1
+
+unset RAILS_ENV
+
+if [ $MYSQL_SUCCESS -eq 0 ] ; then echo "Rspec Mysql Failed" && exit 1; fi
+if [ $PGSQL_SUCCESS -eq 0 ] ; then echo "Rspec Pgsql Failed" && exit 1; fi
+if [ $SQLITE_SUCCESS -eq 0 ] ; then  echo "Rspec SQLite Failed" && exit 1; fi
+if [ $CUC_MYSQL_SUCCESS -eq 0 ] ; then  echo "Cucumber Mysql Failed" && exit 1; fi
+if [ $CUC_PGSQL_SUCCESS -eq 0 ] ; then  echo "Cucumber Pgsql Failed" && exit 1; fi
+if [ $CUC_SQLITE_SUCCESS -eq 0 ] ; then  echo "Cucumber SQLite Failed" && exit 1; fi

data/spec/test_app/script/rspec_multi_db

@@ -0,0 +1,26 @@
+export RAILS_ENV=test
+
+# RUN FOR SQLITE
+
+cp config/database.sqlite.yml config/database.yml
+
+rm db/test.sqlite3
+spring rake db:schema:load
+
+export SQLITE_SUCCESS=0
+
+DBADAPTER=sqlite bundle exec rspec spec && export SQLITE_SUCCESS=1
+
+#RUN FOR MYSQL
+cp config/database.local.yml config/database.yml
+
+mysqladmin -f drop newsletter_test
+mysqladmin -f create newsletter_test
+spring rake db:schema:load
+
+export MYSQL_SUCCESS=0
+
+DBADAPTER=mysql bundle exec rspec spec && export MYSQL_SUCCESS=1
+
+if [ $MYSQL_SUCCESS -eq 0 ] ; then exit 1; fi
+if [ $SQLITE_SUCCESS -eq 0 ] ; then exit 1; fi