newrelic_rpm 4.1.0.333 → 4.2.0.334

data/test/new_relic/agent/instrumentation/action_view_subscriber_test.rb

@@ -1,249 +0,0 @@
-# encoding: utf-8
-# This file is distributed under New Relic's license terms.
-# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
-
-if defined?(::Rails)
-
-require File.expand_path(File.join(File.dirname(__FILE__),'..','..','..','test_helper'))
-require 'new_relic/agent/instrumentation/action_view_subscriber'
-
-class NewRelic::Agent::Instrumentation::ActionViewSubscriberTest < Minitest::Test
-  def setup
-    @subscriber = NewRelic::Agent::Instrumentation::ActionViewSubscriber.new
-    @stats_engine = NewRelic::Agent.instance.stats_engine
-  end
-
-  def teardown
-    NewRelic::Agent.instance.stats_engine.clear_stats
-  end
-
-  def test_records_metrics_for_simple_template
-    params = { :identifier => '/root/app/views/model/index.html.erb' }
-    freeze_time
-    in_transaction do
-      @subscriber.start('render_template.action_view', :id, params)
-      @subscriber.start('!render_template.action_view', :id,
-                        :virtual_path => 'model/index')
-      advance_time 2.0
-      @subscriber.finish('!render_template.action_view', :id,
-                         :virtual_path => 'model/index')
-      @subscriber.finish('render_template.action_view', :id, params)
-    end
-    expected = { :call_count => 1, :total_call_time => 2.0 }
-    assert_metrics_recorded('View/model/index.html.erb/Rendering' => expected)
-  end
-
-  def test_records_metrics_for_simple_file
-    params = { :identifier => '/root/something.txt' }
-    freeze_time
-    in_transaction do
-      @subscriber.start('render_template.action_view', :id, params)
-      @subscriber.start('!render_template.action_view', :id,
-                        :virtual_path => nil)
-      advance_time 2.0
-      @subscriber.finish('!render_template.action_view', :id,
-                         :virtual_path => nil)
-      @subscriber.finish('render_template.action_view', :id, params)
-    end
-    expected = { :call_count => 1, :total_call_time => 2.0 }
-    assert_metrics_recorded('View/file/Rendering' => expected)
-  end
-
-  def test_records_metrics_for_simple_inline
-    params = { :identifier => 'inline template' }
-    freeze_time
-    in_transaction do
-      @subscriber.start('render_template.action_view', :id, params)
-      @subscriber.start('!render_template.action_view', :id,
-                        :virtual_path => nil)
-      advance_time 2.0
-      @subscriber.finish('!render_template.action_view', :id,
-                         :virtual_path => nil)
-      @subscriber.finish('render_template.action_view', :id, params)
-    end
-    expected = { :call_count => 1, :total_call_time => 2.0 }
-    assert_metrics_recorded('View/inline template/Rendering' => expected)
-  end
-
-  def test_records_metrics_for_simple_text
-    params = { :identifier => 'text template' }
-    freeze_time
-    in_transaction do
-      @subscriber.start('render_template.action_view', :id, params)
-      advance_time 2.0
-      @subscriber.finish('render_template.action_view', :id, params)
-    end
-    expected = { :call_count => 1, :total_call_time => 2.0 }
-    assert_metrics_recorded('View/text template/Rendering' => expected)
-  end
-
-  def test_records_metrics_for_simple_partial
-    params = { :identifier => '/root/app/views/model/_form.html.erb' }
-    freeze_time
-    in_transaction do
-      @subscriber.start('render_partial.action_view', :id, params)
-      @subscriber.start('!render_template.action_view', :id,
-                        :virtual_path => 'model/_form')
-      advance_time 2.0
-      @subscriber.finish('!render_template.action_view', :id,
-                         :virtual_path => 'model/_form')
-      @subscriber.finish('render_partial.action_view', :id, params)
-    end
-    expected = { :call_count => 1, :total_call_time => 2.0 }
-    assert_metrics_recorded('View/model/_form.html.erb/Partial' => expected)
-  end
-
-  def test_records_metrics_for_simple_collection
-    params = { :identifier => '/root/app/views/model/_user.html.erb' }
-    freeze_time
-    in_transaction do
-      @subscriber.start('render_collection.action_view', :id, params)
-      @subscriber.start('!render_template.action_view', :id,
-                        :virtual_path => 'model/_user')
-      advance_time 2.0
-      @subscriber.finish('!render_template.action_view', :id,
-                         :virtual_path => 'model/_user')
-      @subscriber.finish('render_collection.action_view', :id, params)
-    end
-    expected = { :call_count => 1, :total_call_time => 2.0 }
-    assert_metrics_recorded('View/model/_user.html.erb/Partial' => expected)
-  end
-
-  def test_records_metrics_for_layout
-    freeze_time
-    in_transaction do
-      @subscriber.start('!render_template.action_view', :id,
-                        :virtual_path => 'layouts/application')
-      advance_time 2.0
-      @subscriber.finish('!render_template.action_view', :id,
-                         :virtual_path => 'layouts/application')
-    end
-    expected = { :call_count => 1, :total_call_time => 2.0 }
-    assert_metrics_recorded('View/layouts/application/Rendering' => expected)
-  end
-
-  def test_records_scoped_metric
-    params = { :identifier => '/root/app/views/model/index.html.erb' }
-
-    in_transaction('test_txn') do
-      @subscriber.start('render_template.action_view', :id, params)
-      @subscriber.start('!render_template.action_view', :id,
-                        :virtual_path => 'model/index')
-      @subscriber.finish('!render_template.action_view', :id,
-                         :virtual_path => 'model/index')
-      @subscriber.finish('render_template.action_view', :id, params)
-    end
-
-    expected = { :call_count => 1 }
-    assert_metrics_recorded(
-      ['View/model/index.html.erb/Rendering', 'test_txn'] => expected
-    )
-  end
-
-  def test_records_nothing_if_tracing_disabled
-    params = { :identifier => '/root/app/views/model/_user.html.erb' }
-
-    NewRelic::Agent.disable_all_tracing do
-      @subscriber.start('render_collection.action_view', :id, params)
-      @subscriber.finish('render_collection.action_view', :id, params)
-    end
-
-    assert_metrics_not_recorded('View/model/_user.html.erb/Partial')
-  end
-
-  def test_creates_txn_node_for_simple_render
-    params = { :identifier => '/root/app/views/model/index.html.erb' }
-
-    in_transaction do
-      @subscriber.start('render_template.action_view', :id, params)
-      @subscriber.start('!render_template.action_view', :id,
-                        :virtual_path => 'model/index')
-      @subscriber.finish('!render_template.action_view', :id,
-                         :virtual_path => 'model/index')
-      @subscriber.finish('render_template.action_view', :id, params)
-    end
-
-    last_node = nil
-    sampler = NewRelic::Agent.instance.transaction_sampler
-    sampler.last_sample.root_node.each_node{|s| last_node = s }
-    NewRelic::Agent.shutdown
-
-    assert_equal('View/model/index.html.erb/Rendering',
-                 last_node.metric_name)
-  end
-
-  def test_creates_nested_partial_node_within_render_node
-    in_transaction do
-      @subscriber.start('render_template.action_view', :id,
-                        :identifier => 'model/index.html.erb')
-      @subscriber.start('!render_template.action_view', :id,
-                        :virtual_path => 'model/index')
-      @subscriber.start('render_partial.action_view', :id,
-                        :identifier => '/root/app/views/model/_list.html.erb')
-      @subscriber.start('!render_template.action_view', :id,
-                        :virtual_path => 'model/_list')
-      @subscriber.finish('!render_template.action_view', :id,
-                         :virtual_path => 'model/_list')
-      @subscriber.finish('render_partial.action_view', :id,
-                         :identifier => '/root/app/views/model/_list.html.erb')
-      @subscriber.finish('!render_template.action_view', :id,
-                           :virtual_path => 'model/index')
-      @subscriber.finish('render_template.action_view', :id,
-                         :identifier => 'model/index.html.erb')
-    end
-
-    sampler = NewRelic::Agent.instance.transaction_sampler
-    template_node = sampler.last_sample.root_node.called_nodes[0].called_nodes[0]
-    partial_node = template_node.called_nodes[0]
-
-    assert_equal('View/model/index.html.erb/Rendering',
-                 template_node.metric_name)
-    assert_equal('View/model/_list.html.erb/Partial',
-                 partial_node.metric_name)
-  end
-
-  def test_creates_nodes_for_each_in_a_collection_event
-    in_transaction do
-      @subscriber.start('render_collection.action_view', :id,
-                        :identifier => '/root/app/views/model/_list.html.erb',
-                        :count => 3)
-      @subscriber.start('!render_template.action_view', :id,
-                        :virtual_path => 'model/_list')
-      @subscriber.finish('!render_template.action_view', :id,
-                        :virtual_path => 'model/_list')
-      @subscriber.start('!render_template.action_view', :id,
-                        :virtual_path => 'model/_list')
-      @subscriber.finish('!render_template.action_view', :id,
-                        :virtual_path => 'model/_list')
-      @subscriber.start('!render_template.action_view', :id,
-                        :virtual_path => 'model/_list')
-      @subscriber.finish('!render_template.action_view', :id,
-                        :virtual_path => 'model/_list')
-      @subscriber.finish('render_collection.action_view', :id,
-                         :identifier => '/root/app/views/model/_list.html.erb',
-                         :count => 3)
-    end
-
-    sampler = NewRelic::Agent.instance.transaction_sampler
-    partial_nodes = sampler.last_sample.root_node.called_nodes[0].called_nodes
-
-    assert_equal 3, partial_nodes.size
-    assert_equal('View/model/_list.html.erb/Partial',
-                 partial_nodes[0].metric_name)
-  end
-
-  def test_metric_path_identifies_file_render_event
-    render_event = NewRelic::Agent::Instrumentation::ActionViewSubscriber::RenderEvent.new('foo', 0, 0, 'bar', {} )
-    assert_equal('file', render_event.metric_path('baz', nil) )
-  end
-
-  def test_metric_path_cannot_identify_empty_collection_render_event
-    render_event = NewRelic::Agent::Instrumentation::ActionViewSubscriber::RenderEvent.new('foo', 0, 0, 'bar', {} )
-    assert_equal('(unknown)', render_event.metric_path('render_collection.action_view', nil) )
-  end
-
-end if ::Rails::VERSION::MAJOR.to_i >= 4
-
-else
-  puts "Skipping tests in #{__FILE__} because Rails is unavailable"
-end

data/test/new_relic/agent/instrumentation/active_job_test.rb

@@ -1,20 +0,0 @@
-# encoding: utf-8
-# This file is distributed under New Relic's license terms.
-# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
-
-require File.expand_path(File.join(File.dirname(__FILE__),'..','..','..','test_helper'))
-require 'new_relic/agent/instrumentation/active_job'
-
-module NewRelic::Agent::Instrumentation
-  class ActiveJobHelperTest < Minitest::Test
-    def test_rails_formatted_adapters_get_shortened
-      name = ActiveJobHelper.clean_adapter_name("ActiveJob::QueueAdapters::InlineAdapter")
-      assert_equal "ActiveJob::Inline", name
-    end
-
-    def test_unexpected_name_format
-      name = ActiveJobHelper.clean_adapter_name("Not::AnExpected::Adapter")
-      assert_equal "Not::AnExpected::Adapter", name
-    end
-  end
-end

data/test/new_relic/agent/instrumentation/active_record_helper_test.rb

@@ -1,66 +0,0 @@
-# encoding: utf-8
-# This file is distributed under New Relic's license terms.
-# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
-require File.expand_path(File.join(File.dirname(__FILE__),'..','..','..','test_helper'))
-require 'new_relic/agent/instrumentation/active_record_helper'
-
-module NewRelic::Agent::Instrumentation
-  class ActiveRecordHelperTest < Minitest::Test
-
-    def test_product_operation_collection_for_find
-      product, operation, collection = ActiveRecordHelper.product_operation_collection_for('Namespace::Model Load', nil, nil)
-      assert_equal "ActiveRecord", product
-      assert_equal "find", operation
-      assert_equal "Namespace::Model", collection
-    end
-
-    def test_product_operation_collection_for_destroy
-      product, operation, collection = ActiveRecordHelper.product_operation_collection_for('Model Destroy', nil, nil)
-      assert_equal "ActiveRecord", product
-      assert_equal "destroy", operation
-      assert_equal "Model", collection
-    end
-
-    def test_product_operation_collection_for_create
-      product, operation, collection = ActiveRecordHelper.product_operation_collection_for('Model Create', nil, nil)
-      assert_equal "ActiveRecord", product
-      assert_equal "create", operation
-      assert_equal "Model", collection
-    end
-
-    def test_product_operation_collection_for_update
-      product, operation, collection = ActiveRecordHelper.product_operation_collection_for('Model Update', nil, nil)
-      assert_equal "ActiveRecord", product
-      assert_equal "update", operation
-      assert_equal "Model", collection
-    end
-
-    def test_product_operation_collection_for_name_columns
-      product, operation, collection = ActiveRecordHelper.product_operation_collection_for('Model Columns', nil, nil)
-      assert_equal "ActiveRecord", product
-      assert_equal "columns", operation
-      assert_equal "Model", collection
-    end
-
-    def test_product_operation_collection_for_with_product_name_from_adapter
-      product, operation, collection = ActiveRecordHelper.product_operation_collection_for('Model Load', nil, "mysql")
-      assert_equal "MySQL", product
-      assert_equal "find", operation
-      assert_equal "Model", collection
-    end
-
-    def test_product_operation_collection_for_from_sql
-      product, operation, collection = ActiveRecordHelper.product_operation_collection_for('invalid', "SELECT * FROM boo", nil)
-      assert_equal "ActiveRecord", product
-      assert_equal "select", operation
-      assert_nil collection
-    end
-
-    def test_product_operation_collection_for_name_with_integer_returns_nil
-      product, operation, collection = ActiveRecordHelper.product_operation_collection_for(1, '', nil)
-      assert_equal "ActiveRecord", product
-      assert_equal "other", operation
-      assert_nil collection
-    end
-  end
-end

data/test/new_relic/agent/instrumentation/active_record_subscriber_test.rb

@@ -1,210 +0,0 @@
-# encoding: utf-8
-# This file is distributed under New Relic's license terms.
-# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
-
-MIN_RAILS_VERSION = 4
-
-if defined?(::Rails) && ::Rails::VERSION::MAJOR.to_i >= MIN_RAILS_VERSION && !NewRelic::LanguageSupport.jruby?
-
-require File.expand_path(File.join(File.dirname(__FILE__),'..','..','..','test_helper'))
-require 'new_relic/agent/instrumentation/active_record_subscriber'
-
-class NewRelic::Agent::Instrumentation::ActiveRecordSubscriberTest < Minitest::Test
-  class Order; end
-
-  def setup
-    @config = { :adapter => 'mysql', :host => 'server' }
-    @connection = Object.new
-    @connection.instance_variable_set(:@config, @config)
-
-
-    @params = {
-      :name => 'NewRelic::Agent::Instrumentation::ActiveRecordSubscriberTest::Order Load',
-      :sql => 'SELECT * FROM sandwiches',
-      :connection_id => @connection.object_id
-    }
-
-    @subscriber = NewRelic::Agent::Instrumentation::ActiveRecordSubscriber.new
-
-    @stats_engine = NewRelic::Agent.instance.stats_engine
-    @stats_engine.clear_stats
-  end
-
-  def test_records_metrics_for_simple_find
-    freeze_time
-
-    in_transaction('test_txn') { simulate_query(2) }
-
-    metric_name = 'Datastore/statement/ActiveRecord/NewRelic::Agent::Instrumentation::ActiveRecordSubscriberTest::Order/find'
-    assert_metrics_recorded(
-      metric_name => { :call_count => 1, :total_call_time => 2.0 }
-    )
-  end
-
-  def test_records_scoped_metrics
-    freeze_time
-
-    in_transaction('test_txn') { simulate_query(2) }
-
-    metric_name = 'Datastore/statement/ActiveRecord/NewRelic::Agent::Instrumentation::ActiveRecordSubscriberTest::Order/find'
-    assert_metrics_recorded(
-      [metric_name, 'test_txn'] => { :call_count => 1, :total_call_time => 2 }
-    )
-  end
-
-  def test_records_datastore_instance_metric_for_supported_adapter
-    config = { :adapter => "mysql", :host => "jonan.gummy_planet", :port => 3306 }
-    @subscriber.stubs(:active_record_config).returns(config)
-
-    in_transaction('test_txn') { simulate_query(2) }
-
-    assert_metrics_recorded('Datastore/instance/MySQL/jonan.gummy_planet/3306')
-  end
-
-  def test_records_datastore_instance_metric_with_one_datum_missing
-    config = { :adapter => "mysql", :host => "jonan.gummy_planet", :port => "" }
-    @subscriber.stubs(:active_record_config).returns(config)
-
-    in_transaction('test_txn') { simulate_query(2) }
-
-    assert_metrics_recorded('Datastore/instance/MySQL/jonan.gummy_planet/unknown')
-
-    config = { :adapter => "mysql", :host => "", :port => 3306 }
-    @subscriber.stubs(:active_record_config).returns(config)
-
-    in_transaction('test_txn') { simulate_query(2) }
-
-    assert_metrics_recorded('Datastore/instance/MySQL/unknown/3306')
-  end
-
-  def test_does_not_record_datastore_instance_metric_for_unsupported_adapter
-    config = { :adapter => "JonanDB", :host => "jonan.gummy_planet" }
-    @subscriber.stubs(:active_record_config).returns(config)
-
-    in_transaction('test_txn') { simulate_query(2) }
-
-    assert_metrics_not_recorded('Datastore/instance/JonanDB/jonan.gummy_planet/default')
-  end
-
-  def test_does_not_record_datastore_instance_metric_if_disabled
-    with_config('datastore_tracer.instance_reporting.enabled' => false) do
-      config = { :host => "jonan.gummy_planet" }
-      @subscriber.stubs(:active_record_config).returns(config)
-
-      in_transaction('test_txn') { simulate_query(2) }
-
-      assert_metrics_not_recorded('Datastore/instance/ActiveRecord/jonan.gummy_planet/default')
-    end
-  end
-
-  def test_does_not_record_datastore_instance_metric_if_both_are_empty
-    config = { :adapter => "", :host => "" }
-    @subscriber.stubs(:active_record_config).returns(config)
-
-    in_transaction('test_txn') { simulate_query(2) }
-
-    assert_metrics_not_recorded('Datastore/instance/unknown/unknown')
-  end
-
-  def test_does_not_record_database_name_if_disabled
-    config = { :host => "jonan.gummy_planet", :database => "pizza_cube" }
-    @subscriber.stubs(:active_record_config).returns(config)
-    with_config('datastore_tracer.database_name_reporting.enabled' => false) do
-      in_transaction { simulate_query(2) }
-    end
-    sample = NewRelic::Agent.instance.transaction_sampler.last_sample
-    node = find_node_with_name_matching sample, /Datastore\//
-    refute node.params.key?(:database_name)
-  end
-
-  def test_records_unknown_unknown_when_error_gathering_instance_data
-    NewRelic::Agent::Instrumentation::ActiveRecordHelper::InstanceIdentification.stubs(:postgres_unix_domain_socket_case?).raises StandardError.new
-    NewRelic::Agent::Instrumentation::ActiveRecordHelper::InstanceIdentification.stubs(:mysql_default_case?).raises StandardError.new
-
-    config = {:adapter => 'mysql', :host => "127.0.0.1"}
-    @subscriber.stubs(:active_record_config).returns(config)
-
-    in_transaction('test_txn') { simulate_query(2) }
-
-    assert_metrics_recorded("Datastore/instance/MySQL/unknown/unknown")
-  end
-
-  def test_records_nothing_if_tracing_disabled
-    freeze_time
-
-    in_transaction('test_txn') do
-      NewRelic::Agent.disable_all_tracing { simulate_query(2) }
-    end
-
-    metric_name = 'Datastore/statement/ActiveRecord/NewRelic::Agent::Instrumentation::ActiveRecordSubscriberTest::Order/find'
-    assert_metrics_not_recorded([metric_name])
-  end
-
-  def test_records_rollup_metrics
-    freeze_time
-
-    in_web_transaction { simulate_query(2) }
-
-    assert_metrics_recorded(
-      'Datastore/operation/ActiveRecord/find' => { :call_count => 1, :total_call_time => 2 },
-      'Datastore/allWeb' => { :call_count => 1, :total_call_time => 2 },
-      'Datastore/all' => { :call_count => 1, :total_call_time => 2 }
-    )
-  end
-
-  def test_creates_txn_node
-    freeze_time
-
-    in_transaction do
-      simulate_query(2)
-    end
-
-    last_node = nil
-    sampler = NewRelic::Agent.instance.transaction_sampler
-    sampler.last_sample.root_node.each_node{|s| last_node = s }
-
-    assert_equal('Datastore/statement/ActiveRecord/NewRelic::Agent::Instrumentation::ActiveRecordSubscriberTest::Order/find',
-                 last_node.metric_name)
-    assert_equal('SELECT * FROM sandwiches',
-                 last_node.params[:sql].sql)
-  end
-
-  def test_creates_slow_sql_node
-    freeze_time
-
-    sampler = NewRelic::Agent.instance.sql_sampler
-    sql = nil
-
-    in_transaction do
-      simulate_query(2)
-      sql = sampler.tl_transaction_data.sql_data[0].sql
-    end
-
-    assert_equal 'SELECT * FROM sandwiches', sql
-  end
-
-  def test_should_not_raise_due_to_an_exception_during_instrumentation_callback
-    @subscriber.stubs(:record_metrics).raises(StandardError)
-    simulate_query
-  end
-
-  def simulate_query(duration=nil)
-    @subscriber.start('sql.active_record', :id, @params)
-    advance_time(duration) if duration
-    @subscriber.finish('sql.active_record', :id, @params)
-  end
-
-  def test_active_record_config_for_event
-    target_connection = ActiveRecord::Base.connection_handler.connection_pool_list.first.connections.first
-    expected_config = target_connection.instance_variable_get(:@config)
-
-    payload = { :connection_id => target_connection.object_id }
-
-    result = @subscriber.active_record_config(payload)
-    assert_equal expected_config, result
-  end
-end
-
-else
-  puts "Skipping tests in #{__FILE__} because Rails >= #{MIN_RAILS_VERSION} is unavailable"
-end