newrelic_rpm 4.1.0.333 → 4.2.0.334

data/test/multiverse/suites/agent_only/encoding_handling_test.rb

@@ -1,122 +0,0 @@
-# encoding: utf-8
-# This file is distributed under New Relic's license terms.
-# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
-
-class EncodingHandlingTest < Minitest::Test
-  include MultiverseHelpers
-
-  setup_and_teardown_agent
-
-  def test_handles_mis_encoded_database_queries
-    with_config(:'transaction_tracer.transaction_threshold' => 0.0,
-      :'transaction_tracer.record_sql' => :raw) do
-      in_transaction do
-        state = NewRelic::Agent::TransactionState.tl_get
-        agent.transaction_sampler.notice_sql(bad_string, nil, 42, state)
-      end
-      assert_endpoint_received_string('transaction_sample_data', normalized_bad_string)
-    end
-  end
-
-  def test_handles_mis_encoded_request_params
-    with_config(:'capture_params' => true,
-      :'transaction_tracer.transaction_threshold' => 0.0) do
-      options = { :filtered_params => { bad_string => bad_string }}
-      in_transaction(options) do
-        # nothin
-      end
-    end
-    assert_endpoint_received_string('transaction_sample_data', normalized_bad_string)
-  end
-
-  def test_handles_mis_encoded_custom_attributes
-    with_config(:'transaction_tracer.transaction_threshold' => 0.0) do
-      in_transaction do
-        NewRelic::Agent.add_custom_attributes(:foo => bad_string)
-      end
-    end
-    assert_endpoint_received_string('transaction_sample_data', normalized_bad_string)
-  end
-
-  def test_handles_mis_encoded_custom_attributes_on_analytics_events
-    in_transaction(:category => :controller) do
-      NewRelic::Agent.add_custom_attributes(:foo => bad_string)
-    end
-    assert_endpoint_received_string('analytic_event_data', normalized_bad_string)
-  end
-
-  def test_handles_mis_encoded_custom_attributes_on_errors
-    NewRelic::Agent.notice_error('bad news', :custom_params => {'foo' => bad_string})
-    assert_endpoint_received_string('error_data', normalized_bad_string)
-  end
-
-  def test_handles_mis_encoded_exception_message
-    NewRelic::Agent.notice_error(bad_string)
-    assert_endpoint_received_string('error_data', normalized_bad_string)
-  end
-
-  def test_handles_mis_encoded_metric_names
-    NewRelic::Agent.record_metric(bad_string, 42)
-    assert_endpoint_received_string('metric_data', normalized_bad_string)
-  end
-
-  def test_handles_mis_encoded_transaction_names
-    with_config(:'transaction_tracer.transaction_threshold' => 0.0) do
-      in_transaction do
-        NewRelic::Agent.set_transaction_name(bad_string)
-      end
-    end
-    expected_transaction_name = "other/#{normalized_bad_string}"
-    assert_endpoint_received_string('transaction_sample_data', expected_transaction_name)
-  end
-
-  def test_handles_mis_encoded_strings_in_environment_report
-    $collector.reset
-    ::NewRelic::EnvironmentReport.report_on('Dummy') do
-      bad_string
-    end
-    agent.instance_variable_set(:@environment_report, agent.environment_for_connect)
-    agent.connect_to_server
-    assert_endpoint_received_string('connect', normalized_bad_string)
-  end
-
-  def assert_endpoint_received_string(endpoint, string)
-    agent.send(:transmit_data)
-    agent.send(:transmit_event_data)
-    requests = $collector.calls_for(endpoint)
-    assert_equal(1, requests.size)
-    request = requests.first
-    request.decode! if request.respond_to?(:decode!)
-    assert_contains_string(request, string)
-  end
-
-  def assert_contains_string(request, string)
-    object_graph = request.body
-    object_graph = request.samples if request.respond_to?(:samples)
-    assert object_graph_contains_string?(request.body, string), "Did not find desired string in #{request.body.inspect}"
-  end
-
-  def object_graph_contains_string?(object_graph, string)
-    case object_graph
-    when String
-      string == object_graph
-    when Array
-      object_graph.any? { |x| object_graph_contains_string?(x, string) }
-    when Hash
-      (
-        object_graph_contains_string?(object_graph.keys, string) ||
-        object_graph_contains_string?(object_graph.values, string)
-      )
-    else
-      false
-    end
-  end
-
-  def bad_string
-    [128].to_a.pack("C*").force_encoding('UTF-8')
-  end
-
-  def normalized_bad_string
-    bad_string.force_encoding('ISO-8859-1').encode('UTF-8')
-  end
-end

data/test/multiverse/suites/agent_only/error_events_test.rb

@@ -1,98 +0,0 @@
-# encoding: utf-8
-# This file is distributed under New Relic's license terms.
-# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
-
-class ErrorEventsTest < Minitest::Test
-  include MultiverseHelpers
-
-  setup_and_teardown_agent do
-    freeze_time
-  end
-
-  def test_error_events_are_submitted
-    txn = generate_errors
-
-    NewRelic::Agent.agent.send(:harvest_and_send_error_event_data)
-
-    intrinsics, _, _ = last_error_event
-
-    assert_equal txn.best_name, intrinsics["transactionName"]
-    assert_equal "RuntimeError", intrinsics["error.class"]
-    assert_equal "Big Controller", intrinsics["error.message"]
-    assert_equal "TransactionError", intrinsics["type"]
-    assert_equal txn.payload[:duration], intrinsics["duration"]
-  end
-
-  def test_records_supportability_metrics
-    with_config :'error_collector.max_event_samples_stored' => 10 do
-      generate_errors 15
-
-      NewRelic::Agent.agent.send(:harvest_and_send_error_event_data)
-
-      assert_metrics_recorded({
-        "Supportability/Events/TransactionError/Sent" => {:call_count => 10},
-        "Supportability/Events/TransactionError/Seen" => {:call_count => 15}
-      })
-    end
-  end
-
-  def test_does_not_record_error_events_when_disabled
-    with_config :'error_collector.capture_events' => false do
-      generate_errors 5
-
-      NewRelic::Agent.agent.send(:harvest_and_send_error_event_data)
-      assert_equal(0, $collector.calls_for(:error_event_data).size)
-    end
-  end
-
-  def test_does_not_record_error_events_when_disabled_by_feature_gate
-
-    $collector.stub('connect', {
-      'agent_run_id'          => 1,
-      'collect_error_events' => false
-    })
-    trigger_agent_reconnect
-
-    generate_errors 5
-
-    NewRelic::Agent.agent.send(:harvest_and_send_error_event_data)
-    assert_equal(0, $collector.calls_for(:error_event_data).size)
-
-    # reset the collect_error_events flag so that the ErrorEventAggregator
-    # will be enabled for the next test
-    $collector.stub('connect', {
-      'agent_run_id'          => 1,
-      'collect_error_events' => true
-    })
-
-    trigger_agent_reconnect
-  end
-
-  def test_error_events_created_outside_of_transaction
-    NewRelic::Agent.notice_error RuntimeError.new "No Txn"
-    NewRelic::Agent.agent.send(:harvest_and_send_error_event_data)
-
-    intrinsics, _, _ = last_error_event
-
-    assert_equal "TransactionError", intrinsics["type"]
-    assert_in_delta Time.now.to_f, intrinsics["timestamp"], 0.001
-    assert_equal "RuntimeError", intrinsics["error.class"]
-    assert_equal "No Txn", intrinsics["error.message"]
-  end
-
-  def generate_errors num_errors = 1
-    in_transaction :transaction_name => "Controller/blogs/index" do |t|
-      num_errors.times { t.notice_error RuntimeError.new "Big Controller" }
-    end
-  end
-
-  def last_error_event
-    post = last_error_event_post
-    assert_equal(1, post.events.size)
-    post.events.last
-  end
-
-  def last_error_event_post
-    $collector.calls_for(:error_event_data).first
-  end
-end

data/test/multiverse/suites/agent_only/exclusive_time_test.rb

@@ -1,176 +0,0 @@
-# encoding: utf-8
-# This file is distributed under New Relic's license terms.
-# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
-
-class ExclusiveTimeTest < Minitest::Test
-  include MultiverseHelpers
-
-  setup_and_teardown_agent
-
-  def test_traced_node_without_metrics_dont_decrease_exclusive_time
-    traced_class = Class.new do
-      include NewRelic::Agent::Instrumentation::ControllerInstrumentation
-      include NewRelic::Agent::MethodTracer
-
-      def outer
-        advance_time 2
-        inner_a
-        inner_b
-      end
-      add_transaction_tracer :outer, :class_name => 'traced'
-
-      def inner_a
-        advance_time 5
-      end
-      add_method_tracer :inner_a, 'inner_a', :metric => false
-
-      def inner_b
-        advance_time 10
-      end
-      add_method_tracer :inner_b, 'inner_b'      
-    end
-
-    freeze_time
-    traced_class.new.outer
-
-    txn_name = 'Controller/traced/outer'
-    assert_metrics_recorded(
-      txn_name => {
-        :call_count           => 1,
-        :total_call_time      => 2 + 5 + 10,
-        :total_exclusive_time => 2 + 5
-      },
-      ['inner_b', txn_name] => {
-        :call_count           => 1,
-        :total_call_time      => 10,
-        :total_exclusive_time => 10
-      })
-  end
-
-  def test_exclusive_time_should_propagate_through_nodes_that_dont_record_metrics
-    traced_class = Class.new do
-      include NewRelic::Agent::Instrumentation::ControllerInstrumentation
-      include NewRelic::Agent::MethodTracer
-
-      def outer
-        advance_time 2
-        inner_a
-      end
-      add_transaction_tracer :outer, :class_name => 'traced'
-
-      def inner_a
-        advance_time 5
-        inner_b
-      end
-      add_method_tracer :inner_a, 'inner_a', :metric => false
-
-      def inner_b
-        advance_time 10
-      end
-      add_method_tracer :inner_b, 'inner_b'
-    end
-
-    freeze_time
-    txn_name = 'Controller/traced/outer'
-
-    traced_class.new.outer
-
-    assert_metrics_recorded(
-      txn_name => {
-        :call_count           => 1,
-        :total_call_time      => 2 + 5 + 10,
-        :total_exclusive_time => 2 + 5
-      },
-      ['inner_b', txn_name] => {
-        :call_count           => 1,
-        :total_call_time      => 10,
-        :total_exclusive_time => 10
-      })
-  end
-
-  def test_exclusive_time_on_unscoped_metric_should_be_zero_if_scoped_metric_matches
-    traced_class = Class.new do
-      include NewRelic::Agent::Instrumentation::ControllerInstrumentation
-      include NewRelic::Agent::MethodTracer
-
-      def outer_a
-        advance_time 2
-        outer_b
-      end
-      add_transaction_tracer :outer_a, :class_name => 'traced'
-
-      def outer_b
-        advance_time 5
-        inner
-      end
-      add_transaction_tracer :outer_b, :class_name => 'traced'
-
-      def inner
-        advance_time 10
-      end
-      add_method_tracer :inner, 'inner'
-    end
-
-    freeze_time
-    traced_class.new.outer_a
-
-    txn_name = 'Controller/traced/outer_b'
-    assert_metrics_recorded(
-       txn_name => {
-        :call_count           => 1,
-        :total_call_time      => 2 + 5 + 10,
-        :total_exclusive_time => 0
-      },
-      ['Nested/Controller/traced/outer_a', txn_name] => {
-        :call_count           => 1,
-        :total_call_time      => 2 + 5 + 10,
-        :total_exclusive_time => 2
-      },
-      ['Nested/Controller/traced/outer_b', txn_name] => {
-        :call_count           => 1,
-        :total_call_time      => 5 + 10,
-        :total_exclusive_time => 5
-      },
-      ['inner', txn_name] => {
-        :call_count           => 1,
-        :total_call_time      => 10,
-        :total_exclusive_time => 10
-      }
-    )
-  end
-
-  def test_exclusive_time_on_unscoped_metric_should_be_non_zero_if_no_nested_transaction
-    traced_class = Class.new do
-      include NewRelic::Agent::Instrumentation::ControllerInstrumentation
-      include NewRelic::Agent::MethodTracer
-
-      def outer
-        advance_time 2
-        inner
-      end
-      add_transaction_tracer :outer, :class_name => 'traced'
-
-      def inner
-        advance_time 10
-      end
-      add_method_tracer :inner, 'inner'
-    end
-
-    freeze_time
-    traced_class.new.outer
-
-    txn_name = 'Controller/traced/outer'
-    assert_metrics_recorded(
-       txn_name => {
-        :call_count           => 1,
-        :total_call_time      => 2 + 10,
-        :total_exclusive_time => 2
-      },
-      ['inner', txn_name] => {
-        :call_count           => 1,
-        :total_call_time      => 10,
-        :total_exclusive_time => 10
-      }
-    )
-  end
-end

data/test/multiverse/suites/agent_only/harvest_timestamps_test.rb

@@ -1,61 +0,0 @@
-# encoding: utf-8
-# This file is distributed under New Relic's license terms.
-# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
-
-require 'newrelic_rpm'
-
-class HarvestTimestampsTest < Minitest::Test
-  include MultiverseHelpers
-
-  setup_and_teardown_agent
-
-  def test_resets_metric_data_timestamps_after_forking
-    freeze_time
-
-    t1 = advance_time 10
-
-    simulate_fork
-    NewRelic::Agent.after_fork
-
-    t2 = advance_time 10
-    trigger_metric_data_post
-
-    metric_data_post = $collector.calls_for('metric_data').first
-    start_ts, end_ts = metric_data_post[1..2]
-
-    assert_equal(t1.to_f, start_ts)
-    assert_equal(t2.to_f, end_ts)
-  end
-
-  def test_start_timestamp_maintained_on_harvest_failure
-    t0 = freeze_time.to_f
-
-    simulate_fork
-    NewRelic::Agent.after_fork
-
-    $collector.stub('metric_data', {}, 503)
-    t1 = advance_time(10).to_f
-    trigger_metric_data_post
-    first_post = last_metric_data_post
-
-    $collector.reset
-    t2 = advance_time(10).to_f
-    trigger_metric_data_post
-    second_post = last_metric_data_post
-
-    assert_equal([t0, t1], first_post[1..2])
-    assert_equal([t0, t2], second_post[1..2])
-  end
-
-  def trigger_metric_data_post
-    NewRelic::Agent.agent.send(:transmit_data)
-  end
-
-  def last_metric_data_post
-    $collector.calls_for('metric_data').last
-  end
-
-  def simulate_fork
-    NewRelic::Agent.instance.harvester.instance_variable_set(:@starting_pid, nil)
-  end
-end