net-ssh 5.0.0.beta1 → 5.0.0.beta2

data/lib/net/ssh/transport/cipher_factory.rb

@@ -3,114 +3,117 @@ require 'net/ssh/transport/ctr.rb'
 require 'net/ssh/transport/key_expander'
 require 'net/ssh/transport/identity_cipher'
 
-module Net; module SSH; module Transport
-
-  # Implements a factory of OpenSSL cipher algorithms.
-  class CipherFactory
-    # Maps the SSH name of a cipher to it's corresponding OpenSSL name
-    SSH_TO_OSSL = {
-      "3des-cbc"                    => "des-ede3-cbc",
-      "blowfish-cbc"                => "bf-cbc",
-      "aes256-cbc"                  => "aes-256-cbc",
-      "aes192-cbc"                  => "aes-192-cbc",
-      "aes128-cbc"                  => "aes-128-cbc",
-      "idea-cbc"                    => "idea-cbc",
-      "cast128-cbc"                 => "cast-cbc",
-      "rijndael-cbc@lysator.liu.se" => "aes-256-cbc",
-      "arcfour128"                  => "rc4",
-      "arcfour256"                  => "rc4",
-      "arcfour512"                  => "rc4",
-      "arcfour"                     => "rc4",
-
-      "3des-ctr"                    => "des-ede3",
-      "blowfish-ctr"                => "bf-ecb",
-
-      "aes256-ctr"                  => "aes-256-ctr",
-      "aes192-ctr"                  => "aes-192-ctr",
-      "aes128-ctr"                  => "aes-128-ctr",
-      "cast128-ctr"                 => "cast5-ecb",
-
-      "none"                        => "none",
-    }
-
-    # Ruby's OpenSSL bindings always return a key length of 16 for RC4 ciphers
-    # resulting in the error: OpenSSL::CipherError: key length too short.
-    # The following ciphers will override this key length.
-    KEY_LEN_OVERRIDE = {
-      "arcfour256"                  => 32,
-      "arcfour512"                  => 64
-    }
-
-
-    # Returns true if the underlying OpenSSL library supports the given cipher,
-    # and false otherwise.
-    def self.supported?(name)
-      ossl_name = SSH_TO_OSSL[name] or raise NotImplementedError, "unimplemented cipher `#{name}'"
-      return true if ossl_name == "none"
-      return OpenSSL::Cipher.ciphers.include?(ossl_name)
-    end
-
-    # Retrieves a new instance of the named algorithm. The new instance
-    # will be initialized using an iv and key generated from the given
-    # iv, key, shared, hash and digester values. Additionally, the
-    # cipher will be put into encryption or decryption mode, based on the
-    # value of the +encrypt+ parameter.
-    def self.get(name, options={})
-      ossl_name = SSH_TO_OSSL[name] or raise NotImplementedError, "unimplemented cipher `#{name}'"
-      return IdentityCipher if ossl_name == "none"
-      cipher = OpenSSL::Cipher.new(ossl_name)
-
-      cipher.send(options[:encrypt] ? :encrypt : :decrypt)
-
-      cipher.padding = 0
-
-      if name =~ /-ctr(@openssh.org)?$/
-        if ossl_name !~ /-ctr/
-          cipher.extend(Net::SSH::Transport::CTR)
-        else
-          cipher = Net::SSH::Transport::OpenSSLAESCTR.new(cipher)
+module Net 
+  module SSH 
+    module Transport
+
+      # Implements a factory of OpenSSL cipher algorithms.
+      class CipherFactory
+        # Maps the SSH name of a cipher to it's corresponding OpenSSL name
+        SSH_TO_OSSL = {
+          "3des-cbc"                    => "des-ede3-cbc",
+          "blowfish-cbc"                => "bf-cbc",
+          "aes256-cbc"                  => "aes-256-cbc",
+          "aes192-cbc"                  => "aes-192-cbc",
+          "aes128-cbc"                  => "aes-128-cbc",
+          "idea-cbc"                    => "idea-cbc",
+          "cast128-cbc"                 => "cast-cbc",
+          "rijndael-cbc@lysator.liu.se" => "aes-256-cbc",
+          "arcfour128"                  => "rc4",
+          "arcfour256"                  => "rc4",
+          "arcfour512"                  => "rc4",
+          "arcfour"                     => "rc4",
+    
+          "3des-ctr"                    => "des-ede3",
+          "blowfish-ctr"                => "bf-ecb",
+    
+          "aes256-ctr"                  => "aes-256-ctr",
+          "aes192-ctr"                  => "aes-192-ctr",
+          "aes128-ctr"                  => "aes-128-ctr",
+          "cast128-ctr"                 => "cast5-ecb",
+    
+          "none"                        => "none"
+        }
+    
+        # Ruby's OpenSSL bindings always return a key length of 16 for RC4 ciphers
+        # resulting in the error: OpenSSL::CipherError: key length too short.
+        # The following ciphers will override this key length.
+        KEY_LEN_OVERRIDE = {
+          "arcfour256"                  => 32,
+          "arcfour512"                  => 64
+        }
+    
+        # Returns true if the underlying OpenSSL library supports the given cipher,
+        # and false otherwise.
+        def self.supported?(name)
+          ossl_name = SSH_TO_OSSL[name] or raise NotImplementedError, "unimplemented cipher `#{name}'"
+          return true if ossl_name == "none"
+          return OpenSSL::Cipher.ciphers.include?(ossl_name)
         end
-      end
-      cipher.iv = Net::SSH::Transport::KeyExpander.expand_key(cipher.iv_len, options[:iv], options) if ossl_name != "rc4"
-
-      key_len = KEY_LEN_OVERRIDE[name] || cipher.key_len
-      cipher.key_len = key_len
-      cipher.key = Net::SSH::Transport::KeyExpander.expand_key(key_len, options[:key], options)
-      cipher.update(" " * 1536) if (ossl_name == "rc4" && name != "arcfour")
-
-      return cipher
-    end
-
-    # Returns a two-element array containing the [ key-length,
-    # block-size ] for the named cipher algorithm. If the cipher
-    # algorithm is unknown, or is "none", 0 is returned for both elements
-    # of the tuple.
-    # if :iv_len option is supplied the third return value will be ivlen
-    def self.get_lengths(name, options = {})
-      ossl_name = SSH_TO_OSSL[name]
-      if ossl_name.nil? || ossl_name == "none"
-        result = [0, 0]
-        result << 0 if options[:iv_len]
-      else
-        cipher = OpenSSL::Cipher.new(ossl_name)
-        key_len = KEY_LEN_OVERRIDE[name] || cipher.key_len
-        cipher.key_len = key_len
-
-        block_size =
-          case ossl_name
-          when "rc4"
-            8
-          when /\-ctr/
-            Net::SSH::Transport::OpenSSLAESCTR.block_size
+    
+        # Retrieves a new instance of the named algorithm. The new instance
+        # will be initialized using an iv and key generated from the given
+        # iv, key, shared, hash and digester values. Additionally, the
+        # cipher will be put into encryption or decryption mode, based on the
+        # value of the +encrypt+ parameter.
+        def self.get(name, options={})
+          ossl_name = SSH_TO_OSSL[name] or raise NotImplementedError, "unimplemented cipher `#{name}'"
+          return IdentityCipher if ossl_name == "none"
+          cipher = OpenSSL::Cipher.new(ossl_name)
+    
+          cipher.send(options[:encrypt] ? :encrypt : :decrypt)
+    
+          cipher.padding = 0
+    
+          if name =~ /-ctr(@openssh.org)?$/
+            if ossl_name !~ /-ctr/
+              cipher.extend(Net::SSH::Transport::CTR)
+            else
+              cipher = Net::SSH::Transport::OpenSSLAESCTR.new(cipher)
+            end
+          end
+          cipher.iv = Net::SSH::Transport::KeyExpander.expand_key(cipher.iv_len, options[:iv], options) if ossl_name != "rc4"
+    
+          key_len = KEY_LEN_OVERRIDE[name] || cipher.key_len
+          cipher.key_len = key_len
+          cipher.key = Net::SSH::Transport::KeyExpander.expand_key(key_len, options[:key], options)
+          cipher.update(" " * 1536) if (ossl_name == "rc4" && name != "arcfour")
+    
+          return cipher
+        end
+    
+        # Returns a two-element array containing the [ key-length,
+        # block-size ] for the named cipher algorithm. If the cipher
+        # algorithm is unknown, or is "none", 0 is returned for both elements
+        # of the tuple.
+        # if :iv_len option is supplied the third return value will be ivlen
+        def self.get_lengths(name, options = {})
+          ossl_name = SSH_TO_OSSL[name]
+          if ossl_name.nil? || ossl_name == "none"
+            result = [0, 0]
+            result << 0 if options[:iv_len]
           else
-            cipher.block_size
+            cipher = OpenSSL::Cipher.new(ossl_name)
+            key_len = KEY_LEN_OVERRIDE[name] || cipher.key_len
+            cipher.key_len = key_len
+    
+            block_size =
+              case ossl_name
+              when "rc4"
+                8
+              when /\-ctr/
+                Net::SSH::Transport::OpenSSLAESCTR.block_size
+              else
+                cipher.block_size
+              end
+    
+            result = [key_len, block_size]
+            result << cipher.iv_len if options[:iv_len]
           end
-
-        result = [key_len, block_size]
-        result << cipher.iv_len if options[:iv_len]
+          result
+        end
       end
-      result
+
     end
   end
-
-end; end; end
+end

data/lib/net/ssh/transport/constants.rb

@@ -1,32 +1,36 @@
-module Net; module SSH; module Transport
-  module Constants
-
-    #--
-    # Transport layer generic messages
-    #++
-
-    DISCONNECT                = 1
-    IGNORE                    = 2
-    UNIMPLEMENTED             = 3
-    DEBUG                     = 4
-    SERVICE_REQUEST           = 5
-    SERVICE_ACCEPT            = 6
-
-    #--
-    # Algorithm negotiation messages
-    #++
-
-    KEXINIT                   = 20
-    NEWKEYS                   = 21
-
-    #--
-    # Key exchange method specific messages
-    #++
-
-    KEXDH_INIT                = 30
-    KEXDH_REPLY               = 31
-
-    KEXECDH_INIT              = 30
-    KEXECDH_REPLY             = 31
+module Net 
+  module SSH 
+    module Transport
+      module Constants
+    
+        #--
+        # Transport layer generic messages
+        #++
+    
+        DISCONNECT                = 1
+        IGNORE                    = 2
+        UNIMPLEMENTED             = 3
+        DEBUG                     = 4
+        SERVICE_REQUEST           = 5
+        SERVICE_ACCEPT            = 6
+    
+        #--
+        # Algorithm negotiation messages
+        #++
+    
+        KEXINIT                   = 20
+        NEWKEYS                   = 21
+    
+        #--
+        # Key exchange method specific messages
+        #++
+    
+        KEXDH_INIT                = 30
+        KEXDH_REPLY               = 31
+    
+        KEXECDH_INIT              = 30
+        KEXECDH_REPLY             = 31
+      end
+    end
   end
-end; end; end
+end

data/lib/net/ssh/transport/ctr.rb

@@ -101,7 +101,7 @@ module Net::SSH::Transport
 
         def xor!(s1, s2)
           s = []
-          s1.unpack('Q*').zip(s2.unpack('Q*')) {|a,b| s.push(a^b) }
+          s1.unpack('Q*').zip(s2.unpack('Q*')) {|a,b| s.push(a ^ b) }
           s.pack('Q*')
         end
         singleton_class.send(:private, :xor!)

data/lib/net/ssh/transport/hmac.rb

@@ -21,7 +21,7 @@ module Net::SSH::Transport::HMAC
     'hmac-sha1-96'   => SHA1_96,
     'hmac-ripemd160' => RIPEMD160,
     'hmac-ripemd160@openssh.com' => RIPEMD160,
-    'none'           => None
+    'none' => None
   }
 
   # add mapping to sha2 hmac algorithms if they're available

data/lib/net/ssh/transport/hmac/abstract.rb

@@ -1,79 +1,82 @@
 require 'openssl'
 require 'openssl/digest'
 
-module Net; module SSH; module Transport; module HMAC
+module Net
+  module SSH
+    module Transport
+      module HMAC
 
-  # The base class of all OpenSSL-based HMAC algorithm wrappers.
-  class Abstract
+        # The base class of all OpenSSL-based HMAC algorithm wrappers.
+        class Abstract
+          class <<self
+            def key_length(*v)
+              @key_length = nil if !defined?(@key_length)
+              if v.empty?
+                @key_length = superclass.key_length if @key_length.nil? && superclass.respond_to?(:key_length)
+                return @key_length
+              elsif v.length == 1
+                @key_length = v.first
+              else
+                raise ArgumentError, "wrong number of arguments (#{v.length} for 1)"
+              end
+            end
 
-    class <<self
-      def key_length(*v)
-        @key_length = nil if !defined?(@key_length)
-        if v.empty?
-          @key_length = superclass.key_length if @key_length.nil? && superclass.respond_to?(:key_length)
-          return @key_length
-        elsif v.length == 1
-          @key_length = v.first
-        else
-          raise ArgumentError, "wrong number of arguments (#{v.length} for 1)"
-        end
-      end
+            def mac_length(*v)
+              @mac_length = nil if !defined?(@mac_length)
+              if v.empty?
+                @mac_length = superclass.mac_length if @mac_length.nil? && superclass.respond_to?(:mac_length)
+                return @mac_length
+              elsif v.length == 1
+                @mac_length = v.first
+              else
+                raise ArgumentError, "wrong number of arguments (#{v.length} for 1)"
+              end
+            end
 
-      def mac_length(*v)
-        @mac_length = nil if !defined?(@mac_length)
-        if v.empty?
-          @mac_length = superclass.mac_length if @mac_length.nil? && superclass.respond_to?(:mac_length)
-          return @mac_length
-        elsif v.length == 1
-          @mac_length = v.first
-        else
-          raise ArgumentError, "wrong number of arguments (#{v.length} for 1)"
-        end
-      end
+            def digest_class(*v)
+              @digest_class = nil if !defined?(@digest_class)
+              if v.empty?
+                @digest_class = superclass.digest_class if @digest_class.nil? && superclass.respond_to?(:digest_class)
+                return @digest_class
+              elsif v.length == 1
+                @digest_class = v.first
+              else
+                raise ArgumentError, "wrong number of arguments (#{v.length} for 1)"
+              end
+            end
+          end
 
-      def digest_class(*v)
-        @digest_class = nil if !defined?(@digest_class)
-        if v.empty?
-          @digest_class = superclass.digest_class if @digest_class.nil? && superclass.respond_to?(:digest_class)
-          return @digest_class
-        elsif v.length == 1
-          @digest_class = v.first
-        else
-          raise ArgumentError, "wrong number of arguments (#{v.length} for 1)"
-        end
-      end
-    end
+          def key_length
+            self.class.key_length
+          end
 
-    def key_length
-      self.class.key_length
-    end
+          def mac_length
+            self.class.mac_length
+          end
 
-    def mac_length
-      self.class.mac_length
-    end
+          def digest_class
+            self.class.digest_class
+          end
 
-    def digest_class
-      self.class.digest_class
-    end
-
-    # The key in use for this instance.
-    attr_reader :key
+          # The key in use for this instance.
+          attr_reader :key
 
-    def initialize(key=nil)
-      self.key = key
-    end
+          def initialize(key=nil)
+            self.key = key
+          end
 
-    # Sets the key to the given value, truncating it so that it is the correct
-    # length.
-    def key=(value)
-      @key = value ? value.to_s[0,key_length] : nil
-    end
+          # Sets the key to the given value, truncating it so that it is the correct
+          # length.
+          def key=(value)
+            @key = value ? value.to_s[0,key_length] : nil
+          end
 
-    # Compute the HMAC digest for the given data string.
-    def digest(data)
-      OpenSSL::HMAC.digest(digest_class.new, key, data)[0,mac_length]
+          # Compute the HMAC digest for the given data string.
+          def digest(data)
+            OpenSSL::HMAC.digest(digest_class.new, key, data)[0,mac_length]
+          end
+        end
+      end
     end
-
   end
-
-end; end; end; end
+end