net-ssh 4.1.0 → 6.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (111) hide show
  1. checksums.yaml +5 -5
  2. checksums.yaml.gz.sig +0 -0
  3. data.tar.gz.sig +0 -0
  4. data/.gitignore +5 -0
  5. data/.rubocop.yml +8 -2
  6. data/.rubocop_todo.yml +405 -552
  7. data/.travis.yml +23 -22
  8. data/CHANGES.txt +112 -1
  9. data/Gemfile +1 -7
  10. data/{Gemfile.norbnacl → Gemfile.noed25519} +1 -1
  11. data/Manifest +4 -5
  12. data/README.md +287 -0
  13. data/Rakefile +40 -29
  14. data/appveyor.yml +12 -6
  15. data/lib/net/ssh.rb +68 -32
  16. data/lib/net/ssh/authentication/agent.rb +234 -222
  17. data/lib/net/ssh/authentication/certificate.rb +175 -164
  18. data/lib/net/ssh/authentication/constants.rb +17 -14
  19. data/lib/net/ssh/authentication/ed25519.rb +162 -141
  20. data/lib/net/ssh/authentication/ed25519_loader.rb +32 -29
  21. data/lib/net/ssh/authentication/key_manager.rb +40 -9
  22. data/lib/net/ssh/authentication/methods/abstract.rb +53 -47
  23. data/lib/net/ssh/authentication/methods/hostbased.rb +32 -33
  24. data/lib/net/ssh/authentication/methods/keyboard_interactive.rb +1 -1
  25. data/lib/net/ssh/authentication/methods/none.rb +10 -10
  26. data/lib/net/ssh/authentication/methods/password.rb +13 -13
  27. data/lib/net/ssh/authentication/methods/publickey.rb +56 -55
  28. data/lib/net/ssh/authentication/pageant.rb +468 -465
  29. data/lib/net/ssh/authentication/pub_key_fingerprint.rb +43 -0
  30. data/lib/net/ssh/authentication/session.rb +130 -122
  31. data/lib/net/ssh/buffer.rb +345 -312
  32. data/lib/net/ssh/buffered_io.rb +163 -163
  33. data/lib/net/ssh/config.rb +316 -238
  34. data/lib/net/ssh/connection/channel.rb +670 -650
  35. data/lib/net/ssh/connection/constants.rb +30 -26
  36. data/lib/net/ssh/connection/event_loop.rb +108 -105
  37. data/lib/net/ssh/connection/keepalive.rb +54 -50
  38. data/lib/net/ssh/connection/session.rb +682 -671
  39. data/lib/net/ssh/connection/term.rb +180 -176
  40. data/lib/net/ssh/errors.rb +101 -99
  41. data/lib/net/ssh/key_factory.rb +195 -108
  42. data/lib/net/ssh/known_hosts.rb +161 -152
  43. data/lib/net/ssh/loggable.rb +57 -55
  44. data/lib/net/ssh/packet.rb +82 -78
  45. data/lib/net/ssh/prompt.rb +55 -53
  46. data/lib/net/ssh/proxy/command.rb +104 -89
  47. data/lib/net/ssh/proxy/errors.rb +12 -8
  48. data/lib/net/ssh/proxy/http.rb +93 -91
  49. data/lib/net/ssh/proxy/https.rb +42 -39
  50. data/lib/net/ssh/proxy/jump.rb +50 -47
  51. data/lib/net/ssh/proxy/socks4.rb +0 -2
  52. data/lib/net/ssh/proxy/socks5.rb +11 -12
  53. data/lib/net/ssh/service/forward.rb +370 -317
  54. data/lib/net/ssh/test.rb +83 -77
  55. data/lib/net/ssh/test/channel.rb +146 -142
  56. data/lib/net/ssh/test/extensions.rb +150 -146
  57. data/lib/net/ssh/test/kex.rb +35 -31
  58. data/lib/net/ssh/test/local_packet.rb +48 -44
  59. data/lib/net/ssh/test/packet.rb +87 -84
  60. data/lib/net/ssh/test/remote_packet.rb +35 -31
  61. data/lib/net/ssh/test/script.rb +173 -171
  62. data/lib/net/ssh/test/socket.rb +59 -55
  63. data/lib/net/ssh/transport/algorithms.rb +430 -364
  64. data/lib/net/ssh/transport/cipher_factory.rb +95 -91
  65. data/lib/net/ssh/transport/constants.rb +33 -25
  66. data/lib/net/ssh/transport/ctr.rb +33 -11
  67. data/lib/net/ssh/transport/hmac.rb +15 -13
  68. data/lib/net/ssh/transport/hmac/abstract.rb +82 -63
  69. data/lib/net/ssh/transport/hmac/sha2_256.rb +7 -11
  70. data/lib/net/ssh/transport/hmac/sha2_256_96.rb +4 -8
  71. data/lib/net/ssh/transport/hmac/sha2_256_etm.rb +12 -0
  72. data/lib/net/ssh/transport/hmac/sha2_512.rb +6 -9
  73. data/lib/net/ssh/transport/hmac/sha2_512_96.rb +4 -8
  74. data/lib/net/ssh/transport/hmac/sha2_512_etm.rb +12 -0
  75. data/lib/net/ssh/transport/identity_cipher.rb +55 -51
  76. data/lib/net/ssh/transport/kex.rb +14 -13
  77. data/lib/net/ssh/transport/kex/abstract.rb +123 -0
  78. data/lib/net/ssh/transport/kex/abstract5656.rb +72 -0
  79. data/lib/net/ssh/transport/kex/curve25519_sha256.rb +38 -0
  80. data/lib/net/ssh/transport/kex/curve25519_sha256_loader.rb +30 -0
  81. data/lib/net/ssh/transport/kex/diffie_hellman_group14_sha1.rb +33 -40
  82. data/lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb +112 -217
  83. data/lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha1.rb +53 -62
  84. data/lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha256.rb +5 -9
  85. data/lib/net/ssh/transport/kex/ecdh_sha2_nistp256.rb +36 -90
  86. data/lib/net/ssh/transport/kex/ecdh_sha2_nistp384.rb +18 -10
  87. data/lib/net/ssh/transport/kex/ecdh_sha2_nistp521.rb +18 -10
  88. data/lib/net/ssh/transport/key_expander.rb +29 -25
  89. data/lib/net/ssh/transport/openssl.rb +116 -116
  90. data/lib/net/ssh/transport/packet_stream.rb +223 -190
  91. data/lib/net/ssh/transport/server_version.rb +64 -66
  92. data/lib/net/ssh/transport/session.rb +306 -257
  93. data/lib/net/ssh/transport/state.rb +198 -196
  94. data/lib/net/ssh/verifiers/accept_new.rb +35 -0
  95. data/lib/net/ssh/verifiers/accept_new_or_local_tunnel.rb +34 -0
  96. data/lib/net/ssh/verifiers/always.rb +56 -0
  97. data/lib/net/ssh/verifiers/never.rb +21 -0
  98. data/lib/net/ssh/version.rb +55 -53
  99. data/net-ssh-public_cert.pem +18 -19
  100. data/net-ssh.gemspec +12 -11
  101. data/support/ssh_tunnel_bug.rb +2 -2
  102. metadata +86 -75
  103. metadata.gz.sig +0 -0
  104. data/Gemfile.norbnacl.lock +0 -41
  105. data/README.rdoc +0 -169
  106. data/lib/net/ssh/ruby_compat.rb +0 -24
  107. data/lib/net/ssh/verifiers/lenient.rb +0 -30
  108. data/lib/net/ssh/verifiers/null.rb +0 -12
  109. data/lib/net/ssh/verifiers/secure.rb +0 -52
  110. data/lib/net/ssh/verifiers/strict.rb +0 -24
  111. data/support/arcfour_check.rb +0 -20
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
- SHA1:
3
- metadata.gz: 315114c6a9537f7c43b92bb2aeb974a3a7e4a82e
4
- data.tar.gz: 0fe85c2a8f79d6dd869cfd71dd3b33f3b181a4a6
2
+ SHA256:
3
+ metadata.gz: 3871354412d3c8b53ef8bf56fccfc9b0bbbe76c7f1792005edeca4c90546f80f
4
+ data.tar.gz: 5d9c55ae9e77f57df83cdd68d3a707ea5583c05fa3ddfa718435b4706bc7da92
5
5
  SHA512:
6
- metadata.gz: 8d5c7cb19f06e99fdb1d58a7aa9d4412a0e400cda6d474c7ddd6ad5d005669fbbac593eac41f68a39b55c5a02ae1f9cd04233c5fa9f966d589ad256954066291
7
- data.tar.gz: 2d902438534348c94d7c35913d654db76a04c71c3f4644265ee90a9c3f56e28af9a89e3d34843c261f9fc0d398a728274d2665097cab7c7157cbe9fec6a5ec69
6
+ metadata.gz: 54f879420d7c34c5e190050506ab61ef5b7d0aae70cf417ff40ea78ed5cd7d595f7354b81bf9b6961b44b071df121612bdc153e141c77f1a4dc17d0c69946360
7
+ data.tar.gz: 5c98a21d3ca109e0fb406bba5a6e453732f8a87f52bda0f9233dfdf7af3eed4b56bc8eca732a1ff5191e9d7eb620fe80867db805932d062be224373875c8d56b
Binary file
data.tar.gz.sig CHANGED
Binary file
data/.gitignore CHANGED
@@ -1,6 +1,11 @@
1
1
  /Gemfile.lock
2
+ /Gemfile.noed25519.lock
2
3
  doc
4
+ rdoc
3
5
  ri
4
6
  pkg
5
7
  *.swp
6
8
  test/integration/.vagrant
9
+ test/integration/playbook.retry
10
+
11
+ .byebug_history
@@ -1,5 +1,11 @@
1
1
  inherit_from: .rubocop_todo.yml
2
2
 
3
- AllCops:
3
+ Style/DoubleNegation:
4
4
  Exclude:
5
- - 'tryout/**/*'
5
+ - 'lib/net/ssh/key_factory.rb'
6
+
7
+ Metrics/LineLength:
8
+ Max: 150
9
+ Exclude:
10
+ - 'test/**/*.rb'
11
+ - 'net-ssh.gemspec'
@@ -1,46 +1,155 @@
1
1
  # This configuration was generated by
2
2
  # `rubocop --auto-gen-config`
3
- # on 2016-12-11 13:27:14 +0100 using RuboCop version 0.46.0.
3
+ # on 2019-09-10 17:13:26 +0200 using RuboCop version 0.74.0.
4
4
  # The point is for the user to remove these configuration records
5
5
  # one by one as the offenses are removed from the code base.
6
6
  # Note that changes in the inspected code, or installation of new
7
7
  # versions of RuboCop, may require this file to be generated again.
8
8
 
9
- # Offense count: 4
10
- # Configuration parameters: AllowSafeAssignment.
11
- Lint/AssignmentInCondition:
9
+ # Offense count: 76
10
+ # Cop supports --auto-correct.
11
+ # Configuration parameters: EnforcedStyle, IndentationWidth.
12
+ # SupportedStyles: with_first_argument, with_fixed_indentation
13
+ Layout/AlignArguments:
14
+ Enabled: false
15
+
16
+ # Offense count: 57
17
+ # Cop supports --auto-correct.
18
+ # Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
19
+ # SupportedHashRocketStyles: key, separator, table
20
+ # SupportedColonStyles: key, separator, table
21
+ # SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
22
+ Layout/AlignHash:
12
23
  Exclude:
13
- - 'lib/net/ssh/connection/channel.rb'
14
- - 'lib/net/ssh/connection/session.rb'
15
- - 'lib/net/ssh/proxy/command.rb'
24
+ - 'lib/net/ssh/key_factory.rb'
25
+ - 'lib/net/ssh/transport/cipher_factory.rb'
26
+ - 'lib/net/ssh/transport/hmac.rb'
27
+ - 'lib/net/ssh/transport/kex.rb'
28
+ - 'test/test_config.rb'
16
29
 
17
- # Offense count: 1
30
+ # Offense count: 70
31
+ # Cop supports --auto-correct.
32
+ Layout/EmptyLineAfterGuardClause:
33
+ Enabled: false
34
+
35
+ # Offense count: 170
36
+ # Cop supports --auto-correct.
37
+ # Configuration parameters: EnforcedStyle.
38
+ # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
39
+ Layout/EmptyLinesAroundModuleBody:
40
+ Enabled: false
41
+
42
+ # Offense count: 2
18
43
  # Cop supports --auto-correct.
19
- # Configuration parameters: AlignWith, SupportedStyles.
20
- # SupportedStyles: either, start_of_block, start_of_line
21
- Lint/BlockAlignment:
44
+ # Configuration parameters: EnforcedStyle, IndentationWidth.
45
+ # SupportedStyles: special_inside_parentheses, consistent, align_brackets
46
+ Layout/IndentFirstArrayElement:
22
47
  Exclude:
23
- - 'test/integration/test_proxy.rb'
48
+ - 'lib/net/ssh/transport/openssl.rb'
24
49
 
25
- # Offense count: 1
50
+ # Offense count: 3
26
51
  # Cop supports --auto-correct.
27
- Lint/DeprecatedClassMethods:
52
+ Layout/LeadingBlankLines:
28
53
  Exclude:
29
54
  - 'Rakefile'
55
+ - 'lib/net/ssh/authentication/pub_key_fingerprint.rb'
56
+ - 'support/arcfour_check.rb'
30
57
 
31
- # Offense count: 1
32
- Lint/EmptyWhen:
58
+ # Offense count: 14
59
+ # Cop supports --auto-correct.
60
+ # Configuration parameters: AllowDoxygenCommentStyle.
61
+ Layout/LeadingCommentSpace:
33
62
  Exclude:
34
- - 'lib/net/ssh/config.rb'
63
+ - 'test/integration/test_ed25519_pkeys.rb'
64
+ - 'test/integration/test_forward.rb'
65
+ - 'test/integration/test_id_rsa_keys.rb'
66
+ - 'test/integration/test_proxy.rb'
67
+
68
+ # Offense count: 23
69
+ # Cop supports --auto-correct.
70
+ # Configuration parameters: EnforcedStyle, IndentationWidth.
71
+ # SupportedStyles: aligned, indented
72
+ Layout/MultilineOperationIndentation:
73
+ Exclude:
74
+ - 'lib/net/ssh/authentication/pageant.rb'
75
+ - 'lib/net/ssh/proxy/https.rb'
76
+ - 'lib/net/ssh/transport/algorithms.rb'
77
+ - 'lib/net/ssh/transport/state.rb'
78
+ - 'lib/net/ssh/verifiers/always.rb'
79
+ - 'test/authentication/methods/test_hostbased.rb'
80
+ - 'test/authentication/methods/test_publickey.rb'
81
+
82
+ # Offense count: 16
83
+ # Cop supports --auto-correct.
84
+ Layout/SpaceAfterColon:
85
+ Exclude:
86
+ - 'lib/net/ssh/authentication/ed25519.rb'
87
+ - 'test/integration/test_ed25519_pkeys.rb'
88
+ - 'test/verifiers/test_always.rb'
35
89
 
36
- # Offense count: 223
90
+ # Offense count: 281
37
91
  # Cop supports --auto-correct.
38
- # Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
39
- # SupportedStyles: keyword, variable, start_of_line
40
- Lint/EndAlignment:
92
+ Layout/SpaceAfterComma:
41
93
  Enabled: false
42
94
 
43
- # Offense count: 8
95
+ # Offense count: 136
96
+ # Cop supports --auto-correct.
97
+ # Configuration parameters: EnforcedStyle.
98
+ # SupportedStyles: space, no_space
99
+ Layout/SpaceAroundEqualsInParameterDefault:
100
+ Enabled: false
101
+
102
+ # Offense count: 10
103
+ # Cop supports --auto-correct.
104
+ # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
105
+ # SupportedStyles: space, no_space
106
+ # SupportedStylesForEmptyBraces: space, no_space
107
+ Layout/SpaceInsideBlockBraces:
108
+ Exclude:
109
+ - 'lib/net/ssh/authentication/session.rb'
110
+ - 'lib/net/ssh/transport/ctr.rb'
111
+ - 'support/ssh_tunnel_bug.rb'
112
+ - 'test/authentication/test_agent.rb'
113
+ - 'test/authentication/test_key_manager.rb'
114
+ - 'test/start/test_user_nil.rb'
115
+
116
+ # Offense count: 6
117
+ # Cop supports --auto-correct.
118
+ # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
119
+ # SupportedStyles: space, no_space
120
+ # SupportedStylesForEmptyBrackets: space, no_space
121
+ Layout/SpaceInsideReferenceBrackets:
122
+ Exclude:
123
+ - 'lib/net/ssh/transport/algorithms.rb'
124
+
125
+ # Offense count: 17
126
+ # Cop supports --auto-correct.
127
+ # Configuration parameters: EnforcedStyle.
128
+ # SupportedStyles: final_newline, final_blank_line
129
+ Layout/TrailingBlankLines:
130
+ Enabled: false
131
+
132
+ # Offense count: 739
133
+ # Cop supports --auto-correct.
134
+ # Configuration parameters: AllowInHeredoc.
135
+ Layout/TrailingWhitespace:
136
+ Enabled: false
137
+
138
+ # Offense count: 4
139
+ # Configuration parameters: AllowSafeAssignment.
140
+ Lint/AssignmentInCondition:
141
+ Exclude:
142
+ - 'lib/net/ssh/connection/channel.rb'
143
+ - 'lib/net/ssh/connection/session.rb'
144
+ - 'lib/net/ssh/proxy/command.rb'
145
+
146
+ # Offense count: 1
147
+ Lint/EmptyWhen:
148
+ Exclude:
149
+ - 'lib/net/ssh/config.rb'
150
+
151
+ # Offense count: 9
152
+ # Configuration parameters: AllowComments.
44
153
  Lint/HandleExceptions:
45
154
  Exclude:
46
155
  - 'lib/net/ssh/authentication/session.rb'
@@ -58,7 +167,7 @@ Lint/ImplicitStringConcatenation:
58
167
  - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb'
59
168
 
60
169
  # Offense count: 1
61
- Lint/LiteralInCondition:
170
+ Lint/LiteralAsCondition:
62
171
  Exclude:
63
172
  - 'lib/net/ssh/authentication/pageant.rb'
64
173
 
@@ -68,22 +177,24 @@ Lint/Loop:
68
177
  - 'lib/net/ssh/authentication/methods/password.rb'
69
178
  - 'lib/net/ssh/key_factory.rb'
70
179
 
71
- # Offense count: 1
72
- Lint/NextWithoutAccumulator:
180
+ # Offense count: 3
181
+ # Configuration parameters: MaximumRangeSize.
182
+ Lint/MissingCopEnableDirective:
73
183
  Exclude:
74
- - 'lib/net/ssh/connection/session.rb'
184
+ - 'test/authentication/test_agent.rb'
185
+ - 'test/authentication/test_certificate.rb'
186
+ - 'test/integration/test_agent.rb'
75
187
 
76
188
  # Offense count: 1
77
189
  Lint/NonLocalExitFromIterator:
78
190
  Exclude:
79
191
  - 'lib/net/ssh/known_hosts.rb'
80
192
 
81
- # Offense count: 4
193
+ # Offense count: 3
82
194
  Lint/RescueException:
83
195
  Exclude:
84
196
  - 'lib/net/ssh/authentication/key_manager.rb'
85
197
  - 'lib/net/ssh/service/forward.rb'
86
- - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb'
87
198
 
88
199
  # Offense count: 2
89
200
  Lint/ShadowedException:
@@ -91,11 +202,18 @@ Lint/ShadowedException:
91
202
  - 'lib/net/ssh/authentication/key_manager.rb'
92
203
 
93
204
  # Offense count: 1
205
+ # Configuration parameters: AllowKeywordBlockArguments.
94
206
  Lint/UnderscorePrefixedVariableName:
95
207
  Exclude:
96
208
  - 'lib/net/ssh/test/local_packet.rb'
97
209
 
98
- # Offense count: 52
210
+ # Offense count: 1
211
+ # Cop supports --auto-correct.
212
+ Lint/UnneededRequireStatement:
213
+ Exclude:
214
+ - 'lib/net/ssh/ruby_compat.rb'
215
+
216
+ # Offense count: 60
99
217
  # Cop supports --auto-correct.
100
218
  # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
101
219
  Lint/UnusedBlockArgument:
@@ -111,14 +229,14 @@ Lint/UnusedBlockArgument:
111
229
  - 'test/transport/test_algorithms.rb'
112
230
  - 'test/transport/test_hmac.rb'
113
231
 
114
- # Offense count: 50
232
+ # Offense count: 62
115
233
  # Cop supports --auto-correct.
116
234
  # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
117
235
  Lint/UnusedMethodArgument:
118
236
  Enabled: false
119
237
 
120
238
  # Offense count: 3
121
- # Configuration parameters: ContextCreatingMethods.
239
+ # Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
122
240
  Lint/UselessAccessModifier:
123
241
  Exclude:
124
242
  - 'lib/net/ssh/buffered_io.rb'
@@ -133,131 +251,183 @@ Lint/UselessAssignment:
133
251
  - 'test/integration/common.rb'
134
252
  - 'test/integration/test_forward.rb'
135
253
 
136
- # Offense count: 196
254
+ # Offense count: 229
137
255
  Metrics/AbcSize:
138
- Max: 76
256
+ Max: 89
139
257
 
140
- # Offense count: 14
141
- # Configuration parameters: CountComments.
258
+ # Offense count: 15
259
+ # Configuration parameters: CountComments, ExcludedMethods.
260
+ # ExcludedMethods: refine
142
261
  Metrics/BlockLength:
143
- Max: 88
262
+ Max: 59
144
263
 
145
264
  # Offense count: 1
265
+ # Configuration parameters: CountBlocks.
146
266
  Metrics/BlockNesting:
147
267
  Max: 4
148
268
 
149
- # Offense count: 27
269
+ # Offense count: 31
150
270
  # Configuration parameters: CountComments.
151
271
  Metrics/ClassLength:
152
- Max: 548
272
+ Max: 488
153
273
 
154
- # Offense count: 34
274
+ # Offense count: 38
155
275
  Metrics/CyclomaticComplexity:
156
- Max: 39
157
-
158
- # Offense count: 1341
159
- # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
160
- # URISchemes: http, https
161
- Metrics/LineLength:
162
- Max: 934
276
+ Max: 27
277
+ Exclude:
278
+ - 'lib/net/ssh/config.rb'
163
279
 
164
- # Offense count: 164
165
- # Configuration parameters: CountComments.
280
+ # Offense count: 211
281
+ # Configuration parameters: CountComments, ExcludedMethods.
166
282
  Metrics/MethodLength:
167
- Max: 93
283
+ Max: 82
168
284
 
169
- # Offense count: 1
285
+ # Offense count: 2
170
286
  # Configuration parameters: CountComments.
171
287
  Metrics/ModuleLength:
172
- Max: 142
288
+ Max: 160
173
289
 
174
290
  # Offense count: 1
175
291
  # Configuration parameters: CountKeywordArgs.
176
292
  Metrics/ParameterLists:
177
293
  Max: 6
178
294
 
179
- # Offense count: 27
295
+ # Offense count: 30
180
296
  Metrics/PerceivedComplexity:
181
- Max: 23
297
+ Max: 20
182
298
 
183
- # Offense count: 3
184
- # Cop supports --auto-correct.
185
- Performance/RangeInclude:
299
+ # Offense count: 9
300
+ Naming/AccessorMethodName:
186
301
  Exclude:
187
- - 'lib/net/ssh/transport/algorithms.rb'
302
+ - 'lib/net/ssh/authentication/methods/password.rb'
303
+ - 'lib/net/ssh/authentication/pageant.rb'
304
+ - 'lib/net/ssh/connection/channel.rb'
305
+ - 'lib/net/ssh/connection/session.rb'
306
+ - 'lib/net/ssh/transport/kex/abstract5656.rb'
307
+ - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb'
308
+ - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha1.rb'
188
309
 
189
- # Offense count: 3
190
- # Cop supports --auto-correct.
191
- Performance/RedundantBlockCall:
310
+ # Offense count: 2
311
+ Naming/BinaryOperatorParameterName:
192
312
  Exclude:
193
- - 'lib/net/ssh/connection/session.rb'
194
- - 'test/connection/test_channel.rb'
313
+ - 'lib/net/ssh/buffer.rb'
314
+ - 'lib/net/ssh/version.rb'
195
315
 
196
- # Offense count: 6
197
- # Cop supports --auto-correct.
198
- Performance/RedundantMatch:
316
+ # Offense count: 12
317
+ Naming/ClassAndModuleCamelCase:
199
318
  Exclude:
200
- - 'lib/net/ssh/key_factory.rb'
201
- - 'lib/net/ssh/transport/server_version.rb'
319
+ - 'lib/net/ssh/transport/hmac/md5_96.rb'
320
+ - 'lib/net/ssh/transport/hmac/sha1_96.rb'
321
+ - 'lib/net/ssh/transport/hmac/sha2_256.rb'
322
+ - 'lib/net/ssh/transport/hmac/sha2_256_96.rb'
323
+ - 'lib/net/ssh/transport/hmac/sha2_256_etm.rb'
324
+ - 'lib/net/ssh/transport/hmac/sha2_512.rb'
325
+ - 'lib/net/ssh/transport/hmac/sha2_512_96.rb'
326
+ - 'lib/net/ssh/transport/hmac/sha2_512_etm.rb'
327
+ - 'test/transport/hmac/test_md5_96.rb'
328
+ - 'test/transport/hmac/test_sha1_96.rb'
329
+ - 'test/transport/hmac/test_sha2_256.rb'
330
+ - 'test/transport/hmac/test_sha2_256_96.rb'
331
+ - 'test/transport/hmac/test_sha2_256_etm.rb'
332
+ - 'test/transport/hmac/test_sha2_512.rb'
333
+ - 'test/transport/hmac/test_sha2_512_96.rb'
334
+ - 'test/transport/hmac/test_sha2_512_etm.rb'
202
335
 
203
- # Offense count: 13
204
- Style/AccessorMethodName:
336
+ # Offense count: 4
337
+ Naming/ConstantName:
205
338
  Exclude:
206
- - 'lib/net/ssh/authentication/methods/password.rb'
207
- - 'lib/net/ssh/authentication/pageant.rb'
208
- - 'lib/net/ssh/connection/session.rb'
209
339
  - 'lib/net/ssh/transport/kex/diffie_hellman_group14_sha1.rb'
210
340
  - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb'
211
- - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha1.rb'
212
- - 'lib/net/ssh/transport/kex/ecdh_sha2_nistp256.rb'
341
+ - 'lib/net/ssh/transport/openssl.rb'
213
342
 
214
- # Offense count: 2
343
+ # Offense count: 11
344
+ # Configuration parameters: Blacklist.
345
+ # Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
346
+ Naming/HeredocDelimiterNaming:
347
+ Exclude:
348
+ - 'test/authentication/test_agent.rb'
349
+ - 'test/authentication/test_certificate.rb'
350
+ - 'test/authentication/test_ed25519.rb'
351
+ - 'test/authentication/test_session.rb'
352
+ - 'test/integration/test_agent.rb'
353
+ - 'test/test_key_factory.rb'
354
+
355
+ # Offense count: 4
356
+ # Configuration parameters: EnforcedStyleForLeadingUnderscores.
357
+ # SupportedStylesForLeadingUnderscores: disallowed, required, optional
358
+ Naming/MemoizedInstanceVariableName:
359
+ Exclude:
360
+ - 'lib/net/ssh/transport/openssl.rb'
361
+ - 'test/authentication/test_key_manager.rb'
362
+
363
+ # Offense count: 32
364
+ # Configuration parameters: EnforcedStyle.
365
+ # SupportedStyles: snake_case, camelCase
366
+ Naming/MethodName:
367
+ Exclude:
368
+ - 'lib/net/ssh/authentication/ed25519_loader.rb'
369
+ - 'lib/net/ssh/transport/kex/curve25519_sha256_loader.rb'
370
+ - 'test/authentication/test_agent.rb'
371
+ - 'test/authentication/test_session.rb'
372
+ - 'test/common.rb'
373
+ - 'test/connection/test_channel.rb'
374
+ - 'test/test_config.rb'
375
+ - 'test/test_key_factory.rb'
376
+
377
+ # Offense count: 4
215
378
  # Cop supports --auto-correct.
216
- # Configuration parameters: EnforcedStyle, SupportedStyles.
217
- # SupportedStyles: prefer_alias, prefer_alias_method
218
- Style/Alias:
379
+ # Configuration parameters: PreferredName.
380
+ Naming/RescuedExceptionsVariableName:
219
381
  Exclude:
220
382
  - 'lib/net/ssh/connection/session.rb'
221
383
  - 'lib/net/ssh/service/forward.rb'
384
+ - 'lib/net/ssh/verifiers/accept_new.rb'
222
385
 
223
- # Offense count: 1
224
- # Cop supports --auto-correct.
225
- Style/AlignArray:
386
+ # Offense count: 23
387
+ # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
388
+ # AllowedNames: io, id, to, by, on, in, at, ip, db
389
+ Naming/UncommunicativeMethodParamName:
226
390
  Exclude:
227
- - 'lib/net/ssh/proxy/socks5.rb'
391
+ - 'lib/net/ssh/authentication/certificate.rb'
392
+ - 'lib/net/ssh/authentication/ed25519.rb'
393
+ - 'lib/net/ssh/authentication/key_manager.rb'
394
+ - 'lib/net/ssh/authentication/pageant.rb'
395
+ - 'lib/net/ssh/buffer.rb'
396
+ - 'lib/net/ssh/buffered_io.rb'
397
+ - 'lib/net/ssh/ruby_compat.rb'
398
+ - 'lib/net/ssh/test/socket.rb'
399
+ - 'lib/net/ssh/transport/ctr.rb'
400
+ - 'lib/net/ssh/transport/hmac/abstract.rb'
401
+ - 'lib/net/ssh/transport/identity_cipher.rb'
402
+ - 'test/connection/test_session.rb'
228
403
 
229
- # Offense count: 25
230
- # Cop supports --auto-correct.
231
- # Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle, SupportedLastArgumentHashStyles.
232
- # SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
233
- Style/AlignHash:
404
+ # Offense count: 8
405
+ # Configuration parameters: EnforcedStyle.
406
+ # SupportedStyles: inline, group
407
+ Style/AccessModifierDeclarations:
234
408
  Exclude:
235
- - 'lib/net/ssh/transport/algorithms.rb'
236
- - 'test/connection/test_channel.rb'
237
- - 'test/integration/test_id_rsa_keys.rb'
238
- - 'test/transport/kex/test_diffie_hellman_group1_sha1.rb'
239
- - 'test/transport/kex/test_ecdh_sha2_nistp256.rb'
240
- - 'test/transport/test_algorithms.rb'
241
- - 'test/transport/test_cipher_factory.rb'
242
- - 'test/transport/test_state.rb'
409
+ - 'lib/net/ssh/authentication/pageant.rb'
410
+ - 'lib/net/ssh/transport/openssl.rb'
411
+ - 'test/test_key_factory.rb'
243
412
 
244
- # Offense count: 72
413
+ # Offense count: 2
245
414
  # Cop supports --auto-correct.
246
- # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
247
- # SupportedStyles: with_first_parameter, with_fixed_indentation
248
- Style/AlignParameters:
249
- Enabled: false
415
+ # Configuration parameters: EnforcedStyle.
416
+ # SupportedStyles: prefer_alias, prefer_alias_method
417
+ Style/Alias:
418
+ Exclude:
419
+ - 'lib/net/ssh/connection/session.rb'
420
+ - 'lib/net/ssh/service/forward.rb'
250
421
 
251
- # Offense count: 33
422
+ # Offense count: 31
252
423
  # Cop supports --auto-correct.
253
- # Configuration parameters: EnforcedStyle, SupportedStyles.
424
+ # Configuration parameters: EnforcedStyle.
254
425
  # SupportedStyles: always, conditionals
255
426
  Style/AndOr:
256
427
  Exclude:
257
428
  - 'lib/net/ssh/authentication/key_manager.rb'
258
429
  - 'lib/net/ssh/buffer.rb'
259
430
  - 'lib/net/ssh/buffered_io.rb'
260
- - 'lib/net/ssh/config.rb'
261
431
  - 'lib/net/ssh/connection/channel.rb'
262
432
  - 'lib/net/ssh/connection/session.rb'
263
433
  - 'lib/net/ssh/key_factory.rb'
@@ -267,19 +437,19 @@ Style/AndOr:
267
437
  - 'lib/net/ssh/transport/cipher_factory.rb'
268
438
  - 'lib/net/ssh/transport/hmac.rb'
269
439
  - 'lib/net/ssh/transport/key_expander.rb'
270
- - 'lib/net/ssh/transport/packet_stream.rb'
271
440
  - 'test/common.rb'
272
441
 
273
442
  # Offense count: 2
443
+ # Configuration parameters: AllowedChars.
274
444
  Style/AsciiComments:
275
445
  Exclude:
276
446
  - 'lib/net/ssh/authentication/pageant.rb'
277
447
  - 'lib/net/ssh/buffered_io.rb'
278
448
 
279
- # Offense count: 11
449
+ # Offense count: 8
280
450
  # Cop supports --auto-correct.
281
- # Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
282
- # SupportedStyles: line_count_based, semantic, braces_for_chaining
451
+ # Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods, AllowBracesOnProceduralOneLiners.
452
+ # SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
283
453
  # ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
284
454
  # FunctionalMethods: let, let!, subject, watch
285
455
  # IgnoredMethods: lambda, proc, it
@@ -291,12 +461,11 @@ Style/BlockDelimiters:
291
461
  - 'lib/net/ssh/connection/keepalive.rb'
292
462
  - 'lib/net/ssh/proxy/command.rb'
293
463
  - 'lib/net/ssh/transport/ctr.rb'
294
- - 'test/test_buffer.rb'
295
- - 'test/verifiers/test_secure.rb'
464
+ - 'test/verifiers/test_always.rb'
296
465
 
297
- # Offense count: 8
466
+ # Offense count: 7
298
467
  # Cop supports --auto-correct.
299
- # Configuration parameters: EnforcedStyle, SupportedStyles.
468
+ # Configuration parameters: EnforcedStyle.
300
469
  # SupportedStyles: braces, no_braces, context_dependent
301
470
  Style/BracesAroundHashParameters:
302
471
  Exclude:
@@ -305,7 +474,6 @@ Style/BracesAroundHashParameters:
305
474
  - 'test/integration/test_id_rsa_keys.rb'
306
475
  - 'test/transport/test_hmac.rb'
307
476
  - 'test/transport/test_session.rb'
308
- - 'test_kerberos_client2.rb'
309
477
 
310
478
  # Offense count: 2
311
479
  Style/CaseEquality:
@@ -313,57 +481,35 @@ Style/CaseEquality:
313
481
  - 'lib/net/ssh/buffer.rb'
314
482
  - 'lib/net/ssh/connection/session.rb'
315
483
 
316
- # Offense count: 42
317
- # Cop supports --auto-correct.
318
- # Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep, IndentationWidth.
319
- # SupportedStyles: case, end
320
- Style/CaseIndentation:
321
- Exclude:
322
- - 'lib/net/ssh.rb'
323
- - 'lib/net/ssh/authentication/methods/hostbased.rb'
324
- - 'lib/net/ssh/authentication/methods/none.rb'
325
- - 'lib/net/ssh/authentication/methods/password.rb'
326
- - 'lib/net/ssh/authentication/methods/publickey.rb'
327
- - 'lib/net/ssh/buffer.rb'
328
- - 'lib/net/ssh/config.rb'
329
- - 'lib/net/ssh/test/local_packet.rb'
330
- - 'lib/net/ssh/test/packet.rb'
331
-
332
484
  # Offense count: 1
333
485
  # Cop supports --auto-correct.
334
486
  Style/CharacterLiteral:
335
487
  Exclude:
336
488
  - 'test/test_buffer.rb'
337
489
 
338
- # Offense count: 12
339
- Style/ClassAndModuleCamelCase:
490
+ # Offense count: 15
491
+ # Cop supports --auto-correct.
492
+ # Configuration parameters: AutoCorrect, EnforcedStyle.
493
+ # SupportedStyles: nested, compact
494
+ Style/ClassAndModuleChildren:
340
495
  Exclude:
496
+ - 'lib/net/ssh/transport/ctr.rb'
497
+ - 'lib/net/ssh/transport/hmac.rb'
498
+ - 'lib/net/ssh/transport/hmac/md5.rb'
341
499
  - 'lib/net/ssh/transport/hmac/md5_96.rb'
500
+ - 'lib/net/ssh/transport/hmac/none.rb'
501
+ - 'lib/net/ssh/transport/hmac/ripemd160.rb'
502
+ - 'lib/net/ssh/transport/hmac/sha1.rb'
342
503
  - 'lib/net/ssh/transport/hmac/sha1_96.rb'
343
504
  - 'lib/net/ssh/transport/hmac/sha2_256.rb'
344
505
  - 'lib/net/ssh/transport/hmac/sha2_256_96.rb'
506
+ - 'lib/net/ssh/transport/hmac/sha2_256_etm.rb'
345
507
  - 'lib/net/ssh/transport/hmac/sha2_512.rb'
346
508
  - 'lib/net/ssh/transport/hmac/sha2_512_96.rb'
347
- - 'test/transport/hmac/test_md5_96.rb'
348
- - 'test/transport/hmac/test_sha1_96.rb'
349
- - 'test/transport/hmac/test_sha2_256.rb'
350
- - 'test/transport/hmac/test_sha2_256_96.rb'
351
- - 'test/transport/hmac/test_sha2_512.rb'
352
- - 'test/transport/hmac/test_sha2_512_96.rb'
353
-
354
- # Offense count: 16
355
- # Configuration parameters: EnforcedStyle, SupportedStyles.
356
- # SupportedStyles: nested, compact
357
- Style/ClassAndModuleChildren:
358
- Enabled: false
359
-
360
- # Offense count: 1
361
- # Cop supports --auto-correct.
362
- # Configuration parameters: EnforcedStyle, SupportedStyles.
363
- # SupportedStyles: is_a?, kind_of?
364
- Style/ClassCheck:
365
- Exclude:
366
- - 'test/authentication/test_key_manager.rb'
509
+ - 'lib/net/ssh/transport/hmac/sha2_512_etm.rb'
510
+ - 'lib/net/ssh/transport/kex.rb'
511
+ - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha1.rb'
512
+ - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha256.rb'
367
513
 
368
514
  # Offense count: 7
369
515
  Style/ClassVars:
@@ -390,34 +536,23 @@ Style/CommentAnnotation:
390
536
  - 'lib/net/ssh/buffer.rb'
391
537
  - 'lib/net/ssh/config.rb'
392
538
 
393
- # Offense count: 2
394
- # Cop supports --auto-correct.
395
- Style/CommentIndentation:
539
+ # Offense count: 3
540
+ Style/CommentedKeyword:
396
541
  Exclude:
542
+ - 'test/connection/test_session.rb'
397
543
  - 'test/integration/test_forward.rb'
398
- - 'test/transport/test_server_version.rb'
399
544
 
400
- # Offense count: 4
545
+ # Offense count: 7
401
546
  # Cop supports --auto-correct.
402
- # Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly.
547
+ # Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
403
548
  # SupportedStyles: assign_to_condition, assign_inside_condition
404
549
  Style/ConditionalAssignment:
405
550
  Exclude:
406
- - 'lib/net/ssh/transport/ctr.rb'
407
- - 'lib/net/ssh/transport/state.rb'
408
- - 'test/test_key_factory.rb'
409
551
  - 'lib/net/ssh/config.rb'
410
- - 'lib/net/ssh/known_hosts.rb'
411
552
  - 'lib/net/ssh/proxy/socks5.rb'
412
553
  - 'lib/net/ssh/test/script.rb'
413
-
414
- # Offense count: 5
415
- Style/ConstantName:
416
- Exclude:
417
- - 'lib/net/ssh/authentication/pageant.rb'
418
- - 'lib/net/ssh/transport/kex/diffie_hellman_group14_sha1.rb'
419
- - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb'
420
- - 'lib/net/ssh/transport/openssl.rb'
554
+ - 'lib/net/ssh/transport/state.rb'
555
+ - 'test/test_key_factory.rb'
421
556
 
422
557
  # Offense count: 1
423
558
  # Cop supports --auto-correct.
@@ -425,7 +560,7 @@ Style/DefWithParentheses:
425
560
  Exclude:
426
561
  - 'test/integration/test_forward.rb'
427
562
 
428
- # Offense count: 16
563
+ # Offense count: 14
429
564
  Style/Documentation:
430
565
  Exclude:
431
566
  - 'spec/**/*'
@@ -435,96 +570,15 @@ Style/Documentation:
435
570
  - 'lib/net/ssh/connection/session.rb'
436
571
  - 'lib/net/ssh/ruby_compat.rb'
437
572
  - 'lib/net/ssh/test/extensions.rb'
438
- - 'lib/net/ssh/transport/hmac/sha2_256_96.rb'
439
- - 'lib/net/ssh/transport/hmac/sha2_512.rb'
440
- - 'lib/net/ssh/transport/hmac/sha2_512_96.rb'
441
573
  - 'lib/net/ssh/transport/kex.rb'
442
- - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha256.rb'
443
574
  - 'lib/net/ssh/transport/key_expander.rb'
444
575
  - 'lib/net/ssh/transport/openssl.rb'
445
576
 
446
- # Offense count: 6
447
- # Cop supports --auto-correct.
448
- # Configuration parameters: EnforcedStyle, SupportedStyles.
449
- # SupportedStyles: leading, trailing
450
- Style/DotPosition:
451
- Exclude:
452
- - 'test/transport/test_algorithms.rb'
453
-
454
- # Offense count: 3
455
- # Cop supports --auto-correct.
456
- Style/EachWithObject:
457
- Exclude:
458
- - 'lib/net/ssh/config.rb'
459
- - 'lib/net/ssh/connection/session.rb'
460
- - 'lib/net/ssh/service/forward.rb'
461
-
462
- # Offense count: 1
463
- # Cop supports --auto-correct.
464
- Style/ElseAlignment:
465
- Exclude:
466
- - 'lib/net/ssh/packet.rb'
467
-
468
- # Offense count: 12
469
- # Cop supports --auto-correct.
470
- # Configuration parameters: AllowAdjacentOneLineDefs.
471
- Style/EmptyLineBetweenDefs:
472
- Exclude:
473
- - 'lib/net/ssh/buffered_io.rb'
474
- - 'lib/net/ssh/ruby_compat.rb'
475
- - 'lib/net/ssh/transport/kex/ecdh_sha2_nistp384.rb'
476
- - 'lib/net/ssh/transport/kex/ecdh_sha2_nistp521.rb'
477
- - 'test/test_buffer.rb'
478
- - 'test/test_key_factory.rb'
479
-
480
- # Offense count: 16
481
- # Cop supports --auto-correct.
482
- Style/EmptyLines:
483
- Exclude:
484
- - 'Rakefile'
485
- - 'lib/net/ssh/buffered_io.rb'
486
- - 'lib/net/ssh/connection/session.rb'
487
- - 'lib/net/ssh/known_hosts.rb'
488
- - 'lib/net/ssh/transport/cipher_factory.rb'
489
- - 'lib/net/ssh/transport/packet_stream.rb'
490
- - 'lib/net/ssh/transport/session.rb'
491
- - 'test/authentication/methods/test_keyboard_interactive.rb'
492
- - 'test/authentication/methods/test_password.rb'
493
- - 'test/integration/test_ed25519_pkeys.rb'
494
- - 'test/integration/test_id_rsa_keys.rb'
495
- - 'test/test_config.rb'
496
- - 'test/test_known_hosts.rb'
497
- - 'test/transport/test_cipher_factory.rb'
498
-
499
- # Offense count: 39
500
- # Cop supports --auto-correct.
501
- # Configuration parameters: EnforcedStyle, SupportedStyles.
502
- # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
503
- Style/EmptyLinesAroundClassBody:
504
- Enabled: false
505
-
506
- # Offense count: 4
507
- # Cop supports --auto-correct.
508
- Style/EmptyLinesAroundMethodBody:
509
- Exclude:
510
- - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha1.rb'
511
- - 'lib/net/ssh/transport/openssl.rb'
512
- - 'test/transport/hmac/test_sha2_256.rb'
513
- - 'test/transport/hmac/test_sha2_512.rb'
514
-
515
- # Offense count: 209
516
- # Cop supports --auto-correct.
517
- # Configuration parameters: EnforcedStyle, SupportedStyles.
518
- # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
519
- Style/EmptyLinesAroundModuleBody:
520
- Enabled: false
521
-
522
- # Offense count: 2
577
+ # Offense count: 1
523
578
  # Cop supports --auto-correct.
524
579
  Style/EmptyLiteral:
525
580
  Exclude:
526
581
  - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb'
527
- - 'lib/net/ssh/transport/kex/ecdh_sha2_nistp256.rb'
528
582
 
529
583
  # Offense count: 1
530
584
  # Cop supports --auto-correct.
@@ -532,44 +586,42 @@ Style/EvenOdd:
532
586
  Exclude:
533
587
  - 'lib/net/ssh/buffer.rb'
534
588
 
535
- # Offense count: 17
536
- # Cop supports --auto-correct.
537
- # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
538
- Style/ExtraSpacing:
539
- Exclude:
540
- - 'Rakefile'
541
- - 'lib/net/ssh/authentication/methods/password.rb'
542
- - 'lib/net/ssh/authentication/pageant.rb'
543
- - 'lib/net/ssh/proxy/socks5.rb'
544
- - 'lib/net/ssh/transport/hmac/sha2_256_96.rb'
545
- - 'lib/net/ssh/transport/hmac/sha2_512_96.rb'
546
- - 'test/authentication/test_key_manager.rb'
547
- - 'test/integration/test_forward.rb'
548
- - 'test/test_config.rb'
549
- - 'test/test_key_factory.rb'
550
- - 'test/transport/test_packet_stream.rb'
551
-
552
589
  # Offense count: 2
553
- # Configuration parameters: EnforcedStyle, SupportedStyles.
590
+ # Cop supports --auto-correct.
591
+ # Configuration parameters: EnforcedStyle.
554
592
  # SupportedStyles: format, sprintf, percent
555
593
  Style/FormatString:
556
594
  Exclude:
557
595
  - 'lib/net/ssh/authentication/pageant.rb'
558
596
  - 'lib/net/ssh/loggable.rb'
559
597
 
560
- # Offense count: 35
598
+ # Offense count: 1
599
+ # Configuration parameters: EnforcedStyle.
600
+ # SupportedStyles: annotated, template, unannotated
601
+ Style/FormatStringToken:
602
+ Exclude:
603
+ - 'lib/net/ssh/loggable.rb'
604
+
605
+ # Offense count: 166
606
+ # Cop supports --auto-correct.
607
+ # Configuration parameters: EnforcedStyle.
608
+ # SupportedStyles: always, never
609
+ Style/FrozenStringLiteralComment:
610
+ Enabled: false
611
+
612
+ # Offense count: 34
561
613
  # Configuration parameters: MinBodyLength.
562
614
  Style/GuardClause:
563
615
  Enabled: false
564
616
 
565
617
  # Offense count: 1
618
+ # Configuration parameters: AllowIfModifier.
566
619
  Style/IfInsideElse:
567
620
  Exclude:
568
621
  - 'lib/net/ssh/connection/session.rb'
569
622
 
570
- # Offense count: 9
623
+ # Offense count: 16
571
624
  # Cop supports --auto-correct.
572
- # Configuration parameters: MaxLineLength.
573
625
  Style/IfUnlessModifier:
574
626
  Exclude:
575
627
  - 'lib/net/ssh.rb'
@@ -577,56 +629,18 @@ Style/IfUnlessModifier:
577
629
  - 'lib/net/ssh/proxy/command.rb'
578
630
  - 'lib/net/ssh/service/forward.rb'
579
631
  - 'lib/net/ssh/transport/ctr.rb'
632
+ - 'lib/net/ssh/transport/kex.rb'
633
+ - 'lib/net/ssh/transport/kex/abstract5656.rb'
580
634
  - 'lib/net/ssh/transport/key_expander.rb'
581
635
  - 'test/integration/test_proxy.rb'
582
636
  - 'test/test_key_factory.rb'
583
637
 
584
- # Offense count: 4
585
- # Cop supports --auto-correct.
586
- # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
587
- # SupportedStyles: special_inside_parentheses, consistent, align_brackets
588
- Style/IndentArray:
589
- Exclude:
590
- - 'lib/net/ssh/transport/openssl.rb'
591
-
592
- # Offense count: 4
593
- # Cop supports --auto-correct.
594
- # Configuration parameters: IndentationWidth.
595
- Style/IndentAssignment:
596
- Exclude:
597
- - 'test/transport/kex/test_diffie_hellman_group1_sha1.rb'
598
- - 'test/transport/kex/test_ecdh_sha2_nistp256.rb'
599
- - 'test/transport/kex/test_ecdh_sha2_nistp384.rb'
600
- - 'test/transport/kex/test_ecdh_sha2_nistp521.rb'
601
-
602
- # Offense count: 227
603
- # Cop supports --auto-correct.
604
- # Configuration parameters: EnforcedStyle, SupportedStyles.
605
- # SupportedStyles: normal, rails
606
- Style/IndentationConsistency:
607
- Enabled: false
608
-
609
- # Offense count: 96
610
- # Cop supports --auto-correct.
611
- # Configuration parameters: Width.
612
- Style/IndentationWidth:
613
- Enabled: false
614
-
615
638
  # Offense count: 1
616
639
  # Cop supports --auto-correct.
617
640
  Style/InfiniteLoop:
618
641
  Exclude:
619
642
  - 'lib/net/ssh/authentication/pageant.rb'
620
643
 
621
- # Offense count: 17
622
- # Cop supports --auto-correct.
623
- Style/LeadingCommentSpace:
624
- Exclude:
625
- - 'test/integration/test_ed25519_pkeys.rb'
626
- - 'test/integration/test_forward.rb'
627
- - 'test/integration/test_id_rsa_keys.rb'
628
- - 'test/integration/test_proxy.rb'
629
-
630
644
  # Offense count: 27
631
645
  # Cop supports --auto-correct.
632
646
  Style/LineEndConcatenation:
@@ -634,44 +648,17 @@ Style/LineEndConcatenation:
634
648
  - 'lib/net/ssh/authentication/pageant.rb'
635
649
  - 'lib/net/ssh/transport/kex/diffie_hellman_group14_sha1.rb'
636
650
  - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb'
637
- - 'lib/net/ssh/transport/kex/ecdh_sha2_nistp256.rb'
638
- - 'lib/net/ssh/verifiers/secure.rb'
639
-
640
- # Offense count: 12
641
- # Cop supports --auto-correct.
642
- Style/MethodCallParentheses:
643
- Exclude:
644
- - 'test/authentication/test_key_manager.rb'
645
- - 'test/connection/test_session.rb'
646
- - 'test/integration/test_forward.rb'
647
- - 'test/start/test_user_nil.rb'
648
-
649
- # Offense count: 2
650
- # Cop supports --auto-correct.
651
- # Configuration parameters: EnforcedStyle, SupportedStyles.
652
- # SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline
653
- Style/MethodDefParentheses:
654
- Exclude:
655
- - 'test/common.rb'
656
- - 'test/integration/common.rb'
651
+ - 'lib/net/ssh/verifiers/always.rb'
657
652
 
658
653
  # Offense count: 1
659
- Style/MethodMissing:
654
+ Style/MethodMissingSuper:
660
655
  Exclude:
661
656
  - 'lib/net/ssh/connection/session.rb'
662
657
 
663
- # Offense count: 24
664
- # Configuration parameters: EnforcedStyle, SupportedStyles.
665
- # SupportedStyles: snake_case, camelCase
666
- Style/MethodName:
658
+ # Offense count: 1
659
+ Style/MissingRespondToMissing:
667
660
  Exclude:
668
- - 'lib/net/ssh/authentication/ed25519_loader.rb'
669
- - 'test/authentication/test_agent.rb'
670
- - 'test/authentication/test_session.rb'
671
- - 'test/common.rb'
672
- - 'test/connection/test_channel.rb'
673
- - 'test/test_config.rb'
674
- - 'test/test_key_factory.rb'
661
+ - 'lib/net/ssh/connection/session.rb'
675
662
 
676
663
  # Offense count: 3
677
664
  # Cop supports --auto-correct.
@@ -680,29 +667,33 @@ Style/MultilineIfThen:
680
667
  - 'lib/net/ssh/buffered_io.rb'
681
668
  - 'lib/net/ssh/service/forward.rb'
682
669
 
683
- # Offense count: 23
670
+ # Offense count: 6
684
671
  # Cop supports --auto-correct.
685
- # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
686
- # SupportedStyles: aligned, indented
687
- Style/MultilineOperationIndentation:
672
+ Style/MultilineWhenThen:
673
+ Exclude:
674
+ - 'lib/net/ssh/test/packet.rb'
675
+ - 'lib/net/ssh/transport/packet_stream.rb'
676
+ - 'lib/net/ssh/transport/session.rb'
677
+
678
+ # Offense count: 5
679
+ Style/MultipleComparison:
688
680
  Exclude:
681
+ - 'lib/net/ssh/authentication/agent.rb'
689
682
  - 'lib/net/ssh/authentication/pageant.rb'
690
683
  - 'lib/net/ssh/known_hosts.rb'
691
- - 'lib/net/ssh/proxy/https.rb'
692
- - 'lib/net/ssh/transport/algorithms.rb'
693
- - 'lib/net/ssh/transport/kex/ecdh_sha2_nistp256.rb'
694
- - 'lib/net/ssh/transport/state.rb'
695
- - 'lib/net/ssh/verifiers/secure.rb'
696
- - 'test/authentication/methods/test_hostbased.rb'
697
- - 'test/authentication/methods/test_publickey.rb'
684
+ - 'lib/net/ssh/verifiers/accept_new_or_local_tunnel.rb'
698
685
 
699
- # Offense count: 40
686
+ # Offense count: 41
700
687
  # Cop supports --auto-correct.
688
+ # Configuration parameters: EnforcedStyle.
689
+ # SupportedStyles: literals, strict
701
690
  Style/MutableConstant:
702
691
  Enabled: false
703
692
 
704
693
  # Offense count: 13
705
694
  # Cop supports --auto-correct.
695
+ # Configuration parameters: EnforcedStyle.
696
+ # SupportedStyles: both, prefix, postfix
706
697
  Style/NegatedIf:
707
698
  Exclude:
708
699
  - 'lib/net/ssh.rb'
@@ -721,21 +712,21 @@ Style/NegatedWhile:
721
712
  Exclude:
722
713
  - 'lib/net/ssh/config.rb'
723
714
 
724
- # Offense count: 2
715
+ # Offense count: 1
725
716
  # Cop supports --auto-correct.
726
- # Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
717
+ # Configuration parameters: EnforcedStyle, MinBodyLength.
727
718
  # SupportedStyles: skip_modifier_ifs, always
728
719
  Style/Next:
729
720
  Exclude:
730
721
  - 'lib/net/ssh/authentication/key_manager.rb'
731
- - 'lib/net/ssh/transport/algorithms.rb'
732
722
 
733
- # Offense count: 2
723
+ # Offense count: 1
734
724
  # Cop supports --auto-correct.
725
+ # Configuration parameters: EnforcedStyle.
726
+ # SupportedStyles: predicate, comparison
735
727
  Style/NilComparison:
736
728
  Exclude:
737
729
  - 'lib/net/ssh/proxy/command.rb'
738
- - 'lib/net/ssh/transport/openssl.rb'
739
730
 
740
731
  # Offense count: 3
741
732
  # Cop supports --auto-correct.
@@ -743,32 +734,18 @@ Style/Not:
743
734
  Exclude:
744
735
  - 'lib/net/ssh/connection/channel.rb'
745
736
 
746
- # Offense count: 7
737
+ # Offense count: 8
747
738
  # Cop supports --auto-correct.
739
+ # Configuration parameters: Strict.
748
740
  Style/NumericLiterals:
749
741
  MinDigits: 310
750
742
 
751
- # Offense count: 11
743
+ # Offense count: 29
752
744
  # Cop supports --auto-correct.
753
- # Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
745
+ # Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
754
746
  # SupportedStyles: predicate, comparison
755
747
  Style/NumericPredicate:
756
- Exclude:
757
- - 'spec/**/*'
758
- - 'lib/net/ssh/authentication/methods/password.rb'
759
- - 'lib/net/ssh/authentication/pageant.rb'
760
- - 'lib/net/ssh/buffer.rb'
761
- - 'lib/net/ssh/service/forward.rb'
762
- - 'lib/net/ssh/test/extensions.rb'
763
- - 'lib/net/ssh/transport/key_expander.rb'
764
- - 'test/transport/test_packet_stream.rb'
765
- - 'test_connection_close_shall_close_cannels.rb'
766
-
767
- # Offense count: 2
768
- Style/OpMethod:
769
- Exclude:
770
- - 'lib/net/ssh/buffer.rb'
771
- - 'lib/net/ssh/version.rb'
748
+ Enabled: false
772
749
 
773
750
  # Offense count: 15
774
751
  # Cop supports --auto-correct.
@@ -784,27 +761,25 @@ Style/ParallelAssignment:
784
761
  - 'test/common.rb'
785
762
  - 'test/connection/test_channel.rb'
786
763
 
787
- # Offense count: 7
764
+ # Offense count: 5
788
765
  # Cop supports --auto-correct.
789
- # Configuration parameters: AllowSafeAssignment.
766
+ # Configuration parameters: AllowSafeAssignment, AllowInMultilineConditions.
790
767
  Style/ParenthesesAroundCondition:
791
768
  Exclude:
792
769
  - 'lib/net/ssh/authentication/ed25519.rb'
793
770
  - 'lib/net/ssh/service/forward.rb'
794
- - 'lib/net/ssh/transport/cipher_factory.rb'
795
771
  - 'lib/net/ssh/transport/ctr.rb'
796
772
  - 'test/integration/test_proxy.rb'
797
773
 
798
- # Offense count: 5
774
+ # Offense count: 33
799
775
  # Cop supports --auto-correct.
800
776
  # Configuration parameters: PreferredDelimiters.
801
777
  Style/PercentLiteralDelimiters:
802
778
  Exclude:
803
- - 'Rakefile'
804
779
  - 'net-ssh.gemspec'
805
780
  - 'test/test_config.rb'
806
781
 
807
- # Offense count: 16
782
+ # Offense count: 15
808
783
  # Cop supports --auto-correct.
809
784
  Style/PerlBackrefs:
810
785
  Exclude:
@@ -813,7 +788,6 @@ Style/PerlBackrefs:
813
788
  - 'lib/net/ssh/key_factory.rb'
814
789
  - 'lib/net/ssh/proxy/command.rb'
815
790
  - 'lib/net/ssh/proxy/socks5.rb'
816
- - 'lib/net/ssh/transport/openssl.rb'
817
791
  - 'test/integration/common.rb'
818
792
 
819
793
  # Offense count: 14
@@ -823,7 +797,7 @@ Style/Proc:
823
797
  - 'lib/net/ssh/connection/session.rb'
824
798
  - 'lib/net/ssh/test/channel.rb'
825
799
  - 'lib/net/ssh/transport/algorithms.rb'
826
- - 'lib/net/ssh/verifiers/secure.rb'
800
+ - 'lib/net/ssh/verifiers/always.rb'
827
801
  - 'test/authentication/methods/test_hostbased.rb'
828
802
  - 'test/authentication/methods/test_publickey.rb'
829
803
  - 'test/connection/test_channel.rb'
@@ -831,7 +805,7 @@ Style/Proc:
831
805
 
832
806
  # Offense count: 7
833
807
  # Cop supports --auto-correct.
834
- # Configuration parameters: EnforcedStyle, SupportedStyles.
808
+ # Configuration parameters: EnforcedStyle.
835
809
  # SupportedStyles: compact, exploded
836
810
  Style/RaiseArgs:
837
811
  Exclude:
@@ -842,7 +816,7 @@ Style/RaiseArgs:
842
816
  Style/RedundantBegin:
843
817
  Exclude:
844
818
  - 'lib/net/ssh/buffered_io.rb'
845
- - 'lib/net/ssh/verifiers/strict.rb'
819
+ - 'lib/net/ssh/verifiers/accept_new.rb'
846
820
  - 'test/manual/test_pageant.rb'
847
821
 
848
822
  # Offense count: 1
@@ -851,36 +825,53 @@ Style/RedundantParentheses:
851
825
  Exclude:
852
826
  - 'support/arcfour_check.rb'
853
827
 
854
- # Offense count: 57
828
+ # Offense count: 59
855
829
  # Cop supports --auto-correct.
856
830
  # Configuration parameters: AllowMultipleReturnValues.
857
831
  Style/RedundantReturn:
858
832
  Enabled: false
859
833
 
860
- # Offense count: 11
834
+ # Offense count: 14
861
835
  # Cop supports --auto-correct.
862
836
  Style/RedundantSelf:
863
837
  Exclude:
864
- - 'lib/net/ssh/authentication/ed25519.rb'
865
838
  - 'lib/net/ssh/connection/channel.rb'
866
839
  - 'lib/net/ssh/test/extensions.rb'
867
- - 'lib/net/ssh/transport/openssl.rb'
868
840
  - 'test/authentication/test_ed25519.rb'
869
841
 
870
- # Offense count: 4
842
+ # Offense count: 6
871
843
  # Cop supports --auto-correct.
872
844
  Style/RescueModifier:
873
845
  Exclude:
874
846
  - 'lib/net/ssh/service/forward.rb'
875
847
  - 'lib/net/ssh/transport/algorithms.rb'
876
848
 
877
- # Offense count: 1
849
+ # Offense count: 25
850
+ # Cop supports --auto-correct.
851
+ # Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist.
852
+ # Whitelist: present?, blank?, presence, try, try!
853
+ Style/SafeNavigation:
854
+ Exclude:
855
+ - 'lib/net/ssh/authentication/key_manager.rb'
856
+ - 'lib/net/ssh/authentication/methods/keyboard_interactive.rb'
857
+ - 'lib/net/ssh/authentication/methods/password.rb'
858
+ - 'lib/net/ssh/authentication/session.rb'
859
+ - 'lib/net/ssh/connection/channel.rb'
860
+ - 'lib/net/ssh/connection/event_loop.rb'
861
+ - 'lib/net/ssh/connection/session.rb'
862
+ - 'lib/net/ssh/key_factory.rb'
863
+ - 'lib/net/ssh/loggable.rb'
864
+ - 'lib/net/ssh/test/local_packet.rb'
865
+ - 'lib/net/ssh/transport/algorithms.rb'
866
+ - 'lib/net/ssh/transport/packet_stream.rb'
867
+
868
+ # Offense count: 2
878
869
  # Cop supports --auto-correct.
879
870
  Style/SelfAssignment:
880
871
  Exclude:
881
872
  - 'lib/net/ssh/config.rb'
882
873
 
883
- # Offense count: 8
874
+ # Offense count: 7
884
875
  # Cop supports --auto-correct.
885
876
  # Configuration parameters: AllowAsExpressionSeparator.
886
877
  Style/Semicolon:
@@ -888,11 +879,10 @@ Style/Semicolon:
888
879
  - 'lib/net/ssh/buffer.rb'
889
880
  - 'test/connection/test_channel.rb'
890
881
  - 'test/connection/test_session.rb'
891
- - 'test/transport/kex/test_ecdh_sha2_nistp256.rb'
892
882
 
893
883
  # Offense count: 2
894
884
  # Cop supports --auto-correct.
895
- # Configuration parameters: EnforcedStyle, SupportedStyles.
885
+ # Configuration parameters: EnforcedStyle.
896
886
  # SupportedStyles: only_raise, only_fail, semantic
897
887
  Style/SignalException:
898
888
  Exclude:
@@ -906,106 +896,9 @@ Style/SingleLineMethods:
906
896
  Exclude:
907
897
  - 'lib/net/ssh/buffered_io.rb'
908
898
 
909
- # Offense count: 16
910
- # Cop supports --auto-correct.
911
- Style/SpaceAfterColon:
912
- Exclude:
913
- - 'lib/net/ssh/authentication/ed25519.rb'
914
- - 'test/integration/test_ed25519_pkeys.rb'
915
- - 'test/verifiers/test_secure.rb'
916
-
917
- # Offense count: 254
918
- # Cop supports --auto-correct.
919
- Style/SpaceAfterComma:
920
- Enabled: false
921
-
922
- # Offense count: 132
923
- # Cop supports --auto-correct.
924
- # Configuration parameters: EnforcedStyle, SupportedStyles.
925
- # SupportedStyles: space, no_space
926
- Style/SpaceAroundEqualsInParameterDefault:
927
- Enabled: false
928
-
929
- # Offense count: 55
930
- # Cop supports --auto-correct.
931
- # Configuration parameters: AllowForAlignment.
932
- Style/SpaceAroundOperators:
933
- Enabled: false
934
-
935
- # Offense count: 6
936
- # Cop supports --auto-correct.
937
- # Configuration parameters: EnforcedStyle, SupportedStyles.
938
- # SupportedStyles: space, no_space
939
- Style/SpaceBeforeBlockBraces:
940
- Exclude:
941
- - 'lib/net/ssh/authentication/session.rb'
942
- - 'support/ssh_tunnel_bug.rb'
943
- - 'test/authentication/test_agent.rb'
944
- - 'test/connection/test_session.rb'
945
-
946
- # Offense count: 4
947
- # Cop supports --auto-correct.
948
- Style/SpaceBeforeComma:
949
- Exclude:
950
- - 'test/integration/test_forward.rb'
951
- - 'test/integration/test_proxy.rb'
952
-
953
- # Offense count: 3
954
- # Cop supports --auto-correct.
955
- # Configuration parameters: AllowForAlignment.
956
- Style/SpaceBeforeFirstArg:
957
- Exclude:
958
- - 'lib/net/ssh/transport/hmac/sha2_256_96.rb'
959
- - 'lib/net/ssh/transport/hmac/sha2_512_96.rb'
960
- - 'test/authentication/test_key_manager.rb'
961
-
962
- # Offense count: 10
963
- # Cop supports --auto-correct.
964
- # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
965
- # SupportedStyles: space, no_space
966
- Style/SpaceInsideBlockBraces:
967
- Exclude:
968
- - 'lib/net/ssh/authentication/session.rb'
969
- - 'lib/net/ssh/transport/ctr.rb'
970
- - 'support/ssh_tunnel_bug.rb'
971
- - 'test/authentication/test_agent.rb'
972
- - 'test/authentication/test_key_manager.rb'
973
- - 'test/start/test_user_nil.rb'
974
-
975
- # Offense count: 22
976
- # Cop supports --auto-correct.
977
- Style/SpaceInsideBrackets:
978
- Exclude:
979
- - 'Rakefile'
980
- - 'lib/net/ssh/transport/algorithms.rb'
981
- - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha1.rb'
982
- - 'test/integration/test_forward.rb'
983
- - 'test/start/test_options.rb'
984
-
985
- # Offense count: 69
986
- # Cop supports --auto-correct.
987
- # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
988
- # SupportedStyles: space, no_space, compact
989
- Style/SpaceInsideHashLiteralBraces:
990
- Enabled: false
991
-
992
- # Offense count: 13
993
- # Cop supports --auto-correct.
994
- Style/SpaceInsideParens:
995
- Exclude:
996
- - 'lib/net/ssh/transport/algorithms.rb'
997
- - 'lib/net/ssh/transport/openssl.rb'
998
-
999
- # Offense count: 3
1000
- # Cop supports --auto-correct.
1001
- Style/SpaceInsideRangeLiteral:
1002
- Exclude:
1003
- - 'lib/net/ssh/authentication/ed25519.rb'
1004
- - 'lib/net/ssh/transport/algorithms.rb'
1005
-
1006
- # Offense count: 22
899
+ # Offense count: 18
1007
900
  # Cop supports --auto-correct.
1008
- # Configuration parameters: EnforcedStyle, SupportedStyles.
901
+ # Configuration parameters: EnforcedStyle.
1009
902
  # SupportedStyles: use_perl_names, use_english_names
1010
903
  Style/SpecialGlobalVars:
1011
904
  Exclude:
@@ -1016,12 +909,10 @@ Style/SpecialGlobalVars:
1016
909
  - 'test/integration/test_forward.rb'
1017
910
  - 'test/manual/test_pageant.rb'
1018
911
  - 'test/test_all.rb'
1019
- - 'test_connection_close_shall_close_cannels.rb'
1020
- - 'test_kerberos_client2.rb'
1021
912
 
1022
- # Offense count: 1846
913
+ # Offense count: 1754
1023
914
  # Cop supports --auto-correct.
1024
- # Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
915
+ # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
1025
916
  # SupportedStyles: single_quotes, double_quotes
1026
917
  Style/StringLiterals:
1027
918
  Enabled: false
@@ -1042,52 +933,9 @@ Style/SymbolProc:
1042
933
 
1043
934
  # Offense count: 1
1044
935
  # Cop supports --auto-correct.
1045
- Style/Tab:
1046
- Exclude:
1047
- - 'lib/net/ssh/config.rb'
1048
-
1049
- # Offense count: 39
1050
- # Cop supports --auto-correct.
1051
- # Configuration parameters: EnforcedStyle, SupportedStyles.
1052
- # SupportedStyles: final_newline, final_blank_line
1053
- Style/TrailingBlankLines:
1054
- Enabled: false
1055
-
1056
- # Offense count: 255
1057
- # Cop supports --auto-correct.
1058
- # Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
1059
- # SupportedStyles: comma, consistent_comma, no_comma
1060
- Style/TrailingCommaInLiteral:
1061
- Exclude:
1062
- - 'lib/net/ssh/key_factory.rb'
1063
- - 'lib/net/ssh/transport/cipher_factory.rb'
1064
- - 'lib/net/ssh/transport/kex.rb'
1065
- - 'lib/net/ssh/transport/openssl.rb'
1066
- - 'test/transport/test_packet_stream.rb'
1067
-
1068
- # Offense count: 66
1069
- # Cop supports --auto-correct.
1070
- Style/TrailingWhitespace:
1071
- Enabled: false
1072
-
1073
- # Offense count: 1
1074
- # Cop supports --auto-correct.
1075
- # Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
1076
- # Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
1077
- Style/TrivialAccessors:
936
+ Style/UnneededCondition:
1078
937
  Exclude:
1079
- - 'test/transport/kex/test_diffie_hellman_group1_sha1.rb'
1080
-
1081
- # Offense count: 6
1082
- # Cop supports --auto-correct.
1083
- Style/UnlessElse:
1084
- Exclude:
1085
- - 'lib/net/ssh/buffer.rb'
1086
- - 'lib/net/ssh/transport/ctr.rb'
1087
- - 'test/transport/kex/test_ecdh_sha2_nistp256.rb'
1088
- - 'test/transport/kex/test_ecdh_sha2_nistp384.rb'
1089
- - 'test/transport/kex/test_ecdh_sha2_nistp521.rb'
1090
- - 'test/transport/test_server_version.rb'
938
+ - 'lib/net/ssh/proxy/command.rb'
1091
939
 
1092
940
  # Offense count: 4
1093
941
  # Cop supports --auto-correct.
@@ -1097,7 +945,7 @@ Style/UnneededInterpolation:
1097
945
  - 'lib/net/ssh/transport/session.rb'
1098
946
  - 'test/integration/test_forward.rb'
1099
947
 
1100
- # Offense count: 4
948
+ # Offense count: 15
1101
949
  # Cop supports --auto-correct.
1102
950
  Style/UnneededPercentQ:
1103
951
  Exclude:
@@ -1113,17 +961,22 @@ Style/WhileUntilDo:
1113
961
 
1114
962
  # Offense count: 3
1115
963
  # Cop supports --auto-correct.
1116
- # Configuration parameters: SupportedStyles, WordRegex.
964
+ # Configuration parameters: WordRegex.
1117
965
  # SupportedStyles: percent, brackets
1118
966
  Style/WordArray:
1119
967
  EnforcedStyle: percent
1120
968
  MinSize: 3
1121
969
 
1122
- # Offense count: 7
970
+ # Offense count: 4
1123
971
  # Cop supports --auto-correct.
1124
972
  Style/ZeroLengthPredicate:
1125
973
  Exclude:
1126
974
  - 'lib/net/ssh/buffered_io.rb'
1127
975
  - 'lib/net/ssh/connection/channel.rb'
1128
- - 'test/integration/test_forward.rb'
1129
- - 'test_connection_close_shall_close_cannels.rb'
976
+
977
+ # Offense count: 1636
978
+ # Cop supports --auto-correct.
979
+ # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
980
+ # URISchemes: http, https
981
+ Metrics/LineLength:
982
+ Max: 932