mumuki-laboratory 7.6.2 → 7.8.0

data/lib/mumuki/laboratory/version.rb

@@ -1,5 +1,5 @@
 module Mumuki
   module Laboratory
-    VERSION = '7.6.2'
+    VERSION = '7.8.0'
   end
 end

data/spec/controllers/confirmations_controller_spec.rb

@@ -15,6 +15,6 @@ describe ExerciseConfirmationsController, organization_workspace: :test do
     before { post :create, params: { exercise_id: reading.id } }
 
     it { expect(response.status).to eq 200 }
-    it { expect(response.body).to json_like(guide_finished_by_solution: true, class_for_progress_list_item: 'progress-list-item text-center success active') }
+    it { expect(response.body).to json_like(guide_finished_by_solution: true) }
   end
 end

data/spec/controllers/discussions_messages_controller_spec.rb

@@ -0,0 +1,73 @@
+require 'spec_helper'
+
+describe DiscussionsMessagesController, organization_workspace: :test do
+  let(:student) { create(:user, permissions: {student: 'test/*'}) }
+  let(:moderator) { create(:user, permissions: {moderator: 'test/*', student: 'test/*'}) }
+
+  let(:exercise) { create(:exercise) }
+  let(:discussion) { create(:discussion, item: exercise, organization: Organization.current) }
+
+  before { Organization.current.update! forum_enabled: true }
+
+  describe 'post' do
+    describe 'for student' do
+      before { set_current_user! student }
+      before { allow_any_instance_of(DiscussionsMessagesController).to receive(:message_params).and_return content: 'Need help' }
+      before { post :create, params: {discussion_id: discussion.id} }
+
+      it { expect(response.status).to eq 302 }
+      it { expect(discussion.messages.size).to eq 1 }
+      it { expect(discussion.messages.last.content).to eq 'Need help' }
+    end
+
+    describe 'for moderator' do
+      before { set_current_user! moderator }
+      before { allow_any_instance_of(DiscussionsMessagesController).to receive(:message_params).and_return content: 'Do this!' }
+      before { post :create, params: {discussion_id: discussion.id} }
+
+      it { expect(response.status).to eq 302 }
+      it { expect(discussion.messages.size).to eq 1 }
+      it { expect(discussion.messages.last.content).to eq 'Do this!' }
+    end
+  end
+
+  describe 'approve' do
+    let(:message) { create(:message, discussion: discussion, sender: student.uid) }
+
+    describe 'for student' do
+      before { set_current_user! student }
+      before { post :approve, params: {id: message.id, discussion_id: discussion.id} }
+
+      it { expect(response.status).to eq 403 }
+      it { expect(message.reload.approved).to be false }
+    end
+
+    describe 'for student' do
+      before { set_current_user! moderator }
+      before { post :approve, params: {id: message.id, discussion_id: discussion.id} }
+
+      it { expect(response.status).to eq 200 }
+      it { expect(message.reload.approved).to be true }
+    end
+  end
+
+  describe 'question' do
+    let(:message) { create(:message, discussion: discussion, sender: student.uid) }
+
+    describe 'for student' do
+      before { set_current_user! student }
+      before { post :question, params: {id: message.id, discussion_id: discussion.id} }
+
+      it { expect(response.status).to eq 403 }
+      it { expect(message.reload.not_actually_a_question).to be false }
+    end
+
+    describe 'for student' do
+      before { set_current_user! moderator }
+      before { post :question, params: {id: message.id, discussion_id: discussion.id} }
+
+      it { expect(response.status).to eq 200 }
+      it { expect(message.reload.not_actually_a_question).to be true }
+    end
+  end
+end

data/spec/controllers/exercise_solutions_controller_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe ExerciseSolutionsController, organization_workspace: :test do
   let(:user) { create(:user) }
   let(:problem) { create(:problem) }
-  let(:kids_problem) { create(:problem, layout: :input_kids) }
+  let(:kids_problem) { create(:problem, layout: :input_primary) }
   let!(:chapter) {
     create(:chapter, name: 'Functional Programming', lessons: [
       create(:lesson, exercises: [problem, kids_problem])
@@ -13,21 +13,56 @@ describe ExerciseSolutionsController, organization_workspace: :test do
   before { set_current_user! user }
 
   def post_problem(problem)
-    post :create, params: { exercise_id: problem.id, solution: { content: 'asd' } }
+    post :create, params: { exercise_id: problem.id, solution: { content: 'the content' } }
   end
 
 
-  describe 'when simple content is sent' do
+  context 'when submission contains client_result' do
+    let(:problem) { create(:problem) }
+    let(:assignment) { Assignment.last }
+
+    before { expect_any_instance_of(Language).to receive(:run_tests!).with(bridge_request) }
+    before do
+      post :create, params: {
+        exercise_id: problem.id,
+        solution: { content: 'the content' },
+        client_result: {
+          status: :passed_with_warnings,
+          test_results: [{title: 'everything works', status: 'passed'}]
+        }
+      }
+    end
+
+    let(:bridge_request) do
+      {
+        content: 'the content',
+        custom_expectations: "\n",
+        expectations: [],
+        extra: "",
+        locale: "en",
+        settings: {},
+        test: "dont care",
+        client_result: {
+          status: 'passed_with_warnings',
+          test_results: [{title: 'everything works', status: 'passed'}]
+        }
+      }
+    end
+
+    it { expect(assignment.solution).to eq 'the content' }
+  end
+
+  context 'when simple content is sent' do
     context 'for a non-kids exercise' do
       before { post_problem(problem) }
       let(:assignment) { Assignment.last }
 
       context 'without client-side interpolations' do
         it { expect(response.status).to eq 200 }
-        it { expect(assignment.solution).to eq('asd')}
+        it { expect(assignment.solution).to eq('the content')}
 
         it { expect(response.body).to json_eq({ status: :failed, guide_finished_by_solution: false },
-                                              except: [:class_for_progress_list_item, :html, :remaining_attempts_html]) }
+                                              except: [:html, :remaining_attempts_html]) }
 
 
         it 'does not include kids specific renders' do
@@ -54,7 +89,7 @@ describe ExerciseSolutionsController, organization_workspace: :test do
       before { post_problem(kids_problem) }
 
       it { expect(response.body).to json_eq({ status: :failed, guide_finished_by_solution: false },
-                                            except: [:class_for_progress_list_item, :html, :remaining_attempts_html,
+                                            except: [:html, :remaining_attempts_html,
                                                      :title_html, :button_html, :expectations, :test_results, :tips]) }
 
       it 'includes kids specific renders' do

data/spec/dummy/db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20200608132959) do
+ActiveRecord::Schema.define(version: 20200804191643) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -117,6 +117,11 @@ ActiveRecord::Schema.define(version: 20200608132959) do
     t.text "manual_evaluation_comment"
     t.integer "upvotes_count", default: 0
     t.bigint "organization_id"
+    t.integer "messages_count", default: 0
+    t.integer "validated_messages_count", default: 0
+    t.boolean "requires_moderator_response", default: true
+    t.string "last_moderator_access_by_id"
+    t.datetime "last_moderator_access_at"
     t.index ["initiator_id"], name: "index_discussions_on_initiator_id"
     t.index ["item_type", "item_id"], name: "index_discussions_on_item_type_and_item_id"
     t.index ["organization_id"], name: "index_discussions_on_organization_id"
@@ -143,7 +148,11 @@ ActiveRecord::Schema.define(version: 20200608132959) do
     t.integer "max_problem_submissions"
     t.integer "max_choice_submissions"
     t.boolean "results_hidden_for_choices", default: false
+    t.bigint "course_id"
+    t.integer "passing_criterion_type", default: 0
+    t.integer "passing_criterion_value"
     t.index ["classroom_id"], name: "index_exams_on_classroom_id", unique: true
+    t.index ["course_id"], name: "index_exams_on_course_id"
     t.index ["guide_id"], name: "index_exams_on_guide_id"
     t.index ["organization_id"], name: "index_exams_on_organization_id"
   end
@@ -288,6 +297,7 @@ ActiveRecord::Schema.define(version: 20200608132959) do
     t.boolean "read", default: false
     t.integer "discussion_id"
     t.boolean "approved", default: false
+    t.boolean "not_actually_a_question", default: false
   end
 
   create_table "organizations", id: :serial, force: :cascade do |t|
@@ -299,6 +309,7 @@ ActiveRecord::Schema.define(version: 20200608132959) do
     t.text "theme", default: "{}", null: false
     t.text "profile", default: "{}", null: false
     t.integer "progressive_display_lookahead"
+    t.boolean "incognito_mode_enabled"
     t.index ["book_id"], name: "index_organizations_on_book_id"
     t.index ["name"], name: "index_organizations_on_name", unique: true
   end
@@ -375,6 +386,7 @@ ActiveRecord::Schema.define(version: 20200608132959) do
     t.string "verified_last_name"
     t.bigint "avatar_id"
     t.datetime "disabled_at"
+    t.boolean "trusted_for_forum"
     t.index ["disabled_at"], name: "index_users_on_disabled_at"
     t.index ["last_organization_id"], name: "index_users_on_last_organization_id"
     t.index ["uid"], name: "index_users_on_uid", unique: true

data/spec/features/chapter_spec.rb

@@ -50,4 +50,21 @@ feature 'Chapters flow', organization_workspace: :test do
       expect(page).to have_text('endofunctors')
     end
   end
+
+  context 'incognito user' do
+    before { Organization.current.update! incognito_mode_enabled: true }
+    scenario 'show chapter, no appendix' do
+      visit "/chapters/#{chapter.id}"
+
+      expect(page).to have_text('Functional Programming')
+      expect(page).to have_text('The Basic Values')
+
+      expect(page).to have_text('Monads and Functors')
+      expect(page).to have_text('The Maybe Functor')
+
+      expect(page).to_not have_text('Appendix')
+
+      expect(page).to have_text('Sign in')
+    end
+  end
 end

data/spec/features/discussion_flow_spec.rb

@@ -0,0 +1,190 @@
+require 'spec_helper'
+
+feature 'Discussion Flow', organization_workspace: :test do
+
+  ## =============
+  ## Users
+  ## =============
+
+  let(:student) { create(:user, permissions: {student: 'test/*:other/*:empty/*'}) }
+  let(:another_student) { create(:user, permissions: {student: 'test/*:other/*:empty/*'}) }
+  let(:moderator) { create(:user, permissions: {moderator: 'test/*:other/*:empty/*', student: 'test/*:other/*:empty/*'}) }
+
+  ## =================
+  ## Organizations
+  ## =================
+
+  let(:test_organization) { Organization.locate! 'test' }
+  let(:other_organization) { create(:organization, name: 'other') }
+  let!(:empty_organization) { create(:organization, name: 'empty') }
+
+  ## ================================
+  ## Content for test_organization
+  ## ================================
+
+  let(:problem_1) { create(:problem) }
+  let(:problem_2) { create(:problem) }
+  let(:problem_3) { create(:problem) }
+
+  let!(:chapter) {
+    create(:chapter, lessons: [create(:lesson, exercises: [ problem_1, problem_2, problem_3])])
+  }
+
+  ## =====================================
+  ## Discussions for test_organization
+  ## =====================================
+
+  let(:problem_2_discussions) { create_list(:discussion, 5, initiator: another_student, item: problem_2, organization: test_organization) }
+  let(:problem_3_discussions) { create_list(:discussion, 5, initiator: student, item: problem_2, organization: test_organization) }
+  let!(:test_organization_discussions) { problem_2_discussions + problem_3_discussions }
+
+  ## ===================================
+  ## Content for other_organization
+  ## ===================================
+
+  let(:other_problem) { create(:problem) }
+  let!(:other_chapter) {
+    create(:chapter, book: other_organization.book, lessons: [create(:lesson, exercises: [other_problem])])
+  }
+
+  ## =====================================
+  ## Discussions for other_organization
+  ## =====================================
+
+  let(:other_problem_discussions) { create_list(:discussion, 5, initiator: student, item: problem_2, organization: other_organization) }
+  let!(:other_organization_discussions) { other_problem_discussions }
+
+  before { reindex_current_organization! }
+  before { reindex_organization! other_organization }
+  before { reindex_organization! empty_organization }
+
+  shared_examples 'no forum access' do
+    scenario 'has no forum access' do
+      visit current_path
+      expect(page).to have_text('You may have mistyped the address or the page may have moved')
+    end
+  end
+
+  context 'exercise discussions' do
+    let(:current_path) { "/exercises/#{problem_1.id}/discussions" }
+
+    context 'with no current user' do
+      it_behaves_like 'no forum access'
+    end
+
+    context 'with logged user' do
+      before { set_current_user! student }
+
+      context 'but no forum enabled' do
+        it_behaves_like 'no forum access'
+      end
+
+      context 'and forum enabled' do
+        before { Organization.current.update! forum_enabled: true }
+
+        scenario 'empty discussion list for problem 1' do
+          visit "/exercises/#{problem_1.id}/discussions"
+          expect(page).to have_text(problem_1.name)
+          expect(page).to have_text('It seems there isn\'t any question yet.')
+        end
+
+        scenario 'discussion list for problem 2' do
+          visit "/exercises/#{problem_2.id}/discussions"
+          expect(page).to have_text(problem_2.name)
+          problem_2_discussions.each do |discussion|
+            expect(page).to have_text(discussion.description)
+          end
+          expect(page).to have_text('Didn\'t find what you were looking for?')
+        end
+      end
+    end
+  end
+
+  context 'book discussions' do
+    let(:current_path) { '/discussions' }
+
+    context 'with no current user' do
+      it_behaves_like 'no forum access'
+    end
+
+    context 'with logged user' do
+      before { set_current_user! student }
+
+      context 'but no forum enabled' do
+        it_behaves_like 'no forum access'
+      end
+
+      context 'and forum enabled' do
+        before { Organization.current.update! forum_enabled: true }
+
+        context 'in empty organization' do
+          before { empty_organization.update! forum_enabled: true }
+          before { set_subdomain_host! 'empty' }
+          after { set_subdomain_host! 'test' }
+
+          scenario 'empty discussion list for book without discussions' do
+            visit current_path
+            expect(page).to have_text(empty_organization.book.name)
+            expect(page).to have_text('It seems there isn\'t any question yet.')
+          end
+
+        end
+
+        scenario 'discussion list for book with discussions' do
+          visit current_path
+          expect(page).to have_text(test_organization.book.name)
+          test_organization_discussions.each do |discussion|
+            expect(page).to have_text(discussion.description)
+          end
+          other_organization_discussions.each do |discussion|
+            expect(page).not_to have_text(discussion.description)
+          end
+          expect(page).not_to have_text('Didn\'t find what you were looking for?')
+          expect(page).not_to have_text('It seems there isn\'t any question yet.')
+        end
+      end
+    end
+  end
+
+  context 'exercise discussion' do
+    let(:current_path) { "/exercises/#{problem_2.id}/discussions/#{problem_2_discussions.first.id}" }
+    before { test_organization.switch! }
+
+    context 'with no current user' do
+      it_behaves_like 'no forum access'
+    end
+
+    context 'with logged student' do
+      before { set_current_user! student }
+
+      context 'but no forum enabled' do
+        it_behaves_like 'no forum access'
+      end
+
+      context 'and forum enabled' do
+        before { Organization.current.update! forum_enabled: true }
+
+        scenario 'newly created discussion' do
+          visit current_path
+          expect(page).to have_text(problem_2.name)
+          expect(page).to have_text('Open')
+          expect(page).to have_text('Messages')
+          expect(page).not_to have_xpath("//div[@class='discussion-actions']")
+        end
+
+        context 'for moderator' do
+          before { set_current_user! moderator }
+
+          scenario 'newly created discussion' do
+            visit current_path
+            expect(page).to have_text(problem_2.name)
+            expect(page).to have_text('Open')
+            expect(page).to have_text('Messages')
+            expect(page).to have_xpath("//div[@class='discussion-actions']")
+          end
+        end
+      end
+    end
+  end
+
+end

data/spec/features/exercise_flow_spec.rb

@@ -13,11 +13,11 @@ feature 'Exercise Flow', organization_workspace: :test do
   let(:problem_5) { build(:problem, name: 'Succ5', description: 'Description of Succ5', layout: :input_right, editor: :upload, hint: 'lele', language: gobstones) }
   let(:problem_6) { build(:problem, name: 'Succ6', description: 'Description of Succ6', layout: :input_right, editor: :hidden, language: haskell) }
   let(:problem_7) { build(:problem, name: 'Succ7', description: 'Description of Succ7', editor: :single_choice, choices: [{value: 'some choice', checked: true}]) }
-  let(:playground_1) { build(:playground, name: 'Succ5', description: 'Description of Succ4', layout: :input_right) }
-  let(:playground_2) { build(:playground, name: 'Succ6', description: 'Description of Succ4', layout: :input_right, extra: 'x = 4') }
+  let(:playground_1) { build(:playground, name: 'Succ5', description: 'Description of Succ4', layout: :input_bottom) }
+  let(:playground_2) { build(:playground, name: 'Succ6', description: 'Description of Succ4', layout: :input_bottom, extra: 'x = 4') }
   let!(:reading) { build(:reading, name: 'Reading about Succ', description: 'Lets understand succ history') }
   let!(:exercise_not_in_path) { create :exercise }
-  let(:kids_problem) { build(:problem, name: 'Kids prob', description: 'Description of kids prob', layout: :input_kids, hint: 'lele', language: gobstones) }
+  let(:kids_problem) { build(:problem, name: 'Kids prob', description: 'Description of kids prob', layout: :input_primary, hint: 'lele', language: gobstones) }
 
   let!(:chapter) {
     create(:chapter, name: 'Functional Programming', lessons: [
@@ -129,6 +129,12 @@ feature 'Exercise Flow', organization_workspace: :test do
       expect(page).to have_text('Solution')
       expect(page).to have_text('need a hint?')
       expect(page).to_not have_selector('.upload')
+
+      expect(page).to have_selector('#mu-exercise-id', )
+      expect(page).to have_selector('#mu-exercise-layout')
+
+      expect(page.find("#mu-exercise-id")['value']).to eq(problem_1.id.to_s)
+      expect(page.find("#mu-exercise-layout")['value']).to eq('input_right')
     end
 
     scenario 'visit exercise by id, hidden layout, no hint, not queriable language' do
@@ -142,6 +148,9 @@ feature 'Exercise Flow', organization_workspace: :test do
       expect(page).to_not have_text('Solution')
       expect(page).to_not have_text('need a hint?')
       expect(page).to_not have_selector('.upload')
+
+      expect(page.find("#mu-exercise-id")['value']).to eq(problem_2.id.to_s)
+      expect(page.find("#mu-exercise-layout")['value']).to eq('input_right')
     end
 
     scenario 'visit exercise by id, hidden layout, no hint, queriable language' do
@@ -152,6 +161,9 @@ feature 'Exercise Flow', organization_workspace: :test do
       expect(page).to_not have_text('Solution')
       expect(page).to_not have_text('need a hint?')
       expect(page).to_not have_selector('.upload')
+
+      expect(page.find("#mu-exercise-id")['value']).to eq(problem_6.id.to_s)
+      expect(page.find("#mu-exercise-layout")['value']).to eq('input_right')
     end
 
 
@@ -163,6 +175,9 @@ feature 'Exercise Flow', organization_workspace: :test do
       expect(page).to have_text('Solution')
       expect(page).to have_text('need a hint?')
       expect(page).to have_selector('.upload')
+
+      expect(page.find("#mu-exercise-id")['value']).to eq(problem_3.id.to_s)
+      expect(page.find("#mu-exercise-layout")['value']).to eq('input_right')
     end
 
     scenario 'visit exercise by id, upload layout, not queriable language' do
@@ -174,6 +189,9 @@ feature 'Exercise Flow', organization_workspace: :test do
       expect(page).to have_selector('.upload')
       expect(problem_5.language.extension).to eq('gbs')
       expect(page.find("//div[@class = 'form-group']/input")['accept']).to eq(".gbs")
+
+      expect(page.find("#mu-exercise-id")['value']).to eq(problem_5.id.to_s)
+      expect(page.find("#mu-exercise-layout")['value']).to eq('input_right')
     end
 
     scenario 'visit exercise by id, input_bottom layout, extra, no hint' do
@@ -185,6 +203,9 @@ feature 'Exercise Flow', organization_workspace: :test do
       expect(page).to have_text('Solution')
       expect(page).to_not have_text('need a hint?')
       expect(page).to_not have_selector('.upload')
+
+      expect(page.find("#mu-exercise-id")['value']).to eq(problem_4.id.to_s)
+      expect(page.find("#mu-exercise-layout")['value']).to eq('input_bottom')
     end
 
     scenario 'visit playground by id, no extra, no hint' do
@@ -195,6 +216,9 @@ feature 'Exercise Flow', organization_workspace: :test do
       expect(page).to_not have_text('Solution')
       expect(page).to_not have_text('need a hint?')
       expect(page).to_not have_selector('.upload')
+
+      expect(page.find("#mu-exercise-id")['value']).to eq(playground_1.id.to_s)
+      expect(page.find("#mu-exercise-layout")['value']).to eq('input_bottom')
     end
 
     scenario 'visit playground by id, with extra, no hint' do
@@ -206,6 +230,9 @@ feature 'Exercise Flow', organization_workspace: :test do
       expect(page).to_not have_text('need a hint?')
       expect(page).to have_text('x = 4')
       expect(page).to_not have_selector('.upload')
+
+      expect(page.find("#mu-exercise-id")['value']).to eq(playground_2.id.to_s)
+      expect(page.find("#mu-exercise-layout")['value']).to eq('input_bottom')
     end
 
     scenario 'visit inner reading by id' do
@@ -218,6 +245,9 @@ feature 'Exercise Flow', organization_workspace: :test do
       expect(page).to_not have_text('Solution')
       expect(page).to_not have_text('need a hint?')
       expect(page).to_not have_selector('.upload')
+
+      expect(page.find("#mu-exercise-id")['value']).to eq(reading.id.to_s)
+      expect(page.find("#mu-exercise-layout")['value']).to eq('input_bottom')
     end
 
     scenario 'visit solved choices exercise' do
@@ -246,4 +276,19 @@ feature 'Exercise Flow', organization_workspace: :test do
       expect(page).to have_xpath("//a[@title='Edit']")
     end
   end
+
+  context 'incognito user' do
+    before { Organization.current.update! incognito_mode_enabled: true }
+
+    scenario 'visit exercise transparently' do
+      visit "/exercises/#{problem_1.transparent_id}"
+
+      expect(page).to have_text('Succ1')
+      expect(page).to have_text('Console')
+      expect(page).to have_text('need a hint?')
+      expect(page).to have_text('Description of Succ1')
+
+      expect(page).to have_text('Sign in')
+    end
+  end
 end