mumuki-laboratory 7.6.2 → 7.8.0

data/spec/features/home_public_flow_spec.rb

@@ -91,4 +91,20 @@ feature 'public org', organization_workspace: :test do
       expect(user.reload.last_organization).to eq current_organization
     end
   end
+
+  context 'incognito user' do
+    before { current_organization.update! incognito_mode_enabled: true }
+    scenario 'from inside' do
+      Capybara.current_session.driver.header 'Referer', 'http://google.com'
+
+      visit '/'
+
+      expect(page).to have_text('ム mumuki')
+      expect(page).to have_text('First Steps')
+      expect(page).to have_selector('.chapter', text: 'Functional Programming')
+      expect(page).to have_text(current_organization.book.name)
+
+      expect(page).to have_text('Sign in')
+    end
+  end
 end

data/spec/features/menu_bar_spec.rb

@@ -1,7 +1,8 @@
 require 'spec_helper'
 
 feature 'menu bar' do
-  let(:chapter) { create(:chapter, lessons: [create(:lesson)]) }
+  let(:lesson) { create(:lesson, exercises: create_list(:exercise, 3))}
+  let(:chapter) { create(:chapter, lessons: [lesson]) }
   let(:book) { create(:book, chapters: [chapter], name: 'private', slug: 'mumuki/mumuki-the-private-book') }
   let(:private_organization) { create(:organization, name: 'private', book: book) }
 
@@ -32,6 +33,8 @@ feature 'menu bar' do
         expect(page).not_to have_text('Profile')
         expect(page).not_to have_text('Classroom')
         expect(page).not_to have_text('Bibliotheca')
+        expect(page).not_to have_text('Solve other\'s doubts')
+        expect(page).not_to have_text('My doubts')
       end
     end
   end
@@ -52,15 +55,91 @@ feature 'menu bar' do
       expect(page).to have_text('Profile')
       expect(page).not_to have_text('Classroom')
       expect(page).not_to have_text('Bibliotheca')
+      expect(page).not_to have_text('Solve other\'s doubts')
+      expect(page).not_to have_text('My doubts')
     end
 
-    scenario 'student should only see profile' do
-      set_current_user! visitor
+    context 'student with no discussions should' do
+      scenario 'only see profile if forum is not enabled' do
+        set_current_user! student
 
-      visit '/'
-      expect(page).to have_text('Profile')
-      expect(page).not_to have_text('Classroom')
-      expect(page).not_to have_text('Bibliotheca')
+        visit '/'
+        expect(page).to have_text('Profile')
+        expect(page).not_to have_text('Classroom')
+        expect(page).not_to have_text('Bibliotheca')
+        expect(page).not_to have_text('Solve other\'s doubts')
+        expect(page).not_to have_text('My doubts')
+      end
+
+      scenario 'see profile and solve_other_doubts links if forum is enabled' do
+        set_current_user! student
+        private_organization.update! forum_enabled: true
+
+        visit '/'
+        expect(page).to have_text('Profile')
+        expect(page).not_to have_text('Classroom')
+        expect(page).not_to have_text('Bibliotheca')
+        expect(page).to have_text('Solve other\'s doubts')
+        expect(page).not_to have_text('My doubts')
+      end
+    end
+
+    context 'student with discussions should' do
+      let(:discussion) { create(:discussion, item: lesson.exercises.last, initiator: student)}
+
+      scenario 'only see profile if forum is not enabled' do
+        set_current_user! student
+        student.subscribe_to! discussion
+
+        visit '/'
+        expect(page).to have_text('Profile')
+        expect(page).not_to have_text('Classroom')
+        expect(page).not_to have_text('Bibliotheca')
+        expect(page).not_to have_text('Solve other\'s doubts')
+        expect(page).not_to have_text('My doubts')
+      end
+
+      scenario 'see all discussions links if forum is enabled' do
+        set_current_user! student
+        private_organization.update! forum_enabled: true
+        student.subscribe_to! discussion
+
+        visit '/'
+        expect(page).to have_text('Profile')
+        expect(page).not_to have_text('Classroom')
+        expect(page).not_to have_text('Bibliotheca')
+        expect(page).to have_text('Solve other\'s doubts')
+        expect(page).to have_text('My doubts')
+      end
+
+      scenario 'only see profile if forum is enabled in a forum_only_for_trusted organization' do
+        set_current_user! student
+        student.subscribe_to! discussion
+        private_organization.update! forum_enabled: true
+        private_organization.update! forum_only_for_trusted: true
+
+        visit '/'
+        expect(page).to have_text('Profile')
+        expect(page).not_to have_text('Classroom')
+        expect(page).not_to have_text('Bibliotheca')
+        expect(page).not_to have_text('Solve other\'s doubts')
+        expect(page).not_to have_text('My doubts')
+      end
+
+      scenario 'see all discussions links if forum is enabled in a forum_only_for_trusted organization but it is trusted' do
+        student.update! trusted_for_forum: true
+        set_current_user! student
+        student.subscribe_to! discussion
+        private_organization.update! forum_enabled: true
+        private_organization.update! forum_only_for_trusted: true
+
+        visit '/'
+        expect(page).to have_text('Profile')
+        expect(page).not_to have_text('Classroom')
+        expect(page).not_to have_text('Bibliotheca')
+        expect(page).to have_text('Solve other\'s doubts')
+        expect(page).to have_text('My doubts')
+      end
     end
 
     scenario 'teacher should see profile and classroom' do
@@ -71,6 +150,8 @@ feature 'menu bar' do
       expect(page).to have_text('Profile')
       expect(page).to have_text('Classroom')
       expect(page).not_to have_text('Bibliotheca')
+      expect(page).not_to have_text('Solve other\'s doubts')
+      expect(page).not_to have_text('My doubts')
     end
 
     scenario 'writer should see profile and bibliotheca' do

data/spec/helpers/breadcrumbs_helper_spec.rb

@@ -91,7 +91,7 @@ describe BreadcrumbsHelper, organization_workspace: :test do
         expect(breadcrumb).to include('my lesson')
         expect(breadcrumb).to include('my exercise')
         expect(breadcrumb).to include('discussions')
-        expect(breadcrumb).to include(discussion.title)
+        expect(breadcrumb).to include(discussion.item.navigable_name)
         expect(breadcrumb).to be_html_safe
       end
     end

data/spec/javascripts/bridge-spec.js

@@ -0,0 +1,5 @@
+describe('bridge', () => {
+  it('can create bridge', () => {
+    expect(new mumuki.bridge.Laboratory()).not.toBe(null);
+  })
+})

data/spec/javascripts/csrf-token-spec.js

@@ -0,0 +1,7 @@
+describe('csrf token', () => {
+  it('can create token', () => {
+    expect(new mumuki.CsrfToken()).not.toBe(null);
+  })
+})
+
+

data/spec/javascripts/editors-spec.js

@@ -0,0 +1,54 @@
+describe('editors', () => {
+
+  beforeEach(() => {
+    mumuki.CustomEditor.clearSources()
+  })
+
+  it('has initially no sources', () => {
+    expect(mumuki.CustomEditor.hasSources).toBe(false)
+  });
+
+  it('can add a custom source', () => {
+    mumuki.editors.addCustomSource({
+      getContent() {
+        return { name: "solution[content]", value: 'the value' } ;
+      }
+    });
+
+    expect(mumuki.CustomEditor.hasSources).toBe(true);
+    expect(mumuki.CustomEditor.getContents()[0].value).toEqual('the value');
+    expect(mumuki.CustomEditor.getContents()[0].name).toEqual('solution[content]');
+  });
+
+  it('reads the custom sources if present, ignoring the form', () => {
+    $('body').html(`
+    <form role="form" class="new_solution">
+      <div class="field form-group editor-code">
+        <textarea class="form-control editor" name="solution[content]" id="solution_content">the standard solution</textarea>
+      </div>
+    </form>`)
+
+    mumuki.editors.addCustomSource({
+      getContent() {
+        return { name: "solution[content]", value: 'the custom solution' } ;
+      }
+    });
+
+    expect(mumuki.editors.getSubmission()).toEqual({"solution[content]":"the custom solution"});
+  });
+
+  it('reads the form if no sources', () => {
+    $('body').html(`
+    <form role="form" class="new_solution">
+      <div class="field form-group editor-code">
+        <textarea class="form-control editor" name="solution[content]" id="solution_content">the solution</textarea>
+      </div>
+    </form>`)
+    expect(mumuki.editors.getSubmission()).toEqual({"solution[content]":"the solution"});
+  });
+
+  it('produces empty submission if no form nor sources', () => {
+    $('body').html(``);
+    expect(mumuki.editors.getSubmission()).toEqual({});
+  });
+})

data/spec/javascripts/elipsis-spec.js

@@ -0,0 +1,25 @@
+describe('elipsis', () => {
+  it('does nothing when no elipsis', () => {
+    expect(mumuki.elipsis('hello')).toEqual('hello');
+  })
+
+  it('replaces student elipsis', () => {
+    expect(mumuki.elipsis(`function longitud(unString) {
+      /*<elipsis-for-student@*/
+      return unString.length;
+      /*@elipsis-for-student>*/
+    }`)).toEqual(`function longitud(unString) {
+      /* ... */
+    }`)
+  });
+
+  it('replaces student hidden', () => {
+    expect(mumuki.elipsis(`function longitud(unString) {
+      /*<hidden-for-student@*/
+      return unString.length;
+      /*@hidden-for-student>*/
+    }`)).toEqual(`function longitud(unString) {
+      /**/
+    }`)
+  });
+})

data/spec/javascripts/exercise-spec.js

@@ -0,0 +1,22 @@
+describe('exercise', () => {
+  it('current exercise information is available when present', () => {
+    $('body').html(`
+    <input type="hidden" name="mu-exercise-id" id="mu-exercise-id" value="3361" />
+    <input type="hidden" name="mu-exercise-layout" id="mu-exercise-layout" value="input_right" />`)
+
+    mumuki.exercise.load()
+
+    expect(mumuki.exercise.id).toBe(3361);
+    expect(mumuki.exercise.layout).toBe('input_right');
+  })
+
+  it('current exercise information is available when not present', () => {
+    $('body').html(``)
+
+    mumuki.exercise.load()
+
+    expect(mumuki.exercise.id).toBe(null);
+    expect(mumuki.exercise.layout).toBe(null);
+  })
+
+})

data/spec/javascripts/global-spec.js

@@ -0,0 +1,6 @@
+describe("global loading", () => {
+  it("produces no global loading errors", () => {
+    const error = window['__globalLoadingError__'];
+    expect(!error).toBe(true, `Expected no global loading errors but got ${error && error.message}`)
+  })
+})

data/spec/javascripts/results-renderers-spec.js

@@ -0,0 +1,17 @@
+describe('results renderers', () => {
+  it('can compute class for status', () => {
+    expect(mumuki.renderers.classForStatus('passed')).toEqual('success');
+  })
+
+  it('can compute icon for status', () => {
+    expect(mumuki.renderers.iconForStatus('pending')).toEqual('fa-circle');
+  })
+
+  it('can compute progress list item for status', () => {
+    expect(mumuki.renderers.progressListItemClassForStatus('passed_with_warnings')).toEqual('progress-list-item text-center warning ');
+  })
+
+  it('can compute progress list item for status when active', () => {
+    expect(mumuki.renderers.progressListItemClassForStatus('failed', true)).toEqual('progress-list-item text-center danger active');
+  })
+})

data/spec/javascripts/spec-helper.js

@@ -0,0 +1,34 @@
+// Teaspoon includes some support files, but you can use anything from your own support path too.
+// require support/jasmine-jquery-1.7.0
+// require support/jasmine-jquery-2.0.0
+// require support/jasmine-jquery-2.1.0
+// require support/sinon
+//
+// PhantomJS (Teaspoons default driver) doesn't have support for Function.prototype.bind, which has caused confusion.
+// Use this polyfill to avoid the confusion.
+//
+// You can require your own javascript files here. By default this will include everything in application, however you
+// may get better load performance if you require the specific files that are being used in the spec that tests them.
+//=require mumuki_laboratory/application
+//
+// Deferring execution
+// If you're using CommonJS, RequireJS or some other asynchronous library you can defer execution. Call
+// Teaspoon.execute() after everything has been loaded. Simple example of a timeout:
+//
+// Teaspoon.defer = true
+// setTimeout(Teaspoon.execute, 1000)
+//
+// Matching files
+// By default Teaspoon will look for files that match _spec.{js,js.coffee,.coffee}. Add a filename_spec.js file in your
+// spec path and it'll be included in the default suite automatically. If you want to customize suites, check out the
+// configuration in teaspoon_env.rb
+//
+// Manifest
+// If you'd rather require your spec files manually (to control order for instance) you can disable the suite matcher in
+// the configuration and use this file as a manifest.
+//
+// For more information: http://github.com/modeset/teaspoon
+
+window.addEventListener("error", (e) => {
+  window['__globalLoadingError__'] = e;
+});

data/spec/javascripts/speech-bubble-renderer-spec.js

@@ -0,0 +1,11 @@
+describe('results renderers', () => {
+  it('can render result item', () => {
+    expect(mumuki.renderers.renderSpeechBubbleResultItem('fix that')).toEqual(`
+        <div class="results-item">
+          <ul class="results-list">
+            <li>fix that</li>
+          </ul>
+        </div>`);
+  })
+
+})

data/spec/javascripts/submissions-store-spec.js

@@ -0,0 +1,44 @@
+describe("SubmissionsStore", () => {
+  const emptyProgramSubmission = {"solution[content]": "program {}"};
+  /** @type {SubmissionResult} */
+  const passedSubmissionResult = {status: 'passed'};
+  /** @type {SubmissionAndResult} */
+  const passedEmptyProgramSubmissionAndResult = { submission: emptyProgramSubmission, result: passedSubmissionResult };
+
+  beforeEach(() => {
+    window.localStorage.clear()
+  });
+
+  describe('getLastSubmission', () => {
+    it("answers null if submission not present", () => {
+      expect(mumuki.SubmissionsStore.getLastSubmissionAndResult(1)).toBe(null)
+    })
+
+    it("answers the last submission result if already sent", () => {
+      mumuki.SubmissionsStore.setSubmissionResultFor(1, passedEmptyProgramSubmissionAndResult)
+      expect(mumuki.SubmissionsStore.getLastSubmissionAndResult(1)).toEqual(passedEmptyProgramSubmissionAndResult)
+    })
+  })
+
+  describe('getLastSubmissionStatus', () => {
+    it("answers pending if submission not present", () => {
+      expect(mumuki.SubmissionsStore.getLastSubmissionStatus(1)).toBe('pending')
+    })
+
+    it("answers the last submission status if previously sent", () => {
+      mumuki.SubmissionsStore.setSubmissionResultFor(1, passedEmptyProgramSubmissionAndResult)
+      expect(mumuki.SubmissionsStore.getLastSubmissionStatus(1)).toBe('passed')
+    })
+  });
+
+  describe('getCachedResultFor', () => {
+    it("answers null if submission not present", () => {
+      expect(mumuki.SubmissionsStore.getSubmissionResultFor(1, emptyProgramSubmission)).toBe(null)
+    })
+
+    it("answers the last submission if previously sent", () => {
+      mumuki.SubmissionsStore.setSubmissionResultFor(1, passedEmptyProgramSubmissionAndResult)
+      expect(mumuki.SubmissionsStore.getSubmissionResultFor(1, emptyProgramSubmission)).toEqual(passedSubmissionResult)
+    })
+  });
+})

data/spec/javascripts/sync-mode-spec.js

@@ -0,0 +1,15 @@
+describe('sync mode', () => {
+  it('can choose server mode', () => {
+    mumuki.incognitoUser = false;
+    mumuki.syncMode._selectSyncMode();
+
+    expect(mumuki.syncMode._current instanceof mumuki.syncMode.ServerSyncMode).toBe(true);
+  })
+
+  it('can choose local mode', () => {
+    mumuki.incognitoUser = true;
+    mumuki.syncMode._selectSyncMode();
+
+    expect(mumuki.syncMode._current instanceof mumuki.syncMode.ClientSyncMode).toBe(true);
+  })
+})

data/spec/javascripts/timeout-spec.js

@@ -0,0 +1,5 @@
+describe('setTimeout', () => {
+  it('can create setTimeout', () => {
+    expect(mumuki.setTimeout).not.toBe(null);
+  })
+})

data/spec/javascripts/timer-spec.js

@@ -0,0 +1,5 @@
+describe('timer', () => {
+  it('can create timer', () => {
+    expect(mumuki.startTimer).not.toBe(null);
+  })
+})

data/spec/mailers/user_mailer_spec.rb

@@ -148,21 +148,21 @@ RSpec.describe UserMailer, type: :mailer do
 
       context "registered 1 week ago" do
         it { expect(user.should_remind?).to be true }
-        it { expect(reminder.body.encoded).to include("you've never submitted solutions") }
+        it { expect(reminder.body.encoded).to include('you've never submitted solutions') }
       end
 
       context "last submission 2 weeks ago" do
         let(:days_since_user_creation) { 16 }
 
         it { expect(user.should_remind?).to be true }
-        it { expect(reminder.body.encoded).to include("you've never submitted solutions") }
+        it { expect(reminder.body.encoded).to include('you've never submitted solutions') }
       end
 
       context "last submission 3 weeks ago" do
         let(:days_since_user_creation) { 26 }
 
         it { expect(user.should_remind?).to be true }
-        it { expect(reminder.body.encoded).to include("you've never submitted solutions") }
+        it { expect(reminder.body.encoded).to include('you've never submitted solutions') }
       end
 
       context "last submission 4 weeks ago" do
@@ -178,4 +178,19 @@ RSpec.describe UserMailer, type: :mailer do
       it { expect(user.should_remind?).to be false }
     end
   end
+
+  describe 'welcome email' do
+    let(:email) { UserMailer.welcome_email(user, organization) }
+
+    let(:non_custom_welcome_orga) { create :organization }
+    let(:custom_welcome_orga) { create :organization, welcome_email_template: 'hello <%= @user.first_name %>!' }
+
+    let(:user) { create :user, first_name: 'some name' }
+    
+    context 'when organization does have a custom welcome template' do
+      let(:organization) { custom_welcome_orga }
+
+      it { expect(email.body.encoded).to eq 'hello some name!' }
+    end
+  end
 end