moxml 0.1.7 → 0.1.8

data/spec/{support/shared_examples/integration.rb → integration/shared_examples/integration_workflows.rb}

@@ -5,6 +5,7 @@ RSpec.shared_examples "Moxml Integration" do
 
   describe "complete document workflow" do
     let(:doc) { context.create_document }
+
     before do
       # Create document with declaration
       doc.add_child(doc.create_declaration("1.0", "UTF-8"))
@@ -16,7 +17,8 @@ RSpec.shared_examples "Moxml Integration" do
       doc.add_child(root)
 
       # Add processing instruction
-      style_pi = doc.create_processing_instruction("xml-stylesheet", 'type="text/xsl" href="style.xsl"')
+      style_pi = doc.create_processing_instruction("xml-stylesheet",
+                                                   'type="text/xsl" href="style.xsl"')
       root.add_previous_sibling(style_pi)
 
       # Add mixed content
@@ -44,7 +46,7 @@ RSpec.shared_examples "Moxml Integration" do
         "<!-- Mixed content example -->",
         "<text>Some text <![CDATA[<with><markup/>]]> and more text</text>",
         '<item id="123" xs:type="custom"></item>',
-        "</root>"
+        "</root>",
       ]
 
       expected_xml_tags.each do |expected_xml|
@@ -54,7 +56,12 @@ RSpec.shared_examples "Moxml Integration" do
     end
 
     it "handles xpath queries" do
-      pending "Ox doesn't have a native XPath" if context.config.adapter_name == :ox
+      if context.config.adapter_name == :ox
+        pending "Ox doesn't support namespace-aware XPath with predicates"
+      end
+      if context.config.adapter_name == :headed_ox
+        skip "HeadedOx limitation: Namespace-aware XPath with predicates needs investigation. See docs/HEADED_OX_LIMITATIONS.md"
+      end
       # Test XPath queries
       #
       # XPath with a default namespace is a problem
@@ -69,7 +76,12 @@ RSpec.shared_examples "Moxml Integration" do
 
   describe "namespace handling" do
     it "handles complex namespace scenarios" do
-      pending "Ox doesn't have a native XPath" if context.config.adapter_name == :ox
+      if context.config.adapter_name == :ox
+        pending "Ox doesn't have a native XPath"
+      end
+      if context.config.adapter_name == :headed_ox
+        skip "HeadedOx limitation: Namespace methods not implemented in adapter. Requires Ox namespace API enhancement. See docs/HEADED_OX_LIMITATIONS.md"
+      end
       xml = <<~XML
         <root xmlns="http://default.org" xmlns:a="http://a.org" xmlns:b="http://b.org">
           <child>
@@ -110,7 +122,12 @@ RSpec.shared_examples "Moxml Integration" do
     let(:doc) { context.parse("<root><a>1</a><b>2</b></root>") }
 
     it "handles complex modifications" do
-      pending "Ox doesn't have a native XPath" if context.config.adapter_name == :ox
+      if context.config.adapter_name == :headed_ox
+        skip "HeadedOx limitation: Parent setter not implemented. Requires Ox node reparenting API. See docs/HEADED_OX_LIMITATIONS.md"
+      end
+      if context.config.adapter_name == :ox
+        skip "Ox doesn't have a native XPath"
+      end
 
       # Move nodes
       b_node = doc.at_xpath("//b")
@@ -132,7 +149,7 @@ RSpec.shared_examples "Moxml Integration" do
       expect(doc.root.children.map(&:name)).to eq(%w[b c a])
       expect(doc.to_xml).to include(
         '<root id="main">',
-        "<b>2<!-- comment --><![CDATA[<tag>]]></b>"
+        "<b>2<!-- comment --><![CDATA[<tag>]]></b>",
       )
     end
   end

data/spec/{support/shared_examples/cdata.rb → integration/shared_examples/node_wrappers/cdata_behavior.rb}

@@ -37,7 +37,12 @@ RSpec.shared_examples "Moxml::Cdata" do
 
     it "escapes CDATA end marker" do
       # pending for Ox: https://github.com/ohler55/ox/issues/377
-      pending "Ox doesn't escape the end token" if context.config.adapter_name == :ox
+      if context.config.adapter_name == :ox
+        pending "Ox doesn't escape the end token"
+      end
+      if context.config.adapter_name == :headed_ox
+        skip "HeadedOx limitation: Ox doesn't escape CDATA end markers. See docs/HEADED_OX_LIMITATIONS.md"
+      end
       cdata.content = "content]]>more"
       expect(cdata.to_xml).to eq("<![CDATA[content]]]]><![CDATA[>more]]>")
     end

data/spec/{support/shared_examples/comment.rb → integration/shared_examples/node_wrappers/comment_behavior.rb}

@@ -32,7 +32,8 @@ RSpec.shared_examples "Moxml::Comment" do
 
     it "raises an error on double hyphens" do
       expect { comment.content = "test -- comment" }
-        .to raise_error(Moxml::ValidationError, "XML comment cannot contain double hyphens (--)")
+        .to raise_error(Moxml::ValidationError,
+                        "XML comment cannot contain double hyphens (--)")
     end
 
     it "handles special characters" do

data/spec/{support/shared_examples/declaration.rb → integration/shared_examples/node_wrappers/declaration_behavior.rb}

@@ -36,7 +36,9 @@ RSpec.shared_examples "Moxml::Declaration" do
     end
 
     it "normalizes encoding" do
-      pending("Rexml Encoding upcases the string") if Moxml.new.config.adapter.name.include?("Rexml")
+      if Moxml.new.config.adapter.name.include?("Rexml")
+        pending("Rexml Encoding upcases the string")
+      end
       declaration.encoding = "utf-8"
       expect(declaration.encoding).to eq("utf-8")
     end
@@ -54,7 +56,8 @@ RSpec.shared_examples "Moxml::Declaration" do
 
     it "validates standalone value" do
       expect { declaration.standalone = "maybe" }
-        .to raise_error(Moxml::ValidationError, "Invalid standalone value: maybe")
+        .to raise_error(Moxml::ValidationError,
+                        "Invalid standalone value: maybe")
     end
 
     it "allows nil standalone" do

data/spec/{support/shared_examples/doctype.rb → integration/shared_examples/node_wrappers/doctype_behavior.rb}

@@ -7,7 +7,7 @@ RSpec.shared_examples "Moxml::Doctype" do
     doc.create_doctype(
       "html",
       "-//W3C//DTD HTML 4.01 Transitional//EN",
-      "http://www.w3.org/TR/html4/loose.dtd"
+      "http://www.w3.org/TR/html4/loose.dtd",
     )
   end
 
@@ -19,7 +19,7 @@ RSpec.shared_examples "Moxml::Doctype" do
     it "wraps content in doctype markers" do
       doc.add_child(doctype)
       expect(doc.to_xml.strip).to end_with(
-        '<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">'
+        '<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">',
       )
     end
   end

data/spec/{support/shared_examples/document.rb → integration/shared_examples/node_wrappers/document_behavior.rb}

@@ -103,7 +103,7 @@ RSpec.shared_examples "Moxml::Document" do
         '<?xml version="1.0" encoding="UTF-8"?>',
         "<root>",
         "<child>text</child>",
-        "</root>"
+        "</root>",
       )
     end
 

data/spec/{support/shared_examples/node.rb → integration/shared_examples/node_wrappers/node_behavior.rb}

@@ -96,7 +96,9 @@ RSpec.shared_examples "Moxml::Node" do
       let(:doc) { context.parse("<root><a><b>1</b></a><a><b>2</b></a></root>") }
 
       it "finds nodes by xpath" do
-        pending "Ox doesn't have a native XPath" if context.config.adapter_name == :ox
+        if context.config.adapter_name == :ox
+          pending "Ox doesn't have a native XPath"
+        end
 
         nodes = doc.xpath("//b")
         expect(nodes.size).to eq(2)
@@ -104,7 +106,12 @@ RSpec.shared_examples "Moxml::Node" do
       end
 
       it "finds first node by xpath" do
-        pending "Ox doesn't have a native XPath" if context.config.adapter_name == :ox
+        if context.config.adapter_name == :ox
+          pending "Ox doesn't have a native XPath"
+        end
+        if context.config.adapter_name == :headed_ox
+          skip "HeadedOx limitation: Text content access from nested elements needs investigation. See docs/HEADED_OX_LIMITATIONS.md"
+        end
 
         node = doc.at_xpath("//b")
         expect(node.text).to eq("1")

data/spec/{support/shared_examples/node_set.rb → integration/shared_examples/node_wrappers/node_set_behavior.rb}

@@ -25,47 +25,34 @@ RSpec.shared_examples "Moxml::NodeSet" do
 
     describe "enumeration" do
       it "iterates over nodes" do
-        pending "Ox doesn't have a native XPath" if context.config.adapter_name == :ox
-
-        texts = []
-        nodes.each { |node| texts << node.text }
+        texts = nodes.map(&:text)
         expect(texts).to eq(%w[First Second Third])
       end
 
       it "maps nodes" do
-        pending "Ox doesn't have a native XPath" if context.config.adapter_name == :ox
-
         texts = nodes.map(&:text)
         expect(texts).to eq(%w[First Second Third])
       end
 
       it "selects nodes" do
-        pending "Ox doesn't have a native XPath" if context.config.adapter_name == :ox
-
         selected = nodes.select { |node| node.text.include?("i") }
         expect(selected.size).to eq(2)
         expect(selected.map(&:text)).to eq(%w[First Third])
       end
 
       it "compares nodes" do
-        pending "Ox doesn't have a native XPath" if context.config.adapter_name == :ox
-
         expect(doc.xpath("//child")).to eq(doc.root.children)
       end
     end
 
     describe "access methods" do
       it "accesses by index" do
-        pending "Ox doesn't have a native XPath" if context.config.adapter_name == :ox
-
         expect(nodes[0].text).to eq("First")
         expect(nodes[1].text).to eq("Second")
         expect(nodes[-1].text).to eq("Third")
       end
 
       it "accesses by range" do
-        pending "Ox doesn't have a native XPath" if context.config.adapter_name == :ox
-
         subset = nodes[0..1]
         expect(subset).to be_a(described_class)
         expect(subset.size).to eq(2)
@@ -73,8 +60,6 @@ RSpec.shared_examples "Moxml::NodeSet" do
       end
 
       it "provides first and last" do
-        pending "Ox doesn't have a native XPath" if context.config.adapter_name == :ox
-
         expect(nodes.first.text).to eq("First")
         expect(nodes.last.text).to eq("Third")
       end
@@ -95,8 +80,6 @@ RSpec.shared_examples "Moxml::NodeSet" do
 
     describe "concatenation" do
       it "combines node sets" do
-        pending "Ox doesn't have a native XPath" if context.config.adapter_name == :ox
-
         other_doc = context.parse("<root><item>Fourth</item></root>")
         other_nodes = other_doc.xpath("//item")
         combined = nodes + other_nodes

data/spec/{support/shared_examples/processing_instruction.rb → integration/shared_examples/node_wrappers/processing_instruction_behavior.rb}

@@ -3,7 +3,10 @@
 RSpec.shared_examples "Moxml::ProcessingInstruction" do
   let(:context) { Moxml.new }
   let(:doc) { context.create_document }
-  let(:pi) { doc.create_processing_instruction("xml-stylesheet", 'href="style.xsl" type="text/xsl"') }
+  let(:pi) do
+    doc.create_processing_instruction("xml-stylesheet",
+                                      'href="style.xsl" type="text/xsl"')
+  end
 
   it "identifies as processing instruction node" do
     expect(pi).to be_processing_instruction
@@ -76,7 +79,8 @@ RSpec.shared_examples "Moxml::ProcessingInstruction" do
 
   describe "common use cases" do
     it "creates stylesheet instruction" do
-      pi = doc.create_processing_instruction("xml-stylesheet", 'type="text/xsl" href="style.xsl"')
+      pi = doc.create_processing_instruction("xml-stylesheet",
+                                             'type="text/xsl" href="style.xsl"')
       expect(pi.to_xml).to eq('<?xml-stylesheet type="text/xsl" href="style.xsl"?>')
     end
 

data/spec/moxml/README.md

@@ -0,0 +1,41 @@
+# Unit Tests
+
+## Purpose
+
+This directory contains pure unit tests for individual classes without adapter switching. Each test focuses on a single class's behavior, state management, and convenience APIs.
+
+## What Should Be Placed Here
+
+- ✅ Tests for individual class methods
+- ✅ Tests for convenience APIs (e.g., `Element#set_attributes`)
+- ✅ Tests for internal utilities
+- ✅ Tests for configuration and setup
+- ✅ Tests that use a single adapter (usually the default)
+- ✅ Tests for class-level functionality independent of adapter implementation
+
+## What Should NOT Be Placed Here
+
+- ❌ Tests that switch between multiple adapters
+- ❌ Tests for cross-adapter behavior
+- ❌ Integration tests that involve multiple classes
+- ❌ Performance benchmarks
+- ❌ Documentation examples
+
+## How to Run
+
+```bash
+# Run all unit tests
+bundle exec rake spec:unit
+
+# Run specific unit test file
+bundle exec rspec spec/unit/moxml/element_spec.rb
+```
+
+## Directory Structure
+
+```
+unit/
+├── moxml/              # Core moxml classes
+│   ├── adapter/        # Adapter registry and base
+│   └── xml_utils/      # Utility classes
+└── moxml_spec.rb       # Top-level module tests

data/spec/moxml/adapter/README.md

@@ -0,0 +1,61 @@
+# Adapter Tests
+#
+# ## Purpose
+#
+# This directory contains tests for adapter implementations. Each test verifies that an adapter correctly implements the adapter API contract and tests adapter-specific features.
+#
+# ## What Should Be Placed Here
+#
+# - ✅ Tests for adapter API contract compliance (parse, create_*, serialize, xpath, etc.)
+# - ✅ Tests for adapter-specific features
+# - ✅ Tests for adapter workarounds/customizations
+# - ✅ Each adapter tested independently
+# - ✅ Adapter initialization and configuration tests
+#
+# ## What Should NOT Be Placed Here
+#
+# - ❌ Tests for high-level wrapper behavior (use integration/ instead)
+# - ❌ Tests for cross-adapter consistency (use consistency/ instead)
+# - ❌ Tests for Moxml wrapper classes
+# - ❌ Performance benchmarks (use performance/ instead)
+#
+# ## How to Run
+#
+# ```bash
+# # Run all adapter tests
+# bundle exec rake spec:adapter
+#
+# # Run specific adapter test
+# bundle exec rspec spec/moxml/adapter/nokogiri_spec.rb
+# ```
+#
+# ## Directory Structure
+#
+# ```
+# moxml/adapter/
+# ├── shared_examples/
+# │   └── adapter_contract.rb    # Defines the adapter API contract
+# ├── base_spec.rb               # Base adapter tests
+# ├── libxml_spec.rb             # LibXML adapter implementation
+# ├── nokogiri_spec.rb           # Nokogiri adapter implementation
+# ├── oga_spec.rb                # Oga adapter implementation
+# ├── ox_spec.rb                 # Ox adapter implementation
+# └── rexml_spec.rb              # REXML adapter implementation
+# ```
+#
+# ## Adding a New Adapter
+#
+# When adding a new adapter:
+#
+# 1. Create `spec/moxml/adapter/<adapter_name>_spec.rb`
+# 2. Include the adapter contract:
+#    ```ruby
+#    RSpec.describe Moxml::Adapter::YourAdapter do
+#      around do |example|
+#        Moxml.with_config(:your_adapter, true, "UTF-8") do
+#          example.run
+#        end
+#      end
+#
+#      it_behaves_like "adapter contract"
+#    end

data/spec/moxml/adapter/base_spec.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+RSpec.describe Moxml::Adapter::Base do
+  describe ".name" do
+    it "returns adapter name" do
+      expect(described_class.name).to include("Base")
+    end
+  end
+
+  describe "interface methods" do
+    it "defines parse method" do
+      expect(described_class).to respond_to(:parse)
+    end
+
+    it "defines create_document method" do
+      expect(described_class).to respond_to(:create_document)
+    end
+
+    it "defines serialize method" do
+      # Base class doesn't implement serialize - each adapter does
+      # This is tested in the individual adapter specs
+      skip "Serialize is adapter-specific, not in Base"
+    end
+  end
+end