moose-inventory 2.0 → 2.1

data/spec/lib/moose_inventory/cli/host_rmgroup_spec.rb

@@ -1,43 +1,24 @@
+# frozen_string_literal: true
+
+# rubocop:disable Metrics/BlockLength
 require 'spec_helper'
 
-# TODO: the usual respond_to? method doesn't seem to work on Thor objects.
 # Why not? For now, we'll check against instance_methods.
 
 RSpec.describe Moose::Inventory::Cli::Host do
   before(:all) do
-    # Set up the configuration object
-    @mockarg_parts = {
-      config:  File.join(spec_root, 'config/config.yml'),
-      format:  'yaml',
-      env:     'test',
-    }
-
-    @mockargs = []
-    @mockarg_parts.each do |key, val|
-      @mockargs << "--#{key}"
-      @mockargs << val
-    end
-
-    @console = Moose::Inventory::Cli::Formatter
-    @config = Moose::Inventory::Config
-    @config.init(@mockargs)
-
-    @db = Moose::Inventory::DB
-    @db.init if @db.db.nil?
-
-    @host = Moose::Inventory::Cli::Host
-    @app = Moose::Inventory::Cli::Application
+    setup_cli_harness(command_class: Moose::Inventory::Cli::Host, command_ivar: :@host)
   end
 
   before(:each) do
-    @db.reset
+    reset_cli_harness
   end
 
   #====================
   describe 'rmgroup' do
     #----------------
     it 'should be responsive' do
-      result = @host.instance_methods(false).include?(:rmgroup)
+      result = @host.method_defined?(:rmgroup, false)
       expect(result).to eq(true)
     end
 
@@ -46,7 +27,7 @@ RSpec.describe Moose::Inventory::Cli::Host do
     #------------------------
     it 'host rmgroup <missing args> ... should abort with an error' do
       actual = runner do
-        @app.start(%w(host rmgroup)) # <- no group given
+        @app.start(%w[host rmgroup]) # <- no group given
       end
 
       # Check output
@@ -60,16 +41,16 @@ RSpec.describe Moose::Inventory::Cli::Host do
       host_name = 'not-a-host'
       group_name = 'example'
       actual = runner do
-        @app.start(%W(host rmgroup #{host_name} #{group_name}))
+        @app.start(%W[host rmgroup #{host_name} #{group_name} --yes])
       end
 
       # Check output
       desired = { aborted: true }
       desired[:STDOUT] =
-        "Dissociate host '#{host_name}' from groups '#{group_name}':\n"\
-        "  - Retrieve host '#{host_name}'...\n"
+        "Dissociate host '#{host_name}' from groups '#{group_name}':\n  " \
+        "- Retrieve host '#{host_name}'...\n"
       desired[:STDERR] =
-        "An error occurred during a transaction, any changes have been rolled back.\n"\
+        "An error occurred during a transaction, any changes have been rolled back.\n" \
         "ERROR: The host '#{host_name}' was not found in the database.\n"
       expected(actual, desired)
     end
@@ -81,10 +62,10 @@ RSpec.describe Moose::Inventory::Cli::Host do
       #    if it has no other groups.
 
       host_name = 'test1'
-      runner { @app.start(%W(host add #{host_name})) }
+      runner { @app.start(%W[host add #{host_name}]) }
 
-      group_names = %w(group1 group2)
-      tmp = runner { @app.start(%W(host addgroup #{host_name} #{group_names[0]} #{group_names[1]})) }
+      group_names = %w[group1 group2]
+      runner { @app.start(%W[host addgroup #{host_name} #{group_names[0]} #{group_names[1]}]) }
 
       #
       # Dissociate from the first group
@@ -92,23 +73,20 @@ RSpec.describe Moose::Inventory::Cli::Host do
       # 2. expect that no association with ungrouped is made.
 
       actual = runner do
-        @app.start(%W(host rmgroup #{host_name} #{group_names[0]}))
+        @app.start(%W[host rmgroup #{host_name} #{group_names[0]} --yes])
       end
       # @console.dump(actual, 'y')
 
-      # rubocop:disable Metrics/LineLength
       desired = { aborted: false }
       desired[:STDOUT] =
-        "Dissociate host '#{host_name}' from groups '#{group_names[0]}':\n"\
-        "  - Retrieve host '#{host_name}'...\n"\
-        "    - OK\n"\
-        "  - Remove association {host:#{host_name} <-> group:#{group_names[0]}}...\n"\
-        "    - OK\n"\
-        "  - All OK\n"\
+        "Dissociate host '#{host_name}' from groups '#{group_names[0]}':\n  " \
+        "- Retrieve host '#{host_name}'...\n    " \
+        "- OK\n  " \
+        "- Remove association {host:#{host_name} <-> group:#{group_names[0]}}...\n    " \
+        "- OK\n  " \
+        "- All OK\n" \
         "Succeeded\n"
       expected(actual, desired)
-      # rubocop:enable Metrics/LineLength
-
       # We should have the correct group associations
       host = @db.models[:host].find(name: host_name)
       groups = host.groups_dataset
@@ -122,24 +100,21 @@ RSpec.describe Moose::Inventory::Cli::Host do
       # 1. expect that the group association is removed
       # 2. expect that an association will be made with 'ungrouped'.
       actual = runner do
-        @app.start(args = %W(host rmgroup #{host_name} #{group_names[1]}))
+        @app.start(%W[host rmgroup #{host_name} #{group_names[1]} --yes])
       end
 
-      # rubocop:disable Metrics/LineLength
       desired = { aborted: false }
       desired[:STDOUT] =
-        "Dissociate host '#{host_name}' from groups '#{group_names[1]}':\n"\
-        "  - Retrieve host '#{host_name}'...\n"\
-        "    - OK\n"\
-        "  - Remove association {host:#{host_name} <-> group:#{group_names[1]}}...\n"\
-        "    - OK\n"\
-        "  - Add automatic association {host:#{host_name} <-> group:ungrouped}...\n"\
-        "    - OK\n"\
-        "  - All OK\n"\
+        "Dissociate host '#{host_name}' from groups '#{group_names[1]}':\n  " \
+        "- Retrieve host '#{host_name}'...\n    " \
+        "- OK\n  " \
+        "- Remove association {host:#{host_name} <-> group:#{group_names[1]}}...\n    " \
+        "- OK\n  " \
+        "- Add automatic association {host:#{host_name} <-> group:ungrouped}...\n    " \
+        "- OK\n  " \
+        "- All OK\n" \
         "Succeeded\n"
       expected(actual, desired)
-      # rubocop:enable Metrics/LineLength
-
       # We should have the correct group associations
       host = @db.models[:host].find(name: host_name)
       groups = host.groups_dataset
@@ -149,6 +124,23 @@ RSpec.describe Moose::Inventory::Cli::Host do
       expect(groups[name: 'ungrouped']).not_to be_nil
     end
 
+    #------------------------
+    it 'host rmgroup HOST GROUP --dry-run should not remove membership or add ungrouped' do
+      host_name = 'test1'
+      group_name = 'group1'
+      runner { @app.start(%W[host add #{host_name}]) }
+      runner { @app.start(%W[host addgroup #{host_name} #{group_name}]) }
+
+      actual = runner { @app.start(%W[host rmgroup #{host_name} #{group_name} --dry-run]) }
+
+      expect(actual[:unexpected]).to eq(false)
+      expect(actual[:aborted]).to eq(false)
+      expect(actual[:STDOUT]).to include('Dry run complete. No changes applied.')
+      host = @db.models[:host].find(name: host_name)
+      expect(host.groups_dataset[name: group_name]).not_to be_nil
+      expect(host.groups_dataset[name: 'ungrouped']).to be_nil
+    end
+
     #------------------------
     it 'host rmgroup HOST GROUP ... should warn about non-existing associations' do
       # 1. Should warn that the group doesn't exist.
@@ -156,22 +148,21 @@ RSpec.describe Moose::Inventory::Cli::Host do
 
       host_name = 'test1'
       group_name = 'no-group'
-      runner { @app.start(%W(host add #{host_name})) }
+      runner { @app.start(%W[host add #{host_name}]) }
 
       actual = runner do
-        @app.start(%W(host rmgroup #{host_name} #{group_name}))
+        @app.start(%W[host rmgroup #{host_name} #{group_name} --yes])
       end
 
-      # rubocop:disable Metrics/LineLength
       desired = { aborted: false }
       desired[:STDOUT] =
-        "Dissociate host '#{host_name}' from groups '#{group_name}':\n"\
-        "  - Retrieve host \'#{host_name}\'...\n"\
-        "    - OK\n"\
-        "  - Remove association {host:#{host_name} <-> group:#{group_name}}...\n"\
-        "    - Doesn't exist, skipping.\n"\
-        "    - OK\n"\
-        "  - All OK\n"\
+        "Dissociate host '#{host_name}' from groups '#{group_name}':\n  " \
+        "- Retrieve host '#{host_name}'...\n    " \
+        "- OK\n  " \
+        "- Remove association {host:#{host_name} <-> group:#{group_name}}...\n    " \
+        "- Doesn't exist, skipping.\n    " \
+        "- OK\n  " \
+        "- All OK\n" \
         "Succeeded\n"
       desired[:STDERR] = "WARNING: Association {host:#{host_name} <-> group:#{group_name}} doesn't exist, skipping.\n"
 
@@ -183,9 +174,9 @@ RSpec.describe Moose::Inventory::Cli::Host do
       name = 'test1'
       groupname = 'ungrouped'
 
-      runner { @app.start(%W(host add #{name})) }
+      runner { @app.start(%W[host add #{name}]) }
 
-      actual = runner { @app.start(%W(host rmgroup #{name} #{groupname})) }
+      actual = runner { @app.start(%W[host rmgroup #{name} #{groupname} --yes]) }
 
       desired = { aborted: true }
       desired[:STDERR] =
@@ -194,41 +185,39 @@ RSpec.describe Moose::Inventory::Cli::Host do
     end
 
     #------------------------
-    it 'host rmgroup GROUP1 GROUP1 ... should dissociate the host from'\
-      ' multiple groups at once' do
+    it 'host rmgroup GROUP1 GROUP1 ... should dissociate the host from ' \
+       'multiple groups at once' do
       # 1. Should rm the host to the group
       # 2. Should add the host from the 'ungrouped' automatic group
       #    if it has no other groups.
 
       host_name = 'test1'
-      runner { @app.start(%W(host add #{host_name})) }
+      runner { @app.start(%W[host add #{host_name}]) }
 
-      group_names = %w(group1 group2)
+      group_names = %w[group1 group2]
       group_names.each do |group|
-        runner { @app.start(%W(host addgroup #{host_name} #{group})) }
+        runner { @app.start(%W[host addgroup #{host_name} #{group}]) }
       end
 
       actual = runner do
-        @app.start(%W(host rmgroup #{host_name}) + group_names)
+        @app.start(%W[host rmgroup #{host_name} --yes] + group_names)
       end
       desired = { aborted: false }
       desired[:STDOUT] =
-        "Dissociate host '#{host_name}' from groups '#{group_names.join(',')}':\n"\
-        "  - Retrieve host \'#{host_name}\'...\n"\
-        "    - OK\n"
+        "Dissociate host '#{host_name}' from groups '#{group_names.join(',')}':\n  " \
+        "- Retrieve host '#{host_name}'...\n    " \
+        "- OK\n"
       group_names.each do |group|
         desired[:STDOUT] = desired[:STDOUT] +
-                           "  - Remove association {host:#{host_name} <-> group:#{group}}...\n"\
-                           "    - OK\n"\
+                           "  - Remove association {host:#{host_name} <-> group:#{group}}...\n    " \
+                           "- OK\n" \
       end
       desired[:STDOUT] = desired[:STDOUT] +
-                         "  - Add automatic association {host:#{host_name} <-> group:ungrouped}...\n"\
-                         "    - OK\n"\
-                         "  - All OK\n"\
+                         "  - Add automatic association {host:#{host_name} <-> group:ungrouped}...\n    " \
+                         "- OK\n  " \
+                         "- All OK\n" \
                          "Succeeded\n"
       expected(actual, desired)
-      # rubocop:enable Metrics/LineLength
-
       # We should have the correct group associations
       host = @db.models[:host].find(name: host_name)
       groups = host.groups_dataset
@@ -240,3 +229,4 @@ RSpec.describe Moose::Inventory::Cli::Host do
     end
   end
 end
+# rubocop:enable Metrics/BlockLength

data/spec/lib/moose_inventory/cli/host_rmvar_spec.rb

@@ -1,48 +1,29 @@
+# frozen_string_literal: true
+
+# rubocop:disable Metrics/BlockLength
 require 'spec_helper'
 
-# TODO: the usual respond_to? method doesn't seem to work on Thor objects.
 # Why not? For now, we'll check against instance_methods.
 
 RSpec.describe Moose::Inventory::Cli::Host do
   before(:all) do
-    # Set up the configuration object
-    @mockarg_parts = {
-      config:  File.join(spec_root, 'config/config.yml'),
-      format:  'yaml',
-      env:     'test',
-    }
-
-    @mockargs = []
-    @mockarg_parts.each do |key, val|
-      @mockargs << "--#{key}"
-      @mockargs << val
-    end
-
-    @config = Moose::Inventory::Config
-    @config.init(@mockargs)
-
-    @db = Moose::Inventory::DB
-    @db.init if @db.db.nil?
-
-    @console = Moose::Inventory::Cli::Formatter
-    @host = Moose::Inventory::Cli::Host
-    @app = Moose::Inventory::Cli::Application
+    setup_cli_harness(command_class: Moose::Inventory::Cli::Host, command_ivar: :@host)
   end
 
   before(:each) do
-    @db.reset
+    reset_cli_harness
   end
 
   describe 'rmvar' do
     it 'should be responsive' do
-      result = @host.instance_methods(false).include?(:rmvar)
+      result = @host.method_defined?(:rmvar, false)
       expect(result).to eq(true)
     end
 
     #-----------------
     it '<missing args> ... should abort with an error' do
       actual = runner  do
-        @app.start(%w(host rmvar)) # <- no group given
+        @app.start(%w[host rmvar]) # <- no group given
       end
 
       # Check output
@@ -56,16 +37,16 @@ RSpec.describe Moose::Inventory::Cli::Host do
       host_name = 'not-a-host'
       var_name = 'foo=bar'
       actual = runner do
-        @app.start(%W(host rmvar #{host_name} #{var_name}))
+        @app.start(%W[host rmvar #{host_name} #{var_name} --yes])
       end
 
       # Check output
       desired = { aborted: true }
       desired[:STDOUT] =
-        "Remove variable(s) '#{var_name}' from host '#{host_name}':\n"\
-        "  - retrieve host '#{host_name}'...\n"
+        "Remove variable(s) '#{var_name}' from host '#{host_name}':\n  " \
+        "- retrieve host '#{host_name}'...\n"
       desired[:STDERR] =
-        "An error occurred during a transaction, any changes have been rolled back.\n"\
+        "An error occurred during a transaction, any changes have been rolled back.\n" \
         "ERROR: The host '#{host_name}' does not exist.\n"
       expected(actual, desired)
     end
@@ -77,29 +58,27 @@ RSpec.describe Moose::Inventory::Cli::Host do
 
       host_name = 'test1'
       @db.models[:host].create(name: host_name)
-
-      var = { name: 'foo', value: 'bar' }
-      cases = %w(
+      cases = %w[
         =bar
         foo=bar=
         =foo=bar
         foo=bar=extra
-      )
+      ]
 
       cases.each do |args|
         actual = runner do
-          @app.start(%W(host rmvar #{host_name} #{args}))
+          @app.start(%W[host rmvar #{host_name} #{args} --yes])
         end
         # @console.out(actual,'p')
 
         desired = { aborted: true }
         desired[:STDOUT] =
-          "Remove variable(s) '#{args}' from host '#{host_name}':\n"\
-          "  - retrieve host '#{host_name}'...\n"\
-          "    - OK\n"\
-          "  - remove variable '#{args}'...\n"
+          "Remove variable(s) '#{args}' from host '#{host_name}':\n  " \
+          "- retrieve host '#{host_name}'...\n    " \
+          "- OK\n  " \
+          "- remove variable '#{args}'...\n"
         desired[:STDERR] =
-          "An error occurred during a transaction, any changes have been rolled back.\n"\
+          "An error occurred during a transaction, any changes have been rolled back.\n" \
           "ERROR: Incorrect format in {#{args}}. Expected 'key' or 'key=value'.\n"
 
         expected(actual, desired)
@@ -107,6 +86,20 @@ RSpec.describe Moose::Inventory::Cli::Host do
     end
 
     #------------------------
+    it 'host rmvar HOST key --dry-run should not remove the host variable' do
+      host_name = 'test1'
+      @db.models[:host].create(name: host_name)
+      runner { @app.start(%W[host addvar #{host_name} var1=val1]) }
+
+      actual = runner { @app.start(%W[host rmvar #{host_name} var1 --dry-run]) }
+
+      expect(actual[:unexpected]).to eq(false)
+      expect(actual[:aborted]).to eq(false)
+      expect(actual[:STDOUT]).to include('Dry run complete. No changes applied.')
+      host = @db.models[:host].find(name: host_name)
+      expect(host.hostvars_dataset[name: 'var1']).not_to be_nil
+    end
+
     it 'host rmvar HOST <valid args> ... should remove the host variable' do
       # 1. Should add the var to the db
       # 2. Should associate the host with the var
@@ -114,11 +107,11 @@ RSpec.describe Moose::Inventory::Cli::Host do
       host_name = 'test1'
 
       var = { name: 'foo', value: 'bar' }
-      cases = %W(
+      cases = %W[
         #{var[:name]}
         #{var[:name]}=
         #{var[:name]}=#{var[:value]}
-      )
+      ]
       cases.each do |example|
         # reset the db
         @db.reset
@@ -126,24 +119,24 @@ RSpec.describe Moose::Inventory::Cli::Host do
         # Add an initial host and hostvar
         @db.models[:host].create(name: host_name)
         runner do
-          @app.start(%W(host addvar #{host_name} #{var[:name]}=#{var[:value]}))
+          @app.start(%W[host addvar #{host_name} #{var[:name]}=#{var[:value]}])
         end
 
         # Try to remove the hostvar using the case example valid args
         actual = runner do
-          @app.start(%W(host rmvar #{host_name} #{example}))
+          @app.start(%W[host rmvar #{host_name} #{example} --yes])
         end
         # @console.out(actual,'p')
 
         # Check the output
         desired = { aborted: false }
         desired[:STDOUT] =
-          "Remove variable(s) '#{example}' from host '#{host_name}':\n"\
-          "  - retrieve host '#{host_name}'...\n"\
-          "    - OK\n"\
-          "  - remove variable '#{example}'...\n"\
-          "    - OK\n"\
-          "  - all OK\n"\
+          "Remove variable(s) '#{example}' from host '#{host_name}':\n  " \
+          "- retrieve host '#{host_name}'...\n    " \
+          "- OK\n  " \
+          "- remove variable '#{example}'...\n    " \
+          "- OK\n  " \
+          "- all OK\n" \
           "Succeeded.\n"
 
         # @console.out(desired,'p')
@@ -164,36 +157,35 @@ RSpec.describe Moose::Inventory::Cli::Host do
       host_name = 'test1'
       varsarray = [
         { name: 'var1', value: 'val1' },
-        { name: 'var2', value: 'val2' },
+        { name: 'var2', value: 'val2' }
       ]
 
-      vars = []
-      varsarray.each do |var|
-        vars << "#{var[:name]}=#{var[:value]}"
+      vars = varsarray.map do |var|
+        "#{var[:name]}=#{var[:value]}"
       end
 
       @db.models[:host].create(name: host_name)
-      actual = runner do
-        @app.start(%W(host addvar #{host_name}) + vars)
+      runner do
+        @app.start(%W[host addvar #{host_name}] + vars)
       end
 
       actual = runner do
-        @app.start(%W(host rmvar #{host_name}) + vars)
+        @app.start(%W[host rmvar #{host_name} --yes] + vars)
       end
       # @console.out(actual,'p')
 
       desired = { aborted: false }
       desired[:STDOUT] =
-        "Remove variable(s) '#{vars.join(',')}' from host '#{host_name}':\n"\
-        "  - retrieve host '#{host_name}'...\n"\
-        "    - OK\n"
+        "Remove variable(s) '#{vars.join(',')}' from host '#{host_name}':\n  " \
+        "- retrieve host '#{host_name}'...\n    " \
+        "- OK\n"
       vars.each do |var|
         desired[:STDOUT] = desired[:STDOUT] +
-                           "  - remove variable '#{var}'...\n"\
-                           "    - OK\n"
+                           "  - remove variable '#{var}'...\n    " \
+                           "- OK\n"
       end
       desired[:STDOUT] = desired[:STDOUT] +
-                         "  - all OK\n"\
+                         "  - all OK\n" \
                          "Succeeded.\n"
       expected(actual, desired)
 
@@ -204,3 +196,4 @@ RSpec.describe Moose::Inventory::Cli::Host do
     end
   end
 end
+# rubocop:enable Metrics/BlockLength

data/spec/lib/moose_inventory/cli/host_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require_relative 'host_add_spec'

data/spec/lib/moose_inventory/cli/tags_spec.rb

@@ -0,0 +1,81 @@
+# frozen_string_literal: true
+
+require 'json'
+require 'spec_helper'
+
+# rubocop:disable Metrics/BlockLength
+RSpec.describe 'host and group metadata tags' do
+  before(:all) do
+    setup_cli_harness(command_class: Moose::Inventory::Cli::Application)
+  end
+
+  before(:each) do
+    reset_cli_harness
+  end
+
+  it 'adds and lists host tags' do
+    runner { @app.start(%w[host add app01]) }
+
+    add = runner { @app.start(%w[host addtag app01 prod critical]) }
+    list = runner { @app.start(%w[host listtags app01]) }
+
+    expect(add[:unexpected]).to eq(false)
+    expect(add[:STDOUT]).to include("Added host tag(s) to 'app01': prod, critical.")
+    expect(list[:STDOUT]).to eq("Host 'app01' tags: critical, prod\n")
+  end
+
+  it 'normalizes host tag casing and deduplicates values' do
+    runner { @app.start(%w[host add app01]) }
+
+    add = runner { @app.start(%w[host addtag app01 Prod PROD owner-platform]) }
+    list = runner { @app.start(%w[host listtags app01]) }
+
+    expect(add[:unexpected]).to eq(false)
+    expect(add[:STDOUT]).to include("Added host tag(s) to 'app01': prod, owner-platform.")
+    expect(list[:STDOUT]).to eq("Host 'app01' tags: owner-platform, prod\n")
+    expect(@db.models[:tag].where(name: 'Prod').count).to eq(0)
+    expect(@db.models[:tag].where(name: 'prod').count).to eq(1)
+  end
+
+  it 'removes host tags' do
+    runner { @app.start(%w[host add app01]) }
+    runner { @app.start(%w[host addtag app01 prod critical]) }
+
+    remove = runner { @app.start(%w[host rmtag app01 PROD --yes]) }
+    list = runner { @app.start(%w[host listtags app01]) }
+
+    expect(remove[:unexpected]).to eq(false)
+    expect(remove[:STDOUT]).to include("Removed host tag(s) from 'app01': prod.")
+    expect(list[:STDOUT]).to eq("Host 'app01' tags: critical\n")
+  end
+
+  it 'adds and lists group tags as JSON' do
+    runner { @app.start(%w[group add web]) }
+    runner { @app.start(%w[group addtag web frontend owner-platform]) }
+
+    actual = runner { @app.start(%w[group listtags web --format json]) }
+    parsed = JSON.parse(actual[:STDOUT])
+
+    expect(actual[:unexpected]).to eq(false)
+    expect(parsed).to eq('group' => 'web', 'tags' => %w[frontend owner-platform])
+  end
+
+  it 'records audit events for tag changes' do
+    runner { @app.start(%w[host add app01]) }
+    runner { @app.start(%w[host addtag app01 prod]) }
+
+    event = @db.models[:audit_event].last
+    expect(event.command).to eq('host addtag')
+    expect(event.action).to eq('add_tag')
+    expect(event.entity_type).to eq('host')
+    expect(event.entity_name).to eq('app01')
+  end
+
+  it 'aborts when tagging a missing entity' do
+    actual = runner { @app.start(%w[group addtag missing prod]) }
+
+    expect(actual[:aborted]).to eq(true)
+    expect(actual[:STDERR]).to include("ERROR: The group 'missing' does not exist.")
+  end
+end
+# rubocop:enable Metrics/BlockLength

data/spec/lib/moose_inventory/config/config_spec.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe 'Moose::Inventory::Config' do
   before(:all) do
     # Set up the configuration object
     @mockarg_parts = {
-      config:  File.join(spec_root, 'config/config.yml'),
-      format:  'yaml',
-      env:     'test',
+      config: File.join(spec_root, 'config/config.yml'),
+      format: 'yaml',
+      env: 'test'
     }
 
     @mockargs = []
@@ -24,6 +26,26 @@ RSpec.describe 'Moose::Inventory::Config' do
       result = @config.respond_to?(:init)
       expect(result).to eq(true)
     end
+
+    it 'resets runtime state before parsing new arguments' do
+      @config.init(@mockargs)
+      @config._settings[:junk] = true
+      @config._argv << '--junk'
+
+      @config.init(['--config', @mockarg_parts[:config]])
+
+      expect(@config._settings[:junk]).to be_nil
+      expect(@config._argv).not_to include('--junk')
+    end
+
+    it 'builds a runtime options object from the resolved arguments' do
+      @config.init(@mockargs)
+
+      expect(@config.runtime_options.argv).to eq([])
+      expect(@config.runtime_options.output_format).to eq('yaml')
+      expect(@config.runtime_options.ansible?).to eq(false)
+      expect(@config.application_args).to eq([])
+    end
   end
 
   # ._configopts
@@ -60,6 +82,22 @@ RSpec.describe 'Moose::Inventory::Config' do
     end
   end
 
+  describe 'flag parsing' do
+    it 'raises when --config is missing its value' do
+      expect { @config.init(['--config']) }.to raise_error(RuntimeError, 'Expected a value after --config')
+    end
+
+    it 'raises when --env is missing its value' do
+      expect { @config.init(['--env', '--config', @mockarg_parts[:config]]) }
+        .to raise_error(RuntimeError, 'Expected a value after --env')
+    end
+
+    it 'raises when --format is missing its value' do
+      expect { @config.init(['--config', @mockarg_parts[:config], '--format']) }
+        .to raise_error(RuntimeError, 'Expected a value after --format')
+    end
+  end
+
   # ._settings
   describe '._settings' do
     it 'should be responsive' do