moose-inventory 2.0 → 2.1

data/spec/lib/moose_inventory/cli/group_rmchild_spec.rb

@@ -1,15 +1,17 @@
+# frozen_string_literal: true
+
+# rubocop:disable Metrics/BlockLength
 require 'spec_helper'
 
-# TODO: the usual respond_to? method doesn't seem to work on Thor objects.
 # Why not? For now, we'll check against instance_methods.
 
 RSpec.describe Moose::Inventory::Cli::Group do
   before(:all) do
     # Set up the configuration object
     @mockarg_parts = {
-      config:  File.join(spec_root, 'config/config.yml'),
-      format:  'yaml',
-      env:     'test',
+      config: File.join(spec_root, 'config/config.yml'),
+      format: 'yaml',
+      env: 'test'
     }
 
     @mockargs = []
@@ -39,14 +41,14 @@ RSpec.describe Moose::Inventory::Cli::Group do
   describe 'rmchild' do
     #------------------------
     it 'Group.rmchild() should be responsive' do
-      result = @group.instance_methods(false).include?(:rmchild)
+      result = @group.method_defined?(:rmchild, false)
       expect(result).to eq(true)
     end
 
     #------------------------
     it '<missing args> ... should abort with an error' do
       actual = runner  do
-        @app.start(%w(group addchild))
+        @app.start(%w[group addchild])
       end
 
       # @console.out(actual, 'y')
@@ -63,7 +65,7 @@ RSpec.describe Moose::Inventory::Cli::Group do
       child_name = 'fake'
 
       actual = runner do
-        @app.start(%W(group addchild #{parent_name} #{child_name}))
+        @app.start(%W[group addchild #{parent_name} #{child_name}])
       end
 
       # @console.out(actual, 'y')
@@ -79,7 +81,7 @@ RSpec.describe Moose::Inventory::Cli::Group do
       child_name = 'ungrouped'
 
       actual = runner do
-        @app.start(%W(group rmchild #{parent_name} #{child_name}))
+        @app.start(%W[group rmchild #{parent_name} #{child_name} --yes])
       end
 
       # @console.out(actual, 'y')
@@ -96,17 +98,17 @@ RSpec.describe Moose::Inventory::Cli::Group do
       cname = 'child group'
 
       actual = runner do
-        @app.start(%W(group rmchild #{pname} #{cname}))
+        @app.start(%W[group rmchild #{pname} #{cname} --yes])
       end
 
       # @console.out(actual, 'y')
       # Check output
       desired = { aborted: true }
       desired[:STDOUT] =
-        "Dissociate parent group '#{pname}' from child group(s) '#{cname}':\n"\
-        "  - retrieve group '#{pname}'...\n"
+        "Dissociate parent group '#{pname}' from child group(s) '#{cname}':\n  " \
+        "- retrieve group '#{pname}'...\n"
       desired[:STDERR] =
-        "ERROR: The group '#{pname}' does not exist.\n"\
+        "ERROR: The group '#{pname}' does not exist.\n" \
         "An error occurred during a transaction, any changes have been rolled back.\n"
       expected(actual, desired)
     end
@@ -116,10 +118,10 @@ RSpec.describe Moose::Inventory::Cli::Group do
       pname = 'parent_group'
       cname = 'child group'
 
-      runner { @app.start(%W(group add #{pname} #{cname})) }
+      runner { @app.start(%W[group add #{pname} #{cname}]) }
 
       actual = runner do
-        @app.start(%W(group rmchild #{pname} #{cname}))
+        @app.start(%W[group rmchild #{pname} #{cname} --yes])
       end
 
       # @console.out(actual, 'y')
@@ -127,13 +129,13 @@ RSpec.describe Moose::Inventory::Cli::Group do
       # Check output
       desired = {}
       desired[:STDOUT] =
-        "Dissociate parent group '#{pname}' from child group(s) '#{cname}':\n"\
-        "  - retrieve group '#{pname}'...\n"\
-        "    - OK\n"\
-        "  - remove association {group:#{pname} <-> group:#{cname}}...\n"\
-        "    - doesn't exist, skipping.\n"\
-        "    - OK\n"\
-        "  - all OK\n"\
+        "Dissociate parent group '#{pname}' from child group(s) '#{cname}':\n  " \
+        "- retrieve group '#{pname}'...\n    " \
+        "- OK\n  " \
+        "- remove association {group:#{pname} <-> group:#{cname}}...\n    " \
+        "- doesn't exist, skipping.\n    " \
+        "- OK\n  " \
+        "- all OK\n" \
         "Succeeded, with warnings.\n"
 
       desired[:STDERR] =
@@ -147,11 +149,11 @@ RSpec.describe Moose::Inventory::Cli::Group do
       pname = 'parent_group'
       cname = 'child group'
 
-      runner { @app.start(%W(group add #{pname} #{cname})) }
-      runner { @app.start(%W(group addchild #{pname} #{cname})) }
+      runner { @app.start(%W[group add #{pname} #{cname}]) }
+      runner { @app.start(%W[group addchild #{pname} #{cname}]) }
 
       actual = runner do
-        @app.start(%W(group rmchild #{pname} #{cname}))
+        @app.start(%W[group rmchild #{pname} #{cname} --yes])
       end
 
       # @console.out(actual, 'y')
@@ -159,27 +161,49 @@ RSpec.describe Moose::Inventory::Cli::Group do
       # Check output
       desired = {}
       desired[:STDOUT] =
-        "Dissociate parent group '#{pname}' from child group(s) '#{cname}':\n"\
-        "  - retrieve group '#{pname}'...\n"\
-        "    - OK\n"\
-        "  - remove association {group:#{pname} <-> group:#{cname}}...\n"\
-        "    - OK\n"\
-        "  - all OK\n"\
+        "Dissociate parent group '#{pname}' from child group(s) '#{cname}':\n  " \
+        "- retrieve group '#{pname}'...\n    " \
+        "- OK\n  " \
+        "- remove association {group:#{pname} <-> group:#{cname}}...\n    " \
+        "- OK\n  " \
+        "- all OK\n" \
         "Succeeded.\n"
 
       expected(actual, desired)
     end
 
+    #------------------------
+    it 'GROUP CHILDGROUP --delete-orphans --dry-run should not remove or delete groups' do
+      runner { @app.start(%w[group add parent]) }
+      runner { @app.start(%w[group add child --hosts child-host]) }
+      runner { @app.start(%w[group addchild parent child]) }
+
+      actual = runner do
+        @app.start(%w[group rmchild --delete-orphans parent child --dry-run])
+      end
+
+      expect(actual[:unexpected]).to eq(false)
+      expect(actual[:aborted]).to eq(false)
+      expect(actual[:STDOUT]).to include('Dry run complete. No changes applied.')
+      expect(actual[:STDOUT]).to include("- Recursively delete orphaned group 'child'...
+")
+      parent = @db.models[:group].find(name: 'parent')
+      expect(parent.children_dataset[name: 'child']).not_to be_nil
+      expect(@db.models[:group].find(name: 'child')).not_to be_nil
+      host = @db.models[:host].find(name: 'child-host')
+      expect(host.groups_dataset[name: 'ungrouped']).to be_nil
+    end
+
     #------------------------
     it 'GROUP CHILDGROUP --delete-orphans ... should delete orphaned child groups recursively' do
-      runner { @app.start(%w(group add parent)) }
-      runner { @app.start(%w(group add child --hosts child-host)) }
-      runner { @app.start(%w(group add grandchild)) }
-      runner { @app.start(%w(group addchild parent child)) }
-      runner { @app.start(%w(group addchild child grandchild)) }
+      runner { @app.start(%w[group add parent]) }
+      runner { @app.start(%w[group add child --hosts child-host]) }
+      runner { @app.start(%w[group add grandchild]) }
+      runner { @app.start(%w[group addchild parent child]) }
+      runner { @app.start(%w[group addchild child grandchild]) }
 
       actual = runner do
-        @app.start(%w(group rmchild --delete-orphans parent child))
+        @app.start(%w[group rmchild --delete-orphans parent child --yes])
       end
 
       expect(actual[:unexpected]).to eq(false)
@@ -188,7 +212,7 @@ RSpec.describe Moose::Inventory::Cli::Group do
       expect(actual[:STDOUT]).to include("- Recursively delete orphaned group 'grandchild'...\n")
 
       expect(@db.models[:group].find(name: 'parent')).not_to be_nil
-      %w(child grandchild).each do |name|
+      %w[child grandchild].each do |name|
         expect(@db.models[:group].find(name: name)).to be_nil
       end
 
@@ -198,12 +222,12 @@ RSpec.describe Moose::Inventory::Cli::Group do
 
     #------------------------
     it 'GROUP CHILDGROUP --delete-orphans ... should preserve child groups with another parent' do
-      runner { @app.start(%w(group add parent other-parent)) }
-      runner { @app.start(%w(group addchild parent child)) }
-      runner { @app.start(%w(group addchild other-parent child)) }
+      runner { @app.start(%w[group add parent other-parent]) }
+      runner { @app.start(%w[group addchild parent child]) }
+      runner { @app.start(%w[group addchild other-parent child]) }
 
       actual = runner do
-        @app.start(%w(group rmchild --delete-orphans parent child))
+        @app.start(%w[group rmchild --delete-orphans parent child --yes])
       end
 
       expect(actual[:unexpected]).to eq(false)
@@ -216,3 +240,4 @@ RSpec.describe Moose::Inventory::Cli::Group do
     end
   end
 end
+# rubocop:enable Metrics/BlockLength

data/spec/lib/moose_inventory/cli/group_rmhost_spec.rb

@@ -1,44 +1,28 @@
+# frozen_string_literal: true
+
+# rubocop:disable Metrics/BlockLength
 require 'spec_helper'
 
-# TODO: the usual respond_to? method doesn't seem to work on Thor objects.
 # Why not? For now, we'll check against instance_methods.
 
 RSpec.describe Moose::Inventory::Cli::Group do
   before(:all) do
-    # Set up the configuration object
-    @mockarg_parts = {
-      config:  File.join(spec_root, 'config/config.yml'),
-      format:  'yaml',
-      env:     'test',
-    }
-
-    @mockargs = []
-    @mockarg_parts.each do |key, val|
-      @mockargs << "--#{key}"
-      @mockargs << val
-    end
-
-    @console = Moose::Inventory::Cli::Formatter
-    @config = Moose::Inventory::Config
-    @config.init(@mockargs)
-
-    @db = Moose::Inventory::DB
-    @db.init if @db.db.nil?
-
-    @group = Moose::Inventory::Cli::Group
-    @host = Moose::Inventory::Cli::Host
-    @app = Moose::Inventory::Cli::Application
+    setup_cli_harness(
+      command_class: Moose::Inventory::Cli::Group,
+      command_ivar: :@group,
+      extra_commands: { :@host => Moose::Inventory::Cli::Host }
+    )
   end
 
   before(:each) do
-    @db.reset
+    reset_cli_harness
   end
 
   #====================
   describe 'rmgroup' do
     #----------------
     it 'should be responsive' do
-      result = @group.instance_methods(false).include?(:rmhost)
+      result = @group.method_defined?(:rmhost, false)
       expect(result).to eq(true)
     end
 
@@ -47,7 +31,7 @@ RSpec.describe Moose::Inventory::Cli::Group do
     #------------------------
     it '<missing args> ... should abort with an error' do
       actual = runner  do
-        @app.start(%w(group rmhost)) # <- no group or hosts given
+        @app.start(%w[group rmhost]) # <- no group or hosts given
       end
 
       # Check output
@@ -61,16 +45,16 @@ RSpec.describe Moose::Inventory::Cli::Group do
       group_name = 'not-a-group'
       host_name = 'example'
       actual = runner do
-        @app.start(%W(group rmhost #{group_name} #{host_name}))
+        @app.start(%W[group rmhost #{group_name} #{host_name} --yes])
       end
 
       # Check output
       desired = { aborted: true }
       desired[:STDOUT] =
-        "Dissociate group '#{group_name}' from host(s) '#{host_name}':\n"\
-        "  - retrieve group '#{group_name}'...\n"
+        "Dissociate group '#{group_name}' from host(s) '#{host_name}':\n  " \
+        "- retrieve group '#{group_name}'...\n"
       desired[:STDERR] =
-        "ERROR: The group '#{group_name}' does not exist.\n"\
+        "ERROR: The group '#{group_name}' does not exist.\n" \
         "An error occurred during a transaction, any changes have been rolled back.\n"
       expected(actual, desired)
     end
@@ -80,9 +64,9 @@ RSpec.describe Moose::Inventory::Cli::Group do
       host_name = 'test1'
       group_name = 'group1'
 
-      runner { @app.start(%W(host add #{host_name})) }
-      runner { @app.start(%W(group add #{group_name})) }
-      runner { @app.start(%W(group addhost #{group_name} #{host_name})) }
+      runner { @app.start(%W[host add #{host_name}]) }
+      runner { @app.start(%W[group add #{group_name}]) }
+      runner { @app.start(%W[group addhost #{group_name} #{host_name}]) }
 
       #
       # Dissociate the host
@@ -90,32 +74,48 @@ RSpec.describe Moose::Inventory::Cli::Group do
       # 2. expect that no association with ungrouped is made.
 
       actual = runner do
-        @app.start(%W(group rmhost #{group_name} #{host_name}))
+        @app.start(%W[group rmhost #{group_name} #{host_name} --yes])
       end
 
       # @console.dump(actual, 'y')
 
-      # rubocop:disable Metrics/LineLength
       desired = { aborted: false }
       desired[:STDOUT] =
-        "Dissociate group '#{group_name}' from host(s) '#{host_name}':\n"\
-        "  - retrieve group '#{group_name}'...\n"\
-        "    - OK\n"\
-        "  - remove association {group:#{group_name} <-> host:#{host_name}}...\n"\
-        "    - OK\n"\
-        "  - add automatic association {group:ungrouped <-> host:#{host_name}}...\n"\
-        "    - OK\n"\
-        "  - all OK\n"\
+        "Dissociate group '#{group_name}' from host(s) '#{host_name}':\n  " \
+        "- retrieve group '#{group_name}'...\n    " \
+        "- OK\n  " \
+        "- remove association {group:#{group_name} <-> host:#{host_name}}...\n    " \
+        "- OK\n  " \
+        "- add automatic association {group:ungrouped <-> host:#{host_name}}...\n    " \
+        "- OK\n  " \
+        "- all OK\n" \
         "Succeeded.\n"
       expected(actual, desired)
-      # rubocop:enable Metrics/LineLength
-
       # We should have the correct group associations
       group = @db.models[:group].find(name: group_name)
       hosts = group.hosts_dataset
       expect(hosts.count).to eq(0)
     end
 
+    #------------------------
+    it 'group rmhost GROUP HOST --dry-run should not remove membership or add ungrouped' do
+      host_name = 'test1'
+      group_name = 'group1'
+      runner { @app.start(%W[host add #{host_name}]) }
+      runner { @app.start(%W[group add #{group_name}]) }
+      runner { @app.start(%W[group addhost #{group_name} #{host_name}]) }
+
+      actual = runner { @app.start(%W[group rmhost #{group_name} #{host_name} --dry-run]) }
+
+      expect(actual[:unexpected]).to eq(false)
+      expect(actual[:aborted]).to eq(false)
+      expect(actual[:STDOUT]).to include('Dry run complete. No changes applied.')
+      group = @db.models[:group].find(name: group_name)
+      host = @db.models[:host].find(name: host_name)
+      expect(group.hosts_dataset[name: host_name]).not_to be_nil
+      expect(host.groups_dataset[name: 'ungrouped']).to be_nil
+    end
+
     #------------------------
     it 'GROUP HOST ... should warn about non-existing associations' do
       # 1. Should warn that the association doesn't exist.
@@ -123,28 +123,27 @@ RSpec.describe Moose::Inventory::Cli::Group do
 
       host_name = 'test_host'
       group_name = 'test_group'
-      runner { @app.start(%W(host add #{host_name})) }
-      runner { @app.start(%W(group add #{group_name})) }
-      runner { @app.start(%W(group addhost #{host_name})) }
+      runner { @app.start(%W[host add #{host_name}]) }
+      runner { @app.start(%W[group add #{group_name}]) }
+      runner { @app.start(%W[group addhost #{host_name}]) }
 
       actual = runner do
-        @app.start(%W(group rmhost #{group_name} #{host_name}))
+        @app.start(%W[group rmhost #{group_name} #{host_name} --yes])
       end
 
-      # rubocop:disable Metrics/LineLength
       desired = { aborted: false }
       desired[:STDOUT] =
-        "Dissociate group '#{group_name}' from host(s) '#{host_name}':\n"\
-        "  - retrieve group \'#{group_name}\'...\n"\
-        "    - OK\n"\
-        "  - remove association {group:#{group_name} <-> host:#{host_name}}...\n"\
-        "    - doesn't exist, skipping.\n"\
-        "    - OK\n"\
-        "  - all OK\n"\
+        "Dissociate group '#{group_name}' from host(s) '#{host_name}':\n  " \
+        "- retrieve group '#{group_name}'...\n    " \
+        "- OK\n  " \
+        "- remove association {group:#{group_name} <-> host:#{host_name}}...\n    " \
+        "- doesn't exist, skipping.\n    " \
+        "- OK\n  " \
+        "- all OK\n" \
         "Succeeded, with warnings.\n"
       desired[:STDERR] =
-        "WARNING: Association {group:#{group_name} <-> host:#{host_name}} "\
-          "doesn't exist, skipping.\n"
+        "WARNING: Association {group:#{group_name} <-> host:#{host_name}} " \
+        "doesn't exist, skipping.\n"
 
       expected(actual, desired)
     end
@@ -154,9 +153,9 @@ RSpec.describe Moose::Inventory::Cli::Group do
       host_name = 'test_host'
       group_name = 'ungrouped'
 
-      runner { @app.start(%W(host add #{name})) } # <- auto creates the association with ungrouped
+      runner { @app.start(%W[host add #{name}]) } # <- auto creates the association with ungrouped
 
-      actual = runner { @app.start(%W(group rmhost #{group_name} #{host_name})) }
+      actual = runner { @app.start(%W[group rmhost #{group_name} #{host_name} --yes]) }
 
       desired = { aborted: true }
       desired[:STDERR] =
@@ -165,41 +164,39 @@ RSpec.describe Moose::Inventory::Cli::Group do
     end
 
     #------------------------
-    it 'GROUP HOST1 HOST2 ... should dissociate the group from'\
-      ' multiple hosts at once' do
+    it 'GROUP HOST1 HOST2 ... should dissociate the group from ' \
+       'multiple hosts at once' do
       # 1. Should dissociate hosts from the group
       # 2. Should add each host to the 'ungrouped' automatic group
       #    if it has no other groups.
 
       group_name = 'test_group'
-      host_names = %w(test_host1 test_host2 test_host3)
+      host_names = %w[test_host1 test_host2 test_host3]
 
-      runner { @app.start(%W(group add #{group_name})) }
-      runner { @app.start(%W(group addhost #{group_name}) + host_names) }
+      runner { @app.start(%W[group add #{group_name}]) }
+      runner { @app.start(%W[group addhost #{group_name}] + host_names) }
 
       actual = runner do
-        @app.start(%W(group rmhost #{group_name}) + host_names)
+        @app.start(%W[group rmhost #{group_name} --yes] + host_names)
       end
 
       # @console.out(actual, 'y')
       desired = { aborted: false }
       desired[:STDOUT] =
-        "Dissociate group '#{group_name}' from host(s) '#{host_names.join(',')}':\n"\
-        "  - retrieve group \'#{group_name}\'...\n"\
-        "    - OK\n"
+        "Dissociate group '#{group_name}' from host(s) '#{host_names.join(',')}':\n  " \
+        "- retrieve group '#{group_name}'...\n    " \
+        "- OK\n"
       host_names.each do |host|
         desired[:STDOUT] = desired[:STDOUT] +
-                           "  - remove association {group:#{group_name} <-> host:#{host}}...\n"\
-                           "    - OK\n"\
-                           "  - add automatic association {group:ungrouped <-> host:#{host}}...\n"\
-                           "    - OK\n"\
+                           "  - remove association {group:#{group_name} <-> host:#{host}}...\n    " \
+                           "- OK\n  " \
+                           "- add automatic association {group:ungrouped <-> host:#{host}}...\n    " \
+                           "- OK\n" \
       end
       desired[:STDOUT] = desired[:STDOUT] +
-                         "  - all OK\n"\
+                         "  - all OK\n" \
                          "Succeeded.\n"
       expected(actual, desired)
-      # rubocop:enable Metrics/LineLength
-
       # We should have the correct group associations
       group = @db.models[:group].find(name: group_name)
       hosts = group.hosts_dataset
@@ -210,3 +207,4 @@ RSpec.describe Moose::Inventory::Cli::Group do
     end
   end
 end
+# rubocop:enable Metrics/BlockLength