mongomodel 0.4.6 → 0.4.7

data/spec/mongomodel/concerns/attribute_methods/query_spec.rb

@@ -11,19 +11,19 @@ module MongoModel
     
     describe "#query_attribute" do
       context "string attribute" do
-        it "should return true if the attribute is not blank" do
+        it "returns true if the attribute is not blank" do
           subject.foo = 'set foo'
           subject.query_attribute(:foo).should be_true
           subject.foo?.should be_true
         end
       
-        it "should return false if the attribute is nil" do
+        it "returns false if the attribute is nil" do
           subject.foo = nil
           subject.query_attribute(:foo).should be_false
           subject.foo?.should be_false
         end
       
-        it "should return false if the attribute is blank" do
+        it "returns false if the attribute is blank" do
           subject.foo = ''
           subject.query_attribute(:foo).should be_false
           subject.foo?.should be_false
@@ -31,19 +31,19 @@ module MongoModel
       end
       
       context "boolean attribute" do
-        it "should return true if the attribute is true" do
+        it "returns true if the attribute is true" do
           subject.boolean = true
           subject.query_attribute(:boolean).should be_true
           subject.boolean?.should be_true
         end
         
-        it "should return false if the attribute is nil" do
+        it "returns false if the attribute is nil" do
           subject.boolean = nil
           subject.query_attribute(:boolean).should be_false
           subject.boolean?.should be_false
         end
       
-        it "should return false if the attribute is false" do
+        it "returns false if the attribute is false" do
           subject.boolean = false
           subject.query_attribute(:boolean).should be_false
           subject.boolean?.should be_false

data/spec/mongomodel/concerns/attribute_methods/read_spec.rb

@@ -10,28 +10,28 @@ module MongoModel
     
     describe "#read_attribute" do
       context "valid property" do
-        it "should return the attribute value" do
+        it "returns the attribute value" do
           subject.read_attribute(:foo).should == 'value of foo'
         end
         
-        it "should define a reader method" do
+        it "defines a reader method" do
           subject.foo.should == 'value of foo'
         end
       end
       
       context "no property" do
-        it "should return the attribute value" do
+        it "returns the attribute value" do
           subject.read_attribute(:bar).should == 'value of bar'
         end
         
-        it "should not define a reader method" do
+        it "does not define a reader method" do
           lambda { subject.bar }.should raise_error(NoMethodError)
         end
       end
     end
     
     describe "#[]" do
-      it "should read the given attribute" do
+      it "reads the given attribute" do
         subject.should_receive(:read_attribute).with(:foo).and_return('value of foo')
         subject[:foo].should == 'value of foo'
       end
@@ -44,7 +44,7 @@ module MongoModel
     subject { TestDocument.new }
     
     describe "#id" do
-      it "should return id from attributes" do
+      it "returns id from attributes" do
         subject.id.should == subject.attributes[:id]
       end
     end

data/spec/mongomodel/concerns/attribute_methods/write_spec.rb

@@ -10,31 +10,31 @@ module MongoModel
     
     describe "#write_attribute" do
       context "with property" do
-        it "should set the attribute hash" do
+        it "sets the attribute hash" do
           subject.write_attribute(:foo, 'set foo')
           subject.attributes[:foo].should == 'set foo'
         end
         
-        it "should define a writer method" do
+        it "defines a writer method" do
           subject.foo = 'set foo'
           subject.attributes[:foo].should == 'set foo'
         end
       end
       
       context "no property" do
-        it "should set the attribute hash" do
+        it "sets the attribute hash" do
           subject.write_attribute(:bar, 'set bar')
           subject.attributes[:bar].should == 'set bar'
         end
         
-        it "should not define a writer method" do
+        it "does not define a writer method" do
           lambda { subject.bar = 'set bar' }.should raise_error(NoMethodError)
         end
       end
     end
     
     describe "#[]=" do
-      it "should write the given attribute" do
+      it "writes the given attribute" do
         subject.should_receive(:write_attribute).with(:foo, 'value of foo')
         subject[:foo] = 'value of foo'
       end

data/spec/mongomodel/concerns/attribute_methods_spec.rb

@@ -11,7 +11,7 @@ module MongoModel
       
       subject { TestDocument.new }
       
-      it "should not overwrite an existing method" do
+      it "does not overwrite an existing method" do
         subject.foo(1).should == "from method"
       end
       
@@ -19,7 +19,7 @@ module MongoModel
         define_class(:SubDocument, :TestDocument)
         subject { SubDocument.new }
       
-        it "should not overwrite methods defined on the superclass" do
+        it "does not overwrite methods defined on the superclass" do
           subject.foo(1).should == "from method"
         end
       end
@@ -29,7 +29,7 @@ module MongoModel
           def foo(a); "from method"; end
         end
         
-        it "should not overwrite methods defined on the included module" do
+        it "does not overwrite methods defined on the included module" do
           TestDocument.send(:include, TestModule)
           subject.foo(1).should == "from method"
         end
@@ -47,7 +47,7 @@ module MongoModel
         end
         
         context "the base class" do
-          it "should not overwrite methods defined within the concern" do
+          it "does not overwrite methods defined within the concern" do
             TestDocument.send(:include, TestConcern)
             subject.bar(1).should == "from concern"
           end
@@ -57,7 +57,7 @@ module MongoModel
           define_class(:SubDocument, :TestDocument)
           subject { SubDocument.new }
           
-          it "should not overwrite methods defined within the concern" do
+          it "does not overwrite methods defined within the concern" do
             SubDocument.send(:include, TestConcern)
             subject.bar(1).should == "from concern"
           end

data/spec/mongomodel/concerns/attributes_spec.rb

@@ -19,12 +19,12 @@ module MongoModel
   specs_for(Document, EmbeddedDocument) do
     define_class(:TestDocument, described_class)
     
-    it "should have an attributes store on the instance" do
+    it "has an attributes store on the instance" do
       doc = TestDocument.new
       doc.attributes.should be_an_instance_of(MongoModel::Attributes::Store)
     end
     
-    it "should convert to mongo representation" do
+    it "converts to mongo representation" do
       doc = TestDocument.new
       doc.to_mongo.should == doc.attributes.to_mongo
     end
@@ -51,22 +51,22 @@ module MongoModel
           let(:reloaded) { TestDocument.find(subject.id) }
         end
         
-        it "should read the correct value from attributes" do
+        it "reads the correct value from attributes" do
           subject.test_property.should == value
         end
       
-        it "should read the correct value after reloading" do
+        it "reads the correct value after reloading" do
           reloaded.test_property.should == subject.test_property
         end
       end
     end
     
-    it "should have an attributes store" do
+    it "has an attributes store" do
       doc = TestDocument.new
       doc.attributes.should be_an_instance_of(MongoModel::Attributes::Store)
     end
     
-    it "should duplicate attributes when duplicating object" do
+    it "duplicates attributes when duplicating object" do
       original = TestDocument.new
       duplicate = original.dup
       
@@ -79,18 +79,18 @@ module MongoModel
         property :age, Integer, :default => 21
       end
       
-      it "should be initializable with attributes hash" do
+      it "is initializable with attributes hash" do
         doc = Person.new(:name => 'Fred', :age => 42)
         doc.name.should == 'Fred'
         doc.age.should == 42
       end
       
-      it "should use default attributes when initializing with partial attributes hash" do
+      it "uses default attributes when initializing with partial attributes hash" do
         doc = Person.new(:name => 'Maurice')
         doc.age.should == 21
       end
       
-      it "should load from mongo representation" do
+      it "loads from mongo representation" do
         doc = Person.from_mongo({ 'name' => 'James', 'age' => 15 })
         doc.name.should == 'James'
         doc.age.should == 15
@@ -108,12 +108,12 @@ module MongoModel
       
       subject { TestDocument.new }
       
-      it "should call custom property methods" do
+      it "calls custom property methods" do
         subject.attributes = { :test_property => 'property value' }
         subject.test_property.should == 'set from method'
       end
       
-      it "should use write_attribute if no such property" do
+      it "uses write_attribute if no such property" do
         subject.attributes = { :non_property => 'property value' }
         subject.read_attribute(:non_property).should == 'property value'
       end
@@ -122,7 +122,7 @@ module MongoModel
     describe "#new" do
       define_class(:TestDocument, described_class)
       
-      it "should yield the instance to a block if provided" do
+      it "yields the instance to a block if provided" do
         block_called = false
         
         TestDocument.new do |doc|
@@ -145,7 +145,7 @@ module MongoModel
       
       it { should be_frozen }
       
-      it "should not allow changes to the attributes hash" do
+      it "does not allow changes to the attributes hash" do
         lambda { subject.attributes[:test_property] = 'Change' }.should raise_error
       end
     end

data/spec/mongomodel/concerns/callbacks_spec.rb

@@ -12,7 +12,7 @@ module MongoModel
         property :things, Collection[ChildThingDocument]
       end
             
-      it "should call callbacks on all embedded documents when adding a new one" do
+      it "calls callbacks on all embedded documents when adding a new one" do
         parent = ParentDocument.create!
         parent.things = Collection[ChildThingDocument].new
         parent.things << ChildThingDocument.new(:name => "Thing One")
@@ -35,46 +35,46 @@ module MongoModel
       let(:child) { ChildDocument.new }
       let(:parent) { ParentDocument.create!(:child => child) }
       
-      it "should run each type of callback when initializing" do
+      it "runs each type of callback when initializing" do
         instance = ChildDocument.new
         instance.should run_callbacks(:after_initialize)
       end
       
-      it "should run each type of callback on find" do
+      it "runs each type of callback on find" do
         instance = ParentDocument.find(parent.id).child
         instance.should run_callbacks(:after_initialize, :after_find)
       end
       
-      it "should run each type of callback when validating a new document" do
+      it "runs each type of callback when validating a new document" do
         instance = ChildDocument.new
         instance.valid?
         instance.should run_callbacks(:after_initialize, :before_validation, :after_validation)
       end
       
-      it "should run each type of callback when validating an existing document" do
+      it "runs each type of callback when validating an existing document" do
         instance = ParentDocument.find(parent.id).child
         instance.valid?
         instance.should run_callbacks(:after_initialize, :after_find, :before_validation, :after_validation)
       end
       
-      it "should run each type of callback when creating a document" do
+      it "runs each type of callback when creating a document" do
         instance = ParentDocument.create!(:child => ChildDocument.new)
         instance.child.should run_callbacks(:after_initialize, :before_validation, :after_validation, :before_save, :before_create, :after_create, :after_save)
       end
       
-      it "should run each type of callback when saving an existing document" do
+      it "runs each type of callback when saving an existing document" do
         instance = ParentDocument.find(parent.id)
         instance.save
         instance.child.should run_callbacks(:after_initialize, :after_find, :before_validation, :after_validation, :before_save, :before_update, :after_update, :after_save)
       end
       
-      it "should run each type of callback when destroying a document" do
+      it "runs each type of callback when destroying a document" do
         instance = ParentDocument.find(parent.id)
         instance.destroy
         instance.child.should run_callbacks(:after_initialize, :after_find, :before_destroy, :after_destroy)
       end
       
-      it "should not run destroy callbacks when deleting a document" do
+      it "does not run destroy callbacks when deleting a document" do
         instance = ParentDocument.find(parent.id)
         instance.delete
         instance.child.should run_callbacks(:after_initialize, :after_find)
@@ -95,13 +95,13 @@ module MongoModel
         let(:parent) { ParentDocument.new(:child => child) }
         
         describe "#save" do
-          it "should return false" do
+          it "returns false" do
             parent.save.should be_false
           end
         end
       
         describe "#save!" do
-          it "should raise a MongoModel::DocumentNotSaved exception" do
+          it "raises a MongoModel::DocumentNotSaved exception" do
             lambda { parent.save! }.should raise_error(MongoModel::DocumentNotSaved)
           end
         end

data/spec/mongomodel/concerns/logging_spec.rb

@@ -8,11 +8,11 @@ module MongoModel
       let(:logger) { mock('logger').as_null_object }
       before(:each) { MongoModel.logger = logger }
       
-      it "should have a logger reader on the class" do
+      it "has a logger reader on the class" do
         TestDocument.logger.should == logger
       end
       
-      it "should have a logger reader on the instance" do
+      it "has a logger reader on the instance" do
         TestDocument.new.logger.should == logger
       end
     end

data/spec/mongomodel/concerns/observing_spec.rb

@@ -16,11 +16,11 @@ module MongoModel
 
       subject { TestDocument.new }
 
-      it "should have an #instance method to access the observer singleton" do
+      it "has an #instance method to access the observer singleton" do
         TestObserver.instance.should eq(TestObserver.instance)
       end
       
-      it "should invoke the TestObserver singleton's after_save method after saving" do
+      it "invokes the TestObserver singleton's after_save method after saving" do
         callback = stub
         callback.should_receive(:call).with(subject)
         
@@ -29,4 +29,4 @@ module MongoModel
       end
     end
   end
-end
+end

data/spec/mongomodel/concerns/pretty_inspect_spec.rb

@@ -4,7 +4,7 @@ module MongoModel
   specs_for(Document, EmbeddedDocument) do
     describe "#inspect" do
       context "on base class" do
-        it "should return class name" do
+        it "returns class name" do
           described_class.inspect.should == described_class.name
         end
       end
@@ -13,7 +13,7 @@ module MongoModel
         context "without properties" do
           define_class(:TestDocument, described_class)
       
-          it "should return class name" do
+          it "returns class name" do
             TestDocument.inspect.should == 'TestDocument()'
           end
         end
@@ -24,7 +24,7 @@ module MongoModel
             property :age, Integer
           end
         
-          it "should return class name and property definitions" do
+          it "returns class name and property definitions" do
             TestDocument.inspect.should == 'TestDocument(name: String, age: Integer)'
           end
         end
@@ -42,7 +42,7 @@ module MongoModel
       
         subject { TestDocument.new(:id => 'abc-123', :name => 'Doc name', :age => 54) }
   
-        it "should return class name and property values" do
+        it "returns class name and property values" do
           subject.inspect.should == '#<TestDocument id: abc-123, name: "Doc name", age: 54>'
         end
       end
@@ -59,7 +59,7 @@ module MongoModel
       
         subject { TestDocument.new(:name => 'Doc name', :age => 54) }
   
-        it "should return class name and property values" do
+        it "returns class name and property values" do
           subject.inspect.should == '#<TestDocument name: "Doc name", age: 54>'
         end
       end

data/spec/mongomodel/concerns/properties_spec.rb

@@ -11,14 +11,14 @@ module MongoModel
       property :skill, String
     end
     
-    it "should have a populated hash of properties" do
+    it "has a populated hash of properties" do
       Person.properties.should include({
         :name => Properties::Property.new(:name, String),
         :age => Properties::Property.new(:age, Integer, :default => 21)
       })
     end
     
-    it "should extend properties in subclasses" do
+    it "extends properties in subclasses" do
       SkilledPerson.properties.should include({
         :name => Properties::Property.new(:name, String),
         :age => Properties::Property.new(:age, Integer, :default => 21),
@@ -26,7 +26,7 @@ module MongoModel
       })
     end
     
-    it "should have a set of internal property names" do
+    it "has a set of internal property names" do
       Person.internal_properties.should include(Person.properties[:type])
       Person.internal_properties.should include(Person.properties[:id]) if described_class == Document
     end
@@ -40,14 +40,14 @@ module MongoModel
       let(:with_manager) { Factory.create!(:manager => person) }
       let(:without_manager) { Factory.create! }
       
-      it "should load correctly when property is set" do
+      it "loads correctly when property is set" do
         factory = Factory.find(with_manager.id)
         factory.manager.should be_an_instance_of(SkilledPerson)
         factory.manager.name.should == "Joe"
         factory.manager.skill.should == "Management"
       end
       
-      it "should load correctly when property is nil" do
+      it "loads correctly when property is nil" do
         factory = Factory.find(without_manager.id)
         factory.manager.should be_nil
       end
@@ -60,7 +60,7 @@ module MongoModel
       
       subject { ParentClass.new }
       
-      it "should include methods from the module" do
+      it "includes methods from the module" do
         subject.should respond_to(:custom_accessor)
         subject.custom_accessor.should == "Custom accessor method"
       end