mongomodel 0.4.6 → 0.4.7

data/spec/mongomodel/concerns/associations/has_many_by_ids_spec.rb

@@ -7,92 +7,92 @@ module MongoModel
         has_many :chapters
       end
       
-      it "should default to :by => :ids" do
+      it "defaults to :by => :ids" do
         Book.associations[:chapters].should be_a(Associations::HasManyByIds)
       end
     end
   end
   
   shared_examples_for "accessing and manipulating a has_many :by => :ids association" do
-    it "should access chapters" do
+    it "accesses chapters" do
       subject.chapters.should == [chapter1, chapter2]
     end
     
-    it "should access chapter ids through association" do
+    it "accesses chapter ids through association" do
       subject.chapters.ids.should == [chapter1.id, chapter2.id]
     end
     
-    it "should have chapter ids" do
+    it "has chapter ids" do
       subject.chapter_ids.should == [chapter1.id, chapter2.id]
     end
     
-    it "should add chapters with <<" do
+    it "adds chapters with <<" do
       subject.chapters << chapter3
       subject.chapters.should == [chapter1, chapter2, chapter3]
       subject.chapter_ids.should == [chapter1.id, chapter2.id, chapter3.id]
     end
     
-    it "should add/change chapters with []=" do
+    it "adds/change chapters with []=" do
       subject.chapters[2] = chapter3
       subject.chapters.should == [chapter1, chapter2, chapter3]
       subject.chapter_ids.should == [chapter1.id, chapter2.id, chapter3.id]
     end
     
-    it "should add chapters with concat" do
+    it "adds chapters with concat" do
       subject.chapters.concat([chapter3])
       subject.chapters.should == [chapter1, chapter2, chapter3]
       subject.chapter_ids.should == [chapter1.id, chapter2.id, chapter3.id]
     end
     
-    it "should insert chapters" do
+    it "inserts chapters" do
       subject.chapters.insert(1, chapter3)
       subject.chapters.should == [chapter1, chapter3, chapter2]
       subject.chapter_ids.should == [chapter1.id, chapter3.id, chapter2.id]
     end
     
-    it "should replace chapters" do
+    it "replaces chapters" do
       subject.chapters.replace([chapter2, chapter3])
       subject.chapters.should == [chapter2, chapter3]
       subject.chapter_ids.should == [chapter2.id, chapter3.id]
     end
     
-    it "should add chapters with push" do
+    it "adds chapters with push" do
       subject.chapters.push(chapter3)
       subject.chapters.should == [chapter1, chapter2, chapter3]
       subject.chapter_ids.should == [chapter1.id, chapter2.id, chapter3.id]
     end
     
-    it "should add chapters with unshift" do
+    it "adds chapters with unshift" do
       subject.chapters.unshift(chapter3)
       subject.chapters.should == [chapter3, chapter1, chapter2]
       subject.chapter_ids.should == [chapter3.id, chapter1.id, chapter2.id]
     end
     
-    it "should clear chapters" do
+    it "clears chapters" do
       subject.chapters.clear
       subject.chapters.should be_empty
       subject.chapter_ids.should be_empty
     end
     
-    it "should remove chapters with delete" do
+    it "removes chapters with delete" do
       subject.chapters.delete(chapter1)
       subject.chapters.should == [chapter2]
       subject.chapter_ids.should == [chapter2.id]
     end
     
-    it "should remove chapters with delete_at" do
+    it "removes chapters with delete_at" do
       subject.chapters.delete_at(0)
       subject.chapters.should == [chapter2]
       subject.chapter_ids.should == [chapter2.id]
     end
     
-    it "should remove chapters with delete_if" do
+    it "removes chapters with delete_if" do
       subject.chapters.delete_if { |c| c.id == chapter1.id }
       subject.chapters.should == [chapter2]
       subject.chapter_ids.should == [chapter2.id]
     end
     
-    it "should build a chapter" do
+    it "builds a chapter" do
       chapter4 = subject.chapters.build(:id => '4')
       subject.chapters.should == [chapter1, chapter2, chapter4]
       subject.chapter_ids.should == [chapter1.id, chapter2.id, chapter4.id]
@@ -101,7 +101,7 @@ module MongoModel
       chapter4.id.should == '4'
     end
     
-    it "should create a chapter" do
+    it "creates a chapter" do
       chapter4 = subject.chapters.create(:id => '4')
       subject.chapters.should == [chapter1, chapter2, chapter4]
       subject.chapter_ids.should == [chapter1.id, chapter2.id, chapter4.id]
@@ -110,7 +110,7 @@ module MongoModel
       chapter4.id.should == '4'
     end
     
-    it "should find chapters" do
+    it "finds chapters" do
       # Create bogus chapters
       Chapter.create!(:id => '999')
       Chapter.create!(:id => '998')
@@ -121,7 +121,7 @@ module MongoModel
     
     describe "adding a non-chapter" do
       def self.should_raise(message, &block)
-        it "should raise an AsssociationTypeMismatch error when #{message}" do
+        it "raises an AsssociationTypeMismatch error when #{message}" do
           lambda { instance_eval(&block) }.should raise_error(AssociationTypeMismatch, "expected instance of Chapter but got NonChapter")
         end
       end
@@ -153,11 +153,11 @@ module MongoModel
       context "when uninitialized" do
         subject { Book.new }
         
-        it "should be empty" do
+        it "is empty" do
           subject.chapters.should be_empty
         end
         
-        it "should have an empty ids array" do
+        it "has an empty ids array" do
           subject.chapter_ids.should be_empty
         end
       end
@@ -204,7 +204,7 @@ module MongoModel
         end
         
         context "when the parent object is destroyed" do
-          it "should call destroy on the child objects" do
+          it "calls destroy on the child objects" do
             chapter1.should_receive(:destroy)
             chapter2.should_receive(:destroy)
             chapter3.should_receive(:destroy)
@@ -212,7 +212,7 @@ module MongoModel
             subject.destroy
           end
           
-          it "should remove the child objects from their collection" do
+          it "removes the child objects from their collection" do
             subject.destroy
             
             Chapter.exists?(chapter1.id).should be_false
@@ -238,7 +238,7 @@ module MongoModel
         end
         
         context "when the parent object is destroyed" do
-          it "should not call destroy on the child objects" do
+          it "does not call destroy on the child objects" do
             chapter1.should_not_receive(:destroy)
             chapter2.should_not_receive(:destroy)
             chapter3.should_not_receive(:destroy)
@@ -246,7 +246,7 @@ module MongoModel
             subject.destroy
           end
           
-          it "should remove the child objects from their collection" do
+          it "removes the child objects from their collection" do
             subject.destroy
             
             Chapter.exists?(chapter1.id).should be_false

data/spec/mongomodel/concerns/attribute_methods/before_type_cast_spec.rb

@@ -10,31 +10,31 @@ module MongoModel
     
     describe "#read_attribute_before_type_cast" do
       context "with property" do
-        it "should return the attribute before type casting" do
+        it "returns the attribute before type casting" do
           subject.attributes[:foo] = 'some date'
           subject.read_attribute_before_type_cast(:foo).should == 'some date'
         end
         
-        it "should define a reader method" do
+        it "defines a reader method" do
           subject.attributes[:foo] = 'some date'
           subject.foo_before_type_cast.should == 'some date'
         end
       end
       
       context "no property" do
-        it "should return the attribute without type casting" do
+        it "returns the attribute without type casting" do
           subject.attributes[:bar] = 'set bar'
           subject.read_attribute_before_type_cast(:bar).should == 'set bar'
         end
         
-        it "should not define a reader method" do
+        it "does not define a reader method" do
           lambda { subject.bar_before_type_cast }.should raise_error(NoMethodError)
         end
       end
     end
     
     describe "#attributes_before_type_cast" do
-      it "should return a hash of attributes before type casting" do
+      it "returns a hash of attributes before type casting" do
         subject.attributes[:foo] = 'some date'
         subject.attributes[:bar] = 'set bar'
         

data/spec/mongomodel/concerns/attribute_methods/dirty_spec.rb

@@ -30,15 +30,15 @@ module MongoModel
         subject.write_attribute(:foo, 'new foo')
       end
       
-      it "should add the old attribute name to the changed attributes" do
+      it "adds the old attribute name to the changed attributes" do
         subject.changed.should include("foo")
       end
       
-      it "should not add other attributes to the changed attributes" do
+      it "does not add other attributes to the changed attributes" do
         subject.changed.should_not include("bar")
       end
       
-      it "should add the changed attribute value to the changes hash" do
+      it "adds the changed attribute value to the changes hash" do
         subject.changes["foo"].should == ['original foo', 'new foo']
       end
       
@@ -47,7 +47,7 @@ module MongoModel
           subject.write_attribute(:foo, 'new foo #2')
         end
         
-        it "should keep the original value as the old value in the changes hash" do
+        it "keeps the original value as the old value in the changes hash" do
           subject.changes["foo"].should == ['original foo', 'new foo #2']
         end
       end
@@ -61,19 +61,19 @@ module MongoModel
       
         it { should be_changed }
         
-        it "should have a changed attribute" do
+        it "has a changed attribute" do
           subject.foo_changed?.should == true
         end
         
-        it "should tell what the attribute was" do
+        it "tells what the attribute was" do
           subject.foo_was.should == "original foo"
         end
         
-        it "should have an attribute change" do
+        it "has an attribute change" do
           subject.foo_change.should == ["original foo", "foo changed"]
         end
         
-        it "should be able to reset an attribute" do
+        it "is able to reset an attribute" do
           subject.reset_foo!
           subject.foo.should == "original foo"
           subject.changed?.should == false
@@ -87,19 +87,19 @@ module MongoModel
         
         it { should_not be_changed }
         
-        it "should not have a changed attribute" do
+        it "does not have a changed attribute" do
           subject.foo_changed?.should == false
         end
         
-        it "should tell what the attribute was" do
+        it "tells what the attribute was" do
           subject.foo_was.should == "original foo"
         end
         
-        it "should not have an attribute change" do
+        it "does not have an attribute change" do
           subject.foo_change.should == nil
         end
         
-        it "should be able to reset an attribute" do
+        it "is able to reset an attribute" do
           subject.reset_foo!
           subject.foo.should == "original foo"
           subject.changed?.should == false
@@ -110,19 +110,19 @@ module MongoModel
     context "without changed attributes" do
       it { should_not be_changed }
         
-      it "should not have a changed attribute" do
+      it "does not have a changed attribute" do
         subject.foo_changed?.should == false
       end
       
-      it "should tell what the attribute was" do
+      it "tells what the attribute was" do
         subject.foo_was.should == "original foo"
       end
       
-      it "should not have an attribute change" do
+      it "does not have an attribute change" do
         subject.foo_change.should == nil
       end
       
-      it "should be able to reset an attribute" do
+      it "is able to reset an attribute" do
         subject.reset_foo!
         subject.foo.should == "original foo"
         subject.changed?.should == false
@@ -135,13 +135,13 @@ module MongoModel
           subject.foo = 'changed foo'
         end
         
-        it "should return the attributes before changes" do
+        it "returns the attributes before changes" do
           subject.original_attributes['foo'].should == 'original foo'
         end
       end
       
       context "without changes" do
-        it "should return the attributes hash" do
+        it "returns the attributes hash" do
           subject.original_attributes.symbolize_keys.should == subject.attributes
         end
       end
@@ -161,14 +161,14 @@ module MongoModel
       end
       
       context "with save" do
-        it "should reset the changed attributes" do
+        it "resets the changed attributes" do
           subject.save
           subject.should_not be_changed
         end
       end
       
       context "with save!" do
-        it "should reset the changed attributes" do
+        it "resets the changed attributes" do
           subject.save!
           subject.should_not be_changed
         end
@@ -176,7 +176,7 @@ module MongoModel
     end
     
     context "when instantiated from database" do
-      it "should not be changed" do
+      it "is not changed" do
         instance = TestDocument.find(subject.id)
         instance.should_not be_changed
       end

data/spec/mongomodel/concerns/attribute_methods/multi_parameter_assignment_spec.rb

@@ -12,7 +12,7 @@ module MongoModel
     
     describe "multiparameter assignment from select" do
       context "setting a Time" do
-        it "should combine and assign parameters as Time" do
+        it "combines and assign parameters as Time" do
           subject.attributes = {
             "timestamp(1i)" => "2009",
             "timestamp(2i)" => "10",
@@ -26,7 +26,7 @@ module MongoModel
       end
       
       context "setting a Date" do
-        it "should combine and assign parameters as Date" do
+        it "combines and assign parameters as Date" do
           subject.attributes = {
             "datestamp(1i)" => "2008",
             "datestamp(2i)" => "4",
@@ -38,7 +38,7 @@ module MongoModel
       end
       
       context "setting a DateTime" do
-        it "should combine and assign parameters as DateTime" do
+        it "combines and assign parameters as DateTime" do
           subject.attributes = {
             "datetime(1i)" => "2009",
             "datetime(2i)" => "10",

data/spec/mongomodel/concerns/attribute_methods/protected_spec.rb

@@ -14,22 +14,22 @@ module MongoModel
         TestDocument.attr_protected :foo
       end
       
-      it "should disallow the attribute to be mass-assigned via attributes=" do
+      it "disallows the attribute to be mass-assigned via attributes=" do
         subject.attributes = { :foo => 'value of foo' }
         subject.foo.should be_nil
       end
       
-      it "should not disallow the attribute to be assigned individually" do
+      it "does not disallow the attribute to be assigned individually" do
         subject.foo = 'value of foo'
         subject.foo.should == 'value of foo'
       end
       
-      it "should not disallow other attributes to be mass-assigned via attributes=" do
+      it "does not disallow other attributes to be mass-assigned via attributes=" do
         subject.attributes = { :bar => 'value of bar' }
         subject.bar.should == 'value of bar'
       end
       
-      it "should accept multiple attributes" do
+      it "accepts multiple attributes" do
         TestDocument.attr_protected :foo, :bar
         
         subject.attributes = { :foo => 'value of foo', :bar => 'value of bar' }
@@ -43,22 +43,22 @@ module MongoModel
         TestDocument.attr_accessible :foo
       end
       
-      it "should allow the attribute to be mass-assigned via attributes=" do
+      it "allows the attribute to be mass-assigned via attributes=" do
         subject.attributes = { :foo => 'value of foo' }
         subject.foo.should == 'value of foo'
       end
       
-      it "should not disallow other attributes to be mass-assigned via attributes=" do
+      it "does not disallow other attributes to be mass-assigned via attributes=" do
         subject.attributes = { :bar => 'value of bar' }
         subject.bar.should be_nil
       end
       
-      it "should not disallow others attributes to be assigned individually" do
+      it "does not disallow others attributes to be assigned individually" do
         subject.bar = 'value of bar'
         subject.bar.should == 'value of bar'
       end
       
-      it "should accept multiple attributes" do
+      it "accepts multiple attributes" do
         TestDocument.attr_accessible :foo, :bar
         
         subject.attributes = { :foo => 'value of foo', :bar => 'value of bar' }
@@ -69,14 +69,14 @@ module MongoModel
     
     describe "#property" do
       context "with :protected option" do
-        it "should make the attribute protected" do
+        it "makes the attribute protected" do
           TestDocument.should_receive(:attr_protected).with(:baz)
           TestDocument.property :baz, String, :protected => true
         end
       end
       
       context "with :accessible option" do
-        it "should make the attribute accessible" do
+        it "makes the attribute accessible" do
           TestDocument.should_receive(:attr_accessible).with(:baz)
           TestDocument.property :baz, String, :accessible => true
         end