mongoid 8.1.5 → 9.0.0

data/spec/mongoid/persistable/multipliable_spec.rb

@@ -0,0 +1,227 @@
+# frozen_string_literal: true
+# rubocop:todo all
+
+require "spec_helper"
+
+describe Mongoid::Persistable::Multipliable do
+
+  describe "#mul" do
+
+    context "when the document is a root document" do
+
+      shared_examples_for "a multipliable root document" do
+
+        it "multiplies a positive value" do
+          expect(person.age).to eq(50)
+        end
+
+        it "multiplies a negative value" do
+          expect(person.score).to eq(-500)
+        end
+
+        it "multiplies a nonexistent value" do
+          expect(person.inte).to eq(0)
+        end
+
+        it "returns the self document" do
+          expect(op).to eq(person)
+        end
+
+        it "persists a positive mul" do
+          expect(person.reload.age).to eq(50)
+        end
+
+        it "persists a negative mul" do
+          expect(person.reload.score).to eq(-500)
+        end
+
+        it "persists a nonexistent mul" do
+          expect(person.reload.inte).to eq(0)
+        end
+
+        it "clears out dirty changes" do
+          expect(person).to_not be_changed
+        end
+      end
+
+      let(:person) do
+        Person.create!(age: 10, score: 100)
+      end
+
+      context "when providing string fields" do
+
+        let!(:op) do
+          person.mul("age" => 5, "score" => -5, "inte" => 30)
+        end
+
+        it_behaves_like "a multipliable root document"
+      end
+
+      context "when providing symbol fields" do
+
+        let!(:op) do
+          person.mul(age: 5, score: -5, inte: 30)
+        end
+
+        it_behaves_like "a multipliable root document"
+      end
+
+      context "when providing big decimal values" do
+
+        let(:positive) do
+          BigDecimal("5.0")
+        end
+
+        let(:negative) do
+          BigDecimal("-5.0")
+        end
+
+        let(:dynamic) do
+          BigDecimal("30.0")
+        end
+
+        let!(:op) do
+          person.mul(age: positive, score: negative, inte: dynamic)
+        end
+
+        it_behaves_like "a multipliable root document"
+      end
+    end
+
+    context "when the document is embedded" do
+
+      shared_examples_for "a multipliable embedded document" do
+
+        it "multiplies a positive value" do
+          expect(address.number).to eq(50)
+        end
+
+        it "multiplies a negative value" do
+          expect(address.no).to eq(-500)
+        end
+
+        it "multiplies a nonexistent value" do
+          expect(address.house).to eq(0)
+        end
+
+        it "returns the self document" do
+          expect(op).to eq(address)
+        end
+
+        it "persists a positive mul" do
+          expect(address.reload.number).to eq(50)
+        end
+
+        it "persists a negative mul" do
+          expect(address.reload.no).to eq(-500)
+        end
+
+        it "persists a nonexistent mul" do
+          expect(address.reload.house).to eq(0)
+        end
+
+        it "clears out dirty changes" do
+          expect(address).to_not be_changed
+        end
+      end
+
+      let(:person) do
+        Person.create!
+      end
+
+      let(:address) do
+        person.addresses.create!(street: "test", number: 10, no: 100)
+      end
+
+      context "when providing string fields" do
+
+        let!(:op) do
+          address.mul("number" => 5, "no" => -5, "house" => 30)
+        end
+
+        it_behaves_like "a multipliable embedded document"
+      end
+
+      context "when providing symbol fields" do
+
+        let!(:op) do
+          address.mul(number: 5, no: -5, house: 30)
+        end
+
+        it_behaves_like "a multipliable embedded document"
+      end
+
+      context "when providing big decimal values" do
+
+        let(:positive) do
+          BigDecimal("5.0")
+        end
+
+        let(:negative) do
+          BigDecimal("-5.0")
+        end
+
+        let(:dynamic) do
+          BigDecimal("30.0")
+        end
+
+        let!(:op) do
+          address.mul(number: positive, no: negative, house: dynamic)
+        end
+
+        it_behaves_like "a multipliable embedded document"
+      end
+    end
+
+    context "when executing atomically" do
+
+      let(:person) do
+        Person.create!(age: 10, score: 100)
+      end
+
+      it "marks a dirty change for the multiplied fields" do
+        person.atomically do
+          person.mul age: 15, score: 2
+          expect(person.changes).to eq({"age" => [10, 150], "score" => [100, 200]})
+        end
+      end
+    end
+
+    context "when executing on a readonly document" do
+
+      let(:person) do
+        Person.create!(age: 10, score: 100)
+      end
+
+      context "when legacy_readonly is true" do
+        config_override :legacy_readonly, true
+
+        before do
+          person.__selected_fields = { "age" => 1, "score" => 1 }
+        end
+
+        it "persists the changes" do
+          expect(person).to be_readonly
+          person.mul(age: 15, score: 2)
+          expect(person.age).to eq(150)
+          expect(person.score).to eq(200)
+        end
+      end
+
+      context "when legacy_readonly is false" do
+        config_override :legacy_readonly, false
+
+        before do
+          person.readonly!
+        end
+
+        it "raises a ReadonlyDocument error" do
+          expect(person).to be_readonly
+          expect do
+            person.mul(age: 15, score: 2)
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
+    end
+  end
+end

data/spec/mongoid/persistable/poppable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/persistable/pullable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/persistable/pushable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/persistable/renamable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/persistable/savable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 require "support/immutable_ids"
@@ -294,11 +295,6 @@ describe Mongoid::Persistable::Savable do
           expect(truck.crates[0].toys[0].name).to eq "Teddy bear"
           expect(truck.crates[1].volume).to eq 0.8
           expect(truck.crates[1].toys.size).to eq 0
-
-          # TODO: MONGOID-5026: combine the updates so that there are
-          # no conflicts.
-          #expect(truck.atomic_updates[:conflicts]).to eq nil
-
           expect { truck.save! }.not_to raise_error
 
           _truck = Truck.find(truck.id)
@@ -470,7 +466,7 @@ describe Mongoid::Persistable::Savable do
         expect {
           person.username = 'unloaded-attribute'
           person.save
-        }.to raise_error(ActiveModel::MissingAttributeError)
+        }.to raise_error(Mongoid::Errors::AttributeNotLoaded, /Attempted to access attribute 'username' on Person which was not loaded/)
       end
 
       context 'when the changed attribute is aliased' do

data/spec/mongoid/persistable/settable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -559,20 +560,20 @@ describe Mongoid::Persistable::Settable do
     end
 
     context 'field exists in database' do
-      it "raises MissingAttributeError" do
+      it "raises AttributeNotLoaded" do
         lambda do
           agent.set(title: '008')
-        end.should raise_error(ActiveModel::MissingAttributeError)
+        end.should raise_error(Mongoid::Errors::AttributeNotLoaded, /Attempted to access attribute 'title' on Agent which was not loaded/)
 
         expect(agent.reload.title).to eq 'Double-Oh Eight'
       end
     end
 
     context 'field does not exist in database' do
-      it "raises MissingAttributeError" do
+      it "raises AttributeNotLoaded" do
         lambda do
           agent.set(number: '008')
-        end.should raise_error(ActiveModel::MissingAttributeError)
+        end.should raise_error(Mongoid::Errors::AttributeNotLoaded, /Attempted to access attribute 'number' on Agent which was not loaded/)
 
         expect(agent.reload.read_attribute(:number)).to be nil
       end

data/spec/mongoid/persistable/unsettable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/persistable/updatable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 require "support/immutable_ids"
@@ -428,7 +429,7 @@ describe Mongoid::Persistable::Updatable do
         it 'does not allow the field to be updated' do
           expect {
             person.update_attribute(:title, 'Esteemed')
-          }.to raise_exception(ActiveModel::MissingAttributeError)
+          }.to raise_exception(Mongoid::Errors::AttributeNotLoaded, /Attempted to access attribute 'title' on Person which was not loaded/)
         end
 
         it 'does not persist the change' do
@@ -440,7 +441,7 @@ describe Mongoid::Persistable::Updatable do
           it 'does not allow the field to be updated' do
             expect {
               person.update_attribute('title', 'Esteemed')
-            }.to raise_exception(ActiveModel::MissingAttributeError)
+            }.to raise_exception(Mongoid::Errors::AttributeNotLoaded, /Attempted to access attribute 'title' on Person which was not loaded/)
           end
 
           it 'does not persist the change' do

data/spec/mongoid/persistable/upsertable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -83,7 +84,7 @@ describe Mongoid::Persistable::Upsertable do
 
           context "when not passing any options" do
             let(:options) { {} }
-            it_behaves_like "replaces the existing fields"
+            it_behaves_like "retains the existing fields"
           end
 
           context "when passing replace: false" do
@@ -148,6 +149,38 @@ describe Mongoid::Persistable::Upsertable do
       end
     end
 
+    context 'when `set_on_insert` is given' do
+      let!(:existing_document) { Band.create!(name: "They Might Be Giants") }
+      let!(:new_document) { Band.new(name: "Panic! at the Disco") }
+
+      context 'with `replace: true`' do
+        it 'should raise an ArgumentError' do
+          existing_document.name = "John and John"
+          expect {
+            existing_document.upsert(replace: true, set_on_insert: { member_count: 1 })
+          }.to raise_error(ArgumentError)
+        end
+      end
+
+      context 'without `replace: true`' do
+        context 'when document exists' do
+          it 'ignores set_on_insert' do
+            existing_document.name = "John and John"
+            existing_document.upsert(set_on_insert: { member_count: 1 })
+            expect(existing_document.reload.member_count).to be_nil
+          end
+        end
+
+        context 'when document does not exist' do
+          it 'applies set_on_insert' do
+            new_document.name = "Brendon Urie"
+            new_document.upsert(set_on_insert: { member_count: 1 })
+            expect(new_document.reload.member_count).to be == 1
+          end
+        end
+      end
+    end
+
     context "when the document is readonly" do
 
       context "when legacy_readonly is true" do

data/spec/mongoid/persistable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/persistence_context_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/positional_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/railties/bson_object_id_serializer_spec.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+# rubocop:todo all
+
+require 'spec_helper'
+require 'active_job'
+require 'mongoid/railties/bson_object_id_serializer'
+
+describe 'Mongoid::Railties::ActiveJobSerializers::BsonObjectIdSerializer' do
+
+  let(:serializer) { Mongoid::Railties::ActiveJobSerializers::BsonObjectIdSerializer.instance }
+  let(:object_id) { BSON::ObjectId.new }
+
+  describe '#serialize' do
+    it 'serializes BSON::ObjectId' do
+      expect(serializer.serialize(object_id)).to be_a(String)
+    end
+  end
+
+  describe '#deserialize' do
+    it 'deserializes BSON::ObjectId' do
+      expect(serializer.deserialize(serializer.serialize(object_id))).to eq(object_id)
+    end
+  end
+end

data/spec/mongoid/railties/console_sandbox_spec.rb

@@ -0,0 +1,44 @@
+# rubocop:todo all
+require 'spec_helper'
+require 'mongoid/railties/console_sandbox'
+
+describe 'console_sandbox' do
+  describe '#check_if_transactions_might_be_available!' do
+    context 'cluster may support transactions' do
+      require_topology :replica_set, :sharded, :load_balanced
+
+      it 'does not raise' do
+        expect do
+          check_if_transactions_might_be_available!(Mongoid.default_client)
+        end.not_to raise_error
+      end
+    end
+
+    context 'cluster does not support transactions' do
+      require_topology :single
+
+      it 'raises an error' do
+        expect do
+          check_if_transactions_might_be_available!(Mongoid.default_client)
+        end.to raise_error(Mongoid::Errors::TransactionsNotSupported)
+      end
+    end
+  end
+
+  describe '#start_sandbox_transaction' do
+    require_transaction_support
+
+    before do
+      start_sandbox_transaction(Mongoid.default_client)
+    end
+
+    after do
+      Mongoid.send(:_session).abort_transaction
+      Mongoid::Threaded.clear_session(client: Mongoid.default_client)
+    end
+
+    it 'starts transaction' do
+      expect(Mongoid.send(:_session)).to be_in_transaction
+    end
+  end
+end

data/spec/mongoid/relations/proxy_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 # require "spec_helper"
 #

data/spec/mongoid/reloadable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -290,103 +291,47 @@ describe Mongoid::Reloadable do
 
     context "when embedded documents are unasssigned and reassigned" do
 
-      context "when broken_updates feature flag is not set" do
-        config_override :broken_updates, false
-
-        let(:palette) do
-          Palette.new
-        end
-
-        let(:canvas) do
-          Canvas.create!
-        end
-
-        before do
-          canvas.palette = palette
-          canvas.palette = nil
-          canvas.palette = palette
-          canvas.save!
-          canvas.reload
-        end
-
-        it "reloads the embedded document correctly" do
-          expect(canvas.palette).to eq(palette)
-        end
+      let(:palette) do
+        Palette.new
       end
 
-      context "when broken_updates feature flag is set" do
-        config_override :broken_updates, true
-
-        let(:palette) do
-          Palette.new
-        end
-
-        let(:canvas) do
-          Canvas.create!
-        end
+      let(:canvas) do
+        Canvas.create!
+      end
 
-        before do
-          canvas.palette = palette
-          canvas.palette = nil
-          canvas.palette = palette
-          canvas.save!
-          canvas.reload
-        end
+      before do
+        canvas.palette = palette
+        canvas.palette = nil
+        canvas.palette = palette
+        canvas.save!
+        canvas.reload
+      end
 
-        it "does not reload the embedded document correctly" do
-          expect(canvas.palette).to be_nil
-        end
+      it "reloads the embedded document correctly" do
+        expect(canvas.palette).to eq(palette)
       end
     end
 
     context "when embeds_many documents are cleared and reassigned" do
 
-      context "when broken_updates feature flag is not set" do
-        config_override :broken_updates, false
-
-        let(:contractor) do
-          Contractor.new(name: 'contractor')
-        end
-
-        let(:building) do
-          Building.create!
-        end
-
-        it "persists an embedded document correctly the second time" do
-          building.contractors << contractor
-          expect(building.contractors).to eq([contractor])
-
-          building.contractors.clear
-          expect(building.contractors).to eq([])
-
-          building.contractors << contractor
-          building.reload
-          expect(building.contractors).to eq([contractor])
-        end
+      let(:contractor) do
+        Contractor.new(name: 'contractor')
       end
 
-      context "when broken_updates feature flag is set" do
-        config_override :broken_updates, true
-
-        let(:contractor) do
-          Contractor.new(name: 'contractor')
-        end
-
-        let(:building) do
-          Building.create!
-        end
+      let(:building) do
+        Building.create!
+      end
 
-        it "doesn't persist the embedded document correctly the second time" do
-          building.contractors << contractor
-          expect(building.contractors).to eq([contractor])
+      it "persists an embedded document correctly the second time" do
+        building.contractors << contractor
+        expect(building.contractors).to eq([contractor])
 
-          building.contractors.clear
-          expect(building.contractors).to eq([])
+        building.contractors.clear
+        expect(building.contractors).to eq([])
 
-          building.contractors << contractor
-          building.reload
-          expect(building.contractors).to eq([])
-        end
+        building.contractors << contractor
+        building.reload
+        expect(building.contractors).to eq([contractor])
       end
     end