mongoid 8.1.5 → 9.0.0

data/spec/mongoid/clients/transactions_spec_models.rb

@@ -0,0 +1,159 @@
+# rubocop:todo all
+class TransactionsSpecCounter
+  def initialize
+    @called = 0
+  end
+
+  def inc
+    @called += 1
+  end
+
+  def value
+    @called
+  end
+
+  def reset
+    @called = 0
+  end
+end
+
+module TransactionsSpecCountable
+  def after_commit_counter
+    @after_commit_counter ||= TransactionsSpecCounter.new
+  end
+
+  def after_commit_counter=(new_counter)
+    @after_commit_counter = new_counter
+  end
+
+  def after_rollback_counter
+    @after_rollback_counter ||= TransactionsSpecCounter.new
+  end
+
+  def after_rollback_counter=(new_counter)
+    @after_rollback_counter = new_counter
+  end
+end
+
+class TransactionsSpecPerson
+  include Mongoid::Document
+  include TransactionsSpecCountable
+
+  field :name, type: String
+
+  after_commit do
+    after_commit_counter.inc
+  end
+
+  after_rollback do
+    after_rollback_counter.inc
+  end
+end
+
+class TransactionsSpecPersonWithOnCreate
+  include Mongoid::Document
+  include TransactionsSpecCountable
+
+  field :name, type: String
+
+  after_commit on: :create do
+    after_commit_counter.inc
+  end
+
+  after_rollback on: :create do
+    after_rollback_counter.inc
+  end
+end
+
+class TransactionsSpecPersonWithOnUpdate
+  include Mongoid::Document
+  include TransactionsSpecCountable
+
+  field :name, type: String
+
+  after_commit on: :update do
+    after_commit_counter.inc
+  end
+
+  after_rollback on: :update do
+    after_rollback_counter.inc
+  end
+end
+
+class TransactionsSpecPersonWithOnDestroy
+  include Mongoid::Document
+  include TransactionsSpecCountable
+
+  field :name, type: String
+
+  after_commit on: :destroy do
+    after_commit_counter.inc
+  end
+
+  after_rollback on: :destroy do
+    after_rollback_counter.inc
+  end
+end
+class TransactionSpecRaisesBeforeSave
+  include Mongoid::Document
+  include TransactionsSpecCountable
+
+  field :attr, type: String
+
+  before_save do
+    raise "I cannot be saved"
+  end
+
+  after_commit do
+    after_commit_counter.inc
+  end
+
+  after_rollback do
+    after_rollback_counter.inc
+  end
+end
+
+class TransactionSpecRaisesAfterSave
+  include Mongoid::Document
+  include TransactionsSpecCountable
+
+  field :attr, type: String
+
+  after_save do
+    raise "I cannot be saved"
+  end
+
+  after_commit do
+    after_commit_counter.inc
+  end
+
+  after_rollback do
+    after_rollback_counter.inc
+  end
+end
+
+class TransactionSpecRaisesBeforeCreate
+  include Mongoid::Document
+
+  def self.after_commit_counter
+    @@after_commit_counter ||= TransactionsSpecCounter.new
+  end
+
+  def self.after_rollback_counter
+    @@after_rollback_counter ||= TransactionsSpecCounter.new
+  end
+
+  field :attr, type: String
+
+  before_create do
+    raise "I cannot be saved"
+  end
+
+  after_commit do
+    self.class.after_commit_counter.inc
+  end
+
+  after_rollback do
+    self.class.after_rollback_counter.inc
+  end
+end

data/spec/mongoid/clients_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -1163,7 +1164,7 @@ describe Mongoid::Clients do
         Band.create!(name: 'Led Zeppelin')
       end
 
-      it 'does not create extra symbols symbols' do
+      it 'does not create extra symbols' do
         first_band.with(write: { w: 0, j: false }) do |band|
           band.set(active: false)
         end
@@ -1171,7 +1172,7 @@ describe Mongoid::Clients do
         second_band.with(write: { w: 0, j: false }) do |band|
           band.set(active: false)
         end
-        expect(Symbol.all_symbols.size).to eq(initial_symbols_count)
+        expect(Symbol.all_symbols.size).to be <= initial_symbols_count
       end
 
     end
@@ -1215,4 +1216,48 @@ describe Mongoid::Clients do
       end
     end
   end
+
+  context "#disconnect" do
+
+    let(:clients) do
+      Mongoid::Clients.clients.values
+    end
+
+    before do
+      Band.all.entries
+    end
+
+    it "disconnects from all active clients" do
+      clients.each do |client|
+        expect(client).to receive(:close).and_call_original
+      end
+      Mongoid::Clients.disconnect
+    end
+
+    it "returns true" do
+      expect(Mongoid::Clients.disconnect).to eq(true)
+    end
+  end
+
+  context "#reconnect" do
+
+    let(:clients) do
+      Mongoid::Clients.clients.values
+    end
+
+    before do
+      Band.all.entries
+    end
+
+    it "reconnects all active clients" do
+      clients.each do |client|
+        expect(client).to receive(:reconnect).and_call_original
+      end
+      Mongoid::Clients.reconnect
+    end
+
+    it "returns true" do
+      expect(Mongoid::Clients.reconnect).to eq(true)
+    end
+  end
 end

data/spec/mongoid/collection_configurable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/composable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/config/defaults_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -10,59 +11,6 @@ describe Mongoid::Config::Defaults do
 
   describe ".load_defaults" do
 
-    shared_examples "uses settings for 7.3" do
-      it "uses settings for 7.3" do
-        expect(Mongoid.broken_aggregables).to be true
-        expect(Mongoid.broken_alias_handling).to be true
-        expect(Mongoid.broken_and).to be true
-        expect(Mongoid.broken_scoping).to be true
-        expect(Mongoid.broken_updates).to be true
-        expect(Mongoid.compare_time_by_ms).to be false
-        expect(Mongoid.legacy_pluck_distinct).to be true
-        expect(Mongoid.legacy_triple_equals).to be true
-        expect(Mongoid.object_id_as_json_oid).to be true
-      end
-    end
-
-    shared_examples "does not use settings for 7.3" do
-      it "does not use settings for 7.3" do
-        expect(Mongoid.broken_aggregables).to be false
-        expect(Mongoid.broken_alias_handling).to be false
-        expect(Mongoid.broken_and).to be false
-        expect(Mongoid.broken_scoping).to be false
-        expect(Mongoid.broken_updates).to be false
-        expect(Mongoid.compare_time_by_ms).to be true
-        expect(Mongoid.legacy_pluck_distinct).to be false
-        expect(Mongoid.legacy_triple_equals).to be false
-      end
-    end
-
-    shared_examples "uses settings for 7.4" do
-      it "uses settings for 7.4" do
-        expect(Mongoid.legacy_attributes).to be true
-        expect(Mongoid.overwrite_chained_operators).to be true
-      end
-    end
-
-    shared_examples "does not use settings for 7.4" do
-      it "does not use settings for 7.4" do
-        expect(Mongoid.legacy_attributes).to be false
-        expect(Mongoid.overwrite_chained_operators).to be false
-      end
-    end
-
-    shared_examples "uses settings for 7.5" do
-      it "uses settings for 7.5" do
-        expect(Mongoid.map_big_decimal_to_decimal128).to be false
-      end
-    end
-
-    shared_examples "does not use settings for 7.5" do
-      it "does not use settings for 7.5" do
-        expect(Mongoid.map_big_decimal_to_decimal128).to be true
-      end
-    end
-
     shared_examples "uses settings for 8.0" do
       it "uses settings for 8.0" do
         expect(Mongoid.legacy_readonly).to be true
@@ -78,6 +26,18 @@ describe Mongoid::Config::Defaults do
     shared_examples "uses settings for 8.1" do
       it "uses settings for 8.1" do
         expect(Mongoid.immutable_ids).to be false
+        expect(Mongoid.legacy_persistence_context_behavior).to be true
+        expect(Mongoid.around_callbacks_for_embeds).to be true
+        expect(Mongoid.prevent_multiple_calls_of_embedded_callbacks).to be false
+      end
+    end
+
+    shared_examples "does not use settings for 8.1" do
+      it "does not use settings for 8.1" do
+        expect(Mongoid.immutable_ids).to be true
+        expect(Mongoid.legacy_persistence_context_behavior).to be false
+        expect(Mongoid.around_callbacks_for_embeds).to be false
+        expect(Mongoid.prevent_multiple_calls_of_embedded_callbacks).to be true
       end
     end
 
@@ -91,69 +51,48 @@ describe Mongoid::Config::Defaults do
         Mongoid::Config.reset
       end
 
-      context "when the given version is 7.3" do
-
-        let(:version) { 7.3 }
-
-        it_behaves_like "uses settings for 7.3"
-        it_behaves_like "uses settings for 7.4"
-        it_behaves_like "uses settings for 7.5"
-        it_behaves_like "uses settings for 8.0"
-        it_behaves_like "uses settings for 8.1"
-      end
-
-      context "when the given version is 7.4" do
+      context "when the given version is 8.0" do
 
-        let(:version) { 7.4 }
+        let(:version) { 8.0 }
 
-        it_behaves_like "does not use settings for 7.3"
-        it_behaves_like "uses settings for 7.4"
-        it_behaves_like "uses settings for 7.5"
         it_behaves_like "uses settings for 8.0"
         it_behaves_like "uses settings for 8.1"
       end
 
-      context "when the given version is 7.5" do
+      context "when the given version is 8.1" do
 
-        let(:version) { 7.5 }
+        let(:version) { 8.1 }
 
-        it_behaves_like "does not use settings for 7.3"
-        it_behaves_like "does not use settings for 7.4"
-        it_behaves_like "uses settings for 7.5"
-        it_behaves_like "uses settings for 8.0"
+        it_behaves_like "does not use settings for 8.0"
         it_behaves_like "uses settings for 8.1"
       end
 
-      context "when the given version is 8.0" do
+      context "when the given version is 9.0" do
 
-        let(:version) { 8.0 }
+        let(:version) { 9.0 }
 
-        it_behaves_like "does not use settings for 7.3"
-        it_behaves_like "does not use settings for 7.4"
-        it_behaves_like "does not use settings for 7.5"
-        it_behaves_like "uses settings for 8.0"
-        it_behaves_like "uses settings for 8.1"
+        it_behaves_like "does not use settings for 8.0"
+        it_behaves_like "does not use settings for 8.1"
       end
+    end
 
-      context "when the given version is 8.1" do
-
-        let(:version) { 8.1 }
+    context "when given version a version which is no longer supported" do
+      let(:version) { 7.5 }
 
-        it_behaves_like "does not use settings for 7.3"
-        it_behaves_like "does not use settings for 7.4"
-        it_behaves_like "does not use settings for 7.5"
-        it_behaves_like "does not use settings for 8.0"
-        it_behaves_like "uses settings for 8.1"
+      it "raises an error" do
+        expect do
+          config.load_defaults(version)
+        end.to raise_error(ArgumentError, 'Version no longer supported: 7.5')
       end
     end
 
     context "when given version an invalid version" do
-      let(:version) { 4.2 }
+      let(:version) { '4,2' }
 
       it "raises an error" do
         expect do
           config.load_defaults(version)
-        end.to raise_error(ArgumentError, /Unknown version: 4.2/)
+        end.to raise_error(ArgumentError, 'Unknown version: 4,2')
       end
     end
   end

data/spec/mongoid/config/encryption_spec.rb

@@ -0,0 +1,152 @@
+# frozen_string_literal: true
+# rubocop:todo all
+
+require "spec_helper"
+require "support/crypt/models"
+
+describe Mongoid::Config::Encryption do
+
+  describe ".encryption_schema_map" do
+
+    let(:encryption_schema_map) do
+      Mongoid.config.encryption_schema_map(database_id, models)
+    end
+
+    context "when a model has encrypted fields" do
+      context 'when model has encrypt_metadata' do
+        let(:expected_schema_map) do
+          {
+            "mongoid_test.crypt_patients" => {
+              "bsonType" => "object",
+              "encryptMetadata" => {
+                "keyId" => [BSON::Binary.new(Base64.decode64("grolrnFVSSW9Gq04Q87R9Q=="), :uuid)]
+              },
+              "properties" => {
+                "medical_records" => {
+                  "encrypt" => {
+                    "bsonType" => "array",
+                    "algorithm" => "AEAD_AES_256_CBC_HMAC_SHA_512-Random"
+                  }
+                },
+                "blood_type" => {
+                  "encrypt" => {
+                    "keyId" => "/blood_type_key_name",
+                    "bsonType" => "string",
+                    "algorithm" => "AEAD_AES_256_CBC_HMAC_SHA_512-Random"
+                  }
+                },
+                "ssn" => {
+                  "encrypt" => {
+                    "bsonType" => "int",
+                    "algorithm" => "AEAD_AES_256_CBC_HMAC_SHA_512-Deterministic"
+                  }
+                },
+                'insurance' => {
+                  'bsonType' => 'object',
+                  'properties' => {
+                    'policy_number' => {
+                      'encrypt' => {
+                        'bsonType' => 'int',
+                        'algorithm' => 'AEAD_AES_256_CBC_HMAC_SHA_512-Deterministic'
+                      }
+                    }
+                  }
+                }
+              },
+            }
+          }
+        end
+
+        let(:models) do
+          [Crypt::Patient]
+        end
+
+        it "returns a map of encryption schemas" do
+          expect(encryption_schema_map).to eq(expected_schema_map)
+        end
+
+        context "when models are related" do
+          let(:models) do
+            [Crypt::Patient, Crypt::Insurance]
+          end
+
+          it "returns a map of encryption schemas" do
+            expect(encryption_schema_map).to eq(expected_schema_map)
+          end
+        end
+
+        context 'and fields do not have encryption options' do
+          let(:models) do
+            [Crypt::Car]
+          end
+
+          let(:expected_schema_map) do
+            {
+              "vehicles.crypt_cars" => {
+                "bsonType" => "object",
+                "encryptMetadata" => {
+                  "keyId" => [BSON::Binary.new(Base64.decode64("grolrnFVSSW9Gq04Q87R9Q=="), :uuid)],
+                  "algorithm" => "AEAD_AES_256_CBC_HMAC_SHA_512-Deterministic"
+                },
+                "properties" => {
+                  "vin" => {
+                    "encrypt" => {
+                      "bsonType" => "string"
+                    }
+                  }
+                }
+              }
+            }
+          end
+
+          it "returns a map of encryption schemas" do
+            expect(encryption_schema_map).to eq(expected_schema_map)
+          end
+        end
+      end
+
+      context 'when model does not have encrypt_metadata' do
+        let(:expected_schema_map) do
+          {
+            "mongoid_test.crypt_users" => {
+              "properties" => {
+                "name" => {
+                  "encrypt" => {
+                    'keyId' => [BSON::Binary.new(Base64.decode64("grolrnFVSSW9Gq04Q87R9Q=="), :uuid)],
+                    "bsonType" => "string",
+                    "algorithm" => "AEAD_AES_256_CBC_HMAC_SHA_512-Random"
+                  }
+                },
+                "email" => {
+                  "encrypt" => {
+                    'keyId' => [BSON::Binary.new(Base64.decode64("S34mE/HhSFSym3yErpER6Q=="), :uuid)],
+                    "bsonType" => "string",
+                    "algorithm" => "AEAD_AES_256_CBC_HMAC_SHA_512-Deterministic"
+                  }
+                }
+              }
+            }
+          }
+        end
+
+        let(:models) do
+          [Crypt::User]
+        end
+
+        it "returns a map of encryption schemas" do
+          expect(encryption_schema_map).to eq(expected_schema_map)
+        end
+      end
+    end
+
+    context 'when a model does not have encrypted fields' do
+      let(:models) do
+        [Person]
+      end
+
+      it 'returns an empty map' do
+        expect(encryption_schema_map).to eq({})
+      end
+    end
+  end
+end

data/spec/mongoid/config/environment_spec.rb

@@ -1,21 +1,14 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
+require "support/feature_sandbox"
 
 describe Mongoid::Config::Environment do
 
   around do |example|
-    if defined?(Rails)
-      SavedRails = Rails
+    FeatureSandbox.quarantine do
       example.run
-      Object.send(:remove_const, :Rails) if defined?(Rails)
-      Rails = SavedRails
-      Object.send(:remove_const, :SavedRails)
-    else
-      example.run
-      if defined?(Rails)
-        Object.send(:remove_const, :Rails)
-      end
     end
   end
 
@@ -26,11 +19,8 @@ describe Mongoid::Config::Environment do
       context "when an environment exists" do
 
         before do
-          module Rails
-            class << self
-              def env; "production"; end
-            end
-          end
+          require "support/rails_mock"
+          Rails.env = "production"
         end
 
         it "returns the rails environment" do
@@ -41,20 +31,7 @@ describe Mongoid::Config::Environment do
 
     context "when using sinatra" do
 
-      before do
-        Object.send(:remove_const, :Rails) if defined?(Rails)
-
-        module Sinatra
-          module Base
-            extend self
-            def environment; :staging; end
-          end
-        end
-      end
-
-      after do
-        Object.send(:remove_const, :Sinatra)
-      end
+      before { require "support/sinatra_mock" }
 
       it "returns the sinatra environment" do
         expect(described_class.env_name).to eq("staging")
@@ -63,14 +40,9 @@ describe Mongoid::Config::Environment do
 
     context "when the rack env variable is defined" do
 
-      before do
-        Object.send(:remove_const, :Rails) if defined?(Rails)
-        ENV["RACK_ENV"] = "acceptance"
-      end
+      before { ENV["RACK_ENV"] = "acceptance" }
 
-      after do
-        ENV["RACK_ENV"] = nil
-      end
+      after { ENV["RACK_ENV"] = nil }
 
       it "returns the rack environment" do
         expect(described_class.env_name).to eq("acceptance")
@@ -79,10 +51,6 @@ describe Mongoid::Config::Environment do
 
     context "when no environment information is found" do
 
-      before do
-        Object.send(:remove_const, :Rails) if defined?(Rails)
-      end
-
       it "raises an error" do
         expect { described_class.env_name }.to raise_error(
           Mongoid::Errors::NoEnvironment
@@ -94,7 +62,11 @@ describe Mongoid::Config::Environment do
   describe "#load_yaml" do
     let(:path) { 'mongoid.yml' }
     let(:environment) {}
-    before { allow(Rails).to receive('env').and_return('test') }
+
+    before do
+      require "support/rails_mock"
+      Rails.env = "test"
+    end
 
     subject { described_class.load_yaml(path, environment) }