mongoid 8.1.13 → 9.0.0

data/spec/mongoid/association/referenced/has_many_models.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 class HmmCompany
   include Mongoid::Document

data/spec/mongoid/association/referenced/has_many_query_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 require_relative './has_many_models'
@@ -23,7 +24,7 @@ describe Mongoid::Association::Referenced::HasMany do
       # has a default value specified in the model
       expect do
         student.grade
-      end.to raise_error(ActiveModel::MissingAttributeError)
+      end.to raise_error(Mongoid::Errors::AttributeNotLoaded)
       expect(student.attributes.keys).to eq(['_id', 'name'])
     end
 

data/spec/mongoid/association/referenced/has_many_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 require_relative './has_many_models'

data/spec/mongoid/association/referenced/has_one/binding_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/association/referenced/has_one/buildable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/association/referenced/has_one/eager_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 require_relative '../has_one_models'

data/spec/mongoid/association/referenced/has_one/proxy_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/association/referenced/has_one_models.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 class HomCollege
   include Mongoid::Document

data/spec/mongoid/association/referenced/has_one_query_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 require_relative './has_one_models'
@@ -23,7 +24,7 @@ describe Mongoid::Association::Referenced::HasOne do
       # has a default value specified in the model
       expect do
         accreditation.year
-      end.to raise_error(ActiveModel::MissingAttributeError)
+      end.to raise_error(Mongoid::Errors::AttributeNotLoaded)
       expect(legislator.attributes.keys).to eq(['_id', 'degree'])
     end
 

data/spec/mongoid/association/referenced/has_one_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 require_relative './has_one_models'

data/spec/mongoid/association/reflections_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/association/syncable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/association_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/atomic/modifiers_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/atomic/paths/embedded/many_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/atomic/paths/embedded/one_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/atomic/paths/root_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/atomic/paths_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/atomic_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/atomic_update_preparer_spec.rb

@@ -0,0 +1,83 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Mongoid::AtomicUpdatePreparer do
+  describe '#prepare' do
+    let(:prepared) { described_class.prepare(hash, Band) }
+
+    context 'when the hash already contains $set' do
+      context 'when the $set is first' do
+        let(:hash) do
+          { '$set' => { name: 'Tool' }, likes: 10, '$inc' => { plays: 1 } }
+        end
+
+        it 'moves the non hash values under the provided key' do
+          expect(prepared).to eq(
+            '$set' => { 'name' => 'Tool', 'likes' => 10 },
+            '$inc' => { 'plays' => 1 }
+          )
+        end
+      end
+
+      context 'when the $set is not first' do
+        let(:hash) do
+          { likes: 10, '$inc' => { plays: 1 }, '$set' => { name: 'Tool' } }
+        end
+
+        it 'moves the non hash values under the provided key' do
+          expect(prepared).to eq(
+            '$set' => { 'likes' => 10, 'name' => 'Tool' },
+            '$inc' => { 'plays' => 1 }
+          )
+        end
+      end
+    end
+
+    context 'when the hash does not contain $set' do
+      let(:hash) do
+        { likes: 10, '$inc' => { plays: 1 }, name: 'Tool' }
+      end
+
+      it 'moves the non hash values under the provided key' do
+        expect(prepared).to eq(
+          '$set' => { 'likes' => 10, 'name' => 'Tool' },
+          '$inc' => { 'plays' => 1 }
+        )
+      end
+    end
+
+    context 'when the hash contains $rename' do
+      let(:hash) { { likes: 10, '$rename' => { old: 'new' } } }
+
+      it 'preserves the $rename operator' do
+        expect(prepared).to eq(
+          '$set' => { 'likes' => 10 },
+          '$rename' => { 'old' => 'new' }
+        )
+      end
+    end
+
+    context 'when the hash contains $addToSet' do
+      let(:hash) { { likes: 10, '$addToSet' => { list: 'new' } } }
+
+      it 'preserves the $addToSet operator' do
+        expect(prepared).to eq(
+          '$set' => { 'likes' => 10 },
+          '$addToSet' => { 'list' => 'new' }
+        )
+      end
+    end
+
+    context 'when the hash contains $push' do
+      let(:hash) { { likes: 10, '$push' => { list: 14 } } }
+
+      it 'preserves the $push operator' do
+        expect(prepared).to eq(
+          '$set' => { 'likes' => 10 },
+          '$push' => { 'list' => 14 }
+        )
+      end
+    end
+  end
+end

data/spec/mongoid/attributes/dynamic_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/attributes/embedded_spec.rb

@@ -0,0 +1,118 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Mongoid::Attributes::Embedded do
+  describe '.traverse' do
+    subject(:embedded) { described_class.traverse(attributes, path) }
+
+    let(:path) { '100.name' }
+
+    context 'when the attribute key is a string' do
+      let(:attributes) { { '100' => { 'name' => 'hundred' } } }
+
+      it 'retrieves an embedded value under the provided key' do
+        expect(embedded).to eq 'hundred'
+      end
+
+      context 'when the value is false' do
+        let(:attributes) { { '100' => { 'name' => false } } }
+
+        it 'retrieves the embedded value under the provided key' do
+          expect(embedded).to be false
+        end
+      end
+
+      context 'when the value does not exist' do
+        let(:attributes) { { '100' => { 0 => 'Please do not return this value!' } } }
+
+        it 'returns nil' do
+          expect(embedded).to be_nil
+        end
+      end
+    end
+
+    context 'when the attribute key is an integer' do
+      let(:attributes) { { 100 => { 'name' => 'hundred' } } }
+
+      it 'retrieves an embedded value under the provided key' do
+        expect(embedded).to eq 'hundred'
+      end
+    end
+
+    context 'when the attribute value is nil' do
+      let(:attributes) { { 100 => { 'name' => nil } } }
+
+      it 'returns nil' do
+        expect(embedded).to be_nil
+      end
+    end
+
+    context 'when both string and integer keys are present' do
+      let(:attributes) { { '100' => { 'name' => 'Fred' }, 100 => { 'name' => 'Daphne' } } }
+
+      it 'returns the string key value' do
+        expect(embedded).to eq 'Fred'
+      end
+
+      context 'when the string key value is nil' do
+        let(:attributes) { { '100' => nil, 100 => { 'name' => 'Daphne' } } }
+
+        it 'returns nil' do
+          expect(embedded).to be_nil
+        end
+      end
+    end
+
+    context 'when attributes is an array' do
+      let(:attributes) do
+        [ { 'name' => 'Fred' }, { 'name' => 'Daphne' }, { 'name' => 'Velma' }, { 'name' => 'Shaggy' } ]
+      end
+      let(:path) { '2.name' }
+
+      it 'retrieves the nth value' do
+        expect(embedded).to eq 'Velma'
+      end
+
+      context 'when the member does not exist' do
+        let(:attributes) { [ { 'name' => 'Fred' }, { 'name' => 'Daphne' } ] }
+
+        it 'returns nil' do
+          expect(embedded).to be_nil
+        end
+      end
+    end
+
+    context 'when the path includes a scalar value' do
+      let(:attributes) { { '100' => 'name' } }
+
+      it 'returns nil' do
+        expect(embedded).to be_nil
+      end
+    end
+
+    context 'when the parent key is not present' do
+      let(:attributes) { { '101' => { 'name' => 'hundred and one' } } }
+
+      it 'returns nil' do
+        expect(embedded).to be_nil
+      end
+    end
+
+    context 'when the attributes are deeply nested' do
+      let(:attributes) { { '100' => { 'name' => { 300 => %w[a b c] } } } }
+
+      it 'retrieves the embedded subset of attributes' do
+        expect(embedded).to eq(300 => %w[a b c])
+      end
+
+      context 'when the path is deeply nested' do
+        let(:path) { '100.name.300.1' }
+
+        it 'retrieves the embedded value' do
+          expect(embedded).to eq 'b'
+        end
+      end
+    end
+  end
+end

data/spec/mongoid/attributes/nested_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 require_relative '../association/referenced/has_many_models'
@@ -7,33 +8,6 @@ require_relative './nested_spec_models'
 
 describe Mongoid::Attributes::Nested do
 
-  # Expects the enclosing context to define `build_with_id`, taking an id
-  # value and returning the document built with it in nested attributes.
-  shared_examples 'rejects non-scalar ids' do |klass_name|
-    not_found = /not found for class #{klass_name}/
-
-    context 'when the id is an operator hash' do
-      it 'raises a document not found error' do
-        expect { build_with_id({ '$ne' => nil }) }
-          .to raise_error(Mongoid::Errors::DocumentNotFound, not_found)
-      end
-    end
-
-    context 'when the id is an array' do
-      it 'raises a document not found error' do
-        expect { build_with_id([BSON::ObjectId.new]) }
-          .to raise_error(Mongoid::Errors::DocumentNotFound, not_found)
-      end
-    end
-
-    context 'when the id is a malformed object id hash' do
-      it 'raises a document not found error' do
-        expect { build_with_id({ '$oid' => 'junk' }) }
-          .to raise_error(Mongoid::Errors::DocumentNotFound, not_found)
-      end
-    end
-  end
-
   describe ".accepts_nested_attributes_for" do
 
     context "when the autosave option is not defined" do
@@ -205,30 +179,6 @@ describe Mongoid::Attributes::Nested do
       end
     end
 
-    context 'when the id in the attributes is not a scalar' do
-      let(:person) { Person.create! }
-
-      def build_with_id(id)
-        person.update!(posts_attributes: { '0' => { id: id, title: 'Crafted' } })
-      end
-
-      context 'when the association is empty' do
-        include_examples 'rejects non-scalar ids', 'Post'
-      end
-
-      context 'when the association is not empty' do
-        before { person.posts.create!(title: 'Existing') }
-
-        include_examples 'rejects non-scalar ids', 'Post'
-      end
-
-      context 'when allow_reparenting_via_nested_attributes is true' do
-        config_override :allow_reparenting_via_nested_attributes, true
-
-        include_examples 'rejects non-scalar ids', 'Post'
-      end
-    end
-
     context "when the relation is a references and referenced in many" do
 
       before do
@@ -252,100 +202,16 @@ describe Mongoid::Attributes::Nested do
           )
         end
 
-        context 'when allow_reparenting_via_nested_attributes is false' do
-          config_override :allow_reparenting_via_nested_attributes, false
-
-          it 'raises a document not found error' do
-            expect { person }.to raise_error(Mongoid::Errors::DocumentNotFound,
-                                             /Document\(s\) not found for class Preference/)
-          end
-        end
-
-        context 'when allow_reparenting_via_nested_attributes is true' do
-          config_override :allow_reparenting_via_nested_attributes, true
-
-          it 'sets the nested attributes' do
-            expect(person.preferences.map(&:name)).to eq([preference.name])
-          end
-
-          it 'updates attributes of existing document which is added to relation' do
-            preference_name = 'updated preference'
-            person = Person.new(
-              preferences_attributes: { 0 => { id: preference.id, name: preference_name } }
-            )
-            expect(person.preferences.map(&:name)).to eq([preference_name])
-          end
-
-          context 'when the id does not correspond to an existing document' do
-            let(:person) do
-              Person.new(
-                preferences_attributes: { 0 => { id: BSON::ObjectId.new, name: 'Ghost' } }
-              )
-            end
-
-            context 'when raise_not_found_error is true' do
-              config_override :raise_not_found_error, true
-
-              it 'raises a document not found error' do
-                expect { person }.to raise_error(Mongoid::Errors::DocumentNotFound,
-                                                 /Document\(s\) not found for class Preference/)
-              end
-            end
-
-            context 'when raise_not_found_error is false' do
-              config_override :raise_not_found_error, false
-
-              it 'raises a document not found error' do
-                expect { person }.to raise_error(Mongoid::Errors::DocumentNotFound,
-                                                 /Document\(s\) not found for class Preference/)
-              end
-            end
-          end
-        end
-
-        context 'when _destroy is true for a document not in the relation' do
-          before do
-            Person.send(:undef_method, :preferences_attributes=)
-            Person.accepts_nested_attributes_for :preferences, allow_destroy: true
-          end
-
-          let(:person) do
-            Person.new(
-              preferences_attributes: { 0 => { id: preference.id, _destroy: '1' } }
-            )
-          end
-
-          it 'does not raise UnknownAttribute' do
-            expect { person }.not_to raise_error
-          end
-
-          it 'does not add the document to the relation' do
-            expect(person.preferences).to be_empty
-          end
-        end
-      end
-
-      context 'when the id in the attributes is not a scalar' do
-        let(:target) { Person.create! }
-
-        def build_with_id(id)
-          target.update!(preferences_attributes: { 0 => { id: id, name: 'Crafted' } })
-        end
-
-        context 'when the association is empty' do
-          include_examples 'rejects non-scalar ids', 'Preference'
-        end
-
-        context 'when the association is not empty' do
-          before { target.preferences.create!(name: 'Existing') }
-
-          include_examples 'rejects non-scalar ids', 'Preference'
+        it "sets the nested attributes" do
+          expect(person.preferences.map(&:name)).to eq([preference.name])
         end
 
-        context 'when allow_reparenting_via_nested_attributes is true' do
-          config_override :allow_reparenting_via_nested_attributes, true
-
-          include_examples 'rejects non-scalar ids', 'Preference'
+        it "updates attributes of existing document which is added to relation" do
+          preference_name = 'updated preference'
+          person = Person.new(
+            preferences_attributes: { 0 => { id: preference.id, name: preference_name } }
+          )
+          expect(person.preferences.map(&:name)).to eq([preference_name])
         end
       end
     end
@@ -3150,7 +3016,7 @@ describe Mongoid::Attributes::Nested do
                       { "0" =>
                         { "id" => BSON::ObjectId.new.to_s, "title" => "Rogue" }
                       }
-                  }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document not found for class Post/)
+                  }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Post with id\(s\)/)
                 end
               end
             end
@@ -3184,7 +3050,7 @@ describe Mongoid::Attributes::Nested do
                 expect {
                   person.posts_attributes =
                     { "foo" => { "id" => "test", "title" => "Test" } }
-                }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document not found for class Post/)
+                }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Post with id\(s\)/)
               end
             end
           end
@@ -5132,63 +4998,4 @@ describe Mongoid::Attributes::Nested do
       end
     end
   end
-
-  context 'when an id in nested attributes belongs to another parent' do
-    let(:victim) { Person.create! }
-    let(:attacker) { Person.create! }
-
-    context 'when the association is a has-many' do
-      before do
-        Person.send(:undef_method, :posts_attributes=)
-        Person.accepts_nested_attributes_for :posts
-      end
-
-      let!(:victim_post) { victim.posts.create!(title: 'Private') }
-
-      it 'does not update the other parent\'s document' do
-        expect { attacker.update!(posts_attributes: { '0' => { id: victim_post.id, title: 'Overwritten' } }) }
-          .to raise_error(Mongoid::Errors::DocumentNotFound)
-        expect(victim_post.reload.title).to eq('Private')
-      end
-
-      it 'does not add the other parent\'s document to the association' do
-        expect { attacker.update!(posts_attributes: { '0' => { id: victim_post.id, title: 'Overwritten' } }) }
-          .to raise_error(Mongoid::Errors::DocumentNotFound)
-        expect(attacker.reload.posts).to be_empty
-      end
-
-      it 'does not update via a direct association assignment' do
-        expect { attacker.update!(posts: { '0' => { id: victim_post.id, title: 'Overwritten' } }) }
-          .to raise_error(Mongoid::Errors::DocumentNotFound)
-        expect(victim_post.reload.title).to eq('Private')
-      end
-    end
-
-    context 'when the association is a has-and-belongs-to-many' do
-      before do
-        Person.send(:undef_method, :preferences_attributes=)
-        Person.accepts_nested_attributes_for :preferences
-      end
-
-      let!(:victim_preference) { victim.preferences.create!(name: 'Private') }
-
-      it 'does not update the other parent\'s document' do
-        expect { attacker.update!(preferences_attributes: { '0' => { id: victim_preference.id, name: 'Overwritten' } }) }
-          .to raise_error(Mongoid::Errors::DocumentNotFound)
-        expect(victim_preference.reload.name).to eq('Private')
-      end
-
-      it 'does not add the other parent\'s document to the association' do
-        expect { attacker.update!(preferences_attributes: { '0' => { id: victim_preference.id, name: 'Overwritten' } }) }
-          .to raise_error(Mongoid::Errors::DocumentNotFound)
-        expect(attacker.reload.preferences).to be_empty
-      end
-
-      it 'does not update via a direct association assignment' do
-        expect { attacker.update!(preferences: { '0' => { id: victim_preference.id, name: 'Overwritten' } }) }
-          .to raise_error(Mongoid::Errors::DocumentNotFound)
-        expect(victim_preference.reload.name).to eq('Private')
-      end
-    end
-  end
 end

data/spec/mongoid/attributes/nested_spec_models.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 class NestedAuthor
   include Mongoid::Document

data/spec/mongoid/attributes/projector_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/attributes/readonly_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -265,26 +266,7 @@ describe Mongoid::Attributes::Readonly do
           expect(child.mother).to be_nil
         end
       end
-    end
-
-    context "when a subclass inherits readonly fields" do
-      let(:attributes) do
-        [:title, :terms]
-      end
-
-      before do
-        class OldPerson < Person
-          attr_readonly :age
-        end
-      end
 
-      it "ensures subclass inherits the readonly attributes from parent" do
-        expect(OldPerson.readonly_attributes.to_a).to include("title","terms")
-      end
-
-      it "ensures subclass does not modify parent's readonly attributes" do
-        expect(Person.readonly_attributes.to_a).not_to include("age")
-      end
     end
   end
 end