mongoid 7.5.3 → 8.1.2

data/spec/mongoid/association/referenced/has_and_belongs_to_many_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "spec_helper"
+require_relative "./has_and_belongs_to_many_models"
 
 describe Mongoid::Association::Referenced::HasAndBelongsToMany do
 
@@ -1008,8 +1009,8 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
 
   describe '#foreign_key_check' do
 
-    it 'returns the foreign_key followed by "_changed?"' do
-      expect(association.foreign_key_check).to eq('has_many_right_object_ids_changed?')
+    it 'returns the foreign_key followed by "_previously_changed?"' do
+      expect(association.foreign_key_check).to eq('has_many_right_object_ids_previously_changed?')
     end
   end
 
@@ -1060,6 +1061,13 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
         expect(association.inverse_foreign_key).to eq('bar_ref')
       end
     end
+
+    context "when using a model that uses the class_name option" do
+      let(:inverse_foreign_key) { HabtmmSchool.relations[:students].inverse_foreign_key }
+      it "gets the correct inverse foreign key" do
+        expect(inverse_foreign_key).to eq("school_ids")
+      end
+    end
   end
 
   describe '#inverse_foreign_key_setter' do
@@ -1068,4 +1076,29 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
       expect(association.inverse_foreign_key_setter).to eq('has_many_left_object_ids=')
     end
   end
+
+  context "when adding an object to the association" do
+    let!(:start_time) { Timecop.freeze(Time.at(Time.now.to_i)) }
+
+    let(:update_time) do
+      Timecop.freeze(Time.at(Time.now.to_i) + 2)
+    end
+
+    after do
+      Timecop.return
+    end
+
+    let!(:school) { HabtmmSchool.create! }
+    let!(:student) { HabtmmStudent.create! }
+
+    before do
+      update_time
+      school.update(students: [student])
+    end
+
+    it "updates the updated at" do
+      pending "MONGOID-4953"
+      expect(school.updated_at).to eq(update_time)
+    end
+  end
 end

data/spec/mongoid/association/referenced/has_many/buildable_spec.rb

@@ -138,5 +138,114 @@ describe Mongoid::Association::Referenced::HasMany::Buildable do
         end
       end
     end
+
+    context 'when the object is already associated with another object' do
+
+      context "when using <<" do
+
+        let(:person1) do
+          Person.new
+        end
+
+        let(:person2) do
+          Person.new
+        end
+
+        let(:drug) do
+          Drug.new
+        end
+
+        before do
+          person1.drugs << drug
+          person2.drugs << drug
+        end
+
+        it 'clears the object of its previous association' do
+          expect(person1.drugs).to eq([])
+          expect(person1.drug_ids).to eq([])
+          expect(person2.drugs).to eq([drug])
+          expect(person2.drug_ids).to eq([drug._id])
+        end
+      end
+
+      context "when using concat" do
+
+        let(:person1) do
+          Person.new
+        end
+
+        let(:person2) do
+          Person.new
+        end
+
+        let(:drug) do
+          Drug.new
+        end
+
+        before do
+          person1.drugs.concat([drug])
+          person2.drugs.concat([drug])
+        end
+
+        it 'clears the object of its previous association' do
+          expect(person1.drugs).to eq([])
+          expect(person1.drug_ids).to eq([])
+          expect(person2.drugs).to eq([drug])
+          expect(person2.drug_ids).to eq([drug._id])
+        end
+      end
+
+      context "when using =" do
+
+        let(:person1) do
+          Person.new
+        end
+
+        let(:person2) do
+          Person.new
+        end
+
+        let(:drug) do
+          Drug.new
+        end
+
+        before do
+          person1.drugs = [drug]
+          person2.drugs = [drug]
+        end
+
+        it 'clears the object of its previous association' do
+          expect(person1.drugs).to eq([])
+          expect(person1.drug_ids).to eq([])
+          expect(person2.drugs).to eq([drug])
+          expect(person2.drug_ids).to eq([drug._id])
+        end
+      end
+
+      context "when using = on the same document twice" do
+
+        let(:person1) do
+          Person.new
+        end
+
+        let(:person2) do
+          Person.new
+        end
+
+        let(:drug) do
+          Drug.new
+        end
+
+        before do
+          person1.drugs = [drug]
+          person1.drugs = [drug]
+        end
+
+        it 'clears the object of its previous association' do
+          expect(person1.drugs).to eq([drug])
+          expect(person1.drug_ids).to eq([drug._id])
+        end
+      end
+    end
   end
 end

data/spec/mongoid/association/referenced/has_many/enumerable_spec.rb

@@ -1237,33 +1237,6 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       end
     end
 
-    context 'when the id_sort option is none' do
-
-      let(:person) do
-        Person.create!
-      end
-
-      let(:criteria) do
-        Post.where(person_id: person.id)
-      end
-
-      let(:enumerable) do
-        described_class.new(criteria)
-      end
-
-      let!(:first_post) do
-        person.posts.create!(title: "One")
-      end
-
-      let!(:second_post) do
-        person.posts.create!(title: "Two")
-      end
-
-      it 'does not use the sort on id' do
-        expect(enumerable.first(id_sort: :none)).to eq(first_post)
-      end
-    end
-
     context 'when including a limit' do
 
       let(:person) do
@@ -1291,7 +1264,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       end
     end
 
-    context 'when the id_sort option is not provided' do
+    context 'when no parameters are provided' do
 
       let(:person) do
         Person.create!
@@ -1761,34 +1734,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       end
     end
 
-    context 'when the id_sort option is none' do
-
-      let(:person) do
-        Person.create!
-      end
-
-      let(:criteria) do
-        Post.where(person_id: person.id)
-      end
-
-      let(:enumerable) do
-        described_class.new(criteria)
-      end
-
-      let!(:first_post) do
-        person.posts.create!(title: "One")
-      end
-
-      let!(:second_post) do
-        person.posts.create!(title: "Two")
-      end
-
-      it 'does not use the sort on id' do
-        expect(enumerable.last(id_sort: :none)).to eq(first_post)
-      end
-    end
-
-    context 'when the id_sort option is not provided' do
+    context 'when no parameters are provided' do
 
       let(:person) do
         Person.create!