mongoid 7.5.3 → 8.1.2

data/spec/integration/discriminator_key_spec.rb

@@ -2,17 +2,17 @@
 
 require 'spec_helper'
 
-describe "#discriminator_key" do 
+describe "#discriminator_key" do
 
   context "when the discriminator key is not set on a class" do
-    let(:piano) do 
+    let(:piano) do
       Piano.new
     end
 
-    let(:guitar) do 
+    let(:guitar) do
       Guitar.new
-    end  
-    
+    end
+
     it "sets the child discriminator key to _type: Piano" do
       expect(piano._type).to eq("Piano")
     end
@@ -21,7 +21,7 @@ describe "#discriminator_key" do
       expect(guitar._type).to eq("Guitar")
     end
   end
-  
+
   context "when the discriminator key is changed in the parent" do
     before do
       Instrument.discriminator_key = "hello2"
@@ -31,11 +31,11 @@ describe "#discriminator_key" do
       Instrument.discriminator_key = nil
     end
 
-    let(:piano) do 
+    let(:piano) do
       Piano.new
     end
 
-    let(:guitar) do 
+    let(:guitar) do
       Guitar.new
     end
 
@@ -54,22 +54,24 @@ describe "#discriminator_key" do
         class GlobalIntDiscriminatorParent
           include Mongoid::Document
         end
-        
+
         class GlobalIntDiscriminatorChild < GlobalIntDiscriminatorParent
         end
-        
+
         Mongoid.discriminator_key = "test"
       end
 
       after do
         Mongoid.discriminator_key = "_type"
+        Object.send(:remove_const, :GlobalIntDiscriminatorParent)
+        Object.send(:remove_const, :GlobalIntDiscriminatorChild)
       end
 
-      let(:child) do 
+      let(:child) do
         GlobalIntDiscriminatorChild.new
       end
 
-      it "has a discriminator key _type" do 
+      it "has a discriminator key _type" do
         expect(child._type).to eq("GlobalIntDiscriminatorChild")
       end
 
@@ -79,36 +81,38 @@ describe "#discriminator_key" do
     end
 
     context "before class creation" do
+      config_override :discriminator_key, "test"
+
       before do
-        Mongoid.discriminator_key = "test"
 
         class PreGlobalIntDiscriminatorParent
           include Mongoid::Document
         end
-        
+
         class PreGlobalIntDiscriminatorChild < PreGlobalIntDiscriminatorParent
         end
       end
 
       after do
-        Mongoid.discriminator_key = "_type"
+        Object.send(:remove_const, :PreGlobalIntDiscriminatorParent)
+        Object.send(:remove_const, :PreGlobalIntDiscriminatorChild)
       end
 
-      let(:child) do 
+      let(:child) do
         PreGlobalIntDiscriminatorChild.new
       end
 
-      it "creates a field with new discriminator key" do 
+      it "creates a field with new discriminator key" do
         expect(child.test).to eq("PreGlobalIntDiscriminatorChild")
       end
-      
+
       it "does not have the default value as a field" do
         expect(defined?(child._type)).to be nil
       end
     end
   end
 
-  context "when the discriminator key is changed in the parent" do 
+  context "when the discriminator key is changed in the parent" do
     context "after child class creation" do
       before do
         class LocalIntDiscriminatorParent
@@ -121,15 +125,20 @@ describe "#discriminator_key" do
         LocalIntDiscriminatorParent.discriminator_key = "test2"
       end
 
-      let(:child) do 
+      after do
+        Object.send(:remove_const, :LocalIntDiscriminatorParent)
+        Object.send(:remove_const, :LocalIntDiscriminatorChild)
+      end
+
+      let(:child) do
         LocalIntDiscriminatorChild.new
       end
 
-      it "still has _type field in the child" do 
+      it "still has _type field in the child" do
         expect(child._type).to include("LocalIntDiscriminatorChild")
       end
 
-      it "has the new field in the child" do 
+      it "has the new field in the child" do
         expect(child.test2).to include("LocalIntDiscriminatorChild")
       end
     end
@@ -145,11 +154,16 @@ describe "#discriminator_key" do
         end
       end
 
-      let(:child) do 
+      after do
+        Object.send(:remove_const, :PreLocalIntDiscriminatorParent)
+        Object.send(:remove_const, :PreLocalIntDiscriminatorChild)
+      end
+
+      let(:child) do
         PreLocalIntDiscriminatorChild.new
       end
 
-      it "creates a new field in the child" do 
+      it "creates a new field in the child" do
         expect(child.test2).to include("PreLocalIntDiscriminatorChild")
       end
 
@@ -159,9 +173,9 @@ describe "#discriminator_key" do
     end
   end
 
-  context "when adding to the db" do 
+  context "when adding to the db" do
     context "when changing the discriminator_key" do
-      before do 
+      before do
         class DBDiscriminatorParent
           include Mongoid::Document
           self.discriminator_key = "dkey"
@@ -171,34 +185,44 @@ describe "#discriminator_key" do
         end
         DBDiscriminatorChild.create!
       end
-      
-      it "has the correct count" do 
+
+      after do
+        Object.send(:remove_const, :DBDiscriminatorParent)
+        Object.send(:remove_const, :DBDiscriminatorChild)
+      end
+
+      it "has the correct count" do
         expect(DBDiscriminatorChild.count).to eq(1)
       end
 
-      it "has the correct count in the parent" do 
+      it "has the correct count in the parent" do
         expect(DBDiscriminatorParent.count).to eq(1)
       end
     end
 
     context "when changing the discriminator_key after saving to the db" do
-      before do 
+      before do
         class DBDiscriminatorParent
           include Mongoid::Document
         end
-        
+
         class DBDiscriminatorChild < DBDiscriminatorParent
         end
         DBDiscriminatorChild.create!
         DBDiscriminatorParent.discriminator_key = "dkey2"
         DBDiscriminatorChild.create!
       end
-      
-      it "only finds the documents with the new discriminator key" do 
+
+      after do
+        Object.send(:remove_const, :DBDiscriminatorParent)
+        Object.send(:remove_const, :DBDiscriminatorChild)
+      end
+
+      it "only finds the documents with the new discriminator key" do
         expect(DBDiscriminatorChild.count).to eq(1)
       end
 
-      it "has the correct count in the parent" do 
+      it "has the correct count in the parent" do
         expect(DBDiscriminatorParent.count).to eq(2)
       end
     end
@@ -213,45 +237,51 @@ describe "#discriminator_key" do
           field :x, type: Integer
           field :y, type: Integer
           embedded_in :canvas
-  
+
           self.discriminator_key = "shape_type"
         end
-  
+
         class Example1Circle < Example1Shape
           field :radius, type: Float
         end
-  
+
         class Example1Rectangle < Example1Shape
           field :width, type: Float
           field :height, type: Float
         end
       end
-  
-      let(:rectangle) do 
+
+      after do
+        Object.send(:remove_const, :Example1Shape)
+        Object.send(:remove_const, :Example1Circle)
+        Object.send(:remove_const, :Example1Rectangle)
+      end
+
+      let(:rectangle) do
         Example1Rectangle.new
       end
-  
-      let(:circle) do 
+
+      let(:circle) do
         Example1Circle.new
       end
-  
-      it "has the new discriminator key: Rectangle" do 
+
+      it "has the new discriminator key: Rectangle" do
         expect(rectangle.shape_type).to eq("Example1Rectangle")
       end
-  
+
       it "does not have the default discriminator key: Rectangle" do
         expect(defined?(rectangle._type)).to be nil
       end
-  
-      it "has the new discriminator key: Circle" do 
+
+      it "has the new discriminator key: Circle" do
         expect(circle.shape_type).to eq("Example1Circle")
       end
-  
+
       it "does not have the default discriminator key: Circle" do
         expect(defined?(circle._type)).to be nil
       end
     end
-  
+
     context "Example 2" do
       before do
         class Example2Shape
@@ -260,91 +290,99 @@ describe "#discriminator_key" do
           field :y, type: Integer
           embedded_in :canvas
         end
-  
+
         class Example2Circle < Example2Shape
           field :radius, type: Float
         end
-  
+
         class Example2Rectangle < Example2Shape
           field :width, type: Float
           field :height, type: Float
         end
-  
+
         Example2Shape.discriminator_key = "shape_type"
       end
-  
-      let(:rectangle) do 
+
+      after do
+        Example2Shape.discriminator_key = "_type"
+        Object.send(:remove_const, :Example2Shape)
+        Object.send(:remove_const, :Example2Circle)
+        Object.send(:remove_const, :Example2Rectangle)
+      end
+
+      let(:rectangle) do
         Example2Rectangle.new
       end
-  
-      let(:circle) do 
+
+      let(:circle) do
         Example2Circle.new
       end
-  
-      it "has the new discriminator key: Rectangle" do 
+
+      it "has the new discriminator key: Rectangle" do
         expect(rectangle.shape_type).to eq("Example2Rectangle")
       end
-  
+
       it "has default discriminator key: Rectangle" do
         expect(rectangle._type).to eq("Example2Rectangle")
       end
-  
-      it "has the new discriminator key: Circle" do 
+
+      it "has the new discriminator key: Circle" do
         expect(circle.shape_type).to eq("Example2Circle")
       end
-  
+
       it "has default discriminator key: Circle" do
         expect(circle._type).to eq("Example2Circle")
       end
     end
-  
+
     context "Example 3" do
+      config_override :discriminator_key, "shape_type"
+
       before do
-  
-        Mongoid.discriminator_key = "shape_type"
-        
         class Example3Shape
           include Mongoid::Document
           field :x, type: Integer
           field :y, type: Integer
           embedded_in :canvas
         end
-  
+
         class Example3Circle < Example3Shape
           field :radius, type: Float
         end
-  
+
         class Example3Rectangle < Example3Shape
           field :width, type: Float
           field :height, type: Float
         end
-  
+
       end
 
-      after do 
-        Mongoid.discriminator_key = "_type"
+      after do
+        Object.send(:remove_const, :Example3Shape)
+        Object.send(:remove_const, :Example3Circle)
+        Object.send(:remove_const, :Example3Rectangle)
       end
-  
-      let(:rectangle) do 
+
+      let(:rectangle) do
         Example3Rectangle.new
       end
-  
-      let(:circle) do 
+
+      let(:circle) do
         Example3Circle.new
       end
-  
-      it "has the new discriminator key: Rectangle" do 
+
+      it "has the new discriminator key: Rectangle" do
         expect(rectangle.shape_type).to eq("Example3Rectangle")
       end
-  
+
       it "does not have the default discriminator key: Rectangle" do
         expect(defined?(rectangle._type)).to be nil
       end
-  
-      it "has the new discriminator key: Circle" do 
+
+      it "has the new discriminator key: Circle" do
         expect(circle.shape_type).to eq("Example3Circle")
       end
-  
+
       it "does not have the default discriminator key: Circle" do
         expect(defined?(circle._type)).to be nil
       end

data/spec/integration/dots_and_dollars_spec.rb

@@ -0,0 +1,277 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe "Dots and Dollars" do
+  min_server_version '5.0'
+
+  before(:all) do
+    class DADMUser
+      include Mongoid::Document
+      field :"first.last", type: String, default: "Neil.Shweky"
+      field :"$_amount", type: Integer, default: 0
+      field :"$a.b", type: Boolean, default: true
+    end
+  end
+
+  let!(:user) { DADMUser.create! }
+
+  describe "accessing the fields" do
+
+    context "when using the field getters" do
+
+      context "on dotted fields" do
+        it "gets the right value" do
+          expect(user.send(:"first.last")).to eq("Neil.Shweky")
+        end
+      end
+
+      context "on dollared fields" do
+        it "gets the right value" do
+          expect(user.send(:"$_amount")).to eq(0)
+        end
+      end
+
+      context "on dotted and dollared fields" do
+        it "gets the right value" do
+          expect(user.send(:"$a.b")).to be true
+        end
+      end
+    end
+
+    context "when using the read_attribute" do
+
+      context "on dotted fields" do
+        it "gets the right value" do
+          expect(user.read_attribute("first.last")).to eq("Neil.Shweky")
+        end
+      end
+
+      context "on dollared fields" do
+        it "gets the right value" do
+          expect(user.read_attribute("$_amount")).to eq(0)
+        end
+      end
+
+      context "on dotted and dollared fields" do
+        it "gets the right value" do
+          expect(user.read_attribute("$a.b")).to be true
+        end
+      end
+    end
+
+    context "when using the field setters" do
+
+      context "on dotted fields" do
+        it "raises an error" do
+          expect do
+            user.send(:"first.last=", "Nissim.Shweky")
+          end.to raise_error(Mongoid::Errors::InvalidDotDollarAssignment)
+        end
+      end
+
+      context "on dollared fields" do
+        it "raises an error" do
+          expect do
+            user.send(:"$_amount=", 1)
+          end.to raise_error(Mongoid::Errors::InvalidDotDollarAssignment)
+        end
+      end
+
+      context "on dotted and dollared fields" do
+        it "raises an error" do
+          expect do
+            user.send(:"$a.b=", false)
+          end.to raise_error(Mongoid::Errors::InvalidDotDollarAssignment)
+        end
+      end
+    end
+
+    context "when updating via write_attribute" do
+
+      context "on dotted fields" do
+        it "raises an error" do
+          expect do
+            user.write_attribute("first.last", "Nissim.Shweky")
+          end.to raise_error(Mongoid::Errors::InvalidDotDollarAssignment)
+        end
+      end
+
+      context "on dollared fields" do
+        it "raises an error" do
+          expect do
+            user.write_attribute("$_amount", 1)
+          end.to raise_error(Mongoid::Errors::InvalidDotDollarAssignment)
+        end
+      end
+
+      context "on dotted and dollared fields" do
+        it "raises an error" do
+          expect do
+            user.write_attribute("$a.b", false)
+          end.to raise_error(Mongoid::Errors::InvalidDotDollarAssignment)
+        end
+      end
+    end
+
+    context "when updating via update_attribute" do
+
+      context "on dotted fields" do
+        it "raises an error" do
+          expect do
+            user.update_attribute("first.last", "Nissim.Shweky")
+          end.to raise_error(Mongoid::Errors::InvalidDotDollarAssignment)
+        end
+      end
+
+      context "on dollared fields" do
+        it "raises an error" do
+          expect do
+            user.update_attribute("$_amount", 1)
+          end.to raise_error(Mongoid::Errors::InvalidDotDollarAssignment)
+        end
+      end
+
+      context "on dotted and dollared fields" do
+        it "raises an error" do
+          expect do
+            user.update_attribute("$a.b", false)
+          end.to raise_error(Mongoid::Errors::InvalidDotDollarAssignment)
+        end
+      end
+    end
+
+    context "when updating via update_attributes!" do
+
+      context "on dotted fields" do
+        it "raises an error" do
+          expect do
+            user.update_attributes!("first.last": "Nissim.Shweky")
+          end.to raise_error(Mongoid::Errors::InvalidDotDollarAssignment)
+        end
+      end
+
+      context "on dollared fields" do
+        it "raises an error" do
+          expect do
+            user.update_attributes!("$_amount": 1)
+          end.to raise_error(Mongoid::Errors::InvalidDotDollarAssignment)
+        end
+      end
+
+      context "on dotted and dollared fields" do
+        it "raises an error" do
+          expect do
+            user.update_attributes!("$a.b": false)
+          end.to raise_error(Mongoid::Errors::InvalidDotDollarAssignment)
+        end
+      end
+    end
+
+    context "when updating via []=" do
+
+      context "on dotted fields" do
+        it "raises an error" do
+          expect do
+            user[:"first.last"] = "Nissim.Shweky"
+          end.to raise_error(Mongoid::Errors::InvalidDotDollarAssignment)
+        end
+      end
+
+      context "on dollared fields" do
+        it "raises an error" do
+          expect do
+            user[:"$_amount"] = 1
+          end.to raise_error(Mongoid::Errors::InvalidDotDollarAssignment)
+        end
+      end
+
+      context "on dotted and dollared fields" do
+        it "raises an error" do
+          expect do
+            user[:"$a.b"] = false
+          end.to raise_error(Mongoid::Errors::InvalidDotDollarAssignment)
+        end
+      end
+    end
+
+    context "when updating via remove_attribute" do
+
+      context "on dotted fields" do
+        it "raises an error" do
+          expect do
+            user.remove_attribute("first.last")
+          end.to raise_error(Mongoid::Errors::InvalidDotDollarAssignment)
+        end
+      end
+
+      context "on dollared fields" do
+        it "raises an error" do
+          expect do
+            user.remove_attribute("$_amount")
+          end.to raise_error(Mongoid::Errors::InvalidDotDollarAssignment)
+        end
+      end
+
+      context "on dotted and dollared fields" do
+        it "raises an error" do
+          expect do
+            user.remove_attribute("$a.b")
+          end.to raise_error(Mongoid::Errors::InvalidDotDollarAssignment)
+        end
+      end
+    end
+  end
+
+  describe "persisting to the db" do
+
+    context "when saving to the db" do
+
+      let(:user) { DADMUser.new }
+
+      it "the save succeeds" do
+        expect do
+          user.save!
+        end.to_not raise_error
+      end
+    end
+
+    context "when retrieving it from the db" do
+
+      let(:from_db) { DADMUser.first }
+
+      it "has the fields populated correctly" do
+        expect(from_db.attributes["first.last"]).to eq("Neil.Shweky")
+        expect(from_db.attributes["$_amount"]).to eq(0)
+        expect(from_db.attributes["$a.b"]).to eq(true)
+      end
+    end
+  end
+
+  describe "querying that field" do
+
+    context "when attempting to query a dotted field" do
+
+      let(:queried) do
+        DADMUser.where("first.last": "Neil.Shweky").first
+      end
+
+      it "does not work" do
+        expect(queried).to be nil
+      end
+    end
+
+    context "when attempting to query a dollared field" do
+
+      let(:queried) do
+        DADMUser.where("$_amount": 0).first
+      end
+
+      it "raise an error" do
+        expect do
+          queried
+        end.to raise_error(Mongo::Error::OperationFailure)
+      end
+    end
+  end
+end