mongoid 7.3.4 → 7.4.0

data/spec/mongoid/persistable/settable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -45,7 +44,7 @@ describe Mongoid::Persistable::Settable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:date) do
@@ -109,11 +108,11 @@ describe Mongoid::Persistable::Settable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "t")
+        person.addresses.create!(street: "t")
       end
 
       let(:date) do
@@ -141,7 +140,7 @@ describe Mongoid::Persistable::Settable do
       context 'when the field is a relation' do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:pet) do
@@ -171,7 +170,7 @@ describe Mongoid::Persistable::Settable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(title: "sir", age: 30)
+        Person.create!(title: "sir", age: 30)
       end
 
       it "marks a dirty change for the set fields" do
@@ -185,7 +184,7 @@ describe Mongoid::Persistable::Settable do
 
   context "when dynamic attributes are not enabled" do
     let(:account) do
-      Account.create
+      Account.create!(name: 'Foobar')
     end
 
     it "raises exception for an unknown attribute " do
@@ -197,7 +196,7 @@ describe Mongoid::Persistable::Settable do
 
   context "when dynamic attributes enabled" do
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     it "updates non existing attribute" do
@@ -208,7 +207,7 @@ describe Mongoid::Persistable::Settable do
 
   context "with an attribute with private setter" do
     let(:agent) do
-      Agent.create
+      Agent.create!
     end
 
     let(:title) do
@@ -462,7 +461,7 @@ describe Mongoid::Persistable::Settable do
   context 'when the field is not already set locally' do
 
     let(:church) do
-      Church.create
+      Church.create!
     end
 
     context 'when the field is a Hash type' do

data/spec/mongoid/persistable/unsettable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -41,7 +40,7 @@ describe Mongoid::Persistable::Unsettable do
       end
 
       let(:person) do
-        Person.create(title: "test", age: 30, dob: date)
+        Person.create!(title: "test", age: 30, dob: date)
       end
 
       context "when provided a splat of symbols" do
@@ -111,11 +110,11 @@ describe Mongoid::Persistable::Unsettable do
       end
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
-        person.addresses.create(street: "kreuzberg", number: 40, city: "Berlin")
+        person.addresses.create!(street: "kreuzberg", number: 40, city: "Berlin")
       end
 
       context "when provided a splat of symbols" do
@@ -158,7 +157,7 @@ describe Mongoid::Persistable::Unsettable do
     context "when executing atomically" do
 
       let(:person) do
-        Person.create(title: "sir", age: 30)
+        Person.create!(title: "sir", age: 30)
       end
 
       it "marks a dirty change for the unset fields" do

data/spec/mongoid/persistable/updatable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -10,7 +9,7 @@ describe Mongoid::Persistable::Updatable do
     context "when the field is aliased" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when the setter is overridden" do
@@ -70,7 +69,7 @@ describe Mongoid::Persistable::Updatable do
     context "when setting an array field" do
 
       let(:person) do
-        Person.create(aliases: [])
+        Person.create!(aliases: [])
       end
 
       before do
@@ -118,7 +117,7 @@ describe Mongoid::Persistable::Updatable do
     context "when dynamic attributes are not enabled" do
 
       it "raises exception for an unknown attribute " do
-        account = Account.create
+        account = Account.create!(name: 'Foobar')
 
         expect {
           account.update_attribute(:somethingnew, "somethingnew")
@@ -126,7 +125,7 @@ describe Mongoid::Persistable::Updatable do
       end
 
       it "will update value of aliased field" do
-        person = Person.create
+        person = Person.create!
         person.update_attribute(:t, "test_value")
         expect(person.reload.t).to eq "test_value"
         expect(person.test).to eq "test_value"
@@ -234,7 +233,7 @@ describe Mongoid::Persistable::Updatable do
     context "when persisting a localized field" do
 
       let!(:product) do
-        Product.create(description: "The bomb")
+        Product.create!(description: "The bomb")
       end
 
       before do
@@ -263,15 +262,15 @@ describe Mongoid::Persistable::Updatable do
     context "when updating a deeply embedded document" do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:address) do
-        person.addresses.create(street: "Winterfeldtstr")
+        person.addresses.create!(street: "Winterfeldtstr")
       end
 
       let!(:location) do
-        address.locations.create(name: "work")
+        address.locations.create!(name: "work")
       end
 
       let(:from_db) do
@@ -302,7 +301,7 @@ describe Mongoid::Persistable::Updatable do
       end
 
       let(:person) do
-        Person.create(species: :human)
+        Person.create!(species: :human)
       end
 
       it 'raises an error when trying to set the attribute' do
@@ -347,7 +346,7 @@ describe Mongoid::Persistable::Updatable do
     context 'when the field is loaded explicitly' do
 
       before do
-        Person.create(title: 'Captain')
+        Person.create!(title: 'Captain')
       end
 
       context 'when the loaded attribute is updated' do
@@ -401,7 +400,7 @@ describe Mongoid::Persistable::Updatable do
     context 'when fields are explicitly not loaded' do
 
       before do
-        Person.create(title: 'Captain')
+        Person.create!(title: 'Captain')
       end
 
       context 'when the loaded attribute is updated' do
@@ -461,12 +460,12 @@ describe Mongoid::Persistable::Updatable do
         max_server_version '4.9'
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         it "raises an error" do
           expect {
-            person.update_attributes(map: { "$bad.key" => "value" })
+            person.update_attributes!(map: { "$bad.key" => "value" })
           }.to raise_error(Mongo::Error::OperationFailure)
         end
       end
@@ -474,11 +473,11 @@ describe Mongoid::Persistable::Updatable do
       context "when validation passes" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:saved) do
-          person.update_attributes(pets: false)
+          person.update_attributes!(pets: false)
         end
 
         let(:from_db) do
@@ -498,7 +497,7 @@ describe Mongoid::Persistable::Updatable do
         max_server_version '4.9'
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         it "raises an error" do
@@ -511,7 +510,7 @@ describe Mongoid::Persistable::Updatable do
       context "when validation passes" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:saved) do
@@ -534,7 +533,7 @@ describe Mongoid::Persistable::Updatable do
       context "when the document has been destroyed" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         before do
@@ -555,7 +554,7 @@ describe Mongoid::Persistable::Updatable do
         end
 
         let(:game) do
-          Game.create(person: person)
+          Game.create!(person: person)
         end
 
         before do
@@ -592,7 +591,7 @@ describe Mongoid::Persistable::Updatable do
         context "when providing an embedded child" do
 
           let!(:person) do
-            Person.create
+            Person.create!
           end
 
           let!(:name) do
@@ -619,11 +618,11 @@ describe Mongoid::Persistable::Updatable do
         context "when providing a parent to a referenced in" do
 
           let!(:person) do
-            Person.create
+            Person.create!
           end
 
           let!(:post) do
-            Post.create(title: "Testing")
+            Post.create!(title: "Testing")
           end
 
           context "when the relation has not yet been touched" do
@@ -684,7 +683,7 @@ describe Mongoid::Persistable::Updatable do
         before do
           phone_number.country_code = country_code
           person.phone_numbers << phone_number
-          person.save
+          person.save!
         end
 
         it "sets the first level document" do
@@ -740,4 +739,22 @@ describe Mongoid::Persistable::Updatable do
       end
     end
   end
+
+  describe "#update_attributes!" do
+
+    let(:person) do
+      Person.create!
+    end
+
+    let(:attributes) do
+      { security_code: 'secret' }
+    end
+
+    it 'calls update_attributes' do
+      person.should receive(:update_attributes).with(attributes).and_call_original
+      lambda do
+        person.update_attributes!(attributes)
+      end.should_not raise_error
+    end
+  end
 end

data/spec/mongoid/persistable/upsertable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -83,7 +82,7 @@ describe Mongoid::Persistable::Upsertable do
     context "when the document is not new" do
 
       let!(:existing) do
-        Band.create(name: "Photek")
+        Band.create!(name: "Photek")
       end
 
       context "when updating fields outside of the id" do

data/spec/mongoid/persistable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -10,7 +9,7 @@ describe Mongoid::Persistable do
   describe "#atomically" do
 
     let(:document) do
-      Band.create(member_count: 0, likes: 60, origin: "London")
+      Band.create!(member_count: 0, likes: 60, origin: "London")
     end
 
     context "when providing a block" do

data/spec/mongoid/persistence_context_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 

data/spec/mongoid/positional_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 

data/spec/mongoid/query_cache_middleware_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -20,7 +19,7 @@ describe Mongoid::QueryCache::Middleware do
       expect(code).to eq(200)
     end
 
-    it "enableds the query cache" do
+    it "enables the query cache" do
       middleware.call({})
       expect(@enabled).to be true
     end

data/spec/mongoid/query_cache_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
+require 'mongoid/association/referenced/has_many_models'
 
 describe Mongoid::QueryCache do
 
@@ -17,11 +17,11 @@ describe Mongoid::QueryCache do
     # occur only within the scope of these tests.
     #
     # Other session leaks will be detected and addressed as part of RUBY-2391.
-    SessionRegistry.instance.clear_registry
+    Mrss::SessionRegistry.instance.clear_registry
   end
 
   after do
-    SessionRegistry.instance.verify_sessions_ended!
+    Mrss::SessionRegistry.instance.verify_sessions_ended!
   end
 
   let(:reset_legacy_qc_warning) do
@@ -259,11 +259,11 @@ describe Mongoid::QueryCache do
     end
 
     before do
-      person = Person.create
+      person = Person.create!
       3.times do
-        person.send(relation).create
+        person.send(relation).create!
       end
-      person.save
+      person.save!
     end
 
     let!(:relations) do
@@ -476,7 +476,7 @@ describe Mongoid::QueryCache do
   context 'querying all documents after a single document' do
     before do
       3.times do
-        Person.create
+        Person.create!
       end
     end
 
@@ -532,7 +532,7 @@ describe Mongoid::QueryCache do
   context 'when using a block API' do
     before do
       Band.destroy_all
-      5.times { Band.create }
+      5.times { Band.create! }
     end
 
     context '#any? with no block' do
@@ -792,7 +792,7 @@ describe Mongoid::QueryCache do
       end
     end
 
-   context 'when querying colleciton larger than the batch size' do
+   context 'when querying collection larger than the batch size' do
      before do
        Band.destroy_all
        101.times { |i| Band.create!(_id: i) }
@@ -891,7 +891,7 @@ describe Mongoid::QueryCache do
   context "when reloading a document" do
 
     let!(:band_id) do
-      Band.create.id
+      Band.create!.id
     end
 
     context 'when query cache is disabled' do
@@ -999,4 +999,26 @@ describe Mongoid::QueryCache do
       end
     end
   end
+
+  context 'after calling none? on an association' do
+    let!(:host) do
+      HmmSchool.delete_all
+      school = HmmSchool.create!
+      5.times do
+        HmmStudent.create!(school: school)
+      end
+    end
+
+    let(:school) { HmmSchool.first }
+
+    before do
+      Mongoid::QueryCache.clear_cache
+
+      school.students.none?
+    end
+
+    it 'returns all children for the association' do
+      school.students.to_a.length.should == 5
+    end
+  end
 end

data/spec/mongoid/relations/proxy_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 # require "spec_helper"
 #
@@ -17,7 +16,7 @@
 #
 #     before do
 #       circus.animals << animal
-#       circus.save
+#       circus.save!
 #     end
 #
 #     it 'uses the new persistence options' do
@@ -31,7 +30,7 @@
 #
 #   describe "#find" do
 #     let(:person) do
-#       Person.create
+#       Person.create!
 #     end
 #
 #     let(:messages) do
@@ -39,7 +38,7 @@
 #     end
 #
 #     let(:msg1) do
-#       messages.create(body: 'msg1')
+#       messages.create!(body: 'msg1')
 #     end
 #
 #     it "returns nil with no arguments" do
@@ -70,7 +69,7 @@
 #     end
 #
 #     let(:person) do
-#       Person.create
+#       Person.create!
 #     end
 #
 #     let(:name) do
@@ -88,7 +87,7 @@
 #     context "when extending from the relation definition" do
 #
 #       let!(:address) do
-#         person.addresses.create(street: "hobrecht")
+#         person.addresses.create!(street: "hobrecht")
 #       end
 #
 #       let(:found) do
@@ -103,7 +102,7 @@
 #
 #   describe "equality" do
 #     let(:messages) do
-#       Person.create.messages
+#       Person.create!.messages
 #     end
 #
 #     it "is #equal? to itself" do