mongoid 7.3.4 → 7.4.0

data/spec/mongoid/contextual/none_spec.rb

@@ -1,22 +1,20 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
 describe Mongoid::Contextual::None do
 
-  describe "#==" do
+  before do
+    Band.create!(name: "Depeche Mode")
+  end
 
-    let!(:band) do
-      Band.create(name: "Depeche Mode")
-    end
+  let(:context) do
+    described_class.new(Band.where(name: "Depeche Mode"))
+  end
 
-    let(:context) do
-      described_class.new(Band.where(name: "Depeche Mode"))
-    end
+  describe "#==" do
 
     context "when the other is a none" do
-
       let(:other) do
         described_class.new(Band.where(name: "Depeche Mode"))
       end
@@ -27,7 +25,6 @@ describe Mongoid::Contextual::None do
     end
 
     context "when the other is not a none" do
-
       let(:other) do
         Mongoid::Contextual::Memory.new(Band.where(name: "Depeche Mode"))
       end
@@ -39,120 +36,48 @@ describe Mongoid::Contextual::None do
   end
 
   describe "#each" do
-
-    let!(:band) do
-      Band.create(name: "Depeche Mode")
-    end
-
-    let(:context) do
-      described_class.new(Band.where(name: "Depeche Mode"))
-    end
-
     it "iterates over no documents" do
       expect(context.each.entries).to be_empty
     end
   end
 
   describe "#exists?" do
-
-    let!(:band) do
-      Band.create(name: "Depeche Mode")
-    end
-
-    let(:context) do
-      described_class.new(Band.where(name: "Depeche Mode"))
-    end
-
     it "returns false" do
       expect(context).to_not be_exists
     end
   end
 
   describe "#distinct" do
-
-    let!(:band) do
-      Band.create(name: "Depeche Mode")
-    end
-
-    let(:context) do
-      described_class.new(Band.where(name: "Depeche Mode"))
-    end
-
     it "returns an empty array" do
       expect(context.distinct(:id)).to eq([])
     end
   end
 
   describe "#pluck" do
-
-    let!(:band) do
-      Band.create(name: "Depeche Mode")
-    end
-
-    let(:context) do
-      described_class.new(Band.where(name: "Depeche Mode"))
-    end
-
     it "returns an empty array" do
       expect(context.pluck(:id)).to eq([])
     end
   end
 
   describe "#first" do
-
-    let!(:band) do
-      Band.create(name: "Depeche Mode")
-    end
-
-    let(:context) do
-      described_class.new(Band.where(name: "Depeche Mode"))
-    end
-
     it "returns nil" do
       expect(context.first).to be_nil
     end
   end
 
   describe "#last" do
-
-    let!(:band) do
-      Band.create(name: "Depeche Mode")
-    end
-
-    let(:context) do
-      described_class.new(Band.where(name: "Depeche Mode"))
-    end
-
     it "returns nil" do
       expect(context.last).to be_nil
     end
   end
 
   describe "#length" do
-
-    let!(:band) do
-      Band.create(name: "Depeche Mode")
-    end
-
-    let(:context) do
-      described_class.new(Band.where(name: "Depeche Mode"))
-    end
-
     it "returns zero" do
       expect(context.length).to eq(0)
     end
   end
 
   describe "#size" do
-
-    let!(:band) do
-      Band.create(name: "Depeche Mode")
-    end
-
-    let(:context) do
-      described_class.new(Band.where(name: "Depeche Mode"))
-    end
-
     it "returns zero" do
       expect(context.size).to eq(0)
     end

data/spec/mongoid/copyable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -46,7 +45,7 @@ describe Mongoid::Copyable do
       context "when the document has an id field in the database" do
 
         let!(:band) do
-          Band.create(name: "Tool")
+          Band.create!(name: "Tool")
         end
 
         before do
@@ -66,7 +65,7 @@ describe Mongoid::Copyable do
 
         shared_examples 'behaves as expected' do
           let!(:instance) do
-            cls.create(name: "test")
+            cls.create!(name: "test")
           end
 
           before do
@@ -91,7 +90,7 @@ describe Mongoid::Copyable do
           end
 
           it 'calls constructor with explicitly declared attributes only' do
-            expect(cls).to receive(:new).with({'name' => 'test'}).and_call_original
+            expect(cls).to receive(:new).with('name' => 'test').and_call_original
             cloned
           end
         end
@@ -127,7 +126,7 @@ describe Mongoid::Copyable do
             it "clones" do
               t = StoreAsDupTest1.new(:name => "hi")
               t.build_store_as_dup_test2(:name => "there")
-              t.save
+              t.save!
               copy = t.send(method)
               expect(copy.object_id).not_to eq(t.object_id)
               expect(copy.store_as_dup_test2.name).to eq(t.store_as_dup_test2.name)
@@ -140,7 +139,7 @@ describe Mongoid::Copyable do
             it "clones" do
               t = StoreAsDupTest3.new(:name => "hi")
               t.store_as_dup_test4s << StoreAsDupTest4.new
-              t.save
+              t.save!
               copy = t.send(method)
               expect(copy.object_id).not_to eq(t.object_id)
               expect(copy.store_as_dup_test4s).not_to be_empty
@@ -171,7 +170,7 @@ describe Mongoid::Copyable do
           I18n.locale = 'pt_BR'
           person.desc = "descrição"
           person.addresses.first.name = "descrição"
-          person.save
+          person.save!
         end
 
         after do
@@ -249,7 +248,7 @@ describe Mongoid::Copyable do
       context "when cloning a loaded document" do
 
         before do
-          person.save
+          person.save!
         end
 
         let!(:from_db) do
@@ -364,7 +363,7 @@ describe Mongoid::Copyable do
             end
 
             before do
-              copy.save(validate: false)
+              copy.save!(validate: false)
             end
 
             it "persists the attributes" do
@@ -441,7 +440,7 @@ describe Mongoid::Copyable do
             end
 
             before do
-              copy.save(validate: false)
+              copy.save!(validate: false)
             end
 
             it "persists the attributes" do
@@ -530,7 +529,7 @@ describe Mongoid::Copyable do
             end
 
             before do
-              copy.save(validate: false)
+              copy.save!(validate: false)
             end
 
             it "persists the attributes" do
@@ -605,7 +604,7 @@ describe Mongoid::Copyable do
           end
 
           before do
-            copy.save(validate: false)
+            copy.save!(validate: false)
           end
 
           it "persists the attributes" do
@@ -637,7 +636,7 @@ describe Mongoid::Copyable do
         end
 
         before do
-          person.save
+          person.save!
         end
 
         let!(:from_db) do

data/spec/mongoid/copyable_spec_models.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 module CopyableSpec
   class A

data/spec/mongoid/criteria/findable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -10,11 +9,11 @@ describe Mongoid::Criteria::Findable do
     context "when finding by a document" do
 
       let(:band) do
-        Band.create(name: "Tool")
+        Band.create!(name: "Tool")
       end
 
       let!(:record) do
-        band.records.create(name: "Undertow")
+        band.records.create!(name: "Undertow")
       end
 
       context "when the document is the root" do
@@ -41,7 +40,7 @@ describe Mongoid::Criteria::Findable do
 
       context 'when criteria has additional conditions' do
         let(:band) do
-          Band.create(name: "Tool")
+          Band.create!(name: "Tool")
         end
 
         let(:found) do
@@ -57,11 +56,11 @@ describe Mongoid::Criteria::Findable do
 
       context 'when criteria has additional conditions on id' do
         let(:band) do
-          Band.create(name: "Tool")
+          Band.create!(name: "Tool")
         end
 
         let(:other) do
-          Band.create(name: "Other")
+          Band.create!(name: "Other")
         end
 
         let(:found) do
@@ -79,7 +78,7 @@ describe Mongoid::Criteria::Findable do
     context "when using object ids" do
 
       let!(:band) do
-        Band.create
+        Band.create!
       end
 
       context "when providing a single id" do
@@ -149,7 +148,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing a splat of ids" do
 
         let!(:band_two) do
-          Band.create(name: "Tool")
+          Band.create!(name: "Tool")
         end
 
         context "when all ids match" do
@@ -221,7 +220,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing an array of ids" do
 
         let!(:band_two) do
-          Band.create(name: "Tool")
+          Band.create!(name: "Tool")
         end
 
         context "when all ids match" do
@@ -346,7 +345,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing a splat of extended json ids" do
 
         let!(:band_two) do
-          Band.create(name: "Tool")
+          Band.create!(name: "Tool")
         end
 
         context "when all ids match" do
@@ -418,7 +417,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing an array of extended json ids" do
 
         let!(:band_two) do
-          Band.create(name: "Tool")
+          Band.create!(name: "Tool")
         end
 
         context "when all ids match" do
@@ -499,7 +498,7 @@ describe Mongoid::Criteria::Findable do
       end
 
       let!(:band) do
-        Band.create do |band|
+        Band.create! do |band|
           band.id = "tool"
         end
       end
@@ -560,7 +559,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing a splat of ids" do
 
         let!(:band_two) do
-          Band.create do |band|
+          Band.create! do |band|
             band.id = "depeche-mode"
           end
         end
@@ -623,7 +622,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing an array of ids" do
 
         let!(:band_two) do
-          Band.create do |band|
+          Band.create! do |band|
             band.id = "depeche-mode"
           end
         end
@@ -695,7 +694,7 @@ describe Mongoid::Criteria::Findable do
       end
 
       let!(:band) do
-        Band.create do |band|
+        Band.create! do |band|
           band.id = {"new-order" => true, "Depeche Mode" => false}
         end
       end
@@ -756,7 +755,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing a splat of ids" do
 
         let!(:band_two) do
-          Band.create do |band|
+          Band.create! do |band|
             band.id = {"Radiohead" => false, "Nirvana"=> true}
           end
         end
@@ -819,7 +818,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing an array of ids" do
 
         let!(:band_two) do
-          Band.create do |band|
+          Band.create! do |band|
             band.id = {"Radiohead" => false, "Nirvana"=> true}
           end
         end
@@ -891,7 +890,7 @@ describe Mongoid::Criteria::Findable do
       end
 
       let!(:band) do
-        Band.create do |band|
+        Band.create! do |band|
           band.id = 1
         end
       end
@@ -952,7 +951,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing a splat of ids" do
 
         let!(:band_two) do
-          Band.create do |band|
+          Band.create! do |band|
             band.id = 2
           end
         end
@@ -1015,7 +1014,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing an array of ids" do
 
         let!(:band_two) do
-          Band.create do |band|
+          Band.create! do |band|
             band.id = 2
           end
         end
@@ -1078,7 +1077,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing a range" do
 
         let!(:band_two) do
-          Band.create do |band|
+          Band.create! do |band|
             band.id = 2
           end
         end
@@ -1150,7 +1149,7 @@ describe Mongoid::Criteria::Findable do
     context "when using string and object ids" do
 
       let!(:band) do
-        Band.create
+        Band.create!
       end
 
       context "when providing multiple ids" do
@@ -1190,11 +1189,11 @@ describe Mongoid::Criteria::Findable do
   describe "#multiple_from__db" do
 
     let!(:band) do
-      Band.create(name: "Depeche Mode")
+      Band.create!(name: "Depeche Mode")
     end
 
     let!(:band_two) do
-      Band.create(name: "Tool")
+      Band.create!(name: "Tool")
     end
 
     context "when providing a single id" do

data/spec/mongoid/criteria/inspectable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 

data/spec/mongoid/criteria/marshalable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"