mongoid 7.2.6 → 7.3.0

data/spec/mongoid/association/embedded/embeds_many/proxy_spec.rb

@@ -2449,26 +2449,13 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     end
 
     context "when providing a criteria class method" do
-      context "without keyword arguments" do
 
-        let(:addresses) do
-          person.addresses.california
-        end
-
-        it "applies the criteria to the documents" do
-          expect(addresses).to eq([ address_one ])
-        end
+      let(:addresses) do
+        person.addresses.california
       end
 
-      context "with keyword arguments" do
-
-        let(:addresses) do
-          person.addresses.city_and_state(city: "Sacramento", state: "CA")
-        end
-
-        it "applies the criteria to the documents" do
-          expect(addresses).to eq([])
-        end
+      it "applies the criteria to the documents" do
+        expect(addresses).to eq([ address_one ])
       end
     end
 

data/spec/mongoid/association/nested/one_spec.rb

@@ -137,20 +137,24 @@ describe Mongoid::Association::Nested::One do
         { allow_destroy: true }
       end
 
-      let(:builder) do
-        described_class.new(association, {
-          id: name.id,
-          last_name: "Lang",
-          _destroy: true
-        }, options)
-      end
-
-      before do
-        builder.build(person)
-      end
-
-      it "deletes the relation" do
-        expect(person.name).to be_nil
+      %i(id _id).each do |id_field|
+        context "#{id_field}" do
+          let(:builder) do
+            described_class.new(association, {
+              id_field => name.id,
+              last_name: "Lang",
+              _destroy: true
+            }, options)
+          end
+
+          before do
+            builder.build(person)
+          end
+
+          it "deletes the relation" do
+            expect(person.name).to be_nil
+          end
+        end
       end
     end
   end

data/spec/mongoid/association/referenced/belongs_to/proxy_spec.rb

@@ -127,6 +127,23 @@ describe Mongoid::Association::Referenced::BelongsTo::Proxy do
           it "does not save the target" do
             expect(person).to_not be_persisted
           end
+
+          it "drops private visibility from private methods" do
+            # This is unfortunate but it appears that Ruby does not
+            # have a way to distinguish how method_missing was invoked
+            # (i.e. via an explicit send or method call).
+            # See https://jira.mongodb.org/browse/MONGOID-5009
+            game.person.secret_name.should == 'secret'
+          end
+
+          it "allows private methods to be invoked" do
+            game.person.send(:secret_name).should == 'secret'
+          end
+
+          it "properly exposes delegated methods visibility" do
+            expect(defined?(game.person.id)).to eq("method")
+            expect(defined?(game.person.secret_name)).to be_nil
+          end
         end
 
         context "when the child is not a new record" do
@@ -508,7 +525,7 @@ describe Mongoid::Association::Referenced::BelongsTo::Proxy do
           context "when child is destroyed" do
 
             before do
-              account.delete
+              account.destroy
             end
 
             it "deletes child" do
@@ -548,7 +565,7 @@ describe Mongoid::Association::Referenced::BelongsTo::Proxy do
           context "when child is destroyed" do
 
             before do
-              drug.delete
+              drug.destroy
             end
 
             it "deletes child" do
@@ -600,10 +617,10 @@ describe Mongoid::Association::Referenced::BelongsTo::Proxy do
 
         context "when parent is persisted" do
 
-          context "when child is deleted" do
+          context "when child is destroyed" do
 
             before do
-              account.delete
+              account.destroy
             end
 
             it "deletes child" do
@@ -643,7 +660,7 @@ describe Mongoid::Association::Referenced::BelongsTo::Proxy do
           context "when child is destroyed" do
 
             before do
-              drug.delete
+              drug.destroy
             end
 
             it "deletes child" do
@@ -690,10 +707,10 @@ describe Mongoid::Association::Referenced::BelongsTo::Proxy do
 
         context "when parent is persisted" do
 
-          context "when child is deleted" do
+          context "when child is destroyed" do
 
             before do
-              account.delete
+              account.destroy
             end
 
             it "deletes child" do
@@ -732,7 +749,7 @@ describe Mongoid::Association::Referenced::BelongsTo::Proxy do
           context "when child is destroyed" do
 
             before do
-              drug.delete
+              drug.destroy
             end
 
             it "deletes child" do
@@ -1332,21 +1349,4 @@ describe Mongoid::Association::Referenced::BelongsTo::Proxy do
       end
     end
   end
-
-  describe "#method_missing" do
-      let!(:person) do
-        Person.create
-      end
-
-      let!(:game) do
-        Game.create(person: person)
-      end
-
-    it 'handles keyword args' do
-      expect do
-        game.person.set_personal_data(ssn: '123', age: 25)
-      end.not_to raise_error
-    end
-
-  end
 end

data/spec/mongoid/association/referenced/belongs_to_query_spec.rb

@@ -35,24 +35,4 @@ describe Mongoid::Association::Referenced::BelongsTo do
       expect(school.team).to eq('Bulldogs')
     end
   end
-
-  context 'when projecting with #only while having similar inverse_of candidates' do
-    before do
-      alice = HmmOwner.create!(name: 'Alice')
-      bob = HmmOwner.create!(name: 'Bob')
-
-      HmmPet.create!(name: 'Rex', current_owner: bob, previous_owner: alice)
-    end
-
-    let(:pet) { HmmPet.where(name: 'Rex').only(:name, :previous_owner_id, 'previous_owner.name').first }
-
-    it 'populates specified fields' do
-      expect(pet.name).to eq('Rex')
-      expect(pet.previous_owner.name).to eq('Alice')
-    end
-
-    it 'does not try to load the inverse for an association that explicitly prevents it' do
-      expect { pet.previous_owner.name }.not_to raise_error
-    end
-  end
 end

data/spec/mongoid/association/referenced/has_and_belongs_to_many/binding_spec.rb

@@ -14,7 +14,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Binding do
   end
 
   let(:target) do
-    Mongoid::Association::Referenced::HasMany::Targets::Enumerable.new([ preference ])
+    Mongoid::Association::Referenced::HasMany::Enumerable.new([ preference ])
   end
 
   let(:association) do

data/spec/mongoid/association/referenced/has_many/binding_spec.rb

@@ -14,7 +14,7 @@ describe Mongoid::Association::Referenced::HasMany::Binding do
   end
 
   let(:target) do
-    Mongoid::Association::Referenced::HasMany::Targets::Enumerable.new([ post ])
+    Mongoid::Association::Referenced::HasMany::Enumerable.new([ post ])
   end
 
   let(:association) do

data/spec/mongoid/association/referenced/has_many/enumerable_spec.rb

@@ -3,7 +3,7 @@
 
 require "spec_helper"
 
-describe Mongoid::Association::Referenced::HasMany::Targets::Enumerable do
+describe Mongoid::Association::Referenced::HasMany::Enumerable do
 
   describe "#==" do
 

data/spec/mongoid/association/referenced/has_many_models.rb

@@ -24,23 +24,6 @@ class HmmAddress
   belongs_to :company, class_name: 'HmmCompany'
 end
 
-class HmmOwner
-  include Mongoid::Document
-
-  has_many :pets, class_name: 'HmmPet', inverse_of: :current_owner
-
-  field :name, type: String
-end
-
-class HmmPet
-  include Mongoid::Document
-
-  belongs_to :current_owner, class_name: 'HmmOwner', inverse_of: :pets, optional: true
-  belongs_to :previous_owner, class_name: 'HmmOwner', inverse_of: nil, optional: true
-
-  field :name, type: String
-end
-
 class HmmSchool
   include Mongoid::Document
 

data/spec/mongoid/association/referenced/has_one_models.rb

@@ -19,6 +19,14 @@ class HomAccreditation
 
   field :degree, type: String
   field :year, type: Integer, default: 2012
+
+  def format
+    'fmt'
+  end
+
+  def price
+    42
+  end
 end
 
 class HomAccreditation::Child

data/spec/mongoid/atomic/paths_spec.rb

@@ -113,10 +113,33 @@ describe Mongoid::Atomic::Paths do
         person.addresses << address
       end
 
-      it "returns the association with id.atomic_selector" do
-        expect(address.atomic_selector).to eq(
-          { "_id" => person.id, "addresses._id" => address.id }
-        )
+      context 'when the parent is persisted' do
+
+        let(:person) do
+          Person.create!
+        end
+
+        before do
+          person.should be_persisted
+        end
+
+        it "returns the association with id.atomic_selector" do
+          expect(address.atomic_selector).to eq(
+            { "_id" => person.id, "addresses._id" => address.id }
+          )
+        end
+      end
+
+      context 'when the parent is not persisted' do
+        before do
+          person.should be_new_record
+        end
+
+        it "returns the association with id.atomic_selector" do
+          expect(address.atomic_selector).to eq(
+            { "_id" => person.id, "addresses._id" => address.id }
+          )
+        end
       end
     end
 
@@ -127,14 +150,43 @@ describe Mongoid::Atomic::Paths do
         person.addresses << address
       end
 
-      it "returns the JSON notation to the document with ids" do
-        expect(location.atomic_selector).to eq(
-          {
-            "_id" => person.id,
-            "addresses._id" => address.id,
-            "addresses.locations._id" => location.id
-          }
-        )
+      context 'when the parent is persisted' do
+
+        let(:person) do
+          Person.create!
+        end
+
+        before do
+          person.should be_persisted
+        end
+
+        it "returns the JSON notation to the document with ids" do
+          expect(location.atomic_selector).to eq(
+            {
+              "_id" => person.id,
+              "addresses._id" => address.id,
+              "addresses.0.locations._id" => location.id
+            }
+          )
+        end
+      end
+
+      context 'when the parent is not persisted' do
+        before do
+          person.should be_new_record
+        end
+
+        it "returns the JSON notation to the document with ids" do
+          expect(location.atomic_selector).to eq(
+            {
+              "_id" => person.id,
+              "addresses._id" => address.id,
+              # This condition is technically acceptable for finds
+              # but probably won't work for modifications of 'locations'.
+              "addresses.locations._id" => location.id
+            }
+          )
+        end
       end
     end
   end

data/spec/mongoid/attributes/projector_data/embedded.yml

@@ -0,0 +1,105 @@
+- name: embedded field - inclusion
+  projection:
+    foo.bar: 1
+  
+  queries: &embedded-field-inclusion-expectations
+    # Top-level field is allowed as a container
+    - query: foo
+      allowed: true
+      
+    # Unmentioned field is not allowed
+    - query: bar
+      allowed: false
+      
+    # A peer to the field isn't allowed
+    - query: foo.buck
+      allowed: false
+      
+    # A more nested field is allowed
+    - query: foo.bar.baz
+      allowed: true
+
+- name: embedded field - exclusion
+  projection:
+    foo.bar: 0
+  
+  queries: &embedded-field-exclusion-expectations
+    # Top-level field is allowed
+    - query: foo
+      allowed: true
+    
+    # Unmentioned field is allowed
+    - query: bar
+      allowed: true
+      
+    # A peer to the excluded field is allowed
+    - query: foo.buck
+      allowed: true
+      
+    # A more nested field is not allowed
+    - query: foo.bar.baz
+      allowed: false
+
+- name: parent and child fields - inclusion
+  projection:
+    foo.bar: 1
+    foo.bar.baz: 1
+  
+  queries:
+    # Top-level field is allowed
+    - query: foo
+      allowed: true
+      
+    # Second-level field is allowed
+    - query: foo.bar
+      allowed: true
+    
+    # Third-level field is also allowed
+    - query: foo.bar.baz
+      allowed: true
+    
+    # Fourth-level field is still allowed
+    - query: foo.bar.baz.zzz
+      allowed: true
+    
+    # Unmentioned siblings are not allowed
+    - query: buck
+      allowed: false
+    - query: foo.buck
+      allowed: false
+    
+    # This sibling is under the second-level include and is allowed
+    - query: foo.bar.buck
+      allowed: true
+
+- name: parent and child fields - exclusion
+  projection:
+    foo.bar: 0
+    foo.bar.baz: 0
+  
+  queries:
+    # Top-level field is allowed
+    - query: foo
+      allowed: true
+      
+    # Second-level field is not allowed
+    - query: foo.bar
+      allowed: false
+    
+    # Third-level field is also not allowed
+    - query: foo.bar.baz
+      allowed: false
+    
+    # Fourth-level field is still not allowed
+    - query: foo.bar.baz.zzz
+      allowed: false
+    
+    # Unmentioned siblings are allowed
+    - query: buck
+      allowed: true
+    - query: foo.buck
+      allowed: true
+      
+    # This sibling is under the second-level exclude and is disallowed
+    - query: foo.bar.buck
+      allowed: false

data/spec/mongoid/attributes/projector_data/fields.yml

@@ -0,0 +1,93 @@
+- name: simple inclusion - integer
+  projection:
+    foo: 1
+  
+  queries: &field-inclusion-expectations
+    - query: foo
+      allowed: true
+    - query: bar
+      allowed: false
+
+- name: simple inclusion - boolean
+  projection:
+    foo: true
+  
+  queries: &field-inclusion-expectations
+    - query: foo
+      allowed: true
+    - query: bar
+      allowed: false
+
+- name: positive integer - inclusion
+  projection:
+    foo: 2
+  
+  queries: *field-inclusion-expectations
+
+- name: simple exclusion - integer
+  projection:
+    foo: 0
+  
+  queries: &field-exclusion-expectations
+    - query: foo
+      allowed: false
+    - query: bar
+      allowed: true
+
+- name: simple exclusion - boolean
+  projection:
+    foo: false
+  
+  queries: &field-exclusion-expectations
+    - query: foo
+      allowed: false
+    - query: bar
+      allowed: true
+
+- name: negative integer - exclusion
+  projection:
+    foo: -2
+  
+  queries: *field-exclusion-expectations
+
+- name: field inclusion with _id exclusion
+  projection:
+    foo: 1
+    _id: 0
+  
+  queries: &field-inclusion-with-id-exclusion-expectations
+    - query: foo
+      allowed: true
+      
+    - query: bar
+      allowed: false
+      
+    - query: _id
+      allowed: false
+
+- name: _id exclusion with field inclusion
+  projection:
+    _id: 0
+    foo: 1
+  
+  queries: *field-inclusion-with-id-exclusion-expectations
+
+- name: id inclusion
+  projection:
+    _id: 1
+  
+  queries:
+    - query: _id
+      allowed: true
+    - query: foo
+      allowed: false
+
+- name: id exclusion
+  projection:
+    _id: false
+  
+  queries:
+    - query: _id
+      allowed: false
+    - query: foo
+      allowed: true

data/spec/mongoid/attributes/projector_spec.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require "spec_helper"
+
+describe Mongoid::Attributes::Projector do
+  Dir[File.join(File.dirname(__FILE__), 'projector_data', '*.yml')].sort.each do |path|
+    context File.basename(path) do
+      specs = YAML.load(File.read(path))
+
+      specs.each do |spec|
+        context spec['name'] do
+
+          if spec['pending']
+            pending spec['pending'].to_s
+          end
+
+          let(:projection) do
+            spec['projection']
+          end
+
+          let(:projector) do
+            Mongoid::Attributes::Projector.new(projection)
+          end
+
+          spec.fetch('queries').each do |query_spec|
+            context query_spec.fetch('query').inspect do
+              let(:query) { query_spec['query'] }
+
+              context 'attribute_or_path_allowed?' do
+                it "is #{query_spec.fetch('allowed')}" do
+                  projector.attribute_or_path_allowed?(query).should be query_spec['allowed']
+                end
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end