mongoid 7.2.6 → 7.3.0

data/spec/mongoid/persistable/destroyable_spec.rb

@@ -8,7 +8,7 @@ describe Mongoid::Persistable::Destroyable do
   describe "#destroy" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when destroying a readonly document" do
@@ -24,9 +24,23 @@ describe Mongoid::Persistable::Destroyable do
       end
     end
 
+    context 'when destroying a document that was not saved' do
+      let(:unsaved_person) { Person.new(id: person.id) }
+
+      before do
+        unsaved_person.destroy
+      end
+
+      it 'deletes the matching document from the database' do
+        lambda do
+          person.reload
+        end.should raise_error(Mongoid::Errors::DocumentNotFound)
+      end
+    end
+
     context "when removing a root document" do
 
-      let!(:destroyd) do
+      let!(:destroyed) do
         person.destroy
       end
 
@@ -37,7 +51,7 @@ describe Mongoid::Persistable::Destroyable do
       end
 
       it "returns true" do
-        expect(destroyd).to be true
+        expect(destroyed).to be true
       end
 
       it "resets the flagged for destroy flag" do
@@ -145,6 +159,90 @@ describe Mongoid::Persistable::Destroyable do
         end
       end
     end
+
+    context 'when there are dependent documents' do
+      context 'has_one' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!(bolt: Bolt.create!)
+          end
+
+          it 'destroys dependent documents' do
+            Bolt.count.should == 1
+            parent.destroy
+            Bolt.count.should == 0
+          end
+        end
+
+        context 'dependent: :destroy_all' do
+          let!(:parent) do
+            Hole.create!(threadlocker: Threadlocker.create!)
+          end
+
+          it 'deletes dependent documents' do
+            Threadlocker.count.should == 1
+            parent.destroy
+            Threadlocker.count.should == 0
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!(sealer: Sealer.create!)
+          end
+
+          it 'raises an exception' do
+            Sealer.count.should == 1
+            lambda do
+              parent.destroy
+            end.should raise_error(Mongoid::Errors::DeleteRestriction)
+            Sealer.count.should == 1
+          end
+        end
+      end
+
+      context 'has_many' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!(nuts: [Nut.create!])
+          end
+
+          it 'destroys dependent documents' do
+            Nut.count.should == 1
+            parent.destroy
+            Nut.count.should == 0
+          end
+        end
+
+        context 'dependent: :destroy_all' do
+          let!(:parent) do
+            Hole.create!(washers: [Washer.create!])
+          end
+
+          it 'deletes dependent documents' do
+            Washer.count.should == 1
+            parent.destroy
+            Washer.count.should == 0
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!(spacers: [Spacer.create!])
+          end
+
+          it 'raises an exception' do
+            Spacer.count.should == 1
+            lambda do
+              parent.destroy
+            end.should raise_error(Mongoid::Errors::DeleteRestriction)
+            Spacer.count.should == 1
+          end
+        end
+      end
+    end
   end
 
   describe "#destroy!" do
@@ -264,5 +362,95 @@ describe Mongoid::Persistable::Destroyable do
         end
       end
     end
+
+    context 'when there are dependent documents' do
+      context 'has_one' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!.tap do |hole|
+              Bolt.create!(hole: hole)
+            end
+          end
+
+          it 'destroys dependent documents' do
+            Bolt.count.should == 1
+            Hole.destroy_all
+            Bolt.count.should == 0
+          end
+        end
+
+        context 'dependent: :delete_all' do
+          let!(:parent) do
+            Hole.create!.tap do |hole|
+              Threadlocker.create!(hole: hole)
+            end
+          end
+
+          it 'deletes dependent documents' do
+            Threadlocker.count.should == 1
+            Hole.destroy_all
+            Threadlocker.count.should == 0
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!.tap do |hole|
+              Sealer.create!(hole: hole)
+            end
+          end
+
+          it 'raises an exception' do
+            Sealer.count.should == 1
+            lambda do
+              Hole.destroy_all
+            end.should raise_error(Mongoid::Errors::DeleteRestriction)
+            Sealer.count.should == 1
+          end
+        end
+      end
+
+      context 'has_many' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!(nuts: [Nut.create!])
+          end
+
+          it 'destroys dependent documents' do
+            Nut.count.should == 1
+            Hole.destroy_all
+            Nut.count.should == 0
+          end
+        end
+
+        context 'dependent: :delete_all' do
+          let!(:parent) do
+            Hole.create!(washers: [Washer.create!])
+          end
+
+          it 'deletes dependent documents' do
+            Washer.count.should == 1
+            Hole.destroy_all
+            Washer.count.should == 0
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!(spacers: [Spacer.create!])
+          end
+
+          it 'raises an exception' do
+            Spacer.count.should == 1
+            lambda do
+              Hole.destroy_all
+            end.should raise_error(Mongoid::Errors::DeleteRestriction)
+            Spacer.count.should == 1
+          end
+        end
+      end
+    end
   end
 end

data/spec/mongoid/persistable/savable_spec.rb

@@ -293,6 +293,8 @@ describe Mongoid::Persistable::Savable do
           expect(truck.crates[1].volume).to eq 0.8
           expect(truck.crates[1].toys.size).to eq 0
 
+          # TODO: MONGOID-5026: combine the updates so that there are
+          # no conflicts.
           #expect(truck.atomic_updates[:conflicts]).to eq nil
 
           expect { truck.save! }.not_to raise_error
@@ -360,8 +362,6 @@ describe Mongoid::Persistable::Savable do
 
         context 'when also updating first embedded top level association' do
           it 'performs all writes' do
-            pending 'https://jira.mongodb.org/browse/MONGOID-4982'
-
             truck.crates.first.volume = 2
             truck.crates.first.toys.build(name: 'Bear')
             truck.crates.build
@@ -397,8 +397,6 @@ describe Mongoid::Persistable::Savable do
 
         context 'when embedded association embeds another association' do
           it 'persists the new documents' do
-            pending 'https://jira.mongodb.org/browse/MONGOID-4982'
-
             expect(truck.seats.size).to eq 1
             expect(truck.seats[0].rating).to eq 1
 
@@ -409,7 +407,7 @@ describe Mongoid::Persistable::Savable do
 
             _truck = Truck.find(truck.id)
             expect(_truck.seats.size).to eq 2
-            expect(_truck.seats[0].rating).to eq 1
+            expect(_truck.seats[0].rating).to eq 2
             expect(_truck.seats[0].armrests.length).to eq 1
             expect(_truck.seats[1].rating).to eq 100
           end

data/spec/mongoid/persistable/updatable_spec.rb

@@ -458,7 +458,6 @@ describe Mongoid::Persistable::Updatable do
     describe "##{method}" do
 
       context "when saving with a hash field with invalid keys" do
-        max_server_version '4.9'
 
         let(:person) do
           Person.create
@@ -495,7 +494,6 @@ describe Mongoid::Persistable::Updatable do
       end
 
       context "when the document has been destroyed" do
-        max_server_version '4.9'
 
         let(:person) do
           Person.create

data/spec/mongoid/persistable/upsertable_spec.rb

@@ -32,7 +32,7 @@ describe Mongoid::Persistable::Upsertable do
     context "when the document is new" do
 
       let!(:existing) do
-        Band.create(name: "Photek")
+        Band.create!(name: "Photek")
       end
 
       context "when a matching document exists in the db" do

data/spec/mongoid/persistable_spec.rb

@@ -178,8 +178,8 @@ describe Mongoid::Persistable do
 
         before do
           class Band
-            def my_updates(**args)
-              atomically(**args) do |d|
+            def my_updates(*args)
+              atomically(*args) do |d|
                 d.set(name: "Placebo")
                 d.unset(:origin)
               end

data/spec/mongoid/query_cache_middleware_spec.rb

@@ -58,4 +58,12 @@ describe Mongoid::QueryCache::Middleware do
       end
     end
   end
+
+  context 'when driver implements query cache middleware' do
+    min_driver_version '2.15'
+
+    it 'uses the driver query cache middleware' do
+      Mongoid::QueryCache::Middleware.should be Mongo::QueryCache::Middleware
+    end
+  end
 end

data/spec/mongoid/query_cache_spec.rb

@@ -24,27 +24,10 @@ describe Mongoid::QueryCache do
     SessionRegistry.instance.verify_sessions_ended!
   end
 
-  let(:reset_legacy_qc_warning) do
-    begin
-      Mongoid::QueryCache.remove_instance_variable('@legacy_query_cache_warned')
-    rescue NameError
-      # raised if the instance variable wasn't set
-    end
-  end
-
   describe '#cache' do
     context 'with driver query cache' do
       min_driver_version '2.14'
 
-      it 'does not log a deprecation warning' do
-        reset_legacy_qc_warning
-
-        expect_any_instance_of(Logger).to_not receive(:warn).with(
-          described_class::LEGACY_WARNING
-        )
-        described_class.cache { }
-      end
-
       context 'when query cache is not enabled' do
         before do
           Mongoid::QueryCache.enabled = false
@@ -197,13 +180,6 @@ describe Mongoid::QueryCache do
     context 'with mongoid query cache' do
       max_driver_version '2.13'
 
-      it 'logs a deprecation warning' do
-        reset_legacy_qc_warning
-
-        expect_any_instance_of(Logger).to receive(:warn).with(described_class::LEGACY_WARNING)
-        described_class.cache { }
-      end
-
       context 'when query cache is not enabled' do
         before do
           Mongoid::QueryCache.enabled = false

data/spec/mongoid/reloadable_spec.rb

@@ -110,7 +110,7 @@ describe Mongoid::Reloadable do
 
     context "when document not saved" do
 
-      context "when raising not found error" do
+      context "when there is no document matching our id" do
 
         it "raises an error" do
           expect {
@@ -118,6 +118,23 @@ describe Mongoid::Reloadable do
           }.to raise_error(Mongoid::Errors::DocumentNotFound)
         end
       end
+
+      context 'when there is a document matching our id' do
+
+        let!(:previous) { Agent.create!(title: '007') }
+
+        let(:agent) { Agent.new(id: previous.id) }
+
+        it 'loads the existing document' do
+          agent.title.should be nil
+
+          lambda do
+            agent.reload
+          end.should_not raise_error
+
+          agent.title.should == '007'
+        end
+      end
     end
 
     context "when the document is embedded" do

data/spec/mongoid/shardable_spec.rb

@@ -128,6 +128,50 @@ describe Mongoid::Shardable do
       end
     end
 
+    context 'when record is persisted' do
+      let(:instance) { klass.create(name: value) }
+
+      it { is_expected.to eq({ 'name' => value }) }
+
+      context 'changing shard key value' do
+        let(:new_value) { 'a-new-value' }
+
+        before do
+          instance.name = new_value
+        end
+
+        it 'uses the newly set shard key value' do
+          subject.should == { 'name' => new_value }
+        end
+      end
+    end
+  end
+
+  describe '#shard_key_selector_in_db' do
+    subject { instance.shard_key_selector_in_db }
+    let(:klass) { Band }
+    let(:value) { 'a-brand-name' }
+
+    before { klass.shard_key(:name) }
+
+    context 'when record is new' do
+      let(:instance) { klass.new(name: value) }
+
+      it { is_expected.to eq({ 'name' => value }) }
+
+      context 'changing shard key value' do
+        let(:new_value) { 'a-new-value' }
+
+        before do
+          instance.name = new_value
+        end
+
+        it 'uses the existing shard key value' do
+          subject.should == { 'name' => new_value }
+        end
+      end
+    end
+
     context 'when record is persisted' do
       let(:instance) { klass.create(name: value) }
 

data/spec/mongoid/touchable_spec.rb

@@ -2,6 +2,7 @@
 # encoding: utf-8
 
 require "spec_helper"
+require_relative './touchable_spec_models'
 
 describe Mongoid::Touchable do
 
@@ -9,7 +10,7 @@ describe Mongoid::Touchable do
 
     context "when the document has no associations" do
       let(:updatable) do
-        Updatable.create
+        Updatable.create!
       end
 
       it "responds to #touch" do
@@ -28,30 +29,117 @@ describe Mongoid::Touchable do
       end
     end
 
-    context "when the document is embedded" do
+    context 'when the document has a parent association' do
 
-      before do
-        Label.send(:include, Mongoid::Touchable::InstanceMethods)
+      let(:building) do
+        parent_cls.create!
       end
 
-      let(:band) do
-        Band.create(name: "Placebo")
+      let(:entrance) do
+        building.entrances.create!
       end
 
-      let(:label) do
-        band.create_label(name: "Mute", updated_at: 10.days.ago)
+      let(:floor) do
+        building.floors.create!
       end
 
-      before do
-        label.touch
+      let!(:start_time) { Timecop.freeze(Time.at(Time.now.to_i)) }
+
+      let(:update_time) do
+        Timecop.freeze(Time.at(Time.now.to_i) + 2)
       end
 
-      it "updates the updated_at timestamp" do
-        expect(label.updated_at).to be_within(1).of(Time.now)
+      after do
+        Timecop.return
+      end
+
+      shared_examples 'updates the child' do
+        it "updates the updated_at timestamp" do
+          entrance
+          update_time
+          entrance.touch
+
+          entrance.updated_at.should == update_time
+        end
+
+        it "persists the changes" do
+          entrance
+          update_time
+          entrance.touch
+
+          entrance.reload.updated_at.should == update_time
+        end
       end
 
-      it "persists the changes" do
-        expect(label.reload.updated_at).to be_within(1).of(Time.now)
+      shared_examples 'updates the parent when :touch is true' do
+
+        it 'updates updated_at on parent' do
+          floor
+          update_time
+          floor.touch
+
+          building.updated_at.should == update_time
+        end
+
+        it 'persists updated updated_at on parent' do
+          floor
+          update_time
+          floor.touch
+
+          building.reload.updated_at.should == update_time
+        end
+      end
+
+      shared_examples 'updates the parent when :touch is not set' do
+        it 'does not update updated_at on parent' do
+          entrance
+          update_time
+          entrance.touch
+
+          building.updated_at.should == update_time
+        end
+
+        it 'does not persist updated updated_at on parent' do
+          entrance
+          update_time
+          entrance.touch
+
+          building.reload.updated_at.should == update_time
+        end
+      end
+
+      shared_examples 'does not update the parent when :touch is not set' do
+        it 'does not update updated_at on parent' do
+          entrance
+          update_time
+          entrance.touch
+
+          building.updated_at.should == start_time
+        end
+
+        it 'does not persist updated updated_at on parent' do
+          entrance
+          update_time
+          entrance.touch
+
+          building.reload.updated_at.should == start_time
+        end
+      end
+
+      context "when the document is embedded" do
+        let(:parent_cls) { TouchableSpec::Embedded::Building }
+
+        include_examples 'updates the child'
+        include_examples 'updates the parent when :touch is true'
+        include_examples 'updates the parent when :touch is not set'
+      end
+
+      context "when the document is referenced" do
+        let(:parent_cls) { TouchableSpec::Referenced::Building }
+
+        include_examples 'updates the child'
+        include_examples 'updates the parent when :touch is true'
+        include_examples 'does not update the parent when :touch is not set'
       end
     end
 
@@ -415,11 +503,11 @@ describe Mongoid::Touchable do
       context "when modifying the child" do
 
         let!(:agency) do
-          Agency.create
+          Agency.create!
         end
 
         let!(:agent) do
-          agency.agents.create(number: '1')
+          agency.agents.create!(number: '1')
         end
 
         it "updates the parent's updated at" do

data/spec/mongoid/touchable_spec_models.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+module TouchableSpec
+  module Embedded
+    class Building
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embeds_many :entrances
+      embeds_many :floors
+    end
+
+    class Entrance
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embedded_in :building
+    end
+
+    class Floor
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embedded_in :building, touch: true
+    end
+  end
+
+  module Referenced
+    class Building
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      has_many :entrances, inverse_of: :building
+      has_many :floors, inverse_of: :building
+    end
+
+    class Entrance
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      belongs_to :building
+    end
+
+    class Floor
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      belongs_to :building, touch: true
+    end
+  end
+end

data/spec/mongoid/validatable_spec.rb

@@ -37,7 +37,7 @@ describe Mongoid::Validatable do
       end
 
       let(:documents) do
-        Mongoid::Association::Referenced::HasMany::Targets::Enumerable.new([ address ])
+        Mongoid::Association::Referenced::HasMany::Enumerable.new([ address ])
       end
 
       before do