mongoid 7.0.5 → 8.1.0

data/spec/mongoid/association/eager_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::EagerLoadable do
@@ -207,10 +209,10 @@ describe Mongoid::Association::EagerLoadable do
         end
 
         it 'successfully loads all relations' do
-          user = User.create
-          unit = Unit.create
-          booking = Booking.create(unit: unit)
-          Voucher.create(booking: booking, created_by: user)
+          user = User.create!
+          unit = Unit.create!
+          booking = Booking.create!(unit: unit)
+          Voucher.create!(booking: booking, created_by: user)
 
           vouchers = Voucher.includes(:created_by, booking: [:unit])
 
@@ -242,7 +244,8 @@ describe Mongoid::Association::EagerLoadable do
       end
 
       it "runs the has_one preload" do
-        expect(Mongoid::Association::Referenced::HasOne::Eager).to receive(:new).with([book_association, cat_association], docs).once.and_call_original
+        expect(Mongoid::Association::Referenced::HasOne::Eager).to receive(:new).with([ book_association ], docs).once.and_call_original
+        expect(Mongoid::Association::Referenced::HasOne::Eager).to receive(:new).with([ cat_association ], docs).once.and_call_original
         context.eager_load(docs)
       end
     end

data/spec/mongoid/association/embedded/cyclic_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::Cyclic do
@@ -25,7 +27,7 @@ describe Mongoid::Association::Embedded::Cyclic do
       context "when a query is executed" do
 
         before do
-          document.save
+          document.save!
         end
 
         it "queries the database, not memory" do
@@ -148,7 +150,7 @@ describe Mongoid::Association::Embedded::Cyclic do
     context "when a query is executed" do
 
       before do
-        document.save
+        document.save!
       end
 
       it "queries the database, not memory" do

data/spec/mongoid/association/embedded/dirty_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe "when initialize a model with an embedded model" do
@@ -18,7 +20,7 @@ end
 describe "when creating a model with an embedded model" do
 
   let(:person) do
-    Person.create(pet: Pet.new)
+    Person.create!(pet: Pet.new)
   end
 
   it "does not have changes in the embedded model" do
@@ -33,7 +35,7 @@ end
 describe "when embedding a model on an already saved model" do
 
   let(:person) do
-    Person.create
+    Person.create!
   end
 
   before do

data/spec/mongoid/association/embedded/embedded_in/binding_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbeddedIn::Binding do
@@ -56,7 +58,8 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Binding do
         end
 
         it "does nothing" do
-          expect(name).to receive(:namable=).never
+          expect(name).to receive(:namable=).with(person).never
+          expect(name).to receive(:namable=).with(nil).once
           binding.bind_one
         end
       end

data/spec/mongoid/association/embedded/embedded_in/buildable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbeddedIn::Buildable do
@@ -31,4 +33,58 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Buildable do
       end
     end
   end
+
+  context 'when the object is already associated with another object' do
+
+    context "when inverse is embeds_many" do
+
+      let(:appointment1) do
+        Appointment.new
+      end
+
+      let(:appointment2) do
+        Appointment.new
+      end
+
+      let(:person) do
+        Person.create!
+      end
+
+      before do
+        appointment1.person = person
+        appointment2.person = person
+      end
+
+      it 'does not clear the object of its previous association' do
+        expect(appointment1.person).to eq(person)
+        expect(appointment2.person).to eq(person)
+        expect(person.appointments).to eq([appointment1, appointment2])
+      end
+    end
+
+    context "when inverse is embeds_one" do
+
+      let(:scribe1) do
+        Scribe.new
+      end
+
+      let(:scribe2) do
+        Scribe.new
+      end
+
+      let(:owner) do
+        Owner.create!
+      end
+
+      before do
+        scribe1.owner = owner
+        scribe2.owner = owner
+      end
+
+      it 'clears the object of its previous association' do
+        expect(scribe1.owner).to be_nil
+        expect(scribe2.owner).to eq(owner)
+      end
+    end
+  end
 end

data/spec/mongoid/association/embedded/embedded_in/proxy_spec.rb

@@ -1,4 +1,7 @@
+# frozen_string_literal: true
+
 require "spec_helper"
+require_relative '../embeds_many_models'
 
 describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
 
@@ -76,7 +79,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
       context "when the parent is not a new record" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:name) do
@@ -221,7 +224,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
       context "when the documents are not new records" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:name) do
@@ -291,7 +294,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
       context "when the documents are not new records" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:address) do
@@ -319,7 +322,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
       context "when a child already exists on the parent" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:address_one) do
@@ -389,19 +392,19 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
   context "when creating the tree through initialization" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:address) do
-      Address.create(addressable: person)
+      Address.create!(addressable: person)
     end
 
     let!(:first_location) do
-      Location.create(address: address)
+      Location.create!(address: address)
     end
 
     let!(:second_location) do
-      Location.create(address: address)
+      Location.create!(address: address)
     end
 
     it "saves the child" do
@@ -430,7 +433,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
   context "when instantiating a new child with a persisted parent" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:address) do
@@ -453,15 +456,15 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
   context "when replacing the relation with another" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:person_two) do
-      Person.create
+      Person.create!
     end
 
     let!(:address) do
-      person.addresses.create(street: "Kotbusser Damm")
+      person.addresses.create!(street: "Kotbusser Damm")
     end
 
     let!(:name) do
@@ -470,7 +473,7 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
 
     before do
       name.namable = address.addressable
-      name.namable.save
+      name.namable.save!
     end
 
     it "sets the new parent" do
@@ -504,4 +507,140 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do
       end
     end
   end
+
+  context "when the same class is embedded multiple times; embeds_one" do
+
+    let(:customer) do
+      Customer.new
+    end
+
+    context "assignment after saving" do
+
+      it "correctly sets the association for the embedded class" do
+
+        customer.home_address = CustomerAddress.new
+        customer.work_address = CustomerAddress.new
+
+        expect(customer.home_address._association.store_as).to eq("home_address")
+        expect(customer.work_address._association.store_as).to eq("work_address")
+
+        expect(customer.home_address.instance_eval { _association.store_as }).to eq("home_address")
+        expect(customer.work_address.instance_eval { _association.store_as }).to eq("work_address")
+
+        customer.save!
+
+        customer.home_address = CustomerAddress.new
+        customer.work_address = CustomerAddress.new
+
+        expect(customer.home_address._association.store_as).to eq("home_address")
+        expect(customer.work_address._association.store_as).to eq("work_address")
+
+        expect(customer.home_address.instance_eval { _association.store_as }).to eq("home_address")
+        expect(customer.work_address.instance_eval { _association.store_as }).to eq("work_address")
+
+        expect(customer.home_address.addressable).to eq(customer)
+        expect(customer.work_address.addressable).to eq(customer)
+      end
+    end
+
+    context "inverse assignment" do
+
+      it "raises an error when trying to set the association" do
+        customer.work_address = CustomerAddress.new
+
+        expect do
+          customer.work_address.addressable = customer
+        end.to raise_error(Mongoid::Errors::InvalidSetPolymorphicRelation)
+      end
+    end
+
+    context "when there is an explicit inverse_of" do
+
+      let(:customer) { EmmCustomer.new }
+
+      it "correctly sets the association for the embedded class" do
+        customer.work_address = EmmCustomerAddress.new
+
+        expect do
+          customer.work_address.addressable = customer
+        end.to_not raise_error
+
+        expect(customer.work_address.addressable).to eq(customer)
+      end
+    end
+  end
+
+  context "when the same class is embedded multiple times; embeds_many" do
+
+    let(:customer) do
+      EmmCustomer.new
+    end
+
+    context "assignment after saving" do
+
+      it "correctly sets the association for the embedded class" do
+
+        customer.close_friends = [EmmFriend.new]
+        customer.acquaintances = [EmmFriend.new]
+
+        expect(customer.close_friends._association.store_as).to eq("close_friends")
+        expect(customer.acquaintances._association.store_as).to eq("acquaintances")
+
+        expect(customer.close_friends[0].instance_eval { _association.store_as }).to eq("close_friends")
+        expect(customer.acquaintances[0].instance_eval { _association.store_as }).to eq("acquaintances")
+
+        customer.save!
+
+        customer.close_friends = [EmmFriend.new]
+        customer.acquaintances = [EmmFriend.new]
+
+        expect(customer.close_friends._association.store_as).to eq("close_friends")
+        expect(customer.acquaintances._association.store_as).to eq("acquaintances")
+
+        expect(customer.close_friends[0].instance_eval { _association.store_as }).to eq("close_friends")
+        expect(customer.acquaintances[0].instance_eval { _association.store_as }).to eq("acquaintances")
+
+        expect(customer.close_friends[0].befriendable).to eq(customer)
+        expect(customer.acquaintances[0].befriendable).to eq(customer)
+      end
+    end
+
+    context "inverse assignment" do
+
+      it "raises an error when trying to set the association" do
+        customer.acquaintances = [EmmFriend.new]
+
+        expect do
+          customer.acquaintances[0].befriendable = customer
+        end.to raise_error(Mongoid::Errors::InvalidSetPolymorphicRelation)
+      end
+    end
+  end
+
+  context "when assigning a hash" do
+    let(:building_address) { BuildingAddress.new }
+
+    before do
+      building_address.building = { name: "Chrysler" }
+    end
+
+    it "creates the objects correctly" do
+      expect(building_address.building).to be_a(Building)
+      expect(building_address.building.name).to eq("Chrysler")
+    end
+  end
+
+  context "when replacing an association with a hash" do
+    let(:building_address) { BuildingAddress.new }
+
+    before do
+      building_address.building = { name: "Chrysler" }
+      building_address.building = { name: "Empire State" }
+    end
+
+    it "creates the objects correctly" do
+      expect(building_address.building).to be_a(Building)
+      expect(building_address.building.name).to eq("Empire State")
+    end
+  end
 end

data/spec/mongoid/association/embedded/embedded_in_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 require_relative './embeds_one_models'
 
@@ -898,4 +900,4 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
       expect(association.create_relation(owner, target)).to be_a(EmbeddedObject)
     end
   end
-end
+end

data/spec/mongoid/association/embedded/embeds_many/binding_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbedsMany::Binding do

data/spec/mongoid/association/embedded/embeds_many/buildable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbedsMany::Buildable do
@@ -101,4 +103,116 @@ describe Mongoid::Association::Embedded::EmbedsMany::Buildable do
       end
     end
   end
+
+  context 'when the object is already associated with another object' do
+
+    context "when using <<" do
+
+      let(:person1) do
+        Person.new
+      end
+
+      let(:person2) do
+        Person.new
+      end
+
+      let(:appointment) do
+        Appointment.new
+      end
+
+      before do
+        person1.appointments << appointment
+        person2.appointments << appointment
+      end
+
+      it 'clears the object of its previous association' do
+        expect(person1.appointments).to eq([])
+        expect(person2.appointments).to eq([appointment])
+      end
+    end
+
+    context "when using concat" do
+
+      let(:person1) do
+        Person.new
+      end
+
+      let(:person2) do
+        Person.new
+      end
+
+      let(:appointment) do
+        Appointment.new
+      end
+
+      before do
+        person1.appointments.concat([appointment])
+        person2.appointments.concat([appointment])
+      end
+
+      it 'clears the object of its previous association' do
+        expect(person1.appointments).to eq([])
+        expect(person2.appointments).to eq([appointment])
+      end
+    end
+
+    context "when using =" do
+
+      let(:person1) do
+        Person.new
+      end
+
+      let(:person2) do
+        Person.new
+      end
+
+      let(:appointment) do
+        Appointment.new
+      end
+
+      let(:apts) { [ appointment ] }
+
+      before do
+        person1.appointments = apts
+        person2.appointments = apts
+        expect(apts).to eq([ appointment ])
+      end
+
+      it 'clears the object of its previous association' do
+        expect(person1.appointments).to eq([])
+        expect(person2.appointments).to eq([appointment])
+      end
+    end
+
+    context "when using = on the same document twice" do
+
+      let(:person1) do
+        Person.new
+      end
+
+      let(:person2) do
+        Person.new
+      end
+
+      let(:appointment1) do
+        Appointment.new
+      end
+
+      let(:appointment2) do
+        Appointment.new
+      end
+
+      let(:apts) { [ appointment1, appointment2 ] }
+
+      before do
+        person1.appointments = apts
+        person1.appointments = person1.appointments.reverse
+        expect(apts).to eq([ appointment1, appointment2  ])
+      end
+
+      it 'clears the object of its previous association' do
+        expect(person1.appointments).to eq([ appointment2, appointment1 ])
+      end
+    end
+  end
 end