mongoid 7.0.5 → 8.1.0

data/spec/mongoid/persistable/updatable_spec.rb

@@ -1,13 +1,18 @@
+# frozen_string_literal: true
+
 require "spec_helper"
+require "support/immutable_ids"
 
 describe Mongoid::Persistable::Updatable do
+  extend Mongoid::ImmutableIds
+  immutable_id_examples_as "persisted _ids are immutable"
 
   describe "#update_attribute" do
 
     context "when the field is aliased" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when the setter is overridden" do
@@ -67,7 +72,7 @@ describe Mongoid::Persistable::Updatable do
     context "when setting an array field" do
 
       let(:person) do
-        Person.create(aliases: [])
+        Person.create!(aliases: [])
       end
 
       before do
@@ -115,7 +120,7 @@ describe Mongoid::Persistable::Updatable do
     context "when dynamic attributes are not enabled" do
 
       it "raises exception for an unknown attribute " do
-        account = Account.create
+        account = Account.create!(name: 'Foobar')
 
         expect {
           account.update_attribute(:somethingnew, "somethingnew")
@@ -123,7 +128,7 @@ describe Mongoid::Persistable::Updatable do
       end
 
       it "will update value of aliased field" do
-        person = Person.create
+        person = Person.create!
         person.update_attribute(:t, "test_value")
         expect(person.reload.t).to eq "test_value"
         expect(person.test).to eq "test_value"
@@ -229,21 +234,17 @@ describe Mongoid::Persistable::Updatable do
     end
 
     context "when persisting a localized field" do
+      with_default_i18n_configs
 
       let!(:product) do
-        Product.create(description: "The bomb")
+        Product.create!(description: "The bomb")
       end
 
       before do
-        I18n.enforce_available_locales = false
         ::I18n.locale = :de
         product.update_attribute(:description, "Die Bombe")
       end
 
-      after do
-        ::I18n.locale = :en
-      end
-
       let(:attributes) do
         product.attributes["description"]
       end
@@ -260,15 +261,15 @@ describe Mongoid::Persistable::Updatable do
     context "when updating a deeply embedded document" do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:address) do
-        person.addresses.create(street: "Winterfeldtstr")
+        person.addresses.create!(street: "Winterfeldtstr")
       end
 
       let!(:location) do
-        address.locations.create(name: "work")
+        address.locations.create!(name: "work")
       end
 
       let(:from_db) do
@@ -299,7 +300,7 @@ describe Mongoid::Persistable::Updatable do
       end
 
       let(:person) do
-        Person.create(species: :human)
+        Person.create!(species: :human)
       end
 
       it 'raises an error when trying to set the attribute' do
@@ -344,7 +345,7 @@ describe Mongoid::Persistable::Updatable do
     context 'when the field is loaded explicitly' do
 
       before do
-        Person.create(title: 'Captain')
+        Person.create!(title: 'Captain')
       end
 
       context 'when the loaded attribute is updated' do
@@ -398,7 +399,7 @@ describe Mongoid::Persistable::Updatable do
     context 'when fields are explicitly not loaded' do
 
       before do
-        Person.create(title: 'Captain')
+        Person.create!(title: 'Captain')
       end
 
       context 'when the loaded attribute is updated' do
@@ -448,6 +449,14 @@ describe Mongoid::Persistable::Updatable do
         end
       end
     end
+
+    context 'when the field is _id' do
+      def invoke_operation!
+        object.update_attribute "_id", new_id_value
+      end
+
+      it_behaves_like "persisted _ids are immutable"
+    end
   end
 
   [:update_attributes, :update].each do |method|
@@ -455,45 +464,24 @@ describe Mongoid::Persistable::Updatable do
     describe "##{method}" do
 
       context "when saving with a hash field with invalid keys" do
+        max_server_version '4.9'
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         it "raises an error" do
           expect {
-            person.update_attributes(map: { "$bad.key" => "value" })
+            person.update_attributes!(map: { "$bad.key" => "value" })
           }.to raise_error(Mongo::Error::OperationFailure)
         end
       end
 
-      context "when validation passes" do
-
-        let(:person) do
-          Person.create
-        end
-
-        let!(:saved) do
-          person.update_attributes(pets: false)
-        end
-
-        let(:from_db) do
-          Person.find(person.id)
-        end
-
-        it "returns true" do
-          expect(saved).to be true
-        end
-
-        it "saves the attributes" do
-          expect(from_db.pets).to be false
-        end
-      end
-
       context "when the document has been destroyed" do
+        max_server_version '4.9'
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         it "raises an error" do
@@ -506,7 +494,7 @@ describe Mongoid::Persistable::Updatable do
       context "when validation passes" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:saved) do
@@ -529,7 +517,7 @@ describe Mongoid::Persistable::Updatable do
       context "when the document has been destroyed" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         before do
@@ -550,7 +538,7 @@ describe Mongoid::Persistable::Updatable do
         end
 
         let(:game) do
-          Game.create(person: person)
+          Game.create!(person: person)
         end
 
         before do
@@ -587,7 +575,7 @@ describe Mongoid::Persistable::Updatable do
         context "when providing an embedded child" do
 
           let!(:person) do
-            Person.create
+            Person.create!
           end
 
           let!(:name) do
@@ -614,11 +602,11 @@ describe Mongoid::Persistable::Updatable do
         context "when providing a parent to a referenced in" do
 
           let!(:person) do
-            Person.create
+            Person.create!
           end
 
           let!(:post) do
-            Post.create(title: "Testing")
+            Post.create!(title: "Testing")
           end
 
           context "when the relation has not yet been touched" do
@@ -679,7 +667,7 @@ describe Mongoid::Persistable::Updatable do
         before do
           phone_number.country_code = country_code
           person.phone_numbers << phone_number
-          person.save
+          person.save!
         end
 
         it "sets the first level document" do
@@ -717,6 +705,14 @@ describe Mongoid::Persistable::Updatable do
           end
         end
       end
+
+      context 'when the _id is one of the fields' do
+        def invoke_operation!
+          object.update_attributes _id: new_id_value
+        end
+  
+        it_behaves_like "persisted _ids are immutable"
+      end
     end
   end
 
@@ -735,4 +731,22 @@ describe Mongoid::Persistable::Updatable do
       end
     end
   end
+
+  describe "#update_attributes!" do
+
+    let(:person) do
+      Person.create!
+    end
+
+    let(:attributes) do
+      { security_code: 'secret' }
+    end
+
+    it 'calls update_attributes' do
+      person.should receive(:update_attributes).with(attributes).and_call_original
+      lambda do
+        person.update_attributes!(attributes)
+      end.should_not raise_error
+    end
+  end
 end

data/spec/mongoid/persistable/upsertable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Persistable::Upsertable do
@@ -29,7 +31,7 @@ describe Mongoid::Persistable::Upsertable do
     context "when the document is new" do
 
       let!(:existing) do
-        Band.create(name: "Photek")
+        Band.create!(name: "Photek")
       end
 
       context "when a matching document exists in the db" do
@@ -40,8 +42,10 @@ describe Mongoid::Persistable::Upsertable do
           end
         end
 
+        let(:options) { {} }
+
         before do
-          updated.upsert
+          updated.upsert(options)
         end
 
         it "updates the existing document" do
@@ -51,6 +55,47 @@ describe Mongoid::Persistable::Upsertable do
         it "flags the document as persisted" do
           expect(existing).to be_persisted
         end
+
+        shared_examples "replaces the existing fields" do
+          it 'replaces the existing fields' do
+            Band.count.should == 1
+
+            existing.reload
+            existing.views.should be nil
+            existing.name.should == 'Tool'
+          end
+        end
+
+        shared_examples "retains the existing fields" do
+          it 'retains the existing fields' do
+            Band.count.should == 1
+
+            existing.reload
+            existing.views.should eq(42)
+            existing.name.should == 'Tool'
+          end
+        end
+
+        context 'when existing document contains other fields' do
+          let!(:existing) do
+            Band.create!(name: "Photek", views: 42)
+          end
+
+          context "when not passing any options" do
+            let(:options) { {} }
+            it_behaves_like "replaces the existing fields"
+          end
+
+          context "when passing replace: false" do
+            let(:options) { { replace: false } }
+            it_behaves_like "retains the existing fields"
+          end
+
+          context "when passing replace: true" do
+            let(:options) { { replace: true } }
+            it_behaves_like "replaces the existing fields"
+          end
+        end
       end
 
       context "when no matching document exists in the db" do
@@ -80,7 +125,7 @@ describe Mongoid::Persistable::Upsertable do
     context "when the document is not new" do
 
       let!(:existing) do
-        Band.create(name: "Photek")
+        Band.create!(name: "Photek")
       end
 
       context "when updating fields outside of the id" do
@@ -102,5 +147,50 @@ describe Mongoid::Persistable::Upsertable do
         end
       end
     end
+
+    context "when the document is readonly" do
+
+      context "when legacy_readonly is true" do
+        config_override :legacy_readonly, true
+
+        let!(:existing) do
+          Band.create!(name: "Photek")
+        end
+
+        before do
+          existing.name = "Depeche Mode"
+        end
+
+        let!(:upsert) do
+          existing.upsert
+        end
+
+        it "updates the existing document" do
+          expect(existing.reload.name).to eq("Depeche Mode")
+        end
+
+        it "returns true" do
+          expect(upsert).to be true
+        end
+      end
+
+      context "when legacy_readonly is false" do
+        config_override :legacy_readonly, false
+
+        let!(:existing) do
+          Band.create!(name: "Photek").tap(&:readonly!)
+        end
+
+        before do
+          existing.name = "Depeche Mode"
+        end
+
+        it 'raises a ReadonlyDocument error' do
+          expect do
+            existing.upsert
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
+    end
   end
 end

data/spec/mongoid/persistable_spec.rb

@@ -1,11 +1,15 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Persistable do
 
+  class PersistableSpecTestException < StandardError; end
+
   describe "#atomically" do
 
     let(:document) do
-      Band.create(member_count: 0, likes: 60, origin: "London")
+      Band.create!(member_count: 0, likes: 60, origin: "London")
     end
 
     context "when providing a block" do
@@ -173,8 +177,8 @@ describe Mongoid::Persistable do
 
         before do
           class Band
-            def my_updates
-              atomically do |d|
+            def my_updates(**args)
+              atomically(**args) do |d|
                 d.set(name: "Placebo")
                 d.unset(:origin)
               end
@@ -182,15 +186,87 @@ describe Mongoid::Persistable do
           end
         end
 
-        let!(:update) do
-          document.atomically do |doc|
-            doc.inc(member_count: 10)
-            doc.bit(likes: { and: 13 })
-            doc.my_updates
+        context "when given join_context: false" do
+
+          let(:run_update) do
+            document.atomically do |doc|
+              doc.set origin: "Paris"
+              doc.atomically(join_context: false) do |doc2|
+                doc2.inc(member_count: 10)
+              end
+              doc.inc likes: 1
+              raise PersistableSpecTestException, "oops"
+            end
+          end
+
+          it_behaves_like "an atomically updatable root document" do
+            let!(:update) do
+              document.atomically do |doc|
+                doc.inc(member_count: 10)
+                doc.my_updates join_context: false
+                doc.bit(likes: { and: 13 })
+              end
+            end
+          end
+
+          it "independently persists the non-joining block's operations" do
+            begin run_update; rescue PersistableSpecTestException; end
+
+            document.reload
+
+            expect(document.origin).to eq "London"
+            expect(document.likes).to eq 60
+            expect(document.member_count).to eq 10
+          end
+
+          it "resets in-memory changes that did not successfully persist" do
+            begin run_update; rescue PersistableSpecTestException; end
+
+            expect(document.origin).to eq "London"
+            expect(document.likes).to eq 60
+            expect(document.member_count).to eq 10
           end
         end
 
-        it_behaves_like "an atomically updatable root document"
+        context "when given join_context: true" do
+
+          let(:run_update) do
+            document.atomically do |doc|
+              doc.inc(member_count: 10)
+              doc.my_updates join_context: true
+              doc.bit(likes: { and: 13 })
+            end
+          end
+
+          it_behaves_like "an atomically updatable root document" do
+            let!(:update) { run_update }
+          end
+
+          it "performs an update_one exactly once" do
+            expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).exactly(:once).and_call_original
+            run_update
+          end
+
+          it "resets in-memory changes that did not successfully persist" do
+            begin
+              document.atomically do |doc|
+                doc.set origin: "Paris"
+                doc.atomically(join_context: true) do |doc2|
+                  doc2.inc(member_count: 10)
+                end
+                doc.atomically(join_context: true) do |doc3|
+                  doc.inc likes: 1
+                end
+                raise PersistableSpecTestException, "oops"
+              end
+            rescue PersistableSpecTestException
+            end
+
+            expect(document.origin).to eq "London"
+            expect(document.likes).to eq 60
+            expect(document.member_count).to eq 0
+          end
+        end
       end
     end