mongoid 7.0.0 → 7.4.0

data/spec/mongoid/attributes_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Attributes do
@@ -18,7 +20,7 @@ describe Mongoid::Attributes do
     context "when the attribute was excluded in a criteria" do
 
       let!(:person) do
-        Person.create(title: "sir")
+        Person.create!(title: "sir")
       end
 
       context "when the attribute is localized" do
@@ -53,7 +55,7 @@ describe Mongoid::Attributes do
               let!(:agent) do
                 agent = Agent.new(:title => title)
                 agent.build_address(:city => city)
-                agent.save()
+                agent.save!()
                 agent
               end
               let(:from_db) do
@@ -93,6 +95,49 @@ describe Mongoid::Attributes do
             it "does not raise an error" do
               expect(from_db.map).to eq(map)
             end
+
+            context 'when only one of the hash fields is projected' do
+
+              let(:map) do
+                { 'dates' => { 'y' => { '2016' => 'Berlin', '2017' => 'Munich' } } }
+              end
+
+              let(:expected) do
+                { 'dates' => { 'y' => {
+                  '2016' => 'Berlin',
+                } } }
+              end
+
+              it 'retrieves only the projected fields' do
+                expect(from_db.map).to eq(expected)
+              end
+            end
+
+            context 'when several of the hash fields is projected' do
+
+              let(:map) do
+                { 'dates' => { 'y' => {
+                  '2016' => 'Berlin',
+                  '2017' => 'Munich',
+                  '2018' => 'Krakow',
+                } } }
+              end
+
+              let(:expected) do
+                { 'dates' => { 'y' => {
+                  '2016' => 'Berlin',
+                  '2018' => 'Krakow',
+                } } }
+              end
+
+              let(:from_db) do
+                Person.only('map.dates.y.2016', 'map.dates.y.2018').first
+              end
+
+              it 'retrieves only the projected fields' do
+                expect(from_db.map).to eq(expected)
+              end
+            end
           end
         end
 
@@ -153,7 +198,7 @@ describe Mongoid::Attributes do
     context 'when the document has a custom attribute type' do
 
       let(:bar) do
-        Bar.create(lat_lng: LatLng.new(52.30, 13.25))
+        Bar.create!(lat_lng: LatLng.new(52.30, 13.25))
       end
 
       it 'returns the demongoized version of the attribute' do
@@ -210,7 +255,7 @@ describe Mongoid::Attributes do
     context "when the document is an existing record" do
 
       let!(:person) do
-        Person.create(title: "sir")
+        Person.create!(title: "sir")
       end
 
       context "when the attribute was excluded in a criteria" do
@@ -242,6 +287,91 @@ describe Mongoid::Attributes do
         end
       end
 
+      context "when the field was not explicitly defined" do
+
+        context "when excluding with only and the field was not excluded" do
+
+          let(:from_db) do
+            Person.only(:_id).first
+          end
+
+          it "raises an error" do
+            expect {
+              from_db[:undefined_field]
+            }.to raise_error(ActiveModel::MissingAttributeError)
+          end
+        end
+
+        context "when excluding with without and the field was excluded" do
+
+          let(:from_db) do
+            Person.without(:title).first
+          end
+
+          it "raises an error" do
+            expect {
+              from_db[:title]
+            }.to raise_error(ActiveModel::MissingAttributeError)
+          end
+        end
+
+        context "when excluding with without and the field was not excluded" do
+
+          let(:from_db) do
+            Person.without(:title).first
+          end
+
+          it "returns nil" do
+            from_db[:undefined_field].should be nil
+          end
+        end
+      end
+
+      context 'when projecting with #only' do
+        let!(:person) do
+          Person.create!(title: 'sir', name: { first_name: 'Jose', language: { name: 'es' } })
+        end
+
+        context 'when projecting an embedded association' do
+          let(:from_db) do
+            Person.only(:name).first
+          end
+
+          context 'when retrieving a field of the association using the dot notation' do
+
+            it 'retrieves the field' do
+              expect(from_db['name.first_name']).to eq 'Jose'
+            end
+          end
+
+          context 'when retrieving a field of a nested association using the dot notation' do
+            it 'retrieves the field' do
+              expect(from_db['name.language.name']).to eq 'es'
+            end
+          end
+        end
+
+        context 'when projecting a sub-association of an embedded association' do
+          let(:from_db) do
+            Person.only('name.language').first
+          end
+
+          context 'when retrieving a field under the projected sub-association' do
+            it 'retrieves the field' do
+              expect(from_db['name.language.name']).to eq 'es'
+            end
+          end
+
+          context 'when retrieving a non-projected field' do
+            it 'raises MissingAttributeError' do
+              expect do
+                from_db['name.first_name']
+              end.to raise_error(ActiveModel::MissingAttributeError)
+            end
+          end
+        end
+      end
+
       context "when the attribute does not exist" do
 
         before do
@@ -284,7 +414,7 @@ describe Mongoid::Attributes do
       let(:bar) do
         Bar.new.tap do |b|
           b[:lat_lng] = LatLng.new(52.30, 13.25)
-          b.save
+          b.save!
         end
       end
 
@@ -326,6 +456,67 @@ describe Mongoid::Attributes do
         expect(terms).to eq(true)
       end
     end
+
+    context 'when the field is not explicitly defined' do
+      let(:bar) { Bar.new }
+
+      before do
+        bar['missing_field'] = 42
+      end
+
+      it 'writes the value into attributes' do
+        bar.attributes.should == {'_id' => bar.id, 'missing_field' => 42}
+      end
+
+      it 'makes the attribute accessible via []' do
+        bar['missing_field'].should == 42
+      end
+
+      context 'when writing fields on a document with projection' do
+
+        let!(:person) do
+          Person.create!(title: "sir")
+        end
+
+        context "when excluding with only and the field was not excluded" do
+
+          let(:from_db) do
+            Person.only(:_id).first
+          end
+
+          it "raises an error" do
+            expect {
+              from_db[:undefined_field] = 'x'
+            }.to raise_error(ActiveModel::MissingAttributeError)
+          end
+        end
+
+        context "when excluding with without and the field was excluded" do
+
+          let(:from_db) do
+            Person.without(:title).first
+          end
+
+          it "raises an error" do
+            expect {
+              from_db[:title] = 'x'
+            }.to raise_error(ActiveModel::MissingAttributeError)
+          end
+        end
+
+        context "when excluding with without and the field was not excluded" do
+
+          let(:from_db) do
+            Person.without(:title).first
+          end
+
+          it "writes the value" do
+            from_db[:undefined_field] = 'x'
+            from_db[:undefined_field].should == 'x'
+          end
+        end
+      end
+    end
   end
 
   describe "#_id" do
@@ -796,7 +987,7 @@ describe Mongoid::Attributes do
     context 'when the document has a custom attribute type' do
 
       let(:bar) do
-        Bar.create(lat_lng: LatLng.new(52.30, 13.25))
+        Bar.create!(lat_lng: LatLng.new(52.30, 13.25))
       end
 
       it 'returns the demongoized version of the attribute' do
@@ -834,7 +1025,7 @@ describe Mongoid::Attributes do
     context "when the document is an existing record" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when the attribute does not exist" do
@@ -873,7 +1064,7 @@ describe Mongoid::Attributes do
   describe "#read_attribute_before_type_cast" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when the attribute has not yet been assigned" do
@@ -890,6 +1081,50 @@ describe Mongoid::Attributes do
         expect(person.age_before_type_cast).to eq("old")
       end
     end
+
+    context 'when reading fields on a document with projection' do
+
+      let!(:person) do
+        Person.create!(title: "sir")
+      end
+
+      context "when excluding with only and the field was not excluded" do
+
+        let(:from_db) do
+          Person.only(:_id).first
+        end
+
+        it "raises an error" do
+          expect {
+            from_db.read_attribute(:undefined_field)
+          }.to raise_error(ActiveModel::MissingAttributeError)
+        end
+      end
+
+      context "when excluding with without and the field was excluded" do
+
+        let(:from_db) do
+          Person.without(:title).first
+        end
+
+        it "raises an error" do
+          expect {
+            from_db.read_attribute(:title)
+          }.to raise_error(ActiveModel::MissingAttributeError)
+        end
+      end
+
+      context "when excluding with without and the field was not excluded" do
+
+        let(:from_db) do
+          Person.without(:title).first
+        end
+
+        it "returns nil" do
+          from_db.read_attribute(:undefined_field).should be nil
+        end
+      end
+    end
   end
 
   describe "#attribute_present?" do
@@ -921,7 +1156,7 @@ describe Mongoid::Attributes do
     context "when the document is an existing record" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when the attribute does not exist" do
@@ -980,7 +1215,7 @@ describe Mongoid::Attributes do
 
     context "when the attribute is not on only list" do
 
-      before { Person.create }
+      before { Person.create! }
       let(:person) do
         Person.only(:id).first
       end
@@ -1049,7 +1284,7 @@ describe Mongoid::Attributes do
     context "when the attribute exists" do
 
       let(:person) do
-        Person.create(title: "Sir")
+        Person.create!(title: "Sir")
       end
 
       before do
@@ -1067,7 +1302,7 @@ describe Mongoid::Attributes do
       context "when saving after the removal" do
 
         before do
-          person.save
+          person.save!
         end
 
         it "persists the removal" do
@@ -1087,7 +1322,7 @@ describe Mongoid::Attributes do
      end
 
      before do
-       person.save
+       person.save!
        person.pet.remove_attribute(:name)
      end
 
@@ -1102,7 +1337,7 @@ describe Mongoid::Attributes do
      context "when saving after the removal" do
 
        before do
-         person.save
+         person.save!
        end
 
        it "persists the removal" do
@@ -1147,7 +1382,7 @@ describe Mongoid::Attributes do
       context 'when the database name is used' do
 
         let(:person) do
-          Person.create(at: Time.now)
+          Person.create!(at: Time.now)
         end
 
         before do
@@ -1165,7 +1400,7 @@ describe Mongoid::Attributes do
         context "when saving after the removal" do
 
           before do
-            person.save
+            person.save!
           end
 
           it "persists the removal" do
@@ -1177,7 +1412,7 @@ describe Mongoid::Attributes do
       context 'when the alias is used' do
 
         let(:person) do
-          Person.create(aliased_timestamp: Time.now)
+          Person.create!(aliased_timestamp: Time.now)
         end
 
         before do
@@ -1195,7 +1430,7 @@ describe Mongoid::Attributes do
         context "when saving after the removal" do
 
           before do
-            person.save
+            person.save!
           end
 
           it "persists the removal" do
@@ -1338,7 +1573,7 @@ describe Mongoid::Attributes do
         person.write_attribute(:test, "aliased field to test")
       end
 
-      it "allows the field name to be udpated" do
+      it "allows the field name to be updated" do
         expect(person.t).to eq("aliased field to test")
       end
     end
@@ -1346,10 +1581,16 @@ describe Mongoid::Attributes do
     context "when attribute is a Hash" do
       let(:person) { Person.new map: { somekey: "somevalue" } }
 
-      it "raises an error when try to set an invalid value" do
-        expect {
+      it "raises an error when trying to set a value of invalid type - array" do
+        expect do
           person.map = []
-        }.to raise_error(Mongoid::Errors::InvalidValue)
+        end.to raise_error(Mongoid::Errors::InvalidValue, /Value of type Array cannot be written to a field of type Hash/)
+      end
+
+      it "raises an error when trying to set a value of invalid type - boolean" do
+        expect do
+          person.map = false
+        end.to raise_error(Mongoid::Errors::InvalidValue, /Value of type FalseClass cannot be written to a field of type Hash/)
       end
 
       it "can set a Hash value" do
@@ -1364,10 +1605,16 @@ describe Mongoid::Attributes do
         expect(person.aliases).to eq([ :alias_1 ])
       end
 
-      it "raises an error when try to set an invalid value" do
-        expect {
+      it "raises an error when trying to set a value of invalid type - hash" do
+        expect do
           person.aliases = {}
-        }.to raise_error(Mongoid::Errors::InvalidValue)
+        end.to raise_error(Mongoid::Errors::InvalidValue, /Value of type Hash cannot be written to a field of type Array/)
+      end
+
+      it "raises an error when trying to set a value of invalid type - boolean" do
+        expect do
+          person.aliases = false
+        end.to raise_error(Mongoid::Errors::InvalidValue, /Value of type FalseClass cannot be written to a field of type Array/)
       end
     end
 
@@ -1383,6 +1630,51 @@ describe Mongoid::Attributes do
         expect(dictionary.description).to eq('foo')
       end
     end
+
+    context 'when writing fields on a document with projection' do
+
+      let!(:person) do
+        Person.create!(title: "sir")
+      end
+
+      context "when excluding with only and the field was not excluded" do
+
+        let(:from_db) do
+          Person.only(:_id).first
+        end
+
+        it "raises an error" do
+          expect {
+            from_db.write_attribute(:undefined_field, 'x')
+          }.to raise_error(ActiveModel::MissingAttributeError)
+        end
+      end
+
+      context "when excluding with without and the field was excluded" do
+
+        let(:from_db) do
+          Person.without(:title).first
+        end
+
+        it "raises an error" do
+          expect {
+            from_db.write_attribute(:title, 'x')
+          }.to raise_error(ActiveModel::MissingAttributeError)
+        end
+      end
+
+      context "when excluding with without and the field was not excluded" do
+
+        let(:from_db) do
+          Person.without(:title).first
+        end
+
+        it "writes the value" do
+          from_db.write_attribute(:undefined_field, 'x')
+          from_db.read_attribute(:undefined_field).should == 'x'
+        end
+      end
+    end
   end
 
   describe "#typed_value_for" do
@@ -1422,7 +1714,7 @@ describe Mongoid::Attributes do
   end
 
   describe "#typed_attributes"  do
-    
+
     let(:date_time) do
       DateTime.current
     end
@@ -1636,6 +1928,61 @@ describe Mongoid::Attributes do
     end
   end
 
+  describe '#unalias_attribute' do
+    let(:shirt) { Shirt.new }
+    let(:id) { '1234' }
+
+    context 'when creating object' do
+      let(:shirt) { Shirt.new(id: id) }
+
+      it 'id and _id are not the same' do
+        expect(shirt.id).to eq(id)
+        expect(shirt._id).not_to eq(id)
+      end
+    end
+
+    context 'update' do
+      before do
+        shirt.update(id: id)
+      end
+
+      it 'updates id but not_id' do
+        expect(shirt.id).to eq(id)
+        expect(shirt._id).not_to eq(id)
+      end
+    end
+
+    context 'id=' do
+      before do
+        shirt.id = id
+      end
+
+      it 'sets id and not _id' do
+        expect(shirt.id).to eq(id)
+        expect(shirt._id).not_to eq(id)
+      end
+    end
+
+    context 'id?' do
+      context 'with null id' do
+        it 'returns false' do
+          expect(shirt.id?).to be false
+          expect(shirt._id?).to be true
+        end
+      end
+
+      context 'with id' do
+        before do
+          shirt.id = id
+        end
+
+        it 'returns true' do
+          expect(shirt.id?).to be true
+        end
+      end
+    end
+  end
+
   describe "#alias_attribute" do
 
     let(:product) do
@@ -1727,7 +2074,7 @@ describe Mongoid::Attributes do
   context "when persisting nil attributes" do
 
     let!(:person) do
-      Person.create(score: nil)
+      Person.create!(score: nil)
     end
 
     it "has an entry in the attributes" do
@@ -1742,7 +2089,7 @@ describe Mongoid::Attributes do
     end
 
     it "saves the default" do
-      expect { person.save }.to_not raise_error
+      expect { person.save! }.to_not raise_error
       expect(person.last_drink_taken_at).to eq(1.day.ago.in_time_zone("Alaska").to_date)
     end
   end
@@ -1752,7 +2099,7 @@ describe Mongoid::Attributes do
     context "when no value exists in the database" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       it "applies the default value" do
@@ -1765,7 +2112,7 @@ describe Mongoid::Attributes do
       context "when the value is not nil" do
 
         let!(:person) do
-          Person.create(age: 50)
+          Person.create!(age: 50)
         end
 
         let(:from_db) do
@@ -1780,7 +2127,7 @@ describe Mongoid::Attributes do
       context "when the value is explicitly nil" do
 
         let!(:person) do
-          Person.create(age: nil)
+          Person.create!(age: nil)
         end
 
         let(:from_db) do
@@ -1795,7 +2142,7 @@ describe Mongoid::Attributes do
       context "when the default is a proc" do
 
         let!(:account) do
-          Account.create(name: "savings", balance: "100")
+          Account.create!(name: "savings", balance: 100)
         end
 
         let(:from_db) do
@@ -1813,7 +2160,7 @@ describe Mongoid::Attributes do
 
     context 'when the attribute is blank' do
       let(:person) do
-        Person.create(title: '')
+        Person.create!(title: '')
       end
 
       it 'returns false' do
@@ -1823,7 +2170,7 @@ describe Mongoid::Attributes do
 
     context 'when the attribute is localized' do
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context 'after initialization when the field is nil' do
@@ -1855,7 +2202,7 @@ describe Mongoid::Attributes do
 
     context 'when the attribute is not localized' do
       let(:person) do
-        Person.create(username: 'localized')
+        Person.create!(username: 'localized')
       end
 
       before do

data/spec/mongoid/cacheable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Cacheable do
@@ -35,7 +37,7 @@ describe Mongoid::Cacheable do
     context "when persisted" do
 
       before do
-        document.save
+        document.save!
       end
 
       context "with updated_at" do