mongoid 7.0.0 → 7.4.0

data/spec/mongoid/association/referenced/has_one_query_spec.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require_relative './has_one_models'
+
+describe Mongoid::Association::Referenced::HasOne do
+  context 'when projecting with #only' do
+    before do
+      college = HomCollege.create!(state: 'ny')
+      HomAccreditation.create!(college: college, degree: 'cs', year: 2017)
+    end
+
+    let(:college) do
+      HomCollege.where(state: 'ny').only('accreditation._id', 'accreditation.degree').first
+    end
+
+    let(:accreditation) { college.accreditation }
+
+    it 'populates specified fields only' do
+      pending 'https://jira.mongodb.org/browse/MONGOID-4704'
+
+      expect(accreditation.degree).to eq('cs')
+      # has a default value specified in the model
+      expect do
+        accreditation.year
+      end.to raise_error(ActiveModel::MissingAttributeError)
+      expect(legislator.attributes.keys).to eq(['_id', 'degree'])
+    end
+
+    # Delete this test when https://jira.mongodb.org/browse/MONGOID-4704 is
+    # implemented and above test is unpended
+    it 'fetches all fields' do
+      expect(accreditation.degree).to eq('cs')
+      expect(accreditation.year).to eq(2017)
+    end
+  end
+end

data/spec/mongoid/association/referenced/has_one_spec.rb

@@ -1,4 +1,7 @@
+# frozen_string_literal: true
+
 require "spec_helper"
+require_relative './has_one_models'
 
 describe Mongoid::Association::Referenced::HasOne do
 
@@ -483,6 +486,27 @@ describe Mongoid::Association::Referenced::HasOne do
     end
   end
 
+  describe '#scope' do
+
+    context 'when scope is specified in the options' do
+
+      let(:options) do
+        { scope: -> { unscoped.where(foo: :bar) } }
+      end
+
+      it 'returns a Criteria Queryable Key' do
+        expect(association.scope).to be_a(Proc)
+      end
+    end
+
+    context 'when scope is not specified in the options' do
+
+      it 'returns nil' do
+        expect(association.scope).to be_nil
+      end
+    end
+  end
+
   describe '#as' do
 
     context 'when :as is specified in the options' do
@@ -744,7 +768,7 @@ describe Mongoid::Association::Referenced::HasOne do
     end
   end
 
-  describe '##inverse' do
+  describe '#inverse' do
 
     context 'when polymorphic' do
 
@@ -890,6 +914,33 @@ describe Mongoid::Association::Referenced::HasOne do
 
   describe '#relation_class_name' do
 
+    context 'when the classes are defined in a module' do
+
+      let(:define_classes) do
+        module HasOneAssociationClassName
+          class OwnedClass
+            include Mongoid::Document
+
+            belongs_to :owner_class
+          end
+
+          class OwnerClass
+            include Mongoid::Document
+
+            has_one :owned_class
+          end
+        end
+      end
+
+      it 'returns the inferred unqualified class name' do
+        define_classes
+
+        expect(
+            HasOneAssociationClassName::OwnedClass.relations['owner_class'].relation_class_name
+        ).to eq('OwnerClass')
+      end
+    end
+
     context 'when the :class_name option is specified' do
 
       let(:options) do
@@ -899,6 +950,16 @@ describe Mongoid::Association::Referenced::HasOne do
       it 'returns the class name option' do
         expect(association.relation_class_name).to eq('OtherBelongingObject')
       end
+
+      context 'when the class is namespaced' do
+        let(:association) do
+          HomNs::PrefixedParent.relations['child']
+        end
+
+        it 'returns unqualified class name as given in the :class_name option' do
+          expect(association.relation_class_name).to eq('PrefixedChild')
+        end
+      end
     end
 
     context 'when the class_name option is not specified' do
@@ -907,9 +968,19 @@ describe Mongoid::Association::Referenced::HasOne do
         expect(association.relation_class_name).to eq('BelongingObject')
       end
     end
+
+    context "when the class is not defined" do
+      let(:name) do
+        :undefined_class
+      end
+
+      it 'does not trigger autoloading' do
+        expect(association.relation_class_name).to eq('UndefinedClass')
+      end
+    end
   end
 
-  describe '#klass' do
+  describe '#relation_class' do
 
     context 'when the :class_name option is specified' do
 
@@ -923,22 +994,48 @@ describe Mongoid::Association::Referenced::HasOne do
       end
 
       it 'returns the class name option' do
-        expect(association.klass).to eq(_class)
+        expect(association.relation_class).to eq(_class)
+      end
+
+      context 'when the class is namespaced' do
+        let(:association) do
+          HomNs::PrefixedParent.relations['child']
+        end
+
+        it 'returns resolved class instance' do
+          expect(association.relation_class).to eq(HomNs::PrefixedChild)
+        end
       end
     end
 
     context 'when the class_name option is not specified' do
 
       it 'uses the name of the relation to deduce the class name' do
-        expect(association.klass).to eq(BelongingObject)
+        expect(association.relation_class).to eq(BelongingObject)
       end
     end
   end
 
+  describe '#klass' do
+    it 'is the target class' do
+      expect(association.klass).to eq(BelongingObject)
+    end
+  end
+
   describe '#inverse_class_name' do
 
     it 'returns the name of the owner class' do
-      expect(association.inverse_class_name).to eq(OwnerObject.name)
+      expect(association.inverse_class_name).to eq('OwnerObject')
+    end
+
+    context 'polymorphic association' do
+      let(:association) do
+        has_one_class.has_one :belonging_object, as: :bar
+      end
+
+      it 'returns the name of the owner class' do
+        expect(association.inverse_class_name).to eq(OwnerObject.name)
+      end
     end
   end
 
@@ -947,6 +1044,16 @@ describe Mongoid::Association::Referenced::HasOne do
     it 'returns the owner class' do
       expect(association.inverse_class).to be(OwnerObject)
     end
+
+    context 'polymorphic association' do
+      let(:association) do
+        has_one_class.has_one :belonging_object, as: :bar
+      end
+
+      it 'returns the owner class' do
+        expect(association.inverse_class).to be(OwnerObject)
+      end
+    end
   end
 
   describe '#inverse_of' do
@@ -1200,6 +1307,38 @@ describe Mongoid::Association::Referenced::HasOne do
     end
   end
 
+  context 'when the classes are defined in a module' do
+
+    let(:define_classes) do
+      module HasOneAssociationModuleDefinitions
+        class OwnedClass
+          include Mongoid::Document
+
+          belongs_to :owner_class
+        end
+
+        class OwnerClass
+          include Mongoid::Document
+
+          has_one :owned_class
+        end
+      end
+    end
+
+    let(:owner) do
+      HasOneAssociationModuleDefinitions::OwnerClass.create!
+    end
+
+    let(:owned) do
+      define_classes
+      HasOneAssociationModuleDefinitions::OwnedClass.create!(owner_class: owner)
+    end
+
+    it 'successfully creates the owned document' do
+      expect { owned }.not_to raise_error
+    end
+  end
+
   describe '#nested_builder' do
 
     it 'returns an instance of Association::Nested::One' do

data/spec/mongoid/association/reflections_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Reflections do

data/spec/mongoid/association/syncable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe "Syncable Association" do
@@ -108,7 +110,7 @@ describe "Syncable Association" do
       context "and is Persisted" do
 
         it "is able to :save" do
-          expect(account.save).to be true
+          expect(account.save!).to be true
         end
       end
 
@@ -119,7 +121,7 @@ describe "Syncable Association" do
         end
 
         it "is able to :save" do
-          expect(account.save).to be true
+          expect(account.save!).to be true
         end
       end
     end
@@ -140,7 +142,7 @@ describe "Syncable Association" do
     end
 
     it "does not attempt synchronization" do
-      expect { article.save }.to_not raise_error
+      expect { article.save! }.to_not raise_error
     end
 
     it "sets the one side of the relation" do
@@ -151,11 +153,11 @@ describe "Syncable Association" do
   context "when first setting by the relation itself" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:one) do
-      Preference.create(name: "one")
+      Preference.create!(name: "one")
     end
 
     before do
@@ -173,12 +175,12 @@ describe "Syncable Association" do
     context "when subsequently setting with keys" do
 
       let!(:two) do
-        Preference.create(name: "two")
+        Preference.create!(name: "two")
       end
 
       before do
         person.preference_ids << two.id
-        person.save
+        person.save!
       end
 
       it "sets the inverse foreign key" do
@@ -190,15 +192,15 @@ describe "Syncable Association" do
   context "when setting new ids" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:one) do
-      Preference.create(name: "one")
+      Preference.create!(name: "one")
     end
 
     let!(:two) do
-      Preference.create(name: "two")
+      Preference.create!(name: "two")
     end
 
     before do
@@ -222,7 +224,7 @@ describe "Syncable Association" do
       context "when validation passes" do
 
         before do
-          person.save
+          person.save!
         end
 
         it "persists the foreign_key" do
@@ -243,19 +245,19 @@ describe "Syncable Association" do
   context "when replacing ids" do
 
     let!(:one) do
-      Preference.create(name: "one")
+      Preference.create!(name: "one")
     end
 
     let!(:two) do
-      Preference.create(name: "two")
+      Preference.create!(name: "two")
     end
 
     let!(:person) do
-      Person.create(preference_ids: [ one.id, two.id ])
+      Person.create!(preference_ids: [ one.id, two.id ])
     end
 
     let!(:three) do
-      Preference.create(name: "three")
+      Preference.create!(name: "three")
     end
 
     before do
@@ -283,7 +285,7 @@ describe "Syncable Association" do
       context "when validation passes" do
 
         before do
-          person.save
+          person.save!
         end
 
         it "persists the foreign_key" do
@@ -308,15 +310,15 @@ describe "Syncable Association" do
   context "when setting ids to empty" do
 
     let!(:one) do
-      Preference.create(name: "one")
+      Preference.create!(name: "one")
     end
 
     let!(:two) do
-      Preference.create(name: "two")
+      Preference.create!(name: "two")
     end
 
     let!(:person) do
-      Person.create(preference_ids: [ one.id, two.id ])
+      Person.create!(preference_ids: [ one.id, two.id ])
     end
 
     before do
@@ -340,7 +342,7 @@ describe "Syncable Association" do
       context "when validation passes" do
 
         before do
-          person.save
+          person.save!
         end
 
         it "persists the foreign_key" do
@@ -361,15 +363,15 @@ describe "Syncable Association" do
   context "when setting ids to nil" do
 
     let!(:one) do
-      Preference.create(name: "one")
+      Preference.create!(name: "one")
     end
 
     let!(:two) do
-      Preference.create(name: "two")
+      Preference.create!(name: "two")
     end
 
     let!(:person) do
-      Person.create(preference_ids: [ one.id, two.id ])
+      Person.create!(preference_ids: [ one.id, two.id ])
     end
 
     before do
@@ -393,7 +395,7 @@ describe "Syncable Association" do
       context "when validation passes" do
 
         before do
-          person.save
+          person.save!
         end
 
         it "persists the foreign_key" do
@@ -414,15 +416,15 @@ describe "Syncable Association" do
   context "when destroying" do
 
     let!(:one) do
-      Preference.create(name: "one")
+      Preference.create!(name: "one")
     end
 
     let!(:two) do
-      Preference.create(name: "two")
+      Preference.create!(name: "two")
     end
 
     let!(:person) do
-      Person.create(preferences: [ one, two ])
+      Person.create!(preferences: [ one, two ])
     end
 
     context "when destroying the parent" do
@@ -455,7 +457,7 @@ describe "Syncable Association" do
   context "when appending an existing document to a new one" do
 
     let!(:persisted) do
-      Tag.create
+      Tag.create!
     end
 
     let(:article) do
@@ -464,7 +466,7 @@ describe "Syncable Association" do
 
     before do
       article.tags << persisted
-      article.save
+      article.save!
     end
 
     it "persists the foreign key on the inverse" do
@@ -479,7 +481,7 @@ describe "Syncable Association" do
   context "when the document has an ordering default scope" do
 
     let!(:dog) do
-      Dog.create(name: "Fido")
+      Dog.create!(name: "Fido")
     end
 
     let!(:breed) do
@@ -487,7 +489,7 @@ describe "Syncable Association" do
     end
 
     before do
-      breed.save
+      breed.save!
     end
 
     it "adds the id to the inverse relation" do

data/spec/mongoid/association_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association do

data/spec/mongoid/atomic/modifiers_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Atomic::Modifiers do
@@ -6,6 +8,26 @@ describe Mongoid::Atomic::Modifiers do
     described_class.new
   end
 
+  describe "#push_conflict?" do
+    let(:result) { modifiers.send(:push_conflict?, field) }
+
+    context 'for embeds many subdocument' do
+      context 'when another field on subdocument is being set' do
+        before do
+          modifiers.set('foo.0.a' => 1)
+        end
+
+        let(:field) { 'foo' }
+
+        it 'does not conflict' do
+          pending 'https://jira.mongodb.org/browse/MONGOID-4982'
+
+          result.should be false
+        end
+      end
+    end
+  end
+
   describe "#add_to_set" do
 
     context "when the unique adds are empty" do
@@ -341,6 +363,33 @@ describe Mongoid::Atomic::Modifiers do
         end
       end
     end
+
+    context 'when there is another operation on a sibling of a key which is nested' do
+
+      let(:first_op) do
+        { "addresses.0.name" => 'test' }
+      end
+
+      let(:push_op) do
+        { "addresses.0.locations" => { "street" => "Oxford St" } }
+      end
+
+      before do
+        modifiers.set(first_op)
+        modifiers.push(push_op)
+      end
+
+      it "does not conflict and adds push to top level" do
+        pending 'https://jira.mongodb.org/browse/MONGOID-4982'
+
+        modifiers.should == {
+          '$set' => { "addresses.0.name" => 'test' },
+          '$push' => {"addresses.0.locations" => {'$each' => [
+            { "street" => "Oxford St" },
+          ]}},
+        }
+      end
+    end
   end
 
   describe "#set" do

data/spec/mongoid/atomic/paths/embedded/many_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Atomic::Paths::Embedded::Many do

data/spec/mongoid/atomic/paths/embedded/one_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Atomic::Paths::Embedded::One do

data/spec/mongoid/atomic/paths/root_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Atomic::Paths::Root do