mongoid 6.4.8 → 7.0.0.beta

data/spec/mongoid/fields_spec.rb

@@ -816,7 +816,7 @@ describe Mongoid::Fields do
 
     context "when the field name conflicts with mongoid's internals" do
 
-      [:__metadata, :invalid].each do |meth|
+      [:_association, :invalid].each do |meth|
         context "when the field is named #{meth}" do
 
           it "raises an error" do
@@ -1171,7 +1171,7 @@ describe Mongoid::Fields do
     end
 
     let(:decimal) do
-      BigDecimal("1000000.00")
+      BigDecimal.new("1000000.00")
     end
 
     context "when setting to a big decimal" do

data/spec/mongoid/findable_spec.rb

@@ -10,7 +10,7 @@ describe Mongoid::Findable do
     end
 
     it "returns the distinct values for the field" do
-      expect(Band.distinct(:name).sort).to eq([ "Photek", "Tool" ])
+      expect(Band.distinct(:name)).to eq([ "Tool", "Photek" ])
     end
   end
 

data/spec/mongoid/indexable_spec.rb

@@ -89,8 +89,9 @@ describe Mongoid::Indexable do
         klass.create_indexes
       end
 
-      it "creates the indexes" do
-        expect(klass.collection.indexes.get(_type: 1)).to_not be_nil
+      it "creates the indexes by using specified background option" do
+        index = klass.collection.indexes.get(_type: 1)
+        expect(index[:background]).to eq(true)
       end
     end
 
@@ -104,12 +105,9 @@ describe Mongoid::Indexable do
         end
       end
 
-      before do
-        klass.create_indexes
-      end
-
       after do
         klass.remove_indexes
+        Mongoid::Config.background_indexing = false
       end
 
       let(:indexes) do
@@ -118,8 +116,20 @@ describe Mongoid::Indexable do
         end
       end
 
-      it "creates the indexes" do
-        expect(indexes.get(_type: 1)).to_not be_nil
+      it "creates the indexes by using default background_indexing option" do
+        klass.create_indexes
+
+        index = indexes.get(_type: 1)
+        expect(index[:background]).to eq(Mongoid::Config.background_indexing)
+      end
+
+      it "creates the indexes by using specified background_indexing option" do
+        Mongoid::Config.background_indexing = true
+
+        klass.create_indexes
+
+        index = indexes.get(_type: 1)
+        expect(index[:background]).to eq(true)
       end
     end
 

data/spec/mongoid/interceptable_spec.rb

@@ -526,7 +526,7 @@ describe Mongoid::Interceptable do
           end
 
           after(:all) do
-            begin; Band.reset_callbacks(:rearrange); rescue; end
+            Band.reset_callbacks(:rearrange)
           end
 
           let(:attributes) do
@@ -597,7 +597,7 @@ describe Mongoid::Interceptable do
       it "raises an error" do
         expect {
           Band.has_and_belongs_to_many :tags, cascade_callbacks: true
-        }.to raise_error(Mongoid::Errors::InvalidOptions)
+        }.to raise_error(Mongoid::Errors::InvalidRelationOption)
       end
     end
 
@@ -1181,6 +1181,25 @@ describe Mongoid::Interceptable do
           end
         end
 
+        context 'when the parent is updated' do
+
+          let(:band) do
+            Band.create(name: "Moderat")
+          end
+
+          before do
+            band.update(records: [ { name: 'Black on Both Sides' }])
+          end
+
+          it 'executes the callback' do
+            expect(band.records.first.before_validation_called).to be true
+          end
+
+          it 'persists the change' do
+            expect(band.reload.records.first.before_validation_called).to be true
+          end
+        end
+
         context "when the child is persisted" do
 
           let(:band) do

data/spec/mongoid/matchable_spec.rb

@@ -86,7 +86,7 @@ describe Mongoid::Matchable do
           let(:selector) do
             { "occupants.0" => "Tim" }
           end
-
+          
           it "returns true" do
             expect(document.locations.first._matches?(selector)).to be true
           end
@@ -774,31 +774,6 @@ describe Mongoid::Matchable do
         end
       end
 
-      context "with an $nor selector" do
-
-        context "when the attributes match" do
-
-          let(:selector) do
-            { "$nor" => [ { number: 10 }, { number: { "$gt" => 199 } } ] }
-          end
-
-          it "returns true" do
-            expect(document._matches?(selector)).to be true
-          end
-        end
-
-        context "when the attributes do not match" do
-
-          let(:selector) do
-            { "$nor" => [ { number: 10 }, { number: { "$gt" => 99 } } ] }
-          end
-
-          it "returns false" do
-            expect(document._matches?(selector)).to be false
-          end
-        end
-      end
-
       context "with a $size selector" do
 
         context "when the attributes match" do

data/spec/mongoid/persistable/deletable_spec.rb

@@ -228,25 +228,6 @@ describe Mongoid::Persistable::Deletable do
           expect(removed).to eq(1)
         end
       end
-
-      context 'when the write concern is unacknowledged' do
-
-        before do
-          Person.create(title: 'miss')
-        end
-
-        let!(:deleted) do
-          Person.with(write: { w: 0 }) { |klass| klass.delete_all(title: "sir") }
-        end
-
-        it "removes the matching documents" do
-          expect(Person.where(title: 'miss').count).to eq(1)
-        end
-
-        it "returns 0" do
-          expect(deleted).to eq(0)
-        end
-      end
     end
   end
 end

data/spec/mongoid/persistable/destroyable_spec.rb

@@ -222,25 +222,6 @@ describe Mongoid::Persistable::Destroyable do
       end
     end
 
-    context 'when the write concern is unacknowledged' do
-
-      before do
-        Person.create(title: 'miss')
-      end
-
-      let!(:removed) do
-        Person.with(write: { w: 0 }) { |klass| klass.destroy_all(title: "sir") }
-      end
-
-      it "removes the matching documents" do
-        expect(Person.where(title: 'miss').count).to eq(1)
-      end
-
-      it "returns 0" do
-        expect(removed).to eq(0)
-      end
-    end
-
     context 'when removing a list of embedded documents' do
 
       context 'when the embedded documents list is reversed in memory' do

data/spec/mongoid/persistable/incrementable_spec.rb

@@ -66,15 +66,15 @@ describe Mongoid::Persistable::Incrementable do
       context "when providing big decimal values" do
 
         let(:five) do
-          BigDecimal("5.0")
+          BigDecimal.new("5.0")
         end
 
         let(:neg_ten) do
-          BigDecimal("-10.0")
+          BigDecimal.new("-10.0")
         end
 
         let(:thirty) do
-          BigDecimal("30.0")
+          BigDecimal.new("30.0")
         end
 
         let!(:inc) do
@@ -151,15 +151,15 @@ describe Mongoid::Persistable::Incrementable do
       context "when providing big decimal values" do
 
         let(:five) do
-          BigDecimal("5.0")
+          BigDecimal.new("5.0")
         end
 
         let(:neg_ten) do
-          BigDecimal("-10.0")
+          BigDecimal.new("-10.0")
         end
 
         let(:thirty) do
-          BigDecimal("30.0")
+          BigDecimal.new("30.0")
         end
 
         let!(:inc) do

data/spec/mongoid/persistable/savable_spec.rb

@@ -189,8 +189,8 @@ describe Mongoid::Persistable::Savable do
               "title" => "King",
               "name.first_name" => "Ryan"
             },
-            "$push"=> {
-              "addresses" =>  { '$each' => [ { "_id" => address.id, "street" => "Bond St" } ] }
+            "$pushAll"=> {
+              "addresses" => [ { "_id" => address.id, "street" => "Bond St" } ]
             }
           })
         end
@@ -309,7 +309,7 @@ describe Mongoid::Persistable::Savable do
         expect {
           person.username = 'unloaded-attribute'
           person.save
-        }.to raise_error(Mongoid::Errors::ReadonlyAttribute)
+        }.to raise_error(ActiveModel::MissingAttributeError)
       end
 
       context 'when the changed attribute is aliased' do

data/spec/mongoid/persistable/settable_spec.rb

@@ -278,22 +278,7 @@ describe Mongoid::Persistable::Settable do
       end
     end
 
-    context 'when the field is a nested hash' do
-
-      context 'when the field is reset to an empty hash' do
-
-        before do
-          church.set('location' => {})
-        end
-
-        it 'updates the field locally' do
-          expect(church.location).to eq({})
-        end
-
-        it 'updates the field in the database' do
-          expect(church.reload.location).to eq({})
-        end
-      end
+    context 'when the field is a bested hash' do
 
       context 'when a leaf value in the nested hash is updated' do
 
@@ -315,25 +300,6 @@ describe Mongoid::Persistable::Settable do
         end
       end
 
-      context 'when a leaf value in the nested hash is updated to a number' do
-
-        let(:church) do
-          Church.new.tap do |a|
-            a.location = {'address' => {'city' => 'Berlin', 'street' => 'Yorckstr'}}
-            a.name = 'Church1'
-            a.save
-          end
-        end
-
-        before do
-          church.set('location.address.city' => 12345)
-        end
-
-        it 'updates the nested value to the correct value' do
-          expect(church.name).to eq('Church1')
-          expect(church.location).to eql({'address' => {'city' => 12345, 'street' => 'Yorckstr'}})
-        end
-      end
 
       context 'when the nested hash is many levels deep' do
 

data/spec/mongoid/persistable/updatable_spec.rb

@@ -462,7 +462,7 @@ describe Mongoid::Persistable::Updatable do
 
         it "raises an error" do
           expect {
-            person.update_attributes(map: { "$bad.key" => "value" })
+            person.update_attributes(map: { "bad.key" => "value" })
           }.to raise_error(Mongo::Error::OperationFailure)
         end
       end
@@ -498,7 +498,7 @@ describe Mongoid::Persistable::Updatable do
 
         it "raises an error" do
           expect {
-            person.send(method, map: { "$bad.key" => "value" })
+            person.send(method, map: { "bad.key" => "value" })
           }.to raise_error(Mongo::Error::OperationFailure)
         end
       end

data/spec/mongoid/persistable_spec.rb

@@ -52,16 +52,16 @@ describe Mongoid::Persistable do
       context "when not chaining the operations" do
 
         let(:operations) do
-          [{
+          {
             "$inc" => { "member_count" => 10 },
             "$bit" => { "likes" => { :and => 13 }},
             "$set" => { "name" => "Placebo" },
-            "$unset" => { "origin" => true }},
-           { session: nil }]
+            "$unset" => { "origin" => true }
+          }
         end
 
         before do
-          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(*operations).and_call_original
+          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(operations).and_call_original
         end
 
         let!(:update) do
@@ -79,16 +79,16 @@ describe Mongoid::Persistable do
       context "when chaining the operations" do
 
         let(:operations) do
-          [{
+          {
             "$inc" => { "member_count" => 10 },
             "$bit" => { "likes" => { :and => 13 }},
             "$set" => { "name" => "Placebo" },
-            "$unset" => { "origin" => true }},
-           { :session => nil } ]
+            "$unset" => { "origin" => true }
+          }
         end
 
         before do
-          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(*operations).and_call_original
+          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(operations).and_call_original
         end
 
         let!(:update) do
@@ -107,16 +107,16 @@ describe Mongoid::Persistable do
       context "when given multiple operations of the same type" do
 
         let(:operations) do
-          [{
+          {
             "$inc" => { "member_count" => 10, "other_count" => 10 },
             "$bit" => { "likes" => { :and => 13 }},
             "$set" => { "name" => "Placebo" },
-            "$unset" => { "origin" => true }},
-            { session: nil }]
+            "$unset" => { "origin" => true }
+          }
         end
 
         before do
-          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(*operations).and_call_original
+          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(operations).and_call_original
         end
 
         let!(:update) do
@@ -144,16 +144,16 @@ describe Mongoid::Persistable do
       context "when expecting the document to be yielded" do
 
         let(:operations) do
-          [{
+          {
             "$inc" => { "member_count" => 10 },
             "$bit" => { "likes" => { :and => 13 }},
             "$set" => { "name" => "Placebo" },
-            "$unset" => { "origin" => true }},
-            { session: nil }]
+            "$unset" => { "origin" => true }
+          }
         end
 
         before do
-          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(*operations).and_call_original
+          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(operations).and_call_original
         end
 
         let!(:update) do

data/spec/mongoid/persistence_context_spec.rb

@@ -70,20 +70,6 @@ describe Mongoid::PersistenceContext do
       { collection: :other }
     end
 
-    context 'when the method throws an error' do
-
-      let!(:persistence_context) do
-        described_class.set(object, options).tap do |cxt|
-          allow(cxt).to receive(:client).and_raise(Mongoid::Errors::NoClientConfig.new('default'))
-        end
-      end
-
-      it 'clears the context anyway' do
-        begin; described_class.clear(object); rescue; end
-        expect(described_class.get(object)).to be(nil)
-      end
-    end
-
     context 'when there has been a persistence context set on the current thread' do
 
       let!(:persistence_context) do

data/spec/mongoid/positional_spec.rb

@@ -17,8 +17,8 @@ describe Mongoid::Positional do
           "children.0.field" => "value",
           "children.0.children.1.children.3.field" => "value"
         },
-        "$push" => {
-          "children.0.children.1.children.3.fields" => { '$each' => [ "value", "value" ] }
+        "$pushAll" => {
+          "children.0.children.1.children.3.fields" => [ "value", "value" ]
         }
       }
     end
@@ -113,8 +113,8 @@ describe Mongoid::Positional do
               "children.$.field" => "value",
               "children.0.children.1.children.3.field" => "value"
             },
-            "$push" => {
-              "children.0.children.1.children.3.fields" => { '$each' => [ "value", "value" ] }
+            "$pushAll" => {
+              "children.0.children.1.children.3.fields" => [ "value", "value" ]
             }
           }
         end
@@ -141,8 +141,8 @@ describe Mongoid::Positional do
               "children.0.field" => "value",
               "children.0.children.1.children.3.field" => "value"
             },
-            "$push" => {
-              "children.0.children.1.children.3.fields" => { '$each' => [ "value", "value" ] }
+            "$pushAll" => {
+              "children.0.children.1.children.3.fields" => [ "value", "value" ]
             }
           }
         end
@@ -170,8 +170,8 @@ describe Mongoid::Positional do
             "children.$.field" => "value",
             "children.0.children.1.children.3.field" => "value"
           },
-          "$push" => {
-            "children.0.children.1.children.3.fields" => { '$each' => [ "value", "value" ] }
+          "$pushAll" => {
+            "children.0.children.1.children.3.fields" => [ "value", "value" ]
           }
         }
       end
@@ -203,8 +203,8 @@ describe Mongoid::Positional do
             "children.$.field" => "value",
             "children.0.children.1.children.3.field" => "value"
           },
-          "$push" => {
-            "children.0.children.1.children.3.fields" => { '$each' => [ "value", "value" ] }
+          "$pushAll" => {
+            "children.0.children.1.children.3.fields" => [ "value", "value" ]
           }
         }
       end