mongoid 6.4.8 → 7.0.0.beta

data/spec/mongoid/config_spec.rb

@@ -88,6 +88,30 @@ describe Mongoid::Config do
     end
   end
 
+  context 'when background_indexing option' do
+    context 'is not set in the config' do
+      it 'sets the value to false by default' do
+        Mongoid::Config.reset
+        configuration = CONFIG.merge(options: {})
+
+        Mongoid.configure { |config| config.load_configuration(configuration) }
+
+        expect(Mongoid::Config.background_indexing).to be(false)
+      end
+    end
+
+    context 'is set in the config' do
+      it 'sets the value' do
+        Mongoid::Config.reset
+        configuration = CONFIG.merge(options: {background_indexing: true})
+
+        Mongoid.configure { |config| config.load_configuration(configuration) }
+
+        expect(Mongoid::Config.background_indexing).to be(true)
+      end
+    end
+  end
+
   context 'when the belongs_to_required_by_default option is not set in the config' do
 
     before do

data/spec/mongoid/contextual/geo_near_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe Mongoid::Contextual::GeoNear do
-  max_server_version '4.0'
 
   describe "#average_distance" do
 

data/spec/mongoid/contextual/mongo_spec.rb

@@ -275,23 +275,6 @@ describe Mongoid::Contextual::Mongo do
           expect(Band.count).to eq(0)
         end
       end
-
-      context 'when the write concern is unacknowledged' do
-
-        let(:criteria) do
-          Band.all
-        end
-
-        let!(:deleted) do
-          criteria.with(write: { w: 0 }) do |crit|
-            crit.send(method)
-          end
-        end
-
-        it 'returns 0' do
-          expect(deleted).to eq(0)
-        end
-      end
     end
   end
 
@@ -380,27 +363,6 @@ describe Mongoid::Contextual::Mongo do
         end
       end
     end
-
-    context 'when the write concern is unacknowledged' do
-
-      before do
-        2.times { Band.create }
-      end
-
-      let(:criteria) do
-        Band.all
-      end
-
-      let!(:deleted) do
-        criteria.with(write: { w: 0 }) do |crit|
-          crit.send(method)
-        end
-      end
-
-      it 'returns 0' do
-        expect(deleted).to eq(0)
-      end
-    end
   end
 
   describe "#distinct" do
@@ -451,7 +413,7 @@ describe Mongoid::Contextual::Mongo do
       end
 
       it "returns the distinct field values" do
-        expect(context.distinct(:years).sort).to eq([ 25, 30 ])
+        expect(context.distinct(:years)).to eq([ 30, 25 ])
       end
     end
 
@@ -591,12 +553,12 @@ describe Mongoid::Contextual::Mongo do
 
     context "when no documents are returned" do
 
-      let(:game_metadata) do
+      let(:game_association) do
         Person.reflect_on_association(:game)
       end
 
       it "does not make any additional database queries" do
-        expect(game_metadata).to receive(:eager_load).never
+        expect(game_association).to receive(:eager_load).never
         context.send(:eager_load, [])
       end
     end
@@ -2132,41 +2094,6 @@ describe Mongoid::Contextual::Mongo do
         expect(context.update).to be false
       end
     end
-
-    context 'when provided array filters', if: array_filters_supported? do
-
-      before do
-        Band.delete_all
-        b = Band.new(name: 'Depeche Mode')
-        b.labels << Label.new(name: 'Warner')
-        b.labels << Label.new(name: 'Sony')
-        b.labels << Label.new(name: 'Cbs')
-        b.save
-
-        b = Band.new(name: 'FKA Twigs')
-        b.labels << Label.new(name: 'Warner')
-        b.labels << Label.new(name: 'Cbs')
-        b.save
-      end
-
-
-      let(:criteria) do
-        Band.where(name: 'Depeche Mode')
-      end
-
-      let!(:update) do
-        context.update({ '$set' => { 'labels.$[i].name' => 'Sony' } },
-                       array_filters: [{ 'i.name' => 'Cbs' }])
-      end
-
-      it 'applies the array filters' do
-        expect(Band.where(name: 'Depeche Mode').first.labels.collect(&:name)).to match_array(['Warner', 'Sony', 'Sony'])
-      end
-
-      it 'does not affect other documents' do
-        expect(Band.where(name: 'FKA Twigs').first.labels.collect(&:name)).to match_array(['Warner', 'Cbs'])
-      end
-    end
   end
 
   describe "#update_all" do
@@ -2304,41 +2231,6 @@ describe Mongoid::Contextual::Mongo do
         expect(context.update_all).to be false
       end
     end
-
-    context 'when provided array filters', if: array_filters_supported? do
-
-      before do
-        Band.delete_all
-        b = Band.new(name: 'Depeche Mode')
-        b.labels << Label.new(name: 'Warner')
-        b.labels << Label.new(name: 'Sony')
-        b.labels << Label.new(name: 'Cbs')
-        b.save
-
-        b = Band.new(name: 'FKA Twigs')
-        b.labels << Label.new(name: 'Warner')
-        b.labels << Label.new(name: 'Cbs')
-        b.save
-      end
-
-
-      let(:criteria) do
-        Band.all
-      end
-
-      let!(:update) do
-        context.update_all({ '$set' => { 'labels.$[i].name' => 'Sony' } },
-                           array_filters: [{ 'i.name' => 'Cbs' }])
-      end
-
-      it 'applies the array filters' do
-        expect(Band.where(name: 'Depeche Mode').first.labels.collect(&:name)).to match_array(['Warner', 'Sony', 'Sony'])
-      end
-
-      it 'updates all documents' do
-        expect(Band.where(name: 'FKA Twigs').first.labels.collect(&:name)).to match_array(['Warner', 'Sony'])
-      end
-    end
   end
 
   describe '#pipeline' do
@@ -2363,7 +2255,7 @@ describe Mongoid::Contextual::Mongo do
       end
 
       it 'creates a pipeline with the selector as one of the $match criteria' do
-        expect(pipeline_match).to include({ '$text' => { '$search' => "New Order" } })
+        expect(pipeline_match).to include({ :'$text' => { :'$search' => "New Order" } })
       end
 
       it 'creates a pipeline with the $exists operator as one of the $match criteria' do

data/spec/mongoid/criteria/modifiable_spec.rb

@@ -49,6 +49,29 @@ describe Mongoid::Criteria::Modifiable do
         end
       end
     end
+
+    context 'when the object is polymorphic' do
+
+      let(:movie) do
+        Movie.new
+      end
+
+      let(:criteria) do
+        Rating.where(ratable: movie)
+      end
+
+      let(:document) do
+        criteria.create
+      end
+
+      it 'sets the polymorphic id' do
+        expect(document.ratable_id).to eq(movie.id)
+      end
+
+      it 'sets the type field' do
+        expect(document.ratable_type).to eq('Movie')
+      end
+    end
   end
 
   describe "#create!" do
@@ -65,6 +88,29 @@ describe Mongoid::Criteria::Modifiable do
         }.to raise_error(Mongoid::Errors::Validations)
       end
     end
+
+    context 'when the object is polymorphic' do
+
+      let(:movie) do
+        Movie.new
+      end
+
+      let(:criteria) do
+        Rating.where(ratable: movie)
+      end
+
+      let(:document) do
+        criteria.create!
+      end
+
+      it 'sets the polymorphic id' do
+        expect(document.ratable_id).to eq(movie.id)
+      end
+
+      it 'sets the type field' do
+        expect(document.ratable_type).to eq('Movie')
+      end
+    end
   end
 
   [ :delete, :delete_all, :destroy, :destroy_all ].each do |method|
@@ -295,6 +341,25 @@ describe Mongoid::Criteria::Modifiable do
           expect(person.pets).to be true
         end
       end
+
+      context 'when the object is polymorphic' do
+
+        let(:movie) do
+          Movie.new
+        end
+
+        let(:document) do
+          Rating.find_or_create_by(ratable: movie)
+        end
+
+        it 'sets the polymorphic id' do
+          expect(document.ratable_id).to eq(movie.id)
+        end
+
+        it 'sets the type field' do
+          expect(document.ratable_type).to eq('Movie')
+        end
+      end
     end
   end
 
@@ -447,6 +512,25 @@ describe Mongoid::Criteria::Modifiable do
         end
       end
     end
+
+    context 'when the object is polymorphic' do
+
+      let(:movie) do
+        Movie.new
+      end
+
+      let(:document) do
+        Rating.find_or_create_by!(ratable: movie)
+      end
+
+      it 'sets the polymorphic id' do
+        expect(document.ratable_id).to eq(movie.id)
+      end
+
+      it 'sets the type field' do
+        expect(document.ratable_type).to eq('Movie')
+      end
+    end
   end
 
   describe ".find_or_initialize_by" do
@@ -500,6 +584,25 @@ describe Mongoid::Criteria::Modifiable do
         end
       end
     end
+
+    context 'when the object is polymorphic' do
+
+      let(:movie) do
+        Movie.new
+      end
+
+      let(:document) do
+        Rating.find_or_initialize_by(ratable: movie)
+      end
+
+      it 'sets the polymorphic id' do
+        expect(document.ratable_id).to eq(movie.id)
+      end
+
+      it 'sets the type field' do
+        expect(document.ratable_type).to eq('Movie')
+      end
+    end
   end
 
   describe "first_or_create" do
@@ -649,7 +752,7 @@ describe Mongoid::Criteria::Modifiable do
             band = Band.create
             Mongoid::Criteria.new(Record) do |criteria|
               criteria.embedded = true
-              criteria.metadata = Band.reflect_on_association(:records)
+              criteria.association = Band.reflect_on_association(:records)
               criteria.parent_document = band
               criteria.selector = { "records" => { "producers"=>{"$in"=>["nonexistent"] } } }
             end
@@ -703,6 +806,29 @@ describe Mongoid::Criteria::Modifiable do
         end
       end
 
+      context 'when the object is polymorphic' do
+
+        let(:movie) do
+          Movie.new
+        end
+
+        let(:criteria) do
+          Rating.where(ratable: movie)
+        end
+
+        let(:document) do
+          criteria.first_or_create
+        end
+
+        it 'sets the polymorphic id' do
+          expect(document.ratable_id).to eq(movie.id)
+        end
+
+        it 'sets the type field' do
+          expect(document.ratable_type).to eq('Movie')
+        end
+      end
+
       context "when a block is provided" do
 
         let(:document) do
@@ -919,6 +1045,29 @@ describe Mongoid::Criteria::Modifiable do
         end
       end
     end
+
+    context 'when the object is polymorphic' do
+
+      let(:movie) do
+        Movie.new
+      end
+
+      let(:criteria) do
+        Rating.where(ratable: movie)
+      end
+
+      let(:document) do
+        criteria.first_or_create!
+      end
+
+      it 'sets the polymorphic id' do
+        expect(document.ratable_id).to eq(movie.id)
+      end
+
+      it 'sets the type field' do
+        expect(document.ratable_type).to eq('Movie')
+      end
+    end
   end
 
   describe "first_or_initialize" do
@@ -938,6 +1087,29 @@ describe Mongoid::Criteria::Modifiable do
       end
     end
 
+    context 'when the object is polymorphic' do
+
+      let(:movie) do
+        Movie.new
+      end
+
+      let(:criteria) do
+        Rating.where(ratable: movie)
+      end
+
+      let(:document) do
+        criteria.first_or_initialize
+      end
+
+      it 'sets the polymorphic id' do
+        expect(document.ratable_id).to eq(movie.id)
+      end
+
+      it 'sets the type field' do
+        expect(document.ratable_type).to eq('Movie')
+      end
+    end
+
     context "when the document is not found" do
 
       context "when attributes are provided" do
@@ -1471,15 +1643,11 @@ describe Mongoid::Criteria::Modifiable do
         { 'username' => 'Turnip' }
       end
 
-      it 'does not modify the selector' do
-        expect(Person.create_with(attrs).selector[:username]).to be_nil
-      end
-
-      it 'create_attrs is modified' do
-        expect(Person.create_with(attrs).create_attrs).to eq(attrs)
+      it 'returns a criteria with the defined attributes' do
+        expect(Person.create_with(attrs).selector).to eq(attrs)
       end
 
-      context 'when a create is chained' do
+      context 'when a method is chained' do
 
         context 'when a write method is chained' do
 
@@ -1503,25 +1671,6 @@ describe Mongoid::Criteria::Modifiable do
             expect(new_person.age).to eq(50)
           end
 
-          context 'when a matching document is already in the collection' do
-            let(:query) do
-              { 'username' => 'foo', 'age' => 12 }
-            end
-
-            let(:person) do
-              Person.create!(query)
-            end
-
-            let(:found_person) do
-              Person.create_with(attrs).find_or_create_by(query)
-            end
-
-            it 'finds the matching document' do
-              person
-              expect(found_person.id).to eq(person.id)
-            end
-          end
-
           context 'when the attributes are shared with the write method args' do
 
             let(:query) do
@@ -1532,7 +1681,7 @@ describe Mongoid::Criteria::Modifiable do
               Person.create_with(attrs).find_or_create_by(query)
             end
 
-            it 'gives the find method args precedence' do
+            it 'gives the write method args precedence' do
               expect(new_person.username).to eq('Beet')
               expect(new_person.age).to eq(50)
             end
@@ -1559,12 +1708,8 @@ describe Mongoid::Criteria::Modifiable do
             { 'username' => 'Beet', 'age' => 50 }
           end
 
-          it 'does not modify the selector' do
-            expect(criteria.create_with(attrs).selector).to eq(criteria_selector)
-          end
-
           it 'overwrites all the original attributes' do
-            expect(criteria.create_with(attrs).create_attrs).to eq(attrs)
+            expect(criteria.create_with(attrs).selector).to eq(attrs)
           end
         end
       end
@@ -1575,12 +1720,8 @@ describe Mongoid::Criteria::Modifiable do
           { 'username' => 'Beet' }
         end
 
-        it 'does not modify the selector' do
-          expect(criteria.create_with(attrs).selector).to eq(criteria_selector)
-        end
-
         it 'only overwrites the shared attributes' do
-          expect(criteria.create_with(attrs).create_attrs).to eq(attrs)
+          expect(criteria.create_with(attrs).selector).to eq(criteria_selector.merge!(attrs))
         end
       end
 
@@ -1589,11 +1730,12 @@ describe Mongoid::Criteria::Modifiable do
         let(:attrs) do
           { 'username' => 'Turnip' }
         end
+
         let(:query) do
           { 'username' => 'Beet', 'age' => 50 }
         end
 
-        context 'when a create method is chained' do
+        context 'when a write method is chained' do
 
           it 'executes the method' do
             expect(criteria.create_with(attrs).new.username).to eq('Turnip')
@@ -1607,28 +1749,9 @@ describe Mongoid::Criteria::Modifiable do
             criteria.create_with(attrs).find_or_create_by(query)
           end
 
-          it 'gives the find method arg precedence' do
+          it 'executes the query' do
             expect(new_person.username).to eq('Beet')
-            expect(new_person.age).to be(50)
-          end
-
-          context 'when a matching document is already in the collection' do
-            let(:query) do
-              { 'username' => 'foo', 'age' => 12 }
-            end
-
-            let(:person) do
-              Person.create!(query)
-            end
-
-            let(:found_person) do
-              criteria.create_with(attrs).find_or_create_by(query)
-            end
-
-            it 'finds the matching document' do
-              person
-              expect(found_person.id).to eq(person.id)
-            end
+            expect(new_person.age).to eq(50)
           end
         end
       end