mongoid 6.4.4 → 7.5.1

data/spec/mongoid/interceptable_spec.rb

@@ -1,7 +1,18 @@
+# frozen_string_literal: true
+
 require "spec_helper"
+require_relative './interceptable_spec_models'
 
 describe Mongoid::Interceptable do
 
+  before do
+    # The find and initialize callbacks I added were causing failures
+    # because they were causing updates when we were asserting no updates
+    # happened.
+    Label.reset_callbacks(:initialize)
+    Label.reset_callbacks(:find)
+  end
+
   class TestClass
     include Mongoid::Interceptable
 
@@ -74,7 +85,7 @@ describe Mongoid::Interceptable do
   describe ".after_find" do
 
     let!(:player) do
-      Player.create
+      Player.create!
     end
 
     context "when the callback is on a root document" do
@@ -127,7 +138,7 @@ describe Mongoid::Interceptable do
     context "when the callback is on an embedded document" do
 
       let!(:implant) do
-        player.implants.create
+        player.implants.create!
       end
 
       context "when when the document is instantiated" do
@@ -197,7 +208,7 @@ describe Mongoid::Interceptable do
           ]
         })
         book.id = '123'
-        book.save
+        book.save!
         book
       end
 
@@ -209,7 +220,7 @@ describe Mongoid::Interceptable do
         book.pages.each do | page |
           page.notes.destroy_all
           page.notes.new(message: new_message)
-          page.save
+          page.save!
         end
       end
 
@@ -272,7 +283,7 @@ describe Mongoid::Interceptable do
 
       before do
         expect(artist).to receive(:before_create_stub).once.and_return(true)
-        artist.save
+        artist.save!
       end
 
       it "gets saved" do
@@ -317,7 +328,7 @@ describe Mongoid::Interceptable do
         end
 
         it "the save returns true" do
-          expect(artist.save).to be true
+          expect(artist.save!).to be true
         end
       end
 
@@ -341,7 +352,7 @@ describe Mongoid::Interceptable do
     context "when updating" do
 
       let(:artist) do
-        Artist.create(name: "Depeche Mode").tap do |artist|
+        Artist.create!(name: "Depeche Mode").tap do |artist|
           artist.name = "The Mountain Goats"
         end
       end
@@ -357,7 +368,7 @@ describe Mongoid::Interceptable do
         end
 
         it "the save returns true" do
-          expect(artist.save).to be true
+          expect(artist.save!).to be true
         end
       end
 
@@ -382,7 +393,7 @@ describe Mongoid::Interceptable do
   describe ".before_destroy" do
 
     let(:artist) do
-      Artist.create(name: "Depeche Mode")
+      Artist.create!(name: "Depeche Mode")
     end
 
     before do
@@ -427,7 +438,7 @@ describe Mongoid::Interceptable do
       end
 
       let!(:record) do
-        moderat.records.create(name: "Moderat")
+        moderat.records.create!(name: "Moderat")
       end
 
       before do
@@ -526,6 +537,8 @@ describe Mongoid::Interceptable do
           end
 
           after(:all) do
+            # ActiveSupport may raise an error when trying to reset callbacks on all of Band's
+            # descendants, regardless of whether they have a particular callback defined.
             begin; Band.reset_callbacks(:rearrange); rescue; end
           end
 
@@ -539,7 +552,7 @@ describe Mongoid::Interceptable do
 
           it "does not cascade to the child" do
             Band.accepts_nested_attributes_for :records, allow_destroy: true
-            expect(band.update_attributes(attributes)).to be true
+            expect(band.update_attributes!(attributes)).to be true
           end
         end
       end
@@ -570,7 +583,7 @@ describe Mongoid::Interceptable do
 
           it "only executes the callbacks once for each embed" do
             expect(note).to receive(:update_saved).twice
-            band.save
+            band.save!
           end
         end
       end
@@ -579,7 +592,7 @@ describe Mongoid::Interceptable do
     context "when cascading after initialize" do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       before do
@@ -597,7 +610,7 @@ describe Mongoid::Interceptable do
       it "raises an error" do
         expect {
           Band.has_and_belongs_to_many :tags, cascade_callbacks: true
-        }.to raise_error(Mongoid::Errors::InvalidOptions)
+        }.to raise_error(Mongoid::Errors::InvalidRelationOption)
       end
     end
 
@@ -618,7 +631,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -629,7 +642,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:label) do
@@ -637,7 +650,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -649,7 +662,7 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:label) do
@@ -658,7 +671,7 @@ describe Mongoid::Interceptable do
 
           before do
             label.after_create_called = false
-            band.save
+            band.save!
           end
 
           it "does not execute the callback" do
@@ -682,7 +695,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -693,7 +706,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:label) do
@@ -701,7 +714,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -713,7 +726,7 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:label) do
@@ -721,7 +734,7 @@ describe Mongoid::Interceptable do
           end
 
           before do
-            band.save
+            band.save!
           end
 
           it "executes the callback" do
@@ -745,7 +758,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "does not execute the callback" do
@@ -756,7 +769,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:label) do
@@ -764,7 +777,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "does not execute the callback" do
@@ -776,7 +789,7 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           context "when the child is dirty" do
@@ -787,7 +800,7 @@ describe Mongoid::Interceptable do
 
             before do
               label.name = "Nothing"
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -802,7 +815,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "does not execute the callback" do
@@ -827,7 +840,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -838,7 +851,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:label) do
@@ -846,7 +859,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -858,7 +871,7 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:label) do
@@ -866,7 +879,7 @@ describe Mongoid::Interceptable do
           end
 
           before do
-            band.save
+            band.save!
           end
 
           it "executes the callback" do
@@ -890,7 +903,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -901,7 +914,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:record) do
@@ -909,7 +922,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -921,16 +934,16 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:record) do
-            band.records.create(name: "Moderat")
+            band.records.create!(name: "Moderat")
           end
 
           before do
             record.before_create_called = false
-            band.save
+            band.save!
           end
 
           it "does not execute the callback" do
@@ -954,7 +967,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -969,7 +982,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:record) do
@@ -977,7 +990,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -993,15 +1006,15 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:record) do
-            band.records.create(name: "Moderat")
+            band.records.create!(name: "Moderat")
           end
 
           before do
-            band.save
+            band.save!
           end
 
           it "executes the callback" do
@@ -1016,7 +1029,7 @@ describe Mongoid::Interceptable do
         context "when the child is created" do
 
           let!(:band) do
-            Band.create
+            Band.create!
           end
 
           let!(:label) do
@@ -1044,7 +1057,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "does not execute the callback" do
@@ -1055,7 +1068,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:record) do
@@ -1063,7 +1076,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "does not execute the callback" do
@@ -1075,18 +1088,18 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:record) do
-            band.records.create(name: "Moderat")
+            band.records.create!(name: "Moderat")
           end
 
           context "when the child is dirty" do
 
             before do
               record.name = "Nothing"
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -1101,7 +1114,7 @@ describe Mongoid::Interceptable do
           context "when the child is not dirty" do
 
             before do
-              band.save
+              band.save!
             end
 
             it "does not execute the callback" do
@@ -1126,7 +1139,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -1141,7 +1154,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:record) do
@@ -1149,7 +1162,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -1164,7 +1177,7 @@ describe Mongoid::Interceptable do
           context 'when the parent is updated' do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             before do
@@ -1181,18 +1194,37 @@ describe Mongoid::Interceptable do
           end
         end
 
+        context 'when the parent is updated' do
+
+          let(:band) do
+            Band.create!(name: "Moderat")
+          end
+
+          before do
+            band.update(records: [ { name: 'Black on Both Sides' }])
+          end
+
+          it 'executes the callback' do
+            expect(band.records.first.before_validation_called).to be true
+          end
+
+          it 'persists the change' do
+            expect(band.reload.records.first.before_validation_called).to be true
+          end
+        end
+
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:record) do
-            band.records.create(name: "Moderat")
+            band.records.create!(name: "Moderat")
           end
 
           before do
-            band.save
+            band.save!
           end
 
           it "executes the callback" do
@@ -1227,7 +1259,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -1238,7 +1270,7 @@ describe Mongoid::Interceptable do
           context "when the root is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:record) do
@@ -1250,7 +1282,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -1262,20 +1294,20 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:record) do
-            band.records.create(name: "Moderat")
+            band.records.create!(name: "Moderat")
           end
 
           let!(:track) do
-            record.tracks.create(name: "Berlin")
+            record.tracks.create!(name: "Berlin")
           end
 
           before do
             track.before_create_called = false
-            band.save
+            band.save!
           end
 
           it "does not execute the callback" do
@@ -1303,7 +1335,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             let(:reloaded) do
@@ -1322,7 +1354,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:record) do
@@ -1334,7 +1366,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             let(:reloaded) do
@@ -1354,19 +1386,19 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:record) do
-            band.records.create(name: "Moderat")
+            band.records.create!(name: "Moderat")
           end
 
           let!(:track) do
-            record.tracks.create(name: "Berlin")
+            record.tracks.create!(name: "Berlin")
           end
 
           before do
-            band.save
+            band.save!
           end
 
           let(:reloaded) do
@@ -1402,7 +1434,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "does not execute the callback" do
@@ -1413,7 +1445,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:record) do
@@ -1425,7 +1457,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "does not execute the callback" do
@@ -1437,22 +1469,22 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:record) do
-            band.records.create(name: "Moderat")
+            band.records.create!(name: "Moderat")
           end
 
           let!(:track) do
-            record.tracks.create(name: "Berlin")
+            record.tracks.create!(name: "Berlin")
           end
 
           context "when the child is dirty" do
 
             before do
               track.name = "Rusty Nails"
-              band.save
+              band.save!
             end
 
             let(:reloaded) do
@@ -1471,7 +1503,7 @@ describe Mongoid::Interceptable do
           context "when the child is not dirty" do
 
             before do
-              band.save
+              band.save!
             end
 
             it "does not execute the callback" do
@@ -1519,7 +1551,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -1530,7 +1562,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:record) do
@@ -1542,7 +1574,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -1554,19 +1586,19 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:record) do
-            band.records.create(name: "Moderat")
+            band.records.create!(name: "Moderat")
           end
 
           let!(:track) do
-            record.tracks.create(name: "Berlin")
+            record.tracks.create!(name: "Berlin")
           end
 
           before do
-            band.save
+            band.save!
           end
 
           it "executes the callback" do
@@ -1593,11 +1625,11 @@ describe Mongoid::Interceptable do
     end
 
     before do
-      parent.save
+      parent.save!
     end
 
     it "does not duplicate the child documents" do
-      parent.children.create(position: 1)
+      parent.children.create!(position: 1)
       expect(ParentDoc.find(parent.id).children.size).to eq(1)
     end
   end
@@ -1648,7 +1680,7 @@ describe Mongoid::Interceptable do
     context "when updating a document" do
 
       let(:person) do
-        Person.create.tap do |person|
+        Person.create!.tap do |person|
           person.attributes = {
             mode: :prevent_save,
             title: "Associate",
@@ -1682,8 +1714,8 @@ describe Mongoid::Interceptable do
   context "when loading a model multiple times" do
 
     before do
-      load "spec/app/models/callback_test.rb"
-      load "spec/app/models/callback_test.rb"
+      load File.join(MODELS, "callback_test.rb")
+      load File.join(MODELS, "callback_test.rb")
     end
 
     let(:callback) do
@@ -1698,4 +1730,65 @@ describe Mongoid::Interceptable do
       end
     end
   end
+
+  context 'when creating a parent and embedded child' do
+    let(:registry) { InterceptableSpec::CallbackRegistry.new }
+    let(:parent) do
+      InterceptableSpec::CbParent.new(registry).tap do |parent|
+        parent.cb_children << InterceptableSpec::CbChild.new(registry, cb_parent: parent)
+      end
+    end
+
+    let(:expected) do
+      [
+        [InterceptableSpec::CbParent, :before_validation],
+        [InterceptableSpec::CbChild, :before_validation],
+        [InterceptableSpec::CbChild, :after_validation],
+        [InterceptableSpec::CbParent, :after_validation],
+        [InterceptableSpec::CbParent, :before_save],
+        [InterceptableSpec::CbParent, :before_create],
+        [InterceptableSpec::CbParent, :after_create],
+        [InterceptableSpec::CbParent, :after_save],
+      ]
+    end
+
+    it 'calls callbacks in the right order' do
+      parent.save!
+      expect(registry.calls).to eq expected
+    end
+  end
+
+  context 'when creating a parent and embedded child with cascading callbacks' do
+    let(:registry) { InterceptableSpec::CallbackRegistry.new }
+    let(:parent) do
+      InterceptableSpec::CbParent.new(registry).tap do |parent|
+        parent.cb_cascaded_children <<
+          InterceptableSpec::CbCascadedChild.new(registry, cb_parent: parent)
+      end
+    end
+
+    let(:expected) do
+      [
+        [InterceptableSpec::CbParent, :before_validation],
+        [InterceptableSpec::CbCascadedChild, :before_validation],
+        [InterceptableSpec::CbCascadedChild, :after_validation],
+        [InterceptableSpec::CbParent, :after_validation],
+        [InterceptableSpec::CbParent, :before_save],
+        [InterceptableSpec::CbCascadedChild, :before_save],
+        [InterceptableSpec::CbParent, :before_create],
+        [InterceptableSpec::CbCascadedChild, :before_create],
+        [InterceptableSpec::CbParent, :after_create],
+        [InterceptableSpec::CbCascadedChild, :after_create],
+        [InterceptableSpec::CbParent, :after_save],
+        [InterceptableSpec::CbCascadedChild, :after_save],
+      ]
+    end
+
+    it 'calls callbacks in the right order' do
+      pending 'MONGOID-3795'
+
+      parent.save!
+      expect(registry.calls).to eq expected
+    end
+  end
 end