mongoid 6.4.4 → 7.5.1

data/spec/mongoid/extensions/hash_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Hash do
@@ -230,10 +232,27 @@ describe Mongoid::Extensions::Hash do
     it "should retrieve a nested value under the provided key" do
       expect(nested).to eq "hundred"
     end
+
+    context 'and the value is falsey' do
+      let(:hash) do
+        { "100" => { "name" => false } }
+      end
+      it "should retrieve the falsey nested value under the provided key" do
+        expect(nested).to eq false
+      end
+    end
+
+    context 'and the value is nil' do
+      let(:hash) do
+        { "100" => { 0 => "Please don't return this value!" } }
+      end
+      it "should retrieve the nil nested value under the provided key" do
+        expect(nested).to eq nil
+      end
+    end
   end
 
   context "when the hash key is an integer" do
-
     let(:hash) do
       { 100 => { "name" => "hundred" } }
     end
@@ -345,4 +364,107 @@ describe Mongoid::Extensions::Hash do
       expect(Hash).to be_resizable
     end
   end
+
+  shared_examples_for 'unsatisfiable criteria method' do
+
+    context "when the hash has only an empty _id criteria" do
+
+      let(:hash) do
+        { "_id" => { "$in" => [] }}
+      end
+
+      it "is true" do
+        expect(hash.send(meth)).to be true
+      end
+    end
+
+    context "when the hash has an empty _id criteria and another criteria" do
+
+      let(:hash) do
+        { "_id" => { "$in" => [] }, 'foo' => 'bar'}
+      end
+
+      it "is false" do
+        expect(hash.send(meth)).to be false
+      end
+    end
+
+    context "when the hash has an empty _id criteria via $and" do
+
+      let(:hash) do
+        {'$and' => [{ "_id" => { "$in" => [] }}]}
+      end
+
+      it "is true" do
+        expect(hash.send(meth)).to be true
+      end
+    end
+
+    context "when the hash has an empty _id criteria via $and and another criteria at top level" do
+
+      let(:hash) do
+        {'$and' => [{ "_id" => { "$in" => [] }}], 'foo' => 'bar'}
+      end
+
+      it "is false" do
+        expect(hash.send(meth)).to be false
+      end
+    end
+
+    context "when the hash has an empty _id criteria via $and and another criteria in $and" do
+
+      let(:hash) do
+        {'$and' => [{ "_id" => { "$in" => [] }}, {'foo' => 'bar'}]}
+      end
+
+      it "is true" do
+        expect(hash.send(meth)).to be true
+      end
+    end
+
+    context "when the hash has an empty _id criteria via $and and another criteria in $and value" do
+
+      let(:hash) do
+        {'$and' => [{ "_id" => { "$in" => [] }, 'foo' => 'bar'}]}
+      end
+
+      it "is false" do
+        expect(hash.send(meth)).to be false
+      end
+    end
+
+    context "when the hash has an empty _id criteria via $or" do
+
+      let(:hash) do
+        {'$or' => [{ "_id" => { "$in" => [] }}]}
+      end
+
+      it "is false" do
+        expect(hash.send(meth)).to be false
+      end
+    end
+
+    context "when the hash has an empty _id criteria via $nor" do
+
+      let(:hash) do
+        {'$nor' => [{ "_id" => { "$in" => [] }}]}
+      end
+
+      it "is false" do
+        expect(hash.send(meth)).to be false
+      end
+    end
+  end
+
+  describe "#blank_criteria?" do
+    let(:meth) { :blank_criteria? }
+
+    it_behaves_like 'unsatisfiable criteria method'
+  end
+
+  describe "#_mongoid_unsatisfiable_criteria?" do
+    let(:meth) { :_mongoid_unsatisfiable_criteria? }
+
+    it_behaves_like 'unsatisfiable criteria method'
+  end
 end

data/spec/mongoid/extensions/integer_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Integer do
@@ -16,8 +18,18 @@ describe Mongoid::Extensions::Integer do
       integer.__mongoize_time__
     end
 
-    it "returns the float as a time" do
-      expect(mongoized).to eq(Time.at(integer))
+    let(:expected_time) { Time.at(integer).in_time_zone }
+
+    context "when using active support's time zone" do
+      include_context 'using AS time zone'
+
+      it_behaves_like 'mongoizes to AS::TimeWithZone'
+    end
+
+    context "when not using active support's time zone" do
+      include_context 'not using AS time zone'
+
+      it_behaves_like 'mongoizes to Time'
     end
   end
 

data/spec/mongoid/extensions/module_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Module do

data/spec/mongoid/extensions/nil_class_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Extensions::NilClass do

data/spec/mongoid/extensions/object_id_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Extensions::ObjectId do

data/spec/mongoid/extensions/object_spec.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Object do
 
-  describe "#__evolve_object_id__" do
+  let(:object) do
+    Object.new
+  end
 
-    let(:object) do
-      Object.new
-    end
+  describe "#__evolve_object_id__" do
 
     it "returns self" do
       expect(object.__evolve_object_id__).to eq(object)
@@ -15,10 +17,6 @@ describe Mongoid::Extensions::Object do
 
   describe "#__find_args__" do
 
-    let(:object) do
-      Object.new
-    end
-
     it "returns self" do
       expect(object.__find_args__).to eq(object)
     end
@@ -26,10 +24,6 @@ describe Mongoid::Extensions::Object do
 
   describe "#__mongoize_object_id__" do
 
-    let(:object) do
-      Object.new
-    end
-
     it "returns self" do
       expect(object.__mongoize_object_id__).to eq(object)
     end
@@ -39,14 +33,10 @@ describe Mongoid::Extensions::Object do
 
     context "when the related model uses object ids" do
 
-      let(:metadata) do
+      let(:association) do
         Game.relations["person"]
       end
 
-      let(:constraint) do
-        metadata.constraint
-      end
-
       context "when provided an object id" do
 
         let(:object_id) do
@@ -54,7 +44,7 @@ describe Mongoid::Extensions::Object do
         end
 
         let(:fk) do
-          Object.__mongoize_fk__(constraint, object_id)
+          Object.__mongoize_fk__(association, object_id)
         end
 
         it "returns the object id" do
@@ -71,7 +61,7 @@ describe Mongoid::Extensions::Object do
           end
 
           let(:fk) do
-            Object.__mongoize_fk__(constraint, object_id.to_s)
+            Object.__mongoize_fk__(association, object_id.to_s)
           end
 
           it "returns the object id" do
@@ -86,7 +76,7 @@ describe Mongoid::Extensions::Object do
           end
 
           let(:fk) do
-            Object.__mongoize_fk__(constraint, string)
+            Object.__mongoize_fk__(association, string)
           end
 
           it "returns the string" do
@@ -97,7 +87,7 @@ describe Mongoid::Extensions::Object do
         context "when the string is blank" do
 
           let(:fk) do
-            Object.__mongoize_fk__(constraint, "")
+            Object.__mongoize_fk__(association, "")
           end
 
           it "returns nil" do
@@ -109,7 +99,7 @@ describe Mongoid::Extensions::Object do
       context "when provided nil" do
 
         let(:fk) do
-          Object.__mongoize_fk__(constraint, nil)
+          Object.__mongoize_fk__(association, nil)
         end
 
         it "returns nil" do
@@ -120,7 +110,7 @@ describe Mongoid::Extensions::Object do
       context "when provided an empty array" do
 
         let(:fk) do
-          Object.__mongoize_fk__(constraint, [])
+          Object.__mongoize_fk__(association, [])
         end
 
         it "returns an empty array" do
@@ -132,10 +122,6 @@ describe Mongoid::Extensions::Object do
 
   describe "#__mongoize_time__" do
 
-    let(:object) do
-      Object.new
-    end
-
     it "returns self" do
       expect(object.__mongoize_time__).to eq(object)
     end
@@ -143,10 +129,6 @@ describe Mongoid::Extensions::Object do
 
   describe "#__sortable__" do
 
-    let(:object) do
-      Object.new
-    end
-
     it "returns self" do
       expect(object.__sortable__).to eq(object)
     end
@@ -292,12 +274,15 @@ describe Mongoid::Extensions::Object do
 
   describe "#numeric?" do
 
-    let(:object) do
-      Object.new
-    end
-
     it "returns false" do
       expect(object.numeric?).to eq(false)
     end
   end
+
+  describe "#blank_criteria?" do
+
+    it "is false" do
+      expect(object.blank_criteria?).to be false
+    end
+  end
 end

data/spec/mongoid/extensions/range_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Range do
@@ -139,6 +141,13 @@ describe Mongoid::Extensions::Range do
         expect(("a".."z").mongoize).to eq({ "min" => "a", "max" => "z" })
       end
     end
+
+    context 'when the value is a string' do
+
+      it 'returns a string' do
+        expect(Range.mongoize('3')).to eq('3')
+      end
+    end
   end
 
   describe "#resizable?" do

data/spec/mongoid/extensions/regexp_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Regexp do

data/spec/mongoid/extensions/set_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Set do

data/spec/mongoid/extensions/string_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Extensions::String do
@@ -69,33 +71,47 @@ describe Mongoid::Extensions::String do
   describe "#__mongoize_time__" do
 
     context "when using active support's time zone" do
+      include_context 'using AS time zone'
 
-      before do
-        Mongoid.use_activesupport_time_zone = true
-        ::Time.zone = "Tokyo"
-      end
+      context "when the string is a valid time with time zone" do
+
+        let(:string) do
+          # JST is +0900
+          "2010-11-19 00:24:49.123457 +1100"
+        end
+
+        let(:mongoized) do
+          string.__mongoize_time__
+        end
+
+        let(:expected_time) { Time.parse("2010-11-18 13:24:49.123457 +0000").in_time_zone }
 
-      after do
-        ::Time.zone = "Berlin"
+        it "converts to the AS time zone" do
+          expect(mongoized.zone).to eq("JST")
+        end
+
+        it_behaves_like 'mongoizes to AS::TimeWithZone'
+        it_behaves_like 'maintains precision when mongoized'
       end
 
-      context "when the string is a valid time" do
+      context "when the string is a valid time without time zone" do
 
         let(:string) do
-          "2010-11-19 00:24:49 +0900"
+          "2010-11-19 00:24:49.123457"
         end
 
-        let(:time) do
+        let(:mongoized) do
           string.__mongoize_time__
         end
 
-        it "converts to a time" do
-          expect(time).to eq(Time.configured.parse(string))
-        end
+        let(:expected_time) { Time.parse("2010-11-18 15:24:49.123457 +0000").in_time_zone }
 
-        it "converts to the as time zone" do
-          expect(time.zone).to eq("JST")
+        it "converts to the AS time zone" do
+          expect(mongoized.zone).to eq("JST")
         end
+
+        it_behaves_like 'mongoizes to AS::TimeWithZone'
+        it_behaves_like 'maintains precision when mongoized'
       end
 
       context "when the string is an invalid time" do
@@ -113,29 +129,46 @@ describe Mongoid::Extensions::String do
     end
 
     context "when not using active support's time zone" do
+      include_context 'not using AS time zone'
 
-      before do
-        Mongoid.use_activesupport_time_zone = false
-      end
+      context "when the string is a valid time with time zone" do
+
+        let(:string) do
+          "2010-11-19 00:24:49.123457 +1100"
+        end
+
+        let(:expected_time) { Time.parse("2010-11-18 13:24:49.123457 +0000").in_time_zone }
 
-      after do
-        Mongoid.use_activesupport_time_zone = true
-        Time.zone = nil
+        let(:mongoized) do
+          string.__mongoize_time__
+        end
+
+        it_behaves_like 'mongoizes to Time'
+        it_behaves_like 'maintains precision when mongoized'
       end
 
-      context "when the string is a valid time" do
+      context "when the string is a valid time without time zone" do
 
         let(:string) do
-          "2010-11-19 00:24:49 +0900"
+          "2010-11-19 00:24:49.123457"
+        end
+
+        let(:utc_offset) do
+          Time.now.utc_offset
         end
 
-        let(:time) do
+        let(:expected_time) { Time.parse("2010-11-19 00:24:49.123457 +0000") - Time.parse(string).utc_offset }
+
+        let(:mongoized) do
           string.__mongoize_time__
         end
 
-        it "converts to a time" do
-          expect(time).to eq(Time.parse(string))
+        it 'test operates in multiple time zones' do
+          expect(utc_offset).not_to eq(Time.zone.now.utc_offset)
         end
+
+        it_behaves_like 'mongoizes to Time'
+        it_behaves_like 'maintains precision when mongoized'
       end
 
       context "when the string is an invalid time" do
@@ -163,14 +196,14 @@ describe Mongoid::Extensions::String do
         end
       end
 
-      it "returns an underscored tableized name" do
+      it "returns an underscored table-ized name" do
         expect(Medical::Patient.name.collectionize).to eq("medical_patients")
       end
     end
 
     context "when class is not namespaced" do
 
-      it "returns an underscored tableized name" do
+      it "returns an underscored table-ized name" do
         expect(MixedDrink.name.collectionize).to eq("mixed_drinks")
       end
     end
@@ -277,49 +310,77 @@ describe Mongoid::Extensions::String do
     context "when the string is an integer" do
 
       it "returns true" do
-        expect("1234").to be_numeric
+        expect("1234".numeric?).to eq(true)
       end
     end
 
     context "when string is a float" do
 
       it "returns true" do
-        expect("1234.123").to be_numeric
+        expect("1234.123".numeric?).to eq(true)
       end
     end
 
     context "when the string is has exponents" do
 
       it "returns true" do
-        expect("1234.123123E4").to be_numeric
+        expect("1234.123123E4".numeric?).to eq(true)
       end
     end
 
     context "when the string is non numeric" do
 
       it "returns false" do
-        expect("blah").to_not be_numeric
+        expect("blah".numeric?).to eq(false)
       end
     end
 
     context "when the string is NaN" do
 
       it "returns true" do
-        expect("NaN").to be_numeric
+        expect("NaN".numeric?).to eq(true)
+      end
+    end
+
+    context "when the string is NaN and junk in front" do
+
+      it "returns false" do
+        expect("a\nNaN".numeric?).to eq(false)
+      end
+    end
+
+    context "when the string is NaN and whitespace at end" do
+
+      it "returns false" do
+        expect("NaN\n".numeric?).to eq(false)
       end
     end
 
     context "when the string is Infinity" do
 
       it "returns true" do
-        expect("Infinity").to be_numeric
+        expect("Infinity".numeric?).to eq(true)
+      end
+    end
+
+    context "when the string contains Infinity and junk in front" do
+
+      it "returns false" do
+        expect("a\nInfinity".numeric?).to eq(false)
+      end
+    end
+
+    context "when the string contains Infinity and whitespace at end" do
+
+      it "returns false" do
+        expect("Infinity\n".numeric?).to eq(false)
       end
     end
 
     context "when the string is -Infinity" do
 
       it "returns true" do
-        expect("-Infinity").to be_numeric
+        expect("-Infinity".numeric?).to eq(true)
       end
     end
   end

data/spec/mongoid/extensions/stringified_symbol_spec.rb

@@ -0,0 +1,84 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Mongoid::StringifiedSymbol do
+
+  describe ".demongoize" do
+
+    context "when the object is not a symbol" do
+
+      it "returns the symbol" do
+        expect(Mongoid::StringifiedSymbol.demongoize("test")).to eq(:test)
+      end
+    end
+
+    context "when the object is a symbol" do
+
+      it "returns the symbol" do
+        expect(Mongoid::StringifiedSymbol.demongoize(:test)).to eq(:test)
+      end
+    end
+
+    context "when the object is a BSON Symbol" do
+
+      it "returns a symbol" do
+        expect(Mongoid::StringifiedSymbol.demongoize(BSON::Symbol::Raw.new(:test))).to eq(:test)
+      end
+    end
+
+
+    context "when the object is an integer" do
+
+      it "returns a symbol" do
+        expect(Mongoid::StringifiedSymbol.demongoize(14)).to eq(:"14")
+      end
+    end
+
+    context "when the object is nil" do
+
+      it "returns nil" do
+        expect(Mongoid::StringifiedSymbol.demongoize(nil)).to be_nil
+      end
+    end
+  end
+
+  describe ".mongoize" do
+
+    context "when the object is not a symbol" do
+
+      it "returns the object" do
+        expect(Mongoid::StringifiedSymbol.mongoize("test")).to eq("test")
+      end
+
+      it "returns the string" do
+        expect(Mongoid::StringifiedSymbol.mongoize([0,1,2])).to eq("[0, 1, 2]")
+      end
+
+      it "returns the string" do
+        expect(Mongoid::StringifiedSymbol.mongoize(2)).to eq("2")
+      end
+    end
+
+    context "when the object is a symbol" do
+
+      it "returns a string" do
+        expect(Mongoid::StringifiedSymbol.mongoize(:test)).to eq("test")
+      end
+    end
+
+    context "when the object is nil" do
+
+      it "returns nil" do
+        expect(Mongoid::StringifiedSymbol.mongoize(nil)).to be_nil
+      end
+    end
+  end
+
+  describe "#mongoize" do
+
+    it "returns self" do
+      expect(:test.mongoize).to eq(:test)
+    end
+  end
+end

data/spec/mongoid/extensions/symbol_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Symbol do