mongoid 6.4.4 → 7.1.7

data/spec/mongoid/extensions/date_time_spec.rb

@@ -1,78 +1,36 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Extensions::DateTime do
 
   describe "__mongoize_time__" do
 
-    context "when the date time has more than seconds precision" do
-
-      let(:date_time) do
-        DateTime.parse("2012-06-17 18:42:15.123Z")
-      end
-
-      let(:mongoized) do
-        date_time.__mongoize_time__
-      end
-
-      it "does not drop the precision" do
-        expect(mongoized.to_f.to_s).to match(/\.123/)
-      end
+    let(:date_time) do
+      # DateTime has time zone information, even if a time zone is not provided
+      # when parsing a string
+      DateTime.parse("2012-06-17 18:42:15.123457")
     end
 
-    context "when using active support's time zone" do
-
-      before do
-        Mongoid.use_activesupport_time_zone = true
-        Time.zone = "Tokyo"
-      end
-
-      after do
-        Time.zone = nil
-      end
+    let(:mongoized) do
+      date_time.__mongoize_time__
+    end
 
-      let(:date_time) do
-        DateTime.new(2010, 1, 1)
-      end
+    let(:expected_time) { date_time.to_time.in_time_zone }
 
-      let(:expected) do
-        Time.zone.local(2010, 1, 1, 9, 0, 0, 0)
-      end
-
-      let(:mongoized) do
-        date_time.__mongoize_time__
-      end
+    context "when using active support's time zone" do
+      include_context 'using AS time zone'
 
-      it "returns the date as a local time" do
-        expect(mongoized).to eq(expected)
-      end
+      it_behaves_like 'mongoizes to AS::TimeWithZone'
+      it_behaves_like 'maintains precision when mongoized'
     end
 
     context "when not using active support's time zone" do
+      include_context 'not using AS time zone'
 
-      before do
-        Mongoid.use_activesupport_time_zone = false
-      end
-
-      after do
-        Mongoid.use_activesupport_time_zone = true
-        Time.zone = nil
-      end
-
-      let(:date_time) do
-        DateTime.new(2010, 1, 1)
-      end
-
-      let(:expected) do
-        Time.utc(2010, 1, 1, 0, 0, 0, 0).getlocal
-      end
-
-      let(:mongoized) do
-        date_time.__mongoize_time__
-      end
-
-      it "returns the date as a utc time" do
-        expect(mongoized).to eq(expected)
-      end
+      it_behaves_like 'mongoizes to Time'
+      it_behaves_like 'maintains precision when mongoized'
     end
   end
 

data/spec/mongoid/extensions/decimal128_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Decimal128 do

data/spec/mongoid/extensions/false_class_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Extensions::FalseClass do

data/spec/mongoid/extensions/float_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Float do
@@ -9,15 +12,27 @@ describe Mongoid::Extensions::Float do
   describe "#__mongoize_time__" do
 
     let(:float) do
-      1335532685.117847
+      1335532685.123457
     end
 
     let(:mongoized) do
       float.__mongoize_time__
     end
 
-    it "returns the float as a time" do
-      expect(mongoized).to eq(Time.at(float))
+    let(:expected_time) { Time.at(float).in_time_zone }
+
+    context "when using active support's time zone" do
+      include_context 'using AS time zone'
+
+      it_behaves_like 'mongoizes to AS::TimeWithZone'
+      it_behaves_like 'maintains precision when mongoized'
+    end
+
+    context "when not using active support's time zone" do
+      include_context 'not using AS time zone'
+
+      it_behaves_like 'mongoizes to Time'
+      it_behaves_like 'maintains precision when mongoized'
     end
   end
 

data/spec/mongoid/extensions/hash_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Hash do
@@ -230,10 +233,27 @@ describe Mongoid::Extensions::Hash do
     it "should retrieve a nested value under the provided key" do
       expect(nested).to eq "hundred"
     end
+
+    context 'and the value is falsey' do
+      let(:hash) do
+        { "100" => { "name" => false } }
+      end
+      it "should retrieve the falsey nested value under the provided key" do
+        expect(nested).to eq false
+      end
+    end
+
+    context 'and the value is nil' do
+      let(:hash) do
+        { "100" => { 0 => "Please don't return this value!" } }
+      end
+      it "should retrieve the nil nested value under the provided key" do
+        expect(nested).to eq nil
+      end
+    end
   end
 
   context "when the hash key is an integer" do
-
     let(:hash) do
       { 100 => { "name" => "hundred" } }
     end
@@ -345,4 +365,107 @@ describe Mongoid::Extensions::Hash do
       expect(Hash).to be_resizable
     end
   end
+
+  shared_examples_for 'unsatisfiable criteria method' do
+
+    context "when the hash has only an empty _id criteria" do
+
+      let(:hash) do
+        { "_id" => { "$in" => [] }}
+      end
+
+      it "is true" do
+        expect(hash.send(meth)).to be true
+      end
+    end
+
+    context "when the hash has an empty _id criteria and another criteria" do
+
+      let(:hash) do
+        { "_id" => { "$in" => [] }, 'foo' => 'bar'}
+      end
+
+      it "is false" do
+        expect(hash.send(meth)).to be false
+      end
+    end
+
+    context "when the hash has an empty _id criteria via $and" do
+
+      let(:hash) do
+        {'$and' => [{ "_id" => { "$in" => [] }}]}
+      end
+
+      it "is true" do
+        expect(hash.send(meth)).to be true
+      end
+    end
+
+    context "when the hash has an empty _id criteria via $and and another criteria at top level" do
+
+      let(:hash) do
+        {'$and' => [{ "_id" => { "$in" => [] }}], 'foo' => 'bar'}
+      end
+
+      it "is false" do
+        expect(hash.send(meth)).to be false
+      end
+    end
+
+    context "when the hash has an empty _id criteria via $and and another criteria in $and" do
+
+      let(:hash) do
+        {'$and' => [{ "_id" => { "$in" => [] }}, {'foo' => 'bar'}]}
+      end
+
+      it "is true" do
+        expect(hash.send(meth)).to be true
+      end
+    end
+
+    context "when the hash has an empty _id criteria via $and and another criteria in $and value" do
+
+      let(:hash) do
+        {'$and' => [{ "_id" => { "$in" => [] }, 'foo' => 'bar'}]}
+      end
+
+      it "is false" do
+        expect(hash.send(meth)).to be false
+      end
+    end
+
+    context "when the hash has an empty _id criteria via $or" do
+
+      let(:hash) do
+        {'$or' => [{ "_id" => { "$in" => [] }}]}
+      end
+
+      it "is false" do
+        expect(hash.send(meth)).to be false
+      end
+    end
+
+    context "when the hash has an empty _id criteria via $nor" do
+
+      let(:hash) do
+        {'$nor' => [{ "_id" => { "$in" => [] }}]}
+      end
+
+      it "is false" do
+        expect(hash.send(meth)).to be false
+      end
+    end
+  end
+
+  describe "#blank_criteria?" do
+    let(:meth) { :blank_criteria? }
+
+    it_behaves_like 'unsatisfiable criteria method'
+  end
+
+  describe "#_mongoid_unsatisfiable_criteria?" do
+    let(:meth) { :_mongoid_unsatisfiable_criteria? }
+
+    it_behaves_like 'unsatisfiable criteria method'
+  end
 end

data/spec/mongoid/extensions/integer_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Integer do
@@ -16,8 +19,18 @@ describe Mongoid::Extensions::Integer do
       integer.__mongoize_time__
     end
 
-    it "returns the float as a time" do
-      expect(mongoized).to eq(Time.at(integer))
+    let(:expected_time) { Time.at(integer).in_time_zone }
+
+    context "when using active support's time zone" do
+      include_context 'using AS time zone'
+
+      it_behaves_like 'mongoizes to AS::TimeWithZone'
+    end
+
+    context "when not using active support's time zone" do
+      include_context 'not using AS time zone'
+
+      it_behaves_like 'mongoizes to Time'
     end
   end
 

data/spec/mongoid/extensions/module_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Module do

data/spec/mongoid/extensions/nil_class_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Extensions::NilClass do

data/spec/mongoid/extensions/object_id_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Extensions::ObjectId do

data/spec/mongoid/extensions/object_spec.rb

@@ -1,12 +1,15 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Object do
 
-  describe "#__evolve_object_id__" do
+  let(:object) do
+    Object.new
+  end
 
-    let(:object) do
-      Object.new
-    end
+  describe "#__evolve_object_id__" do
 
     it "returns self" do
       expect(object.__evolve_object_id__).to eq(object)
@@ -15,10 +18,6 @@ describe Mongoid::Extensions::Object do
 
   describe "#__find_args__" do
 
-    let(:object) do
-      Object.new
-    end
-
     it "returns self" do
       expect(object.__find_args__).to eq(object)
     end
@@ -26,10 +25,6 @@ describe Mongoid::Extensions::Object do
 
   describe "#__mongoize_object_id__" do
 
-    let(:object) do
-      Object.new
-    end
-
     it "returns self" do
       expect(object.__mongoize_object_id__).to eq(object)
     end
@@ -39,14 +34,10 @@ describe Mongoid::Extensions::Object do
 
     context "when the related model uses object ids" do
 
-      let(:metadata) do
+      let(:association) do
         Game.relations["person"]
       end
 
-      let(:constraint) do
-        metadata.constraint
-      end
-
       context "when provided an object id" do
 
         let(:object_id) do
@@ -54,7 +45,7 @@ describe Mongoid::Extensions::Object do
         end
 
         let(:fk) do
-          Object.__mongoize_fk__(constraint, object_id)
+          Object.__mongoize_fk__(association, object_id)
         end
 
         it "returns the object id" do
@@ -71,7 +62,7 @@ describe Mongoid::Extensions::Object do
           end
 
           let(:fk) do
-            Object.__mongoize_fk__(constraint, object_id.to_s)
+            Object.__mongoize_fk__(association, object_id.to_s)
           end
 
           it "returns the object id" do
@@ -86,7 +77,7 @@ describe Mongoid::Extensions::Object do
           end
 
           let(:fk) do
-            Object.__mongoize_fk__(constraint, string)
+            Object.__mongoize_fk__(association, string)
           end
 
           it "returns the string" do
@@ -97,7 +88,7 @@ describe Mongoid::Extensions::Object do
         context "when the string is blank" do
 
           let(:fk) do
-            Object.__mongoize_fk__(constraint, "")
+            Object.__mongoize_fk__(association, "")
           end
 
           it "returns nil" do
@@ -109,7 +100,7 @@ describe Mongoid::Extensions::Object do
       context "when provided nil" do
 
         let(:fk) do
-          Object.__mongoize_fk__(constraint, nil)
+          Object.__mongoize_fk__(association, nil)
         end
 
         it "returns nil" do
@@ -120,7 +111,7 @@ describe Mongoid::Extensions::Object do
       context "when provided an empty array" do
 
         let(:fk) do
-          Object.__mongoize_fk__(constraint, [])
+          Object.__mongoize_fk__(association, [])
         end
 
         it "returns an empty array" do
@@ -132,10 +123,6 @@ describe Mongoid::Extensions::Object do
 
   describe "#__mongoize_time__" do
 
-    let(:object) do
-      Object.new
-    end
-
     it "returns self" do
       expect(object.__mongoize_time__).to eq(object)
     end
@@ -143,10 +130,6 @@ describe Mongoid::Extensions::Object do
 
   describe "#__sortable__" do
 
-    let(:object) do
-      Object.new
-    end
-
     it "returns self" do
       expect(object.__sortable__).to eq(object)
     end
@@ -292,12 +275,15 @@ describe Mongoid::Extensions::Object do
 
   describe "#numeric?" do
 
-    let(:object) do
-      Object.new
-    end
-
     it "returns false" do
       expect(object.numeric?).to eq(false)
     end
   end
+
+  describe "#blank_criteria?" do
+
+    it "is false" do
+      expect(object.blank_criteria?).to be false
+    end
+  end
 end