mongoid 6.4.4 → 7.1.7

data/spec/mongoid/{relations/bindings/referenced/one_spec.rb → association/referenced/has_one/binding_spec.rb}

@@ -1,6 +1,9 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
-describe Mongoid::Relations::Bindings::Referenced::One do
+describe Mongoid::Association::Referenced::HasOne::Binding do
 
   let(:person) do
     Person.new
@@ -10,14 +13,14 @@ describe Mongoid::Relations::Bindings::Referenced::One do
     Game.new
   end
 
-  let(:metadata) do
+  let(:association) do
     Person.relations["game"]
   end
 
   describe "#bind_one" do
 
     let(:binding) do
-      described_class.new(person, game, metadata)
+      described_class.new(person, game, association)
     end
 
     context "when the document is bindable" do
@@ -53,7 +56,7 @@ describe Mongoid::Relations::Bindings::Referenced::One do
   describe "#unbind_one" do
 
     let(:binding) do
-      described_class.new(person, game, metadata)
+      described_class.new(person, game, association)
     end
 
     context "when the document is unbindable" do

data/spec/mongoid/association/referenced/has_one/buildable_spec.rb

@@ -0,0 +1,116 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require "spec_helper"
+
+describe Mongoid::Association::Referenced::HasOne::Buildable do
+
+  let(:base) do
+    double(new_record?: false)
+  end
+
+  describe "#build" do
+
+    let(:document) do
+      association.build(base, object)
+    end
+
+    let(:association) do
+      Mongoid::Association::Referenced::HasOne.new(Person, :account)
+    end
+
+    context "when provided an id" do
+
+      let!(:account) do
+        Account.create!(person_id: object, name: 'banking')
+      end
+
+      let(:object) do
+        BSON::ObjectId.new
+      end
+
+      before do
+        expect(Account).to receive(:where).with(association.foreign_key => object).and_call_original
+      end
+
+      it "sets the document" do
+        expect(document).to eq(account)
+      end
+    end
+
+    context "when provided a object" do
+
+      let(:object) do
+        Account.new
+      end
+
+      it "returns the object" do
+        expect(document).to eq(object)
+      end
+
+      context 'when the object is already related to another object' do
+
+        let(:original_person) do
+          Person.new
+        end
+
+        let(:object) do
+          Account.new(person: original_person)
+        end
+
+        let!(:document) do
+          association.build(Person.new, object)
+        end
+
+        it 'clears the object of its previous relation' do
+          expect(original_person.account).to be_nil
+        end
+
+        it 'returns the object' do
+          expect(document).to eq(object)
+        end
+      end
+    end
+
+    context "when the document is not found" do
+
+      let(:object) do
+        BSON::ObjectId.new
+      end
+
+      it "returns nil" do
+        expect(document).to be_nil
+      end
+    end
+
+    context "when the document is persisted" do
+
+      let(:person) do
+        Person.create
+      end
+
+      let!(:game) do
+        Game.create(person: person)
+      end
+
+      it "returns the document" do
+        expect(person.game).to eq(game)
+      end
+    end
+
+    context "when the document have a non standard pk" do
+
+      let(:person) do
+        Person.create
+      end
+
+      let!(:cat) do
+        Cat.create(person: person)
+      end
+
+      it "returns the document" do
+        expect(person.cat).to eq(cat)
+      end
+    end
+  end
+end

data/spec/mongoid/{relations/eager/has_one_spec.rb → association/referenced/has_one/eager_spec.rb}

@@ -1,6 +1,9 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
-describe Mongoid::Relations::Eager::HasOne do
+describe Mongoid::Association::Referenced::HasOne::Eager do
 
   describe ".grouped_doc" do
 
@@ -12,13 +15,13 @@ describe Mongoid::Relations::Eager::HasOne do
       Person.all.to_a
     end
 
-    let(:metadata) do
+    let(:association) do
       Person.reflect_on_association(:cat)
     end
 
     let(:eager) do
-      described_class.new([metadata], docs).tap do |b|
-        b.shift_metadata
+      described_class.new([association], docs).tap do |b|
+        b.send(:shift_association)
       end
     end
 
@@ -27,7 +30,7 @@ describe Mongoid::Relations::Eager::HasOne do
     end
 
     it "aggregates by the relation primary key" do
-      expect(eager.grouped_docs.keys).to eq([person.username])
+      expect(eager.send(:grouped_docs).keys).to eq([person.username])
     end
   end
 
@@ -41,13 +44,13 @@ describe Mongoid::Relations::Eager::HasOne do
       Person.all.to_a
     end
 
-    let(:metadata) do
+    let(:association) do
       Person.reflect_on_association(:cat)
     end
 
     let(:eager) do
-      described_class.new([metadata], docs).tap do |b|
-        b.shift_metadata
+      described_class.new([association], docs).tap do |b|
+        b.send(:shift_association)
       end
     end
 
@@ -60,12 +63,18 @@ describe Mongoid::Relations::Eager::HasOne do
       docs.each do |doc|
         expect(doc).to receive(:set_relation).once.with(:cat, :foo)
       end
-      eager.set_on_parent(person.username, :foo)
+      eager.send(:set_on_parent, person.username, :foo)
     end
 
-    it "doesnt call an extra query" do
-      expect_query(0) do
-        eager.set_on_parent(person.username, :foo)
+    context 'when able to make query count assertions' do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
+
+      it "doesnt call an extra query" do
+        expect_query(0) do
+          eager.send(:set_on_parent, person.username, :foo)
+        end
       end
     end
   end
@@ -82,6 +91,9 @@ describe Mongoid::Relations::Eager::HasOne do
     end
 
     context "when including the has_one relation" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       it "queries twice" do
 
@@ -95,6 +107,9 @@ describe Mongoid::Relations::Eager::HasOne do
     end
 
     context "when including more than one has_one relation" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       it "queries 3 times" do
 

data/spec/mongoid/{relations/referenced/one_spec.rb → association/referenced/has_one/proxy_spec.rb}

@@ -1,6 +1,9 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
-describe Mongoid::Relations::Referenced::One do
+describe Mongoid::Association::Referenced::HasOne::Proxy do
 
   describe "#=" do
 
@@ -52,17 +55,17 @@ describe Mongoid::Relations::Referenced::One do
           Game.new
         end
 
-        let(:metadata) do
+        let(:association) do
           Game.relations["person"]
         end
 
         before do
-          expect(metadata).to receive(:criteria).never
+          expect(association).to receive(:criteria).never
           person.game = game
         end
 
         it "sets the target of the relation" do
-          expect(person.game.target).to eq(game)
+          expect(person.game._target).to eq(game)
         end
 
         it "sets the foreign key on the relation" do
@@ -97,7 +100,7 @@ describe Mongoid::Relations::Referenced::One do
         end
 
         it "sets the target of the relation" do
-          expect(person.game.target).to eq(game)
+          expect(person.game._target).to eq(game)
         end
 
         it "sets the foreign key of the relation" do
@@ -152,7 +155,7 @@ describe Mongoid::Relations::Referenced::One do
         end
 
         it "sets the target of the relation" do
-          expect(person.cat.target).to eq(cat)
+          expect(person.cat._target).to eq(cat)
         end
 
         it "sets the foreign key of the relation" do
@@ -190,7 +193,7 @@ describe Mongoid::Relations::Referenced::One do
         end
 
         it "sets the target of the relation" do
-          expect(bar.rating.target).to eq(rating)
+          expect(bar.rating._target).to eq(rating)
         end
 
         it "sets the foreign key on the relation" do
@@ -225,7 +228,7 @@ describe Mongoid::Relations::Referenced::One do
         end
 
         it "sets the target of the relation" do
-          expect(bar.rating.target).to eq(rating)
+          expect(bar.rating._target).to eq(rating)
         end
 
         it "sets the foreign key of the relation" do
@@ -859,27 +862,6 @@ describe Mongoid::Relations::Referenced::One do
     end
   end
 
-  describe ".builder" do
-
-    let(:builder_klass) do
-      Mongoid::Relations::Builders::Referenced::One
-    end
-
-    let(:document) do
-      double
-    end
-
-    let(:metadata) do
-      double(extension?: false)
-    end
-
-    it "returns the embedded in builder" do
-      expect(
-        described_class.builder(nil, metadata, document)
-      ).to be_a_kind_of(builder_klass)
-    end
-  end
-
   describe "#create_#\{name}" do
 
     context "when the relationship is an illegal embedded reference" do
@@ -996,48 +978,6 @@ describe Mongoid::Relations::Referenced::One do
     end
   end
 
-  describe ".criteria" do
-
-    let(:id) do
-      BSON::ObjectId.new
-    end
-
-    context "when the relation is polymorphic" do
-
-      let(:metadata) do
-        Book.relations["rating"]
-      end
-
-      let(:criteria) do
-        described_class.criteria(metadata, id, Book)
-      end
-
-      it "includes the type in the criteria" do
-        expect(criteria.selector).to eq(
-          {
-            "ratable_id"    => id,
-            "ratable_type"  => "Book"
-          }
-        )
-      end
-    end
-
-    context "when the relation is not polymorphic" do
-
-      let(:metadata) do
-        Person.relations["game"]
-      end
-
-      let(:criteria) do
-        described_class.criteria(metadata, id, Person)
-      end
-
-      it "does not include the type in the criteria" do
-        expect(criteria.selector).to eq({ "person_id" => id })
-      end
-    end
-  end
-
   describe ".embedded?" do
 
     it "returns false" do
@@ -1045,20 +985,6 @@ describe Mongoid::Relations::Referenced::One do
     end
   end
 
-  describe ".foreign_key_suffix" do
-
-    it "returns _id" do
-      expect(described_class.foreign_key_suffix).to eq("_id")
-    end
-  end
-
-  describe ".macro" do
-
-    it "returns has_one" do
-      expect(described_class.macro).to eq(:has_one)
-    end
-  end
-
   describe "#nullify" do
 
     let(:person) do
@@ -1133,29 +1059,6 @@ describe Mongoid::Relations::Referenced::One do
     end
   end
 
-  describe ".stores_foreign_key?" do
-
-    it "returns false" do
-      expect(described_class.stores_foreign_key?).to be false
-    end
-  end
-
-  describe ".valid_options" do
-
-    it "returns the valid options" do
-      expect(described_class.valid_options).to eq(
-        [ :as, :autobuild, :autosave, :dependent, :foreign_key, :primary_key ]
-      )
-    end
-  end
-
-  describe ".validation_default" do
-
-    it "returns true" do
-      expect(described_class.validation_default).to be true
-    end
-  end
-
   context "when reloading the relation" do
 
     let!(:person) do
@@ -1178,7 +1081,7 @@ describe Mongoid::Relations::Referenced::One do
 
       before do
         Game.collection.find({ _id: game_one.id }).
-          update_one({ "$set" => { name: "Diablo 2" }})
+            update_one({ "$set" => { name: "Diablo 2" }})
       end
 
       let(:reloaded) do

data/spec/mongoid/association/referenced/has_one_models.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+class HomCollege
+  include Mongoid::Document
+
+  has_one :accreditation, class_name: 'HomAccreditation'
+
+  field :state, type: String
+end
+
+class HomAccreditation
+  include Mongoid::Document
+
+  belongs_to :college, class_name: 'HomCollege'
+
+  field :degree, type: String
+  field :year, type: Integer, default: 2012
+end
+
+class HomAccreditation::Child
+  include Mongoid::Document
+
+  belongs_to :hom_college
+end
+
+module HomNs
+  class PrefixedParent
+    include Mongoid::Document
+
+    has_one :child, class_name: 'PrefixedChild'
+  end
+
+  class PrefixedChild
+    include Mongoid::Document
+
+    belongs_to :parent, class_name: 'PrefixedParent'
+  end
+end
+
+class HomPolymorphicParent
+  include Mongoid::Document
+
+  has_one :p_child, as: :parent
+end
+
+class HomPolymorphicChild
+  include Mongoid::Document
+
+  belongs_to :p_parent, polymorphic: true
+end