mongoid 3.1.7 → 4.0.2

data/spec/mongoid/{sharding_spec.rb → shardable_spec.rb}

@@ -1,21 +1,21 @@
 require "spec_helper"
 
-describe Mongoid::Sharding do
+describe Mongoid::Shardable do
 
   describe ".included" do
 
     let(:klass) do
       Class.new do
-        include Mongoid::Sharding
+        include Mongoid::Shardable
       end
     end
 
     it "adds an shard_key_fields accessor" do
-      klass.should respond_to(:shard_key_fields)
+      expect(klass).to respond_to(:shard_key_fields)
     end
 
     it "defaults shard_key_fields to an empty array" do
-      klass.shard_key_fields.should be_empty
+      expect(klass.shard_key_fields).to be_empty
     end
   end
 
@@ -23,7 +23,7 @@ describe Mongoid::Sharding do
 
     let(:klass) do
       Class.new do
-        include Mongoid::Sharding
+        include Mongoid::Shardable
       end
     end
 
@@ -32,7 +32,7 @@ describe Mongoid::Sharding do
     end
 
     it "specifies a shard key on the collection" do
-      klass.shard_key_fields.should eq([:name])
+      expect(klass.shard_key_fields).to eq([:name])
     end
   end
 
@@ -40,7 +40,7 @@ describe Mongoid::Sharding do
 
     let(:klass) do
       Class.new do
-        include Mongoid::Sharding
+        include Mongoid::Shardable
         attr_accessor :name
       end
     end
@@ -55,7 +55,7 @@ describe Mongoid::Sharding do
     end
 
     it "returns a hash of shard key names and values" do
-      object.shard_key_selector.should eq({ "name" => "Jo" })
+      expect(object.shard_key_selector).to eq({ "name" => "Jo" })
     end
   end
 end

data/spec/mongoid/{state_spec.rb → stateful_spec.rb}

@@ -1,28 +1,28 @@
 require "spec_helper"
 
-describe Mongoid::State do
+describe Mongoid::Stateful do
 
   describe "#new_record?" do
 
     context "when calling new on the document" do
 
       let(:person) do
-        Person.new("_id" => Moped::BSON::ObjectId.new)
+        Person.new("_id" => BSON::ObjectId.new)
       end
 
       it "returns true" do
-        person.should be_a_new_record
+        expect(person).to be_a_new_record
       end
     end
 
     context "when the object has been saved" do
 
       let(:person) do
-        Person.instantiate("_id" => Moped::BSON::ObjectId.new)
+        Person.instantiate("_id" => BSON::ObjectId.new)
       end
 
       it "returns false" do
-        person.should_not be_a_new_record
+        expect(person).to_not be_a_new_record
       end
     end
 
@@ -33,7 +33,7 @@ describe Mongoid::State do
       end
 
       it "returns true" do
-        person.should be_a_new_record
+        expect(person).to be_a_new_record
       end
     end
   end
@@ -45,7 +45,7 @@ describe Mongoid::State do
     end
 
     it "delegates to new_record?" do
-      person.should_not be_persisted
+      expect(person).to_not be_persisted
     end
 
     context "when the object has been destroyed" do
@@ -55,7 +55,7 @@ describe Mongoid::State do
       end
 
       it "returns false" do
-        person.should_not be_persisted
+        expect(person).to_not be_persisted
       end
     end
   end
@@ -73,7 +73,7 @@ describe Mongoid::State do
       end
 
       it "returns true" do
-        person.should be_destroyed
+        expect(person).to be_destroyed
       end
     end
 
@@ -84,7 +84,7 @@ describe Mongoid::State do
       end
 
       it "returns true" do
-        person.should_not be_destroyed
+        expect(person).to_not be_destroyed
       end
     end
 
@@ -95,7 +95,32 @@ describe Mongoid::State do
       end
 
       it "returns false" do
-        person.should_not be_destroyed
+        expect(person).to_not be_destroyed
+      end
+    end
+  end
+
+  describe "#readonly?" do
+
+    let(:document) do
+      Band.new
+    end
+
+    context "when the document is readonly" do
+
+      before do
+        document.__selected_fields = { test: 1 }
+      end
+
+      it "returns true" do
+        expect(document).to be_readonly
+      end
+    end
+
+    context "when no readonly has been set" do
+
+      it "returns false" do
+        expect(document).to_not be_readonly
       end
     end
   end

data/spec/mongoid/tasks/database_rake_spec.rb

@@ -0,0 +1,285 @@
+require "rake"
+require "spec_helper"
+
+unless defined?(Rails)
+  module Rails
+  end
+end
+
+shared_context "rake task" do
+  let(:task_name) { self.class.top_level_description }
+  let(:task) { Rake.application[task_name] }
+  let(:task_file) { "mongoid/tasks/database" }
+
+  let(:logger) do
+    double("logger").tap do |log|
+      allow(log).to receive(:info)
+    end
+  end
+
+  before do
+    rake = Rake::Application.new
+    Rake.application = rake
+    rake.rake_require(task_file, $LOAD_PATH, [])
+    Rake::Task.define_task(:environment)
+
+    allow(Mongoid::Tasks::Database).to receive(:logger).and_return(logger)
+  end
+
+  shared_examples_for "create_indexes" do
+
+    it "receives create_indexes" do
+      expect(Mongoid::Tasks::Database).to receive(:create_indexes)
+      task.invoke
+    end
+  end
+end
+
+shared_context "rails rake task" do
+  let(:task_file) { "mongoid/railties/database" }
+
+  let(:application) do
+    app = double("application")
+    allow(app).to receive(:eager_load!)
+    app
+  end
+end
+
+describe "db:drop" do
+  include_context "rake task"
+  include_context "rails rake task"
+
+  it "calls mongoid:drop" do
+    expect(task.prerequisites).to include("mongoid:drop")
+  end
+
+  it "works" do
+    task.invoke
+  end
+end
+
+describe "db:purge" do
+  include_context "rake task"
+  include_context "rails rake task"
+
+  it "calls mongoid:drop" do
+    expect(task.prerequisites).to include("mongoid:purge")
+  end
+
+  it "works" do
+    task.invoke
+  end
+end
+
+describe "db:seed" do
+  include_context "rake task"
+  include_context "rails rake task"
+
+  it "calls environment" do
+    expect(task.prerequisites).to include("environment")
+  end
+
+  it "works" do
+    expect(Rails).to receive(:root).and_return(".")
+    task.invoke
+  end
+end
+
+describe "db:setup" do
+  include_context "rake task"
+  include_context "rails rake task"
+
+  it "calls db:create" do
+    expect(task.prerequisites).to include("db:create")
+  end
+
+  it "calls db:mongoid:create_indexes" do
+    expect(task.prerequisites).to include("mongoid:create_indexes")
+  end
+
+  it "calls db:seed" do
+    expect(task.prerequisites).to include("db:seed")
+  end
+
+  it_behaves_like "create_indexes" do
+
+    before do
+      expect(Rails).to receive(:root).and_return(".")
+      expect(Rails).to receive(:application).and_return(application)
+    end
+  end
+
+  it "works" do
+    expect(Mongoid::Tasks::Database).to receive(:create_indexes)
+    expect(Rails).to receive(:root).and_return(".")
+    expect(Rails).to receive(:application).and_return(application)
+    task.invoke
+  end
+end
+
+describe "db:reset" do
+  include_context "rake task"
+  include_context "rails rake task"
+
+  it "calls db:drop" do
+    expect(task.prerequisites).to include("db:drop")
+  end
+
+  it "calls db:seed" do
+    expect(task.prerequisites).to include("db:seed")
+  end
+
+  it "works" do
+    expect(Rails).to receive(:root).and_return(".")
+    task.invoke
+  end
+end
+
+describe "db:create" do
+  include_context "rake task"
+  include_context "rails rake task"
+
+  it "works" do
+    task.invoke
+  end
+end
+
+describe "db:migrate" do
+  include_context "rake task"
+  include_context "rails rake task"
+
+  it "works" do
+    task.invoke
+  end
+end
+
+describe "db:test:prepare" do
+  include_context "rake task"
+  include_context "rails rake task"
+
+  it_behaves_like "create_indexes" do
+    before do
+      expect(Rails).to receive(:application).and_return(application)
+    end
+  end
+
+  it "calls mongoid:create_indexes" do
+    expect(task.prerequisites).to include("mongoid:create_indexes")
+  end
+
+  it "works" do
+    expect(Rails).to receive(:application).and_return(application)
+    expect(Mongoid::Tasks::Database).to receive(:create_indexes)
+    task.invoke
+  end
+end
+
+describe "db:mongoid:create_indexes" do
+  include_context "rake task"
+
+  it_behaves_like "create_indexes"
+
+  it "calls load_models" do
+    expect(task.prerequisites).to include("load_models")
+  end
+
+  it "calls environment" do
+    expect(task.prerequisites).to include("environment")
+  end
+
+  context "when using rails task" do
+    include_context "rails rake task"
+
+    before do
+      expect(Rails).to receive(:application).and_return(application)
+    end
+
+    it_behaves_like "create_indexes"
+  end
+end
+
+describe "db:mongoid:remove_undefined_indexes" do
+  include_context "rake task"
+
+  it "receives remove_undefined_indexes" do
+    expect(Mongoid::Tasks::Database).to receive(:remove_undefined_indexes)
+    task.invoke
+  end
+
+  it "calls environment" do
+    expect(task.prerequisites).to include("environment")
+  end
+
+  context "when using rails task" do
+    include_context "rails rake task"
+
+    before do
+      expect(Rails).to receive(:application).and_return(application)
+    end
+
+    it "receives remove_undefined_indexes" do
+      expect(Mongoid::Tasks::Database).to receive(:remove_undefined_indexes)
+      task.invoke
+    end
+  end
+end
+
+describe "db:mongoid:remove_indexes" do
+  include_context "rake task"
+
+  it "receives remove_indexes" do
+    expect(Mongoid::Tasks::Database).to receive(:remove_indexes)
+    task.invoke
+  end
+
+  it "calls environment" do
+    expect(task.prerequisites).to include("environment")
+  end
+
+  context "when using rails task" do
+    include_context "rails rake task"
+
+    before do
+      expect(Rails).to receive(:application).and_return(application)
+    end
+
+    it "receives remove_indexes" do
+      expect(Mongoid::Tasks::Database).to receive(:remove_indexes)
+      task.invoke
+    end
+  end
+end
+
+describe "db:mongoid:drop" do
+  include_context "rake task"
+
+  it "works" do
+    task.invoke
+  end
+
+  context "when using rails task" do
+    include_context "rails rake task"
+
+    it "works" do
+      task.invoke
+    end
+  end
+end
+
+describe "db:mongoid:purge" do
+  include_context "rake task"
+
+  it "receives a purge" do
+    expect(Mongoid).to receive(:purge!)
+    task.invoke
+  end
+
+  context "when using rails task" do
+    include_context "rails rake task"
+
+    it "receives a purge" do
+      expect(Mongoid).to receive(:purge!)
+      task.invoke
+    end
+  end
+end

data/spec/mongoid/tasks/database_spec.rb

@@ -0,0 +1,160 @@
+require "spec_helper"
+
+describe "Mongoid::Tasks::Database" do
+
+  let(:logger) do
+    double("logger").tap do |log|
+      allow(log).to receive(:info)
+    end
+  end
+
+  before do
+    allow(Mongoid::Tasks::Database).to receive(:logger).and_return(logger)
+  end
+
+  let(:models) do
+    [ User, Account, Address, Draft ]
+  end
+
+  describe ".create_indexes" do
+
+    let!(:klass) do
+      User
+    end
+
+    let(:indexes) do
+      Mongoid::Tasks::Database.create_indexes(models)
+    end
+
+    context "with ordinary Rails models" do
+
+      it "creates the indexes for the models" do
+        expect(klass).to receive(:create_indexes).once
+        indexes
+      end
+    end
+
+    context "with a model without indexes" do
+
+      let(:klass) do
+        Account
+      end
+
+      it "does nothing" do
+        expect(klass).to receive(:create_indexes).never
+        indexes
+      end
+    end
+
+    context "when an exception is raised" do
+
+      it "is not swallowed" do
+        expect(klass).to receive(:create_indexes).and_raise(ArgumentError)
+        expect { indexes }.to raise_error(ArgumentError)
+      end
+    end
+
+    context "when index is defined on embedded model" do
+
+      let!(:klass) do
+        Address
+      end
+
+      before do
+        klass.index(street: 1)
+      end
+
+      it "does nothing, but logging" do
+        expect(klass).to receive(:create_indexes).never
+        indexes
+      end
+    end
+
+    context "when index is defined on self-embedded (cyclic) model" do
+
+      let(:klass) do
+        Draft
+      end
+
+      it "creates the indexes for the models" do
+        expect(klass).to receive(:create_indexes).once
+        indexes
+      end
+    end
+  end
+
+  describe ".undefined_indexes" do
+
+    before(:each) do
+      Mongoid::Tasks::Database.create_indexes(models)
+    end
+
+    let(:indexes) do
+      Mongoid::Tasks::Database.undefined_indexes(models)
+    end
+
+    it "returns the removed indexes" do
+      expect(indexes).to be_empty
+    end
+
+    context "with extra index on model collection" do
+
+      before(:each) do
+        User.collection.indexes.create(account_expires: 1)
+      end
+
+      let(:names) do
+        indexes[User].map{ |index| index['name'] }
+      end
+
+      it "should have single index returned" do
+        expect(names).to eq(['account_expires_1'])
+      end
+    end
+  end
+
+  describe ".remove_undefined_indexes" do
+
+    let(:indexes) do
+      User.collection.indexes
+    end
+
+    before(:each) do
+      Mongoid::Tasks::Database.create_indexes(models)
+      indexes.create(account_expires: 1)
+      Mongoid::Tasks::Database.remove_undefined_indexes(models)
+    end
+
+    let(:removed_indexes) do
+      Mongoid::Tasks::Database.undefined_indexes(models)
+    end
+
+    it "returns the removed indexes" do
+      expect(removed_indexes).to be_empty
+    end
+  end
+
+  describe ".remove_indexes" do
+
+    let!(:klass) do
+      User
+    end
+
+    let(:indexes) do
+      klass.collection.indexes
+    end
+
+    before :each do
+      Mongoid::Tasks::Database.create_indexes(models)
+      Mongoid::Tasks::Database.remove_indexes(models)
+    end
+
+    it "removes indexes from klass" do
+      expect(indexes.reject{ |doc| doc["name"] == "_id_" }).to be_empty
+    end
+
+    it "leaves _id index untouched" do
+      expect(indexes.select{ |doc| doc["name"] == "_id_" }).to_not be_empty
+    end
+  end
+end