mongoid 3.1.7 → 4.0.2

data/spec/config/mongoid.yml

@@ -5,7 +5,7 @@ test:
       hosts:
         - <%=ENV["MONGOID_SPEC_HOST"]%>:<%=ENV["MONGOID_SPEC_PORT"]%>
       options:
-        consistency: :strong
+        read: primary
     mongohq_single:
       database: <%=ENV["MONGOHQ_SINGLE_NAME"]%>
       username: <%=ENV["MONGOHQ_SINGLE_USER"]%>
@@ -13,8 +13,9 @@ test:
       hosts:
         - <%=ENV["MONGOHQ_SINGLE_URL"]%>
       options:
-        safe: true
-        consistency: :strong
+        write:
+          w: 1
+        read: primary
     mongohq_repl:
       database: <%=ENV["MONGOHQ_REPL_NAME"]%>
       username: <%=ENV["MONGOHQ_REPL_USER"]%>
@@ -23,18 +24,16 @@ test:
         - <%=ENV["MONGOHQ_REPL_1_URL"]%>
         - <%=ENV["MONGOHQ_REPL_2_URL"]%>
       options:
-        consistency: :strong
-        safe: true
+        read: primary
+        write:
+          w: majority
     mongohq_repl_uri:
       uri: <%= ENV["MONGOHQ_REPL_URI"]%>
   options:
-    allow_dynamic_fields: true
-    identity_map_enabled: false
     include_root_in_json: false
     include_type_for_serialization: false
     preload_models: false
     scope_overwrite_exception: false
     raise_not_found_error: true
-    skip_version_check: true
     use_activesupport_time_zone: true
     use_utc: false

data/spec/helpers.rb

@@ -0,0 +1,18 @@
+require 'mongoid/support/query_counter'
+
+module Mongoid
+  module SpecHelpers
+    def expect_query(number, &block)
+      query_counter = Mongoid::QueryCounter.new
+      query_counter.instrument(&block)
+      expect(query_counter.events.size).to(eq(number), %[
+Expected to receive #{number} queries, it received #{query_counter.events.size}
+#{query_counter.inspect}
+])
+    end
+
+    def expect_no_queries(&block)
+      expect_query(0, &block)
+    end
+  end
+end

data/spec/mongoid/atomic/modifiers_spec.rb

@@ -15,7 +15,7 @@ describe Mongoid::Atomic::Modifiers do
       end
 
       it "does not contain any operations" do
-        modifiers.should eq({})
+        expect(modifiers).to eq({})
       end
     end
 
@@ -32,7 +32,7 @@ describe Mongoid::Atomic::Modifiers do
         end
 
         it "adds the add to set with each modifiers" do
-          modifiers.should eq({
+          expect(modifiers).to eq({
             "$addToSet" => { "preference_ids" => { "$each" => [ "one", "two" ] }}
           })
         end
@@ -50,7 +50,7 @@ describe Mongoid::Atomic::Modifiers do
         end
 
         it "adds the add to set with each modifiers" do
-          modifiers.should eq({
+          expect(modifiers).to eq({
             "$addToSet" =>
               { "preference_ids" =>
                 { "$each" => [ "one", "two", "three" ] }
@@ -70,7 +70,7 @@ describe Mongoid::Atomic::Modifiers do
       end
 
       it "does not contain any pull operations" do
-        modifiers.should eq({})
+        expect(modifiers).to eq({})
       end
     end
 
@@ -87,7 +87,7 @@ describe Mongoid::Atomic::Modifiers do
         end
 
         it "adds the push all modifiers" do
-          modifiers.should eq(
+          expect(modifiers).to eq(
             { "$pull" => { "addresses" => { "_id" => { "$in" => [ "one" ]}}}}
           )
         end
@@ -109,7 +109,7 @@ describe Mongoid::Atomic::Modifiers do
         end
 
         it "overwrites the previous pulls" do
-          modifiers.should eq(
+          expect(modifiers).to eq(
             { "$pull" => { "addresses" => { "_id" => { "$in" => [ "two" ]}}}}
           )
         end
@@ -126,7 +126,7 @@ describe Mongoid::Atomic::Modifiers do
       end
 
       it "does not contain any pull operations" do
-        modifiers.should eq({})
+        expect(modifiers).to eq({})
       end
     end
 
@@ -143,7 +143,7 @@ describe Mongoid::Atomic::Modifiers do
         end
 
         it "adds the push all modifiers" do
-          modifiers.should eq(
+          expect(modifiers).to eq(
             { "$pullAll" =>
               { "addresses" => [
                   { "_id" => "one" }
@@ -170,7 +170,7 @@ describe Mongoid::Atomic::Modifiers do
         end
 
         it "adds the pull all modifiers" do
-          modifiers.should eq(
+          expect(modifiers).to eq(
             { "$pullAll" =>
               { "addresses" => [
                   { "street" => "Hobrechtstr." },
@@ -193,7 +193,7 @@ describe Mongoid::Atomic::Modifiers do
       end
 
       it "does not contain any push operations" do
-        modifiers.should eq({})
+        expect(modifiers).to eq({})
       end
     end
 
@@ -210,7 +210,7 @@ describe Mongoid::Atomic::Modifiers do
         end
 
         it "adds the push all modifiers" do
-          modifiers.should eq(
+          expect(modifiers).to eq(
             { "$pushAll" =>
               { "addresses" => [
                   { "street" => "Oxford St" }
@@ -237,7 +237,7 @@ describe Mongoid::Atomic::Modifiers do
         end
 
         it "adds the push all modifiers" do
-          modifiers.should eq(
+          expect(modifiers).to eq(
             { "$pushAll" =>
               { "addresses" => [
                   { "street" => "Hobrechtstr." },
@@ -268,7 +268,7 @@ describe Mongoid::Atomic::Modifiers do
         end
 
         it "adds the push all modifiers to the conflicts hash" do
-          modifiers.should eq(
+          expect(modifiers).to eq(
             { "$set" => { "addresses.0.street" => "Bond" },
               conflicts: { "$pushAll" =>
                 { "addresses" => [
@@ -297,7 +297,7 @@ describe Mongoid::Atomic::Modifiers do
         end
 
         it "adds the push all modifiers to the conflicts hash" do
-          modifiers.should eq(
+          expect(modifiers).to eq(
             { "$pullAll" => {
               "addresses" => { "street" => "Bond St" }},
               conflicts: { "$pushAll" =>
@@ -327,7 +327,7 @@ describe Mongoid::Atomic::Modifiers do
         end
 
         it "adds the push all modifiers to the conflicts hash" do
-          modifiers.should eq(
+          expect(modifiers).to eq(
             { "$pushAll" => {
               "addresses.0.locations" => [{ "street" => "Bond St" }]},
               conflicts: { "$pushAll" =>
@@ -360,14 +360,14 @@ describe Mongoid::Atomic::Modifiers do
           end
 
           it "adds the sets to the modifiers" do
-            modifiers.should eq({ "$set" => { "title" => "Sir" } })
+            expect(modifiers).to eq({ "$set" => { "title" => "Sir" } })
           end
         end
 
         context "when the sets contain an id" do
 
           let(:sets) do
-            { "_id" => Moped::BSON::ObjectId.new }
+            { "_id" => BSON::ObjectId.new }
           end
 
           before do
@@ -375,7 +375,7 @@ describe Mongoid::Atomic::Modifiers do
           end
 
           it "does not include the id sets" do
-            modifiers.should eq({})
+            expect(modifiers).to eq({})
           end
         end
 
@@ -386,7 +386,7 @@ describe Mongoid::Atomic::Modifiers do
           end
 
           it "does not contain set operations" do
-            modifiers.should eq({})
+            expect(modifiers).to eq({})
           end
         end
       end
@@ -407,7 +407,7 @@ describe Mongoid::Atomic::Modifiers do
         end
 
         it "adds the set modifiers to the conflicts hash" do
-          modifiers.should eq(
+          expect(modifiers).to eq(
             { "$pullAll" =>
               { "addresses" => [
                   { "_id" => "one" }
@@ -437,7 +437,7 @@ describe Mongoid::Atomic::Modifiers do
         end
 
         it "adds the unsets to the modifiers" do
-          modifiers.should eq({ "$unset" => { "addresses" => true } })
+          expect(modifiers).to eq({ "$unset" => { "addresses" => true } })
         end
       end
 
@@ -448,7 +448,7 @@ describe Mongoid::Atomic::Modifiers do
         end
 
         it "does not contain unset operations" do
-          modifiers.should eq({})
+          expect(modifiers).to eq({})
         end
       end
     end

data/spec/mongoid/atomic/paths/embedded/many_spec.rb

@@ -25,21 +25,21 @@ describe Mongoid::Atomic::Paths::Embedded::Many do
   describe "#delete_modifier" do
 
     it "returns $pull" do
-      many.delete_modifier.should eq("$pull")
+      expect(many.delete_modifier).to eq("$pull")
     end
   end
 
   describe "#document" do
 
     it "returns the document" do
-      many.document.should eq(address)
+      expect(many.document).to eq(address)
     end
   end
 
   describe "#insert_modifier" do
 
     it "returns $push" do
-      many.insert_modifier.should eq("$push")
+      expect(many.insert_modifier).to eq("$push")
     end
   end
 
@@ -48,7 +48,7 @@ describe Mongoid::Atomic::Paths::Embedded::Many do
     context "when the document is embedded one level" do
 
       it "returns the name of the relation" do
-        many.path.should eq("addresses")
+        expect(many.path).to eq("addresses")
       end
     end
 
@@ -67,7 +67,7 @@ describe Mongoid::Atomic::Paths::Embedded::Many do
       end
 
       it "returns the nested path to the relation" do
-        many.path.should eq("addresses.locations")
+        expect(many.path).to eq("addresses.locations")
       end
     end
   end
@@ -85,12 +85,12 @@ describe Mongoid::Atomic::Paths::Embedded::Many do
           person.phones << phone
         end
         it "return the name of the store_as in relation" do
-          many.position.should eq("mobile_phones")
+          expect(many.position).to eq("mobile_phones")
         end
       end
 
       it "returns the name of the relation" do
-        many.position.should eq("addresses")
+        expect(many.position).to eq("addresses")
       end
     end
 
@@ -111,48 +111,7 @@ describe Mongoid::Atomic::Paths::Embedded::Many do
       end
 
       it "returns the nested position to the relation" do
-        many.position.should eq("addresses.0.locations.0")
-      end
-    end
-  end
-
-  describe "#selector" do
-
-    context "when the document is embedded one level" do
-
-      it "returns the the hash with parent selector" do
-        many.selector.should eq(
-          { "_id" => person._id, "addresses._id" => address._id }
-        )
-      end
-    end
-
-    context "when the document is embedded multiple levels" do
-
-      let(:location) do
-        Location.new(name: "home")
-      end
-
-      before do
-        address.locations << location
-        address.new_record = false
-        address.post_persist
-        location.new_record = false
-        location.post_persist
-      end
-
-      let(:many) do
-        described_class.new(location)
-      end
-
-      it "returns the hash with all parent selectors" do
-        many.selector.should eq(
-          {
-            "_id" => person._id,
-            "addresses._id" => address._id,
-            "addresses.0.locations._id" => location._id
-          }
-        )
+        expect(many.position).to eq("addresses.0.locations.0")
       end
     end
   end

data/spec/mongoid/atomic/paths/embedded/one_spec.rb

@@ -21,21 +21,21 @@ describe Mongoid::Atomic::Paths::Embedded::One do
   describe "#delete_modifier" do
 
     it "returns $unset" do
-      one.delete_modifier.should eq("$unset")
+      expect(one.delete_modifier).to eq("$unset")
     end
   end
 
   describe "#document" do
 
     it "returns the document" do
-      one.document.should eq(name)
+      expect(one.document).to eq(name)
     end
   end
 
   describe "#insert_modifier" do
 
     it "returns $set" do
-      one.insert_modifier.should eq("$set")
+      expect(one.insert_modifier).to eq("$set")
     end
   end
 
@@ -44,7 +44,7 @@ describe Mongoid::Atomic::Paths::Embedded::One do
     context "when the document is embedded one level" do
 
       it "returns the name of the relation" do
-        one.path.should eq("name")
+        expect(one.path).to eq("name")
       end
     end
 
@@ -68,7 +68,7 @@ describe Mongoid::Atomic::Paths::Embedded::One do
       end
 
       it "returns the nested path to the relation" do
-        one.path.should eq("phone_numbers.country_code")
+        expect(one.path).to eq("phone_numbers.country_code")
       end
     end
   end
@@ -78,7 +78,7 @@ describe Mongoid::Atomic::Paths::Embedded::One do
     context "when the document is embedded one level" do
 
       it "returns the name of the relation" do
-        one.position.should eq("name")
+        expect(one.position).to eq("name")
       end
     end
 
@@ -103,49 +103,7 @@ describe Mongoid::Atomic::Paths::Embedded::One do
       end
 
       it "returns the nested position to the relation" do
-        one.position.should eq("phone_numbers.0.country_code")
-      end
-    end
-  end
-
-  describe "#selector" do
-
-    context "when the document is embedded one level" do
-
-      it "returns the the hash with parent selector" do
-        one.selector.should eq({ "_id" => person._id, "name._id" => name._id })
-      end
-    end
-
-    context "when the document is embedded multiple levels" do
-
-      let(:phone) do
-        Phone.new(number: "404-555-1212")
-      end
-
-      let(:country_code) do
-        CountryCode.new(code: 1)
-      end
-
-      before do
-        phone.country_code = country_code
-        person.phone_numbers << phone
-        phone.new_record = false
-        phone.post_persist
-      end
-
-      let(:one) do
-        described_class.new(country_code)
-      end
-
-      it "returns the hash with all parent selectors" do
-        one.selector.should eq(
-          {
-            "_id" => person._id,
-            "phone_numbers._id" => phone._id,
-            "phone_numbers.0.country_code._id" => country_code._id
-          }
-        )
+        expect(one.position).to eq("phone_numbers.0.country_code")
       end
     end
   end

data/spec/mongoid/atomic/paths/root_spec.rb

@@ -13,21 +13,21 @@ describe Mongoid::Atomic::Paths::Root do
   describe "#document" do
 
     it "returns the document" do
-      root.document.should eq(person)
+      expect(root.document).to eq(person)
     end
   end
 
   describe "#path" do
 
     it "returns an empty string" do
-      root.path.should be_empty
+      expect(root.path).to be_empty
     end
   end
 
   describe "#position" do
 
     it "returns an empty string" do
-      root.position.should be_empty
+      expect(root.position).to be_empty
     end
   end
 
@@ -45,62 +45,4 @@ describe Mongoid::Atomic::Paths::Root do
       expect { root.insert_modifier }.to raise_error(Mongoid::Errors::InvalidPath)
     end
   end
-
-  describe "#selector" do
-
-    context "when using a shard key" do
-
-      let(:profile) do
-        Profile.new(name: "google")
-      end
-
-      let(:root) do
-        described_class.new(profile)
-      end
-
-      it "returns the id and shard key in the hash" do
-        root.selector.should eq({ "_id" => profile.id, "name" => profile.name })
-      end
-    end
-
-    context "when not using a shard key" do
-
-      context "when using object ids" do
-
-        it "returns the hash with the id" do
-          root.selector.should eq({ "_id" => person.id })
-        end
-      end
-
-      context "when using a composite key" do
-
-        let(:account) do
-          Account.new(name: "savings")
-        end
-
-        let(:root) do
-          described_class.new(account)
-        end
-
-        context "when the composite key has changed" do
-
-          before do
-            account.new_record = false
-            account.name = "current"
-          end
-
-          it "returns the hash with the old key" do
-            root.selector.should eq({ "_id" => "savings" })
-          end
-        end
-
-        context "when the composite key has not changed" do
-
-          it "returns the hash with the key" do
-            root.selector.should eq({ "_id" => "savings" })
-          end
-        end
-      end
-    end
-  end
 end