mongodb_model 0.2.8 → 2.0.0

data/spec/validation_spec.rb

@@ -1,22 +1,99 @@
 require 'spec_helper'
 
-describe "Validations" do
+describe "Validation" do
   with_mongo_model
 
-  before :all do
-    class BaseUnit
-      inherit Mongo::Model
-      collection :units
+  describe 'CRUD' do
+    before do
+      class Unit
+        inherit Mongo::Model
+        collection :units
 
-      attr_accessor :name
+        attr_accessor :items
+        embedded :items
+
+        class Item
+          inherit Mongo::Model
+        end
+      end
+    end
+    after{remove_constants :Unit}
+
+    before do
+      @item = Unit::Item.new
+      @unit = Unit.new
+      @unit.items = [@item]
+    end
+
+    it 'should not save, update or delete invalid objects' do
+      # create
+      @unit.stub!(:valid?).and_return(false)
+      db.units.save(@unit).should be_false
+
+      @unit.stub!(:valid?).and_return(true)
+      db.units.save(@unit).should be_true
+
+      # update
+      @unit.stub!(:valid?).and_return(false)
+      db.units.save(@unit).should be_false
+
+      @unit.stub!(:valid?).and_return(true)
+      db.units.save(@unit).should be_true
+
+      # delete
+      @unit.stub!(:valid?).and_return(false)
+      db.units.delete(@unit).should be_false
+
+      @unit.stub!(:valid?).and_return(true)
+      db.units.delete(@unit).should be_true
+    end
+
+    it 'should not save, update or delete invalid embedded objects' do
+      # create
+      @item.stub!(:valid?).and_return(false)
+      db.units.save(@unit).should be_false
+
+      @item.stub!(:valid?).and_return(true)
+      db.units.save(@unit).should be_true
+
+      # update
+      @item.stub!(:valid?).and_return(false)
+      db.units.save(@unit).should be_false
+
+      @item.stub!(:valid?).and_return(true)
+      db.units.save(@unit).should be_true
+
+      # delete
+      @item.stub!(:valid?).and_return(false)
+      db.units.delete(@unit).should be_false
+
+      @item.stub!(:valid?).and_return(true)
+      db.units.delete(@unit).should be_true
+    end
+
+    it "should be able to skip validation" do
+      @unit.stub!(:valid?).and_return(false)
+      db.units.save(@unit, validate: false).should be_true
+
+      @unit.stub!(:valid?).and_return(true)
+      @item.stub!(:valid?).and_return(false)
+      db.units.save(@unit, validate: false).should be_true
     end
   end
-  after{remove_constants :Unit}
-  after(:all){remove_constants :BaseUnit}
 
-  describe 'basics' do
-    it "before validation callback" do
-      class Unit < BaseUnit
+  describe "basics" do
+    before do
+      class Unit
+        inherit Mongo::Model
+        collection :units
+
+        attr_accessor :name
+      end
+    end
+    after{remove_constants :Unit}
+
+    it "should provide validation callback" do
+      class Unit
         before_validate :check_name
         def check_name
           errors.add :name, 'invalid name'
@@ -28,7 +105,7 @@ describe "Validations" do
     end
 
     it "should not save model with errors" do
-      unit = BaseUnit.build name: 'Zeratul'
+      unit = Unit.build name: 'Zeratul'
       unit.save.should be_true
 
       unit.errors.clear
@@ -42,7 +119,7 @@ describe "Validations" do
     end
 
     it "should add custom validations" do
-      class Unit < BaseUnit
+      class Unit
         validate :check_name
         def check_name
           errors.add :name, 'invalid name'
@@ -54,85 +131,15 @@ describe "Validations" do
       unit.errors[:name].should == ['invalid name']
     end
 
-    # it "should check :errors only and ignore valid? method" do
-    #   unit = BaseUnit.build name: 'Zeratul'
-    #   unit.should_not_receive(:valid?)
-    #   unit.save.should be_true
-    # end
-  end
-
-  describe "validatable2" do
-    it "smoke test" do
-      class Unit < BaseUnit
+    it "should clear errors before validation" do
+      class Unit
         validates_presence_of :name
       end
 
       unit = Unit.new
       unit.should_not be_valid
-      unit.errors.size.should == 1
-      unit.errors.first.first.should == :name
-      unit.save.should be_false
-
-      unit.errors.clear
       unit.name = 'Zeratul'
       unit.should be_valid
-      unit.errors.should be_empty
-      unit.save.should be_true
-    end
-
-    it "should validate before save" do
-      unit = BaseUnit.new
-      unit.should_receive(:run_validations)
-      unit.save
-    end
-
-    it "should not save errors as instance variables" do
-      unit = BaseUnit.new
-      unit.valid?
-      unit.instance_variables.select{|iv_name| iv_name !~ /^@_/}.should be_empty
-    end
-  end
-
-  it "should clear errors before validation" do
-    class Unit < BaseUnit
-      validates_presence_of :name
-    end
-
-    unit = Unit.new
-    unit.should_not be_valid
-    unit.name = 'Zeratul'
-    unit.should be_valid
-  end
-
-  describe "special" do
-    it 'validates_uniqueness_of' do
-      class Unit < BaseUnit
-        validates_uniqueness_of :name
-      end
-
-      unit = Unit.build name: 'Zeratul'
-      unit.save.should be_true
-
-      unit = Unit.build name: 'Zeratul'
-      unit.save.should be_false
-      unit.errors[:name].first.should =~ /unique/
-    end
-
-    it 'validates_uniqueness_of with scope' do
-      class Unit < BaseUnit
-        attr_accessor :account_id
-
-        validates_uniqueness_of :name, scope: :account_id
-      end
-
-      unit = Unit.build name: 'Zeratul', account_id: '10'
-      unit.save.should be_true
-
-      unit = Unit.build name: 'Zeratul', account_id: '10'
-      unit.save.should be_false
-
-      unit = Unit.build name: 'Zeratul', account_id: '20'
-      unit.save.should be_true
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mongodb_model
 version: !ruby/object:Gem::Version
-  version: 0.2.8
+  version: 2.0.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-10-11 00:00:00.000000000Z
+date: 2011-11-18 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mongodb
-  requirement: &2829180 !ruby/object:Gem::Requirement
+  requirement: &2848940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2829180
+  version_requirements: *2848940
 - !ruby/object:Gem::Dependency
   name: validatable2
-  requirement: &2828940 !ruby/object:Gem::Requirement
+  requirement: &2848700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2828940
+  version_requirements: *2848700
 - !ruby/object:Gem::Dependency
   name: ruby_ext
-  requirement: &2828700 !ruby/object:Gem::Requirement
+  requirement: &2848460 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,7 +43,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2828700
+  version_requirements: *2848460
 description: 
 email: 
 executables: []
@@ -58,16 +58,19 @@ files:
 - lib/mongo/model/conversion.rb
 - lib/mongo/model/crud.rb
 - lib/mongo/model/db.rb
-- lib/mongo/model/file_model.rb
+- lib/mongo/model/integration/file_model.rb
 - lib/mongo/model/integration/rails.rb
+- lib/mongo/model/integration/validatable/uniqueness_validator.rb
+- lib/mongo/model/integration/validatable.rb
+- lib/mongo/model/load.rb
 - lib/mongo/model/misc.rb
 - lib/mongo/model/model.rb
 - lib/mongo/model/query.rb
 - lib/mongo/model/query_mixin.rb
 - lib/mongo/model/scope.rb
 - lib/mongo/model/spec.rb
-- lib/mongo/model/support/types.rb
-- lib/mongo/model/validation/uniqueness_validator.rb
+- lib/mongo/model/support/conversions.rb
+- lib/mongo/model/support.rb
 - lib/mongo/model/validation.rb
 - lib/mongo/model.rb
 - lib/mongodb_model/gems.rb
@@ -79,7 +82,8 @@ files:
 - spec/crud_spec.rb
 - spec/db_spec.rb
 - spec/equality_spec.rb
-- spec/file_model_spec.rb
+- spec/integration/file_model_spec.rb
+- spec/integration/validatable_spec.rb
 - spec/misc_spec.rb
 - spec/query_spec.rb
 - spec/scope_spec.rb