mongodb_model 0.2.8 → 2.0.0

data/spec/crud_spec.rb

@@ -1,83 +1,81 @@
 require 'spec_helper'
-require 'mongo/object/spec/crud_shared'
+require 'mongo/object/spec/shared_object_crud'
 
 describe "Model CRUD" do
   with_mongo_model
 
-  describe 'simple' do
-    before :all do
+  describe 'single model' do
+    it_should_behave_like "single object CRUD"
+
+    before do
       class Unit
         inherit Mongo::Model
         collection :units
 
         attr_accessor :name, :info
-        def == o; [self.class, name, info] == [o.class, o.respond_to(:name), o.respond_to(:info)] end
+        def == o; [self.class, name, info] == [o.class, o.name, o.info] end
       end
-    end
-    after(:all){remove_constants :Unit}
 
-    before do
-      @zeratul = Unit.build name: 'Zeratul', info: 'Dark Templar'
+      @unit = Unit.build name: 'Zeratul', info: 'Dark Templar'
     end
+    after{remove_constants :Unit}
 
-    it_should_behave_like "object CRUD"
-
-    it 'model crud' do
-      # read
+    it 'should perform CRUD' do
+      # Read.
       Unit.count.should == 0
       Unit.all.should == []
       Unit.first.should == nil
 
-      # create
-      @zeratul.save.should be_true
-      @zeratul._id.should_not be_nil
+      # Create.
+      @unit.save.should be_true
+      @unit._id.should_not be_nil
 
-      # read
+      # Read.
       Unit.count.should == 1
-      Unit.all.should == [@zeratul]
-      Unit.first.should == @zeratul
-      Unit.first.object_id.should_not == @zeratul.object_id
+      Unit.all.should == [@unit]
+      Unit.first.should == @unit
+      Unit.first.object_id.should_not == @unit.object_id
 
-      # update
-      @zeratul.info = 'Killer of Cerebrates'
-      @zeratul.save.should be_true
+      # Update.
+      @unit.info = 'Killer of Cerebrates'
+      @unit.save.should be_true
       Unit.count.should == 1
       Unit.first(name: 'Zeratul').info.should == 'Killer of Cerebrates'
 
-      # destroy
-      @zeratul.destroy.should be_true
+      # Delete.
+      @unit.delete.should be_true
       Unit.count.should == 0
     end
 
-    it 'should be able to save to another collection' do
-      # create
-      @zeratul.save(collection: db.heroes).should be_true
-      @zeratul._id.should_not be_nil
+    it 'should be able to save model to another collection' do
+      # Create.
+      @unit.save(collection: db.heroes).should be_true
+      @unit._id.should_not be_nil
 
-      # read
+      # Read.
       Unit.count.should == 0
       db.heroes.count.should == 1
-      db.heroes.first.should == @zeratul
-      db.heroes.first.object_id.should_not == @zeratul.object_id
+      db.heroes.first.should == @unit
+      db.heroes.first.object_id.should_not == @unit.object_id
 
-      # update
-      @zeratul.info = 'Killer of Cerebrates'
-      @zeratul.save(collection: db.heroes).should be_true
+      # Update.
+      @unit.info = 'Killer of Cerebrates'
+      @unit.save(collection: db.heroes).should be_true
       Unit.count.should == 0
       db.heroes.count.should == 1
       db.heroes.first(name: 'Zeratul').info.should == 'Killer of Cerebrates'
 
-      # destroy
-      @zeratul.destroy(collection: db.heroes).should be_true
+      # Delete.
+      @unit.delete(collection: db.heroes).should be_true
       db.heroes.count.should == 0
     end
 
-    it 'build' do
+    it 'should build model' do
       u = Unit.build name: 'Zeratul'
       u.name.should == 'Zeratul'
     end
 
-    it 'create' do
+    it 'should create model' do
       u = Unit.create(name: 'Zeratul')
       u.new_record?.should be_false
 
@@ -85,16 +83,16 @@ describe "Model CRUD" do
       u.new_record?.should be_false
     end
 
-    it 'destroy_all' do
+    it 'should delete all models' do
       Unit.create(name: 'Zeratul')
       Unit.count.should == 1
-      Unit.destroy_all
+      Unit.delete_all
       Unit.count.should == 0
 
-      Unit.destroy_all!
+      Unit.delete_all!
     end
 
-    it 'modifiers' do
+    it 'should accept modifiers' do
       unit = Unit.create! name: 'Zeratul'
 
       Unit.update({_id: unit._id}, _set: {name: 'Tassadar'})
@@ -107,57 +105,57 @@ describe "Model CRUD" do
     end
   end
 
-  describe 'embedded' do
-    before :all do
-      class Player
+  describe 'embedded model' do
+    it_should_behave_like 'embedded object CRUD'
+
+    before do
+      class Unit
         inherit Mongo::Model
-        collection :players
+        collection :units
 
-        attr_accessor :missions
-        def == o; [self.class, self.missions] == [o.class, o.respond_to(:missions)] end
+        attr_accessor :items
+        def == o; [self.class, self.items] == [o.class, o.items] end
 
-        class Mission
+        class Item
           inherit Mongo::Model
 
-          attr_accessor :name, :stats
-          def == o; [self.class, self.name, self.stats] == [o.class, o.respond_to(:name), o.respond_to(:stats)] end
+          attr_accessor :name
+          def == o; [self.class, self.name] == [o.class, o.name] end
         end
       end
-    end
-    after(:all){remove_constants :Player}
 
-    before do
-      @mission_class = Player::Mission
-      @player = Player.new
-      @player.missions = [
-        Player::Mission.build(name: 'Wasteland',         stats: {'buildings' => 5, 'units' => 10}),
-        Player::Mission.build(name: 'Backwater Station', stats: {'buildings' => 8, 'units' => 25}),
+      @item_class = Unit::Item
+      @unit = Unit.new
+      @unit.items = [
+        Unit::Item.build(name: 'Psionic blade'),
+        Unit::Item.build(name: 'Plasma shield'),
       ]
     end
+    after{remove_constants :Unit}
 
-    it_should_behave_like 'embedded object CRUD'
+    it 'should perform CRUD' do
+      # Create.
+      @unit.save.should be_true
+      @unit._id.should_not be_nil
 
-    it 'crud' do
-      # create
-      @player.save.should be_true
-      @player._id.should_not be_nil
-
-      # read
-      Player.count.should == 1
-      Player.first.should == @player
-      Player.first.object_id.should_not == @players.object_id
-
-      # update
-      @player.missions.first.stats['units'] = 9
-      @player.missions << Player::Mission.build(name: 'Desperate Alliance', stats: {'buildings' => 11, 'units' => 40})
-      @player.save.should be_true
-      Player.count.should == 1
-      Player.first.should == @player
-      Player.first.object_id.should_not == @player.object_id
-
-      # destroy
-      @player.destroy.should be_true
-      Player.count.should == 0
+      # Read.
+      Unit.count.should == 1
+      unit = Unit.first
+      unit.should == @unit
+      unit.object_id.should_not == @unit.object_id
+
+      # Update.
+      @unit.items.first.name = "Psionic blade level 3"
+      @unit.items << Unit::Item.build(name: 'Power suit')
+      @unit.save.should be_true
+      Unit.count.should == 1
+      unit = Unit.first
+      unit.should == @unit
+      unit.object_id.should_not == @unit.object_id
+
+      # Delete.
+      @unit.delete.should be_true
+      Unit.count.should == 0
     end
   end
 end

data/spec/equality_spec.rb

@@ -3,34 +3,44 @@ require 'spec_helper'
 describe 'Model equality' do
   with_mongo_model
 
-  after{remove_constants :Player, :Tags}
+  after{remove_constants :Unit, :Tags}
 
-  it "integration smoke test" do
-    class Player
+  it "should check for equality based on model attributes" do
+    class Unit
       inherit Mongo::Model
 
-      attr_accessor :name, :mission
+      attr_accessor :name, :items
 
-      class Mission
+      class Item
         inherit Mongo::Model
 
         attr_accessor :name
       end
     end
 
-    player1 = Player.new name: 'Alex'
-    player1.mission = Player::Mission.new name: 'First Strike'
+    unit1 = Unit.new name: 'Zeratul'
+    unit1.items = [Unit::Item.new(name: 'Psionic blade')]
 
-    player2 = Player.new name: 'Alex'
-    player2.mission = Player::Mission.new name: 'First Strike'
+    unit2 = Unit.new name: 'Zeratul'
+    unit2.items = [Unit::Item.new(name: 'Psionic blade')]
 
-    player1.should == player2
+    unit1.should == unit2
 
-    player1.mission.name = 'Into the Flames'
-    player1.should_not == player2
+    unit1.items.first.name = 'Power suit'
+    unit1.should_not == unit2
   end
 
-  it "should correct compare Array/Hash models (from error)" do
+  it "should compare with non models (from errors)" do
+    class Unit
+      inherit Mongo::Model
+    end
+
+    unit = Unit.new
+    unit.should_not == 1
+    unit.should_not == nil
+  end
+
+  it "should correctly compare Array/Hash models (from error)" do
     class Tags < Array
       inherit Mongo::Model
     end

data/spec/{file_model_spec.rb → integration/file_model_spec.rb}

@@ -1,7 +1,7 @@
 require 'spec_helper'
 require 'file_model/spec/shared_crud'
 
-describe 'File Model' do
+describe 'Integration with File Model' do
   with_mongo_model
   it_should_behave_like "file model crud"
 

data/spec/integration/validatable_spec.rb

@@ -0,0 +1,89 @@
+require 'spec_helper'
+
+describe "Integration with Validatable" do
+  with_mongo_model
+
+  describe "basics" do
+    before do
+      class Unit
+        inherit Mongo::Model
+        collection :units
+
+        attr_accessor :name
+      end
+    end
+    after{remove_constants :Unit}
+
+    it "should perform basic validation" do
+      class Unit
+        validates_presence_of :name
+      end
+
+      unit = Unit.new
+      unit.should_not be_valid
+      unit.errors.size.should == 1
+      unit.errors.first.first.should == :name
+      unit.save.should be_false
+
+      unit.errors.clear
+      unit.name = 'Zeratul'
+      unit.should be_valid
+      unit.errors.should be_empty
+      unit.save.should be_true
+    end
+
+    it "should validate before save" do
+      unit = Unit.new
+      unit.should_receive(:run_validations)
+      unit.save
+    end
+
+    it "should not save errors as instance variables" do
+      unit = Unit.new
+      unit.valid?
+      unit.instance_variables.select{|iv_name| iv_name !~ /^@_/}.should be_empty
+    end
+  end
+
+  describe "Special validators" do
+    before do
+      class Unit
+        inherit Mongo::Model
+        collection :units
+
+        attr_accessor :name
+      end
+    end
+    after{remove_constants :Unit}
+
+    it 'should validate uniqueness' do
+      class Unit
+        validates_uniqueness_of :name
+      end
+
+      unit = Unit.build name: 'Zeratul'
+      unit.save.should be_true
+
+      unit = Unit.build name: 'Zeratul'
+      unit.save.should be_false
+      unit.errors[:name].first.should =~ /unique/
+    end
+
+    it 'should validate uniqueness within scope' do
+      class Unit
+        attr_accessor :account_id
+
+        validates_uniqueness_of :name, scope: :account_id
+      end
+
+      unit = Unit.build name: 'Zeratul', account_id: '10'
+      unit.save.should be_true
+
+      unit = Unit.build name: 'Zeratul', account_id: '10'
+      unit.save.should be_false
+
+      unit = Unit.build name: 'Zeratul', account_id: '20'
+      unit.save.should be_true
+    end
+  end
+end

data/spec/misc_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe 'Model Miscellaneous' do
+describe 'Miscellaneous' do
   with_mongo_model
 
   before do
@@ -13,7 +13,7 @@ describe 'Model Miscellaneous' do
   end
   after{remove_constants :Unit3, :User}
 
-  it "timestamps" do
+  it "should create timestamps" do
     class Unit3
       inherit Mongo::Model
       collection :units
@@ -36,7 +36,7 @@ describe 'Model Miscellaneous' do
     unit.updated_at.should >  updated_at
   end
 
-  it 'cache' do
+  it 'should have cache' do
     class Unit3
       inherit Mongo::Model
     end
@@ -44,21 +44,21 @@ describe 'Model Miscellaneous' do
     u._cache.should == {}
   end
 
-  it "to_param" do
+  it "should convert model to param" do
     u = User.new
     u.to_param.should be_nil
     u.save!
     u.to_param.should_not be_empty
   end
 
-  it "dom_id" do
+  it "should have dom_id" do
     u = User.new
     u.dom_id.should be_nil
     u.save!
     u.dom_id.should_not be_empty
   end
 
-  it 'reload' do
+  it 'should reload model' do
     u = User.create! name: 'Zeratul'
     u.name = 'Jim'
     u.reload

data/spec/query_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "Model Query" do
+describe "Query" do
   with_mongo_model
 
   before :all do
@@ -13,32 +13,32 @@ describe "Model Query" do
   end
   after(:all){remove_constants :Unit, :SpecialUnit}
 
-  before{@zeratul = Unit.build name: 'Zeratul'}
+  before{@unit = Unit.build name: 'Zeratul'}
 
-  it 'exist?' do
+  it 'should check existence' do
     Unit.should_not exist(name: 'Zeratul')
-    @zeratul.save!
+    @unit.save!
     Unit.should exist(name: 'Zeratul')
   end
 
-  it 'first, first!' do
+  it 'should return first model (also with bang version)' do
     Unit.first.should be_nil
     -> {Unit.first!}.should raise_error(Mongo::NotFound)
-    @zeratul.save
+    @unit.save
     Unit.first.should_not be_nil
     Unit.first!.should_not be_nil
   end
 
-  it 'all, each' do
+  it 'should return all and iterate over each models' do
     list = []; Unit.each{|o| list << o}
     list.size.should == 0
 
-    @zeratul.save
+    @unit.save
     list = []; Unit.each{|o| list << o}
     list.size.should == 1
   end
 
-  it 'dynamic finders integration' do
+  it 'should have dynamic finders' do
     Unit.first_by_name('Zeratul').should be_nil
     u = Unit.build(name: 'Zeratul')
     u.save!
@@ -46,7 +46,7 @@ describe "Model Query" do
     Unit.by_id!(u._id).name.should == 'Zeratul'
   end
 
-  it 'build, create, create!' do
+  it 'should be integrated with build, create and create!' do
     class SpecialUnit < Unit
       attr_accessor :age
     end
@@ -54,27 +54,18 @@ describe "Model Query" do
     u = SpecialUnit.query(name: 'Zeratul').build age: 500
     [u.name, u.age].should == ['Zeratul', 500]
 
-    SpecialUnit.destroy_all
+    SpecialUnit.delete_all
     SpecialUnit.query(name: 'Zeratul').create age: 500
     u = SpecialUnit.first
     [u.name, u.age].should == ['Zeratul', 500]
 
-    SpecialUnit.destroy_all
+    SpecialUnit.delete_all
     SpecialUnit.query(name: 'Zeratul').create! age: 500
     u = SpecialUnit.first
     [u.name, u.age].should == ['Zeratul', 500]
   end
 
-  it 'exist?' do
-    u = Unit.new
-    u.exist?.should be_false
-    u.save!
-    u.exist?.should be_true
-    u.destroy!
-    u.exist?.should be_false
-  end
-
-  it "build should assign protected attributes" do
+  it "should not allow to mass-assign protected attributes" do
     class SpecialUnit < Unit
       attr_accessor :age, :status
       assign do
@@ -88,9 +79,7 @@ describe "Model Query" do
     u.status.should == 'active'
   end
 
-  it "where" do
-    # Unit.where(name: 'Zeratul').should == Mongo::Model::Query.new(Unit, {name: 'Zeratul'}, {})
-
+  it "should support where clause" do
     query = Unit.where(name: 'Zeratul')
     query = query.where(race: 'Protoss')
     query.should == Mongo::Model::Query.new(Unit, {name: 'Zeratul', race: 'Protoss'}, {})

data/spec/scope_spec.rb

@@ -45,7 +45,7 @@ describe "Scope" do
       Unit.current_scope.should be_nil
     end
 
-    it "definition" do
+    it "should allow to define default scope" do
       Unit.default_scope status: 'alive'
 
       Unit.current_scope.should == Unit.query(status: 'alive')
@@ -56,7 +56,7 @@ describe "Scope" do
       Unit.current_scope.should == Unit.query(status: 'alive')
     end
 
-    it "should be inherited" do
+    it "should inherit default scope" do
       Unit.default_scope status: 'alive'
 
       class Protoss < Unit; end
@@ -69,7 +69,7 @@ describe "Scope" do
   end
 
   describe 'scope' do
-    it "definition" do
+    it "should allow to define scope" do
       Unit.scope :alive, status: 'alive'
       Unit.alive.current_scope.should == Unit.query(status: 'alive')
 
@@ -101,7 +101,7 @@ describe "Scope" do
     end
   end
 
-  describe 'with_scope' do
+  describe 'querying with scope' do
     it "shouldn't allow to nest exclusive scope" do
       -> {
         Unit.with_exclusive_scope do
@@ -116,7 +116,7 @@ describe "Scope" do
       }.should raise_error(/exclusive scope already applied/)
     end
 
-    it "with_exclusive_scope should clear other scopes" do
+    it "should clear other scopes when exclusive scope used" do
       Unit.default_scope status: 'alive'
 
       Unit.with_scope race: 'Protoss' do
@@ -132,13 +132,13 @@ describe "Scope" do
       end
     end
 
-    it "usage" do
+    it "should access current scope" do
       Unit.with_scope status: 'alive' do
         Unit.current_scope.should == Unit.query(status: 'alive')
       end
     end
 
-    it "should merge scope" do
+    it "should merge scopes" do
       Unit.default_scope status: 'alive'
       Unit.with_scope race: 'Protoss' do
         Unit.with_scope name: 'Zeratul' do
@@ -149,13 +149,13 @@ describe "Scope" do
   end
 
   describe 'handy scopes' do
-    it "limit, skip, sort" do
+    it "should provide limit, skip and sort scopes" do
       query = Unit.skip(30).limit(10).sort([:name, 1]).snapshot
       query.selector.should == {}
       query.options.should == {skip: 30, limit: 10, sort: [[:name, 1]], snapshot: true}
     end
 
-    it "sort should understand simplified form" do
+    it "should understand simplified form of sort scope" do
       query = Unit.sort(:name)
       query.options.should == {sort: [[:name, 1]]}
 
@@ -163,7 +163,7 @@ describe "Scope" do
       query.options.should == {sort: [[:race, 1], [:name, 1]]}
     end
 
-    it 'paginate' do
+    it 'should provide paginate' do
       query = Unit.paginate(4, 10)
       query.selector.should == {}
       query.options.should == {skip: 30, limit: 10}

data/spec/spec_helper.rb

@@ -3,11 +3,27 @@ require 'mongo/model'
 require 'rspec_ext'
 require 'mongo/model/spec'
 
-#
-# Handy spec helpers
-#
+# Shortcuts.
 rspec do
   def db
     mongo.db
   end
+end
+
+# Helper to simplify callback expectations.
+module RSpec::CallbackHelper
+  def run_before_callbacks name, method, options = {}
+    $_dont_watch_callbacks ? true : send(:"before_#{name}")
+  end
+
+  def run_after_callbacks name, method, options = {}
+    $_dont_watch_callbacks ? true : send(:"after_#{name}")
+  end
+
+  def dont_watch_callbacks &block
+    $_dont_watch_callbacks = true
+    block.call
+  ensure
+    $_dont_watch_callbacks = false
+  end
 end