mongo_mapper 0.13.1 → 0.14.0.rc1

data/spec/functional/associations/one_embedded_proxy_spec.rb

@@ -38,7 +38,7 @@ describe "OneEmbeddedProxy" do
     post.reload
 
     post.author.should == author
-    post.author.nil?.should be_false
+    post.author.nil?.should be_falsey
 
     new_author = @author_class.new(:name => 'Emily')
     post.author = new_author
@@ -72,10 +72,10 @@ describe "OneEmbeddedProxy" do
     @post_class.one :author, :class => @author_class
 
     post = @post_class.new
-    post.author?.should be_false
+    post.author?.should be_falsey
 
     post.author = @author_class.new(:name => 'Frank')
-    post.author?.should be_true
+    post.author?.should be_truthy
   end
 
   it "should initialize id for nested embedded document created from hash" do

data/spec/functional/associations/one_proxy_spec.rb

@@ -11,7 +11,7 @@ describe "OneProxy" do
 
   it "should default to nil" do
     @post_class.one :author, :class => @author_class
-    @post_class.new.author.nil?.should be_true
+    @post_class.new.author.nil?.should be_truthy
   end
 
   it "should return nil instead of a proxy" do
@@ -25,7 +25,7 @@ describe "OneProxy" do
     post = @post_class.new('author' => { 'name' => 'Frank' })
     post.author.name.should == 'Frank'
 
-    post.save.should be_true
+    post.save.should be_truthy
     post.reload
 
     post.author.name.should == 'Frank'
@@ -42,7 +42,7 @@ describe "OneProxy" do
         post.reload
 
         post.author.should == author
-        post.author.nil?.should be_false
+        post.author.nil?.should be_falsey
 
         new_author = @author_class.new(:name => 'Emily')
         post.author = new_author
@@ -58,7 +58,7 @@ describe "OneProxy" do
         post.reload
 
         post.author.should == author
-        post.author.nil?.should be_false
+        post.author.nil?.should be_falsey
 
         original_author = post.author
         original_author.name.should == 'Frank'
@@ -79,7 +79,7 @@ describe "OneProxy" do
         post.reload
 
         post.author.name.should == 'Frank'
-        post.author.nil?.should be_false
+        post.author.nil?.should be_falsey
 
         post.author = {'name' => 'Emily'}
         post.author.name.should == 'Emily'
@@ -97,7 +97,7 @@ describe "OneProxy" do
         end
 
         it "should call delete on the existing document" do
-          @author_class.any_instance.should_receive(:delete).once
+          expect_any_instance_of(@author_class).to receive(:delete).once
           @post.author = @author_class.new
         end
 
@@ -107,7 +107,7 @@ describe "OneProxy" do
         end
 
         it "should do nothing if it's the same document" do
-          @author_class.any_instance.should_receive(:delete).never
+          expect_any_instance_of(@author_class).to receive(:delete).never
           @post.author = @author
         end
       end
@@ -122,7 +122,7 @@ describe "OneProxy" do
         end
 
         it "should call destroy the existing document" do
-          @author_class.any_instance.should_receive(:destroy).once
+          expect_any_instance_of(@author_class).to receive(:destroy).once
           @post.author = @author_class.new
         end
 
@@ -132,7 +132,7 @@ describe "OneProxy" do
         end
 
         it "should do nothing if it's the same document" do
-          @author_class.any_instance.should_receive(:destroy).never
+          expect_any_instance_of(@author_class).to receive(:destroy).never
           @post.author = @author
         end
       end
@@ -207,10 +207,10 @@ describe "OneProxy" do
     @post_class.one :author, :class => @author_class
 
     post = @post_class.new
-    post.author?.should be_false
+    post.author?.should be_falsey
 
     post.author = @author_class.new(:name => 'Frank')
-    post.author?.should be_true
+    post.author?.should be_truthy
   end
 
   it "should work with criteria" do
@@ -232,7 +232,7 @@ describe "OneProxy" do
     post.update_attributes!(:author => author)
     post.reload
     post.author = nil
-    post.author.nil?.should be_true
+    post.author.nil?.should be_truthy
   end
 
   context "destroying parent with :dependent" do
@@ -246,7 +246,7 @@ describe "OneProxy" do
       end
 
       it "should should call destroy on the associated documents" do
-        @author_class.any_instance.should_receive(:destroy).once
+        expect_any_instance_of(@author_class).to receive(:destroy).once
         @post.destroy
       end
 
@@ -268,7 +268,7 @@ describe "OneProxy" do
       end
 
       it "should should call delete the associated documents" do
-        @author_class.any_instance.should_receive(:delete).once
+        expect_any_instance_of(@author_class).to receive(:delete).once
         @post.destroy
       end
 

data/spec/functional/caching_spec.rb

@@ -6,16 +6,16 @@ describe "Caching" do
       extend MongoMapper::Plugins
       plugin MongoMapper::Plugins::Caching
     end
-    @klass.stub(:name).and_return('Post')
-    @klass.any_instance.stub(:persisted?).and_return(true)
-    @klass.any_instance.stub(:[]).and_return(nil)
-    @klass.any_instance.stub(:[]=).and_return(nil)
+    allow(@klass).to receive(:name).and_return('Post')
+    allow_any_instance_of(@klass).to receive(:persisted?).and_return(true)
+    allow_any_instance_of(@klass).to receive(:[]).and_return(nil)
+    allow_any_instance_of(@klass).to receive(:[]=).and_return(nil)
   end
 
   context "new" do
     before do
       @doc = @klass.new
-      @doc.stub(:persisted?).and_return(false)
+      allow(@doc).to receive(:persisted?).and_return(false)
     end
 
     it "should be class/new" do
@@ -35,14 +35,14 @@ describe "Caching" do
     before do
       @object_id = BSON::ObjectId.new
       @doc = @klass.new
-      @doc.stub(:persisted).and_return(true)
-      @doc.stub(:id).and_return(@object_id)
+      allow(@doc).to receive(:persisted).and_return(true)
+      allow(@doc).to receive(:id).and_return(@object_id)
     end
 
     context "with updated_at" do
       before do
         time = Time.utc(2010, 6, 20, 8, 10, 7)
-        @doc.stub(:[]).with(:updated_at).and_return(time)
+        allow(@doc).to receive(:[]).with(:updated_at).and_return(time)
       end
 
       it "should be class/id-timestamp" do

data/spec/functional/callbacks_spec.rb

@@ -240,4 +240,91 @@ describe "Callbacks" do
       doc.message.should == 'Ho!'
     end
   end
+
+  describe "after_find" do
+    before do
+      @found_objects = []
+      found_objects = @found_objects # use a local for closure
+
+      @doc_class = Doc("User") do
+        after_find :set_found_object
+
+        define_method :set_found_object do
+          found_objects << self
+        end
+      end
+    end
+
+    it "should run after finding an object with find!" do
+      @doc = @doc_class.create!
+
+      @doc_class.find!(@doc.id)
+      @found_objects.should == [@doc]
+    end
+
+    it "should not have run if nothing was queried" do
+      @found_objects.should == []
+    end
+
+    it "should run for multiple objects" do
+      @doc1 = @doc_class.create!
+      @doc2 = @doc_class.create!
+
+      @doc_class.all
+      @found_objects.should == [@doc1, @doc2]
+    end
+
+    it "should run after finding an object through the query proxy" do
+      @doc = @doc_class.create!
+      @doc_class.where(:_id => @doc.id).first
+      @found_objects.should == [@doc]
+    end
+
+    it "should still return the object" do
+      @doc = @doc_class.create!
+      @doc_class.where(:_id => @doc.id).first.should == @doc
+    end
+
+    it "should not bail if the method return false" do
+      @doc_class = Doc("User") do
+        after_find :set_found_object
+
+        define_method :set_found_object do
+          false
+        end
+      end
+
+      @doc = @doc_class.create!
+      @doc_class.where(:_id => @doc.id).first.should == @doc
+    end
+  end
+
+  describe "after_initialize" do
+    before do
+      @objects = []
+      objects = @objects
+
+      @doc_class = Doc("User") do
+        after_initialize :set_initialized_object
+
+        define_method :set_initialized_object do
+          objects << self
+        end
+      end
+    end
+
+    it "should be triggered for objects created with new" do
+      @objects.should == []
+      obj = @doc_class.new
+      @objects.should == [obj]
+    end
+
+    it "should be triggered for objects found in the db" do
+      @doc = @doc_class.create!
+      @objects.clear # don't re-assign as we want the operation to be in place
+
+      @doc_class.all
+      @objects.should == [@doc]
+    end
+  end
 end

data/spec/functional/counter_cache_spec.rb

@@ -15,6 +15,7 @@ module CounterCacheFixtureModels
 
     key :comments_count, Integer, :default => 0
     key :some_custom_comments_count, Integer, :default => 0
+    key :commentable_count, Integer, :default => 0
 
     has_many :comments,
              :class_name => "CounterCacheFixtureModels::Comment"
@@ -22,6 +23,20 @@ module CounterCacheFixtureModels
     belongs_to :user,
                :counter_cache => true,
                :class_name => "CounterCacheFixtureModels::User"
+
+    many :polymorphic_comments,
+         :as => :commentable,
+         :class_name => "CounterCacheFixtureModels::Comment"
+  end
+
+  class Article
+    include MongoMapper::Document
+
+    key :commentable_count, Integer, :default => 0
+
+    many :polymorphic_comments,
+         :as => :commentable,
+         :class_name => "CounterCacheFixtureModels::Comment"
   end
 
   class Comment
@@ -30,6 +45,10 @@ module CounterCacheFixtureModels
     belongs_to :post,
                :counter_cache => true,
                :class_name => "CounterCacheFixtureModels::Post"
+
+    belongs_to :commentable,
+               :polymorphic => true,
+               :counter_cache => :commentable_count
   end
 
   class CustomComment
@@ -143,4 +162,74 @@ describe MongoMapper::Plugins::CounterCache do
       end
     }.should raise_error(MongoMapper::Plugins::CounterCache::InvalidCounterCacheError, "Missing `key :invalid_field, Integer, :default => 0' on model CounterCacheFixtureModels::Post")
   end
+
+  describe "with polymorphic associations" do
+    before do
+      @article = CounterCacheFixtureModels::Article.new
+      @comment = CounterCacheFixtureModels::Comment.new
+      @comment.commentable = @article
+    end
+
+    it "should update the counter cache on save" do
+      expect {
+        @comment.save!
+        @article.reload
+      }.to change(@article, :commentable_count).by(1)
+    end
+
+    it "should increment with a second object" do
+      @comment.save!
+
+      expect {
+        second_comment = CounterCacheFixtureModels::Comment.new
+        second_comment.commentable = @article
+        second_comment.save!
+        @article.reload
+      }.to change(@article, :commentable_count).by(1)
+    end
+
+    it "should decrement the counter cache on destroy" do
+      @comment.save!
+
+      expect {
+        @comment.destroy
+        @article.reload
+      }.to change(@article, :commentable_count).by(-1)
+    end
+
+    it "should increment with a different type of object" do
+      @comment.save!
+
+      expect {
+        second_comment = CounterCacheFixtureModels::Comment.new
+        second_comment.commentable = @article
+        second_comment.save!
+
+        @article.reload
+      }.to change(@article, :commentable_count).by(1)
+    end
+
+    describe "without a counter cache field" do
+      before do
+        @comment = CounterCacheFixtureModels::Comment.new
+        @klass = Class.new do
+          include MongoMapper::Document
+
+          many :polymorphic_comments,
+               :as => :commentable,
+               :class_name => "CounterCacheFixtureModels::Comment"
+        end
+
+        @obj = @klass.new
+      end
+
+      it "should raise at save (runtime) if there is no counter cache field" do
+        @comment.commentable = @obj
+
+        expect {
+          @comment.save!
+        }.to raise_error(MongoMapper::Plugins::CounterCache::InvalidCounterCacheError)
+      end
+    end
+  end
 end

data/spec/functional/dirty_spec.rb

@@ -11,73 +11,73 @@ describe "Dirty" do
   context "marking changes" do
     it "should not happen if there are none" do
       doc = @document.new
-      doc.phrase_changed?.should be_false
+      doc.phrase_changed?.should be_falsey
       doc.phrase_change.should be_nil
     end
 
     it "should happen when change happens" do
       doc = @document.new
       doc.phrase = 'Golly Gee Willikers Batman'
-      doc.phrase_changed?.should be_true
+      doc.phrase_changed?.should be_truthy
       doc.phrase_was.should be_nil
       doc.phrase_change.should == [nil, 'Golly Gee Willikers Batman']
     end
 
     it "should happen when initializing" do
       doc = @document.new(:phrase => 'Foo')
-      doc.changed?.should be_true
+      doc.changed?.should be_truthy
     end
 
     it "should clear changes on save" do
       doc = @document.new
       doc.phrase = 'Golly Gee Willikers Batman'
-      doc.phrase_changed?.should be_true
+      doc.phrase_changed?.should be_truthy
       doc.save
-      doc.phrase_changed?.should_not be_true
+      doc.phrase_changed?.should_not be_truthy
       doc.phrase_change.should be_nil
     end
 
     it "should clear changes on save!" do
       doc = @document.new
       doc.phrase = 'Golly Gee Willikers Batman'
-      doc.phrase_changed?.should be_true
+      doc.phrase_changed?.should be_truthy
       doc.save!
-      doc.phrase_changed?.should_not be_true
+      doc.phrase_changed?.should_not be_truthy
       doc.phrase_change.should be_nil
     end
 
     it "should not happen when loading from database" do
       doc = @document.create(:phrase => 'Foo')
-      @document.any_instance.should_receive(:attribute_will_change!).never
-      @document.any_instance.should_receive(:attribute_changed?).never
+      expect_any_instance_of(@document).to receive(:attribute_will_change!).never
+      expect_any_instance_of(@document).to receive(:attribute_changed?).never
       doc = @document.find(doc.id)
-      doc.changed?.should be_false
+      doc.changed?.should be_falsey
     end
 
     it "should not happen when reloading from database" do
       doc = @document.create(:phrase => 'Foo')
       doc = @document.find(doc.id)
 
-      doc.changed?.should be_false
+      doc.changed?.should be_falsey
       doc.phrase = 'Fart'
-      doc.changed?.should be_true
+      doc.changed?.should be_truthy
       doc.reload
-      doc.changed?.should be_false
+      doc.changed?.should be_falsey
     end
 
     it "should happen if changed after loading from database" do
       doc = @document.create(:phrase => 'Foo')
       doc.reload
-      doc.changed?.should be_false
+      doc.changed?.should be_falsey
       doc.phrase = 'Bar'
-      doc.changed?.should be_true
+      doc.changed?.should be_truthy
     end
 
     it "should happen with aliased keys" do
       doc = @document.create(:paragraph => 'Wibbly')
       doc.paragraph = "Wobbly"
-      doc.changed?.should be_true
-      doc.paragraph_changed?.should be_true
+      doc.changed?.should be_truthy
+      doc.paragraph_changed?.should be_truthy
     end
   end
 
@@ -88,7 +88,7 @@ describe "Dirty" do
       [nil, ''].each do |value|
         doc = @document.new
         doc.age = value
-        doc.age_changed?.should be_false
+        doc.age_changed?.should be_falsey
         doc.age_change.should be_nil
       end
     end
@@ -101,7 +101,7 @@ describe "Dirty" do
       [nil, ''].each do |value|
         doc = @document.new
         doc.amount = value
-        doc.amount_changed?.should be_false
+        doc.amount_changed?.should be_falsey
         doc.amount_change.should be_nil
       end
     end
@@ -111,27 +111,27 @@ describe "Dirty" do
     it "should be true if key changed" do
       doc = @document.new
       doc.phrase = 'A penny saved is a penny earned.'
-      doc.changed?.should be_true
+      doc.changed?.should be_truthy
     end
 
     it "should be false if no keys changed" do
-      @document.new.changed?.should be_false
+      @document.new.changed?.should be_falsey
     end
 
     it "should not raise when key name is 'value'" do
       @document.key :value, Integer
 
       doc = @document.new
-      doc.value_changed?.should be_false
+      doc.value_changed?.should be_falsey
     end
 
     it "should be false if the same ObjectId was assigned in String format" do
       @document.key :doc_id, ObjectId
 
       doc = @document.create!(:doc_id => BSON::ObjectId.new)
-      doc.changed?.should be_false
+      doc.changed?.should be_falsey
       doc.doc_id = doc.doc_id.to_s
-      doc.changed?.should be_false
+      doc.changed?.should be_falsey
     end
   end
 
@@ -164,14 +164,14 @@ describe "Dirty" do
       doc = @document.create(:phrase => 'Foo')
 
       doc.phrase << 'bar'
-      doc.phrase_changed?.should be_false
+      doc.phrase_changed?.should be_falsey
 
       doc.phrase_will_change!
-      doc.phrase_changed?.should be_true
+      doc.phrase_changed?.should be_truthy
       doc.phrase_change.should == ['Foobar', 'Foobar']
 
       doc.phrase << '!'
-      doc.phrase_changed?.should be_true
+      doc.phrase_changed?.should be_truthy
       doc.phrase_change.should == ['Foobar', 'Foobar!']
     end
   end
@@ -190,7 +190,7 @@ describe "Dirty" do
 
       milestone = milestone_class.create(:name => 'Launch')
       milestone.project = project_class.create(:name => 'Harmony')
-      milestone.changed?.should be_true
+      milestone.changed?.should be_truthy
       milestone.changed.should == %w(project_id)
     end
   end
@@ -204,11 +204,11 @@ describe "Dirty" do
       validated_doc = validated_class.new
       validated_doc.name = "I'm a changin"
       validated_doc.save
-      validated_doc.changed?.should be_true
+      validated_doc.changed?.should be_truthy
 
       validated_doc.required = 1
       validated_doc.save
-      validated_doc.changed?.should be_false
+      validated_doc.changed?.should be_falsey
     end
   end
 
@@ -224,7 +224,7 @@ describe "Dirty" do
       doc = @document.create(:a=>"b")
       doc.a = "c"
       doc.a = "b"
-      doc.changed?.should be_false
+      doc.changed?.should be_falsey
     end
   end
 
@@ -233,7 +233,7 @@ describe "Dirty" do
       doc = @document.create(:a=>"b")
       doc.a = "c"
       doc.reset_a!
-      doc.changed?.should be_false
+      doc.changed?.should be_falsey
       doc.a.should == "b"
     end
     it "should reset the attribute back to the original value after several changes" do
@@ -242,7 +242,7 @@ describe "Dirty" do
       doc.a = "d"
       doc.a = "e"
       doc.reset_a!
-      doc.changed?.should be_false
+      doc.changed?.should be_falsey
       doc.a.should == "b"
     end
   end
@@ -275,21 +275,21 @@ describe "Dirty" do
 
     it "should track changes" do
       @duck.name = "hi"
-      @duck.changed?.should be_true
+      @duck.changed?.should be_truthy
     end
 
     it "should clear changes when saved" do
       @duck.name = "hi"
-      @duck.changed?.should be_true
+      @duck.changed?.should be_truthy
       @duck.save!
-      @duck.changed?.should_not be_true
+      @duck.changed?.should_not be_truthy
     end
 
     it "should clear changes when the parent is saved" do
       @duck.name = "hi"
-      @duck.changed?.should be_true
+      @duck.changed?.should be_truthy
       @doc.save!
-      @duck.changed?.should_not be_true
+      @duck.changed?.should_not be_truthy
     end
 
     context "with nested embedded documents" do
@@ -302,14 +302,14 @@ describe "Dirty" do
 
       it "should track changes" do
         @dong.name = "hi"
-        @dong.changed?.should be_true
+        @dong.changed?.should be_truthy
       end
 
       it "should clear changes when the root saves" do
         @dong.name = "hi"
-        @dong.changed?.should be_true
+        @dong.changed?.should be_truthy
         @doc.save!
-        @dong.changed?.should be_false
+        @dong.changed?.should be_falsey
       end
     end
   end