mongo_mapper 0.13.1 → 0.14.0.rc1

data/spec/functional/static_keys_spec.rb

@@ -0,0 +1,153 @@
+require 'spec_helper'
+
+describe MongoMapper::Plugins::Keys::Static do
+  before do
+    @klass = Class.new do
+      include MongoMapper::Document
+    end
+  end
+
+  it "is off by default" do
+    @klass.static_keys.should == false
+  end
+
+  it "can be turned on" do
+    @klass.static_keys = true
+    @klass.static_keys.should == true
+  end
+
+  describe "a class with static keys" do
+    before do
+      @klass = Class.new do
+        include MongoMapper::Document
+
+        self.static_keys = true
+
+        attr_accessor :an_accessor
+
+        key "valid_key", String
+      end
+
+      @obj = @klass.new
+    end
+
+    it "should be able to assign to a valid key" do
+      @obj.valid_key = "foo"
+      @obj.valid_key.should == "foo"
+    end
+
+    it "should raise a MissingKeyError if trying to assign to a field that does not exist" do
+      lambda {
+        @obj['foo'] = "foo"
+      }.should raise_error(MongoMapper::Plugins::Keys::Static::MissingKeyError)
+    end
+
+    it "should raise a MissingKeyError if trying to read from a field that does not exist" do
+      lambda {
+        @obj['foo']
+      }.should raise_error(MongoMapper::Plugins::Keys::Static::MissingKeyError)
+    end
+
+    it "should raise a MissingKeyError if trying to set attributes= to a field that does not exist" do
+      lambda {
+        @obj.attributes = {:foo => "foo"}
+      }.should raise_error(MongoMapper::Plugins::Keys::Static::MissingKeyError)
+    end
+
+    it "should be able to call a method" do
+      @obj.an_accessor = :bar
+      @obj.an_accessor.should == :bar
+    end
+
+    it "should raise a NoMethodError if trying to call the non-existant key method" do
+      lambda {
+        @obj.foo
+      }.should raise_error(NoMethodError)
+    end
+
+    it "should raise for read_key" do
+      lambda {
+        @obj.read_key('foo')
+      }.should raise_error(MongoMapper::Plugins::Keys::Static::MissingKeyError)
+    end
+
+    it "should raise for attribute" do
+      lambda {
+        @obj.attribute('foo')
+      }.should raise_error(MongoMapper::Plugins::Keys::Static::MissingKeyError)
+    end
+
+    it "should not raise if trying to assign to a field that exists (but with a symbol instead of a string)" do
+      lambda {
+        @obj.write_key(:valid_key, "foo")
+      }.should_not raise_error
+
+      @obj.valid_key.should == "foo"
+    end
+
+    it "should not raise a MissingKeyError if trying to read from a field that exists (but with a symbol instead of a string)" do
+      lambda {
+        @obj[:valid_key]
+      }.should_not raise_error
+    end
+
+    it "should not blow up when loading if there is a key defined in the db that has not been defined (but it should not load it)" do
+      @klass.collection.insert({ :foo => "bar", :valid_key => "something" })
+      @obj = @klass.first
+      @obj.valid_key.should == "something"
+
+      lambda {
+        @obj.foo
+      }.should raise_error(NoMethodError)
+    end
+  end
+
+  describe "a class without static keys" do
+    before do
+      @klass = Class.new do
+        include MongoMapper::Document
+        key :valid_key, String
+      end
+
+      @obj = @klass.new
+    end
+
+    it "should be able to assign to a valid key" do
+      @obj.valid_key = "foo"
+      @obj.valid_key.should == "foo"
+    end
+
+    it "should be able to read and assign a dynamic key" do
+      @obj['foo'].should be_nil
+      @obj['foo'] = "bar"
+      @obj['foo'].should == "bar"
+    end
+  end
+
+  describe "with mixed static + non static models" do
+    before do
+      @static_model = Class.new do
+        include MongoMapper::Document
+        self.static_keys = true
+      end
+
+      @non_static_model = Class.new do
+        include MongoMapper::Document
+        self.static_keys = false
+      end
+
+      @static_key_object = @static_model.new
+      @non_static_key_object = @non_static_model.new
+    end
+
+    it "should allow non-static key assignment to one, only static assignment to the other" do
+      @non_static_key_object['foo'] = 'bar'
+      @non_static_key_object.foo.should == 'bar'
+      @non_static_key_object['foo'].should == 'bar'
+
+      lambda {
+        @static_key_object['foo'] = 'bar'
+      }.should raise_error
+    end
+  end
+end

data/spec/functional/stats_spec.rb

@@ -59,10 +59,6 @@ describe "Stats" do
       expect(Docs.stats.padding_factor).to eq(Docs.collection.stats['paddingFactor'])
     end
 
-    it "should have the correct system flags" do
-      expect(Docs.stats.system_flags).to eq(Docs.collection.stats['systemFlags'])
-    end
-
     it "should have the correct user flags" do
       expect(Docs.stats.user_flags).to eq(Docs.collection.stats['userFlags'])
     end

data/spec/functional/touch_spec.rb

@@ -61,7 +61,7 @@ describe "Touch" do
 
       it 'should not be true by default' do
         @comment_class.belongs_to :post, :class => @post_class
-        @comment_class.associations[:post].touch?.should_not be_true
+        @comment_class.associations[:post].touch?.should_not be_truthy
       end
 
       context 'touch the parent when true' do

data/spec/functional/validations_spec.rb

@@ -57,7 +57,7 @@ describe "Validations" do
 
     it "should create a new document" do
       instance = @document.create!(:name => "James")
-      instance.new_record?.should be_false
+      instance.new_record?.should be_falsey
     end
   end
 
@@ -140,7 +140,7 @@ describe "Validations" do
         validates_uniqueness_of :name, :scope => :adult
       end
       doc = document.new("name" => "joe", :adult => true)
-      doc.save.should be_true
+      doc.save.should be_truthy
 
       doc2 = document.new("name" => "joe", :adult => false)
       doc2.should be_valid
@@ -149,31 +149,32 @@ describe "Validations" do
     it "should work with i18n taken message" do
       @document.create(:name => 'joe')
       doc = @document.create(:name => 'joe')
-      doc.should have_error_on(:name, 'has already been taken')
+      doc.should have_error_on(:name)
+      doc.errors[:name].should == ['has already been taken']
     end
 
     it "should allow to update an object" do
       doc = @document.new("name" => "joe")
-      doc.save.should be_true
+      doc.save.should be_truthy
 
-      @document \
-        .stub(:first) \
-        .with(:name => 'joe') \
-        .and_return(doc)
+      allow(@document).to \
+        receive(:first).
+        with(:name => 'joe').
+        and_return(doc)
 
       doc.name = "joe"
-      doc.valid?.should be_true
+      doc.valid?.should be_truthy
       doc.should_not have_error_on(:name)
     end
 
     it "should fail if object name is not unique" do
       doc = @document.new("name" => "joe")
-      doc.save.should be_true
+      doc.save.should be_truthy
 
-      @document \
-        .stub(:first) \
-        .with(:name => 'joe') \
-        .and_return(doc)
+      allow(@document).to \
+        receive(:first).
+        with(:name => 'joe').
+        and_return(doc)
 
       doc2 = @document.new("name" => "joe")
       doc2.should have_error_on(:name)
@@ -186,12 +187,12 @@ describe "Validations" do
       end
 
       doc = document.new("name" => "")
-      doc.save.should be_true
+      doc.save.should be_truthy
 
-      document \
-        .stub(:first) \
-        .with(:name => '') \
-        .and_return(doc)
+      allow(@document).to \
+        receive(:first).
+        with(:name => '').
+        and_return(doc)
 
       doc2 = document.new("name" => "")
       doc2.should_not have_error_on(:name)
@@ -204,7 +205,7 @@ describe "Validations" do
       end
 
       doc = document.new('name' => nil)
-      doc.save.should be_true
+      doc.save.should be_truthy
 
       doc2 = document.new('name' => nil)
       doc2.should_not have_error_on(:name)
@@ -217,7 +218,7 @@ describe "Validations" do
       end
 
       doc = document.new("name" => "BLAMMO")
-      doc.save.should be_true
+      doc.save.should be_truthy
 
       doc2 = document.new("name" => "blammo")
       doc2.should_not have_error_on(:name)
@@ -233,7 +234,7 @@ describe "Validations" do
 
       it "should fail on entries that differ only in case" do
         doc = @document.new("name" => "BLAMMO")
-        doc.save.should be_true
+        doc.save.should be_truthy
 
         doc2 = @document.new("name" => "blammo")
         doc2.should have_error_on(:name)
@@ -251,10 +252,10 @@ describe "Validations" do
 
       it "should check for uniqueness using entire string" do
         doc = @document.new("name" => "John Doe")
-        doc.save.should be_true
+        doc.save.should be_truthy
 
         doc2 = @document.new("name" => "John")
-        doc2.valid?.should be_true
+        doc2.valid?.should be_truthy
       end
     end
 
@@ -269,12 +270,12 @@ describe "Validations" do
 
       it "should fail if the same name exists in the scope" do
         doc = @document.new("name" => "joe", "scope" => "one")
-        doc.save.should be_true
+        doc.save.should be_truthy
 
-        @document \
-          .stub(:first) \
-          .with(:name => 'joe', :scope => "one") \
-          .and_return(doc)
+        allow(@document).to \
+          receive(:first).
+          with(:name => 'joe', :scope => "one").
+          and_return(doc)
 
         doc2 = @document.new("name" => "joe", "scope" => "one")
         doc2.should have_error_on(:name)
@@ -282,12 +283,12 @@ describe "Validations" do
 
       it "should pass if the same name exists in a different scope" do
         doc = @document.new("name" => "joe", "scope" => "one")
-        doc.save.should be_true
+        doc.save.should be_truthy
 
-        @document \
-          .stub(:first) \
-          .with(:name => 'joe', :scope => 'two') \
-          .and_return(nil)
+        allow(@document).to \
+          receive(:first).
+          with(:name => 'joe', :scope => 'two').
+          and_return(nil)
 
         doc2 = @document.new("name" => "joe", "scope" => "two")
         doc2.should_not have_error_on(:name)
@@ -306,12 +307,12 @@ describe "Validations" do
 
       it "should fail if the same name exists in the scope" do
         doc = @document.new("name" => "joe", "first_scope" => "one", "second_scope" => "two")
-        doc.save.should be_true
+        doc.save.should be_truthy
 
-        @document \
-          .stub(:first) \
-          .with(:name => 'joe', :first_scope => 'one', :second_scope => 'two') \
-          .and_return(doc)
+        allow(@document).to \
+          receive(:first).
+          with(:name => 'joe', :first_scope => 'one', :second_scope => 'two').
+          and_return(doc)
 
         doc2 = @document.new("name" => "joe", "first_scope" => "one", "second_scope" => "two")
         doc2.should have_error_on(:name)
@@ -319,12 +320,12 @@ describe "Validations" do
 
       it "should pass if the same name exists in a different scope" do
         doc = @document.new("name" => "joe", "first_scope" => "one", "second_scope" => "two")
-        doc.save.should be_true
+        doc.save.should be_truthy
 
-        @document \
-          .stub(:first) \
-          .with(:name => 'joe', :first_scope => 'one', :second_scope => 'one') \
-          .and_return(nil)
+        allow(@document).to \
+          receive(:first).
+          with(:name => 'joe', :first_scope => 'one', :second_scope => 'one').
+          and_return(nil)
 
         doc2 = @document.new("name" => "joe", "first_scope" => "one", "second_scope" => "one")
         doc2.should_not have_error_on(:name)
@@ -345,21 +346,21 @@ describe "Validations" do
 
     it "should pass if there are no associated docs" do
       doc = @root_class.new
-      doc.save.should be_true
+      doc.save.should be_truthy
     end
 
     it "should pass if the associated doc is valid" do
       doc = @root_class.new
       doc.children.build(:name => 'Joe')
-      doc.save.should be_true
+      doc.save.should be_truthy
     end
 
     it "should fail if the associated doc is invalid" do
       doc = @root_class.new
       doc.children.build
-      doc.should have_error_on(:children, 'are invalid')
+      doc.should have_error_on(:children)
+      doc.errors[:children].should == ['are invalid']
     end
-
   end
 
   context "validating associated docs with custom context" do
@@ -377,22 +378,22 @@ describe "Validations" do
 
     it "should pass if there are no associated docs" do
       doc = @root_class.new
-      doc.valid?(:custom_context).should be_true
+      doc.valid?(:custom_context).should be_truthy
     end
 
     it "should pass if the associated doc is valid" do
       doc = @root_class.new
       doc.children.build(:name => 'George')
-      doc.valid?(:custom_context).should be_true
+      doc.valid?(:custom_context).should be_truthy
     end
 
     it "should fail if the associated doc is invalid" do
       doc = @root_class.new
       doc.children.build(:name => 'Bob')
-      doc.valid?(:custom_context).should_not be_true
+      doc.valid?(:custom_context).should_not be_truthy
     end
-
   end
+
   # context "validates uniqueness of with :unique shortcut" do
   #   it "should work" do
   #     @document = Doc do
@@ -402,13 +403,14 @@ describe "Validations" do
   #     doc = @document.create(:name => 'John')
   #     doc.should_not have_error_on(:name)
   #
-  #     @document \
-  #       .stub(:first) \
-  #       .with(:name => 'John') \
-  #       .and_return(doc)
+  #     allow(@document).to \
+  #       receive(:first).
+  #       with(:name => 'John').
+  #       and_return(doc)
   #
   #     second_john = @document.create(:name => 'John')
-  #     second_john.should have_error_on(:name, 'has already been taken')
+  #     second_john.should have_error_on(:name)
+  #     second_john.errors[:name].should == ['has already been taken']
   #   end
   # end
 end

data/spec/quality_spec.rb

@@ -27,7 +27,7 @@ describe "The library itself" do
   end
 
   RSpec::Matchers.define :be_well_formed do
-    failure_message_for_should do |actual|
+    failure_message do |actual|
       actual.join("\n")
     end
 

data/spec/spec_helper.rb

@@ -5,6 +5,7 @@ require 'bundler/setup'
 require 'fileutils'
 require 'timecop'
 require "generator_spec/test_case"
+# require 'ruby-debug'
 
 if RUBY_PLATFORM != "java"
   if ENV['TRAVIS']
@@ -70,9 +71,12 @@ MongoMapper.database = "test"
 MongoMapper.database.collections.each { |c| c.drop_indexes }
 Dir[File.dirname(__FILE__) + "/support/**/*.rb"].each {|f| require f}
 
-RSpec.configure do |c|
-  c.treat_symbols_as_metadata_keys_with_true_values = true
-  c.around(:each, :without_connection) do |example|
+RSpec.configure do |config|
+  config.expect_with :rspec do |c|
+    c.syntax = [:should, :expect]
+  end
+
+  config.around(:each, :without_connection) do |example|
     old, MongoMapper.connection = MongoMapper.connection, nil
     example.run
     MongoMapper.connection = old