mongo_mapper 0.13.0 → 0.15.1

data/spec/functional/associations/in_foreign_array_proxy_spec.rb

@@ -0,0 +1,321 @@
+require 'spec_helper'
+
+describe "InForeignArrayProxyTest" do
+  context "description" do
+    before do
+      class ::List
+        include MongoMapper::Document
+        key :name, String, :required => true
+        key :user_ids, Array
+        many :users, :in => :user_ids
+      end
+
+      class ::User
+        include MongoMapper::Document
+        key :name, String, :required => true
+        many :lists, :from => :user_ids, :as => :user
+      end
+      User.collection.drop
+      List.collection.drop
+    end
+
+    after do
+      Object.send :remove_const, 'List' if defined?(::List)
+      Object.send :remove_const, 'User' if defined?(::User)
+    end
+
+    it "should default reader to empty array" do
+      User.new.lists.should == []
+    end
+
+    it "should allow adding to association like it was an array" do
+      user = User.new(:name => 'John')
+      user.lists <<     List.new(:name => 'Foo1!')
+      user.lists.push   List.new(:name => 'Foo2!')
+      user.lists.concat List.new(:name => 'Foo3!')
+      user.lists.size.should == 3
+    end
+
+    it "should ignore adding duplicate ids" do
+      user = User.create(:name => 'John')
+      list = List.create(:name => 'Foo')
+      user.lists << list
+      user.lists << list
+      user.lists << list
+
+      list.reload.user_ids.should == [user.id]
+      user.lists.count.should == 1
+    end
+
+    it "should be able to replace the association" do
+      user = User.new(:name => 'John')
+      list = List.new(:name => 'Foo')
+      user.lists = [list]
+      user.save.should == true
+
+      user.reload
+      list.reload
+      list.user_ids.should == [user.id]
+      user.lists.size.should == 1
+      user.lists[0].name.should == 'Foo'
+    end
+
+    context "create" do
+      before do
+        @user = User.create(:name => 'John')
+        @list = @user.lists.create(:name => 'Foo!')
+      end
+
+      it "should add id to key" do
+        @list.user_ids.should include(@user.id)
+      end
+
+      it "should persist id addition to key in database" do
+        @list.reload
+        @list.user_ids.should include(@user.id)
+      end
+
+      it "should add doc to association" do
+        @user.lists.should include(@list)
+      end
+
+      it "should save doc" do
+        @list.should_not be_new
+      end
+
+      it "should reset cache" do
+        @user.lists.size.should == 1
+        @user.lists.create(:name => 'Moo!')
+        @user.lists.size.should == 2
+      end
+    end
+
+    context "create!" do
+      before do
+        @user = User.create(:name => 'John')
+        @list = @user.lists.create!(:name => 'Foo!')
+      end
+
+      it "should add id to key" do
+        @list.user_ids.should include(@user.id)
+      end
+
+      it "should persist id addition to key in database" do
+        @list.reload
+        @list.user_ids.should include(@user.id)
+      end
+
+      it "should add doc to association" do
+        @user.lists.should include(@list)
+      end
+
+      it "should save doc" do
+        @list.should_not be_new
+      end
+
+      it "should raise exception if invalid" do
+        lambda do
+          @user.lists.create!
+        end.should raise_error(MongoMapper::DocumentNotValid)
+      end
+
+      it "should reset cache" do
+        @user.lists.size.should == 1
+        @user.lists.create!(:name => 'Moo!')
+        @user.lists.size.should == 2
+      end
+    end
+
+    context "Finding scoped to association" do
+      before do
+        @user = User.create(:name => 'John')
+        @user2 = User.create(:name => 'Brandon')
+        @list1 = @user.lists.create!(:name => 'Foo 1', :position => 1)
+        @list2 = @user.lists.create!(:name => 'Foo 2', :position => 2)
+        @list3 = @user2.lists.create!(:name => 'Foo 3', :position => 1)
+      end
+
+      context "all" do
+        it "should work" do
+          @user.lists.all(:order => :position.asc).should == [@list1, @list2]
+        end
+
+        it "should work with conditions" do
+          @user.lists.all(:name => 'Foo 1').should == [@list1]
+        end
+      end
+
+      context "first" do
+        it "should work" do
+          @user.lists.first(:order => 'position').should == @list1
+        end
+
+        it "should work with conditions" do
+          @user.lists.first(:position => 2).should == @list2
+        end
+      end
+
+      context "last" do
+        it "should work" do
+          @user.lists.last(:order => 'position').should == @list2
+        end
+
+        it "should work with conditions" do
+          @user.lists.last(:position => 2, :order => 'position').should == @list2
+        end
+      end
+
+      context "with one id" do
+        it "should work for id in association" do
+          @user.lists.find(@list1.id).should == @list1
+        end
+
+        it "should work with string ids" do
+          @user.lists.find(@list1.id.to_s).should == @list1
+        end
+
+        it "should not work for id not in association" do
+          @user.lists.find(@list3.id).should be_nil
+        end
+
+        it "should raise error when using ! and not found" do
+          lambda do
+            @user.lists.find!(@list3.id)
+          end.should raise_error(MongoMapper::DocumentNotFound)
+        end
+      end
+
+      context "with multiple ids" do
+        it "should work for ids in association" do
+          @user.lists.find(@list1.id, @list2.id).should == [@list1, @list2]
+        end
+
+        it "should not work for ids not in association" do
+          @user.lists.find(@list1.id, @list2.id, @list3.id).should == [@list1, @list2]
+        end
+      end
+
+      context "with #paginate" do
+        before do
+          @lists = @user.lists.paginate(:per_page => 1, :page => 1, :order => 'position')
+        end
+
+        it "should return total pages" do
+          @lists.total_pages.should == 2
+        end
+
+        it "should return total entries" do
+          @lists.total_entries.should == 2
+        end
+
+        it "should return the subject" do
+          @lists.collect(&:name).should == ['Foo 1']
+        end
+      end
+
+      context "dynamic finders" do
+        it "should work with single key" do
+          @user.lists.find_by_name('Foo 1').should == @list1
+          @user.lists.find_by_name!('Foo 1').should == @list1
+          @user.lists.find_by_name('Foo 3').should be_nil
+        end
+
+        it "should work with multiple keys" do
+          @user.lists.find_by_name_and_position('Foo 1', 1).should == @list1
+          @user.lists.find_by_name_and_position!('Foo 1', 1).should == @list1
+          @user.lists.find_by_name_and_position('Foo 3', 1).should be_nil
+        end
+
+        it "should raise error when using ! and not found" do
+          lambda do
+            @user.lists.find_by_name!('Foo 3')
+          end.should raise_error(MongoMapper::DocumentNotFound)
+        end
+
+        context "find_or_create_by" do
+          it "should not create document if found" do
+            lambda {
+              list = @user.lists.find_or_create_by_name('Foo 1')
+              list.should == @list1
+            }.should_not change { List.count }
+          end
+
+          it "should create document if not found" do
+            lambda {
+              list = @user.lists.find_or_create_by_name('Home')
+              @user.lists.should include(list)
+            }.should change { List.count }
+          end
+        end
+      end
+    end
+
+    context "count" do
+      before do
+        @user = User.create(:name => 'John')
+        @user2 = User.create(:name => 'Brandon')
+        @list1 = @user.lists.create!(:name => 'Foo 1')
+        @list2 = @user.lists.create!(:name => 'Foo 2')
+        @list3 = @user2.lists.create!(:name => 'Foo 3')
+      end
+
+      it "should return number of ids" do
+        @user.lists.count.should == 2
+        @user2.lists.count.should == 1
+      end
+
+      it "should return correct count when given criteria" do
+        @user.lists.count(:name => 'Foo 1').should == 1
+        @user2.lists.count(:name => 'Foo 1').should == 0
+      end
+    end
+
+    context "Removing documents" do
+      before do
+        @user = User.create(:name => 'John')
+        @user2 = User.create(:name => 'Brandon')
+        @list1 = @user.lists.create!(:name => 'Foo 1', :position => 1)
+        @list2 = @user.lists.create!(:name => 'Foo 2', :position => 2)
+        @list3 = @user2.lists.create!(:name => 'Foo 3', :position => 1)
+      end
+
+      context "destroy_all" do
+        it "should work" do
+          @user.lists.count.should == 2
+          @user.lists.destroy_all
+          @user.lists.count.should == 0
+        end
+
+        it "should work with conditions" do
+          @user.lists.count.should == 2
+          @user.lists.destroy_all(:name => 'Foo 1')
+          @user.lists.count.should == 1
+        end
+      end
+
+      context "delete_all" do
+        it "should work" do
+          @user.lists.count.should == 2
+          @user.lists.delete_all
+          @user.lists.count.should == 0
+        end
+
+        it "should work with conditions" do
+          @user.lists.count.should == 2
+          @user.lists.delete_all(:name => 'Foo 1')
+          @user.lists.count.should == 1
+        end
+      end
+
+      it "should work with nullify" do
+        @user.lists.count.should == 2
+
+        lambda {
+          @user.lists.nullify
+        }.should_not change { List.count }
+
+        @user.lists.count.should == 0
+      end
+    end
+  end
+end

data/spec/functional/associations/many_documents_as_proxy_spec.rb

@@ -2,8 +2,8 @@ require 'spec_helper'
 
 describe "ManyDocumentsAsProxy" do
   before do
-    Post.collection.remove
-    PostComment.collection.remove
+    Post.collection.drop
+    PostComment.collection.drop
   end
 
   it "should default reader to empty array" do
@@ -155,9 +155,9 @@ describe "ManyDocumentsAsProxy" do
       end
 
       it "should not work for id not in association" do
-        expect {
+        lambda {
           @post.comments.find!(@comment5._id)
-        }.to raise_error(MongoMapper::DocumentNotFound)
+        }.should raise_error(MongoMapper::DocumentNotFound)
       end
     end
 
@@ -168,9 +168,9 @@ describe "ManyDocumentsAsProxy" do
       end
 
       it "should not work for ids not in association" do
-        expect {
+        lambda {
           @post.comments.find!(@comment1._id, @comment2._id, @comment4._id)
-        }.to raise_error(MongoMapper::DocumentNotFound)
+        }.should raise_error(MongoMapper::DocumentNotFound)
       end
     end
 

data/spec/functional/associations/many_documents_proxy_spec.rb

@@ -2,8 +2,8 @@ require 'spec_helper.rb'
 
 describe "ManyDocumentsProxy" do
   before do
-    Project.collection.remove
-    Status.collection.remove
+    Project.collection.drop
+    Status.collection.drop
 
     @pet_class = Doc do
       key :name, String
@@ -105,7 +105,7 @@ describe "ManyDocumentsProxy" do
     owner.pets[1].name.should == 'Sasha'
     owner.pets[1].species.should == 'Siberian Husky'
 
-    owner.save.should be_true
+    owner.save.should be_truthy
     owner.reload
 
     owner.name.should == 'Mr. Pet Lover'
@@ -128,7 +128,7 @@ describe "ManyDocumentsProxy" do
       it "should work" do
         project = Project.new
         project.statuses = [Status.new(:name => "ready")]
-        project.save.should be_true
+        project.save.should be_truthy
 
         project.reload
         project.statuses.size.should == 1
@@ -140,7 +140,7 @@ describe "ManyDocumentsProxy" do
       it "should convert to objects of the class and work" do
         project = Project.new
         project.statuses = [{ 'name' => 'ready' }]
-        project.save.should be_true
+        project.save.should be_truthy
 
         project.reload
         project.statuses.size.should == 1
@@ -430,9 +430,9 @@ describe "ManyDocumentsProxy" do
 
     it "should raise exception if not valid" do
       project = Project.create
-      expect {
+      lambda {
         project.statuses.create!(:name => nil)
-      }.to raise_error(MongoMapper::DocumentNotValid)
+      }.should raise_error(MongoMapper::DocumentNotValid)
     end
 
     it "should reset cache" do
@@ -491,19 +491,19 @@ describe "ManyDocumentsProxy" do
   context "empty?" do
     it "should be true with no associated docs" do
       project = Project.create
-      project.statuses.empty?.should be_true
+      project.statuses.empty?.should be_truthy
     end
 
     it "should be false if a document is built" do
       project = Project.create
       project.statuses.build(:name => 'Foo!')
-      project.statuses.empty?.should be_false
+      project.statuses.empty?.should be_falsey
     end
 
     it "should be false if a document is created" do
       project = Project.create
       project.statuses.create(:name => 'Foo!')
-      project.statuses.empty?.should be_false
+      project.statuses.empty?.should be_falsey
     end
   end
 
@@ -754,9 +754,9 @@ describe "ManyDocumentsProxy" do
       end
 
       it "should not work for ids not in association" do
-        expect {
+        lambda {
           @project1.statuses.find!(@brand_new.id, @complete.id, @archived.id)
-        }.to raise_error(MongoMapper::DocumentNotFound)
+        }.should raise_error(MongoMapper::DocumentNotFound)
       end
     end
 
@@ -810,13 +810,13 @@ describe "ManyDocumentsProxy" do
       class ::Property
         include MongoMapper::Document
       end
-      Property.collection.remove
+      Property.collection.drop
 
       class ::Thing
         include MongoMapper::Document
         key :name, String
       end
-      Thing.collection.remove
+      Thing.collection.drop
     end
 
     after do
@@ -950,4 +950,75 @@ describe "ManyDocumentsProxy" do
       @paper.articles.should include(article)
     end
   end
+
+  describe "regression with association proxy scoping" do
+    before do
+      @job_title_class = Doc do
+        set_collection_name "job_titles"
+      end
+
+      @training_class = Doc do
+        set_collection_name "trainings"
+        key :slug, String
+        key :is_active, Boolean, default: true
+
+        def self.find_by_slug!(the_slug)
+          if res = first(:slug => the_slug)
+            res
+          else
+            raise "MissingSlugError"
+          end
+        end
+
+        validates_presence_of :job_title_id
+        validates_presence_of :slug
+        validates_uniqueness_of :slug, :scope => :job_title_id
+      end
+
+      @job_title_class.has_many :trainings, :class => @training_class, :foreign_key => :job_title_id
+      @training_class.belongs_to :job_title, :class => @job_title_class
+    end
+
+    it "should scope queries that return a single method on has many association with the right parent id" do
+      @job_title_1 = @job_title_class.create!
+      @job_title_2 = @job_title_class.create!
+
+      @training_1 = @training_class.create!(:slug => 'foo', :job_title_id => @job_title_1.id)
+      @training_2 = @training_class.create!(:slug => 'foo', :job_title_id => @job_title_2.id)
+
+      @job_title_1.reload
+      @job_title_2.reload
+
+      @job_title_1.trainings.count.should == 1
+      @job_title_2.trainings.count.should == 1
+
+      @job_title_1.trainings.find_by_slug!('foo').should == @training_1
+      @job_title_2.trainings.find_by_slug!('foo').should == @training_2
+
+      lambda do
+        @job_title_2.trainings.find_by_slug!('bar')
+      end.should raise_error(RuntimeError)
+    end
+
+    it "should scope with an extra where clause on the proxy (regression #2)" do
+      @job_title_1 = @job_title_class.create!
+      @job_title_2 = @job_title_class.create!
+
+      @training_1 = @training_class.create!(:slug => 'foo', :job_title_id => @job_title_1.id)
+      @training_2 = @training_class.create!(:slug => 'foo', :job_title_id => @job_title_2.id)
+
+      @job_title_1.reload
+      @job_title_2.reload
+
+      @job_title_1.trainings.count.should == 1
+      @job_title_2.trainings.count.should == 1
+
+      @job_title_1.trainings.where(:is_active => true).find_by_slug!('foo').should == @training_1
+      @job_title_2.trainings.where(:is_active => true).find_by_slug!('foo').should == @training_2
+
+      lambda do
+        @job_title_2.trainings.find_by_slug!('bar')
+      end.should raise_error(RuntimeError)
+    end
+  end
 end