mongo_mapper 0.13.0 → 0.15.1

data/spec/functional/stats_spec.rb

@@ -0,0 +1,86 @@
+require 'spec_helper'
+
+describe "Stats" do
+  before(:each) do
+    class ::Docs
+      include MongoMapper::Document
+      key   :title, String
+      key   :published_at, Time
+    end
+
+    Docs.collection.drop
+  end
+
+  context "with no documents present" do
+    it "should return nil" do
+      if Docs.stats == nil
+        Docs.stats.should == nil
+      else
+        Docs.stats['count'].should == 0
+      end
+    end
+  end
+
+  context "with documents present" do
+    before do
+      # Make sure that there is at least one document stored
+      Docs.create!
+    end
+
+    def get_stats
+      MongoMapper.database.command(:collstats => 'docs').documents[0]
+    end
+
+    it "should have the correct count" do
+      Docs.stats.count.should == get_stats['count']
+    end
+
+    it "should have the correct namespace" do
+      Docs.stats.ns.should == get_stats['ns']
+    end
+
+    it "should have the correct size" do
+      Docs.stats.size.should == get_stats['size']
+    end
+
+    it "should have the correct storage size" do
+      Docs.stats.storage_size.should == get_stats['storageSize']
+    end
+
+    it "should have the correct average object size" do
+      Docs.stats.avg_obj_size.should == get_stats['avgObjSize']
+    end
+
+    it "should have the correct number of extents" do
+      if get_stats['numExtents']
+        Docs.stats.num_extents.should == get_stats['numExtents']
+      end
+    end
+
+    it "should have the correct number of indexes" do
+      Docs.stats.nindexes.should == get_stats['nindexes']
+    end
+
+    it "should have the correct last extent size" do
+      if get_stats['lastExtentSize']
+        Docs.stats.last_extent_size.should == get_stats['lastExtentSize']
+      end
+    end
+
+    it "should have the correct padding factor" do
+      if get_stats['paddingFactor']
+        Docs.stats.padding_factor.should == get_stats['paddingFactor']
+      end
+    end
+
+    it "should have the correct user flags" do
+      if get_stats['userFlags']
+        Docs.stats.user_flags.should == get_stats['userFlags']
+      end
+    end
+
+    it "should have the correct total index size" do
+      Docs.stats.total_index_size.should == get_stats['totalIndexSize']
+    end
+  end
+end

data/spec/functional/strong_parameters_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe "Strong parameters" do
+  context 'A document with strong parameters protection' do
+    if ::ActiveModel.const_defined?(:ForbiddenAttributesProtection)
+      require "action_controller/metal/strong_parameters"
+
+      before do
+        @doc_class = Doc do
+          plugin MongoMapper::Plugins::StrongParameters
+
+          key :name, String
+          key :admin, Boolean, :default => false
+        end
+
+        @doc = @doc_class.create(:name => 'Steve Sloan')
+      end
+
+      let(:params) {
+        {name: "Permitted", admin: true}
+      }
+
+      let(:strong_params) {
+        ActionController::Parameters.new params
+      }
+
+      it "allows assignment of attribute hashes" do
+        @doc.attributes = params
+        @doc.name.should =="Permitted"
+      end
+
+      it "doesn't allow mass assignment of ActionController::Parameters" do
+        lambda {
+          @doc.attributes = strong_params
+        }.should raise_error(ActiveModel::ForbiddenAttributesError)
+      end
+
+      it "does not allow mass assignment of non-permitted attributes" do
+        @doc.attributes = strong_params.permit(:name)
+        @doc.admin.should == false
+      end
+
+      it "allows mass assignment of permitted attributes" do
+        @doc.attributes = strong_params.permit(:name)
+        @doc.name.should == "Permitted"
+      end
+    end
+  end
+end

data/spec/functional/touch_spec.rb

@@ -61,7 +61,7 @@ describe "Touch" do
 
       it 'should not be true by default' do
         @comment_class.belongs_to :post, :class => @post_class
-        @comment_class.associations[:post].touch?.should_not be_true
+        @comment_class.associations[:post].touch?.should_not be_truthy
       end
 
       context 'touch the parent when true' do

data/spec/functional/validations_spec.rb

@@ -57,7 +57,7 @@ describe "Validations" do
 
     it "should create a new document" do
       instance = @document.create!(:name => "James")
-      instance.new_record?.should be_false
+      instance.new_record?.should be_falsey
     end
   end
 
@@ -140,7 +140,7 @@ describe "Validations" do
         validates_uniqueness_of :name, :scope => :adult
       end
       doc = document.new("name" => "joe", :adult => true)
-      doc.save.should be_true
+      doc.save.should be_truthy
 
       doc2 = document.new("name" => "joe", :adult => false)
       doc2.should be_valid
@@ -149,31 +149,30 @@ describe "Validations" do
     it "should work with i18n taken message" do
       @document.create(:name => 'joe')
       doc = @document.create(:name => 'joe')
-      doc.should have_error_on(:name, 'has already been taken')
+      doc.should have_error_on(:name)
+      doc.errors[:name].should == ['has already been taken']
     end
 
     it "should allow to update an object" do
       doc = @document.new("name" => "joe")
-      doc.save.should be_true
+      doc.save.should be_truthy
 
-      @document \
-        .stub(:first) \
-        .with(:name => 'joe') \
-        .and_return(doc)
+      @document.stub(:first).
+        with(:name => 'joe').
+        and_return(doc)
 
       doc.name = "joe"
-      doc.valid?.should be_true
+      doc.valid?.should be_truthy
       doc.should_not have_error_on(:name)
     end
 
     it "should fail if object name is not unique" do
       doc = @document.new("name" => "joe")
-      doc.save.should be_true
+      doc.save.should be_truthy
 
-      @document \
-        .stub(:first) \
-        .with(:name => 'joe') \
-        .and_return(doc)
+      @document.stub(:first).
+        with(:name => 'joe').
+        and_return(doc)
 
       doc2 = @document.new("name" => "joe")
       doc2.should have_error_on(:name)
@@ -186,12 +185,11 @@ describe "Validations" do
       end
 
       doc = document.new("name" => "")
-      doc.save.should be_true
+      doc.save.should be_truthy
 
-      document \
-        .stub(:first) \
-        .with(:name => '') \
-        .and_return(doc)
+      @document.stub(:first).
+        with(:name => '').
+        and_return(doc)
 
       doc2 = document.new("name" => "")
       doc2.should_not have_error_on(:name)
@@ -204,7 +202,7 @@ describe "Validations" do
       end
 
       doc = document.new('name' => nil)
-      doc.save.should be_true
+      doc.save.should be_truthy
 
       doc2 = document.new('name' => nil)
       doc2.should_not have_error_on(:name)
@@ -217,7 +215,7 @@ describe "Validations" do
       end
 
       doc = document.new("name" => "BLAMMO")
-      doc.save.should be_true
+      doc.save.should be_truthy
 
       doc2 = document.new("name" => "blammo")
       doc2.should_not have_error_on(:name)
@@ -233,7 +231,7 @@ describe "Validations" do
 
       it "should fail on entries that differ only in case" do
         doc = @document.new("name" => "BLAMMO")
-        doc.save.should be_true
+        doc.save.should be_truthy
 
         doc2 = @document.new("name" => "blammo")
         doc2.should have_error_on(:name)
@@ -251,10 +249,10 @@ describe "Validations" do
 
       it "should check for uniqueness using entire string" do
         doc = @document.new("name" => "John Doe")
-        doc.save.should be_true
+        doc.save.should be_truthy
 
         doc2 = @document.new("name" => "John")
-        doc2.valid?.should be_true
+        doc2.valid?.should be_truthy
       end
     end
 
@@ -269,12 +267,11 @@ describe "Validations" do
 
       it "should fail if the same name exists in the scope" do
         doc = @document.new("name" => "joe", "scope" => "one")
-        doc.save.should be_true
+        doc.save.should be_truthy
 
-        @document \
-          .stub(:first) \
-          .with(:name => 'joe', :scope => "one") \
-          .and_return(doc)
+        @document.stub(:first).
+          with(:name => 'joe', :scope => "one").
+          and_return(doc)
 
         doc2 = @document.new("name" => "joe", "scope" => "one")
         doc2.should have_error_on(:name)
@@ -282,12 +279,11 @@ describe "Validations" do
 
       it "should pass if the same name exists in a different scope" do
         doc = @document.new("name" => "joe", "scope" => "one")
-        doc.save.should be_true
+        doc.save.should be_truthy
 
-        @document \
-          .stub(:first) \
-          .with(:name => 'joe', :scope => 'two') \
-          .and_return(nil)
+        @document.stub(:first).
+          with(:name => 'joe', :scope => 'two').
+          and_return(nil)
 
         doc2 = @document.new("name" => "joe", "scope" => "two")
         doc2.should_not have_error_on(:name)
@@ -306,12 +302,11 @@ describe "Validations" do
 
       it "should fail if the same name exists in the scope" do
         doc = @document.new("name" => "joe", "first_scope" => "one", "second_scope" => "two")
-        doc.save.should be_true
+        doc.save.should be_truthy
 
-        @document \
-          .stub(:first) \
-          .with(:name => 'joe', :first_scope => 'one', :second_scope => 'two') \
-          .and_return(doc)
+        @document.stub(:first).
+          with(:name => 'joe', :first_scope => 'one', :second_scope => 'two').
+          and_return(doc)
 
         doc2 = @document.new("name" => "joe", "first_scope" => "one", "second_scope" => "two")
         doc2.should have_error_on(:name)
@@ -319,12 +314,11 @@ describe "Validations" do
 
       it "should pass if the same name exists in a different scope" do
         doc = @document.new("name" => "joe", "first_scope" => "one", "second_scope" => "two")
-        doc.save.should be_true
+        doc.save.should be_truthy
 
-        @document \
-          .stub(:first) \
-          .with(:name => 'joe', :first_scope => 'one', :second_scope => 'one') \
-          .and_return(nil)
+        @document.stub(:first).
+          with(:name => 'joe', :first_scope => 'one', :second_scope => 'one').
+          and_return(nil)
 
         doc2 = @document.new("name" => "joe", "first_scope" => "one", "second_scope" => "one")
         doc2.should_not have_error_on(:name)
@@ -345,21 +339,21 @@ describe "Validations" do
 
     it "should pass if there are no associated docs" do
       doc = @root_class.new
-      doc.save.should be_true
+      doc.save.should be_truthy
     end
 
     it "should pass if the associated doc is valid" do
       doc = @root_class.new
       doc.children.build(:name => 'Joe')
-      doc.save.should be_true
+      doc.save.should be_truthy
     end
 
     it "should fail if the associated doc is invalid" do
       doc = @root_class.new
       doc.children.build
-      doc.should have_error_on(:children, 'are invalid')
+      doc.should have_error_on(:children)
+      doc.errors[:children].should == ['are invalid']
     end
-
   end
 
   context "validating associated docs with custom context" do
@@ -377,22 +371,22 @@ describe "Validations" do
 
     it "should pass if there are no associated docs" do
       doc = @root_class.new
-      doc.valid?(:custom_context).should be_true
+      doc.valid?(:custom_context).should be_truthy
     end
 
     it "should pass if the associated doc is valid" do
       doc = @root_class.new
       doc.children.build(:name => 'George')
-      doc.valid?(:custom_context).should be_true
+      doc.valid?(:custom_context).should be_truthy
     end
 
     it "should fail if the associated doc is invalid" do
       doc = @root_class.new
       doc.children.build(:name => 'Bob')
-      doc.valid?(:custom_context).should_not be_true
+      doc.valid?(:custom_context).should_not be_truthy
     end
-
   end
+
   # context "validates uniqueness of with :unique shortcut" do
   #   it "should work" do
   #     @document = Doc do
@@ -402,13 +396,13 @@ describe "Validations" do
   #     doc = @document.create(:name => 'John')
   #     doc.should_not have_error_on(:name)
   #
-  #     @document \
-  #       .stub(:first) \
-  #       .with(:name => 'John') \
-  #       .and_return(doc)
+  #     @document.stub(:first).
+  #       with(:name => 'John').
+  #       and_return(doc)
   #
   #     second_john = @document.create(:name => 'John')
-  #     second_john.should have_error_on(:name, 'has already been taken')
+  #     second_john.should have_error_on(:name)
+  #     second_john.errors[:name].should == ['has already been taken']
   #   end
   # end
 end

data/spec/quality_spec.rb

@@ -0,0 +1,51 @@
+if defined?(Encoding) && Encoding.default_external != "UTF-8"
+  Encoding.default_external = "UTF-8"
+end
+
+describe "The library itself" do
+  def check_for_tab_characters(filename)
+    failing_lines = []
+    File.readlines(filename).each_with_index do |line,number|
+      failing_lines << number + 1 if line =~ /\t/
+    end
+
+    unless failing_lines.empty?
+      "#{filename} has tab characters on lines #{failing_lines.join(', ')}"
+    end
+  end
+
+  def check_for_extra_spaces(filename)
+    failing_lines = []
+    File.readlines(filename).each_with_index do |line,number|
+      next if line =~ /^\s+#.*\s+\n$/
+      failing_lines << number + 1 if line =~ /\s+\n$/
+    end
+
+    unless failing_lines.empty?
+      "#{filename} has spaces on the EOL on lines #{failing_lines.join(', ')}"
+    end
+  end
+
+  RSpec::Matchers.define :be_well_formed do
+    failure_message do |actual|
+      actual.join("\n")
+    end
+
+    match do |actual|
+      actual.empty?
+    end
+  end
+
+  it "has no malformed whitespace" do
+    exempt = /\.gitmodules|\.marshal|fixtures|vendor|ssl_certs|kill|LICENSE/
+    error_messages = []
+    Dir.chdir(File.expand_path("../..", __FILE__)) do
+      `git ls-files`.split("\n").each do |filename|
+        next if filename =~ exempt
+        error_messages << check_for_tab_characters(filename)
+        error_messages << check_for_extra_spaces(filename)
+      end
+    end
+    error_messages.compact.should be_well_formed
+  end
+end