mongo 2.9.2 → 2.10.0.rc0

data/spec/mongo/error/operation_failure_spec.rb

@@ -148,6 +148,52 @@ describe Mongo::Error::OperationFailure do
         end
       end
     end
+
+    context 'when there is a non-resumable label' do
+      context 'getMore response' do
+        let(:error) { Mongo::Error::OperationFailure.new('no message',
+          Mongo::Operation::GetMore::Result.new([]),
+          :code => 91, :code_name => 'ShutdownInProgress',
+          :labels => ['NonResumableChangeStreamError']) }
+
+        it 'returns false' do
+          expect(error.change_stream_resumable?).to eql(false)
+        end
+      end
+
+      context 'not a getMore response' do
+        let(:error) { Mongo::Error::OperationFailure.new('no message', nil,
+          :code => 91, :code_name => 'ShutdownInProgress',
+          :labels => ['NonResumableChangeStreamError']) }
+
+        it 'returns false' do
+          expect(error.change_stream_resumable?).to eql(false)
+        end
+      end
+    end
+
+    context 'when there is another label' do
+      context 'getMore response' do
+        let(:error) { Mongo::Error::OperationFailure.new('no message',
+          Mongo::Operation::GetMore::Result.new([]),
+          :code => 91, :code_name => 'ShutdownInProgress',
+          :labels => %w(TransientTransactionError)) }
+
+        it 'returns true' do
+          expect(error.change_stream_resumable?).to eql(true)
+        end
+      end
+
+      context 'not a getMore response' do
+        let(:error) { Mongo::Error::OperationFailure.new('no message', nil,
+          :code => 91, :code_name => 'ShutdownInProgress',
+          :labels => %w(TransientTransactionError)) }
+
+        it 'returns false' do
+          expect(error.change_stream_resumable?).to eql(false)
+        end
+      end
+    end
   end
 
   describe '#labels' do
@@ -210,7 +256,7 @@ describe Mongo::Error::OperationFailure do
       context 'when the error has labels' do
 
         let(:labels) do
-          [ Mongo::Error::TRANSIENT_TRANSACTION_ERROR_LABEL ]
+          %w(TransientTransactionError)
         end
 
         it 'has the correct labels' do

data/spec/mongo/error/parser_spec.rb

@@ -1,13 +1,12 @@
 require 'spec_helper'
 
 describe Mongo::Error::Parser do
+  let(:parser) do
+    described_class.new(document)
+  end
 
   describe '#message' do
 
-    let(:parser) do
-      described_class.new(document)
-    end
-
     context 'when the document contains no error message' do
 
       let(:document) do
@@ -97,9 +96,6 @@ describe Mongo::Error::Parser do
   end
 
   describe '#code' do
-    let(:parser) do
-      described_class.new(document)
-    end
 
     context 'when document contains code and ok: 1' do
       let(:document) do
@@ -172,12 +168,23 @@ describe Mongo::Error::Parser do
         expect(parser.code).to be nil
       end
     end
+
+    context 'when both top level code and write concern code are present' do
+
+      let(:document) do
+        { 'ok' => 0,
+          'errmsg' => 'not master', 'code' => 10107, 'codeName' => 'NotMaster',
+          'writeConcernError' => {
+            'code' => 100, 'errmsg' => 'Not enough data-bearing nodes' } }
+      end
+
+      it 'returns top level code' do
+        expect(parser.code).to eq(10107)
+      end
+    end
   end
 
   describe '#code_name' do
-    let(:parser) do
-      described_class.new(document)
-    end
 
     context 'when document contains code name and ok: 1' do
       let(:document) do
@@ -251,13 +258,152 @@ describe Mongo::Error::Parser do
         expect(parser.code_name).to be nil
       end
     end
+
+    context 'when both top level code and write concern code are present' do
+
+      let(:document) do
+        { 'ok' => 0,
+          'errmsg' => 'not master', 'code' => 10107, 'codeName' => 'NotMaster',
+          'writeConcernError' => {
+            'code' => 100, 'errmsg' => 'Not enough data-bearing nodes' } }
+      end
+
+      it 'returns top level code' do
+        expect(parser.code_name).to eq('NotMaster')
+      end
+    end
   end
 
-  describe '#document' do
-    let(:parser) do
-      described_class.new(document)
+  describe '#write_concern_error?' do
+    context 'there is a write concern error' do
+
+      let(:document) do
+        { 'ok' => 1,
+          'writeConcernError' => {
+            'code' => 100, 'errmsg' => 'Not enough data-bearing nodes' } }
+      end
+
+      it 'is true' do
+        expect(parser.write_concern_error?).to be true
+      end
+    end
+
+    context 'there is no write concern error' do
+
+      let(:document) do
+        { 'ok' => 0,
+          'errmsg' => 'not master', 'code' => 10107, 'codeName' => 'NotMaster',
+        }
+      end
+
+      it 'is false' do
+        expect(parser.write_concern_error?).to be false
+      end
     end
 
+    context 'there is a top level error and write concern error' do
+
+      let(:document) do
+        { 'ok' => 0,
+          'errmsg' => 'not master', 'code' => 10107, 'codeName' => 'NotMaster',
+          'writeConcernError' => {
+            'code' => 100, 'errmsg' => 'Not enough data-bearing nodes' } }
+      end
+
+      it 'is true' do
+        expect(parser.write_concern_error?).to be true
+      end
+    end
+  end
+
+  describe '#write_concern_error_code' do
+    context 'there is a write concern error' do
+
+      let(:document) do
+        { 'ok' => 1,
+          'writeConcernError' => {
+            'code' => 100, 'errmsg' => 'Not enough data-bearing nodes' } }
+      end
+
+      it 'is true' do
+        expect(parser.write_concern_error_code).to eq(100)
+      end
+    end
+
+    context 'there is no write concern error' do
+
+      let(:document) do
+        { 'ok' => 0,
+          'errmsg' => 'not master', 'code' => 10107, 'codeName' => 'NotMaster',
+        }
+      end
+
+      it 'is nil' do
+        expect(parser.write_concern_error_code).to be nil
+      end
+    end
+
+    context 'there is a top level error and write concern error' do
+
+      let(:document) do
+        { 'ok' => 0,
+          'errmsg' => 'not master', 'code' => 10107, 'codeName' => 'NotMaster',
+          'writeConcernError' => {
+            'code' => 100, 'errmsg' => 'Not enough data-bearing nodes' } }
+      end
+
+      it 'is true' do
+        expect(parser.write_concern_error_code).to eq(100)
+      end
+    end
+  end
+
+  describe '#write_concern_error_code_name' do
+    context 'there is a write concern error' do
+
+      let(:document) do
+        { 'ok' => 1,
+          'writeConcernError' => {
+            'code' => 100, 'codeName' => 'SomeCodeName',
+              'errmsg' => 'Not enough data-bearing nodes' } }
+      end
+
+      it 'is the code name' do
+        expect(parser.write_concern_error_code_name).to eq('SomeCodeName')
+      end
+    end
+
+    context 'there is no write concern error' do
+
+      let(:document) do
+        { 'ok' => 0,
+          'errmsg' => 'not master', 'code' => 10107, 'codeName' => 'NotMaster',
+        }
+      end
+
+      it 'is nil' do
+        expect(parser.write_concern_error_code_name).to be nil
+      end
+    end
+
+    context 'there is a top level error and write concern error' do
+
+      let(:document) do
+        { 'ok' => 0,
+          'errmsg' => 'not master', 'code' => 10107, 'codeName' => 'NotMaster',
+          'writeConcernError' => {
+            'code' => 100, 'codeName' => 'SomeCodeName',
+              'errmsg' => 'Not enough data-bearing nodes' } }
+      end
+
+      it 'is the code name' do
+        expect(parser.write_concern_error_code_name).to eq('SomeCodeName')
+      end
+    end
+  end
+
+  describe '#document' do
+
     let(:document) do
       { 'ok' => 0, 'errmsg' => 'not master', 'code' => 10107, 'codeName' => 'NotMaster' }
     end
@@ -268,9 +414,6 @@ describe Mongo::Error::Parser do
   end
 
   describe '#replies' do
-    let(:parser) do
-      described_class.new(document)
-    end
 
     context 'when there are no replies' do
       let(:document) do
@@ -284,9 +427,6 @@ describe Mongo::Error::Parser do
   end
 
   describe '#labels' do
-    let(:parser) do
-      described_class.new(document)
-    end
 
     let(:document) do
       {
@@ -308,7 +448,7 @@ describe Mongo::Error::Parser do
 
     context 'when there are labels' do
       let(:labels) do
-        [ Mongo::Error::TRANSIENT_TRANSACTION_ERROR_LABEL ]
+        %w(TransientTransactionError)
       end
 
       it 'has the correct labels' do
@@ -318,9 +458,6 @@ describe Mongo::Error::Parser do
   end
 
   describe '#wtimeout' do
-    let(:parser) do
-      described_class.new(document)
-    end
 
     context 'when document contains wtimeout' do
       let(:document) do

data/spec/mongo/operation/insert/bulk_spec.rb

@@ -1,6 +1,8 @@
 require 'spec_helper'
 
 describe Mongo::Operation::Insert do
+  require_no_multi_shard
+
   before do
     begin
       authorized_collection.delete_many
@@ -188,7 +190,6 @@ describe Mongo::Operation::Insert do
       end
 
       context 'when write concern is unacknowledged' do
-
         let(:write_concern) do
           Mongo::WriteConcern.get(w: 0)
         end

data/spec/mongo/operation/result_spec.rb

@@ -261,6 +261,17 @@ describe Mongo::Operation::Result do
         end
       end
     end
+
+    context 'when there is a write concern error' do
+      let(:documents) do
+        [{'ok' => 1.0, 'writeConcernError' => {
+          'code' => 91, 'errmsg' => 'Replication is being shut down'}}]
+      end
+
+      it 'is false' do
+        expect(result).not_to be_successful
+      end
+    end
   end
 
   describe '#written_count' do
@@ -309,4 +320,20 @@ describe Mongo::Operation::Result do
       expect(result).to be_a(Mongo::Operation::Result)
     end
   end
+
+  describe '#validate!' do
+
+    context 'when there is a write concern error' do
+      let(:documents) do
+        [{'ok' => 1.0, 'writeConcernError' => {
+          'code' => 91, 'errmsg' => 'Replication is being shut down'}}]
+      end
+
+      it 'raises OperationFailure' do
+        expect do
+          result.validate!
+        end.to raise_error(Mongo::Error::OperationFailure, /Replication is being shut down \(91\)/)
+      end
+    end
+  end
 end

data/spec/mongo/operation/update/bulk_spec.rb

@@ -1,6 +1,7 @@
 require 'spec_helper'
 
 describe Mongo::Operation::Update do
+  require_no_multi_shard
 
   let(:documents) do
     [{ :q => { :foo => 1 },

data/spec/mongo/retryable_spec.rb

@@ -67,6 +67,8 @@ class ModernRetryableTestConsumer < LegacyRetryableTestConsumer
       i = 1
       allow(session).to receive(:next_txn_num) { i += 1 }
       allow(session).to receive(:in_transaction?).and_return(false)
+      allow(session).to receive(:pinned_server)
+      allow(session).to receive(:starting_transaction?).and_return(false)
     end
   end
 

data/spec/mongo/server/app_metadata_spec.rb

@@ -23,7 +23,7 @@ describe Mongo::Server::AppMetadata do
       end
 
       after do
-        client.close
+        client.close(true)
       end
 
       it 'sets the app name' do
@@ -41,7 +41,7 @@ describe Mongo::Server::AppMetadata do
         end
 
         after do
-          client.close
+          client.close(true)
         end
 
         it 'raises an error' do

data/spec/mongo/server/connection_spec.rb

@@ -757,42 +757,38 @@ describe Mongo::Server::Connection, retry: 3 do
       end
     end
 
-    context 'when a socket timeout is set on client' do
+    context 'when a socket timeout is set' do
 
       let(:connection) do
         described_class.new(server, socket_timeout: 10)
       end
 
-      it 'is propagated to connection timeout' do
+      it 'sets the timeout' do
         expect(connection.timeout).to eq(10)
       end
-    end
 
-    context 'when an operation never completes' do
       let(:client) do
-        authorized_client.with(socket_timeout: 1.5,
-          # Read retries would cause the reads to be attempted twice,
-          # thus making the find take twice as long to time out.
-          retry_reads: false, max_read_retries: 0)
+        authorized_client.with(socket_timeout: 1.5)
       end
 
       before do
-        client.cluster.next_primary
+        authorized_collection.delete_many
+        authorized_collection.insert_one(a: 1)
       end
 
-      it 'times out and raises SocketTimeoutError' do
+      it 'raises a timeout when it expires' do
         start = Time.now
         begin
-          Timeout::timeout(1.5 + 2) do
+          Timeout::timeout(1.5 + 15) do
             client[authorized_collection.name].find("$where" => "sleep(2000) || true").first
           end
         rescue => ex
           end_time = Time.now
-          expect(ex).to be_a(Mongo::Error::SocketTimeoutError)
-          expect(ex.message).to match(/Took more than 1.5 seconds to receive data/)
+          expect(ex).to be_a(Timeout::Error)
+          expect(ex.message).to eq("Took more than 1.5 seconds to receive data.")
         end
-        # allow 1.5 seconds +- 0.5 seconds
-        expect(end_time - start).to be_within(1).of(2)
+        # Account for wait queue timeout (2s) and rescue
+        expect(end_time - start).to be_within(2.5).of(1.5)
       end
 
       context 'when the socket_timeout is negative' do
@@ -820,7 +816,7 @@ describe Mongo::Server::Connection, retry: 3 do
         it 'raises a timeout error' do
           expect {
             reply
-          }.to raise_exception(Mongo::Error::SocketTimeoutError)
+          }.to raise_exception(Timeout::Error)
         end
       end
     end
@@ -1001,7 +997,7 @@ describe Mongo::Server::Connection, retry: 3 do
     end
 
     after do
-      client.close
+      client.close(true)
     end
 
     context 'when a connect_timeout is in the options' do