mongo 2.9.2 → 2.10.0.rc0

data/spec/integration/client_spec.rb

@@ -0,0 +1,44 @@
+require 'spec_helper'
+
+describe 'Client' do
+  context 'after client is disconnected' do
+    let(:client) { authorized_client.with(server_selection_timeout: 1) }
+
+    before do
+      client.close
+    end
+
+    it 'is still usable for operations' do
+      resp = client.database.command(ismaster: 1)
+      expect(resp).to be_a(Mongo::Operation::Result)
+    end
+
+    it 'is still usable for operations that can use sessions' do
+      client['collection'].insert_one(test: 1)
+    end
+
+    context 'after all servers are marked unknown' do
+      before do
+        client.cluster.servers.each do |server|
+          server.unknown!
+        end
+      end
+
+      context 'operation that never uses sessions' do
+        it 'fails server selection' do
+          expect do
+            client.database.command(ismaster: 1)
+          end.to raise_error(Mongo::Error::NoServerAvailable)
+        end
+      end
+
+      context 'operation that can use sessions' do
+        it 'fails server selection' do
+          expect do
+            client['collection'].insert_one(test: 1)
+          end.to raise_error(Mongo::Error::NoServerAvailable)
+        end
+      end
+    end
+  end
+end

data/spec/integration/command_monitoring_spec.rb

@@ -79,6 +79,7 @@ describe 'Command monitoring' do
   end
 
   context 'when write concern is specified outside of command document' do
+    require_wired_tiger
     require_topology :replica_set
     min_server_fcv '4.0'
 

data/spec/integration/command_spec.rb

@@ -61,7 +61,13 @@ describe 'Command' do
       context 'with session' do
         min_server_fcv '3.6'
 
-        let(:session) { authorized_client.start_session }
+        let(:session) do
+          authorized_client.start_session.tap do |session|
+            # We are bypassing the normal transaction lifecycle, which would
+            # set txn_options
+            allow(session).to receive(:txn_options).and_return({})
+          end
+        end
 
         let(:expected_payload) do
           {

data/spec/integration/mmapv1_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+# This test is a marker used to verify that the test suite runs on
+# mmapv1 storage engine.
+describe 'mmapv1' do
+  require_mmapv1
+
+  context 'standalone' do
+    require_topology :single
+
+    it 'is exercised' do
+    end
+  end
+
+  context 'replica set' do
+    require_topology :replica_set
+
+    it 'is exercised' do
+    end
+  end
+
+  context 'sharded' do
+    require_topology :sharded
+
+    it 'is exercised' do
+    end
+  end
+end

data/spec/integration/mongos_pinning_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+
+describe 'Mongos pinning' do
+  require_topology :sharded
+  min_server_fcv '4.2'
+
+  let(:client) { authorized_client }
+  let(:collection) { client['mongos_pinning_spec'] }
+
+  before do
+    collection.create
+  end
+
+  context 'successful operations' do
+    it 'pins and unpins' do
+      session = client.start_session
+      expect(session.pinned_server).to be nil
+
+      session.start_transaction
+      expect(session.pinned_server).to be nil
+
+      primary = client.cluster.next_primary
+
+      collection.insert_one({a: 1}, session: session)
+      expect(session.pinned_server).not_to be nil
+
+      session.commit_transaction
+      expect(session.pinned_server).not_to be nil
+
+      collection.insert_one({a: 1}, session: session)
+      expect(session.pinned_server).to be nil
+    end
+  end
+end

data/spec/integration/operation_failure_code_spec.rb

@@ -16,8 +16,8 @@ describe 'OperationFailure code' do
         fail('Should have raised')
       rescue Mongo::Error::OperationFailure => e
         expect(e.code).to eq(11000)
-        # 4.0 and 4.1 sharded clusters set code name.
-        # 4.0 and 4.1 replica sets and standalones do not,
+        # 4.0 and 4.2 sharded clusters set code name.
+        # 4.0 and 4.2 replica sets and standalones do not,
         # and neither do older versions.
         expect([nil, 'DuplicateKey']).to include(e.code_name)
       end

data/spec/integration/{read_concern.rb → read_concern_spec.rb}

@@ -1,11 +1,17 @@
 require 'spec_helper'
 
 describe 'read concern' do
+  min_server_version '3.2'
+
   let(:subscriber) do
     EventSubscriber.new
   end
 
   let(:specified_read_concern) do
+    { :level => :local }
+  end
+
+  let(:expected_read_concern) do
     { 'level' => 'local' }
   end
 
@@ -17,7 +23,7 @@ describe 'read concern' do
 
   shared_examples_for 'a read concern is specified' do
     it 'sends a read concern to the server' do
-      expect(sent_read_concern).to eq(specified_read_concern)
+      expect(sent_read_concern).to eq(expected_read_concern)
     end
   end
 

data/spec/integration/read_preference_spec.rb

@@ -0,0 +1,485 @@
+require 'spec_helper'
+
+# The only allowed read preference in transaction is primary.
+# Because of this, the tests assert that the final read preference is primary.
+# It would be preferable to assert that some other read preference is selected,
+# but this would only work for non-transactional tests and would require
+# duplicating the examples.
+
+describe 'Read preference' do
+  clean_slate_on_evergreen
+
+  let(:client) do
+    authorized_client.with(client_options)
+  end
+
+  let(:subscriber) { EventSubscriber.new }
+
+  before do
+    client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
+  end
+
+  let(:client_options) do
+    {}
+  end
+
+  let(:session_options) do
+    {}
+  end
+
+  let(:tx_options) do
+    {}
+  end
+
+  let(:collection) { client['tx_read_pref_test'] }
+
+  before do
+    collection.drop
+    collection.create(write_concern: {w: :majority})
+  end
+
+  let(:find_options) do
+    {}
+  end
+
+  shared_examples_for 'sends expected read preference when reading' do
+    it 'sends expected read preference when reading' do
+      read_operation
+
+      event = subscriber.single_command_started_event('find')
+      actual_preference = event.command['$readPreference']
+      expect(actual_preference).to eq(expected_read_preference)
+    end
+  end
+
+  shared_examples_for 'does not send read preference when reading' do
+    it 'does not send read preference when reading' do
+      read_operation
+
+      event = subscriber.single_command_started_event('find')
+      actual_preference = event.command['$readPreference']
+      expect(actual_preference).to be nil
+    end
+  end
+
+  shared_examples_for 'non-transactional read preference examples' do
+    it 'does not send read preference when writing' do
+      write_operation
+
+      event = subscriber.single_command_started_event('insert')
+      actual_preference = event.command['$readPreference']
+      expect(actual_preference).to be nil
+    end
+
+    context 'standalone' do
+      require_topology :single
+
+      it_behaves_like 'does not send read preference when reading'
+    end
+
+    context 'RS, sharded cluster' do
+      # Supposedly read preference should only be sent in a sharded cluster
+      # topology. However, transactions spec tests contain read preference
+      # assertions also when they are run in RS topologies.
+      require_topology :sharded, :replica_set
+
+      context 'pre-OP_MSG server' do
+        max_server_version '3.4'
+
+        it_behaves_like 'does not send read preference when reading'
+      end
+
+      context 'server supporting OP_MSG' do
+        min_server_fcv '3.6'
+
+        it_behaves_like 'sends expected read preference when reading'
+      end
+    end
+  end
+
+  shared_examples_for 'sends expected read preference' do
+    it_behaves_like 'non-transactional read preference examples'
+  end
+
+  shared_context 'non-transactional read preference specifications' do
+
+    context 'when read preference is not explicitly given' do
+      let(:client_options) do
+        {}
+      end
+
+      let(:expected_read_preference) do
+        nil
+      end
+
+      it_behaves_like 'sends expected read preference'
+    end
+
+    context 'when read preference is given in client options' do
+      let(:client_options) do
+        {read: { mode: :primary }}
+      end
+
+      let(:expected_read_preference) do
+        {'mode' => 'primary'}
+      end
+
+      it_behaves_like 'sends expected read preference'
+    end
+
+    context 'when read preference is given in operation options' do
+      let(:expected_read_preference) do
+        {'mode' => 'primary'}
+      end
+
+      let(:find_options) do
+        {read: {mode: :primary}}
+      end
+
+      it_behaves_like 'sends expected read preference'
+    end
+
+    context 'when read preference is given in client and operation options' do
+      let(:client_options) do
+        {read: { mode: :secondary }}
+      end
+
+      # Operation should override the client.
+      let(:expected_read_preference) do
+        {'mode' => 'primary'}
+      end
+
+      let(:find_options) do
+        {read: {mode: :primary}}
+      end
+
+      it_behaves_like 'sends expected read preference'
+    end
+
+    context 'when read preference is given in collection and operation options' do
+      let(:collection) do
+        client['tx_read_pref_test', {read: {mode: :secondary}}]
+      end
+
+      # Operation should override the collection.
+      let(:expected_read_preference) do
+        {'mode' => 'primary'}
+      end
+
+      let(:find_options) do
+        {read: {mode: :primary}}
+      end
+
+      it_behaves_like 'sends expected read preference'
+    end
+  end
+
+  context 'not in transaction' do
+
+    let(:write_operation) do
+      collection.insert_one(hello: 'world')
+    end
+
+    let(:read_operation) do
+      collection.with(write: {w: :majority}).insert_one(hello: 'world')
+      res = collection.find({}, find_options || {}).to_a.count
+      expect(res).to eq(1)
+    end
+
+    include_context 'non-transactional read preference specifications'
+
+    context 'when read preference is given in collection options' do
+      let(:client_options) do
+        {}
+      end
+
+      let(:collection) do
+        client['tx_read_pref_test', {read: {mode: :primary}}]
+      end
+
+      let(:expected_read_preference) do
+        {'mode' => 'primary'}
+      end
+
+      it_behaves_like 'sends expected read preference'
+    end
+
+    context 'when read preference is given in collection options via #with' do
+      let(:collection) do
+        client['tx_read_pref_test'].with(read: {mode: :primary})
+      end
+
+      let(:expected_read_preference) do
+        {'mode' => 'primary'}
+      end
+
+      it_behaves_like 'sends expected read preference'
+    end
+
+    context 'when read preference is given in client and collection options' do
+      let(:client_options) do
+        {read: { mode: :secondary }}
+      end
+
+      let(:collection) do
+        client['tx_read_pref_test', {read: {mode: :primary}}]
+      end
+
+      # Collection should override the client.
+      let(:expected_read_preference) do
+        {'mode' => 'primary'}
+      end
+
+      it_behaves_like 'sends expected read preference'
+    end
+  end
+
+  context 'in transaction' do
+    # 4.0/RS is a valid topology to test against, but our tooling doesn't
+    # support multiple constraint specifications like runOn does.
+    # There is no loss of generality to constrain these tests to 4.2+.
+    min_server_fcv '4.2'
+    require_topology :sharded, :replica_set
+
+    let(:write_operation) do
+      expect do
+        session = client.start_session(session_options)
+        session.with_transaction(tx_options) do
+          collection.insert_one({hello: 'world'}, session: session)
+        end
+      end.not_to raise_error
+    end
+
+    let(:read_operation) do
+      expect do
+        session = client.start_session(session_options)
+        session.with_transaction(tx_options) do
+          collection.insert_one({hello: 'world'}, session: session)
+          res = collection.find({}, {session: session}.merge(find_options || {})).to_a.count
+          expect(res).to eq(1)
+        end
+      end.not_to raise_error
+    end
+
+    shared_examples_for 'sends expected read preference' do
+      it_behaves_like 'non-transactional read preference examples'
+
+      it 'sends expected read preference when starting transaction' do
+        collection.insert_one(hello: 'world')
+
+        session = client.start_session(session_options)
+        session.with_transaction(tx_options) do
+          res = collection.find({}, {session: session}.merge(find_options || {})).to_a.count
+          expect(res).to eq(1)
+        end
+
+        event = subscriber.single_command_started_event('find')
+        actual_preference = event.command['$readPreference']
+        expect(actual_preference).to eq(expected_read_preference)
+      end
+    end
+
+    include_context 'non-transactional read preference specifications'
+
+    context 'when read preference is given in collection options' do
+      let(:client_options) do
+        {}
+      end
+
+      let(:collection) do
+        client['tx_read_pref_test', {read: {mode: :primary}}]
+      end
+
+      # collection read preference is ignored
+      let(:expected_read_preference) do
+        nil
+      end
+
+      it_behaves_like 'sends expected read preference'
+    end
+
+    context 'when read preference is given in collection options via #with' do
+      let(:collection) do
+        client['tx_read_pref_test'].with(read: {mode: :primary})
+      end
+
+      # collection read preference is ignored
+      let(:expected_read_preference) do
+        nil
+      end
+
+      it_behaves_like 'sends expected read preference'
+    end
+
+    context 'when read preference is given in client and collection options' do
+      let(:client_options) do
+        {read: { mode: :primary }}
+      end
+
+      let(:collection) do
+        client['tx_read_pref_test', {read: {mode: :secondary}}]
+      end
+
+      # collection read preference is ignored, client read preference is used
+      let(:expected_read_preference) do
+        {'mode' => 'primary'}
+      end
+
+      it_behaves_like 'sends expected read preference'
+    end
+
+    context 'when read preference is given in default transaction options' do
+      let(:session_options) do
+        {default_transaction_options: {read: { mode: :primary }}}
+      end
+
+      let(:expected_read_preference) do
+        {'mode' => 'primary'}
+      end
+
+      it_behaves_like 'sends expected read preference'
+    end
+
+    context 'when read preference is given in client and default transaction options' do
+      let(:client_options) do
+        {read: { mode: :secondary }}
+      end
+
+      let(:session_options) do
+        {default_transaction_options: {read: { mode: :primary }}}
+      end
+
+      let(:expected_read_preference) do
+        {'mode' => 'primary'}
+      end
+
+      it_behaves_like 'sends expected read preference'
+    end
+
+    context 'when read preference is given in collection and default transaction options' do
+      let(:collection) do
+        client['tx_read_pref_test', {read: {mode: :secondary}}]
+      end
+
+      let(:session_options) do
+        {default_transaction_options: {read: { mode: :primary }}}
+      end
+
+      let(:expected_read_preference) do
+        {'mode' => 'primary'}
+      end
+
+      it_behaves_like 'sends expected read preference'
+    end
+
+    context 'when read preference is given in default transaction and transaction options' do
+      let(:session_options) do
+        {default_transaction_options: {read: { mode: :secondary }}}
+      end
+
+      let(:tx_options) do
+        {read: { mode: :primary }}
+      end
+
+      let(:expected_read_preference) do
+        {'mode' => 'primary'}
+      end
+
+      it_behaves_like 'sends expected read preference'
+    end
+
+    context 'when read preference is given in default transaction and operation options' do
+      let(:session_options) do
+        {default_transaction_options: {read: { mode: :primary }}}
+      end
+
+      let(:find_options) do
+        {read: {mode: :secondary}}
+      end
+
+      let(:expected_read_preference) do
+        {'mode' => 'primary'}
+      end
+
+      it 'sends operation read preference and fails' do
+        expect do
+          session = client.start_session(session_options)
+          session.with_transaction(tx_options) do
+            collection.insert_one({hello: 'world'}, session: session)
+            res = collection.find({}, {session: session}.merge(find_options || {})).to_a.count
+            expect(res).to eq(1)
+          end
+        end.to raise_error(Mongo::Error::InvalidTransactionOperation, "read preference in a transaction must be primary (requested: secondary)")
+      end
+    end
+
+    context 'when read preference is given in transaction options' do
+      let(:tx_options) do
+        {read: { mode: :primary }}
+      end
+
+      let(:expected_read_preference) do
+        {'mode' => 'primary'}
+      end
+
+      it_behaves_like 'sends expected read preference'
+    end
+
+    context 'when read preference is given in client and transaction options' do
+      let(:client_options) do
+        {read: { mode: :secondary }}
+      end
+
+      let(:tx_options) do
+        {read: { mode: :primary }}
+      end
+
+      let(:expected_read_preference) do
+        {'mode' => 'primary'}
+      end
+
+      it_behaves_like 'sends expected read preference'
+    end
+
+    context 'when read preference is given in collection and transaction options' do
+      let(:collection) do
+        client['tx_read_pref_test', {read: {mode: :secondary}}]
+      end
+
+      let(:tx_options) do
+        {read: { mode: :primary }}
+      end
+
+      let(:expected_read_preference) do
+        {'mode' => 'primary'}
+      end
+
+      it_behaves_like 'sends expected read preference'
+    end
+
+    context 'when read preference is given in transaction and operation options' do
+      let(:tx_options) do
+        {read: { mode: :primary }}
+      end
+
+      let(:find_options) do
+        {read: {mode: :secondary}}
+      end
+
+      let(:expected_read_preference) do
+        {'mode' => 'primary'}
+      end
+
+      it 'sends operation read preference and fails' do
+        expect do
+          session = client.start_session(session_options)
+          session.with_transaction(tx_options) do
+            collection.insert_one({hello: 'world'}, session: session)
+            res = collection.find({}, {session: session}.merge(find_options || {})).to_a.count
+            expect(res).to eq(1)
+          end
+        end.to raise_error(Mongo::Error::InvalidTransactionOperation, "read preference in a transaction must be primary (requested: secondary)")
+      end
+    end
+  end
+end