mongo 2.7.0 → 2.7.1

data/spec/mongo/operation/insert/op_msg_spec.rb

@@ -89,7 +89,7 @@ describe Mongo::Operation::Insert::OpMsg do
   describe '#message' do
 
     context 'when the server supports OP_MSG' do
-      min_server_version '3.6'
+      min_server_fcv '3.6'
 
       let(:documents) do
         [ { foo: 1 }, { bar: 2 }]
@@ -119,7 +119,7 @@ describe Mongo::Operation::Insert::OpMsg do
       end
 
       context 'when the topology is replica set or sharded' do
-        min_server_version '3.6'
+        min_server_fcv '3.6'
         require_topology :replica_set, :sharded
 
         let(:expected_global_args) do
@@ -136,7 +136,9 @@ describe Mongo::Operation::Insert::OpMsg do
         end
       end
 
-      context 'when the topology is standalone', if: standalone? && sessions_enabled? do
+      context 'when the topology is standalone' do
+        min_server_fcv '3.6'
+        require_topology :single
 
         let(:expected_global_args) do
           global_args
@@ -192,7 +194,7 @@ describe Mongo::Operation::Insert::OpMsg do
           end
 
           context 'when the topology is replica set or sharded' do
-            min_server_version '3.6'
+            min_server_fcv '3.6'
             require_topology :replica_set, :sharded
 
             let(:expected_global_args) do
@@ -212,7 +214,9 @@ describe Mongo::Operation::Insert::OpMsg do
             end
           end
 
-          context 'when the topology is standalone', if: standalone? && sessions_enabled? do
+          context 'when the topology is standalone' do
+            min_server_fcv '3.6'
+            require_topology :single
 
             let(:expected_global_args) do
               global_args.dup.tap do |args|
@@ -232,7 +236,7 @@ describe Mongo::Operation::Insert::OpMsg do
         end
 
         context 'when the session is explicit' do
-          min_server_version '3.6'
+          min_server_fcv '3.6'
           require_topology :replica_set, :sharded
 
           let(:session) do

data/spec/mongo/operation/update/op_msg_spec.rb

@@ -95,7 +95,7 @@ describe Mongo::Operation::Update::OpMsg do
   describe '#message' do
 
     context 'when the server supports OP_MSG' do
-      min_server_version '3.6'
+      min_server_fcv '3.6'
 
       let(:global_args) do
         {
@@ -121,7 +121,7 @@ describe Mongo::Operation::Update::OpMsg do
       end
 
       context 'when the topology is replica set or sharded' do
-        min_server_version '3.6'
+        min_server_fcv '3.6'
         require_topology :replica_set, :sharded
 
         let(:expected_global_args) do
@@ -135,7 +135,9 @@ describe Mongo::Operation::Update::OpMsg do
         end
       end
 
-      context 'when the topology is standalone', if: standalone? && sessions_enabled? do
+      context 'when the topology is standalone' do
+        min_server_fcv '3.6'
+        require_topology :single
 
         let(:expected_global_args) do
           global_args
@@ -184,7 +186,7 @@ describe Mongo::Operation::Update::OpMsg do
           end
 
           context 'when the topology is replica set or sharded' do
-            min_server_version '3.6'
+            min_server_fcv '3.6'
             require_topology :replica_set, :sharded
 
             let(:expected_global_args) do
@@ -201,7 +203,9 @@ describe Mongo::Operation::Update::OpMsg do
             end
           end
 
-          context 'when the topology is standalone', if: standalone? && sessions_enabled? do
+          context 'when the topology is standalone' do
+            min_server_fcv '3.6'
+            require_topology :single
 
             let(:expected_global_args) do
               global_args.dup.tap do |args|
@@ -218,7 +222,7 @@ describe Mongo::Operation::Update::OpMsg do
         end
 
         context 'when the session is explicit' do
-          min_server_version '3.6'
+          min_server_fcv '3.6'
           require_topology :replica_set, :sharded
 
           let(:session) do

data/spec/mongo/protocol/compressed_spec.rb

@@ -53,7 +53,7 @@ describe Mongo::Protocol::Compressed do
     end
 
     context 'when the original message is not replyable' do
-      min_server_version '3.6'
+      min_server_fcv '3.6'
 
       let(:original_message) do
         Mongo::Protocol::Msg.new([:more_to_come], {}, { ping: 1 })

data/spec/mongo/protocol/msg_spec.rb

@@ -441,7 +441,7 @@ describe Mongo::Protocol::Msg do
     context 'when the msg only contains a payload type 0' do
 
       it 'creates a payload with the command' do
-        expect(message.payload[:command_name]).to eq(:ping)
+        expect(message.payload[:command_name]).to eq('ping')
         expect(message.payload[:database_name]).to eq(SpecConfig.instance.test_db)
         expect(message.payload[:command]).to eq('ping' => 1)
         expect(message.payload[:request_id]).to eq(message.request_id)

data/spec/mongo/server/app_metadata_spec.rb

@@ -106,12 +106,13 @@ describe Mongo::Server::AppMetadata do
       end
 
       context 'when the driver info is too long' do
+        require_no_compression
 
         before do
           allow(app_metadata).to receive(:driver_doc).and_return('x'*500)
         end
 
-        it 'truncates the document to be just an ismaster command and the compressors', unless: compression_enabled? do
+        it 'truncates the document to be just an ismaster command and the compressors' do
           # Because we sometimes request that the server provide a list of valid auth mechanisms for
           # the user, we need to conditionally add the length of that metadata to the expected
           # length of the isMaster document.

data/spec/mongo/server/connection_auth_spec.rb

@@ -55,7 +55,7 @@ describe Mongo::Server::Connection, retry: 3 do
     end
 
     context 'when the ismaster response includes saslSupportedMechs' do
-      min_server_version '4.0'
+      min_server_fcv '4.0'
 
       let(:server_options) do
         SpecConfig.instance.test_options.merge(

data/spec/mongo/server/monitor/connection_spec.rb

@@ -116,4 +116,46 @@ describe Mongo::Server::Monitor::Connection do
       end
     end
   end
+
+  describe '#ismaster' do
+    let(:options) do
+      SpecConfig.instance.test_options
+    end
+
+    let(:result) { connection.ismaster }
+
+    it 'returns a hash' do
+      expect(result).to be_a(Hash)
+    end
+
+    it 'is successful' do
+      expect(result['ok']).to eq(1.0)
+    end
+
+    context 'network error during ismaster' do
+      let(:result) do
+        connection
+
+        socket = connection.send(:socket).send(:socket)
+        expect([Socket, OpenSSL::SSL::SSLSocket]).to include(socket.class)
+
+        expect(socket).to receive(:write).and_raise(IOError)
+        expect(socket).to receive(:write).and_call_original
+
+        connection.ismaster
+      end
+
+      it 'retries ismaster and is successful' do
+        expect(result).to be_a(Hash)
+        expect(result['ok']).to eq(1.0)
+      end
+
+      it 'logs the retry' do
+        expect(Mongo::Logger.logger).to receive(:warn) do |msg|
+          expect(msg).to match(/Retrying ismaster on #{connection.address}/)
+        end
+        expect(result).to be_a(Hash)
+      end
+    end
+  end
 end

data/spec/mongo/server_selector_spec.rb

@@ -206,9 +206,13 @@ describe Mongo::ServerSelector do
 
       let(:cluster) do
         double('cluster').tap do |c|
+          allow(c).to receive(:connected?).and_return(true)
           allow(c).to receive(:summary)
           allow(c).to receive(:topology).and_return(topology)
           allow(c).to receive(:servers).and_return(servers)
+          allow(c).to receive(:servers_list).and_return(servers)
+          allow(c).to receive(:addresses).and_return(servers.map(&:address))
+          allow(c).to receive(:replica_set?).and_return(true)
           allow(c).to receive(:single?).and_return(false)
           allow(c).to receive(:sharded?).and_return(false)
           allow(c).to receive(:unknown?).and_return(false)
@@ -238,9 +242,13 @@ describe Mongo::ServerSelector do
 
       let(:cluster) do
         double('cluster').tap do |c|
+          allow(c).to receive(:connected?).and_return(true)
           allow(c).to receive(:summary)
           allow(c).to receive(:topology).and_return(topology)
           allow(c).to receive(:servers).and_return(servers)
+          allow(c).to receive(:servers_list).and_return(servers)
+          allow(c).to receive(:addresses).and_return(servers.map(&:address))
+          allow(c).to receive(:replica_set?).and_return(true)
           allow(c).to receive(:single?).and_return(false)
           allow(c).to receive(:sharded?).and_return(false)
           allow(c).to receive(:unknown?).and_return(false)
@@ -284,9 +292,12 @@ describe Mongo::ServerSelector do
 
       let(:cluster) do
         double('cluster').tap do |c|
+          allow(c).to receive(:connected?).and_return(true)
           allow(c).to receive(:summary)
           allow(c).to receive(:topology).and_return(topology)
           allow(c).to receive(:servers).and_return(servers)
+          allow(c).to receive(:addresses).and_return(servers.map(&:address))
+          allow(c).to receive(:replica_set?).and_return(true)
           allow(c).to receive(:single?).and_return(false)
           allow(c).to receive(:sharded?).and_return(false)
           allow(c).to receive(:unknown?).and_return(false)
@@ -311,9 +322,12 @@ describe Mongo::ServerSelector do
 
       let(:cluster) do
         double('cluster').tap do |c|
+          allow(c).to receive(:connected?).and_return(true)
           allow(c).to receive(:summary)
           allow(c).to receive(:topology).and_return(topology)
           allow(c).to receive(:servers).and_return([server])
+          allow(c).to receive(:addresses).and_return([server.address])
+          allow(c).to receive(:replica_set?).and_return(true)
           allow(c).to receive(:single?).and_return(false)
           allow(c).to receive(:sharded?).and_return(false)
           allow(c).to receive(:unknown?).and_return(false)
@@ -348,9 +362,12 @@ describe Mongo::ServerSelector do
 
       let(:cluster) do
         double('cluster').tap do |c|
+          allow(c).to receive(:connected?).and_return(true)
           allow(c).to receive(:summary)
           allow(c).to receive(:topology).and_return(topology)
           allow(c).to receive(:servers).and_return(servers)
+          allow(c).to receive(:addresses).and_return([])
+          allow(c).to receive(:replica_set?).and_return(!single && !sharded)
           allow(c).to receive(:single?).and_return(single)
           allow(c).to receive(:sharded?).and_return(sharded)
           allow(c).to receive(:unknown?).and_return(false)

data/spec/mongo/server_spec.rb

@@ -265,4 +265,114 @@ describe Mongo::Server do
       end
     end
   end
+
+  describe '#summary' do
+    context 'server is primary' do
+      let(:server) do
+        make_server(:primary)
+      end
+
+      before do
+        expect(server).to be_primary
+      end
+
+      it 'includes its status' do
+        expect(server.summary).to match(/PRIMARY/)
+      end
+
+      it 'includes replica set name' do
+        expect(server.summary).to match(/replica_set=mongodb_set/)
+      end
+    end
+
+    context 'server is secondary' do
+      let(:server) do
+        make_server(:secondary)
+      end
+
+      before do
+        expect(server).to be_secondary
+      end
+
+      it 'includes its status' do
+        expect(server.summary).to match(/SECONDARY/)
+      end
+
+      it 'includes replica set name' do
+        expect(server.summary).to match(/replica_set=mongodb_set/)
+      end
+    end
+
+    context 'server is arbiter' do
+      let(:server) do
+        make_server(:arbiter)
+      end
+
+      before do
+        expect(server).to be_arbiter
+      end
+
+      it 'includes its status' do
+        expect(server.summary).to match(/ARBITER/)
+      end
+
+      it 'includes replica set name' do
+        expect(server.summary).to match(/replica_set=mongodb_set/)
+      end
+    end
+
+    context 'server is ghost' do
+      let(:server) do
+        make_server(:ghost)
+      end
+
+      before do
+        expect(server).to be_ghost
+      end
+
+      it 'includes its status' do
+        expect(server.summary).to match(/GHOST/)
+      end
+
+      it 'does not include replica set name' do
+        expect(server.summary).not_to include('replica_set')
+      end
+    end
+
+    context 'server is other' do
+      let(:server) do
+        make_server(:other)
+      end
+
+      before do
+        expect(server).to be_other
+      end
+
+      it 'includes its status' do
+        expect(server.summary).to match(/OTHER/)
+      end
+
+      it 'includes replica set name' do
+        expect(server.summary).to match(/replica_set=mongodb_set/)
+      end
+    end
+
+    context 'server is unknown' do
+      let(:server) do
+        described_class.new(address, cluster, monitoring, listeners, SpecConfig.instance.test_options)
+      end
+
+      before do
+        expect(server).to be_unknown
+      end
+
+      it 'includes unknown status' do
+        expect(server.summary).to match(/UNKNOWN/)
+      end
+
+      it 'does not include replica set name' do
+        expect(server.summary).not_to include('replica_set')
+      end
+    end
+  end
 end

data/spec/mongo/session/session_pool_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe Mongo::Session::SessionPool do
-  min_server_version '3.6'
+  min_server_fcv '3.6'
   require_topology :replica_set, :sharded
 
   let(:cluster) do

data/spec/mongo/session_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe Mongo::Session do
-  min_server_version '3.6'
+  min_server_fcv '3.6'
   require_topology :replica_set, :sharded
 
   let(:session) do

data/spec/mongo/session_transaction_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 class SessionTransactionSpecError < StandardError; end
 
 describe Mongo::Session do
-  min_server_version '4.0'
+  min_server_fcv '4.0'
   require_topology :replica_set, :sharded
 
   let(:session) do
@@ -22,6 +22,54 @@ describe Mongo::Session do
     collection.delete_many
   end
 
+  describe '#abort_transaction' do
+    require_topology :replica_set
+
+    context 'when a non-Mongo error is raised' do
+      before do
+        collection.insert_one({foo: 1})
+      end
+
+      it 'propagates the exception and sets state to transaction aborted' do
+        session.start_transaction
+        collection.insert_one({foo: 1}, session: session)
+        expect(session).to receive(:write_with_retry).and_raise(SessionTransactionSpecError)
+        expect do
+          session.abort_transaction
+        end.to raise_error(SessionTransactionSpecError)
+        expect(session.send(:within_states?, Mongo::Session::TRANSACTION_ABORTED_STATE)).to be true
+
+        # Since we failed abort_transaction call, the transaction is still
+        # outstanding. It will cause subsequent tests to stall until it times
+        # out on the server side. End the session to force the server
+        # to close the transaction.
+        kill_all_server_sessions
+      end
+    end
+
+    context 'when a Mongo error is raised' do
+      before do
+        collection.insert_one({foo: 1})
+      end
+
+      it 'swallows the exception and sets state to transaction aborted' do
+        session.start_transaction
+        collection.insert_one({foo: 1}, session: session)
+        expect(session).to receive(:write_with_retry).and_raise(Mongo::Error::SocketError)
+        expect do
+          session.abort_transaction
+        end.not_to raise_error
+        expect(session.send(:within_states?, Mongo::Session::TRANSACTION_ABORTED_STATE)).to be true
+
+        # Since we failed abort_transaction call, the transaction is still
+        # outstanding. It will cause subsequent tests to stall until it times
+        # out on the server side. End the session to force the server
+        # to close the transaction.
+        kill_all_server_sessions
+      end
+    end
+  end
+
   describe '#with_transaction' do
     context 'callback successful' do
       it 'commits' do
@@ -60,5 +108,118 @@ describe Mongo::Session do
         expect(rv).to eq(42)
       end
     end
+
+    context 'timeout with callback raising TransientTransactionError' do
+      max_example_run_time 7
+
+      after do
+        Timecop.return
+      end
+
+      it 'times out' do
+        warp = Time.now + 200
+        entered = false
+
+        Thread.new do
+          until entered
+            sleep 0.1
+          end
+          Timecop.travel warp
+        end
+
+        expect do
+          session.with_transaction do
+            entered = true
+
+            # This sleep is to give the interrupting thread a chance to run,
+            # it significantly affects how much time is burned in this
+            # looping thread
+            sleep 0.1
+
+            exc = Mongo::Error::OperationFailure.new('timeout test')
+            exc.send(:add_label, Mongo::Error::TRANSIENT_TRANSACTION_ERROR_LABEL)
+            raise exc
+          end
+        end.to raise_error(Mongo::Error::OperationFailure, 'timeout test')
+      end
+    end
+
+    %w(UNKNOWN_TRANSACTION_COMMIT_RESULT_LABEL TRANSIENT_TRANSACTION_ERROR_LABEL).each do |label|
+      context "timeout with commit raising with #{label}" do
+        max_example_run_time 7
+
+        after do
+          Timecop.return
+        end
+
+        before do
+          # create collection if it does not exist
+          collection.insert_one(a: 1)
+        end
+
+        it 'times out' do
+          warp = Time.now + 200
+          entered = false
+
+          Thread.new do
+            until entered
+              sleep 0.1
+            end
+            Timecop.travel warp
+          end
+
+          exc = Mongo::Error::OperationFailure.new('timeout test')
+          exc.send(:add_label, Mongo::Error.const_get(label))
+
+          expect(session).to receive(:commit_transaction).and_raise(exc).at_least(:once)
+
+          expect do
+            session.with_transaction do
+              entered = true
+
+              # This sleep is to give the interrupting thread a chance to run,
+              # it significantly affects how much time is burned in this
+              # looping thread
+              sleep 0.1
+
+              collection.insert_one(a: 2)
+            end
+          end.to raise_error(Mongo::Error::OperationFailure, 'timeout test')
+        end
+      end
+    end
+
+    context 'callback breaks out of with_tx loop' do
+      it 'aborts transaction' do
+        expect(session).to receive(:start_transaction).and_call_original
+        expect(session).to receive(:abort_transaction).and_call_original
+        expect(session).to receive(:log_warn).and_call_original
+
+        session.with_transaction do
+          break
+        end
+      end
+    end
+
+    context 'application timeout around with_tx' do
+      it 'keeps session in a working state' do
+        session
+        collection.insert_one(a: 1)
+
+        expect do
+          Timeout.timeout(1, SessionTransactionSpecError) do
+            session.with_transaction do
+              sleep 2
+            end
+          end
+        end.to raise_error(SessionTransactionSpecError)
+
+        session.with_transaction do
+          collection.insert_one(timeout_around_with_tx: 2)
+        end
+
+        expect(collection.find(timeout_around_with_tx: 2).first).not_to be nil
+      end
+    end
   end
 end