mongo 2.7.0 → 2.7.1

data/spec/mongo/client_construction_spec.rb

@@ -190,9 +190,14 @@ describe Mongo::Client do
             expect(client.cluster.app_metadata.send(:document)[:compression]).to eq(options[:compressors])
           end
 
-          it 'uses compression for messages', if: testing_compression? do
-            expect(Mongo::Protocol::Compressed).to receive(:new).and_call_original
-            client[TEST_COLL].find({}, limit: 1).first
+          context 'when server supports compression' do
+            require_compression
+            min_server_fcv '3.6'
+
+            it 'uses compression for messages' do
+              expect(Mongo::Protocol::Compressed).to receive(:new).and_call_original
+              client[TEST_COLL].find({}, limit: 1).first
+            end
           end
 
           it 'does not use compression for authentication messages' do
@@ -218,7 +223,9 @@ describe Mongo::Client do
             expect(client.cluster.app_metadata.send(:document)[:compression]).to eq([])
           end
 
-          context 'when one supported compressor and one unsupported compressor are provided', if: compression_enabled? do
+          context 'when one supported compressor and one unsupported compressor are provided' do
+            require_compression
+            min_server_fcv '3.6'
 
             let(:options) do
               { compressors: ['zlib', 'snoopy'] }
@@ -235,7 +242,8 @@ describe Mongo::Client do
           end
         end
 
-        context 'when the compressor is not supported by the server', unless: collation_enabled? do
+        context 'when the compressor is not supported by the server' do
+          max_server_version '3.4'
 
           let(:options) do
             { compressors: ['zlib'] }
@@ -248,7 +256,8 @@ describe Mongo::Client do
         end
       end
 
-      context 'when compressors are not provided', unless: compression_enabled? do
+      context 'when compressors are not provided' do
+        require_no_compression
 
         let(:client) do
           authorized_client
@@ -268,7 +277,9 @@ describe Mongo::Client do
         end
       end
 
-      context 'when a zlib_compression_level option is provided', if: testing_compression? do
+      context 'when a zlib_compression_level option is provided' do
+        require_compression
+        min_server_fcv '3.6'
 
         let(:client) do
           new_local_client_nmio(SpecConfig.instance.addresses, SpecConfig.instance.test_options.merge(zlib_compression_level: 1))

data/spec/mongo/client_spec.rb

@@ -502,7 +502,8 @@ describe Mongo::Client do
       )
     end
 
-    context 'when filter criteria is present', if: sessions_enabled? do
+    context 'when filter criteria is present' do
+      min_server_fcv '3.6'
 
       let(:result) do
         root_authorized_client.database_names(filter)
@@ -528,7 +529,8 @@ describe Mongo::Client do
         end).to include('admin')
     end
 
-    context 'when filter criteria is present', if: sessions_enabled? do
+    context 'when filter criteria is present' do
+      min_server_fcv '3.6'
 
       let(:result) do
         root_authorized_client.list_databases(filter)
@@ -592,7 +594,8 @@ describe Mongo::Client do
       expect(result.first.options[:read]).to eq(BSON::Document.new(options)[:read])
     end
 
-    context 'when filter criteria is present', if: sessions_enabled? do
+    context 'when filter criteria is present' do
+      min_server_fcv '3.6'
 
       let(:result) do
         client.list_mongo_databases(filter)
@@ -663,7 +666,7 @@ describe Mongo::Client do
     end
 
     context 'when sessions are supported' do
-      min_server_version '3.6'
+      min_server_fcv '3.6'
       require_topology :replica_set, :sharded
 
       it 'creates a session' do
@@ -756,7 +759,7 @@ describe Mongo::Client do
     end
 
     context 'when two clients have the same cluster' do
-      min_server_version '3.6'
+      min_server_fcv '3.6'
       require_topology :replica_set, :sharded
 
       let(:client) do
@@ -773,7 +776,7 @@ describe Mongo::Client do
     end
 
     context 'when two clients have different clusters' do
-      min_server_version '3.6'
+      min_server_fcv '3.6'
       require_topology :replica_set, :sharded
 
       let(:client) do
@@ -791,7 +794,8 @@ describe Mongo::Client do
       end
     end
 
-    context 'when sessions are not supported', unless: sessions_enabled? do
+    context 'when sessions are not supported' do
+      max_server_version '3.4'
 
       it 'raises an exception' do
         expect {

data/spec/mongo/cluster_spec.rb

@@ -589,7 +589,7 @@ describe Mongo::Cluster do
     end
 
     context 'in server 3.6+' do
-      min_server_version '3.6'
+      min_server_fcv '3.6'
 
       context 'in single topology' do
         require_topology :single
@@ -639,4 +639,33 @@ describe Mongo::Cluster do
       end
     end
   end
+
+  describe '#summary' do
+    context 'cluster has unknown servers' do
+      it 'includes unknown servers' do
+        cluster.servers_list.each do |server|
+          expect(server).to be_unknown
+        end
+
+        expect(cluster.summary).to match(/Server address=localhost/)
+      end
+    end
+
+    context 'cluster has known servers' do
+      let(:client) { ClientRegistry.instance.global_client('authorized') }
+      let(:cluster) { client.cluster }
+
+      before do
+        wait_for_all_servers(cluster)
+      end
+
+      it 'includes known servers' do
+        cluster.servers_list.each do |server|
+          expect(server).not_to be_unknown
+        end
+
+        expect(cluster.summary).to match(/Server address=localhost/)
+      end
+    end
+  end
 end

data/spec/mongo/collection/view/aggregation_spec.rb

@@ -145,7 +145,7 @@ describe Mongo::Collection::View::Aggregation do
     end
 
     context 'when the initial response has no results but an active cursor' do
-      min_server_version '3.2'
+      min_server_fcv '3.2'
 
       let(:documents) do
         [
@@ -177,14 +177,16 @@ describe Mongo::Collection::View::Aggregation do
         Mongo::Collection::View.new(collection, selector, view_options)
       end
 
-      context 'when the server supports write concern on the aggregate command', if: collation_enabled? do
+      context 'when the server supports write concern on the aggregate command' do
+        min_server_fcv '3.4'
 
         it 'does not apply the write concern' do
           expect(aggregation.to_a.size).to eq(2)
         end
       end
 
-      context 'when the server does not support write concern on the aggregation command', unless: collation_enabled? do
+      context 'when the server does not support write concern on the aggregation command' do
+        max_server_version '3.2'
 
         it 'does not apply the write concern' do
           expect(aggregation.to_a.size).to eq(2)
@@ -223,7 +225,7 @@ describe Mongo::Collection::View::Aggregation do
     end
 
     context 'session id' do
-      min_server_version '3.6'
+      min_server_fcv '3.6'
       require_topology :replica_set, :sharded
 
       let(:options) do
@@ -266,7 +268,8 @@ describe Mongo::Collection::View::Aggregation do
         aggregation.explain['$cursor']['queryPlanner']['collation']['locale']
       end
 
-      context 'when the server selected supports collations', if: collation_enabled? do
+      context 'when the server selected supports collations' do
+        min_server_fcv '3.4'
 
         context 'when the collation key is a String' do
 
@@ -291,7 +294,8 @@ describe Mongo::Collection::View::Aggregation do
         end
       end
 
-      context 'when the server selected does not support collations', unless: collation_enabled? do
+      context 'when the server selected does not support collations' do
+        max_server_version '3.2'
 
         let(:options) do
           { collation: { locale: 'en_US', strength: 2 } }
@@ -507,14 +511,16 @@ describe Mongo::Collection::View::Aggregation do
       aggregation.collect { |doc| doc['name']}
     end
 
-    context 'when the server selected supports collations', if: collation_enabled? do
+    context 'when the server selected supports collations' do
+      min_server_fcv '3.4'
 
       it 'applies the collation' do
         expect(result).to eq(['bang', 'bang'])
       end
     end
 
-    context 'when the server selected does not support collations', unless: collation_enabled? do
+    context 'when the server selected does not support collations' do
+      max_server_version '3.2'
 
       it 'raises an exception' do
         expect {
@@ -610,7 +616,8 @@ describe Mongo::Collection::View::Aggregation do
          Mongo::Collection::View.new(collection, selector, view_options)
        end
 
-       context 'when the server supports write concern on the aggregate command', if: collation_enabled? do
+       context 'when the server supports write concern on the aggregate command' do
+        min_server_fcv '3.4'
 
          it 'uses the write concern' do
            expect {
@@ -619,7 +626,8 @@ describe Mongo::Collection::View::Aggregation do
          end
        end
 
-       context 'when the server does not support write concern on the aggregation command', unless: collation_enabled? do
+       context 'when the server does not support write concern on the aggregation command' do
+        max_server_version '3.2'
 
          let(:documents) do
            [

data/spec/mongo/collection/view/change_stream_spec.rb

@@ -1,6 +1,8 @@
 require 'spec_helper'
 
-describe Mongo::Collection::View::ChangeStream, if: test_change_streams? do
+describe Mongo::Collection::View::ChangeStream do
+  min_server_fcv '3.6'
+  require_topology :replica_set
 
   let(:pipeline) do
     []
@@ -214,7 +216,7 @@ describe Mongo::Collection::View::ChangeStream, if: test_change_streams? do
           }.to raise_exception(Mongo::Error::OperationFailure)
         end
 
-        context 'when the operation fails', if: test_change_streams? do
+        context 'when the operation fails' do
 
           let!(:before_last_use) do
             session.instance_variable_get(:@server_session).last_use
@@ -270,7 +272,8 @@ describe Mongo::Collection::View::ChangeStream, if: test_change_streams? do
       end
     end
 
-    context 'when provided a session', if: sessions_enabled? && test_change_streams? do
+    context 'when provided a session' do
+      min_server_fcv '3.6'
 
       let(:options) do
         { session: session }
@@ -383,6 +386,7 @@ describe Mongo::Collection::View::ChangeStream, if: test_change_streams? do
     end
 
     context 'when some documents have been retrieved and the stream is closed before sending getMore' do
+      fails_on_jruby
 
       before do
         change_stream
@@ -437,11 +441,26 @@ describe Mongo::Collection::View::ChangeStream, if: test_change_streams? do
       authorized_collection.insert_one(a: 1)
     end
 
-    it 'raises an exception and closes the cursor' do
-      expect(cursor).to receive(:kill_cursors).and_call_original
-      expect {
-        change_stream.to_enum.next
-      }.to raise_exception(Mongo::Error::MissingResumeToken)
+    context 'pre-4.1 server' do
+      max_server_version '4.0'
+
+      it 'driver raises an exception and closes the cursor' do
+        expect(cursor).to receive(:kill_cursors).and_call_original
+        expect {
+          change_stream.to_enum.next
+        }.to raise_exception(Mongo::Error::MissingResumeToken)
+      end
+    end
+
+    context '4.1+ server' do
+      min_server_fcv '4.2'
+
+      it 'server errors, driver closes the cursor' do
+        expect(cursor).to receive(:kill_cursors).and_call_original
+        expect {
+          change_stream.to_enum.next
+        }.to raise_exception(Mongo::Error::OperationFailure, /Encountered an event whose _id field, which contains the resume token, was modified by the pipeline. Modifying the _id field of an event makes it impossible to resume the stream from that point. Only transformations that retain the unmodified _id field are allowed./)
+      end
     end
   end
 
@@ -574,6 +593,7 @@ describe Mongo::Collection::View::ChangeStream, if: test_change_streams? do
   end
 
   context 'when a server error is encountered during a getMore' do
+    fails_on_jruby
 
     context 'when the error is a resumable error' do
 

data/spec/mongo/collection/view/map_reduce_spec.rb

@@ -223,7 +223,7 @@ describe Mongo::Collection::View::MapReduce do
         end
 
         context 'when the output collection is iterated' do
-          min_server_version '3.6'
+          min_server_fcv '3.6'
           require_topology :replica_set, :sharded
 
           let(:options) do
@@ -257,19 +257,22 @@ describe Mongo::Collection::View::MapReduce do
           end
         end
 
-        context 'when another db is specified', if: (sessions_enabled? && !sharded? && !auth_enabled?) do
+        context 'when another db is specified' do
+          min_server_fcv '3.6'
+          require_topology :single, :replica_set
+          require_no_auth
 
           let(:new_map_reduce) do
             map_reduce.out(db: 'another-db', replace: 'output_collection')
           end
 
-          it 'iterates over the documents in the result', if: (sessions_enabled? && !sharded? && !auth_enabled?) do
+          it 'iterates over the documents in the result' do
             new_map_reduce.each do |document|
               expect(document[:value]).to_not be_nil
             end
           end
 
-          it 'fetches the results from the collection', if: (sessions_enabled? && !sharded? && !auth_enabled?)  do
+          it 'fetches the results from the collection'  do
             expect(new_map_reduce.count).to eq(2)
           end
         end
@@ -291,7 +294,10 @@ describe Mongo::Collection::View::MapReduce do
           expect(new_map_reduce.count).to eq(2)
         end
 
-        context 'when another db is specified', if: (!auth_enabled? && !sharded? && list_command_enabled?) do
+        context 'when another db is specified' do
+          min_server_fcv '3.0'
+          require_topology :single, :replica_set
+          require_no_auth
 
           let(:new_map_reduce) do
             map_reduce.out(db: 'another-db', merge: 'output_collection')
@@ -325,7 +331,10 @@ describe Mongo::Collection::View::MapReduce do
           expect(new_map_reduce.count).to eq(2)
         end
 
-        context 'when another db is specified', if: (!auth_enabled? && list_command_enabled? && !sharded?) do
+        context 'when another db is specified' do
+          min_server_fcv '3.0'
+          require_topology :single, :replica_set
+          require_no_auth
 
           let(:new_map_reduce) do
             map_reduce.out(db: 'another-db', reduce: 'output_collection')
@@ -585,7 +594,9 @@ describe Mongo::Collection::View::MapReduce do
 
           shared_examples_for 'map reduce that writes accepting write concern' do
 
-            context 'when the server supports write concern on the mapReduce command', if: (collation_enabled? && standalone?) do
+            context 'when the server supports write concern on the mapReduce command' do
+              min_server_fcv '3.4'
+              require_topology :single
 
               it 'uses the write concern' do
                 expect {
@@ -594,7 +605,8 @@ describe Mongo::Collection::View::MapReduce do
               end
             end
 
-            context 'when the server does not support write concern on the mapReduce command', unless: collation_enabled? do
+            context 'when the server does not support write concern on the mapReduce command' do
+              max_server_version '3.2'
 
               it 'does not apply the write concern' do
                 expect(map_reduce.to_a.size).to eq(2)
@@ -747,7 +759,8 @@ describe Mongo::Collection::View::MapReduce do
       { name: 'BANG' }
     end
 
-    context 'when the server selected supports collations', if: collation_enabled? do
+    context 'when the server selected supports collations' do
+      min_server_fcv '3.4'
 
       context 'when the collation key is a String' do
 
@@ -772,7 +785,8 @@ describe Mongo::Collection::View::MapReduce do
       end
     end
 
-    context 'when the server selected does not support collations', unless: collation_enabled? do
+    context 'when the server selected does not support collations' do
+      max_server_version '3.2'
 
       context 'when the map reduce has collation specified in its options' do
 

data/spec/mongo/collection/view/readable_spec.rb

@@ -21,7 +21,7 @@ describe Mongo::Collection::View::Readable do
   shared_examples_for 'a read concern aware operation' do
 
     context 'when a read concern is provided' do
-      min_server_version '3.2'
+      min_server_fcv '3.2'
 
       let(:new_view) do
         Mongo::Collection::View.new(new_collection, selector, options)
@@ -321,13 +321,18 @@ describe Mongo::Collection::View::Readable do
       end
     end
 
-    it 'takes a read preference option', unless: sharded? do
-      # Secondary may be delayed, since this tests wants 10 documents
-      # it must query the primary
-      expect(view.count(read: { mode: :primary })).to eq(10)
+    context 'not sharded' do
+      require_topology :single, :replica_set
+
+      it 'takes a read preference option' do
+        # Secondary may be delayed, since this tests wants 10 documents
+        # it must query the primary
+        expect(view.count(read: { mode: :primary })).to eq(10)
+      end
     end
 
-    context 'when a read preference is set on the view', unless: sharded? do
+    context 'when a read preference is set on the view' do
+      require_topology :single, :replica_set
 
       let(:client) do
         # Set a timeout otherwise, the test will hang for 30 seconds.
@@ -411,7 +416,8 @@ describe Mongo::Collection::View::Readable do
         end
       end
 
-      context 'when no read preference argument is provided', unless: sharded? do
+      context 'when no read preference argument is provided' do
+        require_topology :single, :replica_set
 
         before do
           allow(view.collection.client.cluster).to receive(:single?).and_return(false)
@@ -428,7 +434,8 @@ describe Mongo::Collection::View::Readable do
         end
       end
 
-      context 'when the collection does not have a read preference set', unless: sharded? do
+      context 'when the collection does not have a read preference set' do
+        require_topology :single, :replica_set
 
         after do
           client.close
@@ -506,14 +513,16 @@ describe Mongo::Collection::View::Readable do
         { collation: { locale: 'en_US', strength: 2 } }
       end
 
-      context 'when the server selected supports collations', if: collation_enabled? do
+      context 'when the server selected supports collations' do
+        min_server_fcv '3.4'
 
         it 'applies the collation to the count' do
           expect(result).to eq(1)
         end
       end
 
-      context 'when the server selected does not support collations', unless: collation_enabled? do
+      context 'when the server selected does not support collations' do
+        max_server_version '3.2'
 
         it 'raises an exception' do
           expect {
@@ -554,14 +563,16 @@ describe Mongo::Collection::View::Readable do
         { collation: { locale: 'en_US', strength: 2 } }
       end
 
-      context 'when the server selected supports collations', if: collation_enabled? do
+      context 'when the server selected supports collations' do
+        min_server_fcv '3.4'
 
         it 'applies the collation to the count' do
           expect(result).to eq(1)
         end
       end
 
-      context 'when the server selected does not support collations', unless: collation_enabled? do
+      context 'when the server selected does not support collations' do
+        max_server_version '3.2'
 
         it 'raises an exception' do
           expect {
@@ -699,7 +710,8 @@ describe Mongo::Collection::View::Readable do
       end
     end
 
-    context 'when a read preference is set on the view', unless: sharded? do
+    context 'when a read preference is set on the view' do
+      require_topology :single, :replica_set
 
       let(:client) do
         # Set a timeout otherwise, the test will hang for 30 seconds.
@@ -776,7 +788,8 @@ describe Mongo::Collection::View::Readable do
         end
       end
 
-      context 'when no read preference argument is provided', unless: sharded? do
+      context 'when no read preference argument is provided' do
+        require_topology :single, :replica_set
 
         before do
           allow(view.collection.client.cluster).to receive(:single?).and_return(false)
@@ -793,7 +806,8 @@ describe Mongo::Collection::View::Readable do
         end
       end
 
-      context 'when the collection does not have a read preference set', unless: sharded? do
+      context 'when the collection does not have a read preference set' do
+        require_topology :single, :replica_set
 
         let(:documents) do
           (1..3).map{ |i| { field: "test#{i}" }}
@@ -891,14 +905,16 @@ describe Mongo::Collection::View::Readable do
         { collation: { locale: 'en_US', strength: 2 } }
       end
 
-      context 'when the server selected supports collations', if: collation_enabled? do
+      context 'when the server selected supports collations' do
+        min_server_fcv '3.4'
 
         it 'applies the collation to the distinct' do
           expect(result).to eq(['bang'])
         end
       end
 
-      context 'when the server selected does not support collations', unless: collation_enabled? do
+      context 'when the server selected does not support collations' do
+        max_server_version '3.2'
 
         it 'raises an exception' do
           expect {
@@ -936,14 +952,16 @@ describe Mongo::Collection::View::Readable do
         { collation: { locale: 'en_US', strength: 2 } }
       end
 
-      context 'when the server selected supports collations', if: collation_enabled? do
+      context 'when the server selected supports collations' do
+        min_server_fcv '3.4'
 
         it 'applies the collation to the distinct' do
           expect(result).to eq(['bang'])
         end
       end
 
-      context 'when the server selected does not support collations', unless: collation_enabled? do
+      context 'when the server selected does not support collations' do
+        max_server_version '3.2'
 
         it 'raises an exception' do
           expect {