mongo 2.23.0 → 2.24.0

data/lib/mongo/uri/srv_protocol.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2017-2020 MongoDB Inc.
 #
@@ -16,9 +15,7 @@
 # limitations under the License.
 
 module Mongo
-
   class URI
-
     # Parser for a URI using the mongodb+srv protocol, which specifies a DNS to query for SRV records.
     # The driver will query the DNS server for SRV records on <hostname>.<domainname>,
     # prefixed with _mongodb._tcp
@@ -35,7 +32,6 @@ module Mongo
     #
     # @since 2.5.0
     class SRVProtocol < URI
-
       attr_reader :srv_records
 
       # Gets the options hash that needs to be passed to a Mongo::Client on instantiation, so we
@@ -50,7 +46,7 @@ module Mongo
       # @since 2.5.0
       def client_options
         opts = @txt_options.merge(ssl: true)
-        opts = opts.merge(uri_options).merge(:database => database)
+        opts = opts.merge(uri_options).merge(database: database)
         @user ? opts.merge(credentials) : opts
       end
 
@@ -77,33 +73,33 @@ module Mongo
       #   hostname.
       #
       # @deprecated
-      DOT_PARTITION = '.'.freeze
+      DOT_PARTITION = '.'
 
       # @return [ Array<String> ] VALID_TXT_OPTIONS The valid options for a TXT record to specify.
-      VALID_TXT_OPTIONS = %w(replicaset authsource loadbalanced).freeze
+      VALID_TXT_OPTIONS = %w[replicaset authsource loadbalanced].freeze
 
       # @return [ String ] INVALID_HOST Error message format string indicating that the hostname in
       #   in the URI does not fit the expected form.
-      INVALID_HOST = "One and only one host is required in a connection string with the " +
-                       "'#{MONGODB_SRV_SCHEME}' protocol.".freeze
+      INVALID_HOST = 'One and only one host is required in a connection string with the ' +
+                     "'#{MONGODB_SRV_SCHEME}' protocol."
 
       # @return [ String ] INVALID_PORT Error message format string indicating that a port was
       #   included with an SRV hostname.
-      INVALID_PORT = "It is not allowed to specify a port in a connection string with the " +
-                       "'#{MONGODB_SRV_SCHEME}' protocol.".freeze
+      INVALID_PORT = 'It is not allowed to specify a port in a connection string with the ' +
+                     "'#{MONGODB_SRV_SCHEME}' protocol."
 
       # @return [ String ] INVALID_DOMAIN Error message format string indicating that the domain name
       #   of the hostname does not fit the expected form.
       # @deprecated
-      INVALID_DOMAIN = "The domain name must consist of at least two parts: the domain name, " +
-                         "and a TLD.".freeze
+      INVALID_DOMAIN = 'The domain name must consist of at least two parts: the domain name, ' +
+                       'and a TLD.'
 
       # @return [ String ] NO_SRV_RECORDS Error message format string indicating that no SRV records
       #   were found.
-      NO_SRV_RECORDS = "The DNS query returned no SRV records for '%s'".freeze
+      NO_SRV_RECORDS = "The DNS query returned no SRV records for '%s'"
 
       # @return [ String ] FORMAT The expected SRV URI format.
-      FORMAT = 'mongodb+srv://[username:password@]host[/[database][?options]]'.freeze
+      FORMAT = 'mongodb+srv://[username:password@]host[/[database][?options]]'
 
       # Gets the MongoDB SRV URI scheme.
       #
@@ -130,7 +126,7 @@ module Mongo
         @resolver ||= Srv::Resolver.new(
           raise_on_invalid: false,
           resolv_options: options[:resolv_options],
-          timeout: options[:connect_timeout],
+          timeout: options[:connect_timeout]
         )
       end
 
@@ -142,9 +138,7 @@ module Mongo
       def parse!(remaining)
         super
 
-        if @servers.length != 1
-          raise_invalid_error!(INVALID_HOST)
-        end
+        raise_invalid_error!(INVALID_HOST) if @servers.length != 1
         hostname = @servers.first
         validate_srv_hostname(hostname)
         @query_hostname = hostname
@@ -156,9 +150,8 @@ module Mongo
           uri_options[:srv_service_name] || options[:srv_service_name],
           uri_options[:srv_max_hosts] || options[:srv_max_hosts]
         )
-        if srv_result.empty?
-          raise Error::NoSRVRecords.new(NO_SRV_RECORDS % hostname)
-        end
+        raise Error::NoSRVRecords.new(NO_SRV_RECORDS % hostname) if srv_result.empty?
+
         @txt_options = get_txt_options(hostname) || {}
         records = srv_result.address_strs
         records.each do |record|
@@ -180,26 +173,20 @@ module Mongo
       def validate_srv_hostname(hostname)
         raise_invalid_error!(INVALID_PORT) if hostname.include?(HOST_PORT_DELIM)
 
-        if hostname.start_with?('.')
-          raise_invalid_error!("Hostname cannot start with a dot: #{hostname}")
-        end
-        if hostname.end_with?('.')
-          raise_invalid_error!("Hostname cannot end with a dot: #{hostname}")
-        end
+        raise_invalid_error!("Hostname cannot start with a dot: #{hostname}") if hostname.start_with?('.')
+        raise_invalid_error!("Hostname cannot end with a dot: #{hostname}") if hostname.end_with?('.')
         parts = hostname.split('.')
-        if parts.any?(&:empty?)
-          raise_invalid_error!("Hostname cannot have consecutive dots: #{hostname}")
-        end
-        if parts.length < 1
-          raise_invalid_error!("Hostname cannot be empty: #{hostname}")
-        end
+        raise_invalid_error!("Hostname cannot have consecutive dots: #{hostname}") if parts.any?(&:empty?)
+        return unless parts.length < 1
+
+        raise_invalid_error!("Hostname cannot be empty: #{hostname}")
       end
 
       # Obtains the TXT options of a host.
       #
       # @param [ String ] hostname The hostname whose records should be obtained.
       #
-      # @return [ Hash ] The TXT record options (an empyt hash if no TXT
+      # @return [ Hash ] The TXT record options (an empty hash if no TXT
       #   records are found).
       #
       # @raise [ Mongo::Error::InvalidTXTRecord ] If more than one TXT record is found.
@@ -222,21 +209,21 @@ module Mongo
       # @raise [ Mongo::Error::InvalidTXTRecord ] If the TXT record does not fit the expected form
       #   or the option specified is not a valid TXT option.
       def parse_txt_options!(string)
-        string.split(INDIV_URI_OPTS_DELIM).reduce({}) do |txt_options, opt|
+        string.split(INDIV_URI_OPTS_DELIM).each_with_object({}) do |opt, txt_options|
           raise Error::InvalidTXTRecord.new(INVALID_OPTS_VALUE_DELIM) unless opt.index(URI_OPTS_VALUE_DELIM)
+
           key, value = opt.split('=')
           unless VALID_TXT_OPTIONS.include?(key.downcase)
             msg = "TXT records can only specify the options [#{VALID_TXT_OPTIONS.join(', ')}]: #{string}"
             raise Error::InvalidTXTRecord.new(msg)
           end
           options_mapper.add_uri_option(key, value, txt_options)
-          txt_options
         end
       end
 
       def validate_uri_options!
         if uri_options[:direct_connection]
-          raise_invalid_error_no_fmt!("directConnection=true is incompatible with SRV URIs")
+          raise_invalid_error_no_fmt!('directConnection=true is incompatible with SRV URIs')
         end
 
         super

data/lib/mongo/uri.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2014-2020 MongoDB Inc.
 #
@@ -16,7 +15,6 @@
 # limitations under the License.
 
 module Mongo
-
   # The URI class provides a way for users to parse the MongoDB uri as
   # defined in the connection string format spec.
   #
@@ -53,44 +51,44 @@ module Mongo
     # @deprecated Will be removed in 3.0.
     #
     # @since 2.0.0
-    SCHEME = 'mongodb://'.freeze
+    SCHEME = 'mongodb://'
 
     # The mongodb connection string scheme root.
     #
     # @since 2.5.0
-    MONGODB_SCHEME = 'mongodb'.freeze
+    MONGODB_SCHEME = 'mongodb'
 
     # The mongodb srv protocol connection string scheme root.
     #
     # @since 2.5.0
-    MONGODB_SRV_SCHEME = 'mongodb+srv'.freeze
+    MONGODB_SRV_SCHEME = 'mongodb+srv'
 
     # Error details for an invalid scheme.
     #
     # @since 2.1.0
     # @deprecated
-    INVALID_SCHEME = "Invalid scheme. Scheme must be '#{MONGODB_SCHEME}' or '#{MONGODB_SRV_SCHEME}'".freeze
+    INVALID_SCHEME = "Invalid scheme. Scheme must be '#{MONGODB_SCHEME}' or '#{MONGODB_SRV_SCHEME}'"
 
     # MongoDB URI format specification.
     #
     # @since 2.0.0
     FORMAT = 'mongodb://[username:password@]host1[:port1][,host2[:port2]' +
-        ',...[,hostN[:portN]]][/[database][?options]]'.freeze
+             ',...[,hostN[:portN]]][/[database][?options]]'
 
     # MongoDB URI (connection string) documentation url
     #
     # @since 2.0.0
-    HELP = 'https://www.mongodb.com/docs/manual/reference/connection-string/'.freeze
+    HELP = 'https://www.mongodb.com/docs/manual/reference/connection-string/'
 
     # Unsafe characters that must be urlencoded.
     #
     # @since 2.1.0
-    UNSAFE = /[\:\/\@]/
+    UNSAFE = %r{[:/@]}
 
     # Percent sign that must be encoded in user creds.
     #
     # @since 2.5.1
-    PERCENT_CHAR = /\%/
+    PERCENT_CHAR = /%/
 
     # Unix socket suffix.
     #
@@ -100,110 +98,113 @@ module Mongo
     # The character delimiting hosts.
     #
     # @since 2.1.0
-    HOST_DELIM = ','.freeze
+    HOST_DELIM = ','
 
     # The character separating a host and port.
     #
     # @since 2.1.0
-    HOST_PORT_DELIM = ':'.freeze
+    HOST_PORT_DELIM = ':'
 
     # The character delimiting a database.
     #
     # @since 2.1.0
-    DATABASE_DELIM = '/'.freeze
+    DATABASE_DELIM = '/'
 
     # The character delimiting options.
     #
     # @since 2.1.0
-    URI_OPTS_DELIM = '?'.freeze
+    URI_OPTS_DELIM = '?'
 
     # The character delimiting multiple options.
     #
     # @since 2.1.0
     # @deprecated
-    INDIV_URI_OPTS_DELIM = '&'.freeze
+    INDIV_URI_OPTS_DELIM = '&'
 
     # The character delimiting an option and its value.
     #
     # @since 2.1.0
-    URI_OPTS_VALUE_DELIM = '='.freeze
+    URI_OPTS_VALUE_DELIM = '='
 
     # The character separating a username from the password.
     #
     # @since 2.1.0
-    AUTH_USER_PWD_DELIM = ':'.freeze
+    AUTH_USER_PWD_DELIM = ':'
 
     # The character delimiting auth credentials.
     #
     # @since 2.1.0
-    AUTH_DELIM = '@'.freeze
+    AUTH_DELIM = '@'
 
     # Scheme delimiter.
     #
     # @since 2.5.0
-    SCHEME_DELIM = '://'.freeze
+    SCHEME_DELIM = '://'
 
     # Error details for an invalid options format.
     #
     # @since 2.1.0
-    INVALID_OPTS_VALUE_DELIM = "Options and their values must be delimited" +
-      " by '#{URI_OPTS_VALUE_DELIM}'".freeze
+    INVALID_OPTS_VALUE_DELIM = 'Options and their values must be delimited' +
+                               " by '#{URI_OPTS_VALUE_DELIM}'"
 
     # Error details for an non-urlencoded user name or password.
     #
     # @since 2.1.0
-    UNESCAPED_USER_PWD = "User name and password must be urlencoded.".freeze
+    UNESCAPED_USER_PWD = 'User name and password must be urlencoded.'
 
     # Error details for a non-urlencoded unix socket path.
     #
     # @since 2.1.0
-    UNESCAPED_UNIX_SOCKET = "UNIX domain sockets must be urlencoded.".freeze
+    UNESCAPED_UNIX_SOCKET = 'UNIX domain sockets must be urlencoded.'
 
     # Error details for a non-urlencoded auth database name.
     #
     # @since 2.1.0
-    UNESCAPED_DATABASE = "Auth database must be urlencoded.".freeze
+    UNESCAPED_DATABASE = 'Auth database must be urlencoded.'
 
     # Error details for providing options without a database delimiter.
     #
     # @since 2.1.0
-    INVALID_OPTS_DELIM = "Database delimiter '#{DATABASE_DELIM}' must be present if options are specified.".freeze
+    INVALID_OPTS_DELIM = "Database delimiter '#{DATABASE_DELIM}' must be present if options are specified."
 
     # Error details for a missing host.
     #
     # @since 2.1.0
-    INVALID_HOST = "Missing host; at least one must be provided.".freeze
+    INVALID_HOST = 'Missing host; at least one must be provided.'
 
     # Error details for an invalid port.
     #
     # @since 2.1.0
-    INVALID_PORT = "Invalid port. Port must be an integer greater than 0 and less than 65536".freeze
+    INVALID_PORT = 'Invalid port. Port must be an integer greater than 0 and less than 65536'
 
     # Map of URI read preference modes to Ruby driver read preference modes
     #
     # @since 2.0.0
     READ_MODE_MAP = {
-      'primary'            => :primary,
-      'primarypreferred'   => :primary_preferred,
-      'secondary'          => :secondary,
+      'primary' => :primary,
+      'primarypreferred' => :primary_preferred,
+      'secondary' => :secondary,
       'secondarypreferred' => :secondary_preferred,
-      'nearest'            => :nearest
+      'nearest' => :nearest
     }.freeze
 
     # Map of URI authentication mechanisms to Ruby driver mechanisms
     #
     # @since 2.0.0
     AUTH_MECH_MAP = {
-      'GSSAPI'       => :gssapi,
-      'MONGODB-AWS'  => :aws,
+      'GSSAPI' => :gssapi,
+      'MONGODB-AWS' => :aws,
       # MONGODB-CR is deprecated and will be removed in driver version 3.0
-      'MONGODB-CR'   => :mongodb_cr,
+      'MONGODB-CR' => :mongodb_cr,
       'MONGODB-X509' => :mongodb_x509,
-      'PLAIN'        => :plain,
-      'SCRAM-SHA-1'  => :scram,
+      'PLAIN' => :plain,
+      'SCRAM-SHA-1' => :scram,
       'SCRAM-SHA-256' => :scram256,
     }.freeze
 
+    # Valid values for the serverMonitoringMode URI option.
+    SERVER_MONITORING_MODES = %w[stream poll auto].freeze
+
     # Options that are allowed to appear more than once in the uri.
     #
     # In order to follow the URI options spec requirement that all instances
@@ -212,7 +213,7 @@ module Mongo
     # they will be condensed to a single value immediately after parsing the URI.
     #
     # @since 2.1.0
-    REPEATABLE_OPTIONS = [ :tag_sets, :ssl ]
+    REPEATABLE_OPTIONS = %i[tag_sets ssl]
 
     # Get either a URI object or a SRVProtocol URI object.
     #
@@ -228,21 +229,18 @@ module Mongo
     #
     # @since 2.5.0
     def self.get(string, opts = {})
-      unless string
-        raise Error::InvalidURI.new(string, 'URI must be a string, not nil.')
-      end
-      if string.empty?
-        raise Error::InvalidURI.new(string, 'Cannot parse an empty URI.')
-      end
+      raise Error::InvalidURI.new(string, 'URI must be a string, not nil.') unless string
+      raise Error::InvalidURI.new(string, 'Cannot parse an empty URI.') if string.empty?
 
-      scheme, _, _ = string.partition(SCHEME_DELIM)
+      scheme, = string.partition(SCHEME_DELIM)
       case scheme
-        when MONGODB_SCHEME
-          URI.new(string, opts)
-        when MONGODB_SRV_SCHEME
-          SRVProtocol.new(string, opts)
-        else
-          raise Error::InvalidURI.new(string, "Invalid scheme '#{scheme}'. Scheme must be '#{MONGODB_SCHEME}' or '#{MONGODB_SRV_SCHEME}'")
+      when MONGODB_SCHEME
+        URI.new(string, opts)
+      when MONGODB_SRV_SCHEME
+        SRVProtocol.new(string, opts)
+      else
+        raise Error::InvalidURI.new(string,
+                                    "Invalid scheme '#{scheme}'. Scheme must be '#{MONGODB_SCHEME}' or '#{MONGODB_SRV_SCHEME}'")
       end
     end
 
@@ -282,12 +280,8 @@ module Mongo
     #
     # @since 2.0.0
     def initialize(string, options = {})
-      unless string
-        raise Error::InvalidURI.new(string, 'URI must be a string, not nil.')
-      end
-      if string.empty?
-        raise Error::InvalidURI.new(string, 'Cannot parse an empty URI.')
-      end
+      raise Error::InvalidURI.new(string, 'URI must be a string, not nil.') unless string
+      raise Error::InvalidURI.new(string, 'Cannot parse an empty URI.') if string.empty?
 
       @string = string
       @options = options
@@ -295,9 +289,7 @@ module Mongo
       unless parsed_scheme == scheme
         raise_invalid_error!("Invalid scheme '#{parsed_scheme}'. Scheme must be '#{MONGODB_SCHEME}'. Use URI#get to parse SRV URIs.")
       end
-      if remaining.empty?
-        raise_invalid_error!('No hosts in the URI')
-      end
+      raise_invalid_error!('No hosts in the URI') if remaining.empty?
       parse!(remaining)
       validate_uri_options!
     end
@@ -313,7 +305,7 @@ module Mongo
     #
     # @since 2.0.0
     def credentials
-      { :user => @user, :password => @password }
+      { user: @user, password: @password }
     end
 
     # Get the database provided in the URI.
@@ -325,7 +317,7 @@ module Mongo
     #
     # @since 2.0.0
     def database
-      @database ? @database : Database::ADMIN
+      @database || Database::ADMIN
     end
 
     # Get the uri as a string.
@@ -359,9 +351,9 @@ module Mongo
       uri = "#{scheme}#{SCHEME_DELIM}"
       uri += @user.to_s if @user
       uri += "#{AUTH_USER_PWD_DELIM}#{@password}" if @password
-      uri += "@" if @user || @password
+      uri += '@' if @user || @password
       uri += @query_hostname || servers
-      uri += "/" if @database || !options.empty?
+      uri += '/' if @database || !options.empty?
       uri += @database.to_s if @database
       uri += "?#{options}" unless options.empty?
       uri
@@ -374,32 +366,22 @@ module Mongo
     def parse!(remaining)
       hosts_and_db, options = remaining.split('?', 2)
       if options && options.index('?')
-        raise_invalid_error!("Options contain an unescaped question mark (?), or the database name contains a question mark and was not escaped")
+        raise_invalid_error!('Options contain an unescaped question mark (?), or the database name contains a question mark and was not escaped')
       end
 
       hosts, db = hosts_and_db.split('/', 2)
-      if db && db.index('/')
-        raise_invalid_error!("Database name contains an unescaped slash (/): #{db}")
-      end
+      raise_invalid_error!("Database name contains an unescaped slash (/): #{db}") if db && db.index('/')
 
       if hosts.index('@')
         creds, hosts = hosts.split('@', 2)
-        if hosts.empty?
-          raise_invalid_error!("Empty hosts list")
-        end
-        if hosts.index('@')
-          raise_invalid_error!("Unescaped @ in auth info")
-        end
+        raise_invalid_error!('Empty hosts list') if hosts.empty?
+        raise_invalid_error!('Unescaped @ in auth info') if hosts.index('@')
       end
 
-      unless hosts.length > 0
-        raise_invalid_error!("Missing host; at least one must be provided")
-      end
+      raise_invalid_error!('Missing host; at least one must be provided') unless hosts.length > 0
 
       @servers = hosts.split(',').map do |host|
-        if host.empty?
-          raise_invalid_error!('Empty host given in the host list')
-        end
+        raise_invalid_error!('Empty host given in the host list') if host.empty?
         decode(host).tap do |host|
           validate_address_str!(host)
         end
@@ -408,32 +390,26 @@ module Mongo
       @user = parse_user!(creds)
       @password = parse_password!(creds)
       @uri_options = Options::Redacted.new(parse_uri_options!(options))
-      if db
-        @database = parse_database!(db)
-      end
+      @database = parse_database!(db) if db
     rescue Error::InvalidAddress => e
       raise_invalid_error!(e.message)
     end
 
     def options_mapper
       @options_mapper ||= OptionsMapper.new(
-        logger: @options[:logger],
+        logger: @options[:logger]
       )
     end
 
     def parse_uri_options!(string)
       uri_options = {}
-      unless string
-        return uri_options
-      end
+      return uri_options unless string
+
       string.split('&').each do |option_str|
-        if option_str.empty?
-          next
-        end
+        next if option_str.empty?
+
         key, value = option_str.split('=', 2)
-        if value.nil?
-          raise_invalid_error!("Option #{key} has no value")
-        end
+        raise_invalid_error!("Option #{key} has no value") if value.nil?
         key = decode(key)
         value = decode(value)
         options_mapper.add_uri_option(key, value, uri_options)
@@ -442,31 +418,25 @@ module Mongo
     end
 
     def parse_user!(string)
-      if (string && user = string.partition(AUTH_USER_PWD_DELIM)[0])
-        raise_invalid_error!(UNESCAPED_USER_PWD) if user =~ UNSAFE
+      if string && user = string.partition(AUTH_USER_PWD_DELIM)[0]
+        raise_invalid_error!(UNESCAPED_USER_PWD) if UNSAFE.match?(user)
         user_decoded = decode(user)
-        if user_decoded =~ PERCENT_CHAR && encode(user_decoded) != user
-          raise_invalid_error!(UNESCAPED_USER_PWD)
-        end
+        raise_invalid_error!(UNESCAPED_USER_PWD) if user_decoded =~ PERCENT_CHAR && encode(user_decoded) != user
         user_decoded
       end
     end
 
     def parse_password!(string)
-      if (string && pwd = string.partition(AUTH_USER_PWD_DELIM)[2])
-        if pwd.length > 0
-          raise_invalid_error!(UNESCAPED_USER_PWD) if pwd =~ UNSAFE
-          pwd_decoded = decode(pwd)
-          if pwd_decoded =~ PERCENT_CHAR && encode(pwd_decoded) != pwd
-            raise_invalid_error!(UNESCAPED_USER_PWD)
-          end
-          pwd_decoded
-        end
+      if string && (pwd = string.partition(AUTH_USER_PWD_DELIM)[2]) && (pwd.length > 0)
+        raise_invalid_error!(UNESCAPED_USER_PWD) if UNSAFE.match?(pwd)
+        pwd_decoded = decode(pwd)
+        raise_invalid_error!(UNESCAPED_USER_PWD) if pwd_decoded =~ PERCENT_CHAR && encode(pwd_decoded) != pwd
+        pwd_decoded
       end
     end
 
     def parse_database!(string)
-      raise_invalid_error!(UNESCAPED_DATABASE) if string =~ UNSAFE
+      raise_invalid_error!(UNESCAPED_DATABASE) if UNSAFE.match?(string)
       decode(string) if string.length > 0
     end
 
@@ -513,18 +483,14 @@ module Mongo
         end
       end
 
-      unless uri_options[:ssl_verify_certificate].nil?
-        unless uri_options[:ssl_verify_ocsp_endpoint].nil?
-          raise_invalid_error_no_fmt!("tlsAllowInvalidCertificates' and 'tlsDisableOCSPEndpointCheck' cannot both be specified")
-        end
+      if !uri_options[:ssl_verify_certificate].nil? && !uri_options[:ssl_verify_ocsp_endpoint].nil?
+        raise_invalid_error_no_fmt!("tlsAllowInvalidCertificates' and 'tlsDisableOCSPEndpointCheck' cannot both be specified")
       end
 
       # Since we know that the only URI option that sets :ssl_cert is
       # "tlsCertificateKeyFile", any value set for :ssl_cert must also be set
       # for :ssl_key.
-      if uri_options[:ssl_cert]
-        uri_options[:ssl_key] = uri_options[:ssl_cert]
-      end
+      uri_options[:ssl_key] = uri_options[:ssl_cert] if uri_options[:ssl_cert]
 
       if uri_options[:write_concern] && !uri_options[:write_concern].empty?
         begin
@@ -538,50 +504,40 @@ module Mongo
         if uri_options[:connect] && uri_options[:connect].to_s != 'direct'
           raise_invalid_error_no_fmt!("directConnection=true cannot be used with connect=#{uri_options[:connect]}")
         end
-        if servers.length > 1
-          raise_invalid_error_no_fmt!("directConnection=true cannot be used with multiple seeds")
-        end
+        raise_invalid_error_no_fmt!('directConnection=true cannot be used with multiple seeds') if servers.length > 1
       elsif uri_options[:direct_connection] == false && uri_options[:connect].to_s == 'direct'
-        raise_invalid_error_no_fmt!("directConnection=false cannot be used with connect=direct")
+        raise_invalid_error_no_fmt!('directConnection=false cannot be used with connect=direct')
       end
 
       if uri_options[:load_balanced]
-        if servers.length > 1
-          raise_invalid_error_no_fmt!("loadBalanced=true cannot be used with multiple seeds")
-        end
+        raise_invalid_error_no_fmt!('loadBalanced=true cannot be used with multiple seeds') if servers.length > 1
 
         if uri_options[:direct_connection]
-          raise_invalid_error_no_fmt!("directConnection=true cannot be used with loadBalanced=true")
+          raise_invalid_error_no_fmt!('directConnection=true cannot be used with loadBalanced=true')
         end
 
         if uri_options[:connect] && uri_options[:connect].to_sym == :direct
-          raise_invalid_error_no_fmt!("connect=direct cannot be used with loadBalanced=true")
+          raise_invalid_error_no_fmt!('connect=direct cannot be used with loadBalanced=true')
         end
 
         if uri_options[:replica_set]
-          raise_invalid_error_no_fmt!("loadBalanced=true cannot be used with replicaSet option")
+          raise_invalid_error_no_fmt!('loadBalanced=true cannot be used with replicaSet option')
         end
       end
 
-      unless self.is_a?(URI::SRVProtocol)
-        if uri_options[:srv_max_hosts]
-          raise_invalid_error_no_fmt!("srvMaxHosts cannot be used on non-SRV URI")
-        end
+      unless is_a?(URI::SRVProtocol)
+        raise_invalid_error_no_fmt!('srvMaxHosts cannot be used on non-SRV URI') if uri_options[:srv_max_hosts]
 
-        if uri_options[:srv_service_name]
-          raise_invalid_error_no_fmt!("srvServiceName cannot be used on non-SRV URI")
-        end
+        raise_invalid_error_no_fmt!('srvServiceName cannot be used on non-SRV URI') if uri_options[:srv_service_name]
       end
 
-      if uri_options[:srv_max_hosts] && uri_options[:srv_max_hosts] > 0
-        if uri_options[:replica_set]
-          raise_invalid_error_no_fmt!("srvMaxHosts > 0 cannot be used with replicaSet option")
-        end
+      return unless uri_options[:srv_max_hosts] && uri_options[:srv_max_hosts] > 0
 
-        if options[:load_balanced]
-          raise_invalid_error_no_fmt!("srvMaxHosts > 0 cannot be used with loadBalanced=true")
-        end
-      end
+      raise_invalid_error_no_fmt!('srvMaxHosts > 0 cannot be used with replicaSet option') if uri_options[:replica_set]
+
+      return unless options[:load_balanced]
+
+      raise_invalid_error_no_fmt!('srvMaxHosts > 0 cannot be used with loadBalanced=true')
     end
   end
 end