mongo 2.23.0 → 2.24.0

data/lib/mongo/operation/collections_info.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2015-2020 MongoDB Inc.
 #
@@ -19,7 +18,6 @@ require 'mongo/operation/collections_info/result'
 
 module Mongo
   module Operation
-
     # A MongoDB operation to get info on all collections in a given database.
     #
     # @api private

data/lib/mongo/operation/command/op_msg.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2018-2020 MongoDB Inc.
 #
@@ -18,15 +17,13 @@
 module Mongo
   module Operation
     class Command
-
       # A MongoDB command operation sent as an op message.
       #
       # @api private
       #
       # @since 2.5.2
       class OpMsg < OpMsgBase
-
-        def selector(connection)
+        def selector(_connection)
           spec[:selector].dup.tap do |sel|
             sel[:comment] = spec[:comment] unless spec[:comment].nil?
           end

data/lib/mongo/operation/command.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2015-2020 MongoDB Inc.
 #
@@ -19,7 +18,6 @@ require 'mongo/operation/command/op_msg'
 
 module Mongo
   module Operation
-
     # A MongoDB general command operation.
     #
     # @api private

data/lib/mongo/operation/context.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2021 MongoDB Inc.
 #
@@ -17,7 +16,6 @@
 
 module Mongo
   module Operation
-
     # Context for operations.
     #
     # Holds various objects needed to make decisions about operation execution
@@ -44,17 +42,14 @@ module Mongo
         options: nil
       )
         if options
-          if client
-            raise ArgumentError, 'Client and options cannot both be specified'
-          end
+          raise ArgumentError, 'Client and options cannot both be specified' if client
 
-          if session
-            raise ArgumentError, 'Session and options cannot both be specified'
-          end
+          raise ArgumentError, 'Session and options cannot both be specified' if session
         end
 
         if connection_global_id && session&.pinned_connection_global_id
-          raise ArgumentError, 'Trying to pin context to a connection when the session is already pinned to a connection.'
+          raise ArgumentError,
+                'Trying to pin context to a connection when the session is already pinned to a connection.'
         end
 
         @client = client
@@ -65,10 +60,7 @@ module Mongo
         super(session: session, operation_timeouts: operation_timeouts)
       end
 
-      attr_reader :client
-      attr_reader :session
-      attr_reader :view
-      attr_reader :options
+      attr_reader :client, :session, :view, :options
 
       # Returns a new Operation::Context with the deadline refreshed
       # and relative to the current moment.
@@ -131,6 +123,11 @@ module Mongo
         !!@is_retry
       end
 
+      # Whether every retry so far has been due to overload only.
+      def overload_only_retry?
+        !!@overload_only_retry
+      end
+
       # Returns a new context with the parameters changed as per the
       # provided arguments.
       #
@@ -161,11 +158,11 @@ module Mongo
       end
 
       def encrypter
-        if client&.encrypter
-          client.encrypter
-        else
+        unless client&.encrypter
           raise Error::InternalDriverError, 'Encrypter should only be accessed when encryption is to be performed'
         end
+
+        client.encrypter
       end
 
       def inspect

data/lib/mongo/operation/count/op_msg.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2018-2020 MongoDB Inc.
 #
@@ -18,7 +17,6 @@
 module Mongo
   module Operation
     class Count
-
       # A MongoDB count operation sent as an op message.
       #
       # @api private
@@ -29,10 +27,10 @@ module Mongo
 
         private
 
-        def selector(connection)
+        def selector(_connection)
           spec[:selector].merge(
             collation: spec[:collation],
-            comment: spec[:comment],
+            comment: spec[:comment]
           ).compact
         end
       end

data/lib/mongo/operation/count.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2015-2020 MongoDB Inc.
 #
@@ -19,7 +18,6 @@ require 'mongo/operation/count/op_msg'
 
 module Mongo
   module Operation
-
     # A MongoDB count command operation.
     #
     # @api private

data/lib/mongo/operation/create/op_msg.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2018-2020 MongoDB Inc.
 #
@@ -18,7 +17,6 @@
 module Mongo
   module Operation
     class Create
-
       # A MongoDB create collection operation sent as an op message.
       #
       # @api private
@@ -29,11 +27,10 @@ module Mongo
 
         private
 
-        def selector(connection)
-          # Collation is always supported on 3.6+ servers that would use OP_MSG.
+        def selector(_connection)
           spec[:selector].merge(
             collation: spec[:collation],
-            encryptedFields: spec[:encrypted_fields],
+            encryptedFields: spec[:encrypted_fields]
           ).compact
         end
       end

data/lib/mongo/operation/create.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2015-2020 MongoDB Inc.
 #
@@ -19,7 +18,6 @@ require 'mongo/operation/create/op_msg'
 
 module Mongo
   module Operation
-
     # A MongoDB create collection command operation.
     #
     # @api private

data/lib/mongo/operation/create_index/op_msg.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2018-2020 MongoDB Inc.
 #
@@ -18,7 +17,6 @@
 module Mongo
   module Operation
     class CreateIndex
-
       # A MongoDB createindex operation sent as an op message.
       #
       # @api private
@@ -36,15 +34,13 @@ module Mongo
             comment: spec[:comment],
           }.compact.tap do |selector|
             if commit_quorum = spec[:commit_quorum]
-              # While server versions 3.4 and newer generally perform option
-              # validation, there was a bug on server versions 4.2.0 - 4.2.5 where
+              # There was a bug on server versions 4.2.0 - 4.2.5 where
               # the server would accept the commitQuorum option and use it internally
               # (see SERVER-47193). As a result, the drivers specifications require
               # drivers to perform validation and raise an error when the commitQuorum
               # option is passed to servers that don't support it.
-              unless connection.features.commit_quorum_enabled?
-                raise Error::UnsupportedOption.commit_quorum_error
-              end
+              raise Error::UnsupportedOption.commit_quorum_error unless connection.features.commit_quorum_enabled?
+
               selector[:commitQuorum] = commit_quorum
             end
           end

data/lib/mongo/operation/create_index.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2015-2020 MongoDB Inc.
 #
@@ -19,7 +18,6 @@ require 'mongo/operation/create_index/op_msg'
 
 module Mongo
   module Operation
-
     # A MongoDB create index command operation.
     #
     # @api private

data/lib/mongo/operation/create_user/op_msg.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2018-2020 MongoDB Inc.
 #
@@ -18,7 +17,6 @@
 module Mongo
   module Operation
     class CreateUser
-
       # A MongoDB createuser operation sent as an op message.
       #
       # @api private
@@ -29,8 +27,8 @@ module Mongo
 
         private
 
-        def selector(connection)
-          { :createUser => user.name }.merge(user.spec)
+        def selector(_connection)
+          { createUser: user.name }.merge(user.spec)
         end
       end
     end

data/lib/mongo/operation/create_user.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2015-2020 MongoDB Inc.
 #
@@ -19,7 +18,6 @@ require 'mongo/operation/create_user/op_msg'
 
 module Mongo
   module Operation
-
     # A MongoDB create user command operation.
     #
     # @api private

data/lib/mongo/operation/delete/bulk_result.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2014-2020 MongoDB Inc.
 #
@@ -18,7 +17,6 @@
 module Mongo
   module Operation
     class Delete
-
       # Defines custom behavior of results for a delete when part of a bulk write.
       #
       # @since 2.0.0
@@ -37,9 +35,10 @@ module Mongo
         # @api public
         def n_removed
           return 0 unless acknowledged?
+
           @replies.reduce(0) do |n, reply|
             if reply.documents.first[Result::N]
-              n += reply.documents.first[Result::N]
+              n + reply.documents.first[Result::N]
             else
               n
             end

data/lib/mongo/operation/delete/op_msg.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2018-2020 MongoDB Inc.
 #
@@ -18,7 +17,6 @@
 module Mongo
   module Operation
     class Delete
-
       # A MongoDB delete operation sent as an op message.
       #
       # @api private
@@ -29,21 +27,16 @@ module Mongo
         include ExecutableNoValidate
         include ExecutableTransactionLabel
         include PolymorphicResult
-        include Validatable
 
         private
 
-        def selector(connection)
+        def selector(_connection)
           { delete: coll_name,
             Protocol::Msg::DATABASE_IDENTIFIER => db_name,
             ordered: ordered?,
             let: spec[:let],
-            comment: spec[:comment],
-          }.compact.tap do |selector|
-            if hint = spec[:hint]
-              validate_hint_on_update(connection, selector)
-              selector[:hint] = hint
-            end
+            comment: spec[:comment], }.compact.tap do |selector|
+            selector[:hint] = spec[:hint] if spec[:hint]
           end
         end
 

data/lib/mongo/operation/delete/result.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2014-2020 MongoDB Inc.
 #
@@ -18,13 +17,11 @@
 module Mongo
   module Operation
     class Delete
-
       # Defines custom behavior of results for a delete.
       #
       # @since 2.0.0
       # @api semiprivate
       class Result < Operation::Result
-
         # Get the number of documents deleted.
         #
         # @example Get the deleted count.

data/lib/mongo/operation/delete.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2015-2020 MongoDB Inc.
 #
@@ -21,7 +20,6 @@ require 'mongo/operation/delete/bulk_result'
 
 module Mongo
   module Operation
-
     # A MongoDB delete operation.
     #
     # @api private
@@ -31,9 +29,7 @@ module Mongo
       include Specifiable
       include Write
 
-      private
-
-      IDENTIFIER = 'deletes'.freeze
+      IDENTIFIER = 'deletes'
     end
   end
 end

data/lib/mongo/operation/distinct/op_msg.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2018-2020 MongoDB Inc.
 #
@@ -18,7 +17,6 @@
 module Mongo
   module Operation
     class Distinct
-
       # A MongoDB distinct operation sent as an op message.
       #
       # @api private
@@ -30,11 +28,10 @@ module Mongo
 
         private
 
-        def selector(connection)
-          # Collation is always supported on 3.6+ servers that would use OP_MSG.
+        def selector(_connection)
           spec[:selector].merge(
             collation: spec[:collation],
-            comment: spec[:comment],
+            comment: spec[:comment]
           ).compact
         end
       end

data/lib/mongo/operation/distinct.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2017-2020 MongoDB Inc.
 #
@@ -19,7 +18,6 @@ require 'mongo/operation/distinct/op_msg'
 
 module Mongo
   module Operation
-
     # A MongoDB distinct command operation.
     #
     # @api private

data/lib/mongo/operation/drop/op_msg.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2018-2020 MongoDB Inc.
 #
@@ -18,7 +17,6 @@
 module Mongo
   module Operation
     class Drop
-
       # A MongoDB drop collection operation sent as an op message.
       #
       # @api private

data/lib/mongo/operation/drop.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2015-2020 MongoDB Inc.
 #
@@ -19,7 +18,6 @@ require 'mongo/operation/drop/op_msg'
 
 module Mongo
   module Operation
-
     # A MongoDB drop collection operation.
     #
     # @api private

data/lib/mongo/operation/drop_database/op_msg.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2018-2020 MongoDB Inc.
 #
@@ -18,7 +17,6 @@
 module Mongo
   module Operation
     class DropDatabase
-
       # A MongoDB drop database operation sent as an op message.
       #
       # @api private

data/lib/mongo/operation/drop_database.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2015-2020 MongoDB Inc.
 #
@@ -19,7 +18,6 @@ require 'mongo/operation/drop_database/op_msg'
 
 module Mongo
   module Operation
-
     # A MongoDB drop database operation.
     #
     # @api private

data/lib/mongo/operation/drop_index/op_msg.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2018-2020 MongoDB Inc.
 #
@@ -18,7 +17,6 @@
 module Mongo
   module Operation
     class DropIndex
-
       # A MongoDB dropindex operation sent as an op message.
       #
       # @api private
@@ -29,11 +27,11 @@ module Mongo
 
         private
 
-        def selector(connection)
+        def selector(_connection)
           {
-            :dropIndexes => coll_name,
-            :index => index_name,
-            :comment => spec[:comment],
+            dropIndexes: coll_name,
+            index: index_name,
+            comment: spec[:comment],
           }.compact
         end
       end

data/lib/mongo/operation/drop_index.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2015-2020 MongoDB Inc.
 #
@@ -19,7 +18,6 @@ require 'mongo/operation/drop_index/op_msg'
 
 module Mongo
   module Operation
-
     # A MongoDB drop index operation.
     #
     # @api private

data/lib/mongo/operation/explain/op_msg.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2018-2020 MongoDB Inc.
 #
@@ -18,7 +17,6 @@
 module Mongo
   module Operation
     class Explain
-
       # A MongoDB explain operation sent as an op message.
       #
       # @api private

data/lib/mongo/operation/explain/result.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2018-2020 MongoDB Inc.
 #
@@ -18,13 +17,11 @@
 module Mongo
   module Operation
     class Explain
-
       # Defines custom behavior of results in find command with explain.
       #
       # @since 2.5.0
       # @api semiprivate
       class Result < Operation::Result
-
         # Get the cursor id.
         #
         # @example Get the cursor id.

data/lib/mongo/operation/explain.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2015-2020 MongoDB Inc.
 #
@@ -20,7 +19,6 @@ require 'mongo/operation/explain/op_msg'
 
 module Mongo
   module Operation
-
     # A MongoDB explain operation.
     #
     # @api private

data/lib/mongo/operation/find/builder/command.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 # Copyright (C) 2015-2020 MongoDB Inc.
 #
@@ -19,12 +18,10 @@ module Mongo
   module Operation
     class Find
       module Builder
-
         # Builds a find command specification from options.
         #
         # @api private
         module Command
-
           # The mappings from ruby options to the find command.
           OPTION_MAPPINGS = BSON::Document.new(
             allow_disk_use: 'allowDiskUse',
@@ -52,14 +49,10 @@ module Mongo
             snapshot: 'snapshot',
             sort: 'sort',
             tailable: 'tailable',
-            tailable_cursor: 'tailable',
+            tailable_cursor: 'tailable'
           ).freeze
 
-          module_function def selector(spec, connection)
-            if spec[:collation] && !connection.features.collation_enabled?
-              raise Error::UnsupportedCollation
-            end
-
+          module_function def selector(spec, _connection)
             BSON::Document.new.tap do |selector|
               OPTION_MAPPINGS.each do |k, server_k|
                 unless (value = spec[k]).nil?
@@ -86,13 +79,12 @@ module Mongo
           # The +command+ parameter is mutated by this method.
           module_function def convert_limit_and_batch_size!(command)
             if command[:limit] && command[:limit] < 0 &&
-              command[:batchSize] && command[:batchSize] < 0
-            then
+               command[:batchSize] && command[:batchSize] < 0
               command[:limit] = command[:limit].abs
               command[:batchSize] = command[:limit].abs
               command[:singleBatch] = true
             else
-              [:limit, :batchSize].each do |opt|
+              %i[limit batchSize].each do |opt|
                 if command[opt]
                   if command[opt] < 0
                     command[opt] = command[opt].abs