mongo 2.18.3 → 2.19.0

data/spec/mongo/operation/insert_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/operation/limited_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/operation/map_reduce_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/operation/read_preference_legacy_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/operation/read_preference_op_msg_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/operation/remove_user_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/operation/result_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/operation/specifiable_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/operation/update/bulk_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/operation/update/op_msg_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/operation/update_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/operation/update_user_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/options/redacted_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 
@@ -350,4 +350,4 @@ describe Mongo::Options::Redacted do
       end
     end
   end
-end
+end

data/spec/mongo/protocol/caching_hash_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/protocol/compressed_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/protocol/get_more_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 require 'support/shared/protocol'

data/spec/mongo/protocol/kill_cursors_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 require 'support/shared/protocol'

data/spec/mongo/protocol/msg_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 require 'support/shared/protocol'
@@ -390,6 +390,7 @@ describe Mongo::Protocol::Msg do
     end
 
     context 'when the validating_keys option is true with payload 1' do
+      max_bson_version '4.99.99'
 
       let(:sequences) do
         [ section ]

data/spec/mongo/protocol/query_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 require 'support/shared/protocol'

data/spec/mongo/protocol/registry_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 

data/spec/mongo/protocol/reply_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 

data/spec/mongo/query_cache_middleware_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongo/query_cache_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/retryable_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 
@@ -46,7 +46,7 @@ class RetryableTestConsumer
   end
 
   def retry_write_allowed_as_configured?
-    retry_write_allowed?(session, write_concern)
+    write_worker.retry_write_allowed?(session, write_concern)
   end
 end
 
@@ -87,7 +87,9 @@ end
 class RetryableHost
   include Mongo::Retryable
 
-  public :retry_write_allowed?
+  def retry_write_allowed?(*args)
+    write_worker.retry_write_allowed?(*args)
+  end
 end
 
 describe Mongo::Retryable do

data/spec/mongo/semaphore_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 
@@ -16,11 +16,11 @@ describe Mongo::Semaphore do
     # Context switch to start the thread
     sleep 0.1
 
-    start_time = Time.now
+    start_time = Mongo::Utils.monotonic_time
     semaphore.signal
     consumer.join
 
-    (Time.now - start_time).should < 1
+    (Mongo::Utils.monotonic_time - start_time).should < 1
   end
 
   it 'waits until broadcast' do
@@ -31,11 +31,11 @@ describe Mongo::Semaphore do
     # Context switch to start the thread
     sleep 0.1
 
-    start_time = Time.now
+    start_time = Mongo::Utils.monotonic_time
     semaphore.broadcast
     consumer.join
 
-    (Time.now - start_time).should < 1
+    (Mongo::Utils.monotonic_time - start_time).should < 1
   end
 
   it 'times out' do
@@ -46,9 +46,9 @@ describe Mongo::Semaphore do
     # Context switch to start the thread
     sleep 0.1
 
-    start_time = Time.now
+    start_time = Mongo::Utils.monotonic_time
     consumer.join
 
-    (Time.now - start_time).should > 1
+    (Mongo::Utils.monotonic_time - start_time).should > 1
   end
 end

data/spec/mongo/server/app_metadata/environment_spec.rb

@@ -65,6 +65,24 @@ describe Mongo::Server::AppMetadata::Environment do
       end
     end
 
+    context 'when VERCEL and AWS are both given' do
+      local_env(
+        'AWS_EXECUTION_ENV' => 'AWS_Lambda_ruby2.7',
+        'AWS_REGION' => 'us-east-2',
+        'AWS_LAMBDA_FUNCTION_MEMORY_SIZE' => '1024',
+        'VERCEL' => '1',
+        'VERCEL_REGION' => 'cdg1'
+      )
+
+      it_behaves_like 'running in a FaaS environment'
+
+      it 'prefers vercel' do
+        expect(env.aws?).to be false
+        expect(env.vercel?).to be true
+        expect(env.fields[:region]).to be == 'cdg1'
+      end
+    end
+
     context 'when environment is invalid due to missing variable' do
       local_env(
         'AWS_EXECUTION_ENV' => 'AWS_Lambda_ruby2.7',
@@ -161,7 +179,6 @@ describe Mongo::Server::AppMetadata::Environment do
     context 'when FaaS environment is Vercel' do
       local_env(
         'VERCEL' => '1',
-        'VERCEL_URL' => '*.vercel.app',
         'VERCEL_REGION' => 'cdg1'
       )
 
@@ -169,7 +186,6 @@ describe Mongo::Server::AppMetadata::Environment do
 
       it 'recognizes Vercel' do
         expect(env.name).to be == 'vercel'
-        expect(env.fields[:url]).to be == '*.vercel.app'
         expect(env.fields[:region]).to be == 'cdg1'
       end
     end

data/spec/mongo/server/app_metadata_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 
@@ -15,9 +14,7 @@ describe Mongo::Server::AppMetadata do
   end
 
   describe '#initialize' do
-
     context 'when the cluster has an app name option set' do
-
       let(:client) do
         authorized_client.with(app_name: :app_metadata_test)
       end
@@ -31,9 +28,8 @@ describe Mongo::Server::AppMetadata do
       end
 
       context 'when the app name exceeds the max length of 128' do
-
         let(:client) do
-          authorized_client.with(app_name: "\u3042"*43)
+          authorized_client.with(app_name: "\u3042" * 43)
         end
 
         let(:cluster) do
@@ -41,17 +37,15 @@ describe Mongo::Server::AppMetadata do
         end
 
         it 'raises an error' do
-          expect {
-            app_metadata.send(:validate!)
-          }.to raise_exception(Mongo::Error::InvalidApplicationName)
+          expect { app_metadata.validated_document }
+            .to raise_exception(Mongo::Error::InvalidApplicationName)
         end
       end
     end
 
     context 'when the cluster does not have an app name option set' do
-
       it 'does not set the app name' do
-        expect(app_metadata.client_document[:application]).to be(nil)
+        expect(app_metadata.client_document[:application]).to be_nil
       end
     end
 
@@ -69,7 +63,7 @@ describe Mongo::Server::AppMetadata do
 
       context 'when the os.name length is too long' do
         before do
-          allow(app_metadata).to receive(:name).and_return('x'*500)
+          allow(app_metadata).to receive(:name).and_return('x' * 500)
         end
 
         it_behaves_like 'a truncated document'
@@ -77,7 +71,7 @@ describe Mongo::Server::AppMetadata do
 
       context 'when the os.architecture length is too long' do
         before do
-          allow(app_metadata).to receive(:architecture).and_return('x'*500)
+          allow(app_metadata).to receive(:architecture).and_return('x' * 500)
         end
 
         it_behaves_like 'a truncated document'
@@ -85,7 +79,7 @@ describe Mongo::Server::AppMetadata do
 
       context 'when the platform length is too long' do
         before do
-          allow(app_metadata).to receive(:platform).and_return('x'*500)
+          allow(app_metadata).to receive(:platform).and_return('x' * 500)
         end
 
         it_behaves_like 'a truncated document'
@@ -93,7 +87,7 @@ describe Mongo::Server::AppMetadata do
     end
 
     context 'when run outside of a FaaS environment' do
-      it 'should exclude the :env key from the client document' do
+      it 'excludes the :env key from the client document' do
         expect(app_metadata.client_document.key?(:env)).to be false
       end
     end
@@ -103,7 +97,7 @@ describe Mongo::Server::AppMetadata do
         # invalid, because it is missing the other required fields
         local_env('AWS_EXECUTION_ENV' => 'AWS_Lambda_ruby2.7')
 
-        it 'should exclude the :env key from the client document' do
+        it 'excludes the :env key from the client document' do
           expect(app_metadata.client_document.key?(:env)).to be false
         end
       end
@@ -112,9 +106,9 @@ describe Mongo::Server::AppMetadata do
         # valid, because Azure requires only the one field
         local_env('FUNCTIONS_WORKER_RUNTIME' => 'ruby')
 
-        it 'should include the :env key in the client document' do
+        it 'includes the :env key in the client document' do
           expect(app_metadata.client_document.key?(:env)).to be true
-          expect(app_metadata.client_document[:env][:name]).to be == "azure.func"
+          expect(app_metadata.client_document[:env][:name]).to be == 'azure.func'
         end
       end
     end
@@ -140,17 +134,15 @@ describe Mongo::Server::AppMetadata do
 
   describe '#validated_document' do
     it 'raises with too long app name' do
-      app_name = 'app'*500
-      expect {
-        described_class.new(app_name: app_name).validated_document
-      }.to raise_error(Mongo::Error::InvalidApplicationName)
+      app_name = 'app' * 500
+      expect { described_class.new(app_name: app_name).validated_document }
+        .to raise_error(Mongo::Error::InvalidApplicationName)
     end
 
     it 'does not raise with correct app name' do
       app_name = 'app'
-      expect {
-        described_class.new(app_name: app_name).validated_document
-      }.not_to raise_error
+      expect { described_class.new(app_name: app_name).validated_document }
+        .not_to raise_error
     end
   end
 end

data/spec/mongo/server/connection_auth_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongo/server/connection_common_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 

data/spec/mongo/server/connection_pool/populator_spec.rb

@@ -1,9 +1,11 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 
-describe Mongo::Server::Populator do
+describe Mongo::Server::ConnectionPool::Populator do
+  require_no_linting
+
   let(:options) { {} }
 
   let(:client) do
@@ -27,8 +29,8 @@ describe Mongo::Server::Populator do
   before do
     # We create our own populator to test; disable pool's background populator
     # and clear the pool, so ours can run
+    pool.disconnect!
     pool.stop_populator
-    pool.clear
   end
 
   describe '#log_warn' do
@@ -63,6 +65,7 @@ describe Mongo::Server::Populator do
       end
 
       it 'populates the pool up to min_size' do
+        pool.instance_variable_set(:@ready, true)
         populator.run!
         ::Utils.wait_for_condition(3) do
           pool.size >= 2
@@ -89,6 +92,17 @@ describe Mongo::Server::Populator do
         expect(populator.running?).to be true
       end
     end
+
+    context "when clearing the pool" do
+      it "the populator is run one extra time" do
+        expect(pool).to receive(:populate).twice
+        populator.run!
+        sleep 0.5
+        pool.disconnect!
+        sleep 0.5
+        expect(populator.running?).to be true
+      end
+    end
   end
 
   describe '#stop' do