mongo 2.18.3 → 2.19.0

data/spec/mongo/condition_variable_spec.rb

@@ -0,0 +1,104 @@
+# frozen_string_literal: true
+# rubocop:todo all
+
+require 'lite_spec_helper'
+
+describe Mongo::ConditionVariable do
+  let(:lock) { Mutex.new }
+  let(:condition_variable) do
+    described_class.new(lock)
+  end
+
+  it 'waits until signaled' do
+    result = nil
+
+    consumer = Thread.new do
+      lock.synchronize do
+        result = condition_variable.wait(3)
+      end
+    end
+
+    # Context switch to start the thread
+    sleep 0.1
+
+    start_time = Mongo::Utils.monotonic_time
+    lock.synchronize do
+      condition_variable.signal
+    end
+    consumer.join
+
+    (Mongo::Utils.monotonic_time - start_time).should < 1
+  end
+
+  it 'waits until broadcast' do
+    result = nil
+
+    consumer = Thread.new do
+      lock.synchronize do
+        result = condition_variable.wait(3)
+      end
+    end
+
+    # Context switch to start the thread
+    sleep 0.1
+
+    start_time = Mongo::Utils.monotonic_time
+    lock.synchronize do
+      condition_variable.broadcast
+    end
+    consumer.join
+
+    (Mongo::Utils.monotonic_time - start_time).should < 1
+  end
+
+  it 'times out' do
+    result = nil
+
+    consumer = Thread.new do
+      lock.synchronize do
+        result = condition_variable.wait(2)
+      end
+    end
+
+    # Context switch to start the thread
+    sleep 0.1
+
+    start_time = Mongo::Utils.monotonic_time
+    consumer.join
+
+    (Mongo::Utils.monotonic_time - start_time).should > 1
+  end
+
+  context "when acquiring the lock and waiting" do
+
+    it "releases the lock while waiting" do
+
+      lock_acquired = false
+      Timeout::timeout(1) do
+        thread = Thread.new do
+          until lock_acquired
+            sleep 0.1
+          end
+          lock.synchronize do
+            condition_variable.signal
+          end
+        end
+        lock.synchronize do
+          lock_acquired = true
+          condition_variable.wait(10)
+        end
+      end
+    end
+  end
+
+  context "when waiting but not signaling" do
+    it "waits until timeout" do
+      lock.synchronize do
+        start = Mongo::Utils.monotonic_time
+        condition_variable.wait(1)
+        duration = Mongo::Utils.monotonic_time - start
+        expect(duration).to be > 1
+      end
+    end
+  end
+end

data/spec/mongo/config/options_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongo/config_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -70,4 +71,4 @@ describe Mongo::Config do
       end
     end
   end
-end
+end

data/spec/mongo/crypt/auto_decryption_context_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'mongo'
 require 'lite_spec_helper'

data/spec/mongo/crypt/auto_encrypter_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 require 'tempfile'
@@ -157,6 +157,13 @@ describe Mongo::Crypt::AutoEncrypter do
         expect(auto_encrypter.metadata_client).not_to eq(client)
       end
     end
+
+    context 'when crypt shared library is available' do
+      it 'does not create a mongocryptd client' do
+        allow_any_instance_of(Mongo::Crypt::Handle).to receive(:"crypt_shared_lib_available?").and_return true
+        expect(auto_encrypter.mongocryptd_client).to be_nil
+      end
+    end
   end
 
   shared_examples 'with schema map in auto encryption commands' do

data/spec/mongo/crypt/auto_encryption_context_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'mongo'
 require 'lite_spec_helper'

data/spec/mongo/crypt/binary_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 

data/spec/mongo/crypt/binding/binary_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 

data/spec/mongo/crypt/binding/context_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 require_relative '../helpers/mongo_crypt_spec_helper'

data/spec/mongo/crypt/binding/helpers_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 

data/spec/mongo/crypt/binding/mongocrypt_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 require_relative '../helpers/mongo_crypt_spec_helper'

data/spec/mongo/crypt/binding/status_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 

data/spec/mongo/crypt/binding/version_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 
@@ -43,10 +43,24 @@ describe 'Mongo::Crypt::Binding' do
     end
 
     context 'when in a non-parsable format' do
-      it 'does not raise ArgumentError' do
-        expect do
-          Mongo::Crypt::Binding.validate_version("1.5.3-dev+20220730git8f8675fa11")
-        end.not_to raise_error(ArgumentError, /Malformed version number string/)
+      let(:base_version) { Mongo::Crypt::Binding::MIN_LIBMONGOCRYPT_VERSION.to_s }
+
+      shared_examples_for 'non-standard version format' do
+        it 'does not raise an exception' do
+          expect do
+            Mongo::Crypt::Binding.validate_version(version)
+          end.not_to raise_error
+        end
+      end
+
+      context 'when the version is MAJOR.MINOR.PATH-dev+datecommit' do
+        let(:version) { "#{base_version}-dev+20220730git8f8675fa11" }
+        include_examples 'non-standard version format'
+      end
+
+      context 'when the version is MAJOR.MINOR.PATH-date+commit' do
+        let(:version) { "#{base_version}-20230601+git9b07846bef" }
+        include_examples 'non-standard version format'
       end
     end
   end

data/spec/mongo/crypt/binding_unloaded_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 

data/spec/mongo/crypt/data_key_context_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'mongo'
 require 'base64'

data/spec/mongo/crypt/encryption_io_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'mongo'
 require 'spec_helper'

data/spec/mongo/crypt/explicit_decryption_context_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'mongo'
 require 'lite_spec_helper'

data/spec/mongo/crypt/explicit_encryption_context_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'mongo'
 require 'lite_spec_helper'
@@ -139,7 +139,7 @@ describe Mongo::Crypt::ExplicitEncryptionContext do
               value,
               options.merge(query_type: "equality")
             )
-          end.to raise_error(ArgumentError, /query_type is allowed only for "Indexed" algorithm/)
+          end.to raise_error(ArgumentError, /query_type is allowed only for "Indexed" or "RangePreview" algorithm/)
         end
       end
 
@@ -154,7 +154,7 @@ describe Mongo::Crypt::ExplicitEncryptionContext do
               value,
               options.merge(contention_factor: 10)
             )
-          end.to raise_error(ArgumentError, /contention_factor is allowed only for "Indexed" algorithm/)
+          end.to raise_error(ArgumentError, /contention_factor is allowed only for "Indexed" or "RangePreview" algorithm/)
         end
       end
 

data/spec/mongo/crypt/handle_spec.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'mongo'
 require 'base64'
-require 'lite_spec_helper'
+require 'spec_helper'
 
 describe Mongo::Crypt::Handle do
   require_libmongocrypt
@@ -156,7 +156,7 @@ describe Mongo::Crypt::Handle do
         end
 
         it 'does not load the crypt shared lib' do
-          expect_any_instance_of(Binding).not_to receive(:setopt_append_crypt_shared_lib_search_path)
+          expect(Mongo::Crypt::Binding).not_to receive(:setopt_append_crypt_shared_lib_search_path)
 
           expect(handle.crypt_shared_lib_version).to eq(0)
         end
@@ -170,7 +170,7 @@ describe Mongo::Crypt::Handle do
         end
 
         it 'does not load the crypt shared lib' do
-          expect_any_instance_of(Binding).not_to receive(:setopt_append_crypt_shared_lib_search_path)
+          expect(Mongo::Crypt::Binding).not_to receive(:setopt_append_crypt_shared_lib_search_path)
 
           expect(handle.crypt_shared_lib_version).to eq(0)
         end
@@ -204,6 +204,21 @@ describe Mongo::Crypt::Handle do
         include_context 'with AWS kms_providers'
         it_behaves_like 'a functioning Mongo::Crypt::Handle'
       end
+
+      context 'with empty AWS kms_providers' do
+        let(:kms_providers) do
+          {
+            aws: {}
+          }
+        end
+
+        it 'instructs libmongocrypt to handle empty AWS credentials' do
+          expect(Mongo::Crypt::Binding).to receive(
+            :setopt_use_need_kms_credentials_state
+          ).once.and_call_original
+          handle
+        end
+      end
     end
 
     context 'Azure' do

data/spec/mongo/crypt/helpers/mongo_crypt_spec_helper.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 module MongoCryptSpecHelper
   def bind_crypto_hooks(mongocrypt)

data/spec/mongo/crypt/hooks_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'mongo'
 require 'base64'
@@ -27,4 +27,4 @@ describe Mongo::Crypt::Hooks do
       ).to eq(signature)
     end
   end
-end
+end

data/spec/mongo/crypt/kms/azure/credentials_retriever_spec.rb

@@ -0,0 +1,86 @@
+# frozen_string_literal: true
+
+require 'lite_spec_helper'
+
+describe Mongo::Crypt::KMS::Azure::CredentialsRetriever do
+  # The tests here require fake azure server, which is started in FLE
+  # configurations on evergreen. If you want to run these tests locally,
+  # you need to start the server manually. See .evergreen/run-tests.sh
+  # for the command to start the server.
+  before do
+    skip 'These tests require fake azure server to be running' unless SpecConfig.instance.fle?
+  end
+
+  let(:metadata_host) do
+    'localhost:8080'
+  end
+
+  describe '.fetch_access_token' do
+    context 'when response is valid' do
+      let(:token) do
+        described_class.fetch_access_token(metadata_host: metadata_host)
+      end
+
+      it 'returns access token' do
+        expect(token.access_token).to eq('magic-cookie')
+      end
+
+      it 'returns expiration time' do
+        expect(token.expires_in).to eq(70)
+      end
+    end
+
+    context 'when response contains empty json' do
+      it 'raises error' do
+        expect do
+          described_class.fetch_access_token(
+            extra_headers: { 'X-MongoDB-HTTP-TestParams' => 'case=empty-json' }, metadata_host: metadata_host
+          )
+        end.to raise_error(Mongo::Crypt::KMS::CredentialsNotFound)
+      end
+    end
+
+    context 'when response contains invalid json' do
+      it 'raises error' do
+        expect do
+          described_class.fetch_access_token(
+            extra_headers: { 'X-MongoDB-HTTP-TestParams' => 'case=bad-json' }, metadata_host: metadata_host
+          )
+        end.to raise_error(Mongo::Crypt::KMS::CredentialsNotFound)
+      end
+    end
+
+    context 'when metadata host responds with 500' do
+      it 'raises error' do
+        expect do
+          described_class.fetch_access_token(
+            extra_headers: { 'X-MongoDB-HTTP-TestParams' => 'case=500' }, metadata_host: metadata_host
+          )
+        end.to raise_error(Mongo::Crypt::KMS::CredentialsNotFound)
+      end
+    end
+
+    context 'when metadata host responds with 404' do
+      it 'raises error' do
+        expect do
+          described_class.fetch_access_token(
+            extra_headers: { 'X-MongoDB-HTTP-TestParams' => 'case=404' }, metadata_host: metadata_host
+          )
+        end.to raise_error(Mongo::Crypt::KMS::CredentialsNotFound)
+      end
+    end
+
+    context 'when metadata host is slow' do
+      # On JRuby Timeout.timeout does not work in this case.
+      fails_on_jruby
+
+      it 'raises error' do
+        expect do
+          described_class.fetch_access_token(
+            extra_headers: { 'X-MongoDB-HTTP-TestParams' => 'case=slow' }, metadata_host: metadata_host
+          )
+        end.to raise_error(Mongo::Crypt::KMS::CredentialsNotFound)
+      end
+    end
+  end
+end

data/spec/mongo/crypt/kms/credentials_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'mongo'
 require 'lite_spec_helper'
@@ -289,6 +289,22 @@ describe Mongo::Crypt::KMS::Credentials do
         end
       end
     end
+
+    context 'with access token' do
+      let(:kms_provider) do
+        {
+          access_token: 'access_token'
+        }
+      end
+
+      it 'returns valid libmongocrypt credentials' do
+        expect(params.to_document).to eq(
+          BSON::Document.new({
+            accessToken: 'access_token'
+          })
+        )
+      end
+    end
   end
 
   context 'KMIP' do

data/spec/mongo/crypt/kms_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'mongo'
 require 'lite_spec_helper'

data/spec/mongo/crypt/status_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'lite_spec_helper'
 

data/spec/mongo/cursor/builder/get_more_command_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 # TODO convert, move or delete these tests as part of RUBY-2706.
 

data/spec/mongo/cursor/builder/op_get_more_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 # TODO convert, move or delete these tests as part of RUBY-2706.
 

data/spec/mongo/cursor_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'
 
@@ -39,14 +39,23 @@ describe Mongo::Cursor do
         # Deal with this by pre-creating pools for all known servers.
         cluster = authorized_collection.client.cluster
         cluster.next_primary
-        cluster.servers_list.each do |server|
-          server.pool
+        cluster.servers.each do |server|
+          reset_pool(server)
+        end
+      end
+
+      after do
+        authorized_client.cluster.servers.each do |server|
+          if pool = server.pool_internal
+            pool.close
+          end
         end
       end
     end
 
     context 'cursor exhausted by initial result' do
       include_context 'with initialized pool'
+      require_no_linting
 
       let(:view) do
         Mongo::Collection::View.new(authorized_collection)
@@ -64,6 +73,7 @@ describe Mongo::Cursor do
 
     context 'cursor not exhausted by initial result' do
       include_context 'with initialized pool'
+      require_no_linting
 
       let(:view) do
         Mongo::Collection::View.new(authorized_collection, {}, batch_size: 2)
@@ -84,7 +94,7 @@ describe Mongo::Cursor do
 
       let(:server) do
         view.send(:server_selector).select_server(authorized_client.cluster).tap do |server|
-          authorized_client.cluster.disconnect!
+          authorized_client.cluster.close
           server.unknown!
         end
       end
@@ -93,8 +103,10 @@ describe Mongo::Cursor do
         Mongo::Collection::View.new(authorized_collection)
       end
 
-      it 'works' do
-        cursor
+      it 'raises ServerNotUsable' do
+        lambda do
+          cursor
+        end.should raise_error(Mongo::Error::ServerNotUsable)
       end
     end
   end
@@ -697,7 +709,11 @@ describe Mongo::Cursor do
 
   describe '#close' do
     let(:view) do
-      Mongo::Collection::View.new(authorized_collection)
+      Mongo::Collection::View.new(
+        authorized_collection,
+        {},
+        batch_size: 2,
+      )
     end
 
     let(:server) do
@@ -712,25 +728,56 @@ describe Mongo::Cursor do
       described_class.new(view, reply, server)
     end
 
+    let(:documents) do
+      (1..10).map{ |i| { field: "test#{i}" }}
+    end
+
+    before do
+      authorized_collection.drop
+      authorized_collection.insert_many(documents)
+    end
+
     it 'closes' do
+      expect(cursor).not_to be_closed
       cursor.close
       expect(cursor).to be_closed
     end
 
+    context 'when closed from another thread' do
+      it 'raises an error' do
+        Thread.new do
+          cursor.close
+        end
+        sleep(1)
+        expect(cursor).to be_closed
+        expect do
+          cursor.to_a
+        end.to raise_error Mongo::Error::InvalidCursorOperation
+      end
+    end
+
     context 'when there is a socket error during close' do
       clean_slate
+      require_no_linting
 
       before do
+        reset_pool(server)
+      end
+
+      after do
+        server.pool.close
+      end
+
+      it 'does not raise an error' do
+        cursor
         server.with_connection do |conn|
           expect(conn).to receive(:deliver)
+            .at_least(:once)
             .and_raise(Mongo::Error::SocketError, "test error")
         end
-      end
-
-      it 'raises an error' do
         expect do
           cursor.close
-        end.to raise_error(Mongo::Error::SocketError, "test error")
+        end.not_to raise_error
       end
     end
   end

data/spec/mongo/database_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-# encoding: utf-8
+# rubocop:todo all
 
 require 'spec_helper'