mongo 2.15.0 → 2.17.0

data/spec/spec_tests/data/sessions_unified/snapshot-sessions.yml

@@ -0,0 +1,482 @@
+description: snapshot-sessions
+
+schemaVersion: "1.0"
+
+runOnRequirements:
+  - minServerVersion: "5.0"
+    topologies: [replicaset, sharded-replicaset]
+
+createEntities:
+  - client:
+      id: &client0 client0
+      observeEvents: [ commandStartedEvent]
+      ignoreCommandMonitoringEvents: [ findAndModify, insert, update ]
+  - database:
+      id: &database0 database0
+      client: *client0
+      databaseName: &database0Name database0
+  - collection:
+      id: &collection0 collection0
+      database: *database0
+      collectionName: &collection0Name collection0
+      collectionOptions:
+        writeConcern: { w: majority }
+  - session:
+      id: session0
+      client: client0
+      sessionOptions:
+        snapshot: true
+  - session:
+      id: session1
+      client: client0
+      sessionOptions:
+        snapshot: true
+
+initialData:
+  - collectionName: *collection0Name
+    databaseName: *database0Name
+    documents:
+      - { _id: 1, x: 11 }
+      - { _id: 2, x: 11 }
+
+tests:
+- description: Find operation with snapshot
+  operations:
+  - name: find
+    object: collection0
+    arguments:
+      session: session0
+      filter: { _id: 1 }
+    expectResult:
+      - {_id: 1, x: 11}
+  - name: findOneAndUpdate
+    object: collection0
+    arguments:
+      filter: { _id: 1 }
+      update: { $inc: { x: 1 } }
+      returnDocument: After
+    expectResult: { _id: 1, x: 12 }
+  - name: find
+    object: collection0
+    arguments:
+      session: session1
+      filter: { _id: 1 }
+    expectResult:
+      - { _id: 1, x: 12 }
+  - name: findOneAndUpdate
+    object: collection0
+    arguments:
+      filter: { _id: 1 }
+      update: { $inc: { x: 1 } }
+      returnDocument: After
+    expectResult: { _id: 1, x: 13 }
+  - name: find
+    object: collection0
+    arguments:
+      filter: { _id: 1 }
+    expectResult:
+    - { _id: 1, x: 13 }
+  - name: find
+    object: collection0
+    arguments:
+      session: session0
+      filter: { _id: 1 }
+    expectResult:
+    - {_id: 1, x: 11}
+  - name: find
+    object: collection0
+    arguments:
+      session: session1
+      filter: { _id: 1 }
+    expectResult:
+    - {_id: 1, x: 12}
+  expectEvents:
+  - client: client0
+    events:
+    - commandStartedEvent:
+        command:
+          find: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": false
+    - commandStartedEvent:
+        command:
+          find: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": false
+    - commandStartedEvent:
+        command:
+          find: collection0
+          readConcern:
+            "$$exists": false
+    - commandStartedEvent:
+        command:
+          find: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": true
+    - commandStartedEvent:
+        command:
+          find: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": true
+
+- description: Distinct operation with snapshot
+  operations:
+  - name: distinct
+    object: collection0
+    arguments:
+      fieldName: x
+      filter: {}
+      session: session0
+    expectResult:
+    - 11
+  - name: findOneAndUpdate
+    object: collection0
+    arguments:
+      filter: { _id: 2 }
+      update: { $inc: { x: 1 } }
+      returnDocument: After
+    expectResult: { _id: 2, x: 12 }
+  - name: distinct
+    object: collection0
+    arguments:
+      fieldName: x
+      filter: {}
+      session: session1
+    expectResult: [11, 12]
+  - name: findOneAndUpdate
+    object: collection0
+    arguments:
+      filter: { _id: 2 }
+      update: { $inc: { x: 1 } }
+      returnDocument: After
+    expectResult: { _id: 2, x: 13 }
+  - name: distinct
+    object: collection0
+    arguments:
+      fieldName: x
+      filter: {}
+    expectResult: [ 11, 13 ]
+  - name: distinct
+    object: collection0
+    arguments:
+      fieldName: x
+      filter: {}
+      session: session0
+    expectResult: [ 11 ]
+  - name: distinct
+    object: collection0
+    arguments:
+      fieldName: x
+      filter: {}
+      session: session1
+    expectResult: [ 11, 12 ]
+  expectEvents:
+  - client: client0
+    events:
+    - commandStartedEvent:
+        command:
+          distinct: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": false
+    - commandStartedEvent:
+        command:
+          distinct: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": false
+    - commandStartedEvent:
+        command:
+          distinct: collection0
+          readConcern:
+            "$$exists": false
+    - commandStartedEvent:
+        command:
+          distinct: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": true
+    - commandStartedEvent:
+        command:
+          distinct: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": true
+
+- description: Aggregate operation with snapshot
+  operations:
+  - name: aggregate
+    object: collection0
+    arguments:
+      pipeline:
+      - "$match": { _id: 1 }
+      session: session0
+    expectResult:
+    - { _id: 1, x: 11 }
+  - name: findOneAndUpdate
+    object: collection0
+    arguments:
+      filter: { _id: 1 }
+      update: { $inc: { x: 1 } }
+      returnDocument: After
+    expectResult: { _id: 1, x: 12 }
+  - name: aggregate
+    object: collection0
+    arguments:
+      pipeline:
+      - "$match":
+          _id: 1
+      session: session1
+    expectResult:
+    - {_id: 1, x: 12}
+  - name: findOneAndUpdate
+    object: collection0
+    arguments:
+      filter: { _id: 1 }
+      update: { $inc: { x: 1 } }
+      returnDocument: After
+    expectResult: { _id: 1, x: 13 }
+  - name: aggregate
+    object: collection0
+    arguments:
+      pipeline:
+      - "$match": { _id: 1 }
+    expectResult:
+    - { _id: 1, x: 13 }
+  - name: aggregate
+    object: collection0
+    arguments:
+      pipeline:
+      - "$match":
+          _id: 1
+      session: session0
+    expectResult:
+    - { _id: 1, x: 11 }
+  - name: aggregate
+    object: collection0
+    arguments:
+      pipeline:
+      - "$match": { _id: 1 }
+      session: session1
+    expectResult:
+    - { _id: 1, x: 12 }
+  expectEvents:
+  - client: client0
+    events:
+    - commandStartedEvent:
+        command:
+          aggregate: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": false
+    - commandStartedEvent:
+        command:
+          aggregate: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": false
+    - commandStartedEvent:
+        command:
+          aggregate: collection0
+          readConcern:
+            "$$exists": false
+    - commandStartedEvent:
+        command:
+          aggregate: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": true
+    - commandStartedEvent:
+        command:
+          aggregate: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": true
+
+- description: countDocuments operation with snapshot
+  operations:
+  - name: countDocuments
+    object: collection0
+    arguments:
+      filter: {}
+      session: session0
+    expectResult: 2
+  - name: countDocuments
+    object: collection0
+    arguments:
+      filter: {}
+      session: session0
+    expectResult: 2
+  expectEvents:
+  - client: client0
+    events:
+    - commandStartedEvent:
+        command:
+          aggregate: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": false
+    - commandStartedEvent:
+        command:
+          aggregate: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": true
+
+- description: Mixed operation with snapshot
+  operations:
+  - name: find
+    object: collection0
+    arguments:
+      session: session0
+      filter: { _id: 1 }
+    expectResult:
+    - { _id: 1, x: 11 }
+  - name: findOneAndUpdate
+    object: collection0
+    arguments:
+      filter: { _id: 1 }
+      update: { $inc: { x: 1 } }
+      returnDocument: After
+    expectResult: { _id: 1, x: 12 }
+  - name: find
+    object: collection0
+    arguments:
+      filter: { _id: 1 }
+    expectResult:
+    - { _id: 1, x: 12 }
+  - name: aggregate
+    object: collection0
+    arguments:
+      pipeline:
+      - "$match":
+          _id: 1
+      session: session0
+    expectResult:
+    - { _id: 1, x: 11 }
+  - name: distinct
+    object: collection0
+    arguments:
+      fieldName: x
+      filter: {}
+      session: session0
+    expectResult: [ 11 ] 
+  expectEvents:
+  - client: client0
+    events:
+    - commandStartedEvent:
+        command:
+          find: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": false
+    - commandStartedEvent:
+        command:
+          find: collection0
+          readConcern:
+            "$$exists": false
+    - commandStartedEvent:
+        command:
+          aggregate: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": true
+    - commandStartedEvent:
+        command:
+          distinct: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": true
+
+- description: Write commands with snapshot session do not affect snapshot reads
+  operations:
+  - name: find
+    object: collection0
+    arguments:
+      filter: {}
+      session: session0
+  - name: insertOne
+    object: collection0
+    arguments:
+      document:
+        _id: 22
+        x: 33
+  - name: updateOne
+    object: collection0
+    arguments:
+      filter: { _id: 1 }
+      update: { $inc: { x: 1 } }
+  - name: find
+    object: collection0
+    arguments:
+      filter: { _id: 1 }
+      session: session0
+    expectResult:
+    - {_id: 1, x: 11}
+  expectEvents:
+  - client: client0
+    events:
+    - commandStartedEvent:
+        command:
+          find: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": false
+    - commandStartedEvent:
+        command:
+          find: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": true
+
+- description: First snapshot read does not send atClusterTime
+  operations:
+  - name: find
+    object: collection0
+    arguments:
+      filter: {}
+      session: session0
+  expectEvents:
+  - client: client0
+    events:
+    - commandStartedEvent:
+        command:
+          find: collection0
+          readConcern:
+            level: snapshot
+            atClusterTime:
+              "$$exists": false
+        commandName: find
+        databaseName: database0
+
+- description: StartTransaction fails in snapshot session
+  operations:
+  - name: startTransaction
+    object: session0
+    expectError:
+      isError: true
+      isClientError: true
+      errorContains: Transactions are not supported in snapshot sessions

data/spec/spec_tests/data/transactions/retryable-abort-errorLabels.yml

@@ -2,6 +2,8 @@ runOn:
     -
         minServerVersion: "4.3.1"
         topology: ["replicaset", "sharded"]
+        # https://jira.mongodb.org/browse/RUBY-2776
+        serverless: forbid
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

data/spec/spec_tests/data/transactions/retryable-abort.yml

@@ -5,6 +5,8 @@ runOn:
     -
         minServerVersion: "4.1.8"
         topology: ["sharded"]
+        # https://jira.mongodb.org/browse/RUBY-2776
+        serverless: forbid
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

data/spec/spec_tests/data/transactions/retryable-commit-errorLabels.yml

@@ -2,6 +2,8 @@ runOn:
     -
         minServerVersion: "4.3.1"
         topology: ["replicaset", "sharded"]
+        # https://jira.mongodb.org/browse/RUBY-2776
+        serverless: forbid
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

data/spec/spec_tests/data/transactions/retryable-commit.yml

@@ -5,6 +5,8 @@ runOn:
     -
         minServerVersion: "4.1.8"
         topology: ["sharded"]
+        # https://jira.mongodb.org/browse/RUBY-2776
+        serverless: forbid
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

data/spec/spec_tests/data/transactions/retryable-writes.yml

@@ -5,6 +5,8 @@ runOn:
     -
         minServerVersion: "4.1.8"
         topology: ["sharded"]
+        # https://jira.mongodb.org/browse/RUBY-2776
+        serverless: forbid
 
 database_name: &database_name "transaction-tests"
 collection_name: &collection_name "test"

data/spec/spec_tests/data/uri_options/connection-options.yml

@@ -147,3 +147,63 @@ tests:
       hosts: ~
       auth: ~
       options: {}
+    -
+      description: loadBalanced=true
+      uri: "mongodb://example.com/?loadBalanced=true"
+      valid: true
+      warning: false
+      hosts: ~
+      auth: ~
+      options:
+          loadBalanced: true
+    -
+      description: loadBalanced=true with directConnection=false
+      uri: "mongodb://example.com/?loadBalanced=true&directConnection=false"
+      valid: true
+      warning: false
+      hosts: ~
+      auth: ~
+      options:
+          loadBalanced: true
+          directConnection: false
+    -
+      description: loadBalanced=false
+      uri: "mongodb://example.com/?loadBalanced=false"
+      valid: true
+      warning: false
+      hosts: ~
+      auth: ~
+      options:
+          loadBalanced: false
+    -
+      description: Invalid loadBalanced value
+      uri: "mongodb://example.com/?loadBalanced=1"
+      valid: true
+      warning: true
+      hosts: ~
+      auth: ~
+      options: {}
+    -
+      description: loadBalanced=true with multiple hosts causes an error
+      uri: "mongodb://example1,example2/?loadBalanced=true"
+      valid: false
+      warning: false
+      hosts: ~
+      auth: ~
+      options: {}
+    -
+      description: loadBalanced=true with directConnection=true causes an error
+      uri: "mongodb://example.com/?loadBalanced=true&directConnection=true"
+      valid: false
+      warning: false
+      hosts: ~
+      auth: ~
+      options: {}
+    -
+      description: loadBalanced=true with replicaSet causes an error
+      uri: "mongodb://example.com/?loadBalanced=true&replicaSet=replset"
+      valid: false
+      warning: false
+      hosts: ~
+      auth: ~
+      options: {}

data/spec/spec_tests/load_balancers_spec.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require 'spec_helper'
+
+require 'runners/unified'
+
+base = "#{CURRENT_PATH}/spec_tests/data/load_balancers"
+LOAD_BALANCER_TESTS = Dir.glob("#{base}/**/*.yml").sort
+
+describe 'Load balancer spec tests' do
+  require_topology :load_balanced
+
+  define_unified_spec_tests(base, LOAD_BALANCER_TESTS)
+end

data/spec/spec_tests/retryable_reads_spec.rb

@@ -7,7 +7,7 @@ require 'runners/crud'
 
 describe 'Retryable reads spec tests' do
   require_wired_tiger
-  require_no_multi_shard
+  require_no_multi_mongos
 
   define_crud_spec_tests(RETRYABLE_READS_TESTS) do |spec, req, test|
     let(:client) do
@@ -19,7 +19,7 @@ describe 'Retryable reads spec tests' do
 end
 
 describe 'Retryable reads spec tests - legacy' do
-  require_no_multi_shard
+  require_no_multi_mongos
 
   define_crud_spec_tests(RETRYABLE_READS_TESTS) do |spec, req, test|
     let(:client_options) do

data/spec/spec_tests/retryable_writes_spec.rb

@@ -7,7 +7,7 @@ require 'runners/crud'
 
 describe 'Retryable writes spec tests' do
   require_wired_tiger
-  require_no_multi_shard
+  require_no_multi_mongos
 
   # Do not run these tests when write retries are disabled globally -
   # the tests won't work in that case and testing them with retries enabled

data/spec/spec_tests/sdam_integration_spec.rb

@@ -9,7 +9,7 @@ require 'runners/transactions'
 SDAM_INTEGRATION_TESTS = Dir.glob("#{CURRENT_PATH}/spec_tests/data/sdam_integration/*.yml").sort
 
 describe 'SDAM integration tests' do
-  require_no_multi_shard
+  require_no_multi_mongos
   require_wired_tiger
 
   define_transactions_spec_tests(SDAM_INTEGRATION_TESTS)

data/spec/spec_tests/sdam_monitoring_spec.rb

@@ -16,7 +16,7 @@ describe 'SDAM Monitoring' do
     context("#{spec.description} (#{file.sub(%r'.*/data/sdam_monitoring/', '')})") do
 
       before(:all) do
-        @subscriber = PhasedEventSubscriber.new
+        @subscriber = Mrss::PhasedEventSubscriber.new
         sdam_proc = lambda do |client|
           client.subscribe(Mongo::Monitoring::SERVER_OPENING, @subscriber)
           client.subscribe(Mongo::Monitoring::SERVER_CLOSED, @subscriber)
@@ -39,8 +39,13 @@ describe 'SDAM Monitoring' do
           # Since we set monitoring_io: false, servers are not monitored
           # by the cluster. Start monitoring on them manually (this publishes
           # the server opening event but, again due to monitoring_io being
-          # false, does not do network I/O or change server status)>
-          server.start_monitoring
+          # false, does not do network I/O or change server status).
+          #
+          # If the server is a load balancer, it doesn't normally get monitored
+          # so don't start here either.
+          unless server.load_balancer?
+            server.start_monitoring
+          end
         end
       end
 
@@ -53,7 +58,7 @@ describe 'SDAM Monitoring' do
         context("Phase: #{phase_index + 1}") do
 
           before(:all) do
-            phase.responses.each do |response|
+            phase.responses&.each do |response|
               # For each response in the phase, we need to change that server's description.
               server = find_server(@client, response.address)
               server ||= @servers_cache[response.address.to_s]
@@ -68,7 +73,7 @@ describe 'SDAM Monitoring' do
               result['minWireVersion'] ||= 0
               result['maxWireVersion'] ||= 0
               new_description = Mongo::Server::Description.new(
-                server.description.address, result, 0.5)
+                server.description.address, result, average_round_trip_time: 0.5)
               @client.cluster.run_sdam_flow(server.description, new_description)
             end
             @subscriber.phase_finished(phase_index)

data/spec/spec_tests/sdam_spec.rb

@@ -98,7 +98,7 @@ describe 'Server Discovery and Monitoring' do
               result['minWireVersion'] ||= 0
               result['maxWireVersion'] ||= 0
               new_description = Mongo::Server::Description.new(
-                server.description.address, result, 0.5)
+                server.description.address, result, average_round_trip_time: 0.5)
               @client.cluster.run_sdam_flow(server.description, new_description)
             end