mongo 2.15.0 → 2.17.0

data/spec/integration/cursor_pinning_spec.rb

@@ -0,0 +1,121 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe 'Cursor pinning' do
+  let(:client) { authorized_client }
+  let(:collection_name) { 'cursor_pinning' }
+  let(:collection) { client[collection_name] }
+
+  before do
+    authorized_client[collection_name].insert_many([{test: 1}] * 200)
+  end
+
+  let(:server) { client.cluster.next_primary }
+
+  clean_slate
+
+  context 'non-lb' do
+    require_topology :single, :replica_set, :sharded
+    require_no_multi_mongos
+
+    # When not in load-balanced topology, iterating a cursor creates
+    # new connections as needed.
+
+    it 'creates new connections for iteration' do
+      server.pool.size.should == 0
+
+      # Use batch_size of 2 until RUBY-2727 is fixed.
+      enum = collection.find({}, batch_size: 2).to_enum
+      # Still zero because we haven't iterated
+      server.pool.size.should == 0
+
+      enum.next
+      enum.next
+      server.pool.size.should == 1
+
+      # Grab the connection that was used
+      server.with_connection do
+        # This requires a new connection
+        enum.next
+
+        server.pool.size.should == 2
+      end
+    end
+  end
+
+  context 'lb' do
+    require_topology :load_balanced
+
+    # In load-balanced topology, we cannot create new connections to a
+    # particular service.
+
+    context 'when no connection is available' do
+
+      it 'raises ConnectionCheckOutTimeout' do
+        server.pool.size.should == 0
+
+        enum = collection.find({}, batch_size: 1).to_enum
+        # Still zero because we haven't iterated
+        server.pool.size.should == 0
+
+        enum.next
+        server.pool.size.should == 1
+
+        # Grab the connection that was used
+        server.with_connection do
+          # This requires a new connection, but we cannot make one.
+          lambda do
+            enum.next
+          end.should raise_error(Mongo::Error::ConnectionCheckOutTimeout)
+
+          server.pool.size.should == 1
+        end
+      end
+    end
+
+    context 'when connection is available' do
+      require_multi_mongos
+
+      let(:client) { authorized_client.with(max_pool_size: 4) }
+
+      it 'uses the available connection' do
+        server.pool.size.should == 0
+
+        # Create 4 connections.
+
+        enums = []
+        connections = []
+        service_ids = []
+
+        4.times do
+          view = collection.find({}, batch_size: 1)
+          enum = view.to_enum
+
+          enum.next
+
+          enums << enum
+          service_ids << view.cursor.initial_result.connection_description.service_id
+          connections << server.pool.check_out
+        end
+
+        service_ids.uniq.length.should be > 1
+
+        server.pool.size.should == 4
+
+        connections.each do |c|
+          server.pool.check_in(c)
+        end
+
+        # At this point, in theory, all connections are equally likely to
+        # be chosen, but we have cursors referencing more than one
+        # distinct service.
+        # Iterate each cursor to ensure they all continue to work.
+        enums.each do |enum|
+          enum.next
+        end
+      end
+    end
+  end
+end

data/spec/integration/cursor_reaping_spec.rb

@@ -8,6 +8,8 @@ describe 'Cursor reaping' do
   # in MRI, I don't currently know how to force GC to run in JRuby
   require_mri
 
+# Uncomment for debugging this test.
+=begin
   around(:all) do |example|
     saved_level = Mongo::Logger.logger.level
     Mongo::Logger.logger.level = Logger::DEBUG
@@ -17,8 +19,9 @@ describe 'Cursor reaping' do
       Mongo::Logger.logger.level = saved_level
     end
   end
+=end
 
-  let(:subscriber) { EventSubscriber.new }
+  let(:subscriber) { Mrss::EventSubscriber.new }
 
   let(:client) do
     authorized_client.tap do |client|
@@ -57,10 +60,11 @@ describe 'Cursor reaping' do
         10.times do
           scope = collection.find.batch_size(2).no_cursor_timeout
 
-          # there is no API for retrieving the cursor
+          # Begin iteration, creating the cursor
           scope.each.first
-          # and keep the first cursor
-          cursor_ids << scope.instance_variable_get('@cursor').id
+
+          scope.cursor.should_not be nil
+          cursor_ids << scope.cursor.id
         end
       end
     end

data/spec/integration/fork_reconnect_spec.rb

@@ -10,11 +10,7 @@ describe 'fork reconnect' do
   # On multi-shard sharded clusters a succeeding write request does not
   # guarantee that the next operation will succeed (since it could be sent to
   # another shard with a dead connection).
-  require_no_multi_shard
-
-  # On Ruby 2.3 $?.exitstatus is sometimes nil after Process.wait returns which
-  # is not supposed to happen.
-  ruby_version_gte '2.4'
+  require_no_multi_mongos
 
   let(:client) { authorized_client }
   let(:server) { client.cluster.next_primary }

data/spec/integration/get_more_spec.rb

@@ -7,7 +7,7 @@ describe 'getMore operation' do
   # https://jira.mongodb.org/browse/RUBY-1987
   min_server_fcv '3.2'
 
-  let(:subscriber) { EventSubscriber.new }
+  let(:subscriber) { Mrss::EventSubscriber.new }
 
   let(:client) do
     authorized_client.tap do |client|

data/spec/integration/heartbeat_events_spec.rb

@@ -11,7 +11,7 @@ describe 'Heartbeat events' do
 
   clean_slate_for_all
 
-  let(:subscriber) { EventSubscriber.new }
+  let(:subscriber) { Mrss::EventSubscriber.new }
 
   before do
     Mongo::Monitoring::Global.subscribe(Mongo::Monitoring::SERVER_HEARTBEAT, subscriber)

data/spec/integration/map_reduce_spec.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe 'Map-reduce operations' do
+  let(:client) { authorized_client }
+  let(:collection) { client['mr_integration'] }
+
+  let(:subscriber) { Mrss::EventSubscriber.new }
+
+  let(:find_options) { {} }
+
+  let(:operation) do
+    collection.find({}, find_options).map_reduce('function(){}', 'function(){}')
+  end
+
+  before do
+    collection.insert_one(test: 1)
+    client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
+  end
+
+  let(:event) { subscriber.single_command_started_event('mapReduce') }
+
+  context 'read preference' do
+    require_topology :sharded
+
+    context 'specified on client' do
+      let(:client) { authorized_client.with(read: {mode: :secondary_preferred }) }
+
+      # RUBY-2706: read preference is not sent on pre-3.6 servers
+      min_server_fcv '3.6'
+
+      it 'is sent' do
+        operation.to_a
+
+        event.command['$readPreference'].should == {'mode' => 'secondaryPreferred'}
+      end
+    end
+
+    context 'specified on collection' do
+      let(:collection) { client['mr_integration', read: {mode: :secondary_preferred }] }
+
+      # RUBY-2706: read preference is not sent on pre-3.6 servers
+      min_server_fcv '3.6'
+
+      it 'is sent' do
+        operation.to_a
+
+        event.command['$readPreference'].should == {'mode' => 'secondaryPreferred'}
+      end
+    end
+
+    context 'specified on operation' do
+      let(:find_options) { {read: {mode: :secondary_preferred }} }
+
+      # RUBY-2706: read preference is not sent on pre-3.6 servers
+      min_server_fcv '3.6'
+
+      it 'is sent' do
+        operation.to_a
+
+        event.command['$readPreference'].should == {'mode' => 'secondaryPreferred'}
+      end
+    end
+  end
+
+  context 'session' do
+    min_server_fcv '3.6'
+
+    it 'is sent' do
+      operation.to_a
+
+      event.command['lsid'].should_not be nil
+    end
+  end
+end

data/spec/integration/query_cache_spec.rb

@@ -28,7 +28,7 @@ describe 'QueryCache' do
     SessionRegistry.instance.verify_sessions_ended!
   end
 
-  let(:subscriber) { EventSubscriber.new }
+  let(:subscriber) { Mrss::EventSubscriber.new }
 
   let(:client) do
     authorized_client.tap do |client|
@@ -969,7 +969,7 @@ describe 'QueryCache' do
 
   context 'when find command fails and retries' do
     require_fail_command
-    require_no_multi_shard
+    require_no_multi_mongos
     require_warning_clean
 
     before do
@@ -1045,4 +1045,49 @@ describe 'QueryCache' do
       expect(events.length).to eq(2)
     end
   end
+
+  context 'when result set has multiple documents and cursor is iterated partially' do
+
+    before do
+      Mongo::QueryCache.enabled = false
+      5.times do
+        authorized_collection.insert_one({ name: 'testing' })
+      end
+    end
+
+    shared_examples 'retrieves full result set on second iteration' do
+      it 'retrieves full result set on second iteration' do
+        Mongo::QueryCache.clear
+        Mongo::QueryCache.enabled = true
+
+        partial_first_iteration
+
+        authorized_collection.find.to_a.length.should == 5
+      end
+
+    end
+
+    context 'using each & break' do
+      let(:partial_first_iteration) do
+        called = false
+        authorized_collection.find.each do
+          called = true
+          break
+        end
+        called.should be true
+      end
+
+      include_examples 'retrieves full result set on second iteration'
+    end
+
+    context 'using next' do
+      let(:partial_first_iteration) do
+        # #next is executed in its own fiber, and query cache is disabled
+        # for that operation.
+        authorized_collection.find.to_enum.next
+      end
+
+      include_examples 'retrieves full result set on second iteration'
+    end
+  end
 end

data/spec/integration/query_cache_transactions_spec.rb

@@ -23,7 +23,7 @@ describe 'QueryCache with transactions' do
   # leak sessions independently of the query cache. This will be resolved by
   # RUBY-2391.
 
-  let(:subscriber) { EventSubscriber.new }
+  let(:subscriber) { Mrss::EventSubscriber.new }
 
   let(:client) do
     authorized_client.tap do |client|

data/spec/integration/read_concern_spec.rb

@@ -7,7 +7,7 @@ describe 'read concern' do
   min_server_version '3.2'
 
   let(:subscriber) do
-    EventSubscriber.new
+    Mrss::EventSubscriber.new
   end
 
   let(:specified_read_concern) do

data/spec/integration/read_preference_spec.rb

@@ -16,7 +16,7 @@ describe 'Read preference' do
     authorized_client.with(client_options)
   end
 
-  let(:subscriber) { EventSubscriber.new }
+  let(:subscriber) { Mrss::EventSubscriber.new }
 
   before do
     client.subscribe(Mongo::Monitoring::COMMAND, subscriber)
@@ -45,16 +45,6 @@ describe 'Read preference' do
     {}
   end
 
-  shared_examples_for 'sends expected read preference when reading' do
-    it 'sends expected read preference when reading' do
-      read_operation
-
-      event = subscriber.single_command_started_event('find')
-      actual_preference = event.command['$readPreference']
-      expect(actual_preference).to eq(expected_read_preference)
-    end
-  end
-
   shared_examples_for 'does not send read preference when reading' do
     it 'does not send read preference when reading' do
       read_operation
@@ -95,7 +85,17 @@ describe 'Read preference' do
       context 'server supporting OP_MSG' do
         min_server_fcv '3.6'
 
-        it_behaves_like 'sends expected read preference when reading'
+        it 'sends expected read preference when reading' do
+          read_operation
+
+          event = subscriber.single_command_started_event('find')
+          actual_preference = event.command['$readPreference']
+          if expected_read_preference&.[]("mode") == "primary"
+            expect(actual_preference).to be_nil
+          else
+            expect(actual_preference).to eq(expected_read_preference)
+          end
+        end
       end
     end
 
@@ -307,7 +307,11 @@ describe 'Read preference' do
 
           event = subscriber.single_command_started_event('find')
           actual_preference = event.command['$readPreference']
-          expect(actual_preference).to eq(expected_read_preference)
+          if expected_read_preference&.[]("mode") == "primary"
+            expect(actual_preference).to be_nil
+          else
+            expect(actual_preference).to eq(expected_read_preference)
+          end
         end
       end
     end

data/spec/integration/reconnect_spec.rb

@@ -16,20 +16,38 @@ describe 'Client after reconnect' do
     expect(doc['testk']).to eq('testv')
   end
 
-  it 'recreates monitor thread' do
-    thread = client.cluster.servers.first.monitor.instance_variable_get('@thread')
-    expect(thread).to be_alive
+  context 'non-lb' do
+    require_topology :single, :replica_set, :sharded
 
-    thread.kill
-    # context switch to let the thread get killed
-    sleep 0.1
-    expect(thread).not_to be_alive
+    it 'recreates monitor thread' do
+      thread = client.cluster.servers.first.monitor.instance_variable_get('@thread')
+      expect(thread).to be_alive
 
-    client.reconnect
+      thread.kill
+      # context switch to let the thread get killed
+      sleep 0.1
+      expect(thread).not_to be_alive
+
+      client.reconnect
+
+      new_thread = client.cluster.servers.first.monitor.instance_variable_get('@thread')
+      expect(new_thread).not_to eq(thread)
+      expect(new_thread).to be_alive
+    end
+  end
+
+  context 'lb' do
+    require_topology :load_balanced
 
-    new_thread = client.cluster.servers.first.monitor.instance_variable_get('@thread')
-    expect(new_thread).not_to eq(thread)
-    expect(new_thread).to be_alive
+    it 'does not recreate monitor thread' do
+      thread = client.cluster.servers.first.monitor.instance_variable_get('@thread')
+      expect(thread).to be nil
+
+      client.reconnect
+
+      new_thread = client.cluster.servers.first.monitor.instance_variable_get('@thread')
+      expect(new_thread).to be nil
+    end
   end
 
   context 'with min_pool_size > 0' do
@@ -114,7 +132,7 @@ describe 'Client after reconnect' do
     context 'in sharded topology' do
       require_topology :sharded
       require_default_port_deployment
-      require_multi_shard
+      require_multi_mongos
 
       let(:expected_topology_cls) { Mongo::Cluster::Topology::Sharded }
 

data/spec/integration/retryable_errors_spec.rb

@@ -7,7 +7,7 @@ describe 'Failing retryable operations' do
   # Requirement for fail point
   min_server_fcv '4.0'
 
-  let(:subscriber) { EventSubscriber.new }
+  let(:subscriber) { Mrss::EventSubscriber.new }
 
   let(:client_options) do
     {}

data/spec/integration/retryable_writes/retryable_writes_36_and_older_spec.rb

@@ -20,7 +20,7 @@ describe 'Retryable writes integration tests' do
 
   # These tests override server selector, which fails if there are multiple
   # eligible servers as would be the case in a multi-shard sharded cluster
-  require_no_multi_shard
+  require_no_multi_mongos
 
   # Note: these tests are deprecated in favor of the tests in the file
   # spec/integration/retryable_writes/retryable_writes_40_and_newer_spec.rb

data/spec/integration/retryable_writes/retryable_writes_40_and_newer_spec.rb

@@ -10,7 +10,7 @@ require_relative './shared/does_not_support_retries'
 describe 'Retryable Writes' do
   require_fail_command
   require_wired_tiger
-  require_no_multi_shard
+  require_no_multi_mongos
   require_warning_clean
 
   let(:client) do

data/spec/integration/sdam_error_handling_spec.rb

@@ -4,6 +4,8 @@
 require 'spec_helper'
 
 describe 'SDAM error handling' do
+  require_topology :single, :replica_set, :sharded
+
   clean_slate
 
   after do
@@ -14,9 +16,9 @@ describe 'SDAM error handling' do
 
   # These tests operate on specific servers, and don't work in a multi
   # shard cluster where multiple servers are equally eligible
-  require_no_multi_shard
+  require_no_multi_mongos
 
-  let(:diagnostic_subscriber) { VerboseEventSubscriber.new }
+  let(:diagnostic_subscriber) { Mrss::VerboseEventSubscriber.new }
 
   let(:client) do
     new_local_client(SpecConfig.instance.addresses,
@@ -288,7 +290,7 @@ describe 'SDAM error handling' do
   describe 'when there is an error on monitoring connection' do
     clean_slate_for_all
 
-    let(:subscriber) { EventSubscriber.new }
+    let(:subscriber) { Mrss::EventSubscriber.new }
 
     let(:set_subscribers) do
       client.subscribe(Mongo::Monitoring::SERVER_DESCRIPTION_CHANGED, subscriber)

data/spec/integration/sdam_events_spec.rb

@@ -4,7 +4,7 @@
 require 'spec_helper'
 
 describe 'SDAM events' do
-  let(:subscriber) { EventSubscriber.new }
+  let(:subscriber) { Mrss::EventSubscriber.new }
 
   describe 'server closed event' do
     it 'is published when client is closed' do
@@ -50,13 +50,20 @@ describe 'SDAM events' do
     context 'pre-4.4 servers' do
       max_server_version '4.2'
 
+      let(:sdam_proc) do
+        Proc.new do |client|
+          client.subscribe(Mongo::Monitoring::SERVER_HEARTBEAT, subscriber)
+        end
+      end
+
       let(:client) do
         new_local_client(SpecConfig.instance.addresses,
           # Heartbeat interval is bound by 500 ms
-          SpecConfig.instance.test_options.merge(heartbeat_frequency: 0.5),
-        ).tap do |client|
-          client.subscribe(Mongo::Monitoring::SERVER_HEARTBEAT, subscriber)
-        end
+          SpecConfig.instance.test_options.merge(
+            heartbeat_frequency: 0.5,
+            sdam_proc: sdam_proc
+          ),
+        )
       end
 
       it 'is published every heartbeat interval' do
@@ -78,13 +85,20 @@ describe 'SDAM events' do
     context '4.4+ servers' do
       min_server_fcv '4.4'
 
+      let(:sdam_proc) do
+        Proc.new do |client|
+          client.subscribe(Mongo::Monitoring::SERVER_HEARTBEAT, subscriber)
+        end
+      end
+
       let(:client) do
         new_local_client(SpecConfig.instance.addresses,
           # Heartbeat interval is bound by 500 ms
-          SpecConfig.instance.test_options.merge(heartbeat_frequency: 0.5),
-        ).tap do |client|
-          client.subscribe(Mongo::Monitoring::SERVER_HEARTBEAT, subscriber)
-        end
+          SpecConfig.instance.test_options.merge(
+            heartbeat_frequency: 0.5,
+            sdam_proc: sdam_proc
+          ),
+        )
       end
 
       it 'is published up to twice every heartbeat interval' do
@@ -92,23 +106,25 @@ describe 'SDAM events' do
         sleep 3
         client.close
 
-        events = subscriber.select_started_events(Mongo::Monitoring::Event::ServerHeartbeatStarted)
+        started_events = subscriber.select_started_events(
+          Mongo::Monitoring::Event::ServerHeartbeatStarted
+        )
         # We could have up to 16 events and should have no fewer than 8 events.
         # Whenever an awaited hello succeeds while the regular monitor is
         # waiting, the regular monitor's next scan is pushed forward.
-        events.length.should >= 6
-        events.length.should <= 18
-        (started_awaited = events.select(&:awaited?)).should_not be_empty
-        (started_regular = events.reject(&:awaited?)).should_not be_empty
+        started_events.length.should >= 6
+        started_events.length.should <= 18
+        (started_awaited = started_events.select(&:awaited?)).should_not be_empty
+        (started_regular = started_events.reject(&:awaited?)).should_not be_empty
 
-        events = subscriber.select_completed_events(
+        completed_events = subscriber.select_completed_events(
           Mongo::Monitoring::Event::ServerHeartbeatSucceeded,
           Mongo::Monitoring::Event::ServerHeartbeatFailed,
         )
-        events.length.should >= 6
-        events.length.should <= 18
-        (succeeded_awaited = events.select(&:awaited?)).should_not be_empty
-        (succeeded_regular = events.reject(&:awaited?)).should_not be_empty
+        completed_events.length.should >= 6
+        completed_events.length.should <= 18
+        (succeeded_awaited = completed_events.select(&:awaited?)).should_not be_empty
+        (succeeded_regular = completed_events.reject(&:awaited?)).should_not be_empty
 
         # There may be in-flight hellos that don't complete, both
         # regular and awaited.

data/spec/integration/sdam_prose_spec.rb

@@ -11,7 +11,7 @@ describe 'SDAM prose tests' do
     min_server_fcv '4.4'
     require_topology :single
 
-    let(:subscriber) { EventSubscriber.new }
+    let(:subscriber) { Mrss::EventSubscriber.new }
 
     let(:client) do
       new_local_client(SpecConfig.instance.addresses,

data/spec/integration/server_monitor_spec.rb

@@ -4,6 +4,7 @@
 require 'spec_helper'
 
 describe 'Server::Monitor' do
+  require_topology :single, :replica_set, :sharded
 
   let(:client) do
     new_local_client([ClusterConfig.instance.primary_address_str],