mongo 2.13.0.beta1 → 2.13.0.rc1

data/spec/spec_tests/crud_spec.rb

@@ -11,7 +11,7 @@ end
 describe 'CRUD v2 spec tests' do
   define_crud_spec_tests(CRUD2_TESTS) do |spec, req, test|
     let(:client) do
-      authorized_client.tap do |client|
+      authorized_client.use(spec.database_name || 'crud-default').tap do |client|
         client.subscribe(Mongo::Monitoring::COMMAND, event_subscriber)
       end
     end

data/spec/spec_tests/data/change_streams/change-streams-errors.yml

@@ -73,25 +73,21 @@ tests:
     result:
       error:
         code: 280
-        errorLabels: [ "NonResumableChangeStreamError" ]
-
   -
-    description: change stream errors on MaxTimeMSExpired
+    description: change stream errors on ElectionInProgress
     minServerVersion: "4.2"
     failPoint:
       configureFailPoint: failCommand
       mode: { times: 1 }
       data:
           failCommands: ["getMore"]
-          errorCode: 50 # An error code that's not on the old blacklist or whitelist
+          errorCode: 216 # An error code that's not on the old blacklist or whitelist
           closeConnection: false
     target: collection
     topology:
       - replicaset
       - sharded
-    changeStreamPipeline:
-      -
-        $project: { _id: 0 }
+    changeStreamPipeline: []
     changeStreamOptions: {}
     operations:
       -
@@ -103,4 +99,4 @@ tests:
             z: 3
     result:
       error:
-        code: 50
+        code: 216

data/spec/spec_tests/data/change_streams/change-streams-resume-whitelist.yml

@@ -1105,3 +1105,69 @@ tests:
           fullDocument:
             x:
               $numberInt: "1"
+  -
+    # CursorNotFound is special-cased to be resumable regardless of server versions or error labels, so this test has
+    # no maxWireVersion.
+    description: "change stream resumes after CursorNotFound"
+    minServerVersion: "4.2"
+    failPoint:
+      configureFailPoint: failCommand
+      mode: { times: 1 }
+      data:
+          failCommands: ["getMore"]
+          errorCode: 43
+          closeConnection: false
+    target: collection
+    topology:
+      - replicaset
+      - sharded
+    changeStreamPipeline: []
+    changeStreamOptions: {}
+    operations:
+      -
+        database: *database_name
+        collection: *collection_name
+        name: insertOne
+        arguments:
+          document:
+            x: 1
+    expectations:
+      -
+        command_started_event:
+          command:
+            aggregate: *collection_name
+            cursor: {}
+            pipeline:
+              -
+                $changeStream: {}
+          command_name: aggregate
+          database_name: *database_name
+      -
+        command_started_event:
+          command:
+            getMore: 42
+            collection: *collection_name
+          command_name: getMore
+          database_name: *database_name
+      -
+        command_started_event:
+          command:
+            aggregate: *collection_name
+            cursor: {}
+            pipeline:
+              -
+                $changeStream: {}
+          command_name: aggregate
+          database_name: *database_name
+    result:
+      success:
+        -
+          _id: "42"
+          documentKey: "42"
+          operationType: insert
+          ns:
+            db: *database_name
+            coll: *collection_name
+          fullDocument:
+            x:
+              $numberInt: "1"

data/spec/spec_tests/data/max_staleness/ReplicaSetNoPrimary/MaxStalenessTooSmall.yml

@@ -0,0 +1,15 @@
+# maxStalenessSeconds must be at least 90 seconds, even with no known servers.
+---
+topology_description:
+  type: ReplicaSetNoPrimary
+  servers:
+  - &1
+    address: a:27017
+    type: Unknown
+  - &2
+    address: b:27017
+    type: Unknown
+read_preference:
+  mode: Nearest
+  maxStalenessSeconds: 1  # Too small.
+error: true

data/spec/spec_tests/data/max_staleness/ReplicaSetNoPrimary/NoKnownServers.yml

@@ -1,4 +1,4 @@
-# maxStalenessSeconds must be at least 90 seconds, even with no known servers.
+# valid maxStalenessSeconds and no known servers results in an empty set of suitable servers
 ---
 topology_description:
   type: ReplicaSetNoPrimary
@@ -11,5 +11,6 @@ topology_description:
     type: Unknown
 read_preference:
   mode: Nearest
-  maxStalenessSeconds: 1  # Too small.
-error: true
+  maxStalenessSeconds: 90
+suitable_servers: []
+in_latency_window: []

data/spec/spec_tests/data/max_staleness/Unknown/SmallMaxStaleness.yml

@@ -7,6 +7,7 @@ topology_description:
   - &1
     address: a:27017
     type: Unknown
+    maxWireVersion: 5
 read_preference:
   mode: Nearest
   maxStalenessSeconds: 1

data/spec/spec_tests/data/sdam_integration/cancel-server-check.yml

@@ -0,0 +1,96 @@
+# Test SDAM error handling.
+runOn:
+  # General failCommand requirements (this file does not use appName
+  # with failCommand).
+  - minServerVersion: "4.0"
+    topology: ["replicaset"]
+  - minServerVersion: "4.2"
+    topology: ["sharded"]
+
+database_name: &database_name "sdam-tests"
+collection_name: &collection_name "cancel-server-check"
+
+data: []
+
+tests:
+  - description: Cancel server check
+    clientOptions:
+      retryWrites: true
+      heartbeatFrequencyMS: 10000
+      # Server selection timeout MUST be less than heartbeatFrequencyMS for
+      # this test. This setting ensures that the retried insert will fail
+      # after 5 seconds if the driver does not properly cancel the in progress
+      # check.
+      serverSelectionTimeoutMS: 5000
+      appname: cancelServerCheckTest
+    operations:
+      # Perform an operation to ensure the node is discovered.
+      - name: insertOne
+        object: collection
+        arguments:
+          document:
+            _id: 1
+      # Configure the next inserts to fail with a non-timeout network error.
+      # This should:
+      # 1) Mark the server Unknown
+      # 2) Clear the connection pool
+      # 3) Cancel the in progress isMaster check and close the Monitor
+      #    connection
+      # 4) The write will be then we retried, server selection will request an
+      #    immediate check, and block for ~500ms until the next Monitor check
+      #    proceeds.
+      # 5) The write will succeed on the second attempt.
+      - name: configureFailPoint
+        object: testRunner
+        arguments:
+          failPoint:
+            configureFailPoint: failCommand
+            mode: { times: 1 }
+            data:
+                failCommands: ["insert"]
+                closeConnection: True
+      - name: insertOne
+        object: collection
+        arguments:
+          document:
+            _id: 2
+        result:
+          insertedId: 2
+      # The first error should mark the server Unknown and then clear the pool.
+      - name: waitForEvent
+        object: testRunner
+        arguments:
+          event: ServerMarkedUnknownEvent
+          count: 1
+      - name: waitForEvent
+        object: testRunner
+        arguments:
+          event: PoolClearedEvent
+          count: 1
+      # Perform another operation to ensure the node still selectable.
+      - name: insertOne
+        object: collection
+        arguments:
+          document:
+            _id: 3
+        result:
+          insertedId: 3
+      # Assert the server was marked Unknown and pool was cleared exactly once.
+      - name: assertEventCount
+        object: testRunner
+        arguments:
+          event: ServerMarkedUnknownEvent
+          count: 1
+      - name: assertEventCount
+        object: testRunner
+        arguments:
+          event: PoolClearedEvent
+          count: 1
+
+    # Order of operations is non-deterministic so we cannot check events.
+    outcome:
+      collection:
+        data:
+          - {_id: 1}
+          - {_id: 2}
+          - {_id: 3}

data/spec/spec_tests/data/sdam_integration/connectTimeoutMS.yml

@@ -0,0 +1,88 @@
+# Test SDAM error handling.
+runOn:
+    # failCommand appName requirements
+    - minServerVersion: "4.4"
+
+database_name: &database_name "sdam-tests"
+collection_name: &collection_name "connectTimeoutMS"
+
+data: []
+
+tests:
+  - description: connectTimeoutMS=0
+    clientOptions:
+      retryWrites: false
+      connectTimeoutMS: 0
+      heartbeatFrequencyMS: 500
+      appname: connectTimeoutMS=0
+    operations:
+      # Perform an operation to ensure the node is discovered.
+      - name: insertMany
+        object: collection
+        arguments:
+          documents:
+            - _id: 1
+            - _id: 2
+      # Block the next streaming isMaster check for longer than
+      # heartbeatFrequencyMS to ensure that the connection timeout remains
+      # unlimited.
+      - name: configureFailPoint
+        object: testRunner
+        arguments:
+          failPoint:
+            configureFailPoint: failCommand
+            mode: { times: 2 }
+            data:
+                failCommands: ["isMaster"]
+                appName: connectTimeoutMS=0
+                blockConnection: true
+                blockTimeMS: 550
+      - name: wait
+        object: testRunner
+        arguments:
+          ms: 750
+      # Perform an operation to ensure the node is still selectable.
+      - name: insertMany
+        object: collection
+        arguments:
+          documents:
+            - _id: 3
+            - _id: 4
+      # Assert that the server was never marked Unknown and the pool was never
+      # cleared.
+      - name: assertEventCount
+        object: testRunner
+        arguments:
+          event: ServerMarkedUnknownEvent
+          count: 0
+      - name: assertEventCount
+        object: testRunner
+        arguments:
+          event: PoolClearedEvent
+          count: 0
+
+    expectations:
+      - command_started_event:
+          command:
+            insert: *collection_name
+            documents:
+              - _id: 1
+              - _id: 2
+          command_name: insert
+          database_name: *database_name
+      - command_started_event:
+          command:
+            insert: *collection_name
+            documents:
+              - _id: 3
+              - _id: 4
+          command_name: insert
+          database_name: *database_name
+
+    outcome:
+      collection:
+        data:
+          - {_id: 1}
+          - {_id: 2}
+          - {_id: 3}
+          - {_id: 4}

data/spec/spec_tests/data/sdam_integration/find-network-error.yml

@@ -0,0 +1,83 @@
+# Test SDAM error handling.
+runOn:
+    # failCommand appName requirements
+    - minServerVersion: "4.4"
+
+database_name: &database_name "sdam-tests"
+collection_name: &collection_name "find-network-error"
+
+data: &data
+  - {_id: 1}
+  - {_id: 2}
+
+tests:
+  - description: Reset server and pool after network error on find
+    failPoint:
+      configureFailPoint: failCommand
+      mode: { times: 1 }
+      data:
+          failCommands: ["find"]
+          closeConnection: true
+          appName: findNetworkErrorTest
+    clientOptions:
+      retryWrites: false
+      retryReads: false
+      appname: findNetworkErrorTest
+    operations:
+      - name: find
+        object: collection
+        arguments:
+          filter:
+            _id: 1
+        error: true
+      - name: waitForEvent
+        object: testRunner
+        arguments:
+          event: ServerMarkedUnknownEvent
+          count: 1
+      - name: waitForEvent
+        object: testRunner
+        arguments:
+          event: PoolClearedEvent
+          count: 1
+      # Perform another operation to ensure the node is rediscovered.
+      - name: insertMany
+        object: collection
+        arguments:
+          documents:
+            - _id: 5
+            - _id: 6
+      # Assert the server was marked Unknown and pool was cleared exactly once.
+      - name: assertEventCount
+        object: testRunner
+        arguments:
+          event: ServerMarkedUnknownEvent
+          count: 1
+      - name: assertEventCount
+        object: testRunner
+        arguments:
+          event: PoolClearedEvent
+          count: 1
+
+    expectations:
+      - command_started_event:
+          command:
+            find: *collection_name
+          command_name: find
+          database_name: *database_name
+      - command_started_event:
+          command:
+            insert: *collection_name
+            documents:
+              - _id: 5
+              - _id: 6
+          command_name: insert
+          database_name: *database_name
+
+    outcome:
+      collection:
+        data:
+          - {_id: 1}
+          - {_id: 2}
+          - {_id: 5}
+          - {_id: 6}

data/spec/spec_tests/data/sdam_integration/find-shutdown-error.yml

@@ -0,0 +1,116 @@
+# Test SDAM error handling.
+runOn:
+    # failCommand appName requirements
+    - minServerVersion: "4.4"
+
+database_name: &database_name "sdam-tests"
+collection_name: &collection_name "find-shutdown-error"
+
+data: []
+
+tests:
+  - description: Concurrent shutdown error on find
+    clientOptions:
+      retryWrites: false
+      retryReads: false
+      heartbeatFrequencyMS: 500
+      appname: shutdownErrorFindTest
+    operations:
+      # Perform an operation to ensure the node is discovered.
+      - name: insertOne
+        object: collection
+        arguments:
+          document:
+            _id: 1
+      # Configure the next two finds to fail with a non-timeout shutdown
+      # errors. Block the connection for 500ms to ensure both operations check
+      # out connections from the same pool generation.
+      - name: configureFailPoint
+        object: testRunner
+        arguments:
+          failPoint:
+            configureFailPoint: failCommand
+            mode: { times: 2 }
+            data:
+                failCommands: ["find"]
+                appName: shutdownErrorFindTest
+                errorCode: 91
+                blockConnection: true
+                blockTimeMS: 500
+      # Start threads.
+      - name: startThread
+        object: testRunner
+        arguments:
+          name: thread1
+      - name: startThread
+        object: testRunner
+        arguments:
+          name: thread2
+      # Perform concurrent find operations. Both fail with shutdown errors.
+      - name: runOnThread
+        object: testRunner
+        arguments:
+          name: thread1
+          operation:
+            name: find
+            object: collection
+            arguments:
+              filter:
+                _id: 1
+            error: true
+      - name: runOnThread
+        object: testRunner
+        arguments:
+          name: thread2
+          operation:
+            name: find
+            object: collection
+            arguments:
+              filter:
+                _id: 1
+            error: true
+      # Stop threads.
+      - name: waitForThread
+        object: testRunner
+        arguments:
+          name: thread1
+      - name: waitForThread
+        object: testRunner
+        arguments:
+          name: thread2
+      # The first shutdown error should mark the server Unknown and then clear
+      # the pool.
+      - name: waitForEvent
+        object: testRunner
+        arguments:
+          event: ServerMarkedUnknownEvent
+          count: 1
+      - name: waitForEvent
+        object: testRunner
+        arguments:
+          event: PoolClearedEvent
+          count: 1
+      # Perform an operation to ensure the node is rediscovered.
+      - name: insertOne
+        object: collection
+        arguments:
+          document:
+            _id: 4
+      # Assert the server was marked Unknown and pool was cleared exactly once.
+      - name: assertEventCount
+        object: testRunner
+        arguments:
+          event: ServerMarkedUnknownEvent
+          count: 1
+      - name: assertEventCount
+        object: testRunner
+        arguments:
+          event: PoolClearedEvent
+          count: 1
+
+    # Order of operations is non-deterministic so we cannot check events.
+    outcome:
+      collection:
+        data:
+          - {_id: 1}
+          - {_id: 4}